aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* pdf: drawPath should pass the computed matrix, instead of default matrix ↵Gravatar edisonn@google.com2013-10-07
| | | | | | | | | | | | stored in draw. moved cl https://codereview.chromium.org/24265006/ in git repository so I can run the trybots R=vandebo@chromium.org Review URL: https://codereview.chromium.org/25675011 git-svn-id: http://skia.googlecode.com/svn/trunk@11626 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-05
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11625 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add perspective support to SkMatrix44 initializers.Gravatar commit-bot@chromium.org2013-10-05
| | | | | | | | | | | | | | | | | | | | I noticed SkMatrix <-> SkMatrix44 conversions were dropping the perspective values on the floor. As we use SkMatrix44 heavily in Chromium, I'm concerned this missing code will cause a bug eventually. It should be correct to simply use the bottom row of the 4x4 matrix excluding the third column. Previously committed and reverted, second attempt with fix for incorrect use of SkMScalar/SkScalar. BUG= R=reed@google.com, caryclark@google.com Author: aelias@chromium.org Review URL: https://codereview.chromium.org/25484006 git-svn-id: http://skia.googlecode.com/svn/trunk@11624 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Add perspective support to SkMatrix44 initializers."Gravatar aelias@chromium.org2013-10-04
| | | | | | This reverts commit 93db1bcae0863feed8d00a61ae2cf72a90a0083c. git-svn-id: http://skia.googlecode.com/svn/trunk@11623 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add perspective support to SkMatrix44 initializers.Gravatar commit-bot@chromium.org2013-10-04
| | | | | | | | | | | | | | | | | I noticed SkMatrix <-> SkMatrix44 conversions were dropping the perspective values on the floor. As we use SkMatrix44 heavily in Chromium, I'm concerned this missing code will cause a bug eventually. It should be correct to simply use the bottom row of the 4x4 matrix excluding the third column. BUG= R=reed@google.com Author: aelias@chromium.org Review URL: https://codereview.chromium.org/25484006 git-svn-id: http://skia.googlecode.com/svn/trunk@11622 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use vertexless shaders when NVpr is availableGravatar commit-bot@chromium.org2013-10-04
| | | | | | | | | | | | | | | | Adds support for vertexless shaders and enables them when NV_path_rendering is available. This takes a GrGLFragmentOnlyShaderBuilder class, a GrGLTexGenEffectArray class, support for setting TexGen and the projection matrix in GrGpuGL, and code for setting the GL fixed function state where necessary. R=bsalomon@google.com, kkinnunen@nvidia.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/25846002 git-svn-id: http://skia.googlecode.com/svn/trunk@11620 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline angle gradient changesGravatar bsalomon@google.com2013-10-04
| | | | | | Review URL: https://codereview.chromium.org/25666017 git-svn-id: http://skia.googlecode.com/svn/trunk@11618 2bbb7eff-a529-9590-31e7-b0007b416f81
* Mutex protect SkFontMgr_DirectWrite cache.Gravatar bungeman@google.com2013-10-04
| | | | | | | | | | | SkFontMgr_DirectWrite is constant, except for its typeface cache. Protect this cache in the face of multiple threads. R=robertphillips@google.com Review URL: https://codereview.chromium.org/26023002 git-svn-id: http://skia.googlecode.com/svn/trunk@11615 2bbb7eff-a529-9590-31e7-b0007b416f81
* commit to xfermode objects being immutableGravatar commit-bot@chromium.org2013-10-04
| | | | | | | | | | | BUG= R=djsollen@google.com, mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/25968004 git-svn-id: http://skia.googlecode.com/svn/trunk@11614 2bbb7eff-a529-9590-31e7-b0007b416f81
* When cache is full delay flush until GrContext draw is finishedGravatar commit-bot@chromium.org2013-10-04
| | | | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/25673004 git-svn-id: http://skia.googlecode.com/svn/trunk@11613 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move VertexBuilder to a GrGLFullShaderBuilder subclassGravatar commit-bot@chromium.org2013-10-04
| | | | | | | | | | | | | | | | | | | Removes the VertexBuilder nested class from GrGLShaderBuilder in favor of a new GrGLFullShaderBuilder subclass, and adds an optional emitCode overload to GrGLEffect that takes a GrGLFullShaderBuilder. Makes setData virtual in GrGLEffectArray and adds a GrGLVertexEffectArray subclass that gets built using a GrGLFullShaderBuilder. Also adds a new GrGLVertexEffect subclass that makes the GrGLFullShaderBuilder overload required for emitCode, and updates GrGLEffects to inherit from GrGLVertexEffect where needed. R=bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/25474006 git-svn-id: http://skia.googlecode.com/svn/trunk@11612 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to trigger build after several buildbot-side changesGravatar borenet@google.com2013-10-04
| | | | | | | | | | | https://codereview.chromium.org/25437010/ (Skip WritePixels test on Xoom) https://codereview.chromium.org/25820003/ (Use --resetGpuContext flag when running GM on Xoom) https://codereview.chromium.org/25666016/ (Remove --nopdf flag from GM on Android) https://codereview.chromium.org/26005002/ (Increase Compile timeout) Review URL: https://codereview.chromium.org/25421004 git-svn-id: http://skia.googlecode.com/svn/trunk@11611 2bbb7eff-a529-9590-31e7-b0007b416f81
* Don't access RT when disabling scissor.Gravatar commit-bot@chromium.org2013-10-04
| | | | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/25446004 git-svn-id: http://skia.googlecode.com/svn/trunk@11608 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add GM option to allow the GPU context to be reset prior to each GM being runGravatar djsollen@google.com2013-10-04
| | | | | | | | | BUG=skia:1434 R=bsalomon@google.com Review URL: https://codereview.chromium.org/26010002 git-svn-id: http://skia.googlecode.com/svn/trunk@11605 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix SkScalar conversion warning error.Gravatar halcanary@google.com2013-10-04
| | | | | | | | | | This was causing probems on the Win build. R=caryclark@google.com Review URL: https://codereview.chromium.org/26011002 git-svn-id: http://skia.googlecode.com/svn/trunk@11604 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove rebaselined tests from ignored-tests.txtGravatar bsalomon@google.com2013-10-04
| | | | | | Review URL: https://codereview.chromium.org/26014002 git-svn-id: http://skia.googlecode.com/svn/trunk@11603 2bbb7eff-a529-9590-31e7-b0007b416f81
* Mark images with busted concial gradients as ignore failure on N10, N4, and RHBGravatar bsalomon@google.com2013-10-04
| | | | | | Review URL: https://codereview.chromium.org/25968005 git-svn-id: http://skia.googlecode.com/svn/trunk@11602 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline gradient gpu testsGravatar bsalomon@google.com2013-10-04
| | | | | | Review URL: https://codereview.chromium.org/25757010 git-svn-id: http://skia.googlecode.com/svn/trunk@11601 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix iOS build of test_image_decoderGravatar halcanary@google.com2013-10-04
| | | | | | | | Use tool_main() function. Review URL: https://codereview.chromium.org/26008002 git-svn-id: http://skia.googlecode.com/svn/trunk@11600 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix narrowing warning errorGravatar halcanary@google.com2013-10-04
| | | | | | | | I was breaking build, by having a char instead of unsigned char. Review URL: https://codereview.chromium.org/25683012 git-svn-id: http://skia.googlecode.com/svn/trunk@11599 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make image decoding more fault resistant, less verbose.Gravatar halcanary@google.com2013-10-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change address what happens when a jpeg is partially downloaded before failing. Many browsers will render it anyway: we want Skia to do the same. The JpegTest takes a perfectly cromulent jpeg file and only passes into the ImageDecoder the first half of the image. We then verify that the image decoder returns a valid bitmap of the correct dimensions. We also fixed some png library errors, including issue 1691. Also, suppressed the majority of warnings from using libpng and libjpeg. By default, most warnings are *not* suppressed in debug mode. If you have a debug binary and wish to suppress warnings, set the following environment variables to true skia_images_png_suppressDecoderWarnings skia_images_jpeg_suppressDecoderWarnings or from within a program that links to Skia: #if defined(SK_DEBUG) #include "SkRTConf.h" SK_CONF_SET("images.jpeg.suppressDecoderWarnings", true); SK_CONF_SET("images.png.suppressDecoderWarnings", true); #endif I tested this, before (control) and after these changes (test), on 364,295 skps from the cluster telemetry. - number of errors+warnings in control = 2804 - number of errors+warnings fixed = 2283 - number of PNG verbosity fixed = 2152 - number of PNG error fixed = 4 - number of PNG segfault fixed = 3 - number of PNG errors changed to warnings = 62 - number of JPG verbosity fixed = 26 - number of JPG error fixed = 91 Not all errors and warning have been fixed. These numbers were generated using the find_bad_images_in_skps.py program. This program may be useful going forward for testing image-decoding libraries on skp files from the cluster telemetry. find_bad_images_in_skps.py depends on the test_image_decoder program, which simply executes the SkImageDecoder::DecodeFile function and uses its exit status to report success or failure. BUG=skia:1649 BUG=skia:1691 BUG=skia:1680 R=scroggo@google.com Review URL: https://codereview.chromium.org/24449003 git-svn-id: http://skia.googlecode.com/svn/trunk@11597 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-04
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11596 2bbb7eff-a529-9590-31e7-b0007b416f81
* Allow gradient optimization with perspectiveGravatar commit-bot@chromium.org2013-10-04
| | | | | | | | | | | | | | | | | | | | Before, gradients would only interpolate the linear portion of the quadratic equation if there was no perspective. This updates them to do so even in the case that there is perspective. The rearrangement of math causes noise differences in the following gm tests: gradients_no_texture_gpu gradients_view_perspective_gpu gradients_local_perspective_gpu gradients_gpu R=bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/25645006 git-svn-id: http://skia.googlecode.com/svn/trunk@11595 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline for 11592.Gravatar bungeman@google.com2013-10-04
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11594 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ignore the failure of this flaky PDF test.Gravatar scroggo@google.com2013-10-03
| | | | | | | | | | | The Mac 10.6 seems to have a race condition that changes the output. Disable the test to avoid seeing this failure. R=edisonn@google.com Review URL: https://codereview.chromium.org/25887005 git-svn-id: http://skia.googlecode.com/svn/trunk@11593 2bbb7eff-a529-9590-31e7-b0007b416f81
* Snap GDI matrix when snapping height.Gravatar bungeman@google.com2013-10-03
| | | | | | | | | | | | | When using GDI to render, ensure that the GDI matrix does not attempt to add subpixel height. This ensures that rotated text is always the same height as axis aligned text and prevents subpixel drift metrics when they are unwanted. R=reed@google.com Review URL: https://codereview.chromium.org/25739002 git-svn-id: http://skia.googlecode.com/svn/trunk@11592 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use SkPicture::ExtractBitmap callback in pdf too, there is no need for a ↵Gravatar commit-bot@chromium.org2013-10-03
| | | | | | | | | | | | specialized function pointer for pdf only only to pass a rectangle, when we can use subseted bitmaps. R=scroggo@google.com, reed@google.com, vandebo@chromium.org, bsalomon@google.com Author: edisonn@google.com Review URL: https://codereview.chromium.org/25054002 git-svn-id: http://skia.googlecode.com/svn/trunk@11591 2bbb7eff-a529-9590-31e7-b0007b416f81
* update GM to use #ifdef instead of just #ifGravatar djsollen@google.com2013-10-03
| | | | | | Review URL: https://codereview.chromium.org/25749003 git-svn-id: http://skia.googlecode.com/svn/trunk@11590 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fixes for decoding to A8.Gravatar commit-bot@chromium.org2013-10-03
| | | | | | | | | | | | | | | | | | | | | | | | src/images/SkImageDecoder_libpng.cpp: A8 images are not opaque, so do not set the opaque flag. This fixes a bug where copyTo does not work as expected (when copying an A8 decoded image to ARGB_8888), leading to a bitmap hash that does not represent the image correctly (in skimage). tools/skimage_main.cpp: In write_bitmap, which is creating the image for visual comparison, copy A8 to 8888, since A8 cannot be encoded. In the section that tests reencoding, do not test reencoding A8, which is known to not work. R=mtklein@google.com, djsollen@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/25726004 git-svn-id: http://skia.googlecode.com/svn/trunk@11589 2bbb7eff-a529-9590-31e7-b0007b416f81
* Repurpose GrGLCoordTransform as GrGLProgramEffectsGravatar commit-bot@chromium.org2013-10-03
| | | | | | | | | | | | | | Creates a GrGLProgramEffects class that the GrGLProgram uses to manage an array of effects. This gives us enough abstraction for the program to cleanly handle different types of coord transforms. R=bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/25605008 git-svn-id: http://skia.googlecode.com/svn/trunk@11588 2bbb7eff-a529-9590-31e7-b0007b416f81
* Mark shifty hairmodes on N10 as ignore-failureGravatar bsalomon@google.com2013-10-03
| | | | | | | | BUG=skia:1655 Review URL: https://codereview.chromium.org/25524003 git-svn-id: http://skia.googlecode.com/svn/trunk@11587 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update PDF backend to support fallback fonts on Android.Gravatar djsollen@google.com2013-10-03
| | | | | | | | R=edisonn@google.com, reed@google.com, vandebo@chromium.org Review URL: https://codereview.chromium.org/24364008 git-svn-id: http://skia.googlecode.com/svn/trunk@11586 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-03
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11585 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix font GMsGravatar jvanverth@google.com2013-10-02
| | | | | | | | | | Disables font cache dump for now R=robertphillips@google.com Review URL: https://codereview.chromium.org/25605007 git-svn-id: http://skia.googlecode.com/svn/trunk@11584 2bbb7eff-a529-9590-31e7-b0007b416f81
* HTTP GM baseline viewer: server should serve files from gm/rebaseline_server dirGravatar epoger@google.com2013-10-02
| | | | | | | | | | (SkipBuildbotRuns) R=jcgregorio@google.com Review URL: https://codereview.chromium.org/25774002 git-svn-id: http://skia.googlecode.com/svn/trunk@11583 2bbb7eff-a529-9590-31e7-b0007b416f81
* More improvements to HTTP baseline viewer (for GM results)Gravatar epoger@google.com2013-10-02
| | | | | | | | | | (SkipBuildbotRuns) R=borenet@google.com, bsalomon@google.com Review URL: https://codereview.chromium.org/25555003 git-svn-id: http://skia.googlecode.com/svn/trunk@11581 2bbb7eff-a529-9590-31e7-b0007b416f81
* Added missing SK_APIGravatar sugoi@google.com2013-10-02
| | | | | | | | | BUG= R=senorblanco@chromium.org Review URL: https://codereview.chromium.org/25770002 git-svn-id: http://skia.googlecode.com/svn/trunk@11580 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add support to dump font cache texture for debug purposesGravatar commit-bot@chromium.org2013-10-02
| | | | | | | | | | R=robertphillips@google.com, bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/25736002 git-svn-id: http://skia.googlecode.com/svn/trunk@11579 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move makeSpace and resetToSize from SkPathRef.cpp to .hGravatar robertphillips@google.com2013-10-02
| | | | | | | | https://codereview.chromium.org/25754002/ git-svn-id: http://skia.googlecode.com/svn/trunk@11578 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add new skyline RectanizerGravatar commit-bot@chromium.org2013-10-02
| | | | | | | | | | | | | | | | | | | The skyline Rectanizer tracks the leading silhouette of the currently packed rects and tries to fit the next rectangle on top of that. This gives slightly better packing behavior than the current log2 scheme. Also shrank the size of the plots, which increases their number from 18 to 32 and gives better cache behavior (fewer purges and uploads). R=bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/25584002 git-svn-id: http://skia.googlecode.com/svn/trunk@11577 2bbb7eff-a529-9590-31e7-b0007b416f81
* Threads can race to be the first one to calculate the empty path ref's bounds.Gravatar commit-bot@chromium.org2013-10-02
| | | | | | | | | | | | | | | | | | | | | | | | To dodge the problem, call computeBounds when creating the global empty path ref. There's still another race here, which is that we can race to create the empty path ref in the first place. As written we can conceivably allocate an arbitrary number of empty path refs, one of which ends up pointed to by the global variable at the end. I've punted on fixing this for now because 1) tsan has not complained yet; 2) I think it can be fixed by the same approach as we can fix the memsets in 25415003, so I want to wait to see how that review goes first. BUG= R=reed@google.com, robertphillips@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/25745003 git-svn-id: http://skia.googlecode.com/svn/trunk@11576 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make it explicit that some validate methods are debug onlyGravatar robertphillips@google.com2013-10-02
| | | | | | | | https://codereview.chromium.org/25716003/ git-svn-id: http://skia.googlecode.com/svn/trunk@11575 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sadly TSAN still reports this as a race, even when we're obviously writing theGravatar commit-bot@chromium.org2013-10-02
| | | | | | | | | | | | | same values. Initializing with the declaration should quiet it down. BUG= R=caryclark@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/25713004 git-svn-id: http://skia.googlecode.com/svn/trunk@11574 2bbb7eff-a529-9590-31e7-b0007b416f81
* Do not convert non gray PNG to A8.Gravatar scroggo@google.com2013-10-02
| | | | | | | | | | | | If the user requested A8, but the source is not gray, switch to ARGB8888. BUG=https://b.corp.google.com/issue?id=9189955 R=reed@google.com Review URL: https://codereview.chromium.org/24882002 git-svn-id: http://skia.googlecode.com/svn/trunk@11573 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix 10.6Gravatar caryclark@google.com2013-10-02
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11572 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix gpu.gypi missing file issueGravatar bsalomon@google.com2013-10-02
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11571 2bbb7eff-a529-9590-31e7-b0007b416f81
* path ops work in progressGravatar caryclark@google.com2013-10-02
| | | | | | | | | | | | make more skps work remove edit files BUG= Review URL: https://codereview.chromium.org/23542056 git-svn-id: http://skia.googlecode.com/svn/trunk@11570 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make GPU coord transforms automaticGravatar bsalomon@google.com2013-10-02
| | | | | | | | | | | | | Adds a GrCoordTransform class and updates the framework to handle coord transforms similar to how it handles textures with GrTextureAccess. Renames GrGLEffectMatrix to GrGLCoordTransform and slightly repurposes it to be used by the framework instead of effects. R=bsalomon@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/24853002 git-svn-id: http://skia.googlecode.com/svn/trunk@11569 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to test CQ emails.Gravatar commit-bot@chromium.org2013-10-02
| | | | | | | | | | | | | BUG= NOTRY=True R=borenet@google.com TBR=borenet@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/25712003 git-svn-id: http://skia.googlecode.com/svn/trunk@11567 2bbb7eff-a529-9590-31e7-b0007b416f81
* Empty implementations for SkImageDecoder.Gravatar scroggo@google.com2013-10-01
| | | | | | | | | | | | | Add constructor and destructor, so SkScaledBitmapSampler's DummyDecoder has no unresolved symbols in Chrome. Fixes our Chrome canary. Unreviewed. Review URL: https://codereview.chromium.org/25536004 git-svn-id: http://skia.googlecode.com/svn/trunk@11566 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 11:03:51 +0000