aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Add test_skia.py, isolates for test_skia, images, skpsGravatar borenet2016-02-29
| | | | | | | | | | This enables running DM through Swarming. NOTRY=true BUG=skia:4763 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1743113003 Review URL: https://codereview.chromium.org/1743113003
* A bit more privacy for SkiaServe's RequestGravatar joshualitt2016-02-29
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1741043003 Review URL: https://codereview.chromium.org/1741043003
* Add abilitly to query audit trail for batches by draw opGravatar joshualitt2016-02-29
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745513002 Review URL: https://codereview.chromium.org/1745513002
* move drawextrapatheffect header into animatorGravatar reed2016-02-28
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1747753002 TBR=caryclark@google.com Review URL: https://codereview.chromium.org/1747753002
* Update SKP versionGravatar update-skps2016-02-28
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1742243002 Review URL: https://codereview.chromium.org/1742243002
* remove unused view helpersGravatar reed2016-02-27
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744043002 TBR= Review URL: https://codereview.chromium.org/1744043002
* update CMakeLists for views/aminated removalGravatar reed2016-02-27
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1749483002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot NOTRY=True TBR= Review URL: https://codereview.chromium.org/1749483002
* remove unused view filesGravatar reed2016-02-27
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745813002 TBR= Review URL: https://codereview.chromium.org/1745813002
* remove unneeded view subclassesGravatar reed2016-02-27
| | | | | | | | | | | | no doubt, more deletes will follow... goodbye old friends BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1740383002 TBR= Review URL: https://codereview.chromium.org/1740383002
* Add catapult to RecreateSKPs bot's PYTHONPATHGravatar rmistry2016-02-27
| | | | | | | | | TBR=borenet BUG=skia:5024 NOTRY=true GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1747623002 Review URL: https://codereview.chromium.org/1747623002
* Revert of Enable RAW codec for Windows (patchset #8 id:140001 of ↵Gravatar mtklein2016-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1738913002/ ) Reason for revert: I don't think there's anything wrong with this per-se, but the 32-bit Windows bots are running out of memory while running these tests now. (You'll see something like c:\0\build\slave\workdir\build\skia\include\core\skbitmap.h:247: fatal error: ""sk_throw"" in the log.) We run these tests in parallel, and sometimes these 32-bit processes try to use more than the 2-3G RAM they can allocate. Seems like this is a particularly memory-intense process? If we reland this, we might want to blacklist these tests on the 32-bit Windows bots. The 64-bit bots should have access to tons and tons of RAM and let us keep testing for Windows. Original issue's description: > Enable RAW codec for Windows > > * Fix the exception catching > * Set preprocessor differently for MSVC > > BUG=skia:4889(b/26958348) > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1738913002 > > Committed: https://skia.googlesource.com/skia/+/474e4c3dd28b67f590851321f15d9983ef7fd031 TBR=scroggo@google.com,msarett@google.com,yujieqin@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4889(b/26958348) Review URL: https://codereview.chromium.org/1747443003
* Revert of Add non-inline SkRTreeFactory constructor to fix clang-cl ↵Gravatar brucedawson2016-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/1676833002/ ) Reason for revert: This workaround should no longer be needed, per comment#16 from thakis@ on the original CL. Original issue's description: > Add non-inline SkRTreeFactory constructor to fix clang-cl > > When Chromium is switched to build with VS 2015 that switches clang-cl > to build in -fmsc-version=1900 mode. This causes some changes in > importing of constructors and vftables which leads to link errors in > blink_platform.dll. Adding a non-inline constructor makes 1900 mode > behave consistently with 1800 mode and avoids the link error. > > The root cause needs investigation but this will unblock the VS 2015 > switch. > > BUG=440500,498544 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676833002 > > Committed: https://skia.googlesource.com/skia/+/964eec67760196585954203ba625e440607f7e92 TBR=reed@google.com,bsalomon@google.com,mtklein@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=440500,498544 Review URL: https://codereview.chromium.org/1739363002
* DM: dm.json can be missing some final resultsGravatar mtklein2016-02-26
| | | | | | | | | | | | | | We called JsonWriter::DumpJson() every once in a while, but this did not necssarily wait for offloaded PNG encoding to finish. This means we might have been dropping some DM results for a while now. Fix by one more JsonWriter::DumpJson() call after joining back to the main thread. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1744723002 Review URL: https://codereview.chromium.org/1744723002
* DM: support --config {f16,srgb}Gravatar mtklein2016-02-26
| | | | | | | | | | | | Will need to follow up with enabling f16 and srgb configs. They're still assert-y. The GMs 'gamma' and 'gradients' look reassuringly good on f16 and srgb backends. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711143002 Review URL: https://codereview.chromium.org/1711143002
* Switch float arrays to vecs for conical gradientsGravatar jvanverth2016-02-26
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745613002 Review URL: https://codereview.chromium.org/1745613002
* Creating functions for uploading a mipmapped texture.Gravatar cblume2016-02-26
| | | | | | | BUG=476416 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1249543003 Review URL: https://codereview.chromium.org/1249543003
* Make GrVkStencilAttachment derive form GrVkImageGravatar egdaniel2016-02-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1735283004 Review URL: https://codereview.chromium.org/1735283004
* Fix memory crash in vulakn writeUniformBuffersGravatar egdaniel2016-02-26
| | | | | | | BUG=skia:5021 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737593005 Review URL: https://codereview.chromium.org/1737593005
* Replace fWillReadFragmentPosition with a bitfieldGravatar cdalton2016-02-26
| | | | | | | | | | | | Replaces fWillReadFragmentPosition on GrProcessor with a "RequiredFeatures" bitfield. This will allow us to add additional built-in features. Completely removes information about reading the fragment position from GrPipeline and GrProcOptInfo. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734163002 Review URL: https://codereview.chromium.org/1734163002
* New GM that exercises gamma-correctness in various parts of the pipeline.Gravatar brianosman2016-02-26
| | | | | | | | | | | | | | | | | | | | | | | | Attempts to render 50% grey through many different techniques. Only the first one (black/white dither) is guaranteed to be correct. This serves as ground-truth for all the others (independent of whatever your display may or may not be doing when viewing the output of the GM). Current tests: - Texture bilerp - Texture scale (ie mipmaps) - Simple paint color - Gradient - A handful of Xfer modes - 50% grey bitmaps, both linear and sRGB - Bitmaps wrapped in shaders, which hits a different raster code path TODO: - Test coverage (rather than alpha)? - Text, Blur, etc...? Re-landing this without the blitter selection change, which may have caused a regression. Also updated the text color so it's legible against both black (SampleApp) and white (gold). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1740213003 Review URL: https://codereview.chromium.org/1740213003
* Include glGetMultisamplefv APIGravatar cdalton2016-02-26
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1720963002 Committed: https://skia.googlesource.com/skia/+/69c1b24bcaa7cffd59753a75a7f3d155696fcac4 Review URL: https://codereview.chromium.org/1720963002
* When a surface is backed by an external render target force a copy on image snapGravatar bsalomon2016-02-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1694943002 Review URL: https://codereview.chromium.org/1694943002
* Add back Vk files with LF endingsGravatar jvanverth2016-02-26
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1745433002 Review URL: https://codereview.chromium.org/1745433002
* Revert of New GM that exercises gamma-correctness in various parts of the ↵Gravatar brianosman2016-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | pipeline. (patchset #4 id:60001 of https://codereview.chromium.org/1734983003/ ) Reason for revert: Testing revert to fix MacMini? Original issue's description: > New GM that exercises gamma-correctness in various parts of the pipeline. > > Attempts to render 50% grey through many different techniques. Only the first one (black/white dither) is guaranteed to be correct. This serves as ground-truth for all the others (independent of whatever your display may or may not be doing when viewing the output of the GM). > > Current tests: > - Texture bilerp > - Texture scale (ie mipmaps) > - Simple paint color > - Gradient > - A handful of Xfer modes > - 50% grey bitmaps, both linear and sRGB > > Also includes a bug-fix for sRGB -> Linear bitmap case > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734983003 > > Committed: https://skia.googlesource.com/skia/+/9f73a71eec0eb54783f2dcad009aae6aafbe38d5 TBR=bsalomon@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1744533002
* Remove Vk files with spurious CRLFsGravatar jvanverth2016-02-26
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726403007 Review URL: https://codereview.chromium.org/1726403007
* Make GrRRectBlurEffect::onIsEqual include the roundrect's rectGravatar robertphillips2016-02-26
| | | | | | | BUG=skia:5014 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1743553003 Review URL: https://codereview.chromium.org/1743553003
* Get SkiaServe Request started off with a little privacyGravatar joshualitt2016-02-26
| | | | | | | | | | This CL moves the surface stuff into the request object so it can maintain its internal state consistently BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1741823002 Review URL: https://codereview.chromium.org/1741823002
* Fix oval rendering in vulkanGravatar egdaniel2016-02-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1739063002 Review URL: https://codereview.chromium.org/1739063002
* SkPDF/Test: detailed error messages in PDFDeflateWStreamTestGravatar halcanary2016-02-26
| | | | | | | BUG=skia:5009 TBR= Review URL: https://codereview.chromium.org/1727153005
* Wire up /batches in skiaserveGravatar joshualitt2016-02-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737323002 Review URL: https://codereview.chromium.org/1737323002
* Fix uniform buffer layout in vulkanGravatar egdaniel2016-02-26
| | | | | | | | | TBR=jvanverth@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734403002 Review URL: https://codereview.chromium.org/1734403002
* Add batchlist managment to GrAuditTrailGravatar joshualitt2016-02-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1724243004 Review URL: https://codereview.chromium.org/1724243004
* Add VkProgramDataManager back into to repoGravatar egdaniel2016-02-26
| | | | | | | | | | | Confirmed that this is concidered a plain ASCII file with no CR TBR=jvanverth@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1743593002 Review URL: https://codereview.chromium.org/1743593002
* New GM that exercises gamma-correctness in various parts of the pipeline.Gravatar brianosman2016-02-26
| | | | | | | | | | | | | | | | | | | Attempts to render 50% grey through many different techniques. Only the first one (black/white dither) is guaranteed to be correct. This serves as ground-truth for all the others (independent of whatever your display may or may not be doing when viewing the output of the GM). Current tests: - Texture bilerp - Texture scale (ie mipmaps) - Simple paint color - Gradient - A handful of Xfer modes - 50% grey bitmaps, both linear and sRGB Also includes a bug-fix for sRGB -> Linear bitmap case BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734983003 Review URL: https://codereview.chromium.org/1734983003
* Try to fix broken file by just deleting it.Gravatar egdaniel2016-02-26
| | | | | | | | | | | Will try re uploading fixed version after. TBR=jvanverth@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737763003 Review URL: https://codereview.chromium.org/1737763003
* Enable RAW codec for WindowsGravatar yujieqin2016-02-26
| | | | | | | | | | * Fix the exception catching * Set preprocessor differently for MSVC BUG=skia:4889(b/26958348) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1738913002 Review URL: https://codereview.chromium.org/1738913002
* add gm to illustrate bugGravatar caryclark2016-02-26
| | | | | | | | TBR=reed@google.com BUG=skia:517 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734343004 Review URL: https://codereview.chromium.org/1734343004
* fix undefined signed shiftsGravatar caryclark2016-02-26
| | | | | | | | | | | | | The expression (1 << 31) is technically undefined. Fixed the undefined shift referenced by this bug and a few friends. R=reed@google.com BUG=skia:2285 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737363002 Review URL: https://codereview.chromium.org/1737363002
* Revert of Skia Filter Quality and Scaling Metrics (patchset #3 id:60001 of ↵Gravatar ericrk2016-02-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1686203002/ ) Reason for revert: reverting this to address Ilya's comments. Original issue's description: > Skia Filter Quality and Scaling Metrics > > Adds histogram metrics to log the filter quality and scale factor of > each image draw. To make the data easier to consume, this is broken > down into a number of individual histograms: > - Filter quality across all draw calls > - Scale amount across all draw calls > - Scale amount per filter quality (4 histograms total) > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686203002 > > Committed: https://skia.googlesource.com/skia/+/f57b3a6e4a002caf01378832cbd756c6c163a783 TBR=bsalomon@google.com,isherman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1735423002
* SkPDF: Let client re-encode JPGs if they want toGravatar halcanary2016-02-25
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734223003 Review URL: https://codereview.chromium.org/1734223003
* Fix createTexture calls in vk testsGravatar egdaniel2016-02-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737343002 Review URL: https://codereview.chromium.org/1737343002
* Revert of Make GrDrawContext::internalDrawPath cons up its own ↵Gravatar ethannicholas2016-02-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GrPipelineBuilder (patchset #3 id:40001 of https://codereview.chromium.org/1730903007/ ) Reason for revert: Got a GL-related crash in nanobench: https://uberchromegw.corp.google.com/i/client.skia.android/builders/Perf-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release/builds/3815/steps/nanobench/logs/stdio Given we're about to branch and this is the only GL-related change in the blamelist, I'm going to assume this is responsible and revert. Original issue's description: > Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder > > Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. > > TBR=bsalomon@google.com > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730903007 > > Committed: https://skia.googlesource.com/skia/+/00fddebe56fabea67dcc08762805c1294eebf5bf TBR=joshualitt@chromium.org,bsalomon@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1737373002
* Fix copy-paste typo in comment.Gravatar brianosman2016-02-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734613005 Review URL: https://codereview.chromium.org/1734613005
* 4f gradient negative-dx interval fixup for kMirror_TileModeGravatar fmalita2016-02-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | 4f intervals are meant to be monotonically increasing in X. This means we invert the point order when dx < 0: [0...1) -> (1...0] For kMirror_TileMode, we also append a duplicate/flipped interval sequence and expand the range to 2: [0...1) -> [0...1)[1...2) When dx < 0, the current logic yields (1...0] -> (1...0](2...1] which violates the interval monotonicity. To achieve the proper order, we need to swap the two halves: (1...0] -> (1...0](2...1] -> (2...1](1...0] R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1735773003 Review URL: https://codereview.chromium.org/1735773003
* Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilderGravatar robertphillips2016-02-25
| | | | | | | | | | Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730903007 Review URL: https://codereview.chromium.org/1730903007
* Check scalar to fixed conversions with axes.Gravatar benjaminwagner2016-02-25
| | | | | | | | | | In SkTypeface_FreeType::Scanner::computeAxisValues, check for out-of-range values before converting to SkFixed. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709403003 Review URL: https://codereview.chromium.org/1709403003
* Fully check basis vectors for extent degeneracy.Gravatar bungeman2016-02-25
| | | | | | | | | | | | The test for 'nearly singular matrix' in SkScalerContext::computeMatrices is actually a check to see if anything will draw. Unfortunately, the current test only checks when the a skew causes nothing to draw. This adds the check for when the scale causes nothing to draw. BUG=skia:4998 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1735613002 Review URL: https://codereview.chromium.org/1735613002
* Move urlhandlers out of skiaserve.cppGravatar joshualitt2016-02-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737643003 Review URL: https://codereview.chromium.org/1737643003
* Skia Filter Quality and Scaling MetricsGravatar ericrk2016-02-25
| | | | | | | | | | | | | | Adds histogram metrics to log the filter quality and scale factor of each image draw. To make the data easier to consume, this is broken down into a number of individual histograms: - Filter quality across all draw calls - Scale amount across all draw calls - Scale amount per filter quality (4 histograms total) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686203002 Review URL: https://codereview.chromium.org/1686203002
* Deduplicate axis value resolving code.Gravatar bungeman2016-02-25
| | | | | | | | | | | The code was originally written for Android, but is now implemented more generally by the FreeType scanner to be shared between all FreeType backed typefaces. This removes the now duplicate code in the Android font manager and uses the shared code instead. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1726213004 Review URL: https://codereview.chromium.org/1726213004