aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Ensure that we use different glyph entries for regular and df text.Gravatar jvanverth2015-03-19
| | | | | | | | | | Currently if we switch between regular text and df text while using the same GrContext, they may use the same entry in the Ganesh font cache, which is incorrect. This change ensures that they will have different entries. Committed: https://skia.googlesource.com/skia/+/8dc58edd71c11f232860724dfa3b566895478034 Review URL: https://codereview.chromium.org/1020593003
* Run CodecSrc DM.Gravatar scroggo2015-03-19
| | | | | | | | | | | Rather than making SkCodec an option instead of SkImageDecoder, create a separate CodecSrc. This allows us to compare the two. For both CodecSrc and ImageSrc, do not decode to a gpu backend. BUG=skia:3475 Review URL: https://codereview.chromium.org/978823002
* Revert of replace SkFixedDiv impl with native 64bit math (patchset #2 ↵Gravatar reed2015-03-19
| | | | | | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/1022543003/) Reason for revert: http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53096 layouttests failures Original issue's description: > replace SkFixedDiv impl with native 64bit math > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/7c44ca926bf42b3b2e56131f250c0fd58f87ac71 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1018523008
* remove unused SkXRay functionsGravatar reed2015-03-18
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1016263002
* replace SkFixedDiv impl with native 64bit mathGravatar reed2015-03-18
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1022543003
* Revert of Ensure that we use different glyph entries for regular and df ↵Gravatar jvanverth2015-03-18
| | | | | | | | | | | | | | | | | | | | | | | text. (patchset #2 id:20001 of https://codereview.chromium.org/1020593003/) Reason for revert: Bad glyphs in dftext GM. Original issue's description: > Ensure that we use different glyph entries for regular and df text. > > Currently if we switch between regular text and df text while using > the same GrContext, they may use the same entry in the Ganesh font cache, > which is incorrect. This change ensures that they will have different entries. > > Committed: https://skia.googlesource.com/skia/+/8dc58edd71c11f232860724dfa3b566895478034 TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1011403005
* Ensure that we use different glyph entries for regular and df text.Gravatar jvanverth2015-03-18
| | | | | | | | Currently if we switch between regular text and df text while using the same GrContext, they may use the same entry in the Ganesh font cache, which is incorrect. This change ensures that they will have different entries. Review URL: https://codereview.chromium.org/1020593003
* temporarily stifle Math test on TSAN botGravatar mtklein2015-03-18
| | | | | | BUG=skia:3562 Review URL: https://codereview.chromium.org/1017283002
* Remove recent changes to use temp fbo to do stencil clears.Gravatar egdaniel2015-03-18
| | | | | | | | | | | | | In order to implement these stencil clears we had to use a work around where we would bind a color buffer renderbuffer to the fbo before clearing the stencil buffer. However this workaround seems to cause the win 7 hd2000 machines to all crash on some memory access issue. For now we will comment on the change and go back to the old world BUG=skia: Review URL: https://codereview.chromium.org/1015223002
* Bump picture version for uniqueID-less SkImageFilter.Gravatar senorblanco2015-03-18
| | | | | | | | Remove writing of the uniqueID, and put reading behind a version check. BUG=skia:3559 Review URL: https://codereview.chromium.org/1010433003
* Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #17 id:320001 ↵Gravatar egdaniel2015-03-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/949263002/) Reason for revert: Perf regression on win8 hd7700 gpu skps Original issue's description: > Improve tracking of bound FBOs in GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 > > Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 > > Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef > > Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac > > Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88 > > Committed: https://skia.googlesource.com/skia/+/160f24ce0e8d6dd7ca80b78871e063d4f4609cfb TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1009563003
* Do not create empty color table if it does not existGravatar msarett2015-03-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1019543003
* Add Load2/store2 to Sk4x (dumb impl for now)Gravatar reed2015-03-18
| | | | | | | | patch from issue 1001003002 at patchset 1 (http://crrev.com/1001003002#ps1) BUG=skia: Review URL: https://codereview.chromium.org/1001453006
* Remove uniqueID from all filter serialization.Gravatar senorblanco2015-03-18
| | | | | | | | | | | | (This is essentially a revert of https://codereview.chromium.org/503833002/.) This was necessary back when SkPaint was flattened even for in-process use. Now that we only flatten SkPaint for cross-process use, there's no need to serialize UniqueIDs. Note: SkDropShadowImageFilter is being constructed with a croprect and UniqueID (of 0) in Blink. I've made the uniqueID param default to 0 temporarily, until this rolls in and Blink can be changed. (Blink can't be changed first, since unlike the other filters, there's no constructor that takes a cropRect but not a uniqueID.) BUG=skia: Review URL: https://codereview.chromium.org/1019493002
* extend neon table as well for gray8Gravatar reed2015-03-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1021583002
* Simple patch to have draw path call an internal drawPathGravatar joshualitt2015-03-18
| | | | | | | | The purpose of this patch is to expose an internal draw path call which text contexts can use. BUG=skia: Review URL: https://codereview.chromium.org/1012143005
* Let's find out what's up with the TSAN bot test failures.Gravatar mtklein2015-03-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1020573002
* Adding swizzles for bmp:Gravatar msarett2015-03-18
| | | | | | | | | | We now support kN32 and kRGB_565 color types. Additionally, we support premul, unpremul, and opaque alpha types. Unpremul is currently untested as we cannot currently draw to unpremul. BUG=skia: Review URL: https://codereview.chromium.org/1013743003
* Update to identically match the sources used on AndroidGravatar djsollen2015-03-18
| | | | Review URL: https://codereview.chromium.org/1020563002
* Implement SkCodec::getScaledDimensions.Gravatar scroggo2015-03-18
| | | | | | Left out of a prior CL since no one was calling it... Review URL: https://codereview.chromium.org/995303004
* SkPMFloat: avoid loads and stores where possible.Gravatar mtklein2015-03-18
| | | | | | | | | | | | | | | | | | | | | | | | | | A store/load pair like this is a redundant no-op: store simd_register_a, memory_address load memory_address, simd_register_a Everyone seems to be good at removing those when using SSE, but GCC and Clang are pretty terrible at this for NEON. We end up issuing both redundant commands, usually to and from the stack. That's slow. Let's not do that. This CL unions in the native SIMD register type into SkPMFloat, so that we can assign to and from it directly, which is generating a lot better NEON code. On my Nexus 5, the benchmarks improve from 36ns to 23ns. SSE is just as fast either way, but I paralleled the NEON code for consistency. It's a little terser. And because it needed the platform headers anyway, I moved all includes into SkPMFloat.h, again only for consistency. I'd union in Sk4f too to make its conversion methods a little clearer, but MSVC won't let me (it has a copy constructor... they're apparently not up to speed with C++11 unrestricted unions). BUG=skia: Review URL: https://codereview.chromium.org/1015083004
* Restore GDI text size rounding.Gravatar bungeman2015-03-18
| | | | | | | | | | | | | | | | | | Add call to SkScalarRoundToScalar(). The old code calculated the scale from the text size, but now the text size is calculated from the scale (which is arguably the right way to think about it). However, the old code always rounded the final resulting text size, while the new code does not. In the 'no hinting' case, the text size is already rounded to an integer (so that the rest of the matrix is minimized). In the 'hinted' case, the entire scale has been removed from the matrix, so the scale value is the 'real' residual size. The old code rounded this size, and the new code should as well. BUG=464784 Review URL: https://codereview.chromium.org/1014953002
* Add comment describing SkColorTable constructor.Gravatar scroggo2015-03-18
| | | | Review URL: https://codereview.chromium.org/1011263002
* Indexed PNG decoding: Ensure color table is large enough that the bit depth ↵Gravatar dml2015-03-18
| | | | | | | | | | | of the image will not allow reads beyond its end. BUG=skia:3440 R=rmistry@google.com, scroggo@google.com Committed: https://skia.googlesource.com/skia/+/493c1ce1cd406ef28683203146274154783452ce Review URL: https://codereview.chromium.org/948163002
* Whitespace change to test new GCE compile botGravatar Ravi Mistry2015-03-18
|
* Display currently running tests as the keepalive message.Gravatar mtklein2015-03-18
| | | | | | | | | | | | | | | | | | | | ... ( 466MB 550) 31.9ms gpu gm colorwheelnative ( 466MB 549) 50.1ms gpu gm colorwheel ( 468MB 548) 512ms gpu gm colortype_xfermodes Currently running: unit test PathOpsRectsThreaded unit test PathOpsSimplifyDegeneratesThreaded unit test PathOpsSimplifyQuadralateralsThreaded gpu gm colortype ( 468MB 547) 90.8ms gpu gm colortype ( 469MB 546) 2.03s unit test PathOpsSimplifyDegeneratesThreaded ... BUG=skia: Review URL: https://codereview.chromium.org/1017903002
* add kGray_8_SkColorTypeGravatar reed2015-03-17
| | | | | | | | | patch from issue 1014783003 at patchset 60001 (http://crrev.com/1014783003#ps60001) BUG=skia: TBR= Review URL: https://codereview.chromium.org/1010343002
* Improve tracking of bound FBOs in GrGLGpu.Gravatar bsalomon2015-03-17
| | | | | | | | | | | | | | Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88 Review URL: https://codereview.chromium.org/949263002
* Use sample count for temp renderbuffer when clearing stenciGravatar Brian Salomon2015-03-17
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1016903002
* DM: disable image src type on Windows.Gravatar mtklein2015-03-17
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1012183002
* Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #16 id:300001 ↵Gravatar bsalomon2015-03-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/949263002/) Reason for revert: locally hit assert. Original issue's description: > Improve tracking of bound FBOs in GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 > > Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 > > Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef > > Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac > > Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88 TBR=egdaniel@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1017803002
* Improve tracking of bound FBOs in GrGLGpu.Gravatar bsalomon2015-03-17
| | | | | | | | | | | | Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac Review URL: https://codereview.chromium.org/949263002
* Add stencil-only clear bug workaround back but for all devices.Gravatar bsalomon2015-03-17
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1010253002
* Current RSS on linux and android too?Gravatar mtklein2015-03-17
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1009313003
* Doc: htmlify roles table to allow easier modificationGravatar halcanary2015-03-17
| | | | | | | | TODO: make sure the table is up to date. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1011753004 Review URL: https://codereview.chromium.org/1011753004
* imagefilters always need to disable lcdGravatar reed2015-03-17
| | | | | | | | This prev CL accidentally stopped forcing (indirectly) the pixel-geometry to unknown. https://codereview.chromium.org/1010503002 BUG=467882 Review URL: https://codereview.chromium.org/1012113002
* Remove SkLONGLONG.Gravatar bungeman2015-03-17
| | | | | | | | | All users now define SkLONGLONG. This fixes a long outstanding TODO now that int64_t is required. BUG=skia:179 Review URL: https://codereview.chromium.org/1000933003
* Revert "Indexed PNG decoding: Ensure color table is large enough that the ↵Gravatar scroggo2015-03-17
| | | | | | | | | | | | | bit depth of the image will not allow reads beyond its end." This reverts commit 493c1ce1cd406ef28683203146274154783452ce. NOTRY=true NOTREECHECKS=true TBR=egdaniel@google.com,dml@google.com BUG=skia: Review URL: https://codereview.chromium.org/1014553003
* Indexed PNG decoding: Ensure color table is large enough that the bit depth ↵Gravatar Leon Scroggins III2015-03-17
| | | | | | | | | of the image will not allow reads beyond its end. BUG=skia:3440 R=rmistry@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/948163002
* Option for SkCodec to treat dst as all zeroes.Gravatar scroggo2015-03-17
| | | | | | | This recreates SkImageDecoder's feature to skip writing zeroes for SkCodec. Review URL: https://codereview.chromium.org/980903002
* Disable GL_MULTISAMPLE when it's not being usedGravatar cdalton2015-03-16
| | | | | | | | | | | | Updates Gr to disable GL_MULTISAMPLE when drawing to an aliased render target. This is an important step for NV_framebuffer_mixed_samples, where just because the color buffer isn't multisampled doesn't mean other stages in the graphics pipeline aren't. It also removes the need for the "isLineDraw" workaround that was in GrGLGpu::flushHWAAState. BUG=skia: Review URL: https://codereview.chromium.org/1002013006
* widen leak supression. looks like start_keepalive is sometimes inlined.Gravatar mtklein2015-03-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1008873003
* Fix build for UCLIBC platformsGravatar smcgruer2015-03-16
| | | | | | | | | malloc_usable_size does not exist in UCLIBC, so fall back to just returning 0 for SkVarAlloc::heap_size(). BUG=skia: Review URL: https://codereview.chromium.org/1006073003
* Move GrAutoLocaleSetter to new file and fix issue with null localeGravatar bsalomon2015-03-16
| | | | | | | TBR=egdaniel@google.com NOTREECHECKS=true Review URL: https://codereview.chromium.org/1002623004
* remove dead codeGravatar reed2015-03-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1016523002
* remove unneeded flagsGravatar reed2015-03-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1010063002
* Fix up some issues introduced by https://codereview.chromium.org/1013773002/Gravatar jvanverth2015-03-16
| | | | | | | | | Need to check for zero-length gradients when using the new correction. Make sure we use the old text sizes for color emoji test in dftext GM. BUG=skia:3540 Review URL: https://codereview.chromium.org/1009973004
* always reset locale (not just in debug).Gravatar Brian Salomon2015-03-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1007283009
* fix ios build wrt locale?Gravatar Brian Salomon2015-03-16
| | | | | | BUG=skia:3330 Review URL: https://codereview.chromium.org/1012773004
* Use C locale for numerics when emitting shaders.Gravatar bsalomon2015-03-16
| | | | | | BUG=skia:3330 Review URL: https://codereview.chromium.org/1012723002