aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix VkWrapTestGravatar Greg Daniel2017-05-02
| | | | | | | | | | Fix current breakage on bots. Bug: skia: Change-Id: I4b60ef85d941a179d76cccc1a468aaa6437caddc Reviewed-on: https://skia-review.googlesource.com/15104 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Blacklist memory intensive images on a botGravatar Leon Scroggins III2017-05-02
| | | | | | | | | | | | Test-Win8-MSVC-Golo-CPU-AVX-x86-Debug is running out of memory running interlaced image decoding tests. Stop running them on this particular bot (others are still running them). For simplicity, also blacklist the RAW images that have had similar problems on other devices. Change-Id: I1071ca2f59ef26b9a9798924f2eefa0483017439 Reviewed-on: https://skia-review.googlesource.com/15074 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Revert "Remove SkLights include from SkCanvas.h"Gravatar Florin Malita2017-05-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9ff301bf918cd85d9f67047f10631b7a74345a90. Reason for revert: need to update G3, Flutter. Original change's description: > Remove SkLights include from SkCanvas.h > > SkLights.h pulls in a bunch of other headers and is not needed (fwdecl > works fine). > > Change-Id: Id2d7176eb3bf4609f72f46d513eebf59318f542f > Reviewed-on: https://skia-review.googlesource.com/14904 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=mtklein@google.com,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I4799ad5b31aaeaf529c8b912bbe09aa8869a5e6c Reviewed-on: https://skia-review.googlesource.com/15107 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Reland "Add a clip mask bench"Gravatar Florin Malita2017-05-02
| | | | | | | | Change-Id: Iefbfd1ecec38d3db5bac4370c75e6701aa03076f TBR=reed@google.com Reviewed-on: https://skia-review.googlesource.com/15102 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Remove SkLights include from SkCanvas.hGravatar Florin Malita2017-05-02
| | | | | | | | | | SkLights.h pulls in a bunch of other headers and is not needed (fwdecl works fine). Change-Id: Id2d7176eb3bf4609f72f46d513eebf59318f542f Reviewed-on: https://skia-review.googlesource.com/14904 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Fix up shadows in raster.Gravatar Jim Van Verth2017-05-02
| | | | | | | | | | | * Re-enable shadow blurs for raster circles and rrects * Fix up the tessellation as much as possible to remove skinny triangles Bug: skia:6425 Change-Id: I6548055084bc8596a052bcd3cec852766e084ba2 Reviewed-on: https://skia-review.googlesource.com/14943 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Make GrBackendTexture take Gr*Info refs in ctor, and copy them.Gravatar Greg Daniel2017-05-02
| | | | | | | | | Bug: skia: Change-Id: Ic05d3384fa07560fc18c52bb8ae03541a72515f7 Reviewed-on: https://skia-review.googlesource.com/14374 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Remove declaration of SkTextureImageSetTexture, which does not existGravatar Brian Osman2017-05-02
| | | | | | | | Bug: skia: Change-Id: Ifb7edcae491ef48fbc69324d9dfb97a298104db9 Reviewed-on: https://skia-review.googlesource.com/15073 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Expose resetForNextPicture in SkNoDrawCanvasGravatar Adrienne Walker2017-05-02
| | | | | | | | | | | | | | | | | | | SkRecorder has some private Skia behavior with the way it handles an SkNoDrawCanvas that is not exposed. In particular, it's able to create an arbitrary SkIRect device clip at construction time. This is a performance optimization when reusing SkNoDrawCanvas across multiple recordings instead of reconstructing a new canvas every time. https://codereview.chromium.org/2768143002 is trying to implement another version of SkPictureBuilder/SkRecorder and so wants to be able to use similar SkNoDrawCanvas behavior. Change-Id: I0ac5f0eef8f0548cefd7354062311667cf448b07 Reviewed-on: https://skia-review.googlesource.com/11320 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* colorspaceinfo tool: Add flag to indicate that the input is an icc profileGravatar Matt Sarett2017-05-02
| | | | | | | | Bug: skia: Change-Id: Ieb5cff92bae1aa64df5bc7f3a398514fe5b20f77 Reviewed-on: https://skia-review.googlesource.com/14956 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Remove legacy pixelref flag from bzlGravatar Matt Sarett2017-05-02
| | | | | | | | | | NOTRY=true Bug: skia:6535 Change-Id: I29d786cef240aaeaca829b4a9a25ff1a8f078588 Reviewed-on: https://skia-review.googlesource.com/15000 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Revert "Remove copyTo() legacy API flag from bzl"Gravatar Ben Wagner2017-05-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 65083e444c03cedecf45bc38bb8fea27e91e0a9e. Reason for revert: Causes build failures. Original change's description: > Remove copyTo() legacy API flag from bzl > > NOTRY=true > > Bug: skia:6464 > Change-Id: Ia3935998960054df9e54cfb2aead66549c629c04 > Reviewed-on: https://skia-review.googlesource.com/15001 > Reviewed-by: Matt Sarett <msarett@google.com> > Commit-Queue: Matt Sarett <msarett@google.com> > TBR=msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I9d82c7b699e106238981e32553e975c91e42cfb8 Reviewed-on: https://skia-review.googlesource.com/15021 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Added A2B support to colorspaceinfo toolGravatar Matt Sarett2017-05-01
| | | | | | | | | | | | | Tool now parses A2B images/profiles. Tool can now display a cross-section based visualization for the color look-up tables in A2B profiles. BUG=skia: Change-Id: I68abb3e947b080c533e283783d7859feea8d35d6 Reviewed-on: https://skia-review.googlesource.com/6119 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Remove copyTo() legacy API flag from bzlGravatar Matt Sarett2017-05-01
| | | | | | | | | | NOTRY=true Bug: skia:6464 Change-Id: Ia3935998960054df9e54cfb2aead66549c629c04 Reviewed-on: https://skia-review.googlesource.com/15001 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Revert "Revert "SaveLayerRec::fClipMask -> raw pointer""Gravatar Mike Klein2017-05-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 3354969a4a4adcea159f3a0b01ad0a7c04fc9115. Reason for revert: not the problem? Original change's description: > Revert "SaveLayerRec::fClipMask -> raw pointer" > > This reverts commit a6b72cb5729306fdd676d739c1e2c53afa0786a7. > > Reason for revert: red bots > > Original change's description: > > SaveLayerRec::fClipMask -> raw pointer > > > > Use raw pointers for optional clip mask plumbing, to match the backdrop > > API. > > > > Change-Id: I7eb0ee5896faf34cc05789ba0703f35a4ab6a4f2 > > Reviewed-on: https://skia-review.googlesource.com/14901 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Florin Malita <fmalita@chromium.org> > > > > TBR=fmalita@chromium.org,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I4387620cdc3410018af9cef221e5cf8d09015380 > Reviewed-on: https://skia-review.googlesource.com/14955 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,reviews@skia.org,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I6dde9e0441928f7a7423139a5c39f520f892f4b5 Reviewed-on: https://skia-review.googlesource.com/14958 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Add a clip mask bench"Gravatar Mike Klein2017-05-01
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c59a38d12dce287427f3d3fe1d4b3ad8052cda35. Reason for revert: whoops, sorry, this one must have been the problem. Original change's description: > Add a clip mask bench > > Change-Id: I230729492fc23e290136f7d62610abe5ca51c067 > Reviewed-on: https://skia-review.googlesource.com/14941 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ifbd74a8985ebaa95e54032aaaa2891b0f1b67940 Reviewed-on: https://skia-review.googlesource.com/14957 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "SaveLayerRec::fClipMask -> raw pointer"Gravatar Mike Klein2017-05-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a6b72cb5729306fdd676d739c1e2c53afa0786a7. Reason for revert: red bots Original change's description: > SaveLayerRec::fClipMask -> raw pointer > > Use raw pointers for optional clip mask plumbing, to match the backdrop > API. > > Change-Id: I7eb0ee5896faf34cc05789ba0703f35a4ab6a4f2 > Reviewed-on: https://skia-review.googlesource.com/14901 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I4387620cdc3410018af9cef221e5cf8d09015380 Reviewed-on: https://skia-review.googlesource.com/14955 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add a clip mask benchGravatar Florin Malita2017-05-01
| | | | | | | Change-Id: I230729492fc23e290136f7d62610abe5ca51c067 Reviewed-on: https://skia-review.googlesource.com/14941 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* SaveLayerRec::fClipMask -> raw pointerGravatar Florin Malita2017-05-01
| | | | | | | | | | Use raw pointers for optional clip mask plumbing, to match the backdrop API. Change-Id: I7eb0ee5896faf34cc05789ba0703f35a4ab6a4f2 Reviewed-on: https://skia-review.googlesource.com/14901 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* finish up constantsGravatar Mike Klein2017-05-01
| | | | | | | | | | | | | | | | | | For whatever reason, if I swap the condition in the if_then_else tests from < to >= and swap the then/else values, I can use constants in hsl_to_rgb. Still don't understand why, but I'll take it. I suspect it has something to do with SSE, IEEE, and NaN, but I don't care enough to speculate any more concretely. This does that, removes C() and _f, updates some comments, and adds a guard in build_stages.py to yell if it sees trouble like LCPI40_4... This reminds me to try -ffast-math soon. I think that was mostly held back by constants. Change-Id: I3f8a37a4d4642f77422ce3261b750061e9e604a3 Reviewed-on: https://skia-review.googlesource.com/14942 Reviewed-by: Herb Derby <herb@google.com>
* refactor hsl_to_rgb a touchGravatar Mike Klein2017-05-01
| | | | | | | | | | | | | | This rewrites the existing logic to expose more of the symmetries, and especially to make them clearly identical subexpressions. I think it's clear that the intent in hue_to_rgb is to wrap the t value back into 0-1... that's t = fract(t). No GM diffs. Change-Id: I9d62d8f80bcb45711ee334f953d3f6410e068ce4 Reviewed-on: https://skia-review.googlesource.com/14940 Reviewed-by: Herb Derby <herb@google.com>
* Update Nexus6p to Android O developer release.Gravatar Ben Wagner2017-05-01
| | | | | | | | No-Try: true Change-Id: I1b39d3548d0979385b24558170fdcd6d766a63bd Reviewed-on: https://skia-review.googlesource.com/14900 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* fix t / t2 confusion in hsl_to_rgbGravatar Mike Klein2017-05-01
| | | | | | | | | | | | | | | | | | | | | | | | I think the original[1] SkRasterPipeline_opts.h version had a typo that I faithfully copied over to hsl_to_rgb. In Hue2RGB[2], the scalar equivalent of hue_to_rgb, we mutate t to keep it in 0-1 range[3]. In the SkRasterPipeline_opts.h code we introduced a new value t2 instead, and then used it everywhere, but accidentally typed 't' in the t < 1/6 case. The expression "p + (q - p)*6.0f*t" should have been "p + (q - p)*6.0f*t2". This fixes things by changing t in place, much like Hue2RGB does. The GM doesn't change anywhere, which is troubling. [1] https://skia-review.googlesource.com/c/7460/21/src/opts/SkRasterPipeline_opts.h#808 [2] https://skia-review.googlesource.com/c/7460/21/src/effects/SkHighContrastFilter.cpp#26 [3] I think this whole clamp should probably become "t = fract(t)". Will follow up. Change-Id: I3dcc1a79ffae46830178d931844ee3113f8bdfd1 Reviewed-on: https://skia-review.googlesource.com/14910 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* getting close on float constantsGravatar Mike Klein2017-05-01
| | | | | | | | | | | | | I think I'm now down to just the constants used in comparisons in hsl_to_rgb... so weird. I don't get what's special about this code. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win7-MSVC-Golo-CPU-AVX-x86_64-Release,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-SK_CPU_LIMIT_SSE41,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-SK_CPU_LIMIT_SSE2 Change-Id: I398139f00371bdbc45281a49bca56d02ba59cba9 Reviewed-on: https://skia-review.googlesource.com/14909 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkFontMgr::matchFamily should not crash on nullptr.Gravatar bungeman2017-05-01
| | | | | | | | | | | | While all systems can resolve a font from just a style request (without a name) almost no systems specify a default font family. BUG=skia:6574 Change-Id: If7c81808b62cd5d8212bce2eb4d9c476c45af80a Reviewed-on: https://skia-review.googlesource.com/14902 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Reed <reed@google.com>
* some float constantsGravatar Mike Klein2017-05-01
| | | | | | | | | | | | Trying to go slowly to find where problems arise. Weirdly, I think I got everything except hsl_to_rgb. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win7-MSVC-Golo-CPU-AVX-x86_64-Release,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-SK_CPU_LIMIT_SSE41,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-SK_CPU_LIMIT_SSE2 Change-Id: I4d85a4c1f40bd87e7cb18fc9b5ce020812dc31db Reviewed-on: https://skia-review.googlesource.com/14905 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Blacklist SkImage_makeTextureImage on NVIDIA Win10 VulkanGravatar Leon Scroggins III2017-05-01
| | | | | | | | Bug: skia:6554 Change-Id: I7c1086ce6afff84c1b1463ec58c2c6a9949aaa2e Reviewed-on: https://skia-review.googlesource.com/14907 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Fix Creation of GrBackendRenderTarget from GrBackendRenderTargetDesc in GLGravatar Greg Daniel2017-05-01
| | | | | | | | Bug: skia: Change-Id: I970e7bc36ae799996f9b28e70f97cb7ce4382eb2 Reviewed-on: https://skia-review.googlesource.com/14906 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Only store width and height on SkPixelRef (last part)Gravatar Matt Sarett2017-05-01
| | | | | | | | | | | | Relanding https://skia-review.googlesource.com/c/14105/ in pieces to try to diagnose problems with the Chrome roll. Bug: skia:6535 Change-Id: Iefe4825b9ce9be999baeec8ab7ae6651f1caf451 Reviewed-on: https://skia-review.googlesource.com/14860 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Blacklist testimgari.jpg on CGGravatar Matt Sarett2017-05-01
| | | | | | | | Bug: skia: Change-Id: I2c471d18f29bb6d0e8ac4a4d0afa1815788bb121 Reviewed-on: https://skia-review.googlesource.com/14825 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Restore legacy SaveLayerRec ctorGravatar Florin Malita2017-05-01
| | | | | | | | | Let's not break existing clients. Change-Id: I056fefefb49d46fb284597c5bcf0319470537524 Reviewed-on: https://skia-review.googlesource.com/14829 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Fix merge conflict.Gravatar Ben Wagner2017-05-01
| | | | | | | | | | | | I accidentally caused a merged conflict between https://skia-review.googlesource.com/14656 and https://skia-review.googlesource.com/14821 No-Try: true Change-Id: Ib00b293019fddc3951a5d413744b9d186dd103d8 Reviewed-on: https://skia-review.googlesource.com/14840 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove unnecessary SkFILEStream::getMemoryBaseGravatar Leon Scroggins III2017-05-01
| | | | | | | | | | It overrides the SkStream:: version, but does the same thing. Change-Id: I857f2119a85bb3f942707ab3cef58b45a2cf4b7a Reviewed-on: https://skia-review.googlesource.com/14828 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Only store width and height on SkPixelRef (part 2)Gravatar Matt Sarett2017-05-01
| | | | | | | | | | | | Relanding https://skia-review.googlesource.com/c/14105/ in pieces to try to diagnose problems with the Chrome roll. Bug: skia:6535 Change-Id: Iada034fc41ef315f7f00984d8de9d9cc2f361ad2 Reviewed-on: https://skia-review.googlesource.com/14657 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Omit shapes_mixed_10000_32x33 on GTX960 ANGLE ReleaseGravatar Ben Wagner2017-05-01
| | | | | | | | | Bug: skia:6534 Change-Id: I5634b35c3a231da8b5714209889921933ca38962 No-Try: true Reviewed-on: https://skia-review.googlesource.com/14656 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Omit HalfFloatAlphaTextureTest on CommandBuffer bot.Gravatar Ben Wagner2017-05-01
| | | | | | | | | Bug: chromium:697030 No-Try: true Change-Id: Ib56c88c384e6b363aefe91c7027fa587d0b000b5 Reviewed-on: https://skia-review.googlesource.com/14648 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add Swarming bot id and task id to recipe expectations.Gravatar Ben Wagner2017-05-01
| | | | | | | | No-Try: true Change-Id: Idd748bf61ab3d6611b85472de5d3f3a25d4ae9ee Reviewed-on: https://skia-review.googlesource.com/14821 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Revert "Plumb the use of GrBackendRenderTarget throughout Skia""Gravatar Greg Daniel2017-05-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e3bd422fafc74dd3410c3de24a576635be92c3b4. Reason for revert: Pre-req changes have all landed in other projects at this point. Original change's description: > Revert "Plumb the use of GrBackendRenderTarget throughout Skia" > > This reverts commit fdd77daedbba3b7c53be74a82fb9fae891b51696. > > Reason for revert: Apparently I have a few more build files to update before this can land. > > Original change's description: > > Plumb the use of GrBackendRenderTarget throughout Skia > > > > Bug: skia: > > Change-Id: Ib99a58d9552f5c7b8d77c09dcc72fa88326c26aa > > Reviewed-on: https://skia-review.googlesource.com/14148 > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I984e1909870182474c4c3cce257f01b6a9d8581f > Reviewed-on: https://skia-review.googlesource.com/14531 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com,reviews@skia.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib7ab94aada8a7cb80fe38f24daf32f9208c5b169 Reviewed-on: https://skia-review.googlesource.com/14826 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Initial clip-mask-layer supportGravatar Florin Malita2017-05-01
| | | | | | | | | | | | | | SkBitmapDevice-only implementation. Will add A8 fast path specializations in a follow-up. Change-Id: I2ccb1ffba3689e92ac90a23e94737471dfb121a1 BUG=skia:6005 Change-Id: I2ccb1ffba3689e92ac90a23e94737471dfb121a1 Reviewed-on: https://skia-review.googlesource.com/14183 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Optimizations for analytic shadows.Gravatar Jim Van Verth2017-05-01
| | | | | | | | | | | | | | | | | Lots of changes here: * Batch circle shadows with rrect shadows * Avoid checking matrix and path conditions twice * Remove lots of checks for 1/2 pixel radii (needed before to force the rrect through the regular GPU path) * Fix scaling effect on ambient blur width * Remove unused flags Bug: skia:6119 Change-Id: If0eb78ec4d19d9f978b19bdbc3a7e558a4db2ed9 Reviewed-on: https://skia-review.googlesource.com/14654 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Update SKP versionGravatar UpdateSKPs2017-04-30
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Ic3ced4cb5f518abc5d1d0611f68fce4b976f5082 Reviewed-on: https://skia-review.googlesource.com/14679 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Remove temporary_internal_describeTopLayerGravatar Florin Malita2017-04-28
| | | | | | | Change-Id: I035b7db84b524be13fb675b75bc402bc9b733cb5 Reviewed-on: https://skia-review.googlesource.com/13803 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* add drawString helper to canvasGravatar Cary Clark2017-04-28
| | | | | | | | | | | | | | | | | | Many tests and examples use drawText with a guess of how long the text is in bytes, or a call to strlen(). Add a helper to SkCanvas to simplify these examples. Add another helper for SkString. R=reed@google.com Change-Id: I0204a31e938f065606f08ee7cd9a6b36db791ee2 Reviewed-on: https://skia-review.googlesource.com/13642 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Cary Clark <caryclark@skia.org>
* Fix bitmap copy gmsGravatar Matt Sarett2017-04-28
| | | | | | | | | | Mark pixels as opaque so copying to 565 continues to work. Bug: skia: Change-Id: Id2b0a8c462fe35f7d1cc2ccc32ca10eda18981c8 Reviewed-on: https://skia-review.googlesource.com/14653 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Only store width and height on SkPixelRef (part 1)Gravatar Matt Sarett2017-04-28
| | | | | | | | | | | | Relanding https://skia-review.googlesource.com/c/14105/ in pieces to try to diagnose problems with the Chrome roll. Bug: skia:6535 Change-Id: Ic321c437ecd3cb7940a48fd73fc22b192804c67a Reviewed-on: https://skia-review.googlesource.com/14650 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Combine GPU flush with semaphore APIGravatar Brian Osman2017-04-28
| | | | | | | | Bug: skia: Change-Id: I5f388760d43b19755b2767d95d32065f6d0f926e Reviewed-on: https://skia-review.googlesource.com/14646 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* remove unused yuv methodsGravatar Mike Reed2017-04-28
| | | | | | | | Bug: skia: Change-Id: Ie1e6c905d8989b49c2cf5c9e5fd1f383268f6480 Reviewed-on: https://skia-review.googlesource.com/14645 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
* change drawAtlas to behave like drawVerticesGravatar Mike Reed2017-04-28
| | | | | | | | | Bug: skia:6571 Change-Id: If60c30755ec0548df0e9bdeca2f3af0bc87764ca Reviewed-on: https://skia-review.googlesource.com/14642 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Only store width and height on SkPixelRef"Gravatar Ben Wagner2017-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2cbb6662e329981840f90ef4edd62f70f69e6030. Reason for revert: Likely cause of Chromium DEPS roll failure; speculative revert. Original change's description: > Only store width and height on SkPixelRef > > Bug: skia:6535 > Change-Id: Id91e8d1e82f593be7d4b23ca5abde752f2666a77 > Reviewed-on: https://skia-review.googlesource.com/14105 > Commit-Queue: Matt Sarett <msarett@google.com> > Reviewed-by: Mike Reed <reed@google.com> > TBR=djsollen@google.com,msarett@google.com,reed@google.com,stani@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I12a024a71833f33432d5ea8cffdfc642b8b4240a Bug: skia: Reviewed-on: https://skia-review.googlesource.com/14644 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Revert "Delete copyTo(Allocator), hide copyTo() behind flag""Gravatar Matt Sarett2017-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0122af08f6af0dee490e1a4f35b552377d0d4753. Reason for revert: Fixed Android callsite Original change's description: > Revert "Delete copyTo(Allocator), hide copyTo() behind flag" > > This reverts commit d4a338f4d0a0cdc08d7d3668931c60997f0fa971. > > Reason for revert: Looks like I missed something I was supposed to delete in Android. > > Original change's description: > > Delete copyTo(Allocator), hide copyTo() behind flag > > > > Replace uses of copyTo() in Skia. > > > > Bug: skia:6464 > > Change-Id: I921dc53a1c29a5176d18f05741f7c0b5a008e548 > > Reviewed-on: https://skia-review.googlesource.com/14502 > > Commit-Queue: Matt Sarett <msarett@google.com> > > Reviewed-by: Mike Reed <reed@google.com> > > > > TBR=msarett@google.com,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I4d252940cc6a2462b030007055ea6c229471fc6e > Reviewed-on: https://skia-review.googlesource.com/14602 > Reviewed-by: Matt Sarett <msarett@google.com> > Commit-Queue: Matt Sarett <msarett@google.com> > TBR=msarett@google.com,reviews@skia.org,reed@google.com Change-Id: I81659a820f79f1958fda23cb62513065b57db99d Reviewed-on: https://skia-review.googlesource.com/14640 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Matt Sarett <msarett@google.com>