aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Promote experimental tryjob to be blocking.Gravatar Ben Wagner2017-11-30
| | | | | | | | | | | | | Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All has been running for a while as an experimental tryjob and seems to be fast enough and useful enough to be a real tryjob. Bug: skia:7229 Change-Id: I7b47be03e7e29a3ef573933ed6c054802e111c80 Reviewed-on: https://skia-review.googlesource.com/78300 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Fix SkInternalAtlasTextContext to update advance the flush token after ↵Gravatar Brian Salomon2017-11-30
| | | | | | | | | | | issuing each draw. This was causing SkAtlasTextTarget:flush() calls beyond the first to skip the uploads of glyphs added to the atlas after the first flush(). Change-Id: I291b88d50629e38914d4b6af21fc25d8a41fbd9d Reviewed-on: https://skia-review.googlesource.com/77584 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add "lazy" texture proxiesGravatar Chris Dalton2017-11-30
| | | | | | | | | | | Adds ultra-deferred proxies that are instantiated by a user-supplied callback during flush. Bug: skia:7190 Change-Id: I75a7ac6dba953c3b0a99febc203a7f4d2f3789fc Reviewed-on: https://skia-review.googlesource.com/76461 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Turn up Nexus10 CPU frequenciesGravatar Kevin Lubick2017-11-30
| | | | | | | | | | | | | | | | | | | | | The previous list was created from scaling_min_freq and scaling_max_freq instead of cpuinfo_min_freq and cpuinfo_max_freq which are the actual mins and maxes, not the current (transient) settings of the governor. Before: Test-Release: 61 minutes Perf-Debug: 41 minutes After: Test-Release: 32 minutes Perf-Debug: 16 minutes NOTRY=true Bug: skia: Change-Id: I9b431e92d2abcecb4fe643389daddc912a1399e1 Reviewed-on: https://skia-review.googlesource.com/78141 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* bug fix in matrix color filterGravatar Mike Klein2017-11-30
| | | | | | | | | | | | | | | | | | | | | | | The current code for this filter premuls, then clamps. We should be clamping, then premulling. If the matrix makes alpha greater than 1, these two orderings can result in different color values. Alpha will clamp to 1 either way, but the color channels are multiplied by that >1 alpha in one case, and by =1 in the other. The left column of the gm imagefilterscropexpand demonstrates this. Its matrix adds 32/255 to alpha and 255/255 to green. This produces alpha ~= 1.12. That's then multiplied by the relatively small red and blue values in the grey checkerboard, resulting in different in-range values than the ones we would have gotten if we clamped alpha first. Green wasn't affected because it was already fully saturated. 255 * 1.12 == 255 no matter when we clamp. Change-Id: I4b30bf64c30fe62526674ad5f32e9ca19ec84714 Reviewed-on: https://skia-review.googlesource.com/77902 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Use a dst size threshold for multitexturing images.Gravatar Brian Salomon2017-11-30
| | | | | | | | | TODO: Set thresholds based on GPU in use. Change-Id: I0aeac596d11ab63922f2df0d76c668b4f8be5353 Reviewed-on: https://skia-review.googlesource.com/77900 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Update Skia milestone to 65Gravatar Heather Miller2017-11-30
| | | | | | | | | | | NOTRY=TRUE TBR=reed Bug: skia: Change-Id: I3dfe04202f48068bd04e7d64fa38913906af02ce Reviewed-on: https://skia-review.googlesource.com/78201 Reviewed-by: Heather Miller <hcm@google.com> Commit-Queue: Heather Miller <hcm@google.com>
* Add a GrContextThreadSafeProxy to SkSurfaceCharacterizationGravatar Robert Phillips2017-11-30
| | | | | | | | | Ganesh will require access to the GrCaps to make rendering decisions. Change-Id: I6dee42a3f0dc638f052706b8d1ea6e02b589e062 Reviewed-on: https://skia-review.googlesource.com/77681 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Make cpu scaling more robustGravatar Kevin Lubick2017-11-30
| | | | | | | | | | | | | | | | | | Some bots, especially the Nexus 7s, seemed to occasionally fail when setting the CPU frequency. I was unable to repro this behavior, so this is a shotgun approach. We add a 5 second delay between setting and checking, checking frequency using scaling_cur_freq instead of scaling_setspeed, set the min_freq as well as max_freq, and retry up to 3 times if setting cpu frequency fails. NOTRY=true Bug: skia: Change-Id: Id4d85d8d509c9dba8e3a0e06b5992f5adadf36d2 Reviewed-on: https://skia-review.googlesource.com/78140 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Make sure to visit clips and dst proxies during gatherGravatar Chris Dalton2017-11-30
| | | | | | | | Bug: skia:7190 Change-Id: I0cd4f7734047550c7904f44892ef266498842e0c Reviewed-on: https://skia-review.googlesource.com/77940 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ c677795f9..18841310d (1 commit)Gravatar angle-deps-roller@chromium.org2017-11-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/c677795f9f7d..18841310d80b $ git log c677795f9..18841310d --date=short --no-merges --format='%ad %ae %s' 2017-11-28 oetuaho Clean up MatchOutputCodeTest usage Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: I83f3552f3cb713bf0c78259fc1080635adab51ef Reviewed-on: https://skia-review.googlesource.com/78060 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* Roll skia/third_party/externals/angle2/ f13cadd8b..c677795f9 (6 commits)Gravatar angle-deps-roller@chromium.org2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/f13cadd8bd5f..c677795f9f7d $ git log f13cadd8b..c677795f9 --date=short --no-merges --format='%ad %ae %s' 2017-11-27 fjhenigman docs: fix links and typos 2017-11-27 jmadill Add a gl::AttribArray helper type. 2017-11-27 jmadill Isolate GlslangWrapper header from most of ANGLE. 2017-11-28 geofflang Add extra warnings for narrowing and bool conversion. 2017-11-28 oetuaho Refactor TSymbol to follow naming conventions 2017-11-27 oetuaho Fix scalarizing vec and mat constructor args Created with: roll-dep skia/third_party/externals/angle2 BUG=772653 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: I7c1549733e9ad035939c961eb4471253656d421e Reviewed-on: https://skia-review.googlesource.com/77960 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* devirtualize SkCanvas getClipBounds methodsGravatar Mike Klein2017-11-29
| | | | | | | | | | | | | | We no longer have any subclasses overriding the virtual hooks, and we've seen subtle bugs come up back when they did. In all modes, SkCanvas can answer these queries itself. BUG=chromium:781238 Change-Id: I37c7511c7bd00c638faacbe4bee89f785691453f Reviewed-on: https://skia-review.googlesource.com/77202 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Temporarily add Ubuntu IntelHD4400 jobs."Gravatar Ben Wagner2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 373588426b9d02576152e820eb7f870d930f1998. Reason for revert: Have enough digests on Gold now. Original change's description: > Temporarily add Ubuntu IntelHD4400 jobs. > > I want to compare this with the IntelBayTrail and if the results are > similar, replace those bots. > > No-Try: true > Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a > Reviewed-on: https://skia-review.googlesource.com/76900 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Ben Wagner <benjaminwagner@google.com> TBR=benjaminwagner@google.com,kjlubick@google.com Change-Id: Ica07d1ee635e59e3d3da51ee73591ffe08310e34 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/77860 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Revert "Make sure to visit clips and dst proxies during gather"Gravatar Chris Dalton2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c666502bc6975a73ef352d673b151017a21e8562. Reason for revert: <INSERT REASONING HERE> Original change's description: > Make sure to visit clips and dst proxies during gather > > Bug: skia:7190 > Change-Id: I6ba5bad6e155e9092dff9c2ad3241f603c333b4d > Reviewed-on: https://skia-review.googlesource.com/76460 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=robertphillips@google.com,csmartdalton@google.com Change-Id: I4839594bb97472f5ac2057600a0889c8a9dff5f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7190 Reviewed-on: https://skia-review.googlesource.com/77781 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Ignore deserialized path convexity and first direction.Gravatar Brian Salomon2017-11-29
| | | | | | | Change-Id: Ib7bfff6225774b83d9b6e9c5baae254aab17353b Reviewed-on: https://skia-review.googlesource.com/77680 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Isolate the biggest CIPD assets to trim down on overheadGravatar Kevin Lubick2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change, when combined with https://skia-review.googlesource.com/c/buildbot/+/77701 should cut down on the duplicated work of extracting the large toolchains from CIPD. Since the Isolate* steps can be cached (i.e. are idempotent) they will only run about 1/week (unless updated) and all subsequent tasks (primarily Builds) will go much faster. We estimate the overhead on Build-Debian-Android to go from about 90s (which was more time than the actual build) to about 10s. Build-Win-Vulkan's overhead will improve from about 180s to about 35s (1/3 of which is uploading to isolate). Other CIPD assets could be handled in a similar fashion; the ones here are the biggest offenders and the lowest hanging fruit. Doing this to other assets (e.g. clang_win) would have minimal improvements (<10s). There are other tasks with large amounts of overhead (e.g. Build-Mac-Android, Build-Win-Android, Build-WASM) but none of those are depended on by any Tests, so any speed-ups would have less wide-reaching-impact, at the cost of using more Isolate cache/diskspace. See https://docs.google.com/document/d/1DFlcpqg7XqEPE5oYT1V3so2ih2285heS5w3mPT-GMBA/edit# for more information. Bug: skia: Change-Id: I40dd87fe72c3d49292762a09dad6df0dfbe78f61 Reviewed-on: https://skia-review.googlesource.com/77560 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* SkRasterPipeline::dump() in forward orderGravatar Mike Klein2017-11-29
| | | | | | | | | | Reading these in reverse is annoying. Change-Id: I943f2a74716d1904874ebf8fbd6b20ffa4a9f166 Reviewed-on: https://skia-review.googlesource.com/77683 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Make sure to visit clips and dst proxies during gatherGravatar Chris Dalton2017-11-29
| | | | | | | | Bug: skia:7190 Change-Id: I6ba5bad6e155e9092dff9c2ad3241f603c333b4d Reviewed-on: https://skia-review.googlesource.com/76460 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Update CT bots to Debian-9.2Gravatar Eric Boren2017-11-29
| | | | | | | | | | | This has the side effect of using the bots in the new GCE project as well. Bug: skia:7278 Change-Id: Ie14c93d6e3d12ccbfb679089bc50bca482fbf605 Reviewed-on: https://skia-review.googlesource.com/76261 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* [infra] Provide Buildbucket Build ID in dm.jsonGravatar Eric Boren2017-11-29
| | | | | | | | Bug: skia: Change-Id: Iefef7d617e58de2b3be2e27aac075f822641e4ce Reviewed-on: https://skia-review.googlesource.com/77641 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Delete even more unused views codeGravatar Brian Osman2017-11-29
| | | | | | | | Bug: skia: Change-Id: I41480aa89dfcd8cb7e016e477cbabe354f35ce8a Reviewed-on: https://skia-review.googlesource.com/75480 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Upgrade Macs to 10.13.1.Gravatar Ben Wagner2017-11-29
| | | | | | | | | Bug: skia:7203 Change-Id: I741d15eabe502fd4c130e8ab3c3cfb92e3794e43 NoTry: true Reviewed-on: https://skia-review.googlesource.com/68080 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Bundle resources and skps directories into iOS app.Gravatar Jim Van Verth2017-11-29
| | | | | | | | | | | | | Will bundle resources/ for viewer (and skps/ if that directory exists in the main Skia directory). Also updates file code on iOS to fall back to bundle directory. Docs-Preview: https://skia.org/?cl=76803 Bug: skia:7339 Change-Id: I244f67559c866451a6d02c3f1c4948d89457ec84 Reviewed-on: https://skia-review.googlesource.com/76803 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Exclude URLs only for some page setsGravatar Ravi Mistry2017-11-29
| | | | | | | | Bug: skia:7348 Change-Id: Iabf4c0d0bf83a0caeeb06027e5617a18900ac5fc Reviewed-on: https://skia-review.googlesource.com/77180 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Temporarily add Ubuntu IntelHD4400 jobs.Gravatar Ben Wagner2017-11-29
| | | | | | | | | | | I want to compare this with the IntelBayTrail and if the results are similar, replace those bots. No-Try: true Change-Id: Ib5476fe91dc446182cd1b37e93fe17962dcf961a Reviewed-on: https://skia-review.googlesource.com/76900 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Revert "Make PathGeoBuilder use consistent iterators.""Gravatar Brian Salomon2017-11-29
| | | | | | | | | | This reverts commit b4513213245c2550683236b3aae829c8f3086469. Bug: chromium:788500 Change-Id: I6028b20770009b703f76ce2d9b451c561eaa705a Reviewed-on: https://skia-review.googlesource.com/77582 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove temporary image Swarming dimension.Gravatar Ben Wagner2017-11-29
| | | | | | | Change-Id: Iee28f684bd6fa541e36f677ee4261e637cbd4611 Reviewed-on: https://skia-review.googlesource.com/77201 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Make PathGeoBuilder use consistent iterators."Gravatar Robert Phillips2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9c8a16bb1ef5b6663c7b2c98fc2ec7f6499f72a8. Reason for revert: An assert seems to be firing Original change's description: > Make PathGeoBuilder use consistent iterators. > > Previously it used a degenerate consuming iterator to determine the whether there were multiple contours. This was inconsistent with the tessellating step. > > Bug: chromium:788500 > Change-Id: I3938c69cf40bc551acdb8d5fa9b54d2c96e2a460 > Reviewed-on: https://skia-review.googlesource.com/76961 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,brianosman@google.com Change-Id: I3a591086293d21f1a04dc3875242b96198aeddd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:788500 Reviewed-on: https://skia-review.googlesource.com/77441 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Make PathGeoBuilder use consistent iterators."Gravatar Brian Salomon2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9c8a16bb1ef5b6663c7b2c98fc2ec7f6499f72a8. Reason for revert: <INSERT REASONING HERE> Original change's description: > Make PathGeoBuilder use consistent iterators. > > Previously it used a degenerate consuming iterator to determine the whether there were multiple contours. This was inconsistent with the tessellating step. > > Bug: chromium:788500 > Change-Id: I3938c69cf40bc551acdb8d5fa9b54d2c96e2a460 > Reviewed-on: https://skia-review.googlesource.com/76961 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,brianosman@google.com Change-Id: I18005ea2d7ba88c66334f110a5a74c6d82e4ab90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:788500 Reviewed-on: https://skia-review.googlesource.com/77440 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Make PathGeoBuilder use consistent iterators.Gravatar Brian Salomon2017-11-29
| | | | | | | | | | Previously it used a degenerate consuming iterator to determine the whether there were multiple contours. This was inconsistent with the tessellating step. Bug: chromium:788500 Change-Id: I3938c69cf40bc551acdb8d5fa9b54d2c96e2a460 Reviewed-on: https://skia-review.googlesource.com/76961 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Roll skia/third_party/externals/angle2/ 57ea533f7..f13cadd8b (1 commit)Gravatar angle-deps-roller@chromium.org2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/57ea533f79a7..f13cadd8bd5f $ git log 57ea533f7..f13cadd8b --date=short --no-merges --format='%ad %ae %s' 2017-11-28 oetuaho Fix checking negative index when indexing matrix/vector Created with: roll-dep skia/third_party/externals/angle2 BUG=789029 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: I6d6b6eac2ae363aa76dbcbb2e7bf56ab27afc1b4 Reviewed-on: https://skia-review.googlesource.com/77380 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Avoid double-destruction of Sk3DShaderContext-wrapped objectsGravatar Florin Malita2017-11-29
| | | | | | | | | | | | | | | Sk3DShaderContext creates its nested shader context on a SkArenaAlloc, which handles destruction when going out of scope. Hence, the explicit context dtor call in ~Sk3DShaderContext() is incorrect (likely left over from before SkArenaAlloc). BUG=chromium:787712 Change-Id: I176222e449151dcce532a839ef9587d06f61d297 Reviewed-on: https://skia-review.googlesource.com/77203 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Roll skia/third_party/externals/angle2/ 5201ce127..57ea533f7 (1 commit)Gravatar angle-deps-roller@chromium.org2017-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/5201ce127afe..57ea533f79a7 $ git log 5201ce127..57ea533f7 --date=short --no-merges --format='%ad %ae %s' 2017-11-22 kainino TType: Store array sizes vector as a pointer. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: I9dd0c88a4fb5e6ee7b8dbd9681f1307a7f2ccfe3 Reviewed-on: https://skia-review.googlesource.com/77300 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Update SkTLazy for move only types.Gravatar Ben Wagner2017-11-28
| | | | | | | Change-Id: Id812d4f6ac47ae41e5a938310aa8f30eaf33a42d Reviewed-on: https://skia-review.googlesource.com/76901 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
* Roll skia/third_party/externals/angle2/ df68ca50b..5201ce127 (1 commit)Gravatar angle-deps-roller@chromium.org2017-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/df68ca50b310..5201ce127afe $ git log df68ca50b..5201ce127 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 geofflang Fix MSVC 2015 warnings. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: Id42639e2aeda492b42687ebd9ffd573e30f54b11 Reviewed-on: https://skia-review.googlesource.com/77140 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* SkPDF: fix fTextScaleX errorGravatar Hal Canary2017-11-28
| | | | | | | | BUG=skia:7315 Change-Id: Ic613cb6fb8faed5b0840db4f500940bd6823de66 Reviewed-on: https://skia-review.googlesource.com/76981 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* remove unused readBitmapAsImage from readbufferGravatar Mike Reed2017-11-28
| | | | | | | | Bug: skia: Change-Id: Ic200ec39999a06f407de29e15b646baddb9e341d Reviewed-on: https://skia-review.googlesource.com/76982 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* drop 32-bit Android NDK builds down to API 16Gravatar Mike Klein2017-11-28
| | | | | | | Change-Id: I40ded57601da605a1393ce56589455909f66ad00 Reviewed-on: https://skia-review.googlesource.com/77020 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove writeBitmap from SkWriteBuffer -- unusedGravatar Mike Reed2017-11-28
| | | | | | | | Bug: skia: Change-Id: I8809e7e138d64cc30389e8efc76265011b287611 Reviewed-on: https://skia-review.googlesource.com/77060 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Make Skia compatible with Android NDK r16Gravatar bsheedy2017-11-28
| | | | | | | | | | | | | | | Changes to Skia that are necessary to make Chromium compile with Android NDK r16, which switches to unified headers. Sister CLs: src/third_party/android_tools/ndk: https://chromium-review.googlesource.com/c/android_ndk/+/784230 src/: https://chromium-review.googlesource.com/c/chromium/src/+/777822 Bug: chromium:771171 Change-Id: I3d35df5b99d8eb7d7d938d21b5aecdf4c2d5da0f Reviewed-on: https://skia-review.googlesource.com/75422 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Make RecreateSKPs bot fail if capturing SKPs fails + exclude failing page setsGravatar Ravi Mistry2017-11-28
| | | | | | | | Bug: skia:7348 Change-Id: I8dd6337d2efeb1aaa71ac41fcb82b9a22bbd7531 Reviewed-on: https://skia-review.googlesource.com/76220 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Upgrade GalaxyS6.Gravatar Ben Wagner2017-11-28
| | | | | | | | | Bug: skia:7308 Change-Id: Ia84f67c310104fc75e81757de8cb8e57add763d0 Reviewed-on: https://skia-review.googlesource.com/76621 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* remove clip-bounds query overrides from SkColorSpaceXformCanvasGravatar Mike Klein2017-11-28
| | | | | | | | | | | | | | | | | | | | | | | This is the only SkCanvas subclass currently overriding these, and this leads to buggy interactions with this canvas, saveLayer(), and image filters. The base SkCanvas tracks and can answer these queries just as well as fTarget. A couple other SkCanvas subclasses do override isClipEmpty() and isClipRect(), and these conservative clip tracking SkCanvases can't really answer isClipRect() correctly, so I've left those both. I'm intentionally keeping this CL minimal in case it needs backporting to other branches. I'm going to follow up separately with a GM or unit test that would reproduce the Chrome bug, and with a CL that de-virtualizes these two methods. BUG=chromium:781238 Change-Id: I75bf6b0910115fafe17fa721082acc415bfdae23 Reviewed-on: https://skia-review.googlesource.com/76802 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll skia/third_party/externals/angle2/ 0b684ce3c..df68ca50b (1 commit)Gravatar angle-deps-roller@chromium.org2017-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0b684ce3c9f5..df68ca50b310 $ git log 0b684ce3c..df68ca50b --date=short --no-merges --format='%ad %ae %s' 2017-11-27 geofflang Add missing break in StateManagerGL::syncState. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=allanmac@google.com Change-Id: I1e069f3d065e9c8952946ef524947ac9767ca6d0 Reviewed-on: https://skia-review.googlesource.com/76840 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* shader cache now ignores shaders with a length of 0Gravatar Ethan Nicholas2017-11-28
| | | | | | | | Bug: skia: Change-Id: I1dd9794ea424d862e53414fcd96885972ac2ba76 Reviewed-on: https://skia-review.googlesource.com/73721 Reviewed-by: Stan Iliev <stani@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Fix shader initialization on a cache hitGravatar Ethan Nicholas2017-11-28
| | | | | | | | Bug: skia: Change-Id: I1ad93442df1b53ce5f1cfb7285479c6b860b7e24 Reviewed-on: https://skia-review.googlesource.com/71461 Reviewed-by: Stan Iliev <stani@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Add create_bundle support for GNGravatar Jim Van Verth2017-11-28
| | | | | | | | | Docs-Preview: https://skia.org/?cl=75383 Bug: skia:7339 Change-Id: I985734e8b7b5af21a82cb8ee59acbfb5ff1d3ff7 Reviewed-on: https://skia-review.googlesource.com/75383 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Switch Coverage GPU bot to Golo.Gravatar Ben Wagner2017-11-28
| | | | | | | | No-Try: true Change-Id: I0b9f6ef3651e5309af316d7ea7e170b48f54cdeb Reviewed-on: https://skia-review.googlesource.com/76620 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Don't scale CPU for internal botsGravatar Kevin Lubick2017-11-28
| | | | | | | | | | | | For internal hardware, it tends not to work - they work at one clock speed, despite advertising others. Bug: skia: NOTRY=true Change-Id: I10bf0fc1ab4d60bfbc2eefcef5b42ceab9e3f435 Reviewed-on: https://skia-review.googlesource.com/76720 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-04 19:08:30 +0000