aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Build skottie_tool on Linux onlyGravatar Florin Malita2018-06-06
| | | | | | | | | | | | MoltenVK builds are failing on Mac. Let's limit skottie_tool to Linux for now, as that's the only platform Fiddle runs on. Change-Id: Icc94e0e380d6f1bc32888dcaaeb812dad082f625 Reviewed-on: https://skia-review.googlesource.com/132404 Commit-Queue: Florin Malita <fmalita@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com> Auto-Submit: Florin Malita <fmalita@chromium.org> Reviewed-by: Hal Canary <halcanary@google.com>
* Add fuzzer option for Blur w/o occluderGravatar Kevin Lubick2018-06-06
| | | | | | | | | | | I hypothesize that some backends look at the occluder and may have accidentally (on purpose) been avoiding the linked bug. Bug: skia:7956 Change-Id: If8d1de099f778b2faaa2c5ed4c562047b0dd14e7 Reviewed-on: https://skia-review.googlesource.com/131922 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* Revert "Have draw(Text|PosText|PosTextH) use a single entry on the device"Gravatar Hal Canary2018-06-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4225b3220ef4bf50f0d9403f812ea94d50c4ee59. Reason for revert: made valgrind unhappy. Original change's description: > Have draw(Text|PosText|PosTextH) use a single entry on the device > > Handle the positioning of drawText at the canvas layer. Simplify > the code by removing similar implementations. > > Change-Id: I8b711783435072f560e29fca1dd934fa2e345ed2 > Reviewed-on: https://skia-review.googlesource.com/127131 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Herb Derby <herb@google.com> TBR=jvanverth@google.com,bungeman@google.com,herb@google.com Change-Id: I65c9d30ae6ecb1f87e8660e56d8f8ce5daab7551 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/132403 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Harden SkPerlinNoiseShader StitchData initializationGravatar Florin Malita2018-06-06
| | | | | | | | | | ... to ensure fWrap{X,Y} don't overflow int. Bug: chromium:846010, oss-fuzz:8377 Change-Id: I7cf082e388002ad5f8a6c62bad92f998fe831385 Reviewed-on: https://skia-review.googlesource.com/132222 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* work around bug 8051Gravatar Cary Clark2018-06-06
| | | | | | | | | | | | | turn off the example that generates the failing fiddle Docs-Preview: https://skia.org/?cl=132401 Bug: skia:8051 NOTRY=true Change-Id: Ic018dbf9ba4f3b7d948660ca2946291ec37f3555 Reviewed-on: https://skia-review.googlesource.com/132401 Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Roll third_party/externals/angle2 d197803..0211346 (1 commits)Gravatar angle-skia-autoroll2018-06-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/d197803..0211346 git log d197803..0211346 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 jyan@ca.ibm.com PPC/s390: Fix GN error on PPC and s390 Created with: gclient setdep -r third_party/externals/angle2@0211346 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=halcanary@google.com Change-Id: I1cd09cce366d789a454a5dec04d1fe628130efd6 Reviewed-on: https://skia-review.googlesource.com/132380 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* [skottie] Add a tool for dumping encoded animation framesGravatar Florin Malita2018-06-06
| | | | | | | | | | | | | | | | | | | | | | | | | Exports animation frames as a sequence of .png files: 0000000.png 0000001.png ... Usage: skottie_tool -i <input_json> -w <out_dir> Other options: --width Frame width (default: 800) --height Frame height (default: 600) --fps Frames per second (default: 30) --t0 Normalized timeline start (default: 0) --t1 Normalized timeline end (default: 1) Change-Id: I4a79be0f823da15e6863909b6d67d38aa74bb740 Reviewed-on: https://skia-review.googlesource.com/132265 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll third_party/externals/angle2 7ba3f42..d197803 (1 commits)Gravatar angle-skia-autoroll2018-06-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/7ba3f42..d197803 git log 7ba3f42..d197803 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 jmadill@chromium.org Roll dEQP (June 2018). Created with: gclient setdep -r third_party/externals/angle2@d197803 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=halcanary@google.com Change-Id: Ib8581f25f573f096a33636d54557eb7d148af1e8 Reviewed-on: https://skia-review.googlesource.com/132302 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/swiftshader 57776df..f398044 (1 commits)Gravatar swiftshader-skia-autoroll2018-06-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader.git/+log/57776df..f398044 git log 57776df..f398044 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 capn@google.com Don't acquire image for copying until needed. Created with: gclient setdep -r third_party/externals/swiftshader@f398044 The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=halcanary@google.com Change-Id: I430e20e7a50464acc024de1e07163b22fc9ae927 Reviewed-on: https://skia-review.googlesource.com/132300 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add Gr enums and version parsing for SwiftShaderGravatar Kevin Lubick2018-06-05
| | | | | | | | Bug: skia: Change-Id: I1f29cde915a0ae7fa59d7cfdf30f51632c1c24c4 Reviewed-on: https://skia-review.googlesource.com/132264 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Have draw(Text|PosText|PosTextH) use a single entry on the deviceGravatar Herb Derby2018-06-05
| | | | | | | | | | Handle the positioning of drawText at the canvas layer. Simplify the code by removing similar implementations. Change-Id: I8b711783435072f560e29fca1dd934fa2e345ed2 Reviewed-on: https://skia-review.googlesource.com/127131 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* restore headers lost from skia.hGravatar Mike Klein2018-06-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we updated the script that generates skia.h to look at GN dependencies, we lost some headers. Here are two that we have noticed are missing. ~/skia (headers|✚2…) $ git diff --no-index before.h out/gen/skia.h diff --git a/before.h b/out/gen/skia.h index 1d59746af1..915fffb293 100644 --- a/before.h +++ b/out/gen/skia.h @@ -38,6 +38,7 @@ #include "SkColorMatrix.h" #include "SkColorMatrixFilter.h" #include "SkColorPriv.h" +#include "SkColorSpaceXform.h" #include "SkCornerPathEffect.h" #include "SkDashPathEffect.h" #include "SkData.h" @@ -65,6 +66,7 @@ #include "SkImageInfo.h" #include "SkImageSource.h" #include "SkInterpolator.h" +#include "SkJpegEncoder.h" #include "SkLayerDrawLooper.h" #include "SkLightingImageFilter.h" #include "SkLumaColorFilter.h" Bug: skia:8039 Change-Id: If59a421a7852dc19123b851798b194a4666c59a3 Reviewed-on: https://skia-review.googlesource.com/132262 Auto-Submit: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Consolidate ambient and spot code setup.Gravatar Jim Van Verth2018-06-05
| | | | | | | | | | | | Uses shared code to create a polygon version of the path, as well as computing the centroid and determining convexity. This makes things more consistent and sets up for creating concave ambient shadows. Bug: skia:7971 Change-Id: I3f36a423431361177ad9f53218b3ff0fdaa179e1 Reviewed-on: https://skia-review.googlesource.com/131585 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Roll skia/third_party/skcms 2e43fec..0fdd840 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-06-05
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/2e43fec..0fdd840 2018-06-05 mtklein@chromium.org force wasm into N=1 transform code paths The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=halcanary@google.com Change-Id: Ib8763e877f4d9b8d2cd044b2c521519d9b4ee68c Reviewed-on: https://skia-review.googlesource.com/132203 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* SkPDF: Fastpath for clipstack flatteningGravatar Hal Canary2018-06-05
| | | | | | | | | | BUG: chromium:837279 Change-Id: I79a675e7d9e713617711948e491e28babe06b1a2 Reviewed-on: https://skia-review.googlesource.com/132092 Auto-Submit: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Roll skia/third_party/skcms a8a5c9e..2e43fec (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-06-05
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/a8a5c9e..2e43fec 2018-06-05 mtklein@chromium.org clean up option for old powf() The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=halcanary@google.com Change-Id: Ic1556a1a02d339f76f53d446bd2311c6ebd775a6 Reviewed-on: https://skia-review.googlesource.com/132200 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* add upm->upm helperGravatar Mike Klein2018-06-05
| | | | | | | | | Change-Id: I912e58339b3b84be17d6a98d52cbc11f376c9a89 Reviewed-on: https://skia-review.googlesource.com/132093 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org>
* simplify SK_FloatNaNGravatar Mike Klein2018-06-05
| | | | | | | | | | | math.h contains NAN, an expression that evaluates to a quiet float NaN While here, INFINITY is also a float, so the casts aren't needed. Change-Id: Ibdd8f5a2767651cd4382d700e9125b832473a304 Reviewed-on: https://skia-review.googlesource.com/132087 Auto-Submit: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Always use filterColor4f to filter paint colorsGravatar Brian Osman2018-06-05
| | | | | | | | | | | | | | | The rationale here wasn't even correct before - filterColor4f did not use a linearized version of the stored color (for mode color filter), so it's always safe and correct to call the 4f version. Change-Id: I7087342e531e1768c945f78fb2126954b2dc5a86 Reviewed-on: https://skia-review.googlesource.com/132088 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Brian Osman <brianosman@google.com>
* fixed interface/in/out struct for mvk integration and added a few missing ↵Gravatar Timothy Liang2018-06-05
| | | | | | | | | | builtins to skslc msl backend Bug: skia: Change-Id: Id514dc6af64bb2a5eb71f2161ceba549a8a6836d Reviewed-on: https://skia-review.googlesource.com/131881 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* handle degenerate call to blitAntiRectGravatar Mike Reed2018-06-05
| | | | | | | | Bug: skia:8043 Change-Id: Ief3653a748a1e82bd5ca9df3dd7743797e0160e8 Reviewed-on: https://skia-review.googlesource.com/132086 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* GrTessellator: fix for overlapping outer boundary edges in AA case.Gravatar Stephen White2018-06-05
| | | | | | | | | | | | | When inflating outer path boundaries for edge AA, two outer boundary edges may be collinear. In this case, they form part of the overlap region, but they must not be removed on collapse, since they form part of the outer boundary of the shape. Bug: 846655 Change-Id: I4808b570cc4f82d6202862f7a8ecf0f8add771ef Reviewed-on: https://skia-review.googlesource.com/132084 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Point to new CT swarming bots project IDGravatar Ravi Mistry2018-06-05
| | | | | | | | | | No-Try: true Docs-Preview: https://skia.org/?cl=132085 Bug: skia:8010 Change-Id: I44f45d6e6511700524f6fb4d389ab740ed2d6f9d Reviewed-on: https://skia-review.googlesource.com/132085 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Update MotoG4.Gravatar Ben Wagner2018-06-05
| | | | | | | | | No-Try: true Change-Id: I0e8715e7e7a0f884c653e4888459a185b0870065 Reviewed-on: https://skia-review.googlesource.com/131925 Commit-Queue: Kevin Lubick <kjlubick@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Roll third_party/externals/angle2 fba1f61..7ba3f42 (2 commits)Gravatar angle-skia-autoroll2018-06-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/fba1f61..7ba3f42 git log fba1f61..7ba3f42 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 lfy@google.com GLES1: Fog API and rendering 2018-06-05 lfy@google.com GLES1: Clip plane API and rendering Created with: gclient setdep -r third_party/externals/angle2@7ba3f42 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=halcanary@google.com Change-Id: I8eb4a942cc9b475a40679a4f4988eff9374bac4b Reviewed-on: https://skia-review.googlesource.com/132101 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-05
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/b9907703867525b9a082b83d8397f8a5bbf0bf02 Revert "Reland "Expand variables in gclient flattened output."" (jbudorick@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5ffc6361ec4073e11cde001b759623ed4958efb5 Reviewed-on: https://skia-review.googlesource.com/132080 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-05
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/ff6222444366463e2e86fd8b9c26580f689f78d6 Reland "Expand variables in gclient flattened output." (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia8d1535daa245edf6b7d56c88e5d3793e5a239f0 Reviewed-on: https://skia-review.googlesource.com/132040 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-05
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/01cb51055e127b1f846838d14761ca716511d63a Revert "Expand variables in gclient flattened output." (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1cca19ba0183a21fcbfbbbb0c09f45c99c45b04a Reviewed-on: https://skia-review.googlesource.com/131929 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll third_party/externals/angle2 48cdc2e..fba1f61 (5 commits)Gravatar angle-skia-autoroll2018-06-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/48cdc2e..fba1f61 git log 48cdc2e..fba1f61 --date=short --no-merges --format='%ad %ae %s' 2018-06-04 lucferron@chromium.org Vulkan: No-op on ProgramVk::Validate implementation 2018-06-04 lucferron@chromium.org Vulkan: Fix wrong read ptr location when updating uniform block 2018-06-04 fjhenigman@chromium.org Move vertex data copy functions out of D3D. 2018-06-04 geofflang@chromium.org Initialize gl::Context state on the first call to MakeCurrent. 2018-06-04 lucferron@chromium.org Vulkan: Update uniforms bugfix and enable dEQP tests with it Created with: gclient setdep -r third_party/externals/angle2@fba1f61 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=halcanary@google.com Change-Id: Ib08df506feea2b905b41d39010df9d1335f04249 Reviewed-on: https://skia-review.googlesource.com/132000 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/cf4aced37e993525b9e21856c0d1acec682edab1 Update windows git to 2.17.1 (agable@chromium.org) https://crrev.com/af43f40eb22d7ceedf2b48ba79ca8cc1b0a0c761 Fix git cl format --python --full (nodir@google.com) https://crrev.com/0ae14e9aad83c1387df8dd565cce3748fce3dec7 [presubmit] Add python formatting check (nodir@google.com) https://crrev.com/621fe6f9b56a04d06b4a730cd2867d50282a6490 Add ability to whitelist bot accounts as valid authors (sergiyb@chromium.org) https://crrev.com/88087bad47fb55e5e783ef678faddf6174a29a13 [led] Roll to 7ba61969ccbe1f9679661555f72ca947da508a70 (smut@google.com) https://crrev.com/518bb6847a6e29b2bc23a2b7b3a39d9aa5adc166 Include "fuchsia" as a known "deps_os" value (sergiyb@chromium.org) https://crrev.com/9ac59795af3a5a7a3dac572867d2cfce7dc6c21e Fix buildbucket bug filing instructions (nodir@google.com) https://crrev.com/23d75d2db4444e3e61c91dd78a09c977c88a3083 [git-cl-try] Handle absence of builds (nodir@google.com) https://crrev.com/a32f98e652d5e151f70d571cf046c3d83ae2f486 Expand variables in gclient flattened output. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I78cbd48d7f6bf9b752cebc732c84682c7051bcc5 Reviewed-on: https://skia-review.googlesource.com/131926 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* [Isolate] Update clients to hit /_ah/api instead of /apiGravatar smut2018-06-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | The webapp2 adapter is now serving at /_ah/api, the old Endpoints v1 path. https://chromium.googlesource.com/infra/infra revision: d8ec646a9503426a5018cf5bc251abe4a842357f https://chromium.googlesource.com/infra/luci/luci-go revision: 928030a644473add1ca1bd044d13f48fee569c1a linux64/isolate.sha1: https://ci.chromium.org/buildbot/chromium.infra/infra-continuous-trusty-64/12546 mac64/isolate.sha1: https://ci.chromium.org/buildbot/chromium.infra/infra-continuous-mac-10.13-64/4878 windows64/isolate.exe.sha1: https://ci.chromium.org/buildbot/chromium.infra/infra-continuous-win-64/12934 Bug: 805543 Change-Id: I1e15f69908a8c7c7a2300d3e37b0e53607613cbc Reviewed-on: https://skia-review.googlesource.com/131701 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Auto-Submit: smut <smut@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* rm dead codeGravatar Mike Klein2018-06-04
| | | | | | | Change-Id: Ie3e693e07f748fc46cdd9f1d4fe4af530882e915 Reviewed-on: https://skia-review.googlesource.com/131920 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove alpha readback path in GrGLGpu::onReadPixelsGravatar Brian Salomon2018-06-04
| | | | | | | Change-Id: I13d5a885a5a016ca7555702c5798c5b3f31b1cc8 Reviewed-on: https://skia-review.googlesource.com/131820 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Roll third_party/externals/swiftshader 4845633..57776df (2 commits)Gravatar swiftshader-skia-autoroll2018-06-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader.git/+log/4845633..57776df git log 4845633..57776df --date=short --no-merges --format='%ad %ae %s' 2018-06-04 sugoi@google.com Quick build fix 2018-06-04 sugoi@google.com Fixed synchronization issue on MacOS Created with: gclient setdep -r third_party/externals/swiftshader@57776df The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=halcanary@google.com Change-Id: Ifa3bd5a5cd9c62f2bf25a80dc73a812a5ee2573f Reviewed-on: https://skia-review.googlesource.com/131867 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/angle2 7921662..48cdc2e (1 commits)Gravatar angle-skia-autoroll2018-06-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/7921662..48cdc2e git log 7921662..48cdc2e --date=short --no-merges --format='%ad %ae %s' 2018-06-04 lucferron@chromium.org Vulkan: Implement setUniform for matrices correctly Created with: gclient setdep -r third_party/externals/angle2@48cdc2e The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=halcanary@google.com Change-Id: I30f61068f3073cd94ace8c3e76c67764077d458b Reviewed-on: https://skia-review.googlesource.com/131860 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Add null checks for GrSkSLtoGLSL to GrGLProgramBuilderGravatar Brian Salomon2018-06-04
| | | | | | | | | Bug: chromium:845351 Change-Id: I06c4114f9b2cd0609fcf7b7ce6d4a80a00ca85c3 Reviewed-on: https://skia-review.googlesource.com/131525 Auto-Submit: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* need conservative bounds for triangles due to SkFixed drift in SkEdgeGravatar Mike Reed2018-06-04
| | | | | | | | | Bug: oss-fuzz:8018 Change-Id: I09456f906b7eb89f74ffd2c484bc6e30e029bfbb Reviewed-on: https://skia-review.googlesource.com/131021 Reviewed-by: Cary Clark <caryclark@google.com> Auto-Submit: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Remove GrPaint::setGammaCorrectGravatar Brian Osman2018-06-04
| | | | | | | | | | | | | | Driving this from the presence of a color space makes no sense in the new world, we should always be treating sRGB as such (end-to-end). Change-Id: If3d8e740793321a2b1294ff72b04558d3b96cb53 Reviewed-on: https://skia-review.googlesource.com/131784 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Turn off logging for testsGravatar Herb Derby2018-06-04
| | | | | | | Change-Id: I00bb3059bb92b5c11178022aff8a87918bb3781e Reviewed-on: https://skia-review.googlesource.com/131640 Reviewed-by: Khushal Sagar <khushalsagar@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Remove color space restrictions from image infosGravatar Brian Osman2018-06-04
| | | | | | | | | | | What makes an info valid (or invalid)? Nothing to do with color space. Bug: skia: Change-Id: I6795efa9aa74ab0d65935c5ddccc1058f8e0b112 Reviewed-on: https://skia-review.googlesource.com/131780 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* C++14Gravatar Brian Salomon2018-06-04
| | | | | | | Change-Id: I4bbf3e5e6d9d4e11e968a0bc88ce43444047a382 Reviewed-on: https://skia-review.googlesource.com/130903 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Update SKP versionGravatar skia-recreate-skps2018-06-03
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I80ef55d84988185265febee72195bd6f9f4afe10 Reviewed-on: https://skia-review.googlesource.com/131711 Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
* Roll third_party/externals/angle2 47463d8..7921662 (1 commits)Gravatar angle-skia-autoroll2018-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/47463d8..7921662 git log 47463d8..7921662 --date=short --no-merges --format='%ad %ae %s' 2018-06-02 jgilbert@mozilla.com Use stringstream with locale override. Created with: gclient setdep -r third_party/externals/angle2@7921662 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=rmistry@google.com Change-Id: I2558be522e03814b230b9445baabda4b05fbeb9c Reviewed-on: https://skia-review.googlesource.com/131709 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/angle2 bf7b95d..47463d8 (6 commits)Gravatar angle-skia-autoroll2018-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/bf7b95d..47463d8 git log bf7b95d..47463d8 --date=short --no-merges --format='%ad %ae %s' 2018-06-01 ehmaldonado@chromium.org Use revision variables in DEPS. 2018-06-01 geofflang@chromium.org Move the EGL-based initial state to the gl::State constructor. 2018-06-01 lucferron@chromium.org Vulkan: Fix texture completeness issues 2018-06-01 ehmaldonado@chromium.org Make DEPS file compatible with Chromium. 2018-06-01 jmadill@chromium.org D3D11: Micro-optimize StateManager11::updateState. 2018-06-01 jmadill@chromium.org D3D11: Optimize Renderer11::drawArrays. Created with: gclient setdep -r third_party/externals/angle2@47463d8 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=rmistry@google.com Change-Id: Ic8e7f54b75388baa8b08b187784a3fbc1138231d Reviewed-on: https://skia-review.googlesource.com/131707 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/swiftshader 419e8a7..4845633 (2 commits)Gravatar swiftshader-skia-autoroll2018-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader.git/+log/419e8a7..4845633 git log 419e8a7..4845633 --date=short --no-merges --format='%ad %ae %s' 2018-06-02 nicolas.capens@gmail.com Fix CLang build. 2018-06-02 capn@google.com Prevent floating-point error accumulation during blitting. Created with: gclient setdep -r third_party/externals/swiftshader@4845633 The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=rmistry@google.com Change-Id: Ie90ec0dd14d986b916932c80428c2778a890ce12 Reviewed-on: https://skia-review.googlesource.com/131705 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Remove origin from GrGpu::readPixelsGravatar Brian Salomon2018-06-02
| | | | | | | Change-Id: I40d046c66240ab40794aa008861a1974f7f9182c Reviewed-on: https://skia-review.googlesource.com/131620 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Remove origin from GrGpu::writePixelsGravatar Brian Salomon2018-06-02
| | | | | | | | Change-Id: Iea3d68d282420f28623ebea315499fbd7ad9d471 Reviewed-on: https://skia-review.googlesource.com/131526 Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Update SKP versionGravatar skia-recreate-skps2018-06-01
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: I663912fb35f95ee852bd2db7ceac1834990e75b5 Reviewed-on: https://skia-review.googlesource.com/131660 Commit-Queue: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com>
* Remove most of the remaining conflation of colorSpace and sRGB in GaneshGravatar Brian Osman2018-06-01
| | | | | | | Change-Id: I22cd838f15c548b459da925cd7e7d228f95fb2e2 Reviewed-on: https://skia-review.googlesource.com/131583 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* fix a weird edge case in to_srgb stageGravatar Mike Klein2018-06-01
| | | | | | | | | | | | | | I just uncovered this by porting the Chromecast bots from an old GCC to an old Clang. In to_srgb() we tune our constants so that 1.0f maps to exactly 1.0f, but because both JUMPER_IS_NEON and JUMPER_IS_SCALAR were defined, we picked the NEON values instead of the scalar values we want. Undefining JUMPER_IS_NEON when JUMPER_IS_SCALAR should do the trick. Change-Id: I6c6f76b78b3419e204c0b4df351459baf05315bc Reviewed-on: https://skia-review.googlesource.com/131582 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>