aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* SkScaledBitmapSampler: fix memory overwrittenGravatar zoran.jovanovic2015-04-16
| | | | | | | | | | | | | | | | | | | Memory will be overwritten while downsampling some interlaced gif images, most commonly with odd sizes, when index of destination row stores in the current line computed from GifInterlaceIter meets: X is an integer in [0..height-1] and (X < height) && ((X - sampleSize/2) % sampleSize == 0) && ((X - sampleSize/2)/sampleSize >= height/sampleSize) Signed-off-by: Lu Tong <lu.x.tong@sonymobile.com> BUG=skia: Review URL: https://codereview.chromium.org/1085253002
* Add ReverseIter to GrTRecorderGravatar cdalton2015-04-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1035083004
* Revert of remove unused (by clients) SkPathUtils (patchset #1 id:1 of ↵Gravatar jcgregorio2015-04-16
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1088383003/) Reason for revert: This change is causing the DEPS roll to fail: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/78771/steps/gn/logs/stdio Original issue's description: > remove unused (by clients) SkPathUtils > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/aab35d91b8b80acd1902594bbf542083fdfa4bb7 TBR=scroggo@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1060703003
* Don't serialize anything for SkEmptyShader.Gravatar mtklein2015-04-16
| | | | | | BUG=skia:3735 Review URL: https://codereview.chromium.org/1097433002
* widen output png size of bmp_filter_quality_repeatGravatar Brian Salomon2015-04-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1097443002
* Add GM that tests bmp filter qualities with repeat modeGravatar bsalomon2015-04-16
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/1086203002
* remove unused (by clients) SkPathUtilsGravatar reed2015-04-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1088383003
* Zero jpeg_decompress_struct before calling jpeg_calc_output_dimensions().Gravatar mtklein2015-04-16
| | | | | | | | | | https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind/builds/38/steps/dm/logs/stdio (Must have been https://codereview.chromium.org/1076923002 ?) BUG=skia: Review URL: https://codereview.chromium.org/1094603002
* remove older version of cubic->coeffGravatar reed2015-04-15
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1084623004
* Speeup hairline curves (quads and cubics) (patchset #7 id:120001 of ↵Gravatar reed2015-04-15
| | | | | | | | | | | | | https://codereview.chromium.org/1078413003/)" ah ha! Check for the define *after* we pull in SkUserConfig.h (indirectly) This reverts commit 639a82855b94b93c4fa45560e67df8ec4a8bbb3a. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1084283003
* Revert of make blitAntiH2 virtual, to prep for larger change (patchset #1 ↵Gravatar reed2015-04-15
| | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1048323005/) Reason for revert: end of test Original issue's description: > make blitAntiH2 virtual, to prep for larger change > > testing... > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/33afdaa5213cf118b3ca290bb343253c8593756d TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1086293002
* make blitAntiH2 virtual, to prep for larger changeGravatar reed2015-04-15
| | | | | | | | | testing... BUG=skia: TBR= Review URL: https://codereview.chromium.org/1048323005
* Revert of Speeup hairline curves (quads and cubics) (patchset #7 id:120001 ↵Gravatar reed2015-04-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1078413003/) Reason for revert: Crazy failings in chrome tests http://build.chromium.org/p/client.skia/builders/Linux%20Tests/builds/1862 Original issue's description: > Speeup hairline curves (quads and cubics) > > /skia/trunk> cat ../old.txt > maxrss loops min median mean max stddev samples config bench > 9M 1 4.28ms 4.32ms 4.36ms 4.67ms 3% ▄▁▁▃▂▂▁▁▂█ 8888 path_hairline_small_AA_cubic > 9M 1 743µs 767µs 770µs 825µs 4% ▃▃▇▃▁▁▅▁█▁ 8888 path_hairline_small_AA_conic > 9M 1 533µs 606µs 598µs 680µs 9% ▁▂▂█▆▇▇▄▂▂ 8888 path_hairline_small_AA_quad > 9M 1 451µs 452µs 456µs 495µs 3% ▁▁▁▁█▁▁▁▁▁ 8888 path_hairline_small_AA_line > > /skia/trunk> cat ../new.txt > maxrss loops min median mean max stddev samples config bench > 9M 1 827µs 827µs 831µs 869µs 2% ▁▁▁▁▁▁▁█▁▁ 8888 path_hairline_small_AA_cubic > 9M 1 515µs 517µs 517µs 518µs 0% ▇█▆▅▃▃▁▁▁▅ 8888 path_hairline_small_AA_conic > 9M 1 310µs 311µs 315µs 332µs 2% ▂▁█▆▁▁▁▁▁▁ 8888 path_hairline_small_AA_quad > 9M 1 254µs 254µs 258µs 276µs 3% ▁▁▁▁▁▁▁█▇▂ 8888 path_hairline_small_AA_line > > Edited revert of https://codereview.chromium.org/1085013003 > > TBR= > > Expectations: > - no effect on chrome, as it is guarded > - lots of tiny rebaselines for skia TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1092483003
* Don't draw if SkShader::asNewFragmentProcessor fails.Gravatar bsalomon2015-04-15
| | | | | | BUG=chromium:473156 Review URL: https://codereview.chromium.org/1089063002
* Fix LCD text and add path fix for Mali.Gravatar jvanverth2015-04-15
| | | | | | | | | dFdy(st.y) produces negative values, so we need to take abs() to get the right inverse scale. BUG=skia:3528 Review URL: https://codereview.chromium.org/1086183002
* Speeup hairline curves (quads and cubics)Gravatar reed2015-04-15
| | | | | | | | | | | | | | | | | | | | | | /skia/trunk> cat ../old.txt maxrss loops min median mean max stddev samples config bench 9M 1 4.28ms 4.32ms 4.36ms 4.67ms 3% ▄▁▁▃▂▂▁▁▂█ 8888 path_hairline_small_AA_cubic 9M 1 743µs 767µs 770µs 825µs 4% ▃▃▇▃▁▁▅▁█▁ 8888 path_hairline_small_AA_conic 9M 1 533µs 606µs 598µs 680µs 9% ▁▂▂█▆▇▇▄▂▂ 8888 path_hairline_small_AA_quad 9M 1 451µs 452µs 456µs 495µs 3% ▁▁▁▁█▁▁▁▁▁ 8888 path_hairline_small_AA_line /skia/trunk> cat ../new.txt maxrss loops min median mean max stddev samples config bench 9M 1 827µs 827µs 831µs 869µs 2% ▁▁▁▁▁▁▁█▁▁ 8888 path_hairline_small_AA_cubic 9M 1 515µs 517µs 517µs 518µs 0% ▇█▆▅▃▃▁▁▁▅ 8888 path_hairline_small_AA_conic 9M 1 310µs 311µs 315µs 332µs 2% ▂▁█▆▁▁▁▁▁▁ 8888 path_hairline_small_AA_quad 9M 1 254µs 254µs 258µs 276µs 3% ▁▁▁▁▁▁▁█▇▂ 8888 path_hairline_small_AA_line Edited revert of https://codereview.chromium.org/1085013003 TBR= Review URL: https://codereview.chromium.org/1078413003
* SkPDF/Device/ImageFilter: Fix ImageFilter fallback codeGravatar halcanary2015-04-15
| | | | | | | | | | Broken in https://chromium.googlesource.com/skia/+/76033be I have confirmed that this fixes 470083. BUG=470083 Review URL: https://codereview.chromium.org/1080923004
* Real fix for the Mali bug.Gravatar jvanverth2015-04-15
| | | | | | | | | The dFdy(st.y) computation seems to be better than the dFdx(st.x) computation on the Mali, so using that. The end result should be about the same. BUG=skia:3528 Review URL: https://codereview.chromium.org/1082913006
* remove randomness in dstreadshuffleGravatar joshualitt2015-04-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1085443005
* add blitter api for aa-hairlinesGravatar reed2015-04-15
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1088143002
* Change tessellator sweep direction to depend on path aspect ratio.Gravatar senorblanco2015-04-15
| | | | | | | | | | | | | The tessellating path renderer uses several sweep-line algorithms, whose sweep direction can be either in X or Y. It is currently set to in-X at compile time, but a better approach is to make it runtime-configurable, and use the path aspect ratio as a heuristic to determine the optimal sweep direction. BUG=skia:3725 Review URL: https://codereview.chromium.org/1089073002
* SkJpegCodecGravatar msarett2015-04-15
| | | | | | | | | | | | Enables basic decoding for jpegs Includes rewinding 565, YUV, and Jpeg encoding are not yet implemented BUG=skia:3257 Review URL: https://codereview.chromium.org/1076923002
* Revert of add new blit2 methods in support of antialiased hairlines guard ↵Gravatar jcgregorio2015-04-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | flag SK_SUPPORT_LEGACY_BLITANTIH2V2 (patchset #2 id:20001 of https://codereview.chromium.org/1060153003/) Reason for revert: DEPS roll is failing, one such example: http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/73847/steps/ash_unittests%20%28with%20patch%29/logs/stdio More here: https://codereview.chromium.org/1091483003 This CL was the only CL in the roll when things started to fail. Original issue's description: > add new blit2 methods in support of antialiased hairlines > > before: > 9M 1 528µs 530µs 539µs 607µs 5% ▁▁▁▁▁▁▁▁█▂ 8888 path_hairline_small_AA_quad > > after: > 9M 1 355µs 356µs 358µs 375µs 2% ▂▁▁▁▁▁▁▁▁█ 8888 path_hairline_small_AA_quad > > BUG=skia: > > does require new baselines (bug chrome is guarded) > > Committed: https://skia.googlesource.com/skia/+/dd83031b98db4c6d3d0de2353bf115152a7d1464 TBR=caryclark@google.com,reed@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1085013003
* Return cropBitmapGravatar zoran.jovanovic2015-04-15
| | | | | | | | | | | cropBitmap returns 'true' on success and 'false' on failure. Propagate its return value so that cascading failures can be avoided. Signed-off-by: Mykola Kondratenko <mykola.kondratenko@sonymobile.com> BUG=skia: Review URL: https://codereview.chromium.org/1088093003
* Convert BitmapTextBatch from STArray to AutoSTMallocGravatar joshualitt2015-04-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1088533002
* Roll common DEPS: fix string concat error in gs_utils uploadGravatar borenet2015-04-15
| | | | | | | TBR=jcgregorio BUG=skia:3723 Review URL: https://codereview.chromium.org/1057653006
* add new blit2 methods in support of antialiased hairlinesGravatar reed2015-04-14
| | | | | | | | | | | | | | before: 9M 1 528µs 530µs 539µs 607µs 5% ▁▁▁▁▁▁▁▁█▂ 8888 path_hairline_small_AA_quad after: 9M 1 355µs 356µs 358µs 375µs 2% ▂▁▁▁▁▁▁▁▁█ 8888 path_hairline_small_AA_quad BUG=skia: does require new baselines (bug chrome is guarded) Review URL: https://codereview.chromium.org/1060153003
* Convert BitmapTextBlob from using STArray to AutoSTMallocGravatar joshualitt2015-04-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1083703002
* DM: add --multiPage optionGravatar halcanary2015-04-14
| | | | | | | | | | | Motivation: I want to switch back to single-page output by default for direct comparison to raster backends in Gold. I can still test the multi-page option via a command-line switch. BUG=skia:3721 Review URL: https://codereview.chromium.org/1063873004
* Sk4h and Sk8h for SSEGravatar mtklein2015-04-14
| | | | | | | | | | These will underly the SkPMFloat-like class for uint16_t components. Sk4h will back a single-pixel version, and Sk8h any larger number than that. BUG=skia: Review URL: https://codereview.chromium.org/1088883005
* cleanup codec names being produced by dm and uploaded to goldGravatar djsollen2015-04-14
| | | | Review URL: https://codereview.chromium.org/1072933004
* Start canonicalizing color for all A8 textblobsGravatar joshualitt2015-04-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1076593002
* Rename SkNi to SkNb.Gravatar mtklein2015-04-14
| | | | | | | | | | | | | | | | As used today, SkNi is used in bool-y contexts. This keeps that, but under a new name, SkNb. This makes room for a new SkNi that's focused on integer-y things like loads, stores, arithmetic, etc. The main reason to split these is that we want different specializations for each use case: for bools, it's important for us to specialize 32- and 64-bit to support efficient float- and double- comparisons, but for integer work we're more likely to be looking at 8- and 16- bit lanes. Keeping these use cases siloed helps me manage the compexity of the backend NEON and SSE code. BUG=skia: Review URL: https://codereview.chromium.org/1083123002
* change hairline procs to take array of pointsGravatar reed2015-04-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1085883002
* Update common DEPS: adding retries to GS uploadGravatar borenet2015-04-14
| | | | | | BUG=skia:3723 Review URL: https://codereview.chromium.org/1083663006
* Add GM to exercise high quality anisotropic scalingGravatar robertphillips2015-04-14
| | | | | | | | High quality anisotropic is an interesting edge case for the gpu backend. For scales that are both minimizing and maximizing Ganesh falls back to MipMaps which can turn out too blurry. BUG=472864 Review URL: https://codereview.chromium.org/1058133003
* GM: add fadefilter gmGravatar halcanary2015-04-14
| | | | | | BUG=470083 Review URL: https://codereview.chromium.org/1081173002
* early return from stream peekGravatar caryclark2015-04-14
| | | | | | | | | Don't assert if resources are missing R=scroggo@google.com BUG=skia:3719 Review URL: https://codereview.chromium.org/1080073002
* Fixing use of initialized memory.Gravatar msarett2015-04-14
| | | | | | | | Disabling scanline decoding to kIndex8 until it can be implemented. BUG=skia:3715 Review URL: https://codereview.chromium.org/1082923002
* Enable tessellating GPU path renderer.Gravatar senorblanco2015-04-13
| | | | | | | | | | | | | This also contains a fix to remove recursion from the sorted_merge() step. This was essentially tail-recursion, and was causing stack exhaustion on some platforms. Making it iterative fixes the issue. Note: this CL will affect a large number of GPU GM results. R=bsalomon@google.com BUG= Review URL: https://codereview.chromium.org/1080113004
* Blacklist desk_wikipedia pdf on Valgrind botsGravatar borenet2015-04-13
| | | | | | BUG=skia:3506 Review URL: https://codereview.chromium.org/1056763004
* Set resScale on stroker when stroking path on gpu.Gravatar egdaniel2015-04-13
| | | | | | BUG=skia:3686 Review URL: https://codereview.chromium.org/1048333003
* Fix minor undercounting in SkRecord::bytesUsed().Gravatar mtklein2015-04-13
| | | | | | | | | | | | | | | | | | When an SkRecord has more than kInlineRecords ops in it (today, 5 or more), the current logic undercounts the bytes used by the SkRecord by sizeof(Record) * kInlineRecords, i.e. 32 bytes. This isn't a huge deal... by the time you've recorded 5 ops, we're typically up around 1KB anyway, and it's only ever off by that constant 32 bytes, so somewhere between 3% to 0% error as the picture grows. But now that I've noticed, we might as well fix it. Basically, this is a reminder that the inline space used to store those first kInlineRecords ops goes to waste once we pass that threshold. In contrast, fInlineAlloc, the space we preallocate for the SkVarAlloc, never goes to waste. It always holds the first few ops' data even when we grow past it. BUG=skia: Review URL: https://codereview.chromium.org/1081433002
* crank up innerloop to make hairlinebench more usable/reliableGravatar reed2015-04-13
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1087583002
* Make GrContext::freeGpuResources() purge the resource cacheGravatar bsalomon2015-04-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1082783002
* fix valgrind uninitialized issueGravatar caryclark2015-04-13
| | | | | | | R=mtklein@google.com BUG=skia:3654 Review URL: https://codereview.chromium.org/1082753002
* Revert "Enable tessellating GPU path renderer."Gravatar Stephen White2015-04-13
| | | | | | | | | | | This reverts commit c185019d009dbfcc8d07f267b0fd72ba1ce673d9. Reason for revert: Causing errors in DM runs. BUG=skia: TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1087563002
* Enable tessellating GPU path renderer.Gravatar senorblanco2015-04-13
| | | | | | | | | Note: this will affect a large number of GPU GM results. R=bsalomon@google.com BUG= Review URL: https://codereview.chromium.org/1084573003
* Update rebaselining process to be less Florin intensiveGravatar robertphillips2015-04-13
| | | | | | | NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1084583002 Review URL: https://codereview.chromium.org/1084583002
* Start caching masks / stroke fills for textblobsGravatar joshualitt2015-04-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1065293003