aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Add SampleApp that shows problems in strokingGravatar hstern2016-06-15
| | | | | | | | | | | | | | | - When the stroke width gets too big the raster algorithm produces incorrect output - This also causes the GPU path to produce incorrect output if the width is larger than an arbitrary limit in GrAALinearizingConvexPathRenderer (which is the renderer used for this specific geometry) - Other non-convex geometries probably also produce strange results BUG=skia:5405,skia:5406 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060903002 Review-Url: https://codereview.chromium.org/2060903002
* Actually fix leak in deferred_texture_image_dataGravatar bsalomon2016-06-15
| | | | | | | TBR=egdaniel@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068863003 Review-Url: https://codereview.chromium.org/2068863003
* Add test for rendering an already abandoned texture-backed SkImage.Gravatar bsalomon2016-06-15
| | | | | | | BUG=chromium:618858 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2067133002 Review-Url: https://codereview.chromium.org/2067133002
* Check for abandoned texture in GrTextureAdjuster::refTextureSafeForParamsGravatar bsalomon2016-06-14
| | | | | | | | | BUG=chromium:618858 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2063313002 TBR=egdaniel@google.com Review-Url: https://codereview.chromium.org/2063313002
* Revert of Refactoring of GPU NormalMap handling out into its own class ↵Gravatar egdaniel2016-06-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #7 id:120001 of https://codereview.chromium.org/2043393002/ ) Reason for revert: Breaking build and deps roll. Need to move include of SkBitmapProcShader in SkLightingShader.cpp from gpu include list to general list. Original issue's description: > Refactoring of GPU NormalMap handling out into its own class. > > The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources. > > What this CL includes: > > - Created a new 'NormalMapFP', out of the existing normal map reading behavior in LightingFP. > > - Encapsulates this new fragment processor on a new class NormalMapSource. > > - Created a NormalSource abstraction that will interface with SkLightingShader. > > - Adapted SkLightingShader to use the normals from its NormalSource field ON THE GPU SIDE. No changes done to the CPU side yet. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043393002 > > Committed: https://skia.googlesource.com/skia/+/87b0dd00cf9409c5fc990f5d0bb7c0df837f08da TBR=reed@google.com,dvonbeck@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2062133004
* Fix leak of GrContextThreadSafeProxy in deferred_texture_image_dataGravatar bsalomon2016-06-14
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069443004 Review-Url: https://codereview.chromium.org/2069443004
* Refactoring of GPU NormalMap handling out into its own class.Gravatar dvonbeck2016-06-14
| | | | | | | | | | | | | | | | | | | The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources. What this CL includes: - Created a new 'NormalMapFP', out of the existing normal map reading behavior in LightingFP. - Encapsulates this new fragment processor on a new class NormalMapSource. - Created a NormalSource abstraction that will interface with SkLightingShader. - Adapted SkLightingShader to use the normals from its NormalSource field ON THE GPU SIDE. No changes done to the CPU side yet. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2043393002 Review-Url: https://codereview.chromium.org/2043393002
* Fix GrShape to preserve inverseness of rrects for strokes but not dashes.Gravatar bsalomon2016-06-14
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2051263003 Review-Url: https://codereview.chromium.org/2051263003
* Bin circular blur profile textures by scale and blur to radius ratio.Gravatar bsalomon2016-06-14
| | | | | | | | This reduces the number of profile textures that will be generated throughout an animation and also caps the texture size. It could probably be better tuned. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062743003 Review-Url: https://codereview.chromium.org/2062743003
* SkMultiPictureDocument: don't rely on SkPicture::cullRectGravatar halcanary2016-06-14
| | | | | | | SkPicture::cullRect() is not guaranteed to be the same as the bounds passed to SkPictureRecorder::beginRecording(). Review-Url: https://codereview.chromium.org/2067473003
* Remove command buffer sample app support.Gravatar bsalomon2016-06-14
| | | | | | | | | | This hasn't compiled for months. We are deemphasizing SampleApp in favor of viewer. Windowed command buffer is not currently something we currently plan to maintain. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061233002 Review-Url: https://codereview.chromium.org/2061233002
* Store GLSL max samplers using uint32_t rather than uint8_tGravatar bsalomon2016-06-14
| | | | | | | TBR=egdaniel@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061123003 Review-Url: https://codereview.chromium.org/2061123003
* Another linux Vulkan fixGravatar jvanverth2016-06-14
| | | | | | | | BUG=skia: TBR=egdaniel@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069443003 Review-Url: https://codereview.chromium.org/2069443003
* Fix linux compile errorGravatar jvanverth2016-06-14
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069633002 TBR=egdaniel@google.com Review-Url: https://codereview.chromium.org/2069633002
* If we fail to create a window surface with sRGB, try again without.Gravatar brianosman2016-06-14
| | | | | | | | | Fixes crash when switching to sRGB mode on Nexus 9, among others. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066743003 Review-Url: https://codereview.chromium.org/2066743003
* Fix compile error (uninitialized variable use)Gravatar brianosman2016-06-14
| | | | | | | | | | | switch is already handling all cases, but some compilers don't care. This suppresses errors about potentially using vkLoadOp and vkStoreOp uninitialized. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2068523002 Review-Url: https://codereview.chromium.org/2068523002
* Quickly fix 0f to 0.0fGravatar liyuqian2016-06-13
| | | | | | | | | | | TBR=egdaniel@google.com So Visual Studio won't complain. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064863002 Review-Url: https://codereview.chromium.org/2064863002
* Create free list heap for suballocationGravatar jvanverth2016-06-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2029763002 Review-Url: https://codereview.chromium.org/2029763002
* Quickly fix the double to SkScalar issueGravatar liyuqian2016-06-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060823004 Review-Url: https://codereview.chromium.org/2060823004
* Display JPGs in Viewer with Split Screen and ColorSpaceXformGravatar liyuqian2016-06-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058753002 Review-Url: https://codereview.chromium.org/2058753002
* Move create_image_large in ImageTest.cpp inside #if SK_SUPPORT_GPUGravatar bsalomon2016-06-13
| | | | | | | TBR=egdaniel@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062943002 Review-Url: https://codereview.chromium.org/2062943002
* Revert of Clean up two unlaunched SSE 4.1 8888 blits. (patchset #1 id:1 of ↵Gravatar mtklein2016-06-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2062853002/ ) Reason for revert: Breaks a couple Google3 goldens. I need to rebaseline google3 with -DSK_SUPPORT_LEGACY_X86_BLITS first, then reland this. Original issue's description: > Clean up two unlaunched SSE 4.1 8888 blits. > > This code was running on our bots but never in Chrome. > That's a bad state to be in. > > My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly > for perfect correctness but also for speed, then to spread what I learned there > to SSE2, AVX+, and NEON. > > I have since lost interest in changing any aspect of how our legacy 8888 blits > work. There's not much point in making them a bit or two more correct when the > math is fundamentally wrong. > > This will cause many diffs in Gold, none perceptible. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062853002 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/6e472093009bf2fc4a8e53010b51040efcb71213 TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2066453003
* Revert of Add samples to Viewer. (patchset #4 id:60001 of ↵Gravatar egdaniel2016-06-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2056343004/ ) Reason for revert: breaking on android compile Original issue's description: > Add samples to Viewer. > > This adds support with animation, assuming the sample has > implemented onAnimate. Event handling has not been > implemented. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004 > > Committed: https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658 TBR=bsalomon@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2063883002
* Revert of Update typeface serialization style. (patchset #3 id:40001 of ↵Gravatar mtklein2016-06-13
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2030683002/ ) Reason for revert: serialize-8888 broken for typefacestyles on Mac. (Bold weighting goes missing.) Original issue's description: > Update typeface serialization style. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030683002 > > Committed: https://skia.googlesource.com/skia/+/7ae1c72e593823e6e300e4199558555765bcec17 TBR=reed@google.com,bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2067583002
* Fix SkImage::asLegacyBitmap() to respect color space infoGravatar msarett2016-06-13
| | | | | | | BUG=skia:5428 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061783002 Review-Url: https://codereview.chromium.org/2061783002
* Add prescale option to deferred paramsGravatar ericrk2016-06-13
| | | | | | | | | | | Currently, Skia always uploads GPU textures at full resolution. This change allows us to pass a pre-scale mip level to the deferred texture image logic, which causes us to pre-scale the image to the given mip level, and upload that mip level instead of the full image. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2007113008 Review-Url: https://codereview.chromium.org/2007113008
* Clean up two unlaunched SSE 4.1 8888 blits.Gravatar mtklein2016-06-13
| | | | | | | | | | | | | | | | | | | | | This code was running on our bots but never in Chrome. That's a bad state to be in. My plan here use to be to redesign how our 8888 blits worked in SSE 4.1, mainly for perfect correctness but also for speed, then to spread what I learned there to SSE2, AVX+, and NEON. I have since lost interest in changing any aspect of how our legacy 8888 blits work. There's not much point in making them a bit or two more correct when the math is fundamentally wrong. This will cause many diffs in Gold, none perceptible. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062853002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2062853002
* Update typeface serialization style.Gravatar bungeman2016-06-13
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030683002 Review-Url: https://codereview.chromium.org/2030683002
* Add control over whether lines are special cased in SkDashPath. Disable when ↵Gravatar bsalomon2016-06-13
| | | | | | | | called from GrShape. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055253002 Review-Url: https://codereview.chromium.org/2055253002
* skiaserve no longer crashes when no X server is presentGravatar ethannicholas2016-06-13
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2059263002 Review-Url: https://codereview.chromium.org/2059263002
* Add samples to Viewer.Gravatar jvanverth2016-06-13
| | | | | | | | | | | This adds support with animation, assuming the sample has implemented onAnimate. Event handling has not been implemented. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004 Review-Url: https://codereview.chromium.org/2056343004
* Better (?) interface for controlling sRGB-ness of mipmaps on GrTextureGravatar brianosman2016-06-13
| | | | | | | | | | | Switch to new SkSourceGammaTreatment type. Move to a separate setter, rather than an optional argument to dirty. Set the flag correctly after uploading CPU-built mips. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058143002 Review-Url: https://codereview.chromium.org/2058143002
* Request an sRGB FBO0 on Android. Fixes sRGB GL mode.Gravatar brianosman2016-06-13
| | | | | | | | | | | | Tried to comment my logic, but it's totally possible that we run on some device where this doesn't work. From a strict reading of the relevant specs, what I'm doing shouldn't work on the Nexus 5X, but it's necessary to get correct results. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054223002 Review-Url: https://codereview.chromium.org/2054223002
* Update SKP versionGravatar update-skps2016-06-13
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2065433003 Review-Url: https://codereview.chromium.org/2065433003
* tweak mipmap_srgb gm to use integer coordinatesGravatar reed2016-06-11
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061553002 TBR= Review-Url: https://codereview.chromium.org/2061553002
* Make large array of GrShapes in test code heap allocatedGravatar bsalomon2016-06-10
| | | | | | | TBR=mtklein@chormium.org GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058343002 Review-Url: https://codereview.chromium.org/2058343002
* Move multisampleDisableSupport into GrCapsGravatar csmartdalton2016-06-10
| | | | | | | | | | Non-platform code needs this information in order to make rendering decisions. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062443002 Review-Url: https://codereview.chromium.org/2062443002
* Type-erase SkAutoMutexAcquire and SkAutoExclusive.Gravatar mtklein2016-06-10
| | | | | | | | | | This is purely for convenience, to not need to write the lock type in the guard anymore. This should all inline away. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055023003 Review-Url: https://codereview.chromium.org/2055023003
* fix non-square stroke rects (non-aa)Gravatar reed2016-06-10
| | | | | | | | | fiddle showing bug: https://fiddle.skia.org/c/a21ecf5e33da84f52eba26e8c2f3d280 BUG=skia:5408 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060543002 Review-Url: https://codereview.chromium.org/2060543002
* Make SkBlitter hierarchy explicit about what needs to be implemented.Gravatar herb2016-06-10
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2053823002 Review-Url: https://codereview.chromium.org/2053823002
* Remove shaderc cmake compilingGravatar kjlubick2016-06-10
| | | | | | | | | It is no longer needed as of https://skia.googlesource.com/skia/+/b7b4293524e0c1d4c1635c4710aceafaca47b313 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2060503002 Review-Url: https://codereview.chromium.org/2060503002
* Implement SkFontMgr_Custom::onCreateFromFontData.Gravatar bungeman2016-06-10
| | | | | | | | | This fixes serialization issues. We could create a non-default gx typeface, but not deserialize it correctly. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057293002 Review-Url: https://codereview.chromium.org/2057293002
* Fix GrDrawContextPriv::stencilRectGravatar csmartdalton2016-06-10
| | | | | | | | | | | Updates stencilRect to not call getFillRectBatch. This method can return a batch that uses coverage AA, which isn't appropriate for stencil draws. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057613003 Review-Url: https://codereview.chromium.org/2057613003
* Extend inverse_paths GM to test dashingGravatar bsalomon2016-06-10
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2057213002 Review-Url: https://codereview.chromium.org/2057213002
* Create .gyp rules for shaderc librariesGravatar kjlubick2016-06-10
| | | | | | | | | | | To build shaderc, gyp used to punt to cmake, which did not work well on the bots and I couldn't find any way to pipe the variables into cmake which would have made it happy. So, I wrote a gyp file for shaderc and its dependencies. Nothing super complicated (thank goodness), except for the files that spirv-tools needed generated. BUG=skia:5186 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2047833003 Review-Url: https://codereview.chromium.org/2047833003
* respect srgb gamma when building mipsGravatar reed2016-06-10
| | | | | | | | | | | Proposed policy: - If the target is *legacy* (e.g. L32/PMColor) ignore gamma - If the target is S32/F16 respect gamma BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2029373004 Review-Url: https://codereview.chromium.org/2029373004
* Make GrShape capable of representing inverse filled rrects.Gravatar bsalomon2016-06-10
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056523002 Review-Url: https://codereview.chromium.org/2056523002
* add fail condition to addexpandedGravatar caryclark2016-06-10
| | | | | | | | | | | If coincident pairs don't match, give up rather than deref null. R=fmalita@chromium.org BUG=618991 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058773002 Review-Url: https://codereview.chromium.org/2058773002
* Cleanup VulkanWindowContext for use on AndroidGravatar djsollen2016-06-10
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058763002 Review-Url: https://codereview.chromium.org/2058763002
* Add blurcircles to blacklist for macmini4.1Gravatar bsalomon2016-06-10
| | | | | | | BUG=skia:5414 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2053373002 Review-Url: https://codereview.chromium.org/2053373002
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-01 01:00:53 +0000