aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipeGravatar piotaixr2014-10-22
| | | | | | | | | | Depend on https://codereview.chromium.org/663233002 BUG=skia:2947 Committed: https://skia.googlesource.com/skia/+/687732fe046c9cfec940f2d7f661cd97651d10a8 Review URL: https://codereview.chromium.org/613673005
* GP Emit Code takes a structGravatar joshualitt2014-10-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/666693012
* More genericity: overload isPaintOpaque(SkPaint, SkBitmap)Gravatar piotaixr2014-10-22
| | | | | | | | | | | Instead of taking a Bitmap as an argument this version takes only the type of content (None/Opaque/Transparent). This will be used to check the opaqueness of a SkPaint that draws a SkImage. BUG=skia:3042 Review URL: https://codereview.chromium.org/663233002
* Use correct size for font style name search.Gravatar bungeman2014-10-22
| | | | | | | | | | This fixes an out of bounds read introduced with a4c4a2d8cd65abb1e5ac20813831cdb9ace6c7ee "Replace SkTypeface::Style with SkFontStyle." BUG=chromium:425856 Review URL: https://codereview.chromium.org/645223006
* Picture shader resource caching.Gravatar fmalita2014-10-22
| | | | | | | | | | | | | Replace the current/naive shader caching mechanism with a more general implementation based on SkResourceCache. Caching the bitmap shader itself (as opposed to just the tile bitmap) makes for a chunkier key, but OTOH avoids allocating new shaders on cache hit. R=reed@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/671683004
* Ignore failure on internal botGravatar joshualitt2014-10-22
| | | | | | | BUG=skia:3023 TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/640063004
* Add back page_sets/skia_googlespreadsheet_desktopGravatar rmistry2014-10-22
| | | | | | | | | Absolutely could not get the old page to work so I just created a new page. NOTRY=true BUG=skia:3008 Review URL: https://codereview.chromium.org/671883002
* Track nested picture xform state for layer hoistingGravatar robertphillips2014-10-22
| | | | | | The accumulated matrix state of any enclosing SkPictures must be stored separate from the picture-local CTM. Any setMatrix calls inside a layer need to replace the picture-local CTM but concatenate with the enclosing SkPicture transform state (and the transform state needed to translate the layer to the correct location in the cached GrTexture). Review URL: https://codereview.chromium.org/639863005
* Update webpages_playback script and all page_sets to use new ↵Gravatar rmistry2014-10-22
| | | | | | | | | | | | | | | | skpicture_printer benchmark The purpose of this CL is to turn the RecreateSKPs bot green after https://codereview.chromium.org/665193002/ lands. Description of changes in this CL: * After https://codereview.chromium.org/665193002/ lands we will no longer need to copy the archives and pagesets to telemetry's data directory, I removed the code that did this in https://codereview.chromium.org/655313003/ * page_sets now need unique class names. Updated all page_sets to have unique class names. * Using the new --page_set_name and --page_set_base_dir and --also-run-disabled-tests parameters BUG=skia:3046 Review URL: https://codereview.chromium.org/671513009
* Bug fix for es 3.00 fb fetchGravatar joshualitt2014-10-21
| | | | | | | | patch for es 300 shader fb fetch BUG=skia: Review URL: https://codereview.chromium.org/665893008
* add round/ceil/etc. for SkMScalarGravatar reed2014-10-21
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/645793006
* Draw SKPs in 256x256 tiles in nanobench.Gravatar mtklein2014-10-21
| | | | | | | | (This CL will certainly trigger performance regression alerts. Tiled drawing is slower than non-tiled drawing.) BUG=skia: Review URL: https://codereview.chromium.org/669983002
* Implement maxrss for WindowsGravatar mtklein2014-10-21
| | | | | | | | | | No more -1 in the first column on Windows! E.g. http://build.chromium.org/p/client.skia/builders/Perf-Win8-ShuttleA-HD7770-x86_64-Release-Trybot/builds/0/steps/nanobench/logs/stdio BUG=skia: Review URL: https://codereview.chromium.org/661413004
* SkLazyPtr follow upsGravatar mtklein2014-10-21
| | | | | | | | | - moves test to LazyPtrTest.cpp - adds the ability to use a Create() method with an argument BUG=skia: Review URL: https://codereview.chromium.org/669783002
* Widen the set of nested rects that can be drawn natively on the GPUGravatar robertphillips2014-10-21
| | | | | | | | GrAARectRenderer::fillAANestedRects only handles thin stroked rects correctly if the margins are all the same. It is also correct if all the margins are >= 1.0f. This CL allows such cases to use the fillAANestedRects fast path. This seems to halve the gpu rendering time of the picture in bug crbug.com/425427. Review URL: https://codereview.chromium.org/672473002
* small tweaks to SkResourceCache::KeyGravatar mtklein2014-10-21
| | | | | | | | | - remove unused method and obsolete note - add a reminder that yes, we are checking counts are equal BUG=skia: Review URL: https://codereview.chromium.org/667993002
* use - and = to zoom text in slidesGravatar reed2014-10-21
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/668023002
* Fix debugger's SaveAs functionalityGravatar robertphillips2014-10-21
| | | | | | Without this patch the SaveAs functionality only copies the portion of the picture from the current command in the GUI. Review URL: https://codereview.chromium.org/672453002
* Check SkStream::isAtEnd before attempting to read.Gravatar scroggo2014-10-21
| | | | | | | | | | In FrontBufferedStream, when attempting to read and buffer more data, do not try to read if the underlying stream is at the end. Prevents a bug where we continue trying to read a stream that has nothing more to read. Review URL: https://codereview.chromium.org/665303002
* Add check to see if we need to remove fixed funciton VA in OptDrawStateGravatar egdaniel2014-10-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/667033003
* Rebaseline dftext GM for new color emoji test.Gravatar jvanverth2014-10-21
| | | | | | | BUG=skia:3033 TBR=mtklein@google.com Review URL: https://codereview.chromium.org/671513007
* Clean up some warnings about unused code.Gravatar mtklein2014-10-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/663093004
* add gradients and drawPaint to luaGravatar reed2014-10-21
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/667803004
* Add an assert that we still have a buffer to readFromBuffer().Gravatar mtklein2014-10-21
| | | | | | | | sk_free(fBuffer.detach()) means fBuffer will be left as NULL, not a zero-length malloc. BUG=skia: Review URL: https://codereview.chromium.org/669813002
* Fix image filters for PDF backend.Gravatar senorblanco2014-10-20
| | | | | | | | | | | | | | | | Currently, the PDF backend does not support image filters (since PDF does not have that functionality), so it simply removes them. This is causing Chrome print preview to render incorrectly (see bug). The fix here is to fall back to a raster device for image filters, as we used to do in Blink. The resulting bitmap will be drawn to the destination device as a normal main-memory-backed bitmap. Note: this change invalidates the PDF results of all GMs containing image filters (since they'll actually be rendered). BUG=422144 Review URL: https://codereview.chromium.org/644323006
* SkLazyPtr suitable as a local or class member.Gravatar mtklein2014-10-20
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/653183006
* Dilate approximated text bounds to squelch recent assertion failure.Gravatar mtklein2014-10-20
| | | | | | | | | This is once again an issue related to logo fonts, so I don't see any easy way to add a regression test for this. BUG=424824 Review URL: https://codereview.chromium.org/665103002
* Replace SkTypeface::Style with SkFontStyle.Gravatar bungeman2014-10-20
| | | | | | Committed: https://skia.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 Review URL: https://codereview.chromium.org/488143002
* Add color emoji fallback for distance field text.Gravatar jvanverth2014-10-20
| | | | | | BUG=skia:3033 Review URL: https://codereview.chromium.org/670533002
* Stop doing at-exit cleanup of lazy pointers.Gravatar mtklein2014-10-20
| | | | | | | | | | There are only a fixed number of them, and we're already intentionally leaking in Release. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN-Trybot BUG=skia:2940 Review URL: https://codereview.chromium.org/606013004
* Revert of Replace SkTypeface::Style with SkFontStyle. (patchset #9 id:160001 ↵Gravatar mtklein2014-10-20
| | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/488143002/) Reason for revert: CrOS GM failures: [*] 2 ExpectationsMismatch: fontmgr_iter_565.png fontmgr_iter_8888.png Original issue's description: > Replace SkTypeface::Style with SkFontStyle. > > Committed: https://skia.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 TBR=reed@google.com,bungeman@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/667023002
* Replace SkTypeface::Style with SkFontStyle.Gravatar bungeman2014-10-20
| | | | Review URL: https://codereview.chromium.org/488143002
* Move init() to Init() so that flag.Parse() can be called first.Gravatar jcgregorio2014-10-20
| | | | | | | | | Otherwise the --log_dir flag doesn't affect where glog output goes to. TBR=humper BUG=skia: Review URL: https://codereview.chromium.org/667493002
* Revert of Start to vectorize SkTileGrid. (patchset #48 id:1670001 of ↵Gravatar mtklein2014-10-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/634543004/) Reason for revert: breaks chrome GPU debug bots Original issue's description: > Start to vectorize SkTileGrid. > > This adds Sk4x.h to help. > > BUG=skia:3041 > > Committed: https://skia.googlesource.com/skia/+/90c7992bfc6330f070f7704d63372a0ec8410170 > > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot > > Committed: https://skia.googlesource.com/skia/+/958e9628d5f9a81aeafa78572cb4afc4b19a455a TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:3041 Review URL: https://codereview.chromium.org/637863005
* Remove content from public_headers.Gravatar scroggo2014-10-20
| | | | | | | | | The file is unused, but we cannot safely delete it until we remove the reference in a chromium gyp file. BUG=skia:2350 Review URL: https://codereview.chromium.org/663913003
* Add clip to layer cacheGravatar robertphillips2014-10-20
| | | | | | | | | | | This CL adds the clip region to the GPU layer hoisting image cache. It also switches back to the old caching behavior of using the entire CTM in the cache key rather then just the upper 2x2. This latter change is to focus more on hoisting rather then caching. It also includes 2 smaller fixes: a) layer's that have an image filter are no longer atlased (b.c. doing so complicates applying the image filter) b) the result of clipping the layer's bounds to the current clip is used as the hoisted layer's size. This reduces the amount of pixels drawn to match a normal (non-hoisted) draw pass. Review URL: https://codereview.chromium.org/640773004
* Fix clearing issue in render_picturesGravatar robertphillips2014-10-20
| | | | | | This bug only crops up when using the "--writeWholeImage" option in tile mode Review URL: https://codereview.chromium.org/664103003
* Remove unused parameters from filter_textureGravatar robertphillips2014-10-20
| | | | | | Trivial cleanup. Review URL: https://codereview.chromium.org/665863003
* Start to vectorize SkTileGrid.Gravatar mtklein2014-10-20
| | | | | | | | | | | | This adds Sk4x.h to help. BUG=skia: Committed: https://skia.googlesource.com/skia/+/90c7992bfc6330f070f7704d63372a0ec8410170 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot Review URL: https://codereview.chromium.org/634543004
* When rendering df fonts, pass drawText() down to drawPosText().Gravatar jvanverth2014-10-20
| | | | | | | | First pass at getting color emoji working for distance fields. BUG=skia:3033 Review URL: https://codereview.chromium.org/660853003
* Remove obsolete SkRecording.Gravatar mtklein2014-10-20
| | | | | | | | | | | Can land after https://codereview.chromium.org/664583002/ does. BUG=skia: Only API removed. TBR=reed@google.com Review URL: https://codereview.chromium.org/660903002
* Make SkImageDecoder_libpng be compilable with Chromium libpngGravatar kkinnunen2014-10-19
| | | | | | | | | | | | | Chromium has libpng with pngusr.h that disables certain functionality with defines. Use those defines when compiling SkImageDecoder_libpng.cpp. This makes it possible to use Skia PNG decoder and encoder when compiling dm with Chromium. Skia PNG decoder and encoder of course is not compiled to the skia library, but to dm with Chromium. BUG=skia:2992 Review URL: https://codereview.chromium.org/645883004
* add blurimagefilter to luaGravatar reed2014-10-19
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/663993002
* Update SKP versionGravatar skia-deps-roller2014-10-17
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/647973003
* Fix DMWriteTask to write PDF files correctlyGravatar halcanary2014-10-17
| | | | | | Previously, it was not rewinding the asset. Review URL: https://codereview.chromium.org/659793004
* bug_chomper: Cleanup template initialization.Gravatar tfarina2014-10-17
| | | | | | | | | | | | Use the same tricks used by webtry and perf. Code seems more robust and easier to check for errors this way. BUG=None TEST=./run_server.sh, then navigate to 127.0.0.1:8000 and 127.0.0.1:8000/res R=borenet@google.com Review URL: https://codereview.chromium.org/661613004
* Fix RecreateSKPs bot (again)Gravatar borenet2014-10-17
| | | | | | | | | | It's killing its own process... BUG=skia:3008 TBR=rmistry NOTRY=true Review URL: https://codereview.chromium.org/661203002
* Fix recreate_skps?Gravatar borenet2014-10-17
| | | | | | | | | | | | run_measurement was removed in https://codereview.chromium.org/655563007. Based on the comments, I think the right thing to do is replace it with run_benchmark. Hopefully this fixes the bot. BUG=skia: TBR=rmistry NOTRY=true Review URL: https://codereview.chromium.org/658513004
* bug fix for glsl identity stringGravatar joshualitt2014-10-17
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/659313004
* Add recreate_skps scriptGravatar borenet2014-10-17
| | | | | | BUG=skia:3008 Review URL: https://codereview.chromium.org/655313003