aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* remove (unused) scale parameter from measureTextGravatar reed2014-08-26
| | | | | | | | | BUG=skia: R=bungeman@google.com, djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/510433002
* SkAutoTDelete::operator T*()Gravatar halcanary2014-08-26
| | | | | | | | R=reed@google.com, bungeman@google.com, mtklein@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/506963002
* remove commented-out codeGravatar reed2014-08-26
| | | | | | | | | TBR=senorblanco@google.com NOTRY=True Author: reed@google.com Review URL: https://codereview.chromium.org/505253002
* Revert of Testing TBR'ing public API owners (patchset #1 of ↵Gravatar rmistry2014-08-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/486203009/) Reason for revert: Reverting whitespace change Original issue's description: > Testing TBR'ing public API owners > > BUG=skia:2870 > TBR=xyz,reed > NOTRY=true > > (SkipBuildbotRuns) > > Committed: https://skia.googlesource.com/skia/+/96b77dee4e985513abd4042db088bd286fd84383 TBR= NOTREECHECKS=true NOTRY=true BUG=skia:2870 (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/504193003
* Testing TBR'ing public API ownersGravatar rmistry2014-08-26
| | | | | | | | | | | | BUG=skia:2870 TBR=xyz,reed NOTRY=true (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/486203009
* SkData to SkStreamAsset to avoid unneeded copyingGravatar halcanary2014-08-26
| | | | | | | | R=mtklein@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/502193002
* Public API changes are allowed if an owner is TBR'ed.Gravatar rmistry2014-08-26
| | | | | | | | | | | | | | | The following TBR formats are supported: * TBR=reed * TBR=reed@google.com * TBR=xyz,reed * TBR=xyz,reed@google.com BUG=skia:2870 R=borenet@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/504843003
* retool image cache to be generic cache, allowing the client to subclass ↵Gravatar reed2014-08-26
| | | | | | | | | | | | | | | "Rec", so they can provide a custom Key and arbitrary Value. Follow-on CLs - rename ScaledimageCache to something like GeneralCache - explore if we can use call-backs or some mechanism to completely hide "lock/unlock", by forcing all clients to support "copying" their value out of the cache as the result of a Find. R=mtklein@google.com, senorblanco@google.com, bsalomon@google.com, qiankun.miao@intel.com, senorblanco@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/507483002
* Fix overflow when comparing two ints by promoting the sum to 64-bits.Gravatar djsollen2014-08-26
| | | | | | | | R=reed@google.com, scroggo@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/505153003
* Add text blob gm baselines.Gravatar Florin Malita2014-08-26
| | | | Review URL: https://codereview.chromium.org/504203002
* SkTextBlob plumbingGravatar fmalita2014-08-26
| | | | | | | | | | | Add SkTextBlob serialization + drawTextBlob() overrides. R=mtklein@google.com, reed@google.com, robertphillips@google.com BUG=269080 Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/499413002
* Remove unused header file in SkScaledImageCache.cppGravatar qiankun.miao2014-08-26
| | | | | | | | | BUG=skia: R=reed@google.com Author: qiankun.miao@intel.com Review URL: https://codereview.chromium.org/506783003
* Update SKP version to 84Gravatar borenet2014-08-26
| | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= BUG=skia: Author: borenet@google.com Review URL: https://codereview.chromium.org/506783006
* Implement NV_path_rendering on OpenGL ESGravatar kkinnunen2014-08-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement support for NV_path_rendering on OpenGL ES. Use glProgramPathFragmentInputGenNV function call instead of glPathTexGenNV to communicate transforms to fragment shader. The intention is that the NVPR paths will be drawn with the same shader program as non-NVPR geometry. For NVPR calls, the GPU will skip the vertex shader and just run the fragment shader. After program is linked, query the locations of the fragment shader inputs with glGetResourceLocation. The location will be used to set the transforms with glProgramPathFragmentInputGenNV. The functions and their workings are documented in: glProgramPathFragmentInputGenNV https://www.opengl.org/registry/specs/NV/path_rendering.txt (note: addition as of API version 1.3) glGetResourceLocation https://www.opengl.org/registry/specs/ARB/program_interface_query.txt http://www.opengl.org/registry/doc/glspec44.core.pdf (function is in core Open GL 4.4) Note: glProgramPathFragmentInputGenNV could be used also for OpenGL. However, using seems to trigger a bug in the driver. Disable this feature on OpenGL at least until the driver is fixed and released. The bug manifests in shadertext test, where the lower-left text pair is missing. Valgrind catches a bad read for the test and causes the context to OOM reproducibly. R=bsalomon@google.com, cdalton@nvidia.com, joshualitt@google.com, joshualitt@chromium.org Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/367643004
* Rebaselines for a6785ccb540 (Add a working SkFontMgr_fontconfig.)Gravatar bungeman2014-08-25
|
* Bound everything except drawText().Gravatar mtklein2014-08-25
| | | | | | | | | BUG=skia: R=robertphillips@google.com, fmalita@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/470063008
* Unfurl catch-all bounds(). This makes it a little easier to track progress.Gravatar mtklein2014-08-25
| | | | | | | | | | | | I think we've worked out the SaveLayer bounds as of crrev.com/496963003, so remove that TODO. BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/501153002
* Rebaselines for a6785ccb540 (Add a working SkFontMgr_fontconfig.)Gravatar bungeman2014-08-25
|
* Fix recursive computation of filter bounds for drop shadow,Gravatar senorblanco2014-08-25
| | | | | | | | | | | | | | | | | | | | | | morphology, blur. [Reland with fixed tests.] Because we're computing "backwards" from a clip rect of destination pixels to be filled to the required source pixels, we should use tail recursion rather than head recursion in onFilterBounds(). This actually only makes a difference for drop-shadow, where the computation is non-commutative. Blur and morphology commute, but I moved them to tail recursion anyway for clarity (so all onFilterBounds use tail recursion). BUG=skia: R=bsalomon@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/481273005
* Revert of Benchmark designed to exercise fractional image scale/translation ↵Gravatar djsollen2014-08-25
| | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 of https://codereview.chromium.org/491793003/) Reason for revert: fires asserts on Linux Debug builds http://108.170.220.120:10115/builders/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/builds/1910 Original issue's description: > Benchmark designed to exercise fractional image scale/translation > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/5fc226641a0926dddbf70ba784f344881f4c05b9 R=reed@google.com, humper@google.com TBR=humper@google.com, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: djsollen@google.com Review URL: https://codereview.chromium.org/470063007
* Add a working SkFontMgr_fontconfig.Gravatar bungeman2014-08-25
| | | | | | | | R=tomhudson@google.com, reed@google.com, mtklein@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/396143004
* Benchmark designed to exercise fractional image scale/translationGravatar humper2014-08-25
| | | | | | | | | BUG=skia: R=reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/491793003
* gradtext also needed rebaselining from the gamma changeGravatar Mike Klein2014-08-25
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/501113002
* Require length in sk_wchar_to_string.Gravatar bungeman2014-08-25
| | | | | | | | | | | | | This information is already available at all call sites and allows the call to WideCharToMultiByte to not overwrite the '\0' in the writable_str() which isn't really writable. BUG=skia:1989 R=reed@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/500113002
* Rebaseline 565 precision changes and matrixconvolution.Gravatar Mike Klein2014-08-25
| | | | | | BUG=skia:2797 Review URL: https://codereview.chromium.org/504873002
* Document return value of SkPaint::operator==.Gravatar mtklein2014-08-25
| | | | | | | | | BUG=skia:1491 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/467063003
* Revert of Fix recursive computation of filter bounds for drop shadow, ↵Gravatar djsollen2014-08-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 of https://codereview.chromium.org/481273005/) Reason for revert: This CL is currently breaking the Win7 and Win8 bots on some of the new tests (in DM). Original issue's description: > Fix recursive computation of filter bounds for drop shadow, > morphology, blur. > > Because we're computing "backwards" from a clip rect of destination > pixels to be filled to the required source pixels, we should use tail > recursion rather than head recursion in onFilterBounds(). > > This actually only makes a difference for drop-shadow, where > the computation is non-commutative. Blur and morphology commute, but I > moved them to tail recursion anyway for clarity (so all onFilterBounds > use tail recursion). > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/28648fe4a69b0cee8df42b5966e4e645c3aabefb R=bsalomon@google.com, senorblanco@chromium.org TBR=bsalomon@google.com, senorblanco@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: djsollen@google.com Review URL: https://codereview.chromium.org/504773003
* Fix recursive computation of filter bounds for drop shadow,Gravatar senorblanco2014-08-25
| | | | | | | | | | | | | | | | | | | | morphology, blur. Because we're computing "backwards" from a clip rect of destination pixels to be filled to the required source pixels, we should use tail recursion rather than head recursion in onFilterBounds(). This actually only makes a difference for drop-shadow, where the computation is non-commutative. Blur and morphology commute, but I moved them to tail recursion anyway for clarity (so all onFilterBounds use tail recursion). BUG=skia: R=bsalomon@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/481273005
* XPS to use PathOps for inverse winding paths.Gravatar bungeman2014-08-25
| | | | | | | | R=caryclark@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/484343003
* Reverse swap order in DirectWrite typeface.Gravatar bungeman2014-08-25
| | | | | | | | | | | C++ forbids temporaries to bind to non-const references. VC++ allows you to do so anyway, but it makes clang on Windows sad. R=reed@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/487533004
* add const to arrays of member functionsGravatar caryclark2014-08-25
| | | | | | | | | | | | | running 'size ./out/Release/libskia_core.a' revealed a couple of places where path ops chose poorly and declared arrays of member functions to be unnecessarily writable. R=reed@android.com TBR=reed Author: caryclark@google.com Review URL: https://codereview.chromium.org/461363003
* Add SK_API to SkTextBlob and SkTextBlobBuilder.Gravatar jbroman2014-08-25
| | | | | | | | | BUG=skia:2868 R=fmalita@chromium.org, reed@google.com Author: jbroman@chromium.org Review URL: https://codereview.chromium.org/497993002
* remove SkPurgeGlobalDiscardableMemoryPoolGravatar halcanary2014-08-25
| | | | | | | | | BUG=skia:2721 R=reed@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/495453004
* Clean up useless comments in SkScaledImageCache.hGravatar qiankun.miao2014-08-25
| | | | | | | | | BUG=skia: R=reed@google.com Author: qiankun.miao@intel.com Review URL: https://codereview.chromium.org/499203002
* Update SKP version to 82Gravatar borenet2014-08-23
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/499893002
* Update SKP version to 81Gravatar borenet2014-08-22
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/497343002
* Don't leak the shader by reffing twice in SkRectShaderImageFilter.Gravatar mtklein2014-08-22
| | | | | | | | | BUG=skia: R=bsalomon@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/501563002
* Disable Neon optimization of bad S32A/D565 blend.Gravatar mtklein2014-08-22
| | | | | | | | | | | | BUG=skia:2797 Committed: https://skia.googlesource.com/skia/+/84cab93186fbe3e87d931fea73cb31b70ff5017b R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/497823002
* Copy Ubuntu12 RenderSKPs expectations for Recipes botGravatar borenet2014-08-22
| | | | | | | | | | | | This is in preparation for implementing the render_skps workflow in recipes. BUG=skia:761 R=epoger@google.com, stephana@google.com TBR=epoger, stephana Author: borenet@google.com Review URL: https://codereview.chromium.org/496283005
* Add testing flag for XPS for deterministic ids.Gravatar Ben Wagner2014-08-22
| | | | | | | BUG=skia:455 R=mtklein@google.com Review URL: https://codereview.chromium.org/494423002
* Fix leak of GrResourceCacheEntryGravatar bsalomon2014-08-22
| | | | | | | | | R=robertphillips@google.com TBR=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/502543002
* Disable Neon optimization of bad S32A/D565 blend.Gravatar mtklein2014-08-22
| | | | | | | | | BUG=skia:2797 R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/497823002
* Support comment groups in SkRecord.Gravatar mtklein2014-08-22
| | | | | | | | | | | This should fix the failing paint-command-log-nodes.html layout test. BUG=406425 R=tomhudson@chromium.org Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/501533003
* suppress matrixconvolutionGravatar Mike Klein2014-08-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/476283003
* Fix saveLayer() with a pixel-moving filter vs SkBBoxHierarchyRecord / ↵Gravatar mtklein2014-08-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | SkRecordDraw In SkBBoxHierarchyRecord: Since the bounds we pass to saveLayer are in the pre-filtering coordinate space, they aren't correct for determining the actual device pixels touched by the saveLayer in this case. The easiest fix for now is to pass the clip bounds, since the final draw done in restore() will never draw outside the clip. In SkRecordDraw: We do adjust the bounds passed to saveLayer, so we just need to make sure that when we're using a paint that may affect transparent black, we ignore the calculated bounds of draw ops and use the clip intersected with those adjusted bounds. See originally crrev.com/497773002 BUG=skia: R=reed@google.com, senorblanco@chromium.org, junov@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/496963003
* Fix leak in multipicturedraw GMs.Gravatar bsalomon2014-08-22
| | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/502493002
* [SkTextBlob] Merge run font data at draw time.Gravatar fmalita2014-08-22
| | | | | | | | R=bungeman@google.com, reed@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/496773002
* extend SkShader to report a luminance-color to be used for gamma correctionGravatar reed2014-08-22
| | | | | | | | | BUG=skia:590 R=bungeman@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/492963002
* disable neon proc that is triggering assertsGravatar reed2014-08-22
| | | | | | | | | BUG=skia:2845 R=mtklein@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/498733002
* Some early 565 rebaselines.Gravatar Mike Klein2014-08-22
| | | | | | BUG=skia:2797 Review URL: https://codereview.chromium.org/488453003