aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* remove device field from SkDrawGravatar Mike Reed2017-02-22
| | | | | | | | | BUG=skia:6214 Change-Id: I5d57feb3e92f2c1691231c982e74020560febeca Reviewed-on: https://skia-review.googlesource.com/8837 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkClipStack: add bounds() and isEmpty() methodsGravatar Hal Canary2017-02-22
| | | | | | | | | Also: update some of SkPDF to use these rather than the RasterClip. Change-Id: I5a2564d2269c145135df6a8eda65ab05e4aeaf14 Reviewed-on: https://skia-review.googlesource.com/8159 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkExecutorGravatar Mike Klein2017-02-22
| | | | | | | | | | | | | | | | | | Refactoring to refamiliarize myself with SkTaskGroup and SkThreadPool. This adds an SkExecutor interface to describe how we use SkThreadPool, with a global setter and getter for a default instance. Then I rewrote SkTaskGroup to work with any executor, the global default by default. I also think I've made the SkTaskGroup::wait() borrow logic clearer with the addition of SkSemaphore::try_wait(). This lets me keep the semaphore count and actual count of work in perfect sync. Change-Id: I6bbdfaeb0e2c3a43daff6192d34bc4a3f7210178 Reviewed-on: https://skia-review.googlesource.com/8836 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fold MSAN awareness into SkJumper.cpp.Gravatar Mike Klein2017-02-22
| | | | | | | | | | | This is preparation for removing skia_enable_jumper, making it true. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-MSAN Change-Id: I21763ea5ebafaaddda7056176796307f1a81d722 Reviewed-on: https://skia-review.googlesource.com/8830 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Reland "CQ config: add gerrit CQAbility verifier."Gravatar Andrii Shyshkalov2017-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 02241e976b34c8bc4b2d4add2f0c881d8a8d2bc1. Reason for revert: cq proto has been rolled to depot_tools. Original change's description: > Revert "CQ config: add gerrit CQAbility verifier." > > This reverts commit 04628221324eb2e5b329a8fd9c69196ea9acb43c. > > Reason for revert: Lets revert until the proto is rolled into Skia. > > Original change's description: > > CQ config: add gerrit CQAbility verifier. > > > > Goal is to ensure that unreviewed and untrusted code isn't sent through > > CQ to try bots, by accident or through malicious intent. > > > > R=​rmistry@google.com > > BUG=chromium:692613 > > NOTRY=True > > > > Change-Id: I750be91895f5b77229b8f4a22216f00eaa75f7a0 > > Reviewed-on: https://skia-review.googlesource.com/8620 > > Reviewed-by: Ravi Mistry <rmistry@google.com> > > Commit-Queue: Ravi Mistry <rmistry@google.com> > > > > TBR=rmistry@google.com,reviews@skia.org,tandrii@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:692613 > > Change-Id: I6d4b821b2a02ef3e097cf68cd8ebfb2b51d4d165 > Reviewed-on: https://skia-review.googlesource.com/8663 > Reviewed-by: Ravi Mistry <rmistry@google.com> > Commit-Queue: Ravi Mistry <rmistry@google.com> > R=rmistry@google.com,reviews@skia.org,tandrii@google.com # Not skipping CQ checks because original CL landed > 1 day ago. BUG=chromium:692613 Change-Id: Icefcd69b4608e5294f358de66a9ce014c9950ede Reviewed-on: https://skia-review.googlesource.com/8740 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Remove GrPipelineBuilder.cppGravatar Brian Salomon2017-02-22
| | | | | | | Change-Id: I14c26f2967e4722fa4d6ce4664a5857add0cf854 Reviewed-on: https://skia-review.googlesource.com/8822 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* GrTessellator: misc. cleanups and minor tweaks.Gravatar Stephen White2017-02-22
| | | | | | | | | | | | | | | | | | | | | Invert some math to remove a negation. Don't keep a persistent count in EdgeList; we'll test for degenerate boundaries in boundary_to_aa_mesh(). Make connect() use the top/bottom ordering that new_edge has already done for us. Don't add the an edge to the same poly twice when it's easily detectable. Remove some superfluous variables and intialization. BUG=skia: Change-Id: I0efd9ec385d6dfec8950b7acfc6dd25572f667b5 Reviewed-on: https://skia-review.googlesource.com/8784 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Remove special build for Valgrind.Gravatar Ben Wagner2017-02-22
| | | | | | | | | | | Valgrind uses the unmodified binary. See skia:6267. BUG=skia:6267 Change-Id: I3fcecf9ffce67ebec88d4005e464c66d25c6aa21 Reviewed-on: https://skia-review.googlesource.com/8833 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix tasks.json after crossed CLs.Gravatar Ben Wagner2017-02-22
| | | | | | | | | | | | | These two CLs caused failure on Housekeeper-PerCommit-InfraTests: https://skia-review.googlesource.com/8839 https://skia-review.googlesource.com/8805 NOTRY=true Change-Id: Ie27c2fd73186cdd4d9ae5528635bc9690df03210 Reviewed-on: https://skia-review.googlesource.com/8845 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* SkJumper: remove TODO.Gravatar Mike Klein2017-02-22
| | | | | | | | | | Starting with uninitialized vectors is only minorly faster (<0.5%). I'd rather keep the zeroes and feel warm and fuzzy. Change-Id: Ib28aef9c9a75f53e2ab645bfb094582e30b7df07 Reviewed-on: https://skia-review.googlesource.com/8825 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add eGPU jobs.Gravatar Ben Wagner2017-02-22
| | | | | | | Change-Id: Ia160d3b17abebf0075f8ce2b608653e496f46d58 Reviewed-on: https://skia-review.googlesource.com/8805 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix Mesa compileGravatar Brian Osman2017-02-22
| | | | | | | | | | BUG=skia: Change-Id: Id532233537d18e6185a83681188aa73527b212a1 Reviewed-on: https://skia-review.googlesource.com/8842 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* SkRegion: change serialization unit tests, better validation codeGravatar Hal Canary2017-02-22
| | | | | | | | | Also: Don't alloc before validation. Change-Id: Ic2e007ecf4e06fb099366295b963f66df3f7903a Reviewed-on: https://skia-review.googlesource.com/8728 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Do not retry test or perf tasksGravatar Eric Boren2017-02-22
| | | | | | | | | BUG=skia: Change-Id: I153978a92420eb2c39024213ebcdf95d1b8bde30 Reviewed-on: https://skia-review.googlesource.com/8839 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Whitespace change to test new submit strategy IIGravatar Ravi Mistry2017-02-22
| | | | | | | | | | BUG=skia: NOTRY=true Change-Id: I1dd15dcc85967689a55b9661807dd9eab135f014 Reviewed-on: https://skia-review.googlesource.com/8843 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Whitespace change to test new submit strategy IGravatar Ravi Mistry2017-02-22
| | | | | | | | | BUG=skia: NOTRY=true Change-Id: I9a20af0c57d98f86794d6ce6f37ee8200fe8e088 Reviewed-on: https://skia-review.googlesource.com/8840 Reviewed-by: Ravi Mistry <rmistry@google.com>
* Whitespace change to test new submit strategy IIGravatar Ravi Mistry2017-02-22
| | | | | | | | | | BUG=skia: NOTRY=true Change-Id: I21778ed732f53f2216cfc007c43016c83926176a Reviewed-on: https://skia-review.googlesource.com/8841 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Support shared GL contexts in GrContextFactoryGravatar Brian Osman2017-02-22
| | | | | | | | | | | | | | | | Mostly plumbing, plus some minimal testing to make sure that the platform APIs don't explode. I plan to add testing of SkCrossContextImageData using this, which should verify that textures are actually shared. Also found a factory and some related code in the CommandBuffer test context that was totally unused. BUG=skia: Change-Id: I05bbc22c4d1ef946b702a5cc7f67788785219c62 Reviewed-on: https://skia-review.googlesource.com/8808 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* remove guard for SkImageGenerator apiGravatar Mike Reed2017-02-22
| | | | | | | | | BUG=skia: Change-Id: I0c01fbf935be5d933aa2ef67a0fb2edba4941fa7 Reviewed-on: https://skia-review.googlesource.com/8835 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* expore flags for text decoration into android-specific reserved bitsGravatar Mike Reed2017-02-22
| | | | | | | | | | | BUG=skia:6250 precursor to https://skia-review.googlesource.com/c/8815/ Change-Id: I0ff13ff99299edcb7809a2088e0ace61bc8cc60d Reviewed-on: https://skia-review.googlesource.com/8816 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkConvertPixels: Add Alpha8 fast pathGravatar Matt Sarett2017-02-22
| | | | | | | | | BUG:692936 Change-Id: I8394554764b1f46bd8eaabb0194d52f361d477c1 Reviewed-on: https://skia-review.googlesource.com/8826 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Split Valgrind jobs -- one DM/NB run per task.Gravatar Ben Wagner2017-02-22
| | | | | | | | | | | | Reland of https://skia-review.googlesource.com/c/8723/1 BUG=skia:2789 NOTRY=true Change-Id: I1fbd314457a9d411543c8d7af4df166608d1acc7 Reviewed-on: https://skia-review.googlesource.com/8832 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Split Valgrind jobs -- one DM/NB run per task."Gravatar Ben Wagner2017-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit bc9cd524d8ce8fd61ff6e49fa2a6e2a26a069874. Reason for revert: Unable to find Valgrind binary. Original change's description: > Split Valgrind jobs -- one DM/NB run per task. > > Remove special build for Valgrind -- Valgrind uses the unmodified binary. See skia:6267. > > BUG=skia:2789,skia:6267 > > Change-Id: Id56c460abf36eb2be633ac3a309e0dbc7a278f41 > Reviewed-on: https://skia-review.googlesource.com/8723 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Eric Boren <borenet@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,borenet@google.com,mtklein@google.com,benjaminwagner@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2789,skia:6267 Change-Id: I16876a8528c441805931ed21e9aa8688ab2e0b4c Reviewed-on: https://skia-review.googlesource.com/8831 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Omit encode-platform on N5 for all configs.Gravatar Ben Wagner2017-02-21
| | | | | | | | | BUG=skia:5876 Change-Id: Icfd000638290418870df857722317c62cb6942d9 Reviewed-on: https://skia-review.googlesource.com/8827 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Whoops, forgot to re-run build_stages.Gravatar Mike Klein2017-02-21
| | | | | | | Change-Id: I723ae1ecaebf43e84bf47163e44e7899faf31c8a Reviewed-on: https://skia-review.googlesource.com/8824 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Split Valgrind jobs -- one DM/NB run per task.Gravatar Ben Wagner2017-02-21
| | | | | | | | | | | | Remove special build for Valgrind -- Valgrind uses the unmodified binary. See skia:6267. BUG=skia:2789,skia:6267 Change-Id: Id56c460abf36eb2be633ac3a309e0dbc7a278f41 Reviewed-on: https://skia-review.googlesource.com/8723 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* fixed SPIR-V vector equality testsGravatar Ethan Nicholas2017-02-21
| | | | | | | | | BUG=skia: Change-Id: I6ae597d16c0bd17ce4c0316e7ef65cd52643f4b7 Reviewed-on: https://skia-review.googlesource.com/8804 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Move looping logic into start_pipeline().Gravatar Mike Klein2017-02-21
| | | | | | | | | | | | | | | | This should be a big win on Windows, but I haven't timed there yet. On my Mac, it's a solid 2% speedup. PS1 was insufficiently ambitious, but was this for posterity: No need to vzeroupper twice on Windows. On Windows start_pipeline() will vzeroupper, so no need to do it in just_return(). Change-Id: I099320b95da85900a60ce96fdb7a216a36db1858 Reviewed-on: https://skia-review.googlesource.com/8821 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Print GL shader source with line numbers when there is a compile errorGravatar csmartdalton2017-02-21
| | | | | | | | | BUG=skia: Change-Id: I06bad4aacf5992d8207881f59f20615479536481 Reviewed-on: https://skia-review.googlesource.com/8562 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Make GrXferProcessor and related classes private.Gravatar Brian Salomon2017-02-21
| | | | | | | Change-Id: I81ea6f5ea5c8b7b23848ef24524a7e48e531efe8 Reviewed-on: https://skia-review.googlesource.com/8819 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Make sure fuzzer can't pick an illegal colortypeGravatar Kevin Lubick2017-02-21
| | | | | | | | | BUG=skia:6216 Change-Id: Ifb0a0a1e634bb291c586d2094401ec10349dcd0e Reviewed-on: https://skia-review.googlesource.com/8817 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Remove SkSpecialImage's GrTexture-based ctorsGravatar Robert Phillips2017-02-21
| | | | | | | Change-Id: Id71b8ab0477cd1d459089d97af27d63f9f08d21b Reviewed-on: https://skia-review.googlesource.com/7889 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Rename GrContextFactory::ContextOptions to ContextOverridesGravatar csmartdalton2017-02-21
| | | | | | | | | | | | | Also changes the behavior of these flags to only override their corresponding context options when set, and to leave them unchanged when not set. BUG=skia: Change-Id: I09f6be09997594fa888d9045dd4901354ef3f880 Reviewed-on: https://skia-review.googlesource.com/8780 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Fix ComposeOneFragmentProcessor coverage as alpha optimization.Gravatar Brian Salomon2017-02-21
| | | | | | | | | It should only be advertised if the child also advertises it. Change-Id: I698213c9562d710dff45f0622d50eacc41e29af5 Reviewed-on: https://skia-review.googlesource.com/8811 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* SkPath.readFromMemory: check for error caseGravatar Hal Canary2017-02-21
| | | | | | | | | | | | | Fuzzing can produce inconsistant data, such as flags or bounds. Also, use std::unique_ptr to reduce the need for calling `delete`. BUG=skia:6262 BUG=skia:6263 Change-Id: I1de6b5f764cda346bb3cd5cd4698816b6b68f395 Reviewed-on: https://skia-review.googlesource.com/8812 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* Clamp gradient colors in fragment shader after interpolation when there is a ↵Gravatar Brian Salomon2017-02-21
| | | | | | | | | | | color space. This matches what is done in the LUT texture case. Change-Id: I95ab8c9ac761a3315a55a7f81bfe2e4077070542 Reviewed-on: https://skia-review.googlesource.com/8813 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* SkJumper: WindowsGravatar Mike Klein2017-02-21
| | | | | | | | | | | | | - Compile stages with -DWIN to pick up MS-specific start_pipeline(). - Add SkJumper_generated_win.S with MS-specific assembly. - Add a minimal asm tool to our GN Windows toolchain. The SkRasterPipeline_f16 benchmark run ~4x faster on my desktop. Change-Id: Ia45afb4ecb6a055e2c0e43f0f54f59e081c23b7f Reviewed-on: https://skia-review.googlesource.com/8778 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* GrTessellator (AA): implement fast path for removing non-boundary edges.Gravatar Stephen White2017-02-21
| | | | | | | | | | | | | | | Instead of using a full tessellate() pass, which allocates Polys, MonotonePolys, etc. It's faster to simply accumulate the winding number in the left-adjacent edge, and use that to remove non-boundary edges (edges for which apply_fill_type() returns the same value on either side of the edge). This gives ~4-5% boost on MotionMark Fill Shapes. Change-Id: I66bd4248ace01a8c35abd99519f4c455f936e5e5 Reviewed-on: https://skia-review.googlesource.com/8782 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* initial clean up of pdf clippingGravatar Mike Reed2017-02-21
| | | | | | | | | | | clipstack is always available, canvas checks for empty clips up-front Next step is to clarify if PDF wants to use Regions or Clipstack for its clipping (but not both) Change-Id: Iaf1fa35160291e08c33ff61114557deff72304b3 Reviewed-on: https://skia-review.googlesource.com/8692 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add GrTFlagsMask<> wrapper for C++11 bitfield enumsGravatar csmartdalton2017-02-21
| | | | | | | | | | | | | | | | | | | | Previously, operator& for enum class bitfields was reserved only to return a bool. e.g: if (flags & Flags::kFlag) This change adds a new template class GrTFlagsMask<> that gets instantiated by operator~ and allows us to write expressions like: flags &= ~Flags::kFlag (flags & ~Flags::kFlag1) | Flags::kFlag2 BUG=skia: Change-Id: I21e5eb9304135e82cdda459e8a833a3489f6beaf Reviewed-on: https://skia-review.googlesource.com/8563 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Update milestone schedule on skia.orgGravatar Heather Miller2017-02-21
| | | | | | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=8809 Change-Id: Ic46ee37e90f90ebf6826cf5ead18bfd5ed75817a Reviewed-on: https://skia-review.googlesource.com/8809 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* move PDFDevice over to cipstackdeviceGravatar Mike Reed2017-02-21
| | | | | | | | | BUG=skia:6214 Change-Id: I3fc5d49e9197ecff9d83ac50f24a67cccd99a092 Reviewed-on: https://skia-review.googlesource.com/8803 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Remove unneeded is_fuzzing flagGravatar Kevin Lubick2017-02-21
| | | | | | | | | BUG=skia:6260 Change-Id: Id27ac7f64276f87f86719bf4fc3f8834466320ab Reviewed-on: https://skia-review.googlesource.com/8800 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add machine_type dimension to disambiguate bots with GTX960.Gravatar Ben Wagner2017-02-21
| | | | | | | | | BUG=skia: Change-Id: Id66505d2e45cfff0bb31f630d96f7a78ad2f701b Reviewed-on: https://skia-review.googlesource.com/8721 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Simplify GrPaint::isConstantBlendedColor to avoid FP analysis and XP virtual ↵Gravatar Brian Salomon2017-02-21
| | | | | | | | | | | calls This was the only non-test user of GrXPFactory::isConstantPreCoverageBlendedColor which is now removed. Change-Id: Ic1c130d30a44e1a955b89f8912433a3c9df2e61e Reviewed-on: https://skia-review.googlesource.com/8776 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Improve SkCanvas::temporary_internal_getRgnClip performanceGravatar Stan Iliev2017-02-21
| | | | | | | | | | | | | Improve temporary_internal_getRgnClip performance for rect clips by avoiding SkClipStack::asPath. BUG=skia: Change-Id: I371ac6031df325646841d57c4afaba7b835a12bb Reviewed-on: https://skia-review.googlesource.com/8688 Commit-Queue: Stan Iliev <stani@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Prefer EllipseOp instead of DIEllipseOpGravatar Stan Iliev2017-02-21
| | | | | | | | | | | | Prefer EllipseOp instead of DIEllipseOp, which improves the performance. BUG=skia: Change-Id: I607c21326b44a80e0586c577349452a9c369488f Reviewed-on: https://skia-review.googlesource.com/8690 Commit-Queue: Stan Iliev <stani@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Remove GrProcessorTestData's GrTexturesGravatar Robert Phillips2017-02-21
| | | | | | | | | | | (No longer) Blocked on: https://skia-review.googlesource.com/c/8450/ (Remove asTextureRef from SkSpecialImage & update effects accordingly (take 2)) This also (unfortunately) picks up a few straggling effects that didn't have a sk_sp<GrTextureProxy> factory. Change-Id: I5ce583a084aa8fe00e866eec1db90e2ec9dd2ab0 Reviewed-on: https://skia-review.googlesource.com/8500 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Move declaration of is_fuzzer to where it is usedGravatar Ravi Mistry2017-02-21
| | | | | | | | | BUG=skia:6260 Change-Id: Iaca4fb1afb4d182f4d2ae64d939729363a226ce6 Reviewed-on: https://skia-review.googlesource.com/8772 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Store GrRenderTarget rather than just its ID in ↵Gravatar Brian Salomon2017-02-21
| | | | | | | | | | | GrRenderTargetOpList::RecordedOp. This will allow us to feed the op's their render target when they don't have a pipeline before execution. Change-Id: I01f16bec32e930c0152105a9179306159cb14dc4 Reviewed-on: https://skia-review.googlesource.com/8693 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>