| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2105113002
Review-Url: https://codereview.chromium.org/2105113002
|
|
|
|
|
|
| |
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2107013002
Review-Url: https://codereview.chromium.org/2107013002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103973002
Review-Url: https://codereview.chromium.org/2103973002
|
|
|
|
|
|
|
|
|
|
|
| |
When the configs are the same in Vulkan we know we can do write pixels,
but the caller may need to do a draw, so make sure we set up the
tempDrawInfo before returning.
BUG=skia:5461, skia:5458
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108873003
Review-Url: https://codereview.chromium.org/2108873003
|
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
Committed: https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
Review-Url: https://codereview.chromium.org/2108523002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/2108523002/ )
Reason for revert:
Assertion failures
Original issue's description:
> Make lines a special case in GrShape
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
>
> Committed: https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3
TBR=robertphillips@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2109613003
|
|
|
|
|
|
|
|
|
|
| |
(for fuzzer bug)
In this case the int that contains the color and alpha types is getting munged. We don't really case that the surplus bits are 0 just that the values we care about are reasonable.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110493002
Review-Url: https://codereview.chromium.org/2110493002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:5465
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103853002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2103853002
Review-Url: https://codereview.chromium.org/2103853002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002
Review-Url: https://codereview.chromium.org/2108523002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-CT_IMG_DECODE_100k_SKPs bot
BUG=skia:5462
BUG=skia:5466
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2101403003
# Try bots do not run this code.
NOTRY=true
Review-Url: https://codereview.chromium.org/2101403003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Detect more places where the pathops numerics cause numbers
to become nearly identical and subsequently fail. These tests
have extreme inputs and cannot succeed.
Also remove the expectSuccess parameter from PathOpsDebug
and check instead in the test framework.
R=mbarbella@chromium.org
TBR=reed@google.com
BUG=623072,623022
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103513002
Review-Url: https://codereview.chromium.org/2103513002
|
|
|
|
|
|
|
|
|
| |
SkImageInfos that were made invalid weren't being caught
Messing with the size of a SAVE record wasn't being caught
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104973003
Review-Url: https://codereview.chromium.org/2104973003
|
|
|
|
|
|
|
| |
BUG=skia:5461
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103133002
Review-Url: https://codereview.chromium.org/2103133002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2101823003
Review-Url: https://codereview.chromium.org/2101823003
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2101983003
TBR=
Review-Url: https://codereview.chromium.org/2101983003
|
|
|
|
|
|
|
|
| |
The fFillType field only needs/uses 2 bits - not all 8
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2099113004
Review-Url: https://codereview.chromium.org/2099113004
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085473002
Review-Url: https://codereview.chromium.org/2085473002
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed bug with setting up tempReadTexture from previous CL.
Also, previously we were not correctly handling the rowBytes during the read.
BUG=skia:5461
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2102633003
Review-Url: https://codereview.chromium.org/2102633003
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100223003
Review-Url: https://codereview.chromium.org/2100223003
|
|
|
|
|
|
|
|
|
|
|
|
| |
GL has a lot more optimizations checks here to make sure we do the most
effecient and correct draw here, but for now as long as the features
are support we just do basic draws for both reads and writes when we
need certain conversions.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2105433002
Review-Url: https://codereview.chromium.org/2105433002
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use new file hosted on skia.org for 16-17 roadmap
Remove aging published highlights in favor of release notes
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104563002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2104563002
Review-Url: https://codereview.chromium.org/2104563002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:5465
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103443003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=2103443003
Review-Url: https://codereview.chromium.org/2103443003
|
|
|
|
|
|
|
|
|
|
| |
The main "fix" here was that the assert was checking the un-clamped input value rather than the clamped value.
The SkValidatingReadBuffer.cpp change was required to get the reproducing fuzz test case to complete.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2107453002
Review-Url: https://codereview.chromium.org/2107453002
|
|
|
|
|
|
|
|
| |
This addresses a class of fuzzer failure where the paint index has been
made invalid but the calling code doesn't handle a null pointer return.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2099343002
Review-Url: https://codereview.chromium.org/2099343002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
This CL's base was the CL for GPU handling: https://codereview.chromium.org/2043393002/
What this CL includes:
- A refactor of the SkLightingShader context's code that deals with reading normals off of a normal map. This is now abstracted out into a NormalSource::Provider class that the context uses.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050773002
Committed: https://skia.googlesource.com/skia/+/790a70118327a129cb6b48fabe80f4e184c1e67c
Review-Url: https://codereview.chromium.org/2050773002
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug introduced in: https://codereview.chromium.org/1961953002/ (Reland of Simplify SkGpuBlurUtils::GaussianBlur method)
Although the 'canOverwriteSrc' flag is/was being used I still believe we're better off re-adding it after the mask-blur refactoring finishes.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100873002
Review-Url: https://codereview.chromium.org/2100873002
|
|
|
|
|
|
|
| |
TBR=egdaniel@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2105443002
Review-Url: https://codereview.chromium.org/2105443002
|
|
|
|
|
|
| |
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2094023002
Review-Url: https://codereview.chromium.org/2094023002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #13 id:240001 of https://codereview.chromium.org/2050773002/ )
Reason for revert:
GMs are crashing on Windows Test trybots
Original issue's description:
> SkLightingShader normal vector CPU computation refactor.
>
> The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
>
> This CL's base was the CL for GPU handling: https://codereview.chromium.org/2043393002/
>
> What this CL includes:
>
> - A refactor of the SkLightingShader context's code that deals with reading normals off of a normal map. This is now abstracted out into a NormalSource::Provider class that the context uses.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050773002
>
> Committed: https://skia.googlesource.com/skia/+/790a70118327a129cb6b48fabe80f4e184c1e67c
TBR=egdaniel@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2101653002
|
|
|
|
|
|
|
|
|
|
| |
We have observed on OS X that instanced draws don't always behave
correctly when the framebuffer is floating point.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095183002
Review-Url: https://codereview.chromium.org/2095183002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
This CL's base was the CL for GPU handling: https://codereview.chromium.org/2043393002/
What this CL includes:
- A refactor of the SkLightingShader context's code that deals with reading normals off of a normal map. This is now abstracted out into a NormalSource::Provider class that the context uses.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050773002
Review-Url: https://codereview.chromium.org/2050773002
|
|
|
|
|
|
| |
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2099313002
Review-Url: https://codereview.chromium.org/2099313002
|
|
|
|
|
|
|
|
|
|
| |
Now that GrPathRenderer is using GrShape it is possible to get a key for a path that was computed by applying style to an original path.
This improves path renderer subclass selection, particularly when a post-styled path happens to work with a simpler path renderer (e.g. it is convex). Previously a more expensive path renderer may have applied the style and rendered it (e.g. the distance field PR)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064753003
Review-Url: https://codereview.chromium.org/2064753003
|
|
|
|
|
|
|
| |
BUG=skia:5461
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2098933002
Review-Url: https://codereview.chromium.org/2098933002
|
|
|
|
|
|
|
|
|
|
|
| |
was just created early on as a test filter
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2094083002
TBR=
Review-Url: https://codereview.chromium.org/2094083002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2097003003
Review-Url: https://codereview.chromium.org/2097003003
|
|
|
|
|
|
|
| |
BUG=skia:5458
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2099813002
Review-Url: https://codereview.chromium.org/2099813002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054213002
Review-Url: https://codereview.chromium.org/2054213002
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Sk4f would be my choice, but it's not allowed in include/
- SkColor4f and SkPM4f are specified to be unpremultiplied/premultiplied, whereas GrColor (and GrColor4f) are either, depending on context.
This adds 12 bytes to GrPaint. Not sure if we want to pay that price. The precision loss for a single value (vs. in a gradient, etc...) may not justify changing the storage type here. Easy enough to back that part out, while still keeping the 4f intermediate type for the helper math that it adds, and for storage and parameter passing in other locations.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2088303002
Review-Url: https://codereview.chromium.org/2088303002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2091923003
Review-Url: https://codereview.chromium.org/2091923003
|
|
|
|
|
|
|
|
|
|
|
| |
Don't assume bucket name to start with 'master.'.
NOTRY=True
BUG=chromium:617627
R=rmistry@google.com,sergiyb@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2096733005
Review-Url: https://codereview.chromium.org/2096733005
|
|
|
|
|
|
| |
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2081383006
Review-Url: https://codereview.chromium.org/2081383006
|
|
|
|
|
|
|
|
|
| |
This fixes a warning we were receiving while running tests in Vulkan.
BUG=skia:5458
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095923004
Review-Url: https://codereview.chromium.org/2095923004
|
|
|
|
|
|
|
|
|
|
| |
In Vulkan we need to know at create time of a texture whether or not we will
use it as a render target.
BUG=skia:5458
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2093943002
Review-Url: https://codereview.chromium.org/2093943002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2093763003
Review-Url: https://codereview.chromium.org/2093763003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/2096683002/ )
Reason for revert:
Testing to see if this CL caused the failures in Build-Mac-Clang-Arm7-Debug-Android
Original issue's description:
> Remove Android SampleApp
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2096683002
>
> Committed: https://skia.googlesource.com/skia/+/41bb5b40e71411ee39538399ea125986ec760a90
TBR=djsollen@google.com,liyuqian@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/2099693002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2097553002
Review-Url: https://codereview.chromium.org/2097553002
|
|
|
|
|
|
|
|
|
|
| |
Vulkan debug layers complain that when we call readPixels on the texture
we are copying unitialized data from the image to a buffer.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2091823005
Review-Url: https://codereview.chromium.org/2091823005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before:
micros bench
250.98 WritePDFText nonrendering
after:
micros bench
107.10 WritePDFText nonrendering
Also, be slightly more space-efficient in encoding strings.
Also, add a bench.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2099463002
Review-Url: https://codereview.chromium.org/2099463002
|
|
|
|
|
|
|
|
| |
Just another step in reining in the GrPLB
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2086293006
Review-Url: https://codereview.chromium.org/2086293006
|