aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Testing trybot triggeringGravatar rmistry2014-06-13
| | | | | | | | | | | | CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Ubuntu13.10-GCC4.8-x86_64-Debug-CrOS_Link-Trybot BUG=skia:2659 NOTREECHECKS=true TBR= (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/332933005
* Extract "text align proc" functions as reusable classesGravatar kkinnunen2014-06-12
| | | | | | | | | | | | | | | | | | | | | | | Extract "text align proc" as reusable classes. These classes need to be used when writing GrTextContext subclasses. Moves "text align proc" code that is duplicated in SkDraw and SkBitmapTextContext to SkDrawProcs.h and SkTextMapState.h. This functionality is also used in the new GrStencilAndCoverTextContext. Creates new functor classes SkTextAlignProc and SkTextAlignProcScalar which represent the previous "text align procs". Moves TextMapState from SkDraw to SkTextMapStateProc and make it similar functor. The transform should be comparable in speed, as the compiler can and does avoid the call and eliminate some of the branches. R=jvanverth@google.com, reed@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/335573002
* Randomize seed for SkDiscretePathEffect::filterPath()Gravatar rs.prinja2014-06-12
| | | | | | | | | | | | | | | | | | Fix for https://code.google.com/p/skia/issues/detail?id=2581. Randomizes the seed in SkDiscretePathEffect::filterPath(). Prior to this we were using the path length as a seed. Now, if we have two different paths with identical contents and we apply an SkDiscretePathEffect to each, we obtain two different random paths. Previously, we would obtain two overlapping paths (identical path contents leading to the same seed). BUG=skia: R=reed@google.com, scroggo@google.com Author: rs.prinja@samsung.com Review URL: https://codereview.chromium.org/311803002
* hide Config in SkImageDecoder -- use SkColorType insteadGravatar reed2014-06-12
| | | | | | | | | | patch from issue 334613003 TBR=scroggo Author: reed@chromium.org Review URL: https://codereview.chromium.org/334793002
* New baselines for perlin noise tests affected by ce6a35.Gravatar senorblanco2014-06-12
| | | | | | | | | | | | | New baselines for perlinnoise, imagefiltersclipped and imagefiltersscaled GMs. R=scroggo@google.com TBR=scroggo NOTRY=true Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/336703002
* Remove SkPicture SK_SUPPORT_LEGACY_RECORDING_FLAG flagGravatar robertphillips2014-06-12
| | | | | | | | | | | | | | Chromium/Blink should no longer need this flag after: Chromium: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/322123002/ Blink: Remove use of kUsePathBoundsForClip_RecordingFlag https://codereview.chromium.org/326953002/ R=mtklein@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/328343002
* rebaselines for removal of unitmapperGravatar reed2014-06-12
| | | | | | | | | TBR= NOTRY=True Author: reed@google.com Review URL: https://codereview.chromium.org/330513005
* Add more tests to ignore-tests.txt.Gravatar Stephen White2014-06-12
| | | | | | | | | | | Add imagefiltersclipped and imagefiltersscaled to ignored-tests.txt until they can be rebaselined, since they're failing on Android after https://codereview.chromium.org/332523006/. TBR=scroggo BUG=skia: Review URL: https://codereview.chromium.org/336663002
* Revert of third try at landing improved blur rect; this time with more ↵Gravatar scroggo2014-06-12
| | | | | | | | | | | | | | | | | | | | | | | | | | correctness (https://codereview.chromium.org/331443003/) Reason for revert: Failing layout test: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/32762/layout-test-results/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-pretty-diff.html Original issue's description: > third try at landing improved blur rect; this time with more correctness > > BUG=skia:2095 > R=bsalomon@google.com > TBR=bsalomon > > Committed: https://skia.googlesource.com/skia/+/72abfc2b4e7caead660f6b6a05e60d05eaf1a66f R=bsalomon@google.com, reed@google.com, humper@google.com TBR=bsalomon@google.com, humper@google.com, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2095 Author: scroggo@google.com Review URL: https://codereview.chromium.org/333763002
* Add another fail-ignore for flaky dashing4 gmGravatar egdaniel2014-06-12
| | | | | | | | | | | NOTREECHECKS=True NOTRY=True TBR=bsalomon@google.com BUG=skia: Author: egdaniel@google.com Review URL: https://codereview.chromium.org/329223007
* Greenify bench bot Perf-Ubuntu12-ShuttleA-GTX660-x86-Release at build 968Gravatar bensong2014-06-12
| | | | | | | | | | | | R=bsalomon@google.com TBR=scroggo@google.com Bypassing trybots: NOTRY=true Author: bensong@google.com Review URL: https://codereview.chromium.org/338453004
* Added in framework to get more bench dataGravatar kelvinly2014-06-12
| | | | | | | | | | BUG=skia: NOTRY=true R=jcgregorio@google.com, bensong@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/331683003
* Fix tiled perlin noise.Gravatar senorblanco2014-06-12
| | | | | | | | | | | | | | | | | | | | | | | | | It turns out that the perlin implementation we inherited from WebKit does not actually generate tileable noise (see Chromium bug http://crbug.com/383495). The main problem is that when generating coordinates for gradient interpolation, it was attempting to wrap both x and (x + 1) simultaneously at the tile boundary (that is, either both or neither are wrapped). This obviously won't work, since along the tile seams, (x + 1) should be wrapped, but x should not. The same is true in y. This patch fixes both the CPU and GPU paths, renames some variables to more closely match the spec, and modifies the perlin noise GM to actually test tiling. (Note that the clipping the GM was doing was removed, since it's superfluous: it used to be necessary for image filters, but isn't anymore, and this isn't an image filter GM anyway.) R=sugoi@google.com, sugoi TBR=senorblanco Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/332523006
* Use vertex attributes for dash effect in gpuGravatar egdaniel2014-06-12
| | | | | | | | | | | | | This will allow us to batch dashed lines together when drawing. Also, this removes the need for a coord transform matrix in the shader, thus we save the cost of uploading a new matrix uniform everytime we do a simple transform to the dashed line we are drawing. BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/326103002
* manual bench rebase after 679426c using old algorithmGravatar bensong2014-06-12
| | | | | | | | | | | | R=robertphillips@google.com TBR=borenet@google.com, robertphillips@google.com Bypassing trybots: NOTRY=true Author: bensong@google.com Review URL: https://codereview.chromium.org/330103002
* remove GetDeviceConfig/SetDeviceConfigGravatar reed2014-06-12
| | | | | | | | | BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/332453002
* Use scratch with LATC data if possibleGravatar krajcevski2014-06-12
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/330593004
* Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin().Gravatar tfarina2014-06-12
| | | | | | | | | | BUG=None TEST=make tools tests && out/Debug/tests R=epoger@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/327403002
* removes deprecated -q flag for gsutil.Gravatar bensong2014-06-12
| | | | | | | | | | | BUG=skia: NOTRY=true R=kelvinly@google.com TBR=kelvinly@google.com Author: bensong@google.com Review URL: https://codereview.chromium.org/333643005
* Really revert bench trigger changes.Gravatar bensong2014-06-12
| | | | | | | | | | | BUG=skia: NOTRY=true R=kelvinly@google.com TBR=kelvinly@google.com Author: bensong@google.com Review URL: https://codereview.chromium.org/324403009
* Rebase flakey windows dash4 gmGravatar egdaniel2014-06-12
| | | | | | | | | | | NOTREECHECKS=True NOTRY=True TBR=bsalomon@google.com BUG=skia:2667 Author: egdaniel@google.com Review URL: https://codereview.chromium.org/335443003
* Revert trigger changesGravatar kelvinly2014-06-12
| | | | | | | | | | BUG=skia: NOTRY=true R=robertphillips@google.com, bensong@google.com, jcgregorio@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/334673002
* Add expectations for dashing gmGravatar egdaniel2014-06-12
| | | | | | | | | TBR=bsalomon@google.com BUG=skia: Author: egdaniel@google.com Review URL: https://codereview.chromium.org/330033002
* Whitespace change to test trybot triggeringGravatar rmistry2014-06-12
| | | | | | | | | | | BUG=skia: CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Ubuntu13.10-GCC4.8-Arm7-Release-Android-Trybot TBR= (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/333663002
* manual bench rebase after 679426cGravatar scroggo2014-06-12
| | | | | | | | | | | | | | | | In response to: - new SKPs - Kelvin's changes around regression testing R=robertphillips@google.com, kelvinly@google.com TBR=robertphillips@google.com Bypassing trybots: NOTRY=true Author: scroggo@google.com Review URL: https://codereview.chromium.org/332483004
* Remove SkPicture pointer from SkPicturePlaybackGravatar robertphillips2014-06-12
| | | | | | | | | | This CL simplifies the relationship between SkPicture and SkPicturePlayback by moving the path heap into SkPicturePlayback and removing SkPicturePlayback's SkPicture pointer. R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/334493002
* Update SKP version to 21Gravatar borenet2014-06-12
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Author: borenet@google.com Review URL: https://codereview.chromium.org/327213004
* rebaseline_server: delete no-longer-used weightedDiffMeasureGravatar epoger2014-06-11
| | | | | | | | | | | | (replaced by perceptual diff) NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/334533003
* rebaseline_server: change 2 image expectations within unittestsGravatar epoger2014-06-11
| | | | | | | | | | NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/329933002
* Suppress libpoppler and its dependent liblcms in TSAN.Gravatar mtklein2014-06-11
| | | | | | | | | | | This will let us eventually turn PDF back on in DM. BUG=skia: R=halcanary@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/330433003
* Add ifdef to not use function pointer that we don't have yet on Chromium??Gravatar krajcevski2014-06-11
| | | | | | | | R=bsalomon@google.com, robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/326423003
* Allow compressed texture data to be updated.Gravatar krajcevski2014-06-11
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/326383003
* rebaseline_server: merge identical results (across multiple ↵Gravatar epoger2014-06-11
| | | | | | | | | | | builders/configs) into a single row BUG=skia:2534 R=jcgregorio@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/326013002
* Fix a number of issues with iOS build.Gravatar jvanverth2014-06-11
| | | | | | | | | | | | | Set pointer to root view in window (for SampleApp) Set up the correct function pointer for GL multisampling Remove use of SkBitmap::setConfig() Remove incomplete iOS implementation of SkFILE (use SkOSFile for now) R=caryclark@google.com, reed@google.com, bsalomon@google.com, tfarina@chromium.org Author: jvanverth@google.com Review URL: https://codereview.chromium.org/322403007
* third try at landing improved blur rect; this time with more correctnessGravatar humper2014-06-11
| | | | | | | | | | BUG=skia:2095 R=bsalomon@google.com TBR=bsalomon Author: humper@google.com Review URL: https://codereview.chromium.org/331443003
* Texture compression unit tests along with a couple of bug fixesGravatar krajcevski2014-06-11
| | | | | | | | R=robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/330453005
* SkNEW as default Create() for SkLazyPtr macros.Gravatar mtklein2014-06-11
| | | | | | | | | BUG=skia: R=halcanary@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/326413003
* Remove picture pre-allocation from SkPictureRecorderGravatar robertphillips2014-06-11
| | | | | | | | | | | | This CL improves the separation of the SkPicture and SkPictureRecord classes. It delays creation of the SkPicture (in SkPictureRecorder) until recording is actually completed. To accomplish this the SkRecord-derived classes now get SkPathHeap and SkPictureContentInfo members that are absorbed by the SkPicture when it is constructed. As an ancillary change, this CL also moves the SkPictureContentInfo object from SkPicture to SkPicturePlayback. This is intended to centralize all the data in the SkPicturePlayback object. R=mtklein@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/324293004
* Hide chooseFromOneChoice along with Chooser.Gravatar scroggo2014-06-11
| | | | | | | | | | | | Fixes chrome canary. R=reed@android.com TBR=reed NOTRY=true Author: scroggo@google.com Review URL: https://codereview.chromium.org/329113003
* Add support for glCompressedTexSubImage2DGravatar krajcevski2014-06-11
| | | | | | | | R=bsalomon@google.com, robertphillips@google.com Author: krajcevski@google.com Review URL: https://codereview.chromium.org/329213002
* hide SkImageDecoder::ChooserGravatar reed2014-06-11
| | | | | | | | | BUG=skia: R=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/331433003
* Push dash checks into GrContext.Gravatar egdaniel2014-06-11
| | | | | | | | | | Add class to hold stroke and dash info. R=bsalomon@google.com, robertphillips@google.com, jvanverth@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/311183002
* Use new SkBaseMutex::assertHeld() in DiscardableMemoryPoolGravatar halcanary2014-06-11
| | | | | | | | R=mtklein@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/324413003
* Cleanup: Delete sk_tools::get_basename() in favor of SkOSPath::SkBasename().Gravatar tfarina2014-06-11
| | | | | | | | | | BUG=None TEST=make tests && out/Debug/tests R=epoger@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/321693002
* Narrowed expectation margins noticeablyGravatar kelvinly2014-06-11
| | | | | | | | | | BUG=skia: NOTRY=true R=bensong@google.com, bsalomon@google.com, jcgregorio@google.com, robertphillips@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/323373002
* Revert of second try at landing improved blur rect ↵Gravatar reed2014-06-11
| | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/325703002/) Reason for revert: broke some fast/canvas layout tests Original issue's description: > second try at landing improved blur rect > > BUG=skia:2095 > TBR=bsalomon > > Committed: https://skia.googlesource.com/skia/+/e9ea0d6b7d59ac3b7e257281e545b24bcc0d2a76 R=bsalomon@google.com, reed@chromium.org, humper@google.com TBR=bsalomon@google.com, humper@google.com, reed@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2095 Author: reed@google.com Review URL: https://codereview.chromium.org/322423002
* remove SK_SUPPORT_LEGACY_DEVICE_CONFIG codeGravatar reed2014-06-11
| | | | | | | | | BUG=skia: R=djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/327263002
* Code reviews -> reviews@skia.org.Gravatar mtklein2014-06-11
| | | | | | | | | BUG=skia: R=reed@google.com, skia-review@googlegroups.com, hcm@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/328613003
* MIPS: added optimization for functions from SkBlitRow.Gravatar djordje.pesut2014-06-11
| | | | | | | | | | | | | | | | | | | gain is ~40% following function are optimized: S32_D565_Blend S32A_D565_Opaque_Dither S32_D565_Opaque_Dither S32_D565_Blend_Dither S32A_D565_Opaque S32A_D565_Blend S32_Blend_BlitRow32 R=djsollen@google.com, teodora.petrovic@gmail.com Author: djordje.pesut@imgtec.com Review URL: https://codereview.chromium.org/326913004
* Move Dashing filterPath to a dashing utils fileGravatar egdaniel2014-06-11
| | | | | | | | | | | | | | | | From inside GrContext, we have a need to create an SkPath an original path and some dashing info. We do not have access to the original path effect so we need a way to make the FilterPath function accessible outside of the effect. So I moved the core filterPath code (and all need helper functions) out of SkDashPathEffect and created a SkDashPath in utils to store these helper functions. BUG=skia: Committed: https://skia.googlesource.com/skia/+/576dcdc793a762ec63fbecdbfd5768066b548fe5 Author: egdaniel@google.com Review URL: https://codereview.chromium.org/314623004