aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Revert "Revert "Improvements to GPU dither.""Gravatar Brian Salomon2017-07-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 38fb308f3156aab1e42a61d77d08906a06263879. Reason for revert: Reland with SkSL caps fix for vulkan Original change's description: > Revert "Improvements to GPU dither." > > This reverts commit 1806e33e6a09b1361de4925d32389a01e0e2c7e7. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Improvements to GPU dither. > > > > 1) Makes the range of the offset dependent on the config. > > > > 2) Uses an ordered dither on GPUs that support integers in shaders. > > > > 3) Enables dithering for all paints with dither flag when the color type of the dst is 4444 > > > > 4) Dithers r,g,b and clamps to 0,a rather than dithering all four channels (same as CPU backend). > > > > Bug: skia: > > Change-Id: Ie22c3adc38c6d1dbbcd97e4b7d16fc843e392c2e > > Reviewed-on: https://skia-review.googlesource.com/23485 > > Commit-Queue: Brian Salomon <bsalomon@google.com> > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > TBR=bsalomon@google.com,robertphillips@google.com > > Change-Id: Ie82e88bd9032bf8eee745d32d9b57c335a8997c9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/24325 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,robertphillips@google.com Change-Id: Ic38ac276c8b88b8d993a29d1fcbfe37e84becd2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/24282 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Copy over private SKPs during SKP asset create commandGravatar Ravi Mistry2017-07-18
| | | | | | | | Bug: skia:6850 Change-Id: Idaa92d2b4233b9f03a15d70cc185261f0090bab4 Reviewed-on: https://skia-review.googlesource.com/24404 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* SkPDF: Re-use Jpeg Image ShadersGravatar Hal Canary2017-07-18
| | | | | | | | | | | | | | | Also, de-dup shader better. - SkBitmapKeyFromImage function factors out image de-dup code. - SkPDFUtils::ToBitmap funtion factors out to-bitmap code - make_image_shader function now takes Image rather than Bitmap. All tests render the same. Some are significantly smaller PDFs. Change-Id: Id8dd36b31c8e573f44a5e9f6058d5a1d622b6385 Reviewed-on: https://skia-review.googlesource.com/24081 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com>
* sksl now sees vulkan capsGravatar Ethan Nicholas2017-07-18
| | | | | | | | Bug: skia: Change-Id: I41714d80685427a7711b000e61f7fc7e70371253 Reviewed-on: https://skia-review.googlesource.com/24182 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Add some convexity checks to shadow code.Gravatar Jim Van Verth2017-07-18
| | | | | | | | | To address https://github.com/flutter/flutter/issues/11221. Change-Id: I5ccd7f9eb2f3ee0d168aa4ca5474bfdfba14ca9c Reviewed-on: https://skia-review.googlesource.com/24124 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* start on raster pipeline 2d modeGravatar Mike Klein2017-07-18
| | | | | | | | | | - Add run_2d(x,y,w,h) and start_pipeline_2d(). - Add and test a 2d-compatible store_8888_2d stage. Change-Id: Ib9c225d1b8cb40471ae4333df1d06eec4d506f8a Reviewed-on: https://skia-review.googlesource.com/24401 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* vk: Fix geometry-shader input varying locationsGravatar Chris Dalton2017-07-18
| | | | | | | | Bug: skia: Change-Id: I60e0c25fa05ea53b0969fdee54620bec639ae159 Reviewed-on: https://skia-review.googlesource.com/24440 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* fixed use-after-free in sksl switch statementsGravatar Ethan Nicholas2017-07-18
| | | | | | | | Bug: skia: Change-Id: I66ef1cd2af9c654bfa40a71b2218cfde49f3a54e Reviewed-on: https://skia-review.googlesource.com/24329 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* minor fixes to start_pipeline_lowpGravatar Mike Klein2017-07-18
| | | | | | | | | | - in _lowp.cpp, JUMPER is always defined, so no need to check. - the return type of this function has been void for a while. Change-Id: I5271e8dab784f46c7ffa9cfba6eb55b5e399b537 Reviewed-on: https://skia-review.googlesource.com/24326 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Do not move over webpage archives, they are needed for capturing SKPsGravatar Ravi Mistry2017-07-18
| | | | | | | | | NoTry: true Bug: skia:6850 Change-Id: I35ac2c10ae58561ab5424033d9bb5e14b75c526f Reviewed-on: https://skia-review.googlesource.com/24327 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add two test bots for coverage counting path rendererGravatar Chris Dalton2017-07-18
| | | | | | | | Bug: skia: Change-Id: Ib8e89e5e9a75d24b69c23873168fcc23f9eb5c45 Reviewed-on: https://skia-review.googlesource.com/24063 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Revert "Improvements to GPU dither."Gravatar Brian Salomon2017-07-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 1806e33e6a09b1361de4925d32389a01e0e2c7e7. Reason for revert: <INSERT REASONING HERE> Original change's description: > Improvements to GPU dither. > > 1) Makes the range of the offset dependent on the config. > > 2) Uses an ordered dither on GPUs that support integers in shaders. > > 3) Enables dithering for all paints with dither flag when the color type of the dst is 4444 > > 4) Dithers r,g,b and clamps to 0,a rather than dithering all four channels (same as CPU backend). > > Bug: skia: > Change-Id: Ie22c3adc38c6d1dbbcd97e4b7d16fc843e392c2e > Reviewed-on: https://skia-review.googlesource.com/23485 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> TBR=bsalomon@google.com,robertphillips@google.com Change-Id: Ie82e88bd9032bf8eee745d32d9b57c335a8997c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/24325 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Improvements to GPU dither.Gravatar Brian Salomon2017-07-18
| | | | | | | | | | | | | | | | 1) Makes the range of the offset dependent on the config. 2) Uses an ordered dither on GPUs that support integers in shaders. 3) Enables dithering for all paints with dither flag when the color type of the dst is 4444 4) Dithers r,g,b and clamps to 0,a rather than dithering all four channels (same as CPU backend). Bug: skia: Change-Id: Ie22c3adc38c6d1dbbcd97e4b7d16fc843e392c2e Reviewed-on: https://skia-review.googlesource.com/23485 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* guard references to SkColorTableGravatar Mike Reed2017-07-18
| | | | | | | | Bug: skia:6828 Change-Id: I0c8c78e70b118f51cb59dc45675e4ddcd4776108 Reviewed-on: https://skia-review.googlesource.com/24260 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Commit Queue: add Build-Debian9-GCC-arm-ChromecastGravatar Hal Canary2017-07-18
| | | | | | | | Motivation: This compiler configuration has a few quirks. Change-Id: I9c50a15510f4b770f8643b21e9e7cdf57264bc50 Reviewed-on: https://skia-review.googlesource.com/24324 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* added sksl support for integerSupport capGravatar Ethan Nicholas2017-07-18
| | | | | | | | Bug: skia: Change-Id: I7e33af9b845db3f862a3a21cba7f2d56e8ea2909 Reviewed-on: https://skia-review.googlesource.com/24323 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Revert "Revert "SkPDF: Non-outline glyphs as images""Gravatar Hal Canary2017-07-18
| | | | | | | | | | | | | | | | | | | This reverts commit 63b6f8b93209e593f60b235577f5b3d660396d5f. SkPDF: Non-outline glyphs as images - Cache images in PDF Canon for de-duping - For now, rasterize at text scale. In the future, look at CTM and fRasterScale. Original CL: https://skia-review.googlesource.com/24080 BUG=chromium:705480 BUG=skia:3489 Reviewed-by: Ben Wagner <bungeman@google.com> Change-Id: I99783df72c945cfb4b24b6d4db99418aa34e0897 Reviewed-on: https://skia-review.googlesource.com/24322 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Make dither range symmetric about 0Gravatar Brian Salomon2017-07-18
| | | | | | | Change-Id: I0c2eec60beb665c7dca9b9fddc00ac112a1ff2e1 Reviewed-on: https://skia-review.googlesource.com/24121 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove leftover Android ctable referenceGravatar Florin Malita2017-07-18
| | | | | | | | | TBR= Change-Id: I6d8ed2fc2267e2a9b249b3c780495a26f0b5e1c6 Reviewed-on: https://skia-review.googlesource.com/24320 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Add guard to unblock the Chromium rollGravatar Florin Malita2017-07-18
| | | | | | | | | TBR= Change-Id: I87f96fb88479de770490ce4cce6ad840acb90241 Reviewed-on: https://skia-review.googlesource.com/24261 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Use SkRasterPipeline to blend GIF frames and use proper offsetGravatar Leon Scroggins III2017-07-18
| | | | | | | | | | | | | | | | | Mimics SkWebpCodec, but it is simpler, because each pixel is either opaque or transparent, so blending just means using the new pixel if not transparent. Correct the offset when blending f16 frames. It needs to be doubled, since the swizzler used a 4-byte format while f16 is 8-byte. Remove an unnecessary call to sk_bzero. Bug: skia:6750 Change-Id: I8b88d1d66bff660c98c2083031231678a7be5460 Reviewed-on: https://skia-review.googlesource.com/24240 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* add 32-bit Windows SkJumper backendGravatar Mike Klein2017-07-17
| | | | | | | | | | | | | | | | | | | | The most interesting part of this is getting the call to start_pipeline to work. From there it should be just like the other x86 backend. The 32-bit calling conventions are the same across Linux/Mac and Windows, so that's nice. The tricky bit is that Linux and Mac align the stack to 16 bytes, while Windows only to 4. I think this force_align_arg_pointer attribute on start_pipeline does the trick. This needs a guard for layout tests. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Win2k8-MSVC-GCE-CPU-AVX2-x86-Debug;master.tryserver.blink:win10_blink_rel,win7_blink_rel;master.tryserver.chromium.win:win_chromium_rel_ng Change-Id: Ia74d22e5a4ce5483c9817b8a8f89dd21885bbd14 Reviewed-on: https://skia-review.googlesource.com/20968 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Don't store colortables in pixmaps or pixelrefsGravatar Mike Reed2017-07-17
| | | | | | | | | | Lots more changes coming later (need to remove colortable parameters from bitmaps and pixmaps) Bug: skia:6828 Change-Id: Ic63e89570644839fab068141f49915b3f66d1053 Reviewed-on: https://skia-review.googlesource.com/24127 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "SkPDF: Non-outline glyphs as images"Gravatar Mike Reed2017-07-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 3cf6b79e50f148cae7ed8c6ec0cd79f1ede71c95. Reason for revert: breaking build ../../../../../work/skia/src/pdf/SkPDFDevice.cpp: In member function 'void SkPDFDevice::internalDrawText(const void*, size_t, const SkScalar*, SkTextBlob::GlyphPositioning, SkPoint, const SkPaint&, const uint32_t*, uint32_t, const char*)': ../../../../../work/skia/src/pdf/SkPDFDevice.cpp:1578:31: error: missing initializer for member 'SkPoint::fX' [-Werror=missing-field-initializers] SkPoint xy = {}; ^ Original change's description: > SkPDF: Non-outline glyphs as images > > - Cache images in PDF Canon for de-duping > - For now, rasterize at text scale. in the future, look at CTM and > fRasterScale. > - add a test that works on MacOS > > BUG=chromium:705480 > BUG=skia:3489 > Change-Id: I4fbc42f218e5b81ea15ea6cdccc61c91e532f6d0 > Reviewed-on: https://skia-review.googlesource.com/24080 > Commit-Queue: Hal Canary <halcanary@google.com> > Reviewed-by: Ben Wagner <bungeman@google.com> TBR=halcanary@google.com,bungeman@google.com Change-Id: I3d8800fcb33817c6065da0860a534eb14350d132 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:705480, skia:3489 Reviewed-on: https://skia-review.googlesource.com/24160 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Skip bilerp for integral-translate-only matricesGravatar Florin Malita2017-07-17
| | | | | | | | | BUG=chromium:744674 Change-Id: I053a0c26b0f644faa11f469b8a6486302a5efae6 Reviewed-on: https://skia-review.googlesource.com/24126 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* SkPDF: Non-outline glyphs as imagesGravatar Hal Canary2017-07-17
| | | | | | | | | | | | | | - Cache images in PDF Canon for de-duping - For now, rasterize at text scale. in the future, look at CTM and fRasterScale. - add a test that works on MacOS BUG=chromium:705480 BUG=skia:3489 Change-Id: I4fbc42f218e5b81ea15ea6cdccc61c91e532f6d0 Reviewed-on: https://skia-review.googlesource.com/24080 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* remove SK_SUPPORT_LEGACY_INDEX_8_COLORTYPE for google3Gravatar Mike Reed2017-07-17
| | | | | | | Bug: skia: Change-Id: I0469f125c9eb50370ce97287017401082066fcaf Reviewed-on: https://skia-review.googlesource.com/24141 Reviewed-by: Mike Reed <reed@google.com>
* Index8 is dead, remove guarded codeGravatar Mike Reed2017-07-17
| | | | | | | | | | Needs google3 to be updated before this can land. Bug: skia:6828 Change-Id: I2c16be13c6937ffa48768cc24f9f980171c824d6 Reviewed-on: https://skia-review.googlesource.com/23940 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Delete dead SK_SUPPORT_LEGACY_BILERP_IGNORING_HACK codeGravatar Florin Malita2017-07-17
| | | | | | | Change-Id: I367436ea5bef476a2e596f01bb57fa5b817a3619 Reviewed-on: https://skia-review.googlesource.com/24122 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* fixed skslc vec4 uniformsGravatar Ethan Nicholas2017-07-17
| | | | | | | | Bug: skia: Change-Id: I40ad3d0e73dbeedcd150b0d0a7f12c636f01cf33 Reviewed-on: https://skia-review.googlesource.com/24100 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Remove (now-dead) SK_LEGACY_SWEEP_GRADIENT codeGravatar Florin Malita2017-07-17
| | | | | | | | | | | Reland of https://skia-review.googlesource.com/c/17982 TBR= Change-Id: If29d60d60a45562715fddfaff56b1e694be13034 Reviewed-on: https://skia-review.googlesource.com/24042 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Add support for GL 565 and 4444 configs to test toolsGravatar Brian Salomon2017-07-17
| | | | | | | Change-Id: I395e3387df44cf5370fef6ab73db73228225622f Reviewed-on: https://skia-review.googlesource.com/23946 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Run clang-format on GrCircleBlurFP.cppGravatar Brian Osman2017-07-17
| | | | | | | | | | Fixes flutter license script hang Bug: skia:6854 Change-Id: I8eb69641888805411eb2d9ee4dbf50f281ac1b4b Reviewed-on: https://skia-review.googlesource.com/23944 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Update visibility checks in Vulkan to support geom shadersGravatar Greg Daniel2017-07-17
| | | | | | | | Bug: skia: Change-Id: Ie80bea38e644647e5a09e95053ddace30521361d Reviewed-on: https://skia-review.googlesource.com/23300 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* quote $windk to make copy-and-paste easyGravatar Mike Klein2017-07-17
| | | | | | | Change-Id: Iaecae142dcf268517f8918d9f4fa6a64db194fab Reviewed-on: https://skia-review.googlesource.com/23942 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* runtime check for in-range colortypesGravatar Mike Reed2017-07-17
| | | | | | | | Bug:743106 Change-Id: Ia014643c6f1914cf2b9b873138a0c53a783f666f Reviewed-on: https://skia-review.googlesource.com/23943 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Make GrAtlasTextOp a non-legacy GrMeshDrawOp"Gravatar Brian Salomon2017-07-17
| | | | | | | | | | | | | | | | | | | | | | | This reverts commit 434a58ab5fefcc1b86588c7fce898b1e5bd248ba. Reason for revert: <INSERT REASONING HERE> Original change's description: > Make GrAtlasTextOp a non-legacy GrMeshDrawOp > > Change-Id: Ib9eaf149100b0ccecf1c18a755263f2579b8e6f6 > Reviewed-on: https://skia-review.googlesource.com/23482 > Reviewed-by: Jim Van Verth <jvanverth@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=jvanverth@google.com,bsalomon@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I7fd8503b4e0c297b2cfaf979545354aa58d1f989 Reviewed-on: https://skia-review.googlesource.com/23760 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Make SkImage_Lazy cache its result from onMakeColorSpaceGravatar Christopher Cameron2017-07-17
| | | | | | | | | | | | | | May sites will all onMakeColorSpace every frame, resulting repeatedly re-created new SkImage_Lazy class instances, new cache keys, and repeated cache misses. Save the most recent result from onMakeColorSpace, to avoid this thrash. Bug:741607 Change-Id: I34091327a17275722f82ed372eb0b341806a9ddc Reviewed-on: https://skia-review.googlesource.com/23287 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Inject a dsb into SkAnalyticEdge::setLine() to work around ARMv7 CPU ↵Gravatar Mike Klein2017-07-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | erratum." This reverts commit 101806f4526d0ba5d48515c82a28dbf6956aca4d. Reason for revert: no more need. BUG=chromium:740805 Original change's description: > Inject a dsb into SkAnalyticEdge::setLine() to work around ARMv7 CPU erratum. > > BUG=chromium:710131 > > Change-Id: I4568bc24cc8fabb6f9df3b7645b01a98e11791b8 > Reviewed-on: https://skia-review.googlesource.com/14062 > Reviewed-by: Doug Anderson <dianders@google.com> > Commit-Queue: Mike Klein <mtklein@chromium.org> TBR=mtklein@chromium.org,dianders@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:710131 Change-Id: Ib5b58a951ae56e0f0523cfed27754e0cd150e6ce Reviewed-on: https://skia-review.googlesource.com/23840 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Update SKP versionGravatar UpdateSKPs2017-07-16
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Id11d0a2d8e282a043ca3029d6640d9c42ff56306 Reviewed-on: https://skia-review.googlesource.com/23780 Commit-Queue: update-skps <update-skps@skia.org> Reviewed-by: update-skps <update-skps@skia.org>
* Coverage counting path rendererGravatar Chris Dalton2017-07-14
| | | | | | | | | | | | | | | Initial implementation of a GPU path renderer that draws antialiased paths by counting coverage in an offscreen buffer. Initially disabled until it has had time to soak. Bug: skia: Change-Id: I003d8cfdf8dc62641581b5ea2dc4f0aa00108df6 Reviewed-on: https://skia-review.googlesource.com/21541 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Report error on failure to create SkCodecGravatar Leon Scroggins III2017-07-14
| | | | | | | | | | | | | | | | | | Update NewFromStream to report an error on failure to create an SkCodec, so that a client can distinguish between - not enough data - invalid data In Chromium, this will allow blink::ImageDecoder to call SetFailed if the stream is invalid early and we never create an SkCodec. Without this, ImageDecoder will keep trying to create an SkCodec when it receives more data. Change-Id: I4f505c56d91c982be36a828fd0f7db17b1596588 Reviewed-on: https://skia-review.googlesource.com/22642 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: Chris Blume <cblume@chromium.org>
* converted GrBlurredEdgeFragmentProcessor to skslGravatar Ethan Nicholas2017-07-14
| | | | | | | | Bug: skia: Change-Id: I028c85f692b2e54e64be301940708387014ee0c7 Reviewed-on: https://skia-review.googlesource.com/23540 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Fix SkClassifyCubic for near-quadraticsGravatar Chris Dalton2017-07-14
| | | | | | | | | | | | | | Fixes the threshold logic for "0 ~= d1 && 0 ~= d2". Previously, if d1 and d2 were both near zero, but on opposite sides of the threshold, the curve could be misclassified as kCuspAtInfinity and drawn incorrectly. Bug: skia: Change-Id: I65f30ddebf0a4a0b933610d8cc1a2f489efc99e4 Reviewed-on: https://skia-review.googlesource.com/22400 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* Revert "remove dead code for legacy image encode api"Gravatar Brian Osman2017-07-14
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 41ed7f33792c4c32b8444230b8b59cab5e29e45e. Reason for revert: Need this in temporarily to navigate Flutter and Fuchsia rolls. Original change's description: > remove dead code for legacy image encode api > > Bug: skia: > Change-Id: Ia90d776946281473c56cd93006df1b523475696a > Reviewed-on: https://skia-review.googlesource.com/23022 > Reviewed-by: Leon Scroggins <scroggo@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=scroggo@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: I078762fc13de0c455dc6f8a5725d9529af03bffc Reviewed-on: https://skia-review.googlesource.com/23385 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Make GrAtlasTextOp a non-legacy GrMeshDrawOpGravatar Brian Salomon2017-07-14
| | | | | | | Change-Id: Ib9eaf149100b0ccecf1c18a755263f2579b8e6f6 Reviewed-on: https://skia-review.googlesource.com/23482 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* converted EllipseEffect to skslGravatar Ethan Nicholas2017-07-14
| | | | | | | | Bug: skia: Change-Id: Id089b9ead7a21e903b001006dffff2381efd4ba3 Reviewed-on: https://skia-review.googlesource.com/23582 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Add GN arg to allow Flutter-specific API guardsGravatar Brian Osman2017-07-14
| | | | | | | | Bug: skia: Change-Id: I5a97da664626eebf30bba3f391fff0d8b9e62ea5 Reviewed-on: https://skia-review.googlesource.com/23042 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Simplify Sk4i's Min/MaxGravatar Yuqian Li2017-07-14
| | | | | | | | | CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Bug: skia: Change-Id: Id82a58f2f4d947894bb710cb3190c873b20b98eb Reviewed-on: https://skia-review.googlesource.com/23404 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Remove GrTestMeshDrawOpGravatar Brian Salomon2017-07-14
| | | | | | | Change-Id: If7465391b5e704b16b3ded2a73fafe088e2ea8e0 Reviewed-on: https://skia-review.googlesource.com/23384 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-02 00:38:53 +0000