aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* We really shouldn't pass SkFontStyle to printf as %d.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2721 Change-Id: I362063bea3909b2581d8e9b7860d4ac321082808 Reviewed-on: https://skia-review.googlesource.com/2721 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Remove stray semicolons.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | | | | Turns out function declarations don't end in semicolons... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2720 No public API changes. TBR=reed@google.com Change-Id: I72b56d52e1ff7fa6e89c295b0de8c46599791ebb Reviewed-on: https://skia-review.googlesource.com/2720 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add swarming task for upload_dm_resultsGravatar borenet2016-09-27
| | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360203004 Review-Url: https://codereview.chromium.org/2360203004
* Focus -Wno-over-aligned to just 32-bit x86 Android. (2)Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | | | I've even found the code that's making this happen, just don't know why. I've added a test to assert that it's safe to assume malloc() is 8-byte aligned. Test should compile this time. CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-GN_Android-Trybot Change-Id: I48714b99670c20704adf4f7f216da0d60d7d9bcd Reviewed-on: https://skia-review.googlesource.com/2662 Reviewed-on: https://skia-review.googlesource.com/2703 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Focus -Wno-over-aligned to just 32-bit x86 Android."Gravatar Mike Reed2016-09-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit If8a2898ab3a77571622eb125c97f676e029b902c. Reason for revert: ../../../../../work/skia/tests/OverAlignedTest.cpp: In function 'void test_OverAligned(skiatest::Reporter*, sk_gpu_test::GrContextFactory*)': ../../../../../work/skia/tests/OverAlignedTest.cpp:19:33: error: invalid operands of types 'void*' and 'int' to binary 'operator&' REPORTER_ASSERT(r, SkIsAlign8(p)); ^ ninja: build stopped: subcommand failed. Original issue's description: > Focus -Wno-over-aligned to just 32-bit x86 Android. > > I've even found the code that's making this happen, just don't know why. > I've added a test to assert that it's safe to assume malloc() is 8-byte aligned. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2662 > > CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-GN_Android-Trybot > TBR=mtklein@chromium.org,bungeman@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ic9b30ce980d8d5155528a6f2b4e1913e5fa95dc0 Reviewed-on: https://skia-review.googlesource.com/2702 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Remove outdated comments about pre-sk_sp semanticsGravatar brianosman2016-09-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2371603003 Review-Url: https://codereview.chromium.org/2371603003
* Clamp Vulkan caps to INT_MAXGravatar jvanverth2016-09-27
| | | | | | | | | | AMD sets some Vulkan caps values to 0xffffffff as a uint32_t, which overflows our int values and causes merry havok. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2371923002 Review-Url: https://codereview.chromium.org/2371923002
* Revert "Revert "replace Arithmetic xfermode with imagefilter""Gravatar Mike Reed2016-09-27
| | | | | | | | | | | | | This reverts commit 10ff5bfa789b6b602464e8511fdf676c6f5b1bd4. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2680 TBR= Change-Id: Iac2f4d48d227ff426ccf02b7eae280f382ad3580 Reviewed-on: https://skia-review.googlesource.com/2680 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Focus -Wno-over-aligned to just 32-bit x86 Android.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | | | | I've even found the code that's making this happen, just don't know why. I've added a test to assert that it's safe to assume malloc() is 8-byte aligned. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2662 CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-GN_Android-Trybot Change-Id: If8a2898ab3a77571622eb125c97f676e029b902c Reviewed-on: https://skia-review.googlesource.com/2662 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Revert of My take on SkAlign changes. (patchset #3 id:40001 of ↵Gravatar mtklein2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2368293002/ ) Reason for revert: Let's see if reverting this helps the roll. Original issue's description: > My take on SkAlign changes. > > Like the other change, it makes SkAlignN(x) macros work for pointers, and makes the macros themselves just syntax sugar for SkAlign<N>(x). We can still decide if we want to sed away the macros independently. > > This just does it in a somewhat less repetitive way, and adds some tests. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002 > > No public API changes. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/e1a5f4e292384046678edc5c1e360b3e13dc118c TBR=cblume@chromium.org,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2372083002
* Revert "replace Arithmetic xfermode with imagefilter"Gravatar Mike Reed2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit Ia3f3b721854c516f3b7f8c44f71f40a8a2eeb9b4. Reason for revert: need to guard the no-gpu codepath Original issue's description: > replace Arithmetic xfermode with imagefilter > > chrome pre-cl: https://codereview.chromium.org/2369023002/ > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2595 > > Change-Id: Ia3f3b721854c516f3b7f8c44f71f40a8a2eeb9b4 > Reviewed-on: https://skia-review.googlesource.com/2595 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Robert Phillips <robertphillips@google.com> > TBR=robertphillips@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I761799b594a0379c6bf356e6abc73552c3d19480 Reviewed-on: https://skia-review.googlesource.com/2661 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Revert of Turned on SkSL->GLSL compiler (patchset #37 id:800001 of ↵Gravatar ethannicholas2016-09-26
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2288033003/ ) Reason for revert: Gold image breakage Original issue's description: > Turned on SkSL->GLSL compiler > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003 > > Committed: https://skia.googlesource.com/skia/+/9b0fe3d125f237d9884732a48414fa85fc71b4e3 > Committed: https://skia.googlesource.com/skia/+/b12b3c6908c62c908b3680be01e3b5bfd30de310 TBR=benjaminwagner@google.com,bsalomon@google.com,egdaniel@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2372773002
* Move undefined-func-template to wont-fix warnings.Gravatar Mike Klein2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | The warning looks to helpfully pre-warn about possible link failures, but it's warning exclusively in places where we're doing things right. The worst that happens ignoring this warning is a missing-symbol linker error. I've taken the opportunity to batch in a few other de-escalations: - Wconditional-uninitialized is done better by MSAN - It'll take some work to dig Wformat-literal out of our shader compiler, but nothing looks unsafe - Most of Wshift-sign-overflow is 0xff << 24. Don't want to ban that. - Wdeprecated is mostly warning about features C++11 technically deprecated that might be removed in later releases. Punt! - Wcovered-switch-default is pretty much the opposite of what we want. - Wshadow is triggering too often to fix quickly. Probably mostly false positives. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2620 Change-Id: I20a85a77d2e19ed05a536b23037bd988350f821e Reviewed-on: https://skia-review.googlesource.com/2620 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* replace Arithmetic xfermode with imagefilterGravatar Mike Reed2016-09-26
| | | | | | | | | | | | | | chrome pre-cl: https://codereview.chromium.org/2369023002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2595 Change-Id: Ia3f3b721854c516f3b7f8c44f71f40a8a2eeb9b4 Reviewed-on: https://skia-review.googlesource.com/2595 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Fix typoGravatar liyuqian2016-09-26
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370003002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2370003002 Review-Url: https://codereview.chromium.org/2370003002
* Revert of Fix bufferIndex check in VulkanWindowContext (patchset #1 id:1 of ↵Gravatar egdaniel2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2363353003/ ) Reason for revert: Fix not correct. Original issue's description: > Fix bufferIndex check in VulkanWindowContext > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 > > Committed: https://skia.googlesource.com/skia/+/e6bd20e62b827a1f26fa491fc628f015d208350f TBR=jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2370953002
* Fix bufferIndex check in VulkanWindowContextGravatar egdaniel2016-09-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 Review-Url: https://codereview.chromium.org/2363353003
* Turned on SkSL->GLSL compilerGravatar ethannicholas2016-09-26
| | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003 Committed: https://skia.googlesource.com/skia/+/9b0fe3d125f237d9884732a48414fa85fc71b4e3 Review-Url: https://codereview.chromium.org/2288033003
* Minor clean up of GrAAConvexTessellatorGravatar Robert Phillips2016-09-26
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2604 Change-Id: Ie94361256675cded9ca241ddad6443e695a596e9 Reviewed-on: https://skia-review.googlesource.com/2604 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll recipesGravatar borenet2016-09-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2366323002 Review-Url: https://codereview.chromium.org/2366323002
* allow conic chop to failGravatar caryclark2016-09-26
| | | | | | | | | | | | | Fuzzy values may cause the conic chop to fail. Check to see if the values are all finite, and require the caller to do the same. R=reed@google.com BUG=650178 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368993002 Review-Url: https://codereview.chromium.org/2368993002
* Turn on -Wundefined-reinterpret-cast.Gravatar Mike Klein2016-09-26
| | | | | | | | | | | | | | | | | It was not a fan of this (blatant) aliasing. I suspect this best_non_simd_srcover_srgb_srgb() function has several other aliasing issues that use undefined behavior, but this is all it's complaining about for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2606 Change-Id: I25a8800e810bccf5068c8a10e9c8c8f565e57304 Reviewed-on: https://skia-review.googlesource.com/2606 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Tag checkerboard bitmaps as sRGBGravatar brianosman2016-09-26
| | | | | | | | | | | | | | Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 Review-Url: https://codereview.chromium.org/2368933003
* -Wcomma may be good to go now.Gravatar Mike Klein2016-09-26
| | | | | | | | | | | | | This cleans up 3 remaining sites using , that probably meant ; BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2605 Change-Id: I5e48bcd85d72a205d2b0c860461dab1ec793dd18 Reviewed-on: https://skia-review.googlesource.com/2605 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* My take on SkAlign changes.Gravatar mtklein2016-09-26
| | | | | | | | | | | | | | Like the other change, it makes SkAlignN(x) macros work for pointers, and makes the macros themselves just syntax sugar for SkAlign<N>(x). We can still decide if we want to sed away the macros independently. This just does it in a somewhat less repetitive way, and adds some tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002 No public API changes. TBR=reed@google.com Review-Url: https://codereview.chromium.org/2368293002
* bin/coverage: a GN version of the coverage scriptGravatar halcanary2016-09-26
| | | | | | | | intended to replace tools/coverage when GYP is gone. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343243002 Review-Url: https://codereview.chromium.org/2343243002
* Include timestamp in nanobench JSON file nameGravatar borenet2016-09-26
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2366623003 TBR=jcgregorio Review-Url: https://codereview.chromium.org/2366623003
* add tiger testsGravatar caryclark2016-09-26
| | | | | | | | | | | | | | | | Add the tiger test suite. In extended mode (-x) this adds 700K new pathop tests. Normally, it adds about 3500 tests. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2373533002 Review-Url: https://codereview.chromium.org/2373533002
* Typo?Gravatar mtklein2016-09-26
| | | | | | | | | | | This can't be what you intended... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368273002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2368273002
* GN: detect is_clang, use it to switch Clang to warning blacklist.Gravatar mtklein2016-09-26
| | | | | | | | | | | | | | | Same as the last CL, now with -Wno-over-aligned. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369033002 TBR=bungeman@google.com NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2369033002
* Quiet a -Wcomma warning.Gravatar mtklein2016-09-26
| | | | | | | | | | | | | | | | | Clang's got a warning -Wcomma that warns about possible unintentional uses of the comma operator, usually where a semicolon looks itended. I don't think there's a bug here, but a semicolon does work just as well and reads a bit more conventionally. Though, I'm not actually sure how this parses, as fp = ...; glslFP = ...; or fp = (..., glsl = ...). The second would most definitely be a bug. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2365403002
* beziers: I missed an unsequenced moveTo() pair.Gravatar mtklein2016-09-26
| | | | | | | | | TBR=brianosman@google.com BUG=skia: NOTREECHECKS=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369933002 Review-Url: https://codereview.chromium.org/2369933002
* Fix some fuzzer complaintsGravatar Robert Phillips2016-09-26
| | | | | | | | | | | | In one case the fuzzer was switching the picture's op code to an invalid value In the other two the fuzzer was maxing out the number of points passed to drawPoints and the number of characters passed to drawTextRSXform. In these cases the validation would fail but still return a pointer into the data stream. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2593 Change-Id: Id6d4e6b7bcbae38ace7ad1d92ffcfa5c02f9fb61 Reviewed-on: https://skia-review.googlesource.com/2593 Reviewed-by: Mike Reed <reed@google.com>
* Revert "GN: detect is_clang, use it to switch Clang to warning blacklist."Gravatar Mike Klein2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit I09c3487adfeb26a6fb07e1939cb927c5d7de3107. Reason for revert: -Wover-aligned on x86 Android bots Original issue's description: > GN: detect is_clang, use it to switch Clang to warning blacklist. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2599 > > Change-Id: I09c3487adfeb26a6fb07e1939cb927c5d7de3107 > Reviewed-on: https://skia-review.googlesource.com/2599 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,bungeman@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ic07bf7896a305be6c377f14a573cb10836f1a6f8 Reviewed-on: https://skia-review.googlesource.com/2601 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Documentation: fix linksGravatar halcanary2016-09-26
| | | | | | | TBR= NOTRY=true Review-Url: https://codereview.chromium.org/2366403002
* GN: detect is_clang, use it to switch Clang to warning blacklist.Gravatar Mike Klein2016-09-26
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2599 Change-Id: I09c3487adfeb26a6fb07e1939cb927c5d7de3107 Reviewed-on: https://skia-review.googlesource.com/2599 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Stop aggregating texture/buffer access objects in GrFragmentProcessor parents.Gravatar bsalomon2016-09-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349243002 Review-Url: https://codereview.chromium.org/2365943003
* In makeLinearGamma, return the original CS if it's already linearGravatar Brian Osman2016-09-26
| | | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2589 Change-Id: I51d8f8f64bc5f73a0b7cbf5f01f3d23b56c1895e Reviewed-on: https://skia-review.googlesource.com/2589 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* These calls to SkRandom are not sequenced.Gravatar mtklein2016-09-26
| | | | | | | | | | | | | This is why we see two versions of this GM: some compilers evaluate the rand.nextRangeScalar() calls left to right, others right to left. Remember this bug? BUG=skia:3241 (https://codereview.chromium.org/1157943006 fixed hittestpath last year.) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 Review-Url: https://codereview.chromium.org/2368263002
* fix tiger bGravatar caryclark2016-09-26
| | | | | | | | | | | | | | | The tiger tests have uncovered numerous bugs. This CL fixes the last of them. If a pair of curves do not intersect, but have one or both ends very close to the opposite curve, consider that an intersection. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356363003 Review-Url: https://codereview.chromium.org/2356363003
* Dash to use SkIsAlign2Gravatar cblume2016-09-26
| | | | | | | | Dash checks for alignment by actively aligning. It should really just check for alignment. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2366283002 Review-Url: https://codereview.chromium.org/2366283002
* Add SkColor4f serializationGravatar brianosman2016-09-25
| | | | | | | | | | Adjusted usage in color shader, and will also be using this in gradients, soon. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334123003 Review-Url: https://codereview.chromium.org/2334123003
* Update SKP versionGravatar update-skps2016-09-25
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368053002 Review-Url: https://codereview.chromium.org/2368053002
* Disable msaa on iHD530 bot.Gravatar benjaminwagner2016-09-23
| | | | | | | BUG=skia:5792 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356213005 Review-Url: https://codereview.chromium.org/2356213005
* GN: ANGLEGravatar mtklein2016-09-23
| | | | | | | | | | | | | | | | Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. Now working on Linux: $ gn gen angle --args=skia_use_angle=true $ ninja -C angle $ angle/dm --config angle-gl --src gm -w dm-out BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 Review-Url: https://codereview.chromium.org/2361983002
* Change SkSpecialImage::makeSurface and makeTightSurface to take outputGravatar brianosman2016-09-23
| | | | | | | | | | | | | | | | | | | | | | properties (color space), bounds, and (optional) alphaType. We were being pretty inconsistent before. Raster was honoring all components of the info. GPU was using the supplied color type, but propagating the source's color space. All call sites were saying N32. What we want to do is propagate the original device's color space, and pick a good format from that. Rather than force all the clients to jump through hoops constructing an SkImageInfo that meets our criteria, just have them supply the few bits we care about, and do everything else internally. This also lets us always use RGBA on GPU, but N32 on raster. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349373004 Committed: https://skia.googlesource.com/skia/+/53c38087949252d27cde668368a3eeb59cc2eb00 Review-Url: https://codereview.chromium.org/2349373004
* Add validation of RRects to SkValidatingReadBufferGravatar Robert Phillips2016-09-23
| | | | | | | | | | | This comes from the Skia fuzzer where it is inverting the RRect's rect which causes trouble down the line. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2591 Change-Id: I5c34105a47369492d2df99d39a4e29116060ad37 Reviewed-on: https://skia-review.googlesource.com/2591 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Don't compute path keys for volatile paths in GrShape.Gravatar bsalomon2016-09-23
| | | | | | | | | Otherwise, we will compute cache keys for internally transformed paths that don't repeat (e.g. clip paths transformed into device space with a changing view matrix). BUG=chromium:649562 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369513002 Review-Url: https://codereview.chromium.org/2369513002
* Add Pixel C knobs to skpbenchGravatar csmartdalton2016-09-23
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369533002 Review-Url: https://codereview.chromium.org/2369533002
* Some Vulkan memory fixes and cleanupGravatar jvanverth2016-09-23
| | | | | | | | | | | | | * Switch back to not setting transfer_dst on all buffers * Add some missing unit tests * Add tracking of heap usage for debugging purposes * Fall back to non-device-local memory if device-local allocation fails BUG=skia:5031 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003 Committed: https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455 Review-Url: https://codereview.chromium.org/2356343003
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 00:52:51 +0000