aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* sync docs up with tip of treeGravatar Cary Clark2018-06-27
| | | | | | | | | | | | | | | | | | | | Also check in work in progress for blend modes, round rects, and a placeholder for pictures. One minor include change to add a parameter name for SkBlendMode function. TBR=reed@google.com R=caryclark@google.com Docs-Preview: https://skia.org/?cl=134200 Bug: skia:6898 Change-Id: I5d2a9221d61edb32d9c7edbb3193401605b2b513 Reviewed-on: https://skia-review.googlesource.com/134200 Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org> Auto-Submit: Cary Clark <caryclark@skia.org>
* Implement SkFontMgr_FontConfigInterface::onMatchFamilyStyleGravatar Ben Wagner2018-06-27
| | | | | | | | | | | This allows for more uniformity of use, as well as allowing blink to avoid the legacy request cache needed by gfx. BUG=skia:8113 Change-Id: Ibde94c175410213e62de0910a94c50672f24c272 Reviewed-on: https://skia-review.googlesource.com/137885 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Revert "Move Vulkan DebugCallback code into tools."Gravatar Greg Daniel2018-06-27
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d4b2adeaa929edd1664754ac6621ec524992ef03. Reason for revert: Need to revert earlier changes cause of fucshia Original change's description: > Move Vulkan DebugCallback code into tools. > > Bug: skia: > Change-Id: Ib356200e86e54f9ff0ba16396874e6fd10cf0465 > Reviewed-on: https://skia-review.googlesource.com/137424 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: I38d4e71dc29c6503f92712be54e22c58956498c5 Reviewed-on: https://skia-review.googlesource.com/137902 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Increase number of concurrent requests that fiddlecli makes to fiddle.skia.org.Gravatar Joe Gregorio2018-06-27
| | | | | | | | | Bug: skia: Change-Id: I6de7bfadf9c955f7c08c670164f78a988ab7ab9f Reviewed-on: https://skia-review.googlesource.com/137860 Auto-Submit: Joe Gregorio <jcgregorio@google.com> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* Roll skia/third_party/skcms 97bcdb1d73a1..4268c0b12bf2 (1 commits)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-06-27
| | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms.git/+log/97bcdb1d73a1..4268c0b12bf2 2018-06-27 mtklein@chromium.org add a warning about non-D50 profiles The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=jcgregorio@google.com Change-Id: I6b255af186883cf76df9884ce274abcadf20553c Reviewed-on: https://skia-review.googlesource.com/137941 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/angle2 82af620e0559..09303e448d17 (1 commits)Gravatar angle-skia-autoroll2018-06-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/82af620e0559..09303e448d17 git log 82af620e0559..09303e448d17 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 jdarpinian@chromium.org Treat transform feedback generic binding point specially Created with: gclient setdep -r third_party/externals/angle2@09303e448d17 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=jcgregorio@google.com Change-Id: Iec372a7b123e4d3cab96092d1ae72fcd97353946 Reviewed-on: https://skia-review.googlesource.com/137920 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert "Let client pass in full extension to GrVkBackendContext."Gravatar Greg Daniel2018-06-27
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 45c9dab4c3ec43cedb28d1b8c08e166fe0c2e767. Reason for revert: fucshia uses GrVkBackendContext. Need to revert earlier changes Original change's description: > Let client pass in full extension to GrVkBackendContext. > > Bug: skia: > Change-Id: I772ab4ccbca0f4f7e7d429d6c421b07d97f0606f > Reviewed-on: https://skia-review.googlesource.com/131880 > Reviewed-by: Jim Van Verth <jvanverth@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com Change-Id: I1a765ff406c83cb234c3614b804fbed677d5a382 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/137901 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Let client pass in full extension to GrVkBackendContext.Gravatar Greg Daniel2018-06-27
| | | | | | | | Bug: skia: Change-Id: I772ab4ccbca0f4f7e7d429d6c421b07d97f0606f Reviewed-on: https://skia-review.googlesource.com/131880 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Roll third_party/externals/angle2 0265e1ec1eb7..82af620e0559 (6 commits)Gravatar angle-skia-autoroll2018-06-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/0265e1ec1eb7..82af620e0559 git log 0265e1ec1eb7..82af620e0559 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 jie.a.chen@intel.com ParallelCompile: Add entry points. 2018-06-26 ynovikov@chromium.org Skip ClearTest.ChangeFramebufferAttachmentFromRGBAtoRGB on Mac 2018-06-26 geofflang@chromium.org GL: Don't print driver performance warnings. 2018-06-26 ynovikov@chromium.org Skip MaxTextureSizeTest.SpecificationTexImage on Win Intel Vulkan 2018-06-26 geofflang@chromium.org Revert "RendererGL: Limit warning output to 5 per message type." 2018-06-26 fjhenigman@chromium.org Vulkan: add SCALED vertex formats to table. Created with: gclient setdep -r third_party/externals/angle2@82af620e0559 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=jcgregorio@google.com Change-Id: Ie343782b52e43a2bbccb4d0838022cbebb066ce3 Reviewed-on: https://skia-review.googlesource.com/137840 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Update markdown filesGravatar skia-bookmaker2018-06-27
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=rmistry@google.com NO_MERGE_BUILDS Change-Id: Id2185b2901cf3865d620e7b15d0f0dd618c3ccc9 Reviewed-on: https://skia-review.googlesource.com/137822 Commit-Queue: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com> Reviewed-by: <skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com>
* gpu: Expose GrContextPriv::abandoned in the public API.Gravatar Khushal2018-06-27
| | | | | | | | | | TBR=bsalomon@google.com Bug: 854416 Change-Id: Iab71ca6e4724a925b0b9791267aac5ddc34f5b15 Reviewed-on: https://skia-review.googlesource.com/137692 Reviewed-by: Khusal Sagar <khushalsagar@chromium.org> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
* ccpr: Add a context option to disable ccprGravatar Chris Dalton2018-06-27
| | | | | | | | | | TBR=bsalomon@google.com Bug: skia:856404 Change-Id: Icc6f3d1e7ef97f1853427a3b1cdd405961e6ac26 Reviewed-on: https://skia-review.googlesource.com/137763 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-26
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/a991ac69eb052dfbd460459203d4946168622385 gn: Look in src for gn binaries before trying old buildtools location (scottmg@chromium.org) recipe_engine: https://crrev.com/b1546529ec629fa8ddf804916c94b6e06c44d693 Add simple `archive` module for tar + zip. (iannucci@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iade897d995624050961ce1a204cc11aa5808b6ac Reviewed-on: https://skia-review.googlesource.com/137800 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll third_party/externals/angle2 5bdf8bd1cf56..0265e1ec1eb7 (26 commits)Gravatar angle-skia-autoroll2018-06-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/5bdf8bd1cf56..0265e1ec1eb7 git log 5bdf8bd1cf56..0265e1ec1eb7 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 lucferron@chromium.org Ozone: Skip test failing just on GLES 2018-06-26 jmadill@chromium.org Vulkan: Fix unused sampler struct uniforms. 2018-06-26 jmadill@chromium.org Program: Sampler uniform query in front-end. 2018-06-26 fjhenigman@chromium.org Vulkan: enable some vertex data tests. 2018-06-26 tobine@google.com Move PlatformMethods constructor to header 2018-06-26 jmadill@chromium.org Vulkan: Remove expectations for passing/missing tests. 2018-06-26 jmadill@chromium.org Add kEmptyImmutableString. 2018-06-26 lucferron@chromium.org Vulkan: Edge case test and fix for alpha channel masks 2018-06-26 lucferron@chromium.org Context init should set DIRTY_BIT_DRAW_FRAMEBUFFER_BINDING 2018-06-26 geofflang@chromium.org Partially revert "WGL: Support unvirtualized contexts and unsafe multithreading." 2018-06-26 jmadill@chromium.org Vulkan: Implement nested sampler structs. 2018-06-26 jmadill@chromium.org Vulkan: Sampler structs in arrays. 2018-06-26 ianelliott@google.com Initial Android implementation of GetSystemInfo 2018-06-26 geofflang@chromium.org RendererGL: Limit warning output to 5 per message type. 2018-06-25 jiawei.shao@intel.com ES31: Support compute shader shared variables in HLSL 2018-06-22 ynovikov@chromium.org Remove FormatString for real 2018-06-22 lucferron@chromium.org Vulkan: Add drawQuad to a sampler test 2018-06-22 lucferron@chromium.org Vulkan: Cleanup InstancingTest logic and enable tests for Vulkan 2018-06-22 geofflang@chromium.org Temporarily skip MakeCurrentMultiContext test on Windows AMD OpenGL. 2018-06-22 jmadill@chromium.org Vulkan: Add RenderTargetVk::getImageForRead. 2018-06-22 jie.a.chen@intel.com ParallelCompile: Update gl.xml 2018-06-22 jmadill@chromium.org Vulkan: Fix mixed descriptor pool updates. 2018-06-22 jmadill@chromium.org Vulkan: Fix releasing Programs that are in use. 2018-06-22 jmadill@chromium.org Vulkan: Refactor DynamicDescriptorPool. 2018-06-21 geofflang@chromium.org Pass all context creation parameters to DisplayImpl::createContext. 2018-06-21 geofflang@chromium.org WGL: Support unvirtualized contexts and unsafe multithreading. Created with: gclient setdep -r third_party/externals/angle2@0265e1ec1eb7 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Build-Debian9-Clang-x86_64-Release-ANGLE;skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE;skia.primary:Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE TBR=jcgregorio@google.com Change-Id: Ibf3d252a7cd83d565d061130713e2dbfed452f82 Reviewed-on: https://skia-review.googlesource.com/137741 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll third_party/externals/swiftshader 41b7748432ef..659d89e94bf9 (2 commits)Gravatar swiftshader-skia-autoroll2018-06-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://swiftshader.googlesource.com/SwiftShader.git/+log/41b7748432ef..659d89e94bf9 git log 41b7748432ef..659d89e94bf9 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 capn@google.com Support glCopyTexImage2D for float formats. 2018-06-26 capn@google.com Always create an OpenGL ES 3.0 context. Created with: gclient setdep -r third_party/externals/swiftshader@659d89e94bf9 The AutoRoll server is located here: https://swiftshader-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Debian9-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader TBR=jcgregorio@google.com Change-Id: I3d5cd1f5cd611679d6740dfa293cfc9653a8ed01 Reviewed-on: https://skia-review.googlesource.com/137740 Reviewed-by: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: swiftshader-skia-autoroll <swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-26
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/83a57e01cd02356704fb43f08cc4fa49060795df [cipd] Bump cipd and vpython 550cea2b9a -> aacec5af4d. (vadimsh@chromium.org) https://crrev.com/7ccf2f0c21b30b88a462108ee2e39ed7d55b2f2f gclient: Report what dependencies were not processed. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Icbd1b1ac621c1ec6419697e9c6b8e2edc812c189 Reviewed-on: https://skia-review.googlesource.com/137708 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
* Improve CMakeLists.txt auto regeneration.Gravatar Ben Wagner2018-06-26
| | | | | | | | | | | | | Check that the re-generation could actually run ninja. Specify the gn_deps by absolute path names. Depend on the gn_to_cmake.py generator. Change-Id: I5f93031d35f0b239b899fe1716fb1f6a4c67f77e Reviewed-on: https://skia-review.googlesource.com/137397 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Fix some shadow issues.Gravatar Jim Van Verth2018-06-26
| | | | | | | | | | | | | | | | * Clamp path polygon points to nearest 1/16th of a pixel to help with floating point issues. * Added check for multiple contour paths. * Return empty SkVertices for certain degenerate cases to avoid unnecessary blurs. * Check iteration count in SkOffsetPolygon to avoid infinite loops. * Add new tests to verify these. Bug: skia: Change-Id: Ie6ad48d2504e065dcc822609d369f90c56ef3ad3 Reviewed-on: https://skia-review.googlesource.com/136701 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* [Bazel] Omit new test that causes infinite loop in libjpeg-turbo.Gravatar Ben Wagner2018-06-26
| | | | | | | | | | | | | This test was added in https://skia-review.googlesource.com/c/skia/+/129459, but the fix is not yet in a libjpeg-turbo release. No-Try: true Change-Id: Ib7dce7a022934918f9f2e3467849d3e81cbf14cd Reviewed-on: https://skia-review.googlesource.com/137703 Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Handle F32 in lazy imageGravatar Brian Osman2018-06-26
| | | | | | | | | Bug: skia: Change-Id: Idec8259b48733830790a3957b41d204835d7be02 Reviewed-on: https://skia-review.googlesource.com/137705 Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Reland "Revert "Update GPU DM/nanobench configs for color testing""Gravatar Brian Osman2018-06-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c0fb3c8b9fea2f60062819e92a1fa7f0a1966fba. Reason for revert: Had to revert dependent CL. Original change's description: > Revert "Revert "Update GPU DM/nanobench configs for color testing"" > > This reverts commit 2a284de7a51c198096a6f34ec1cbfe9118db554c. > > Re-landing without esrgb configs. Going to enable those separately, > as they require some blacklisting. > > Bug: skia: > Change-Id: I2315849d4f5c45c2e5512f84f9f867d02ff6fe30 > Reviewed-on: https://skia-review.googlesource.com/136589 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> TBR=mtklein@google.com,bsalomon@google.com,brianosman@google.com Change-Id: I942d4235c17100fd933bf9cbfe923e3ae80657b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/137721 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Revert "Temporary fix for SkImage_Lazy handling of color spaces"Gravatar Brian Osman2018-06-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 439b99451445a9d61f0670bbe3f588f5b08f59fa. Reason for revert: Chrome tests failing. Original change's description: > Temporary fix for SkImage_Lazy handling of color spaces > > The aim is to always decode in the generator's color space, > with nonlinear blending. Eventually, we want to decode into > the destination color space, but that requires changing API > and caching flow. For now, this prevents linear premul when > decoding, and stops decoding to formats like F16 and sBGRA. > > Bug: skia: > Change-Id: I9efd909fa6a56df2547ad5955f109e113527f815 > Reviewed-on: https://skia-review.googlesource.com/136791 > Commit-Queue: Mike Klein <mtklein@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,brianosman@google.com Change-Id: Ie15c585b69e4309c090c8aafbe3c2d20191caa4d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/137720 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add subpixel offset to Viewer app.Gravatar Ben Wagner2018-06-26
| | | | | | | | | | | This adds a two dimensional location dragger to drag the origin across a pixel. Also makes the perspective dragger hidden when perspective is off. Also adds 'Z' to toggle the zoom window mouse follow. Change-Id: Ic75d16c95848b392608770c8ed0d4db23733242f Reviewed-on: https://skia-review.googlesource.com/137701 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* basic first pass at RGBA F32 supportGravatar Mike Klein2018-06-26
| | | | | | | | | | | | | Draws basically the same as f16. The existing load_f32, load_f32_dst, and store_f32 stages all had the same bug that we'd never noticed because dy was always 0 until now. Change-Id: Ibbd393fa1acc5df414be4cdef0f5a9d11dcccdb3 Reviewed-on: https://skia-review.googlesource.com/137585 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Disable --gpuThreads when skpbenching DDLsGravatar Robert Phillips2018-06-26
| | | | | | | | | This CL requires https://skia-review.googlesource.com/c/skia/+/136175 (Add --gpuThreads support to skpbench.py (take 2)) Change-Id: Iced00d6b6184ec41efe66a71a5b4e062ce7205ee Reviewed-on: https://skia-review.googlesource.com/136596 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Remove Vulkan code that supported creating a GrVkRenderTarget.Gravatar Greg Daniel2018-06-26
| | | | | | | | | | | We never create a pure RenderTarget. If we are creating a RT it is always a TexRT. The only pure RTs are wrapped. Bug: skia: Change-Id: If95d17d244e78c986ed6c63822d4b936ff67b88a Reviewed-on: https://skia-review.googlesource.com/137700 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* skpbench: Support .svg filesGravatar Chris Dalton2018-06-26
| | | | | | | | Bug: skia: Change-Id: I0337757f635c631870c02a65f8784fc190d1435e Reviewed-on: https://skia-review.googlesource.com/137540 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Revert "Revert "Update GPU DM/nanobench configs for color testing""Gravatar Brian Osman2018-06-26
| | | | | | | | | | | | | This reverts commit 2a284de7a51c198096a6f34ec1cbfe9118db554c. Re-landing without esrgb configs. Going to enable those separately, as they require some blacklisting. Bug: skia: Change-Id: I2315849d4f5c45c2e5512f84f9f867d02ff6fe30 Reviewed-on: https://skia-review.googlesource.com/136589 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Fix some static intializers in Vulkan code.Gravatar Greg Daniel2018-06-26
| | | | | | | | | Bug: skia: Change-Id: Ia5160376ff456874459430e51c2f57acdb1a4de1 Reviewed-on: https://skia-review.googlesource.com/137584 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Chris Blume <cblume@chromium.org> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Expose public factories for platform decodersGravatar Leon Scroggins III2018-06-26
| | | | | | | | | | | | | | | | | | | | | | Bug: skia:8076 Move SkImageGeneratorCG and SkImageGeneratorWIC to include/ports/, and make them SK_API. Remove SkImageGeneratorCG::NewFromEncodedCG. No known clients are using it, and it was a private API in src/. There is already a MakeFromEncodedCG to replace it. Similarly, switch WIC from New to Make. Add a compile test for using them with SetImageGeneratorFromEncodedDataFactory. Change-Id: I897eb7a887b3736a6c614a68e38f38b6a1942cf1 Reviewed-on: https://skia-review.googlesource.com/137387 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Clean up includes in SkMallocPixelRefGravatar Ben Wagner2018-06-26
| | | | | | | | Came across this unnecessary includes while experimenting with WASM Change-Id: I68061c7bbd18ed5695b94b3b8de6dbb63407b8ee Reviewed-on: https://skia-review.googlesource.com/137582 Reviewed-by: Mike Klein <mtklein@google.com>
* remove unused enumGravatar Mike Klein2018-06-26
| | | | | | | | | Change-Id: I9e7be63fdab8b1e4bc3038d48664962deefb6749 Reviewed-on: https://skia-review.googlesource.com/137586 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Refactor GrPipeline dynamic state.Gravatar Brian Salomon2018-06-26
| | | | | | | | | | | | | | | | | Remove scissor rect from GrPipeline. Draws can specify "fixed dynamic state" which doesn't use the dynamism at all or can specify dynamic state arrays with an entry per GrMesh. When we state other than scissor rects this will allow the caller to use a mix of truly dynamic and fixed dynamic state. So a caller that only has dynamic scissor rects doesn't need to store its remaining unvarying state in an array. Change-Id: I8fcc07eb600c72a26cc712b185755c2116021a8a Reviewed-on: https://skia-review.googlesource.com/137223 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add --gpuThreads support to skpbench.py (take 2)Gravatar Robert Phillips2018-06-26
| | | | | | | Change-Id: Ie946ff339c4e04bb866545ad60c2ab77bae85417 Reviewed-on: https://skia-review.googlesource.com/136175 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Update libjpeg-turbo to pre-2.0.0 (from 1.5.3)Gravatar Leon Scroggins III2018-06-26
| | | | | | | | | | | | | | | | | | jpeg_skip_scanlines was incorrectly incrementing an internal counter, resulting in an infinite loop. (This only occurs for certain types of progressive images, using certain sample sizes.) The fix is at https://github.com/libjpeg-turbo/libjpeg-turbo/commit/26f109290dc4ffc9c522d9f5d5a7d5d1ee2c0e0a. This is included in tip-of-tree, which is unofficially 2.0.0, so go ahead and update to it. Add a test based on the original bug. Bug: b/78329453 Change-Id: I5ade9924812324d58668c26f71cd622ef93f40a7 Reviewed-on: https://skia-review.googlesource.com/129459 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Temporary fix for SkImage_Lazy handling of color spacesGravatar Brian Osman2018-06-26
| | | | | | | | | | | | | | The aim is to always decode in the generator's color space, with nonlinear blending. Eventually, we want to decode into the destination color space, but that requires changing API and caching flow. For now, this prevents linear premul when decoding, and stops decoding to formats like F16 and sBGRA. Bug: skia: Change-Id: I9efd909fa6a56df2547ad5955f109e113527f815 Reviewed-on: https://skia-review.googlesource.com/136791 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* move blurimagefilter.cpp back into effectsGravatar Mike Reed2018-06-26
| | | | | | | | Bug: skia: Change-Id: I5711a9a8fcd135344e75cb4b505bd06044414c85 Reviewed-on: https://skia-review.googlesource.com/137581 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Fix instantiation of partially lazy proxiesGravatar Robert Phillips2018-06-26
| | | | | | | Change-Id: I941333711966da109583a3a72ab3464363285b84 Reviewed-on: https://skia-review.googlesource.com/137580 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Move Vulkan DebugCallback code into tools.Gravatar Greg Daniel2018-06-26
| | | | | | | | Bug: skia: Change-Id: Ib356200e86e54f9ff0ba16396874e6fd10cf0465 Reviewed-on: https://skia-review.googlesource.com/137424 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-26
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/a02505f564d2c8aa60e779669208af89affa58ec [cipd] Update cipd client and vpython 4d19637ec -> 550cea2b9. (vadimsh@chromium.org) recipe_engine: https://crrev.com/359385a94a0912af40d41eccc3fc594e68ddb65e autoroller: Search for gitattributes files only in modified dirs. (ehmaldonado@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If71d1013a19856503b813cbdfc6943a6e4afa917 Reviewed-on: https://skia-review.googlesource.com/137429 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2018-06-25
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/77094f7feabd1eb8a4ac2447e562628b453e2b77 Reland of "Wipe out shallow checkout support from bot_update." (tandrii@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I61cc272ec36c26fb3e73047d8157ffee706c3ee2 Reviewed-on: https://skia-review.googlesource.com/137427 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Fix compiler warning for MSVCGravatar Herb Derby2018-06-25
| | | | | | | Change-Id: Id62e746732fd42bc17c02399529cbeb1d10e4476 Reviewed-on: https://skia-review.googlesource.com/137426 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* explicitly include blurimagefilter includeGravatar Cary Clark2018-06-25
| | | | | | | | | | | | | | | | | Try explicitly adding to fix the bookmaker nightly bot. R=jcgregorio@google.com,caryclark@google.com Docs-Preview: https://skia.org/?cl=137421 Bug: skia:6898 Change-Id: Iff27845e6872b885b8494e9fc236f4f05c10c301 Reviewed-on: https://skia-review.googlesource.com/137421 Reviewed-by: Cary Clark <caryclark@skia.org> Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Joe Gregorio <jcgregorio@google.com> Auto-Submit: Cary Clark <caryclark@skia.org>
* Implement onMakeClone function on all subclasses of SkTypeface exceptGravatar Bruce Wang2018-06-25
| | | | | | | | | on mac. Change-Id: I2b8777a5b54e190c37623ab798a89b4f1833ceac Reviewed-on: https://skia-review.googlesource.com/137382 Commit-Queue: Bruce Wang <brucewang@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Put GrPrimitiveProcessor/GrGeometryProcessor before GrPipeline in param lists.Gravatar Brian Salomon2018-06-25
| | | | | | | | | | | We were inconsistent about which order these were in. Having the processor first will make the parameter order more logical for an upcoming change. Also, the primitive processor comes logically before the pipeline. Change-Id: I3968c5e4e6dff01f9c4ad311eb1795b3c7580ff5 Reviewed-on: https://skia-review.googlesource.com/137228 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Validate transformed SkPaintImageFilter rectsGravatar Adrienne Walker2018-06-25
| | | | | | | | | | These can be transformed into invalid rects, so don't try to draw them. Bug: chromium: 852048 Change-Id: I95a8b86557e550453efb0896f6d559a843f47d2a Reviewed-on: https://skia-review.googlesource.com/135924 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com>
* update externally published milestone scheduleGravatar Heather Miller2018-06-25
| | | | | | | | | | No-Try: true Docs-Preview: https://skia.org/?cl=137388 Bug: skia: Change-Id: I83e4da9722991d64190b5e6b73b87a8f9791d629 Reviewed-on: https://skia-review.googlesource.com/137388 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Heather Miller <hcm@google.com>
* remove bad assertGravatar Mike Reed2018-06-25
| | | | | | | | Bug: 855854 Change-Id: Ifad8fd1f89000b206de39ef261a99292ee63b7a1 Reviewed-on: https://skia-review.googlesource.com/137383 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Use indices into the vectors shared by runsGravatar Herb Derby2018-06-25
| | | | | | | | | | With multiple runs, the shared vectors were moving out from under the pointers in earlier runs. Change-Id: I486d2e603e18ea7effc0dbdbc7c5d3c545278703 Reviewed-on: https://skia-review.googlesource.com/137222 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* fix path measure fuzzesGravatar Cary Clark2018-06-25
| | | | | | | | | | | | | these fixes suppress debug asserts when the fuzzer is run R=reed@google.com,kjlubick@google.com Bug: skia: Change-Id: I7b8c16fe475056213314ecb588a4368b547836b0 Reviewed-on: https://skia-review.googlesource.com/137363 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Cary Clark <caryclark@skia.org>