aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Adding int cast to prevent warningGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | BUG=skia: R=fmalita@google.com, fmalita@chromium.org, bsalomon@google.com, bsalomon@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/149463009 git-svn-id: http://skia.googlecode.com/svn/trunk@13285 2bbb7eff-a529-9590-31e7-b0007b416f81
* don't initialize the default Skia tracer if one has already been providedGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/152903005 git-svn-id: http://skia.googlecode.com/svn/trunk@13284 2bbb7eff-a529-9590-31e7-b0007b416f81
* clean up a couple of parameters in the tracing interfaceGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/145973011 git-svn-id: http://skia.googlecode.com/svn/trunk@13283 2bbb7eff-a529-9590-31e7-b0007b416f81
* Initial QuadTree implementationGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | | | | | | | | In an effort to find a faster bounding box hierarchy than the R-Tree, a QuadTree has been implemented here. For now, the QuadTree construction is generally faster than the R-Tree and the queries are a bit slower, so overall, SKP local tests showed QuadTree performance similar to the R-Tree performance. Tests and bench are included in this cl. At this point, I'd like to be able to commit this in order to more easily use the bots to test multiple configurations and a larger number of SKPs. The R-Tree BBH is still used by default so this change shouldn't affect chromium. BUG=skia: R=junov@chromium.org, junov@google.com, senorblanco@google.com, senorblanco@chromium.org, reed@google.com, sugoi@google.com, fmalita@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/131343011 git-svn-id: http://skia.googlecode.com/svn/trunk@13282 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline imagefiltersgraph_gpu ↵Gravatar fmalita@google.com2014-02-03
| | | | | | | | | | | (Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release) BUG=skia:2118 TBR=senorblanco@chromium.org Review URL: https://codereview.chromium.org/148283012 git-svn-id: http://skia.googlecode.com/svn/trunk@13281 2bbb7eff-a529-9590-31e7-b0007b416f81
* hopefully last set of rebaselines for blurrectGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | | BUG=skia:2108 R=epoger@google.com TBR=epoger Author: humper@google.com Review URL: https://codereview.chromium.org/152803002 git-svn-id: http://skia.googlecode.com/svn/trunk@13280 2bbb7eff-a529-9590-31e7-b0007b416f81
* Allow GMs to be used as benchmarks. Make convex_poly_clip opt in.Gravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/151843002 git-svn-id: http://skia.googlecode.com/svn/trunk@13279 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to test the new PRESUBMIT authors checkGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | | | BUG=skia:2072 NOTRY=true TBR= (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/139993010 git-svn-id: http://skia.googlecode.com/svn/trunk@13278 2bbb7eff-a529-9590-31e7-b0007b416f81
* Check if the issue owner is in the AUTHORS file in PRESUBMIT.pyGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | | | | BUG=skia:2072 NOTRY=true (SkipBuildbotRuns) R=borenet@google.com, hcm@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/131293005 git-svn-id: http://skia.googlecode.com/svn/trunk@13277 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix valgrind issue in SkBase64Test.cppGravatar robertphillips@google.com2014-02-01
| | | | | | | | https://codereview.chromium.org/152153002/ git-svn-id: http://skia.googlecode.com/svn/trunk@13276 2bbb7eff-a529-9590-31e7-b0007b416f81
* Performance trigger rebaselinesGravatar robertphillips@google.com2014-02-01
| | | | | | | | https://codereview.chromium.org/151833004/ git-svn-id: http://skia.googlecode.com/svn/trunk@13275 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-01
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13274 2bbb7eff-a529-9590-31e7-b0007b416f81
* Split GrUnitTests.cpp into two separate unit tests.Gravatar tfarina@chromium.org2014-01-31
| | | | | | | | | | | | | GrUnitTests is too generic. Instead we split this file between the two APIs being tested there, GrTBSearch and GrBinHashKey. BUG=None TEST=tests -m GrTBSearchTest && tests -m GrBinHashKeyTest R=brian@thesalomons.net, robertphillips@google.com Review URL: https://codereview.chromium.org/150943002 git-svn-id: http://skia.googlecode.com/svn/trunk@13273 2bbb7eff-a529-9590-31e7-b0007b416f81
* add SkCanvas constructor that explicitly creates no_config with dimensionsGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia: R=scroggo@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/137833016 git-svn-id: http://skia.googlecode.com/svn/trunk@13272 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adding Chromium authors to the AUTHORS file.Gravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | | | | | Some Googlers commit code into Skia using their chromium.org accounts. The Chromium AUTHORS file has a similar entry: http://src.chromium.org/viewvc/chrome/trunk/src/AUTHORS (SkipBuildbotRuns) NOTRY=true BUG=skia:2072 R=hcm@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/146853004 git-svn-id: http://skia.googlecode.com/svn/trunk@13271 2bbb7eff-a529-9590-31e7-b0007b416f81
* Do not enforce the public API presubmit check for Revert CLs.Gravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | NOTRY=true BUG=skia:2068 R=borenet@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/151573002 git-svn-id: http://skia.googlecode.com/svn/trunk@13270 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix leaks in SkConfGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | | | | These leaks were small and would only happen with non-default runtime configuration things set, but they were still leaks and they should be squished. Valgrind reported leaks pre-patch, and all the rtconf leaks are gone after patch. BUG=skia:1722 R=reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/136963004 git-svn-id: http://skia.googlecode.com/svn/trunk@13269 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaselines for ↵Gravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | | | https://skia.googlesource.com/skia.git/+/0b9ada1318acf7d5fe90c57331c2a4548aad8b98 BUG=skia:2113 NOTREECHECKS=True NOTRY=True R=epoger@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/151623002 git-svn-id: http://skia.googlecode.com/svn/trunk@13268 2bbb7eff-a529-9590-31e7-b0007b416f81
* remaining rebaselines for rects GM testGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | BUG=skia:2108 NOTREECHECKS=True NOTRY=True R=humper@google.com TBR=humper Author: epoger@google.com Review URL: https://codereview.chromium.org/148483005 git-svn-id: http://skia.googlecode.com/svn/trunk@13267 2bbb7eff-a529-9590-31e7-b0007b416f81
* remaining GM rebaselines for blurquickreject and megalooper testsGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | BUG=skia:2108 NOTREECHECKS=True NOTRY=True R=humper@google.com TBR=humper Author: epoger@google.com Review URL: https://codereview.chromium.org/134923007 git-svn-id: http://skia.googlecode.com/svn/trunk@13266 2bbb7eff-a529-9590-31e7-b0007b416f81
* Have peek32 return uint32_t& to make it harder to look at more than 4 bytes.Gravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia: R=reed@google.com, robertphillips@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/145053003 git-svn-id: http://skia.googlecode.com/svn/trunk@13265 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix bad gyp file moveGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/151353004 git-svn-id: http://skia.googlecode.com/svn/trunk@13264 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebase simpleblurroundrect and bleed GMs after GPU blur radius changes.Gravatar bsalomon@google.com2014-01-31
| | | | | | | | BUG=skia:1998 Review URL: https://codereview.chromium.org/151503005 git-svn-id: http://skia.googlecode.com/svn/trunk@13263 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add GM with convex polygon clipsGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia:2051 R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/136563004 git-svn-id: http://skia.googlecode.com/svn/trunk@13262 2bbb7eff-a529-9590-31e7-b0007b416f81
* Set the horizontal scanline to NULL when the vertical one failsGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/150013004 git-svn-id: http://skia.googlecode.com/svn/trunk@13261 2bbb7eff-a529-9590-31e7-b0007b416f81
* release the scanline textures in GrRectBlurEffectGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/131163007 git-svn-id: http://skia.googlecode.com/svn/trunk@13260 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add shim for SkOrderedReadBuffer.h too.Gravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | Sorry, I specifically looked for this and failed the first time. BUG=skia: R=robertphillips@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/151093002 git-svn-id: http://skia.googlecode.com/svn/trunk@13259 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-01-31
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13258 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix auto-delete bug that crept in with new fast blur path; is causingGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | some of the valgrind errors. BUG=skia:2111 R=bsalomon@google.com, robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/148593003 git-svn-id: http://skia.googlecode.com/svn/trunk@13257 2bbb7eff-a529-9590-31e7-b0007b416f81
* initial import of Chrome's trace_event into skia frameworkGravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | | | | | | | | | | | This patch includes a modified version of Chrome's trace_event.h, which provides tracing macros that can easily integrate into the about://tracing framework. Currently the macros link to a default implementation of the (narrow) tracing class SkDefaultEventTracer which does nothing; next step will be to have Chrome subclass the SkEventTracer with a shim that bolts Skia's trace events to its own, allowing Skia's trace events to show up in about://tracing. I've verified that this file builds properly, and when I added a simple scoped TRACE_EVENT0 to SkCanvas::drawRect, along with some debug prints in the NOP implementation of tracing, I saw what I expected printed to the screen. BUG=skia: R=nduca@chromium.org, reed@google.com, mtklein@google.com, bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/149563004 git-svn-id: http://skia.googlecode.com/svn/trunk@13256 2bbb7eff-a529-9590-31e7-b0007b416f81
* even more rebaselines for blurGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia:2108 R=epoger@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/149823003 git-svn-id: http://skia.googlecode.com/svn/trunk@13255 2bbb7eff-a529-9590-31e7-b0007b416f81
* Port SkBase64 test to our test driver.Gravatar tfarina@chromium.org2014-01-30
| | | | | | | | | | BUG=None TESTS=tests --match SkBase64Test R=mtklein@google.com, reed@google.com Review URL: https://codereview.chromium.org/132233060 git-svn-id: http://skia.googlecode.com/svn/trunk@13254 2bbb7eff-a529-9590-31e7-b0007b416f81
* Set write buffer flags only in SkWriteBuffer and SkFlatController constructors.Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | | This is a baby step toward refactored (and faster in-process) typeface and flattenable factory encoding and decoding. The sooner SkWriteBuffer knows its flags, the better. Next steps will be to rearrange Sk{Read,Write}Buffer members into disjoint strategies to handle typefaces and flattenable factories: one for in-process, one for cross-process, one when validating. BUG=skia: R=reed@google.com, scroggo@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/138803005 git-svn-id: http://skia.googlecode.com/svn/trunk@13253 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove (unnecessary) SkScalarMul and SkScalarMulAdd macros from SkMatrix.cpp.Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | SkScalarMulDiv remains, but it can be removed later (though it is slightly clearer to use it at times). BUG=skia: R=caryclark@google.com, mtklein@google.com, halcanary@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/150493002 git-svn-id: http://skia.googlecode.com/svn/trunk@13252 2bbb7eff-a529-9590-31e7-b0007b416f81
* add_codereview_message script to append messages to a CLGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add add_codereview_message.py script. This script takes a message and a codereview URL as arguments calls `git cl upload` to append the message to the given codereview issue. Motivation: We are automating a process of testing Chromium/Skia DEPS rolls where roll_deps.py is automatically run every night, and then at a later time, compare_codereview.py is run to generate a report of the trybot results. This script can be used to append that report to the DEPS roll Cl. This CL also refactors functioanlity common to roll_deps and add_codereview_message: * Add tools/git_utils.py module. - ChangeGitBranch class was factored out of roll_deps.GitBranchCLUpload. The other half of that class became roll_deps.git_cl_uploader function. I make use of this new class in both roll_deps and upload_deps_roll. - test_git_executable moved to this new module. * Add tools/misc_utils.py - move VerboseSubprocess, ChangeDir, and ReSearch classes from roll_deps module. * Remove generic functions from roll_deps. * Add git_cl_uploader function to roll_deps. Refactor roll_deps.roll_deps function to make use of it BUG=skia: R=borenet@google.com, robertphillips@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/141483011 git-svn-id: http://skia.googlecode.com/svn/trunk@13251 2bbb7eff-a529-9590-31e7-b0007b416f81
* mark imageblur_gpu gm tests as ignore-failure on IntelRhbGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | BUG=skia:2085 NOTRY=True R=senorblanco@google.com TBR=senorblanco Author: epoger@google.com Review URL: https://codereview.chromium.org/150813002 git-svn-id: http://skia.googlecode.com/svn/trunk@13250 2bbb7eff-a529-9590-31e7-b0007b416f81
* Replace factory generation of TextContexts with persistent objects.Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia:2018 R=bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/150743002 git-svn-id: http://skia.googlecode.com/svn/trunk@13249 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove GM expectations for all ASAN/Valgrind buildersGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | BUG=skia:2112 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/140323020 git-svn-id: http://skia.googlecode.com/svn/trunk@13248 2bbb7eff-a529-9590-31e7-b0007b416f81
* more blurrect rebaselinesGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia:2108 R=epoger@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/136813005 git-svn-id: http://skia.googlecode.com/svn/trunk@13247 2bbb7eff-a529-9590-31e7-b0007b416f81
* create empty expectations for Logan botsGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | BUG=skia:2107 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/150543004 git-svn-id: http://skia.googlecode.com/svn/trunk@13246 2bbb7eff-a529-9590-31e7-b0007b416f81
* Refactor read and write buffers.Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Eliminates SkFlattenable{Read,Write}Buffer, promoting SkOrdered{Read,Write}Buffer a step each in the hierarchy. What used to be this: SkFlattenableWriteBuffer -> SkOrderedWriteBuffer SkFlattenableReadBuffer -> SkOrderedReadBuffer SkFlattenableReadBuffer -> SkValidatingReadBuffer is now SkWriteBuffer SkReadBuffer -> SkValidatingReadBuffer Benefits: - code is simpler, names are less wordy - the generic SkFlattenableFooBuffer code in SkPaint was incorrect; removed - write buffers are completely devirtualized, important for record speed This refactoring was mostly mechanical. You aren't going to find anything interesting in files with less than 10 lines changed. BUG=skia: R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/134163010 git-svn-id: http://skia.googlecode.com/svn/trunk@13245 2bbb7eff-a529-9590-31e7-b0007b416f81
* Suppress new valgrind complaintGravatar robertphillips@google.com2014-01-30
| | | | | | | | https://codereview.chromium.org/144853006/ git-svn-id: http://skia.googlecode.com/svn/trunk@13244 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline GM changes resulting from fast GPU blur algorithmGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/150493005 git-svn-id: http://skia.googlecode.com/svn/trunk@13243 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add convex polygon rendering effect and GM to test it.Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia:2051 R=robertphillips@google.com, jvanverth@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/149683004 git-svn-id: http://skia.googlecode.com/svn/trunk@13242 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline imagefiltersgraph_gpu GMs on Nexus10Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | BUG=skia:2106 NOTREECHECKS=True NOTRY=True R=bsalomon@google.com TBR=bsalomon Author: epoger@google.com Review URL: https://codereview.chromium.org/150113003 git-svn-id: http://skia.googlecode.com/svn/trunk@13241 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline perf because of faster tests after GPU glur changesGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/150563002 git-svn-id: http://skia.googlecode.com/svn/trunk@13240 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move GrTextContext to private interfaceGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | NOTRY=true R=bsalomon@google.com, reed@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/145073005 git-svn-id: http://skia.googlecode.com/svn/trunk@13239 2bbb7eff-a529-9590-31e7-b0007b416f81
* patch from issue 119343003Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | | compile on 10.6, exclude failing gms Sorry for making another CL; rebasing ToT on the old one ended up with code in a tangled mess; was easier to start over. NOTRY=true R=bsalomon@google.com, epoger@google.com, reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/148883005 git-svn-id: http://skia.googlecode.com/svn/trunk@13238 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reland "Add --skip_cpu and --skip_gpu options to tests"Gravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | NOTRY=true BUG=skia:2074 R=djsollen@google.com, mtklein@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/135163004 git-svn-id: http://skia.googlecode.com/svn/trunk@13237 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add fallback code for TextContexts that don't support all featuresGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | BUG=skia:2018 NOTRY=true R=bsalomon@google.com, reed@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/135683006 git-svn-id: http://skia.googlecode.com/svn/trunk@13236 2bbb7eff-a529-9590-31e7-b0007b416f81