aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Revert "Scale the GPU when running perf on Pixel(2)"Gravatar Ravi Mistry2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit aa504cddb9196a3f5e798a280061ba6eb3c22901. Reason for revert: Kevin asked me to revert since this broke things Original change's description: > Scale the GPU when running perf on Pixel(2) > > This is a similar followup to: > https://skia-review.googlesource.com/c/skia/+/93561 > > Bug: skia: > Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc > Reviewed-on: https://skia-review.googlesource.com/114340 > Reviewed-by: Eric Boren <borenet@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> TBR=borenet@google.com,kjlubick@google.com Change-Id: Idbc7234f2b7ff8c5e632680903836e1f4eaa50d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114425 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* fixed SkSL SPIR-V vector comparisonsGravatar Ethan Nicholas2018-03-14
| | | | | | | | Bug: skia: Change-Id: I57788fe427f62e20c6e073fd96279910febef22e Reviewed-on: https://skia-review.googlesource.com/114367 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Add accessor and less for raw glyph ID and WSGravatar Herb Derby2018-03-14
| | | | | | | | | | Accessor is for debugging and Android. Less is for ordered containers. Change-Id: Ic4b7e0e9e32506f8594db961c274f93c5b5d1cee Reviewed-on: https://skia-review.googlesource.com/114369 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Add incompleteShortIntPrecision to SkSL StandaloneShaderCapsGravatar Chris Dalton2018-03-14
| | | | | | | | | | TBR=ethannicholas@google.com Bug: skia: Change-Id: If3b86e414d74072dd3e38a5507bbcbcecc3946f6 Reviewed-on: https://skia-review.googlesource.com/114378 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Scale the GPU when running perf on Pixel(2)Gravatar Kevin Lubick2018-03-14
| | | | | | | | | | | This is a similar followup to: https://skia-review.googlesource.com/c/skia/+/93561 Bug: skia: Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc Reviewed-on: https://skia-review.googlesource.com/114340 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Revert "Update clang_win to yesterday's build (from Chromium)."Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit cefa808f3f237434139ce5fbbbbaf34cbc90e368. Reason for revert: Flaky failure: LINK : fatal error LNK1104: cannot open file 'c:\b\s\w\ir\clang_win\lib\clang\6.0.0\lib\windows\clang_rt.ubsan_standalone-x86_64.lib' Original change's description: > Update clang_win to yesterday's build (from Chromium). > > Change-Id: Iea0f841f7c9a3449213c549ba310ab2a3d928ca2 > Reviewed-on: https://skia-review.googlesource.com/114093 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> TBR=mtklein@chromium.org,mtklein@google.com,benjaminwagner@google.com Change-Id: I1e738d48f75fbd5878658bc79f3d340dd5acfe0a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/114424 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Revert "Improve handling of GrPixelConfig in GrBackendTex/RT ctors"Gravatar Greg Daniel2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7d2b16ad13fd3262c776ae75ae35da4ad69df690. Reason for revert: Maybe breaking chrome? Original change's description: > Improve handling of GrPixelConfig in GrBackendTex/RT ctors > > Make sure that no client facing code was relying on what we set as the > default value for fConfig by making in kUnkown. > > Bug: skia: > Change-Id: Ie52ff08ba8deeacc16fe06eb0dd0c7292b2edf91 > Reviewed-on: https://skia-review.googlesource.com/114261 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: I91e190d72407f9c4bee93a031a557f740bb49b66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114423 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Add Win x86 Clang Perf/Test jobs."Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 40091fd4fc453eb514bf7ca903326fa3538ab6c9. Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 Original change's description: > Add Win x86 Clang Perf/Test jobs. > > Also switch CQ Win 32-bit Build from MSVC to Clang. > > No-Try: true > Change-Id: Ic312ee611b1e99143480840c08a9266a4d8b448b > Reviewed-on: https://skia-review.googlesource.com/113672 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,benjaminwagner@google.com Change-Id: I6a13e97df461bd61eac92bbc3c498146b5322a4a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/114421 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* hide SkBlurMaskFilter and SkBlurQualityGravatar Mike Reed2018-03-14
| | | | | | | | | | SK_SUPPORT_LEGACY_BLURMASKFILTER Bug: skia: Change-Id: Ic3e27e08e6e3cd2ffc1cd13b044e197bebc96236 Reviewed-on: https://skia-review.googlesource.com/113940 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Experiment: relax 4 byte alignment for glyph imagesGravatar Herb Derby2018-03-14
| | | | | | | | | | | | | This experiment remove the need for rowbytes to be 4 byte aligned in width. This causes waste in data transfer between the Renderer and GPU process. BUG=skia:7515 Change-Id: Iad0383ee0adbacaa791bf4251325867e82fdbea1 Reviewed-on: https://skia-review.googlesource.com/114371 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Revert "Add back missing unique key checks when creating CachedBitmap/Image ↵Gravatar Greg Daniel2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Proxies" This reverts commit b78dd5d01eb16ae3cb9104ce8c0fa7e861431259. Reason for revert: possibly breaking chrome roll Original change's description: > Add back missing unique key checks when creating CachedBitmap/Image Proxies > > Its possible that this could fix perf regression in Chrome. > > Bug: 811452 > Change-Id: I2d4f7827092b361469586580f0c7c843ab2d5cec > Reviewed-on: https://skia-review.googlesource.com/114280 > Commit-Queue: Greg Daniel <egdaniel@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: I71646befd07bf28442ac3b9225c021cd141bf398 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811452 Reviewed-on: https://skia-review.googlesource.com/114422 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Switch Win Exceptions Build to Clang."Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e1cb4778c70a6bef543a8936c5521a71a037f551. Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 Original change's description: > Switch Win Exceptions Build to Clang. > > No-Try: true > Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431 > Reviewed-on: https://skia-review.googlesource.com/113673 > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,benjaminwagner@google.com Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/114420 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Remove Goma builds and support in gn_flavor.Gravatar Ben Wagner2018-03-14
| | | | | | | | | | | | The experiment with using Goma to speed up Windows compiles was very close to being successful, but at this point the ongoing maintenance does not seem to be worth the 50-70 seconds saved. Change-Id: Ie3900b9a681e448a3e47634efbab7695ebccad33 Reviewed-on: https://skia-review.googlesource.com/114363 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Roll skia/third_party/externals/angle2/ fccebffe6..87db7c524 (4 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/fccebffe63cf..87db7c524e70 $ git log fccebffe6..87db7c524 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 jmadill D3D11: Minor cleanup to DrawCallVertexParams. 2018-03-14 jmadill Vulkan: Implement basic depth/stencil buffers. 2018-03-14 lucferron Sort the Format_table_autogen.cpp switch case by gl format 2018-03-02 oetuaho Use function id to group functions in ParseContext Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: I953db675111741594d0813b4bfda9490a338eb14 Reviewed-on: https://skia-review.googlesource.com/114372 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* ccpr: Add an attenuation parameter to triangle cornersGravatar Chris Dalton2018-03-14
| | | | | | | | | | | | | Adds an attenuation parameter to corners that corrects the over-coverage from linear interpolation. Adds a GM for shared corners that ensures we're doing this right. Bug: skia: Change-Id: Iff8bd40554f9fda2e7e03faa3c9fbefe65f27568 Reviewed-on: https://skia-review.googlesource.com/114272 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add a shader cap for incomplete short int precisionGravatar Chris Dalton2018-03-14
| | | | | | | | | Bug: skia: Change-Id: Iac36eb763e687f6ecc3acbd4afced66f95596be2 Reviewed-on: https://skia-review.googlesource.com/109003 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Roll skia/third_party/externals/skcms/ 6cecdee60..2b5c77024 (1 commit)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms/+log/6cecdee60988..2b5c7702441a $ git log 6cecdee60..2b5c77024 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 brianosman ApproximateTransferFunction -> ApproximateCurves Created with: roll-dep skia/third_party/externals/skcms The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=stephana@google.com Change-Id: I9a723e3aed3662c9b6727dd11ff542fa35592a91 Reviewed-on: https://skia-review.googlesource.com/114366 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Cleanup TODO in gen_tasksGravatar Kevin Lubick2018-03-14
| | | | | | | | | | It is well after December 2017 Bug: skia: Change-Id: I3e48735dac9885606bdecab301379a1312966ff1 Reviewed-on: https://skia-review.googlesource.com/114361 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Switch Win Exceptions Build to Clang.Gravatar Ben Wagner2018-03-14
| | | | | | | | No-Try: true Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431 Reviewed-on: https://skia-review.googlesource.com/113673 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Add Win x86 Clang Perf/Test jobs.Gravatar Ben Wagner2018-03-14
| | | | | | | | | | Also switch CQ Win 32-bit Build from MSVC to Clang. No-Try: true Change-Id: Ic312ee611b1e99143480840c08a9266a4d8b448b Reviewed-on: https://skia-review.googlesource.com/113672 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Provide promise images when rendering SKPs w/ DDLGravatar Robert Phillips2018-03-14
| | | | | | | Change-Id: I8014693eefb3c7811a1fc0354ee8441c90c97328 Reviewed-on: https://skia-review.googlesource.com/113213 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Ensure that GrGpu state tracking is initialized before making a backend ↵Gravatar Brian Salomon2018-03-14
| | | | | | | | | RT/Tex in tests Change-Id: Ie5692d97678705306f514d5911bf331f784e7a40 Reviewed-on: https://skia-review.googlesource.com/114288 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* add explicit API to know if the writebuffer is using its external storageGravatar Mike Reed2018-03-14
| | | | | | | | | | To help with https://skia-review.googlesource.com/c/skia/+/114262 Bug: skia: Change-Id: I83fcccdec0dbaef28d0e557ea6fb9bd0ed59ed44 Reviewed-on: https://skia-review.googlesource.com/114284 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Improve handling of GrPixelConfig in GrBackendTex/RT ctorsGravatar Greg Daniel2018-03-14
| | | | | | | | | | | | Make sure that no client facing code was relying on what we set as the default value for fConfig by making in kUnkown. Bug: skia: Change-Id: Ie52ff08ba8deeacc16fe06eb0dd0c7292b2edf91 Reviewed-on: https://skia-review.googlesource.com/114261 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Add back missing unique key checks when creating CachedBitmap/Image ProxiesGravatar Greg Daniel2018-03-14
| | | | | | | | | | | Its possible that this could fix perf regression in Chrome. Bug: 811452 Change-Id: I2d4f7827092b361469586580f0c7c843ab2d5cec Reviewed-on: https://skia-review.googlesource.com/114280 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ 690c8eb7f..fccebffe6 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/690c8eb7f2d2..fccebffe63cf $ git log 690c8eb7f..fccebffe6 --date=short --no-merges --format='%ad %ae %s' 2018-03-08 jiawei.shao ES31: Support adjacency draw modes for geometry shader Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: I9a0093c2c4d7012eca0f71901d09adde25211293 Reviewed-on: https://skia-review.googlesource.com/114271 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* exact divide by 255 with NEONGravatar Mike Klein2018-03-14
| | | | | | | Change-Id: Ib121eb0d5af1f22f48f517fe909112a77d92032e Reviewed-on: https://skia-review.googlesource.com/113666 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Cleanup size calculations in SkGlyphGravatar Herb Derby2018-03-14
| | | | | | | | | BUG=skia:7515 Change-Id: Ie9d255a93ecff86ce018f8510332bdb280ec575e Reviewed-on: https://skia-review.googlesource.com/113863 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Update clang_win to yesterday's build (from Chromium).Gravatar Ben Wagner2018-03-13
| | | | | | | Change-Id: Iea0f841f7c9a3449213c549ba310ab2a3d928ca2 Reviewed-on: https://skia-review.googlesource.com/114093 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* [sksg] Use SkTrimPathEffect for path trimmingGravatar Florin Malita2018-03-13
| | | | | | | | | | Refactor TrimEffect using SkTrimPathEffect instead of SkDashPathEffect. TBR= Change-Id: I1415b30b58db28cb74b70fb176307634ab0774e8 Reviewed-on: https://skia-review.googlesource.com/114264 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Roll skia/third_party/externals/angle2/ f0b30dd8b..690c8eb7f (4 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/f0b30dd8bd2b..690c8eb7f2d2 $ git log f0b30dd8b..690c8eb7f --date=short --no-merges --format='%ad %ae %s' 2018-03-12 jmadill Framebuffer: syncState before internal format query. 2018-03-13 jdarpinian Optimize buffer deletion by returning early if buffer is not bound. 2018-03-12 geofflang Update documentation to mention ANGLE committer status and bug editing permissions. 2018-03-13 lucferron run_code_generation.py: Add gen_load_functions_table.py to the list Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: I375d007c288df086e6906415c4d9bfa4516f6263 Reviewed-on: https://skia-review.googlesource.com/114267 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Compile with GCC 7.2.0.Gravatar Ben Wagner2018-03-13
| | | | | | | | | | | | | | This suppresses the noexcept-type warning, since Skia doesn't have a stable ABI in any event. GCC now warns on more printf style formats, so we have to hide our bad test formats a little better. GCC now also warns on implicit enum to bool conversions, which did catch two issues. Change-Id: Ib81769c421757186506873f0fe298ecd0106ae87 Reviewed-on: https://skia-review.googlesource.com/114263 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Harden initial LinearGradient4f tilingGravatar Florin Malita2018-03-13
| | | | | | | | | | | | | | | | | | Even with verified/finite inputs, fx can sometimes collapse to infinity. When that happens, attempting to apply repeat/mirror tiling produces NaN results and things go south. Catch these degenerate cases and tile to 0 (for lack of a better idea). Note: leaving fx == +/- inf in clamp mode should be safe. BUG=oss-fuzz:6622 Change-Id: I65711020057856b47045f67a52d906336ad1f173 Reviewed-on: https://skia-review.googlesource.com/114090 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Add Win Clang x86 builds.Gravatar Ben Wagner2018-03-13
| | | | | | | | | Enable /arch:SSE2 for Win x86 builds (both MSVC and Clang). Change-Id: I0618e938b6542b60fae3947b7e0dcde22650ba54 Reviewed-on: https://skia-review.googlesource.com/56721 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Temporarily remove Win10 QuadroP400 from CQ.Gravatar Ben Wagner2018-03-13
| | | | | | | | | | | | This tryjob is currently just experimental/non-blocking, and we are severely short on capacity due to chromium:821040. Bug: chromium:821040 Change-Id: I36b193cecd4f7ecf4c6f5769e869ee37a1285582 No-Try: true Reviewed-on: https://skia-review.googlesource.com/114221 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* consolidate SaveLayerFlag internal referencesGravatar Cary Clark2018-03-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a third define in SkCanvasPriv to complement SkCanvas::kDontClipToLayer_PrivateSaveLayerFlag and SkCanvas::kDontClipToLayer_Legacy_SaveLayerFlag. SkCanvas::kDontClipToLayer_PrivateSaveLayerFlag exists only to define SkCanvas::kDontClipToLayer_Legacy_SaveLayerFlag and SkCanvasPriv::kDontClipToLayer_SaveLayerFlag. SkCanvas::kDontClipToLayer_Legacy_SaveLayerFlag is used only by Android framework. SkCanvasPriv::kDontClipToLayer_SaveLayerFlag is used internally. Note that changes to CanvasStateTest.cpp inside SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG aren't testable by existing skiabots; it requires building an Android framework aware version of dm. CanvasStateTest.cpp may have bit-rotted. R=reed@google.com,scroggo@google.com Bug: skia:6454,skia:7690 Change-Id: I74f2a54636fae89a5a88a7e13f1baba49d3e2115 Reviewed-on: https://skia-review.googlesource.com/112401 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Increase Android framework bot deadline since we are now building moreGravatar Ravi Mistry2018-03-13
| | | | | | | | | NoTry: true Bug: skia:7716 Change-Id: I230020a28bcb917fc0cb411858f1cce2a42ed62f Reviewed-on: https://skia-review.googlesource.com/114189 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Include correct trace.h.Gravatar Ben Wagner2018-03-13
| | | | | | | | | | | | | SkTraceEventCommon.h currently includes <utils/Trace.h>, but doesn't actually use anything directly from it. In addition, Skia doesn't directly depend on libutils, but instead on libcutils. As a result, replace the <utils/Trace.h> include with <cutils/trace.h> which is what actually provides all the needed macros and declarations. Change-Id: Ic6a7283c71fc94058f735b1b3e541fec3a7db760 Reviewed-on: https://skia-review.googlesource.com/114099 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Fix possible overflows in hair line path renderer vertex countsGravatar Brian Salomon2018-03-13
| | | | | | | | Bug: chromium:820913 Change-Id: I77f9b40cf6173369a4a1b943d71734c305893e09 Reviewed-on: https://skia-review.googlesource.com/114140 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Fixed some shader cache issuesGravatar Ethan Nicholas2018-03-13
| | | | | | | | | | | | We now check GL_NUM_SHADER_BINARY_FORMATS to ensure that it is greater than zero, and handle errors that occur when we try to install a cached shader by falling back to using GLSL. Bug: skia: Change-Id: I1ac46243e9c561d15e1b4190b68afbf514fc8079 Reviewed-on: https://skia-review.googlesource.com/113820 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Remove calls to computeOutputColor- Type and SpaceGravatar Leon Scroggins III2018-03-13
| | | | | | | | | | | | | | Bug: b/70846442 Test: I5110881203c000474116a94a48f2afc9a9b62001 These methods were already called by the client. The client may have further overridden the SkColorType (and therefore the SkColorSpace), so respect their final decision on both. Change-Id: Iddcf618e474784b0a000fd516250c44285dacc6b Reviewed-on: https://skia-review.googlesource.com/114062 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
* Unomit Win Intel Vulkan tests that seem to pass now.Gravatar Ben Wagner2018-03-13
| | | | | | | | | Bug: skia:6398 No-Try: true Change-Id: I34d0d3177260761f241e76a39e279bdfb6c57bad Reviewed-on: https://skia-review.googlesource.com/113668 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* IWYU for some test files starting with 'C'.Gravatar Ben Wagner2018-03-13
| | | | | | | | | Change-Id: Iea274ae52da8b4b87ec55222c856f40a0d88c4e0 Reviewed-on: https://skia-review.googlesource.com/113746 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-on: https://skia-review.googlesource.com/113944 Reviewed-by: Ben Wagner <bungeman@google.com>
* scripts to generate [m]skps, documentationGravatar Hal Canary2018-03-13
| | | | | | | | NoTry: true Change-Id: Ibd5244fa7099cbbe18e5f68e5a28abb52e03127d Reviewed-on: https://skia-review.googlesource.com/114086 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* fix fiddle with blurGravatar Cary Clark2018-03-13
| | | | | | | | | | | Docs-Preview: https://skia.org/?cl=114018 NOTRY=true R=caryclark@google.com Bug: skia:6898 Change-Id: Ied96a0b8479a9b359299ba24ecfa55022046beb0 Reviewed-on: https://skia-review.googlesource.com/114018 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* Add testing-only backend render target support to GrVkGpu.Gravatar Brian Salomon2018-03-13
| | | | | | | | | | | | | Update unit tests to use backend render targets on non-GL contexts Add named DM configs for rendering to Vulkan backend render targets and textures. Make src data ptr param to createTestingOnlyBackendTexture be const. Change-Id: I17f5375ed9bb08422006698956469d3151c4954c Reviewed-on: https://skia-review.googlesource.com/113276 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* avoid divide by zeroGravatar Cary Clark2018-03-13
| | | | | | | | | | R=kjlubick@google.com Bug: skia:7623 Change-Id: Ia9fb31201a39a4540d94f97e8d2f06eb290ab6e5 Reviewed-on: https://skia-review.googlesource.com/114082 Commit-Queue: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Remove use of deprecated MakeFromIRectGravatar Brian Osman2018-03-13
| | | | | | | | Bug: skia: Change-Id: I793456c7a479d160a82bc613cbaf656f85bf6819 Reviewed-on: https://skia-review.googlesource.com/114081 Reviewed-by: Stan Iliev <stani@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* minor style guide updates and editingGravatar Mike Klein2018-03-13
| | | | | | Change-Id: I80b1f810b284b686d80639d7a216a32589336801 Reviewed-on: https://skia-review.googlesource.com/114025 Reviewed-by: Brian Salomon <bsalomon@google.com>
* Roll skia/third_party/externals/angle2/ 64e5ed2ab..f0b30dd8b (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/64e5ed2abd8a..f0b30dd8bd2b $ git log 64e5ed2ab..f0b30dd8b --date=short --no-merges --format='%ad %ae %s' 2018-03-12 lucferron Vulkan: Enable a bunch of dEQP texture related tests 2018-03-02 oetuaho Use non-human-readable mangled names for types Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=stephana@google.com Change-Id: I031a1d6b6708ab732876735e636c55e74fa42384 Reviewed-on: https://skia-review.googlesource.com/114003 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>