aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* remove unused ForceUnique option from makeImageSnapshotGravatar Mike Reed2016-12-29
| | | | | | | | | BUG=skia: Change-Id: I2555ceb86b597f7bb34c8fc48b3e07eb7115ea82 Reviewed-on: https://skia-review.googlesource.com/6481 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Fix typos in the sheriffing documentGravatar Yuqian Li2016-12-29
| | | | | | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=6470 Change-Id: Id80f5bb1a3f0279162b0397fd6822aec83eae322 Reviewed-on: https://skia-review.googlesource.com/6470 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Revert "Add ImageToColorSpace helper in SkImageFilter"Gravatar Brian Osman2016-12-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e02d3caab823728d3106bcb1d4fbb674afc959fb. Reason for revert: New logic triggers out-of-date assert. Reverting until I can fix that, too. Original change's description: > Add ImageToColorSpace helper in SkImageFilter > > Share this logic among a couple filters that need it. This also fixes a > bug that showed up in the morhpology GM for GPU color space configs. > > BUG=skia: > > Change-Id: Ic686b07aff80e58e14a86108703bfbb3cf524979 > Reviewed-on: https://skia-review.googlesource.com/6475 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> > TBR=bsalomon@google.com,robertphillips@google.com,brianosman@google.com,reviews@skia.org BUG=skia: NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I00b444dfaaa9b5981f7b33b34419cf9795b52ddb Reviewed-on: https://skia-review.googlesource.com/6480 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Add ImageToColorSpace helper in SkImageFilterGravatar Brian Osman2016-12-29
| | | | | | | | | | | | Share this logic among a couple filters that need it. This also fixes a bug that showed up in the morhpology GM for GPU color space configs. BUG=skia: Change-Id: Ic686b07aff80e58e14a86108703bfbb3cf524979 Reviewed-on: https://skia-review.googlesource.com/6475 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* update pixel and pixelxl to NMF26QGravatar Kevin Lubick2016-12-28
| | | | | | | | | BUG=skia: Change-Id: I560fc9a7c50187897c9769d4f221d95919558a86 Reviewed-on: https://skia-review.googlesource.com/6476 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add skia_enable_discrete_gpu argument to GNGravatar Brian Osman2016-12-28
| | | | | | | | | | | | This forces all of our testing tools to run with the discrete GPU in laptop systems that have that option. BUG=skia: Change-Id: Ibd7629d6de5f063cdf219b3c7469210af5085d90 Reviewed-on: https://skia-review.googlesource.com/6474 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* Update Nexus 5 to M4B30ZGravatar Kevin Lubick2016-12-28
| | | | | | | | | BUG=skia: Change-Id: I6544be934f3ea84c67e0b0349e2467dd78292647 Reviewed-on: https://skia-review.googlesource.com/6473 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Add color space fallback for matrix convolution filterGravatar Brian Osman2016-12-27
| | | | | | | | | | | | | | | GrMatrixConvolutionFilter is used in two places right now. The GaussianBlur code ensures that we blur in the space of the source image, so no conversion is needed. This changes SkMatrixConvolutionImageFilter to give the same guarantee. BUG=skia: Change-Id: I1a6199d4893f2e579dc6fa809c59cd195bd62f90 Reviewed-on: https://skia-review.googlesource.com/6467 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Modify matrix convolution GM for sRGB testingGravatar Brian Osman2016-12-27
| | | | | | | | | | | | | | | Tag bitmap as sRGB, and adjust gain/bias in color-managed configs to produce results that are less blown out. Also added a colorized version of the GM, to validate that gamut conversion is working. BUG=skia: Change-Id: I333988dcdaa1272121e8aa731b4188c942fe19d8 Reviewed-on: https://skia-review.googlesource.com/6466 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Update SKP versionGravatar UpdateSKPs2016-12-25
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: Ia0a857e5e1c7daa5c12fd9befd15014f1ba40d02 Reviewed-on: https://skia-review.googlesource.com/6421 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Remove legacy matrix definesGravatar Matt Sarett2016-12-22
| | | | | | | | | | BUG=skia: Change-Id: Iaa9e402d687df6f24d94fc58d7edcf9fe47d913d Reviewed-on: https://skia-review.googlesource.com/6460 Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Remove render target unique ID virtual from GrOp.Gravatar Brian Salomon2016-12-22
| | | | | | | | | | | GrRenderTargetOpList now stores the IDs along side each op. This should put us closer to using proxy IDs and not forcing early render target instantiation as many comments point towards. Change-Id: I1ee82b01a0818a80d2bcac39fdf3a4ee7dccecc9 Reviewed-on: https://skia-review.googlesource.com/6403 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Fix iOS buildGravatar Matt Sarett2016-12-22
| | | | | | | | | BUG=skia: Change-Id: I914cd75c84bbe57401ab65352d4e8b3dc413dce1 Reviewed-on: https://skia-review.googlesource.com/6418 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Improve color space support in SkImage::readPixels()Gravatar Matt Sarett2016-12-22
| | | | | | | | | | | | Correct handling of kGray, k565, k4444 etc. is still a TODO. SkImage_Generator and SkImage_Gpu are still TODOs. BUG=skia:6021 Change-Id: Ib53d97d3a866b2b4934fd85c10100855743a8fab Reviewed-on: https://skia-review.googlesource.com/6396 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Change GPU read/write pixels API to support color space conversionGravatar Brian Osman2016-12-22
| | | | | | | | | | | | | GrContext still doesn't convert, but it has the source and destination color spaces, and call sites are supplying appropriate values where it makes sense. BUG=skia: Change-Id: Ia88733125b8090776cfc9b0dc8030cce365b0b8b Reviewed-on: https://skia-review.googlesource.com/6400 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Bot upgrades.Gravatar Ben Wagner2016-12-22
| | | | | | | | | | | | | | Upgrading most Windows bots in the Skolo to version 1607 (build number 14393). Adding IntelIris540 and GTX1070 bot. BUG=skia: Change-Id: Ide7a09a4061d1e387e1d2a22be31b14b13f2fa96 Reviewed-on: https://skia-review.googlesource.com/6357 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Do not support index8 for generateScaledPixelsGravatar Leon Scroggins III2016-12-22
| | | | | | | | | | | | Since the in/out parameter is a const SkPixmap without the proper color table, there is no way to tell the client about it without modifying the const SkPixmap. Rather than cheating, just return false. Change-Id: I63fdf57febc59e1ee9af13aa6eb9b253d19bcb17 Reviewed-on: https://skia-review.googlesource.com/6414 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* remove SK_SUPPORT_LEGACY_PREROLL codeGravatar Mike Reed2016-12-22
| | | | | | | | | BUG=skia: Change-Id: I608a3250882708cefc37747b462d5fa08b1e28be Reviewed-on: https://skia-review.googlesource.com/6349 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Test CLGravatar Ravi Mistry2016-12-22
| | | | | | | | | | NOTRY=true BUG=skia: Change-Id: Ifc020282cfce791db66d90b0173294158b3e16ab Reviewed-on: https://skia-review.googlesource.com/6410 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Revert "Revert "Fix issue in SkDebugCanvas where filter canvas prevents GrOp ↵Gravatar Ravi Mistry2016-12-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bounds from drawing"" This reverts commit 9bcda719e87140dcb541356fdb3f589e145c9b8e. Reason for revert: No idea why the bots failed with the original CL. Putting it back in. Original change's description: > Revert "Fix issue in SkDebugCanvas where filter canvas prevents GrOp bounds from drawing" > > This reverts commit 4bf98e7e802edf43effec93bea22fecb031f65f1. > > Reason for revert: Seems to have caused some compile bots to break- > https://chromium-swarm.appspot.com/task?id=333c47cadb764f10&refresh=10 > > Original change's description: > > Fix issue in SkDebugCanvas where filter canvas prevents GrOp bounds from drawing > > > > Change-Id: I3446bfc42c4cf521916a03aa0f367cd38b4fd370 > > Reviewed-on: https://skia-review.googlesource.com/6401 > > Reviewed-by: Ben Wagner <bungeman@google.com> > > Commit-Queue: Brian Salomon <bsalomon@google.com> > > > > TBR=bsalomon@google.com,bungeman@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I0a73fe8c13967233dec950c317693d13d738722a > Reviewed-on: https://skia-review.googlesource.com/6408 > Commit-Queue: Ravi Mistry <rmistry@google.com> > Reviewed-by: Ravi Mistry <rmistry@google.com> > TBR=bsalomon@google.com,bungeman@google.com,rmistry@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Iad544f883804d13f04640498b4b63f735d33840e Reviewed-on: https://skia-review.googlesource.com/6409 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Revert "Fix issue in SkDebugCanvas where filter canvas prevents GrOp bounds ↵Gravatar Ravi Mistry2016-12-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | from drawing" This reverts commit 4bf98e7e802edf43effec93bea22fecb031f65f1. Reason for revert: Seems to have caused some compile bots to break- https://chromium-swarm.appspot.com/task?id=333c47cadb764f10&refresh=10 Original change's description: > Fix issue in SkDebugCanvas where filter canvas prevents GrOp bounds from drawing > > Change-Id: I3446bfc42c4cf521916a03aa0f367cd38b4fd370 > Reviewed-on: https://skia-review.googlesource.com/6401 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> > TBR=bsalomon@google.com,bungeman@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I0a73fe8c13967233dec950c317693d13d738722a Reviewed-on: https://skia-review.googlesource.com/6408 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Protect glyph sub-pixel placement against NaN and Inf.Gravatar Herb Derby2016-12-21
| | | | | | | | | BUG=chromium:675106 Change-Id: I3f8f2575ca3d1b02615be00d66cf7a123407c5a3 Reviewed-on: https://skia-review.googlesource.com/6404 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Fix issue in SkDebugCanvas where filter canvas prevents GrOp bounds from drawingGravatar Brian Salomon2016-12-21
| | | | | | | Change-Id: I3446bfc42c4cf521916a03aa0f367cd38b4fd370 Reviewed-on: https://skia-review.googlesource.com/6401 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Cleanup GrBicubicEffectGravatar Brian Osman2016-12-21
| | | | | | | | | | | | | | | | | - The base class already stores a color space xform, so just forward our factory argument and use that one. - We had factories that took arbitrary coefficients, but they were only used in the unit test. Make the assumption of Mitchell's coefficients really hard-coded, which lets us skip transposing, storing, comparing, etc... BUG=skia: Change-Id: Ia1d4f72d32c201cba1da24d61b90250f383336d1 Reviewed-on: https://skia-review.googlesource.com/6394 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add color space xform fallback to GrMorphologyEffectGravatar Brian Osman2016-12-21
| | | | | | | | | | | | | | 99% of the time (or maybe 100%?) morphology will trigger pad_image, so the input texture will already be in the destimation color space. If that doesn't happen, then just force the source to be converted, which keeps the morphology effect and driver code simple. BUG=skia: Change-Id: I98876af4f9e9a5da031973213ed76349752ce68f Reviewed-on: https://skia-review.googlesource.com/6388 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Implement scaling in SkCodecImageGeneratorGravatar Leon Scroggins III2016-12-21
| | | | | | | | | | | Plumb calls down to SkCodec. Add a gm Change-Id: I16da24eb739295ab72f487df02f19968151443f3 Reviewed-on: https://skia-review.googlesource.com/6287 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Clean up SkFontHost_Mac ownership.Gravatar bungeman2016-12-21
| | | | | | | | | | | | This clarifies ownership rules throughout SkFontHost_Mac.cpp, as well as tidying up various bits of code. Clarifying ownership means replacing AutoCFRelease with UniqueCFRef which is based on std::unique_ptr. Most of the cleanup is removing now dead code and properly indenting. Change-Id: I6d3a225d62b5d0f2f48a9e70c1a24317faa06747 Reviewed-on: https://skia-review.googlesource.com/6297 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* helper to convert CGImage -> SkImageGravatar Mike Reed2016-12-21
| | | | | | | | | BUG=skia: Change-Id: I07e0b8fe510d34ab541de7572cb6775478527624 Reviewed-on: https://skia-review.googlesource.com/6386 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Rename GrOp::draw to GrOp::executeGravatar Brian Salomon2016-12-21
| | | | | | | Change-Id: I36b8532c57d0b6004a5fd283e30a506df89a4fa6 Reviewed-on: https://skia-review.googlesource.com/6387 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Misc batch->op cleanup Part 2 of 2Gravatar Brian Salomon2016-12-21
| | | | | | | Change-Id: Iedfe5bd019ca1171ab09de569f74c57975aa54c9 Reviewed-on: https://skia-review.googlesource.com/6384 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Misc batch->op cleanup Part 1 of 2Gravatar Brian Salomon2016-12-21
| | | | | | | Change-Id: I80f951976558a284e55386e0a368f08bd835d8ca Reviewed-on: https://skia-review.googlesource.com/6359 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Make SkGIFLZWBlock modifiable so it is assignableGravatar Chris Blume2016-12-21
| | | | | | | | | | | | | std::vector needs to be able to assign objects contained inside it. With const member variables, this isn't possible. Remove the consts so SkGIFLZWBlock can be assigned. BUG=skia:6072 Change-Id: I990dc80fb1c49fbd584712c6d0c1154c2da36e85 Reviewed-on: https://skia-review.googlesource.com/6362 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Remove sk_ref_sp's misleading preprocessor define and commentGravatar Brian Osman2016-12-21
| | | | | | | | | | | | This function will always be useful. Don't make it look/feel like a temporary hack. BUG=skia: Change-Id: I6506d7d51dc3b25a7dbcea4ac273f51cf05f3a89 Reviewed-on: https://skia-review.googlesource.com/6330 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* This renames methods and classes that relate to static analysis of ↵Gravatar Brian Salomon2016-12-21
| | | | | | | | | combinations of GrDrawOps and GrPipelines. Change-Id: I737b901a19d3c67d2ff7f95802fb4df35656beb2 Reviewed-on: https://skia-review.googlesource.com/6199 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* utils/win/SkTScopedComPtr: reset(T*)Gravatar Hal Canary2016-12-21
| | | | | | | | Change-Id: I59a687569e2c7b69cdf65ebc9656c7fbffcc32e0 Motivation: to be used by SkXPS. Reviewed-on: https://skia-review.googlesource.com/6355 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* one more empty contourGravatar Cary Clark2016-12-21
| | | | | | | | | | | | Add one more empty contour check. R=kjlubick@google.com BUG=skia:6073 Change-Id: Ie971875d37388f6bd86a0bdaeaf9230d64aca38d Reviewed-on: https://skia-review.googlesource.com/6356 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* Revert of Generate Signed Distance Field directly from vector path (patchset ↵Gravatar rmistry2016-12-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #23 id:440001 of https://codereview.chromium.org/1643143002/ ) Reason for revert: Caused test failures again but this time in Win8 and Win10 bots: * https://chromium-swarm.appspot.com/task?id=33384540bf6f3710&refresh=10 * https://chromium-swarm.appspot.com/task?id=3338a3ea9f6fe510&refresh=10 Original issue's description: > Generate Signed Distance Field directly from vector path > > Add SkGenerateDistanceFieldFromPath API to generate signed distance field directly from SkPath. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643143002 > > Committed: https://skia.googlesource.com/skia/+/4de97a64e8829323a7070b623411d9f9ddb0cd0f > Committed: https://skia.googlesource.com/skia/+/e8f0a7b986f1e5583c9bc162efcdd92fd6430549 > Committed: https://skia.googlesource.com/skia/+/67c7c81a82b6351e9fbbf235084d7120162d9268 > Review-Url: https://codereview.chromium.org/1643143002 > Committed: https://skia.googlesource.com/skia/+/64b70b096ac20833d9737758a4bd5f2a51078bc4 > Review-Url: https://codereview.chromium.org/1643143002 > Committed: https://skia.googlesource.com/skia/+/6d2f73c364d0d823f14d1ddebc88e0bcbc8f0634 TBR=bsalomon@google.com,jvanverth@google.com,mtklein@google.com,wasim.abbas@arm.com,caryclark@google.com,reed@google.com,egdaniel@google.com,joel.liang@arm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2597473003
* remove MIPS DSP optimizationsGravatar Mike Klein2016-12-21
| | | | | | | | | | | | | | | | | There are only a couple of these, primarily focused on index8 srcs and 565 dsts. The burden's starting to outweigh the benefit. No one on the team knows MIPS assembly. If we're going to try this again, I'd rather we try some sort of SkNx / compiler-intrinsic based approach, probably targeting MIPS SIMD (MSA), not this older instruction set. We already ignore these files for 64-bit MIPS. This just closes the loop on 32-bit MIPS. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD,Build-Ubuntu-Clang-mips64el-Debug-Android,Build-Ubuntu-Clang-mips64el-Release-Android,Build-Ubuntu-Clang-mipsel-Debug-Android,Build-Ubuntu-Clang-mipsel-Release-Android BUG=skia:6065 Change-Id: Iecac15b56f59625b2e743ea36e7791b90bb0b422 Reviewed-on: https://skia-review.googlesource.com/6353 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Generate Signed Distance Field directly from vector pathGravatar joel.liang2016-12-20
| | | | | | | | | | | | | | Add SkGenerateDistanceFieldFromPath API to generate signed distance field directly from SkPath. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643143002 Committed: https://skia.googlesource.com/skia/+/4de97a64e8829323a7070b623411d9f9ddb0cd0f Committed: https://skia.googlesource.com/skia/+/e8f0a7b986f1e5583c9bc162efcdd92fd6430549 Committed: https://skia.googlesource.com/skia/+/67c7c81a82b6351e9fbbf235084d7120162d9268 Review-Url: https://codereview.chromium.org/1643143002 Committed: https://skia.googlesource.com/skia/+/64b70b096ac20833d9737758a4bd5f2a51078bc4 Review-Url: https://codereview.chromium.org/1643143002
* Handle failed surface creation in AlphaThresholdImageFilter GMGravatar Robert Phillips2016-12-21
| | | | | | | Change-Id: Ibc27d26a9afc1f88d5ca7de2216e09afa10ce846 Reviewed-on: https://skia-review.googlesource.com/6354 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Rename batch->op in skiaserveGravatar Brian Salomon2016-12-20
| | | | | | | Change-Id: Ib831b9a6bcf4f37c0f077b26f68b1cefef81bb73 Reviewed-on: https://skia-review.googlesource.com/6351 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove getDevice_just_for_deprecated_compatibility_testing (take 2)Gravatar Robert Phillips2016-12-20
| | | | | | | Change-Id: I516ba4ff1c30bb91563a50c6f2b50f6c01c96f5b Reviewed-on: https://skia-review.googlesource.com/6346 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* xps.gniGravatar Hal Canary2016-12-20
| | | | | | | | | | | | | | | Motivation: Since I am activly refactoring SkXPS, I will be needing to add and subtract sources. This is the only way to keep chrome and skia in sync. TODO(halcanry): follow up in Chrome build files. BUG=skia:3495 Change-Id: I2bfcbfce7628c34f9a623c6fa806374a10cdbb75 Reviewed-on: https://skia-review.googlesource.com/6350 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Rename batch->op in GrAuditTrail.Gravatar Brian Salomon2016-12-20
| | | | | | | Change-Id: I68670e5ceb06716e9928ee58485d63e157c7aca7 Reviewed-on: https://skia-review.googlesource.com/6345 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add color space xform to GrMagnifierEffectGravatar Brian Osman2016-12-20
| | | | | | | | | | | | Tag helper image as sRGB in magnifier image filter GM, so we can see this working. BUG=skia: Change-Id: I8057dc332d09e1d508ad8462aaf0749b307f480f Reviewed-on: https://skia-review.googlesource.com/6347 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Rename files, macros, types, and functions related to GrDrawOp testing.Gravatar Brian Salomon2016-12-20
| | | | | | | | | Make the test factories use sk_sp. Change-Id: Idba630b84deb2848f2203a80fd72e1efa5fc6acf Reviewed-on: https://skia-review.googlesource.com/6342 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove the last "batch tracker" from AAStrokeRectOp.Gravatar Brian Salomon2016-12-20
| | | | | | | | | | | Most of the fields weren't really needed. BUG=skia: Change-Id: If0dbcb707b3a45d044656cbadbe118aa5583be2e Reviewed-on: https://skia-review.googlesource.com/6338 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add color space xform support to GrDisplacementEffectGravatar Brian Osman2016-12-20
| | | | | | | | | BUG=skia: Change-Id: I7508f27d4da6cec7acb801aa389f70c30cb5bfb5 Reviewed-on: https://skia-review.googlesource.com/6340 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add color space xform bits to key for texture domain effectGravatar Brian Osman2016-12-20
| | | | | | | | | | | Overlooked this in a recent CL BUG=skia: Change-Id: I050f8843cc2a8caadc2a46f1ea833b74b47f76b7 Reviewed-on: https://skia-review.googlesource.com/6341 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Fix more Skia filter fuzzer bugsGravatar Robert Phillips2016-12-20
| | | | | | | | | | | | | This CL fixes 3 fuzzer bugs: the rowBytes computation is really unfortunate in ReadRawPixels when width or height is negative In two instances uints were being read through the underlying SkReader32 rather than going through the readUInt virtual In skip SkAlign4 can wrap around and return an answer of 0 for large size_ts!! Change-Id: I657e3afdb4804627604b59abc8008ccdfe47eab2 Reviewed-on: https://skia-review.googlesource.com/6332 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>