aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Convert NonAALatticeOp to non-legacy GrMeshDrawOp.Gravatar Brian Salomon2017-07-11
| | | | | | | | | | Also adds a test factory and fixes a bug in the lattice iter validator where it compared each div value against the start rather than the previous div. Bug: skia: Change-Id: I30e9ddfcbaab7829a2f646ad851f99d1e518ab4a Reviewed-on: https://skia-review.googlesource.com/21871 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Move GrResourceProvider::createMipMappedTexture to ↵Gravatar Robert Phillips2017-07-11
| | | | | | | | | | | | GrSurfaceProxy::MakeDeferredMipMap Although this adds a new method to GrResourceProvider, it is a slight improvement in that it removes some GrProxy stuff from GrResourceProvider (which arguably should only deal in GrSurface-derived classes). Bug: skia: Change-Id: I6d097ed178cd2aa5662770a164135bf2553b80e6 Reviewed-on: https://skia-review.googlesource.com/22023 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* [infra] Golo bots have been upgraded to Ubuntu 17.04Gravatar Eric Boren2017-07-11
| | | | | | | Bug: skia: Change-Id: Ia18c02660b2ab75559400f26ecf610dd610b6540 Reviewed-on: https://skia-review.googlesource.com/22202 Reviewed-by: Ravi Mistry <rmistry@google.com>
* Revert "Always enable Analytic AA for rects"Gravatar Yuqian Li2017-07-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6d70274ccf6e7a3729af53e401d2d9e6726035a3. Reason for revert: need rebaseline Original change's description: > Always enable Analytic AA for rects > > Previously, suitableForAAA disabled Analytic AA for small rects. > But that's a mistake. Re-enabling AAA will bring 10-20% speedup for small rects > (~800ns -> ~700ns measured by path_fill_small_rect nanobench). > > Bug: skia: > Change-Id: I1d8bf4c105d8d116ea441a46e6c955c546bcbb22 > Reviewed-on: https://skia-review.googlesource.com/22074 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=mtklein@chromium.org,herb@google.com,caryclark@google.com,liyuqian@google.com,reed@google.com Change-Id: I87011bf7b8f30fa3be5d46287afbaf38c0be7da9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/22140 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Revert "remove flags for android"Gravatar Mike Reed2017-07-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d8ddf1bbb4a9752d842c4c55a560b9e8947a4463. Reason for revert: going to try moving these flags into android Original change's description: > remove flags for android > > Needs to be coordinated with https://googleplex-android-review.git.corp.google.com/#/c/2518767/ > > > Bug: skia: > Change-Id: If8238119b4a79bec4f816cab43935585728bb601 > Reviewed-on: https://skia-review.googlesource.com/22068 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Mike Reed <reed@google.com> TBR=djsollen@google.com,reed@google.com Change-Id: I2b4965a394d3c5de6556cf620ad1f8e13a79ad51 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/22121 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Remove support for decoding to kIndex_8"Gravatar Leon Scroggins2017-07-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 742a3e298fda669006147e4a305bab8452369b1f. Reason for revert: Breaking Android roll: frameworks/base/core/jni/android/graphics/BitmapFactory.cpp:453:18: error: no member named 'fColorPtr' in 'SkAndroidCodec::AndroidOptions' codecOptions.fColorPtr = colorPtr; ~~~~~~~~~~~~ ^ frameworks/base/core/jni/android/graphics/BitmapFactory.cpp:454:18: error: no member named 'fColorCount' in 'SkAndroidCodec::AndroidOptions' codecOptions.fColorCount = colorCount; ~~~~~~~~~~~~ ^ Original change's description: > Remove support for decoding to kIndex_8 > > Fix up callsites, and remove tests that no longer make sense. > > Bug: skia:6828 > Change-Id: I2548c4b7528b7b1be7412563156f27b52c9d4295 > Reviewed-on: https://skia-review.googlesource.com/21664 > Reviewed-by: Derek Sollenberger <djsollen@google.com> > Commit-Queue: Leon Scroggins <scroggo@google.com> TBR=djsollen@google.com,scroggo@google.com Change-Id: I1bc669441f250690884e75a9a61427fdf75c6907 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:6828 Reviewed-on: https://skia-review.googlesource.com/22120 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Blur gm.Gravatar Herb Derby2017-07-10
| | | | | | | Change-Id: I47294ba47880237541dee8193df55e31b3487f24 Reviewed-on: https://skia-review.googlesource.com/22061 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Correctly stroke zero length segments in multi-contour pathsGravatar Brian Osman2017-07-10
| | | | | | | | Bug: skia: Change-Id: I959287780ef94a258a6746132f3acb9f90e6c6cc Reviewed-on: https://skia-review.googlesource.com/21863 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Always enable Analytic AA for rectsGravatar Yuqian Li2017-07-10
| | | | | | | | | | | | Previously, suitableForAAA disabled Analytic AA for small rects. But that's a mistake. Re-enabling AAA will bring 10-20% speedup for small rects (~800ns -> ~700ns measured by path_fill_small_rect nanobench). Bug: skia: Change-Id: I1d8bf4c105d8d116ea441a46e6c955c546bcbb22 Reviewed-on: https://skia-review.googlesource.com/22074 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Fix Google3 build after https://skia-review.googlesource.com/c/21524/Gravatar Ben Wagner2017-07-10
| | | | | | | | No-Try: true Change-Id: I738c6f79d9ad3af09010e64cee28129e503672a4 Reviewed-on: https://skia-review.googlesource.com/22071 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* remove flags for androidGravatar Mike Reed2017-07-10
| | | | | | | | | | | Needs to be coordinated with https://googleplex-android-review.git.corp.google.com/#/c/2518767/ Bug: skia: Change-Id: If8238119b4a79bec4f816cab43935585728bb601 Reviewed-on: https://skia-review.googlesource.com/22068 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Make SkImage_Lazy::onMakeColorSpace return a SkImage_LazyGravatar Christopher Cameron2017-07-10
| | | | | | | | | | | | | | | | | | | | | | | | | | Make SkImage_Lazy::onMakeColorSpace return a new SkImage_Lazy with the color space of SkImage_Lazy::fInfo changed. Update the call to SkImageGenerator::getPixels to specify image info with this new color space. Update the call to SkImageGenerator::generateTexture to specify this new color space. Update SkPictureImageGenerator to respect the color space argument. Add a SkTransferFunctionBehavior argument to SkImageGenerator::generateTexture to indicate if color conversion is to be doing using an xform canvas. Update Generator_GrYUVProvider::refAsTextureProxy to include a color conversion step to respect this new color space. TBR=reed@google.com Bug:739559 Change-Id: I156a858884659e9dfae739a653bab2ef89274959 Reviewed-on: https://skia-review.googlesource.com/21605 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Christopher Cameron <ccameron@chromium.org> Reviewed-by: Christopher Cameron <ccameron@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Revert "don't compose with (forced) opaque colors"Gravatar Ethan Nicholas2017-07-10
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 81995592d8a941fcf79ba5cee71a37510fa8d6e5. Reason for revert: Various bots reporting "Processor ComposeTwo claimed output for const input doesn't match actual output" Original change's description: > don't compose with (forced) opaque colors > > Bug: skia: > Change-Id: Ic5ea706430b4698e7e937a0cc424ec29b0d8da10 > Reviewed-on: https://skia-review.googlesource.com/22029 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=bsalomon@google.com,brianosman@google.com,reed@google.com Change-Id: Idf0e0db6e2d81dd00fa39c4ea0b3bcd92af8cae0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/22067 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Avoid unneeded SkPictureImageFilter color space transformsGravatar Florin Malita2017-07-10
| | | | | | | Change-Id: Ib5391b4bc315cf709ba6276a79357ce43ee9427e Reviewed-on: https://skia-review.googlesource.com/22062 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Skip GLPrograms test on D3D9 ANGLE to avoid NaN literals bugGravatar Brian Osman2017-07-10
| | | | | | | | Bug: skia:6842 Change-Id: I0bf58f2a00de66cae161561fc87e7adaac651e4f Reviewed-on: https://skia-review.googlesource.com/22064 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Remove unused ctor in GrTextureDomainGravatar Robert Phillips2017-07-10
| | | | | | | Change-Id: I82b4add39f87133157f94745902df0b3a1a23680 Reviewed-on: https://skia-review.googlesource.com/22063 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* ICC: SkICCGetColorProfileTag supports special casesGravatar Hal Canary2017-07-10
| | | | | | | | | | | | | | | | | | | | | | | | Special cases: - "sRGB" - "AdobeRGB" - "DCI-P3" - "Linear Transfer with sRGB Gamut" - "2.2 Transfer with sRGB Gamut" - "sRGB Transfer with DCI-P3 Gamut" - "Linear Transfer with DCI-P3 Gamut" - "sRGB Transfer with Rec-BT-2020 Gamut" - "Linear Transfer with Rec-BT-2020 Gamut" tools/colorspaceinfo now prints out the Tag. Also: constants representing gSRGB_TransferFn, g2Dot2_TransferFn, and gLinear_TransferFn, gDCIP3_TransferFn. BUG=skia:6720 Change-Id: I92a3f9db9d744d3ec366e4e59afd759ba043c235 Reviewed-on: https://skia-review.googlesource.com/20225 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Remove support for decoding to kIndex_8Gravatar Leon Scroggins III2017-07-10
| | | | | | | | | | Fix up callsites, and remove tests that no longer make sense. Bug: skia:6828 Change-Id: I2548c4b7528b7b1be7412563156f27b52c9d4295 Reviewed-on: https://skia-review.googlesource.com/21664 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Fixes for get_images_from_skpsGravatar Leon Scroggins III2017-07-10
| | | | | | | | | | | | | | | | Do not consider kErrorInInput a failure. This probably means a corrupted image stored in the SKP. This will fix the buildbot. In addition, fix some other problems: - Return an error when no SkPicture is created, rather than crashing. - Use a different name for failed decodes, so they don't get overwritten by future failed or successful decodes. Bug: skia:6840 Change-Id: Ia1d04e145a58495fb955d4b07dbb260cb7a35809 Reviewed-on: https://skia-review.googlesource.com/22031 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* [Reland] More SkColorSpaceXformer cachingGravatar Florin Malita2017-07-10
| | | | | | | | | | | | * apply(SkColorFilter*) * apply(SkImage*) Also add purge logic to minimize caching scope. Change-Id: I295d20f760f8be0c3746858d6f9c73e351f10a36 Reviewed-on: https://skia-review.googlesource.com/22030 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* don't compose with (forced) opaque colorsGravatar Mike Reed2017-07-10
| | | | | | | | Bug: skia: Change-Id: Ic5ea706430b4698e7e937a0cc424ec29b0d8da10 Reviewed-on: https://skia-review.googlesource.com/22029 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Make TessellatingPathOp be a non-legacy GrMeshDrawOp"Gravatar Ethan Nicholas2017-07-10
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 086ce11386849c445a99c7bb8c43947f54618a75. Reason for revert: Looks to be upsetting the bots (grglgpu.cpp(2766): fatal error: "assert(!useHWAA || rt->isStencilBufferMultisampled())") Original change's description: > Make TessellatingPathOp be a non-legacy GrMeshDrawOp > > Change-Id: Ic92fdca7bdca91eab3a87e4fea3972ffdcfd5b12 > Reviewed-on: https://skia-review.googlesource.com/21867 > Reviewed-by: Jim Van Verth <jvanverth@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=jvanverth@google.com,bsalomon@google.com Change-Id: Ibb0c8f8f4e2dea018b54686ab780535e2f69539a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/22060 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Remove dependency on recipe_engine/shutil.Gravatar Robert Iannucci2017-07-10
| | | | | | | | | | R=borenet@google.com Bug: chromium:739984 Change-Id: I077c4e6f494eb7e93851201120048ba1ef5faa07 Reviewed-on: https://skia-review.googlesource.com/21921 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Revert "converted GrCircleBlurFragmentProcessor to sksl"Gravatar Ethan Nicholas2017-07-10
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9b80ffc77b8000b493eb1226dc6ec21f1e99edfc. Reason for revert: breaking ANGLE and Android Vulkan GMs Original change's description: > converted GrCircleBlurFragmentProcessor to sksl > > Bug: skia: > Change-Id: I1b70ba2003c9e9de2b5b9acadaf25c9ed59b1198 > Reviewed-on: https://skia-review.googlesource.com/21727 > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,ethannicholas@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: Ia313013b4354b34fa5a02bdb16d007a462c5ca94 Reviewed-on: https://skia-review.googlesource.com/22028 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Make TessellatingPathOp be a non-legacy GrMeshDrawOpGravatar Brian Salomon2017-07-10
| | | | | | | Change-Id: Ic92fdca7bdca91eab3a87e4fea3972ffdcfd5b12 Reviewed-on: https://skia-review.googlesource.com/21867 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Remove Rietveld stuff from cq.cfgGravatar Eric Boren2017-07-10
| | | | | | | Bug: skia: Change-Id: I7e6b80dde2b90c439b29c6946bdec06543a1ec13 Reviewed-on: https://skia-review.googlesource.com/22022 Reviewed-by: Ravi Mistry <rmistry@google.com>
* Add missing checks for geometry shader stages in GrVkUtil.cppGravatar Chris Dalton2017-07-09
| | | | | | | | Bug: skia: Change-Id: I30cb6d5ee5016536537c48346c58ef4cf19f16c5 Reviewed-on: https://skia-review.googlesource.com/21845 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Revert "More SkColorSpaceXformer caching"Gravatar Florin Malita2017-07-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8d1fc16ba6161afc1174e29e30bae4fc9939264f. Reason for revert: looks like it broke a couple of Chrome unit tests - https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/26292 Original change's description: > More SkColorSpaceXformer caching > > * apply(SkColorFilter*) > * apply(SkImage*) > > Change-Id: I9b55632edd73dbbc5edb8b5ca9bb5bead1131260 > Reviewed-on: https://skia-review.googlesource.com/21736 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> TBR=mtklein@google.com,herb@google.com,fmalita@chromium.org,reed@google.com Change-Id: I86bc61fca370796125b66419ad89bfe3610b996f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/21980 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* More SkColorSpaceXformer cachingGravatar Florin Malita2017-07-08
| | | | | | | | | | * apply(SkColorFilter*) * apply(SkImage*) Change-Id: I9b55632edd73dbbc5edb8b5ca9bb5bead1131260 Reviewed-on: https://skia-review.googlesource.com/21736 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Add mock config to tools and run through gms and benchs without crashing.Gravatar Brian Salomon2017-07-07
| | | | | | | Change-Id: I7e2474129ef2b15899ad2baeb8d18f39d05da98c Reviewed-on: https://skia-review.googlesource.com/21820 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Make AAHairlineOp a non-legacy GrDrawMeshOpGravatar Brian Salomon2017-07-07
| | | | | | | Change-Id: I814c696e38c685a294f9696984612807bc94b43d Reviewed-on: https://skia-review.googlesource.com/21862 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* converted GrCircleBlurFragmentProcessor to skslGravatar Ethan Nicholas2017-07-07
| | | | | | | | Bug: skia: Change-Id: I1b70ba2003c9e9de2b5b9acadaf25c9ed59b1198 Reviewed-on: https://skia-review.googlesource.com/21727 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add infra OWNERSGravatar Eric Boren2017-07-07
| | | | | | | | | | | Recipe rollers can't find any reviewers for CLs. Bug: skia: Change-Id: I6222d4250f8f012dc1a145d1721f9f274a52f2a8 Reviewed-on: https://skia-review.googlesource.com/21866 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Robbie Iannucci <iannucci@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Add SK_API to GrBackendTexture and GrBackendRenderTargetGravatar Brian Salomon2017-07-07
| | | | | | | Change-Id: Ibae248bf8e2d2da860e99b62346e737da55a85b5 Reviewed-on: https://skia-review.googlesource.com/21827 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Tweak GLPrograms random seed to "fix" ANGLE botsGravatar Brian Osman2017-07-07
| | | | | | | | | | | See anglebug.com/2098 No-Tree-Checks: true Change-Id: I793459f57a75ccefc7f071ef506e9d128c5abbe4 Reviewed-on: https://skia-review.googlesource.com/21860 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* add guard for android (needs rebaseline)Gravatar Mike Reed2017-07-07
| | | | | | | | | | android.graphics.drawable.cts.BitmapDrawableTest.testPreloadDensity(BitmapDrawableTest.java:556) Bug: skia: Change-Id: Ibc6b67c6ec82f578ffffd7461e2505713c704b8d Reviewed-on: https://skia-review.googlesource.com/21824 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Plumb through need for unpremul/premulGravatar Mike Reed2017-07-07
| | | | | | | | | | Update unittest to build test image with legal premul pixels. Bug: skia: Change-Id: Iebd1d2f81cac77f8913bd79f6ac25983ed710641 Reviewed-on: https://skia-review.googlesource.com/21735 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Indicate texel buffer support in VulkanGravatar Chris Dalton2017-07-06
| | | | | | | | | | Also adds support for static texel buffer access patterns. Bug: skia: Change-Id: Iadf1b82adbc5f84960841b7526e16d1aa77de621 Reviewed-on: https://skia-review.googlesource.com/21705 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Revert "Revert "Make mock GrContext unit testable.""Gravatar Brian Salomon2017-07-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c867a89b012c07e7e5cb719a31ed90e61f4a4901. Reason for revert: test Original change's description: > Revert "Make mock GrContext unit testable." > > This reverts commit 993e7e25217df05d63c3354c817e8bd18ea3738b. > > Reason for revert: Seeing if this fixes the NexusPlayer bots > > Original change's description: > > Make mock GrContext unit testable. > > > > Bug: skia: > > Change-Id: I959122f1f2c390832ab1033bcdbdd2ca6cfc0419 > > Reviewed-on: https://skia-review.googlesource.com/20699 > > Reviewed-by: Greg Daniel <egdaniel@google.com> > > Commit-Queue: Brian Salomon <bsalomon@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com > > Change-Id: I25ed9329962d930fe38108f779ff7083e0e4847e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/21731 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=egdaniel@google.com,bsalomon@google.com Change-Id: I62c579e087db1ff9891cf6c41b3eb40f47561887 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/21733 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Temporarily stop uploading to partner bucket in RecreateSKPs bot"Gravatar Ravi Mistry2017-07-06
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6945c946ea800b7bff31920914a990c88a706718. Reason for revert: Should be able to upload to partner bucket now Original change's description: > Temporarily stop uploading to partner bucket in RecreateSKPs bot > > Bug: skia:6797 > Change-Id: I812837d02b90b78b6df3980649ccf6362e939afc > Reviewed-on: https://skia-review.googlesource.com/20820 > Commit-Queue: Ravi Mistry <rmistry@google.com> > Reviewed-by: Eric Boren <borenet@google.com> TBR=borenet@google.com,rmistry@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia:6797 Change-Id: I145275da0050da01fca3e6e9c3c5efd84bdadea1 Reviewed-on: https://skia-review.googlesource.com/21738 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Potentially fix definition of GR_TEST_UTILS in gn_to_bp.pyGravatar Brian Salomon2017-07-06
| | | | | | | | | TBR=scroggo@google.com Change-Id: I0afe43855e7ac55a0f6a9b88af16a1d7b36666a2 Reviewed-on: https://skia-review.googlesource.com/21737 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add proper aliased support for SDF textGravatar Jim Van Verth2017-07-06
| | | | | | | | | | | | | Previously, when asked to render aliased text with distance fields, we would get the aliased glyph from the cache and then try to anti-alias the edge. This change instead grabs the anti-aliased glyph, then deliberately aliases the edge. Bug: chromium:707979 Change-Id: I05766af17d7ae58bca27aaffd9e08e5c586e789c Reviewed-on: https://skia-review.googlesource.com/21728 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Minor SkColorSpaceXformer cleanupGravatar Florin Malita2017-07-06
| | | | | | | | | Instead of plugging private fields from the factory, pass to ctor. Change-Id: Iea186e394182bddb6a569de1a05f2e40d6815c80 Reviewed-on: https://skia-review.googlesource.com/21734 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Fix missing height check found by /analyzeGravatar Bruce Dawson2017-07-06
| | | | | | | | | | | | | | | | | | | | | A recent run of the experimental VC++ /analyze builder gave this warning: skia\src\gpu\gl\grglgpu.cpp(851) : warning C6287: Redundant code: the left and right sub-expressions are identical. The code it complained about was this: if (width < 0 || width < 0) { which was introduced in https://skia-review.googlesource.com/c/20445/ This change makes the obvious fix. Change-Id: I9d1743293fac9dd15ed82cf85efef907d727921e Reviewed-on: https://skia-review.googlesource.com/21620 Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Bruce Dawson <brucedawson@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Add an SkColorSpaceXformer image filter cacheGravatar Florin Malita2017-07-06
| | | | | | | | | | | | The cache is scoped with the SkColorSpaceXformer object. This ensures we're not transforming nodes with a degree > 1 multiple times, and preserves the DAG topology. Change-Id: I0b072cdac95f9f1c34e0565ed4f258aba986e1ae Reviewed-on: https://skia-review.googlesource.com/21726 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Attempt to fix Android framework buildGravatar Brian Salomon2017-07-06
| | | | | | | | Bug: skia: Change-Id: I70004f5edc47d6de4e2bdb33d40467c9a6f81b48 Reviewed-on: https://skia-review.googlesource.com/21729 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Make mock GrContext unit testable."Gravatar Brian Salomon2017-07-06
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 993e7e25217df05d63c3354c817e8bd18ea3738b. Reason for revert: Seeing if this fixes the NexusPlayer bots Original change's description: > Make mock GrContext unit testable. > > Bug: skia: > Change-Id: I959122f1f2c390832ab1033bcdbdd2ca6cfc0419 > Reviewed-on: https://skia-review.googlesource.com/20699 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=egdaniel@google.com,bsalomon@google.com Change-Id: I25ed9329962d930fe38108f779ff7083e0e4847e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/21731 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* guard legacy bilerp-ignorning hackGravatar Mike Reed2017-07-06
| | | | | | | | Bug: skia:6835 Change-Id: I7f3136595299f9193bc9173a03b782888043aeb5 Reviewed-on: https://skia-review.googlesource.com/21722 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Unfriend SkImageFilter subclassesGravatar Florin Malita2017-07-06
| | | | | | | | | | Subclasses should call SkColorSpaceXformer::apply methods, not makeColorSpace(). Change-Id: I64732641b90dd3f82e331adfd36f2c60dcf996b2 Reviewed-on: https://skia-review.googlesource.com/21724 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* add stages for black and white colorsGravatar Mike Reed2017-07-06
| | | | | | | | | | | | | | histogram of test skps: black: 1/7 white: 2/7 other: 4/7 Bug: skia: Change-Id: I3a092899d31ce87837e66e5c8ea9ec5e0f239361 Reviewed-on: https://skia-review.googlesource.com/21408 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-05 08:49:38 +0000