aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Fix for GM:bigblurs not actually blurring some of the rectangles on Nexus 10.Gravatar ethannicholas2015-10-19
| | | | | | BUG=skia:2860 Review URL: https://codereview.chromium.org/1395693011
* Misc: Don't run etc1 bench with invalid image and fix VS2015 build warningGravatar bsalomon2015-10-19
| | | | Review URL: https://codereview.chromium.org/1409993003
* change SkImage_Gpu to handle all filters (w/ and w/o gpu supportGravatar reed2015-10-19
| | | | | | | | | | The result is that the set of "generic" imagefilters (e.g. SkColorFilterImageFilter) that use drawing commands to return their results will now stay in the same domain as their src (i.e. gpu-src --> gpu-dst). ApplyFilterGM exercises this, and now asserts this same-domain invariant. BUG=skia:4467 Review URL: https://codereview.chromium.org/1401053003
* Rewrite GrTextureMaker to disentangle bitmap case from base class and give ↵Gravatar bsalomon2015-10-19
| | | | | | | | GPU object a say in what copying needs to be done. Committed: https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79 Review URL: https://codereview.chromium.org/1409163002
* Remove unused member variables in GrGLProgramGravatar egdaniel2015-10-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1416523003
* Add imgblur tool to assist BlurMaskFilter debuggingGravatar robertphillips2015-10-19
| | | | | | | | imgblur is intended to establish a ground truth for debugging mask blur issues. It performs a brute force (non-separable) Gaussian blur of the provided image. The blur code itself is in sk_tools_utils so it can be more easily used programmatically in other places (e.g., blur unit tests). Review URL: https://codereview.chromium.org/1384203002
* skia: Make the validate match interface for *_draw_instancedGravatar hendrikw2015-10-19
| | | | | | | | | | | | | | | | | | | | | | | | | For whatever reason, on the Mac, the command buffer is reporting ARB_draw_instanced as a valid extension. This is probably a bug in the command buffer and I'll look into this later. In Skia, we don't check for ARB_draw_instanced in GLES2 when building the interface, but during the validate, we do, so we ended up failing the validation. Looking a bit further at the specs, ARB_draw_instanced is GL only, whereas EXT_draw_instanced is both GL and GLES. I've updated the code to reflect this. See: https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/specs/ARB/draw_instanced.txt https://www.opengl.org/registry/specs/EXT/draw_instanced.txt Everything above also applies to ARB/EXT_instanced_arrays https://www.khronos.org/registry/gles/extensions/EXT/EXT_instanced_arrays.txt https://www.opengl.org/registry/specs/ARB/instanced_arrays.txt Review URL: https://codereview.chromium.org/1409053003
* SkRemote: impl drawRRectGravatar halcanary2015-10-18
| | | | Review URL: https://codereview.chromium.org/1412013002
* Update SKP versionGravatar update-skps2015-10-18
| | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS Review URL: https://codereview.chromium.org/1410283002
* SkRemote: simple impl of onDraw*Text*Gravatar halcanary2015-10-17
| | | | Review URL: https://codereview.chromium.org/1409273004
* SkRemote: impl onDrawDRRectGravatar halcanary2015-10-17
| | | | Review URL: https://codereview.chromium.org/1410223002
* Test SkRemote on GCE bots.Gravatar mtklein2015-10-17
| | | | | | | | | This will get us gathering GM images. I will set up ignores on gold.skia.org so no one's bothered. BUG=skia: Review URL: https://codereview.chromium.org/1414563002
* Remove DrawingMgr shims from GrContextGravatar robertphillips2015-10-17
| | | | | | BUG=skia:4094 Review URL: https://codereview.chromium.org/1413673002
* SkRemote: impl drawPaint()Gravatar halcanary2015-10-17
| | | | Review URL: https://codereview.chromium.org/1409253003
* LookupScope does not need to be in SkRemote.hGravatar mtklein2015-10-16
| | | | | | | | | It's only used by Cache and Client. This moves it to SkRemote.cpp, where they live. BUG=skia: Review URL: https://codereview.chromium.org/1409273002
* Suppression for valgrind bugGravatar scroggo2015-10-16
| | | | | | | | | | | TBR=msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4478 Review URL: https://codereview.chromium.org/1410953002
* Revert of Rewrite GrTextureMaker to disentangle bitmap case from base class ↵Gravatar egdaniel2015-10-16
| | | | | | | | | | | | | | | | | | | and give GPU object a say in what… (patchset #4 id:60001 of https://codereview.chromium.org/1409163002/ ) Reason for revert: breaking nanobench Original issue's description: > Rewrite GrTextureMaker to disentangle bitmap case from base class and give GPU object a say in what copying needs to be done. > > Committed: https://skia.googlesource.com/skia/+/fcffaf22d697f06f903c3193308f9dc54a959f79 TBR=reed@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1409923003
* Rewrite GrTextureMaker to disentangle bitmap case from base class and give ↵Gravatar bsalomon2015-10-16
| | | | | | GPU object a say in what copying needs to be done. Review URL: https://codereview.chromium.org/1409163002
* Move some code around to make another diff cleanerGravatar bsalomon2015-10-16
| | | | | | TBR=reed@google.com Review URL: https://codereview.chromium.org/1403293004
* Add docs on how to install iOS test toolsGravatar stephana2015-10-16
| | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1413653002 Review URL: https://codereview.chromium.org/1413653002
* Image filters: refactor input GPU processing into filterInputGPU().Gravatar senorblanco2015-10-16
| | | | | | | | | | (analog of CPU version here: https://codereview.chromium.org/1404743005/) No change in behaviour; this is a straight refactoring. BUG=skia:3194 Review URL: https://codereview.chromium.org/1393283008
* Fix SkSwizzler bugGravatar msarett2015-10-16
| | | | | | | | | | | | | | | Now, that we are subsetting, fX0 is not necessarily less than fSrcWidth (since fSrcWidth is really the subset width). Ex: We may want a 10 pixel subset starting twenty pixels from the left edge. In that case, fX0=20 and fSrcWidth=10. Let's rename the width as fSubsetWidth to avoid confusion and remove the check. BUG=skia: Review URL: https://codereview.chromium.org/1407603003
* SkRemoteGravatar mtklein2015-10-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1391023005
* Loosen requirement that there be only one GrDrawTargetGravatar robertphillips2015-10-16
| | | | | | BUG=skia:4094 Review URL: https://codereview.chromium.org/1406173003
* Enabling clip stack flattening exercises path ops.Gravatar caryclark2015-10-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Iterating through the 903K skps that represent the imagable 1M top web pages triggers a number of bugs, some of which are addressed here. Some web pages trigger intersecting cubic representations of arc with their conic counterparts. This exposed a flaw in coincident detection that caused an infinite loop. The loop alternatively extended the coincident section and, determining the that the bounds of the curve pairs did not overlap, deleted the extension. Track the number of times the coincident detection is called, and if it exceeds an empirically found limit, assume that the curves are coincident and force it to be so. The loop count limit can be determined by enabling DEBUG_T_SECT_LOOP_COUNT and running all tests. The largest count is reported on completion. Another class of bugs was caused by concident detection duplicating nearly identical points that had been merged earlier. To track these bugs, the 'handle coincidence' code was duplicated as a const debug variety that reported if one of a dozen or so irregularities are present; then it is easier to see when a block of code that fixes one irregularity regresses another. Creating the debug const code version exposed some non-debug code that could be const, and some that was experimental and could be removed. Set DEBUG_COINCIDENCE to track coincidence health and handling. For running on Chrome, DEBUG_VERIFY checks the result of pathops against the same operation using SkRegion to verify that the results are nearly the same. When visualizing the pathops work using tools/pathops_visualizer.htm, set DEBUG_DUMP_ALIGNMENT to see the curves after they've been aligned for coincidence. Other bugs fixed include detecting when a section of a pair of curves have devolved into lines and are coincident. TBR=reed@google.com Review URL: https://codereview.chromium.org/1394503003
* Remove check for whole image in the cache in SkGpuDevice::shouldTileImageGravatar bsalomon2015-10-16
| | | | | | This was never that well justified. Review URL: https://codereview.chromium.org/1405383002
* Remove SkDEPRECATED_InstallDiscardablePixelRef from SkPictureShaderGravatar fmalita2015-10-16
| | | | | | | | Use an SkImage generator/shader instead. R=reed@google.com Review URL: https://codereview.chromium.org/1405103003
* Clean up iOS build filesGravatar jvanverth2015-10-15
| | | | Review URL: https://codereview.chromium.org/1409663002
* Supply separate flags for onBuildTileIndexGravatar msarett2015-10-15
| | | | | | | | | | | | | | | | | | | | | | This is a follow up to: https://codereview.chromium.org/1401283003/ Supply separate flags for onBuildTileIndex Since png and jpeg's implementations of onBuildTileIndex rely on modifications to their underlying libraries, rather than whether we are running on Android, use separate flags that can be disabled independently. This will allow us to easily turn off the feature. It also is a step towards building and running on other platforms for testing (e.g. valgrind/ASAN to find memory leaks etc). BUG=skia: Committed: https://skia.googlesource.com/skia/+/fc06e9c0e621744654e231ae6fa4460d88c0e27e Review URL: https://codereview.chromium.org/1402783008
* SkTHash: hash from fnptr to functor typeGravatar mtklein2015-10-15
| | | | | | | | Passing &SkGoodHash to SkTHashMap and SkTHashSet doesn't guarantee that it's actually instantiated. Using a functor does. BUG=skia: Review URL: https://codereview.chromium.org/1405053002
* Image Filters: refactor all CPU input processing into a filterInput helper ↵Gravatar senorblanco2015-10-15
| | | | | | | | | | function. No change in behaviour; this is a straight refactoring. BUG=skia:3194 Review URL: https://codereview.chromium.org/1404743005
* Remove params from Cacherator_GrTextureMakerGravatar bsalomon2015-10-15
| | | | Review URL: https://codereview.chromium.org/1403313003
* Move an #include out of a namespace.Gravatar thakis2015-10-15
| | | | | | | | | | This is required to build Chromium's ui_base target with -fmodules, but it seems like a good change regardless. Including a header in a namespace is weird. BUG=chromium:543704 Review URL: https://codereview.chromium.org/1398843007
* Update iOS docsGravatar jvanverth2015-10-15
| | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1399533005 Review URL: https://codereview.chromium.org/1399533005
* Add NVPR to VisualBenchGravatar joshualitt2015-10-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1409603004
* Fix -Winconsistent-missing-override in SkCodec_libgif.hGravatar mtklein2015-10-15
| | | | | | | | | | | Follow up to https://codereview.chromium.org/1400343005 This warning only triggers on a few configs, like the coverage bot. TBR=msarett@google.com BUG=skia: Review URL: https://codereview.chromium.org/1407833002
* Add dm target to BUILD and refactor BUILD file. The corresponding google3 ↵Gravatar benjaminwagner2015-10-15
| | | | | | | | | | | | BUILD file changes are in google3 cl/105413829. Fix blaze compilation errors. The default compilation options for blaze require that the initialization list must list fields in initialization order. Also deal with differing versions of libjpeg. The BUILD changes were started by melanielc in google3 cl/102860957. BUG=skia: Review URL: https://codereview.chromium.org/1401883005
* GrDrawContext now holds GrRenderTarget pointerGravatar robertphillips2015-10-15
| | | | Review URL: https://codereview.chromium.org/1404823005
* Renable image benchmarkingGravatar scroggo2015-10-15
| | | | | | | | | | | | | | | - Remove --images '' to renable image benchmarking - Add a flag to disable testing JPEG's buildTileIndex, since it also leaks memory - Do not run images on GPU - Do not run large interlaced images on 32 bit bots - When buildTileIndex is not being used in the subset benches, do not use it for BRD BUG=skia:3418 BUG=skia:4469 BUG=skia:4471 BUG=skia:4360 Review URL: https://codereview.chromium.org/1396113002
* small tidy of benchmarkstreamGravatar joshualitt2015-10-15
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/691b6af907e55250a29a7a2a346b63c2026011c3 Review URL: https://codereview.chromium.org/1395703002
* Reenable warnings in src/codecGravatar msarett2015-10-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1400343005
* Add a comment to explain clip intersection in crop rects.Gravatar senorblanco2015-10-15
| | | | | | | BUG=skia: R=robertphillips Review URL: https://codereview.chromium.org/1401973003
* Fix floating point data loss in SkPictureShaderGravatar ericrk2015-10-14
| | | | | | | | | | SkPictureShader had an invalid use of SkMax32 on two SkScalars which ended up converting the result to an integer which caused us to lose necessary floating point data. BUG=473166 Review URL: https://codereview.chromium.org/1401743004
* Revert of Supply separate flags for onBuildTileIndex (patchset #1 id:1 of ↵Gravatar msarett2015-10-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1402783008/ ) Reason for revert: Missing an important line. Original issue's description: > Supply separate flags for onBuildTileIndex > > This is a follow up to: > https://codereview.chromium.org/1401283003/ > > Supply separate flags for onBuildTileIndex > > Since png and jpeg's implementations of onBuildTileIndex rely on > modifications to their underlying libraries, rather than whether we are > running on Android, use separate flags that can be disabled > independently. > > This will allow us to easily turn off the feature. It also is a step > towards building and running on other platforms for testing (e.g. > valgrind/ASAN to find memory leaks etc). > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/fc06e9c0e621744654e231ae6fa4460d88c0e27e TBR=scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1394433005
* Don't abort analytic clipping if using MSAA until elements are examinedGravatar bsalomon2015-10-14
| | | | | | TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/1399223005
* Revert of small tidy of benchmarkstream (patchset #2 id:20001 of ↵Gravatar joshualitt2015-10-14
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1395703002/ ) Reason for revert: Breaks visualbench Original issue's description: > small tidy of benchmarkstream > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/691b6af907e55250a29a7a2a346b63c2026011c3 TBR=robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1392833006
* Supply separate flags for onBuildTileIndexGravatar msarett2015-10-14
| | | | | | | | | | | | | | | | | | | | This is a follow up to: https://codereview.chromium.org/1401283003/ Supply separate flags for onBuildTileIndex Since png and jpeg's implementations of onBuildTileIndex rely on modifications to their underlying libraries, rather than whether we are running on Android, use separate flags that can be disabled independently. This will allow us to easily turn off the feature. It also is a step towards building and running on other platforms for testing (e.g. valgrind/ASAN to find memory leaks etc). BUG=skia: Review URL: https://codereview.chromium.org/1402783008
* Store texture target on GrGLTexture. This is in preparation for using ↵Gravatar bsalomon2015-10-14
| | | | | | texture targets other than 2D. Review URL: https://codereview.chromium.org/1403123002
* Remove unnecessary allocation in nanobenchGravatar scroggo2015-10-14
| | | | Review URL: https://codereview.chromium.org/1408593002
* Fix clipping when all analytic FP creations can be skippedGravatar bsalomon2015-10-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1400343004
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-08 02:01:11 +0000