aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* fix conic gm to have fixed wrappingGravatar reed2014-12-31
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/815143003
* change API contract: disallow zero-sized images or surfacesGravatar reed2014-12-31
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/830033003
* Rebaseline complexclip2_rect_aa & simpleaaclip_rect GMs for the S4Gravatar robertphillips2014-12-31
| | | | | | | | I believe these are left over from https://codereview.chromium.org/822483003/ (rebase) TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/828973002
* Rebaseline lagging K1 GMsGravatar robertphillips2014-12-31
| | | | | | | | The Nexus9 took a break from 12/20/14 until 12/30/14. This updates the GMs for all the changes during that time. Except for the changes due to https://codereview.chromium.org/834503002/ (Update stroke path to use rect returned from isRect (to fix trailing moveTo bug)), in which a GM was changed, they are all imperceptible. TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/831953002
* Rebaselines after "Fix computation of bound in FillBounds::updateSaveBounds"Gravatar robertphillips2014-12-31
| | | | | | | | The CL in question impacted the size of the hoisted layers and thus impacted the image results for the MPD GMs (for the GPU configs). TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/827423003
* ignore failure -- pdf gradients on mac-miniGravatar reed2014-12-31
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/810653004
* rebaseline after GM changeGravatar reed2014-12-31
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/794833003
* Update SKP versionGravatar skia.buildbots2014-12-30
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/805813006
* debugger: Make draw command image widget resizeGravatar kkinnunen2014-12-30
| | | | | | | | | | | | | | | | | | | | | | | | | | Make draw command image widget resize. The widget was not resizing, effectively preventing the window from being resized smaller. Make the rasterized draw command image be proportional to the widget size. The draw rasterization canvas is still an equilateral rectangle with dimensions of the smaller side of the widget. Makes the widget re-rasterize the image only when the draw command changes, not for each widget paint. Renames the widget from "image widget" to "draw command geometry widget". Makes the background of the image black, similar to the raster widget background. Adds a tooltip saying "Command geometry" for the widget, so that user might understand what the contents should be. This commit is part of work that tries to make the debugger window to be a bit more resizeable, so that it would fit 1900x1200 screen. Review URL: https://codereview.chromium.org/787143004
* debugger: Make settings widget resizeableGravatar kkinnunen2014-12-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The settings widget was laid out by hand, eg. the widths of most elements were hardcoded. This prevented it from being laid out by the Qt widget system. This in turn prevents the widget from shrinking to its optimal size. This in turn causes cascading effect where the geometry of many of the UI widgets has to be hard-coded. This in turn prevents proper resizing of the UI. Make Qt layout the settings widget by following changes: a) Group settings in QGroupBox groups instead of hand-written layouts and labels hardcoded in certain places. b) Remove "Expanding" size policy from settings widget. The widget calculates its own size based on the widgets inside. Thus "Preferred" is the correct policy to use, as expanding the widget will not bring any new content visible. c) Remove maximum width 250 from Settings widget d) Make "canvas settings and image layout", eg. the horizontal layout holding the settings widget divide the space between the picture and settings like so: settings uses up only as much as it needs (stretch factor 0), while picture uses up everything else (stretch factor 1). In order to do a) reasonably, reorganize the UI and the code a bit: a1) Rename settings group "visual filter" to "Visualizations". a2) Make "visual filter: on/off" combo box a checkbox in "Visualizations". a3) Move "Mega viz" setting checkbox from "raster" (or "render targets") section to "Visualizations" a4) Move "PathOps" setting checkbox from "raster" to "Visualizations" a5) Make Raster and GL checkboxes use QGroupBox checkbox feature a6) Move "current command", "command hitbox" and "zoom level" from "Settings" widget to part of "Inspector" concept. These pieces of information are now visualized as their own box in the right-hand bar, below settings. a7) Do not expose settings user selects through the UI widgets state that record the user interacts with. Instead, expose it as state of the "settings widget". Thus settings widget provides "raster settings changed" signal, which the client hook to and then query the state through the object API. This makes the full window a bit shorter. This commit is part of work that tries to make the debugger window to be a bit more resizeable, so that it would fit 1900x1200 screen. Review URL: https://codereview.chromium.org/829933002
* Fix computation of bound in FillBounds::updateSaveBoundsGravatar robertphillips2014-12-30
| | | | | | | | intersect doesn't change the bounds when the two bounds do not intersect. This is definitely not the intended behavior. With the SKPs captured on 12/23/14, Chrome began passing Skia drawPicture ops that did not intersect the current clip - which revealed this bug. Review URL: https://codereview.chromium.org/817483004
* Add a simpler key type for scratch resource keys.Gravatar bsalomon2014-12-30
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/815833004
* Fix for disabled color writes xp on n6Gravatar egdaniel2014-12-30
| | | | | | | | | | The N6 has some driver bug that is required us to give some value to gl_FragColor. The disabledColorWriteXP should not need to set any value in its shader, but to fix this crash this cl sets gl_FragColor to 0. BUG=445377 Review URL: https://codereview.chromium.org/823053003
* ViewMatrix uniform upload moved to GeometryProcessorGravatar joshualitt2014-12-30
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/827973002
* Update SKP versionGravatar skia.buildbots2014-12-30
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/831793002
* Change DebugCanvas API to not encourage memory leaksGravatar kkinnunen2014-12-30
| | | | | | | | | | Pass command strings and offset arrays as out parameters instead of returning new arrays from the functions. This simplifies debugger leak investigations, as the app leaks less by design. Review URL: https://codereview.chromium.org/821663003
* rebaseGravatar joshualitt2014-12-30
| | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/822483003
* Update stroke-fill GM baselinesGravatar robertphillips2014-12-30
| | | | | | TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/827243002
* Move ViewMatrix off of drawstateGravatar joshualitt2014-12-29
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/815553003
* Update stroke path to use rect returned from isRect (to fix trailing moveTo bug)Gravatar robertphillips2014-12-29
| | | | | | | | | | This basically recreates what was done in: https://codereview.chromium.org/16950021/ (add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo) with the addition of GM representation BUG=skia:247770 Review URL: https://codereview.chromium.org/834503002
* Fix bound returned by SkPath::isRect when the path contains a trailing moveToGravatar robertphillips2014-12-29
| | | | | | | | | | | | | | | | | | Oddly enough this was fixed in: https://codereview.chromium.org/16950021/ (add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo) but was reverted here: https://skia.googlesource.com/skia/+/8fd160350ca5f57fbb1b2e03383c5778414a9b48 since it appeared to be crashing Chrome's trybots. I think it just fell through the cracks after that. If this sticks I will land a follow on patch for the stroke issue reported in the original bug (crbug.com/247770). BUG=247770,445368 Review URL: https://codereview.chromium.org/834483002
* removing coord change matricesGravatar joshualitt2014-12-29
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/821243003
* Remove coordchanges from drawstateGravatar joshualitt2014-12-29
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/818233002
* Add device space skshader GM to test kDevice_GrCoordSetGravatar bsalomon2014-12-29
| | | | Review URL: https://codereview.chromium.org/816003002
* Update SKP versionGravatar skia.buildbots2014-12-28
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/829753002
* Update SKP versionGravatar skia.buildbots2014-12-27
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/827813002
* Update SKP versionGravatar skia.buildbots2014-12-25
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/822393002
* disable using codecs until that can work in chromeGravatar reed2014-12-25
| | | | | | | BUG=skia:3275 TBR= Review URL: https://codereview.chromium.org/820343002
* mark c_gms to be rebaselined (gm updated)Gravatar reed2014-12-25
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/820303002
* add image-from-codec to c apiGravatar reed2014-12-25
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/822203002
* fix images in multi-thread by doing shallow-copiesGravatar reed2014-12-25
| | | | | | | BUG=skia: TBR=mtklein@google.com Review URL: https://codereview.chromium.org/791473006
* Update SKP versionGravatar skia.buildbots2014-12-23
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/806243004
* add maskfilter to c apiGravatar reed2014-12-23
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/822053002
* Add baselines for Tegra2 complexclip* GMs.Gravatar jvanverth2014-12-23
| | | | | | | | | They look bad, so marked as failure-ignored and tagged with a bug #. BUG=skia:3273 TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/800523003
* Lay down baselines for complexclip_*_invert and complexclip3_*.Gravatar jvanverth2014-12-23
| | | | | | TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/821093007
* fix for valgrindGravatar joshualitt2014-12-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/816103003
* Update SKP versionGravatar skia.buildbots2014-12-22
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/796993003
* ignoring imageblur2 on galaxyGravatar joshualitt2014-12-22
| | | | | | | | NOTRY=True TBR= BUG=skia: Review URL: https://codereview.chromium.org/816893003
* add picture to c apiGravatar reed2014-12-22
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/818153002
* rebaseGravatar joshualitt2014-12-22
| | | | | | | | TBR= NOTRY=True BUG=skia: Review URL: https://codereview.chromium.org/818163002
* add private flag for sprite-as-bitmapGravatar reed2014-12-22
| | | | | | BUG=skia:3272 Review URL: https://codereview.chromium.org/806853005
* This CL cleans up the last remaining users of localCoordChange on paintGravatar joshualitt2014-12-22
| | | | | | | NOTREECHECKS=True BUG=skia: Review URL: https://codereview.chromium.org/817853002
* Remove last trace of SK_LEGACY_ENCODE_BITMAPGravatar scroggo2014-12-22
| | | | Review URL: https://codereview.chromium.org/819173002
* initial baselines for new GMsGravatar reed2014-12-22
| | | | | | | | BUG=skia: TBR= NOTRY=True Review URL: https://codereview.chromium.org/816453007
* add testing flag to ignore saveLayer boundsGravatar reed2014-12-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/819123003
* Rename GrGpuGL -> GrGLGpuGravatar jvanverth2014-12-22
| | | | Review URL: https://codereview.chromium.org/824753002
* Fix gyp for GrDisableColorXPGravatar egdaniel2014-12-22
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/819923002
* Fix conics for gpu GrAAHairLinePathRenderGravatar egdaniel2014-12-22
| | | | | | | | | | | This fixes one of the bugs discovered when rrects/ovals were changed to conics. Specifcally the case where hairlines were being drawing randomly all of the place. There is still a bug in a lot of our rrect/oval draws/clipping so the legacy flags are still needed. BUG=skia:3258 Review URL: https://codereview.chromium.org/822733003
* Disable GPU sRGB textures for the moment.Gravatar jvanverth2014-12-22
| | | | | | TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/817373002
* reenable complexclip3 for gpuGravatar bsalomon2014-12-22
| | | | Review URL: https://codereview.chromium.org/814273003