aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* path ops work in progressGravatar caryclark@google.com2013-10-02
| | | | | | | | | | | | make more skps work remove edit files BUG= Review URL: https://codereview.chromium.org/23542056 git-svn-id: http://skia.googlecode.com/svn/trunk@11570 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make GPU coord transforms automaticGravatar bsalomon@google.com2013-10-02
| | | | | | | | | | | | | Adds a GrCoordTransform class and updates the framework to handle coord transforms similar to how it handles textures with GrTextureAccess. Renames GrGLEffectMatrix to GrGLCoordTransform and slightly repurposes it to be used by the framework instead of effects. R=bsalomon@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/24853002 git-svn-id: http://skia.googlecode.com/svn/trunk@11569 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to test CQ emails.Gravatar commit-bot@chromium.org2013-10-02
| | | | | | | | | | | | | BUG= NOTRY=True R=borenet@google.com TBR=borenet@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/25712003 git-svn-id: http://skia.googlecode.com/svn/trunk@11567 2bbb7eff-a529-9590-31e7-b0007b416f81
* Empty implementations for SkImageDecoder.Gravatar scroggo@google.com2013-10-01
| | | | | | | | | | | | | Add constructor and destructor, so SkScaledBitmapSampler's DummyDecoder has no unresolved symbols in Chrome. Fixes our Chrome canary. Unreviewed. Review URL: https://codereview.chromium.org/25536004 git-svn-id: http://skia.googlecode.com/svn/trunk@11566 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix race between ~SkThreadPool and SkThreadPool::Loop on fDone.Gravatar commit-bot@chromium.org2013-10-01
| | | | | | | | | | | | | | | | | We're writing fDone without holding the mutex. Bad form, says tsan. In practice this is fairly innocuous, as fDone only ever goes from false to true and only once. Though, I wouldn't be surprised if there were some way this could leak a thread that never got the signal to die. BUG= R=scroggo@google.com, reed@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/25371003 git-svn-id: http://skia.googlecode.com/svn/trunk@11563 2bbb7eff-a529-9590-31e7-b0007b416f81
* Writing to testName and reading its size isn't thread safe, TSAN reminds us.Gravatar commit-bot@chromium.org2013-10-01
| | | | | | | | | | | | | Guarding it into a no-op makes it safe. Looks like this is only used for debugging, presumably singlethreaded? BUG= R=caryclark@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/25366002 git-svn-id: http://skia.googlecode.com/svn/trunk@11562 2bbb7eff-a529-9590-31e7-b0007b416f81
* In skia_test.cc, atomics -> mutex.Gravatar commit-bot@chromium.org2013-10-01
| | | | | | | | | | | | | | | | | | | | | These guys are not heavily contended nor speed critical. No need for atomics, plus this makes tsan stop complaining (correctly) about reading fNextIndex unsafely in onEnd. I took a look at failCount/fFailCount, which I think is safely atomic and quite conveniently so: It's never read until all the threads which could possibly increment it have terminated (except for the one where it was created, obviously). We could guard it with a mutex too, but maybe we can let this one slide. BUG= R=bungeman@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/25357002 git-svn-id: http://skia.googlecode.com/svn/trunk@11561 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use explicitly-sized enums in GrGLProgramDesc::KeyHeaderGravatar commit-bot@chromium.org2013-10-01
| | | | | | | | | | | | | | Uses enums explicitly sized to 8 bits in GrGLProgramDesc::KeyHeader, instead of storing them as uint8_t values. This avoids the need to static_cast them. R=bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/23875048 git-svn-id: http://skia.googlecode.com/svn/trunk@11560 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix build.Gravatar scroggo@google.com2013-10-01
| | | | | | | | Predeclare a function. Unreviewed. git-svn-id: http://skia.googlecode.com/svn/trunk@11559 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add an option on SkImageDecoder to skip writing 0s.Gravatar scroggo@google.com2013-10-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only implemented for PNG. Add a getter and setter, and sets the default to false in the constructor. Also copies the setting in copyFieldsToOther. Fix an indpendent bug where fDitherImage was not being copied in copyFieldsToOther. In SkScaledBitmapSampler::begin, consolidate the settings passed in by passing a const reference to the decoder. The decoder can be referenced for its settings of dither, unpremultiplied, and now skipping writing zeroes. Update callers to use the new API. In png decoder, rather than passing around a pointer to an initial read of getDitherImage, and potentially changing it, look at the field on the decoder itself, and modify it directly. This is a change in behavior - now if that same decoder is used to decode a different image, the dither setting has changed. I think this is okay because A) the typical use case is to use a new decoder for each decode, B) we do not make any promises that a decode does not change the decoder and C) it makes the code in SkScaledBitmapSampler much cleaner. In SkScaledBitmapScampler, add new row procs for skipping zeroes. Now that choosing the row proc has five dimensions (src config, dst config, dither, skip writing zeroes, unpremultiplied), use a new method: each src/dst combination has a function for choosing the right proc depending on the decoder. SkScaledBitmapScampler::RowProc is now public for convenience. Remove Sample_Gray_D8888_Unpremul, which is effectively no different from Sample_Gray_D8888. In cases where unpremultiplied was trivial, such as 565 and when sampling from gray, decoding may now succeed. Add a benchmark (currently disabled) for comparing the speed of skipping writing zeroes versus not skipping. For this particular image, which is mostly transparent pixels, normal decoding took about 3.6 milliseconds, while skipping zeroes in the decode took only about 2.5 milliseconds (this is on a Nexus 4). Presumably it would be slower on an image with a small amount of transparency, but there will be no slowdown for an image which reports that it has no transparency. In SkImageRef_ashmem, always skip writing zeroes, since ashmem memory is guaranteed to be initialized to 0. Add a flag to skip writing zeroes in skimage. Add a regression test for choosing the rowproc to ensure I did not change any behavior accidentally. BUG=skia:1661 R=reed@google.com Review URL: https://codereview.chromium.org/24269006 git-svn-id: http://skia.googlecode.com/svn/trunk@11558 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix ninja build on AndroidGravatar djsollen@google.com2013-10-01
| | | | | | | | R=mtklein@google.com Review URL: https://codereview.chromium.org/25535002 git-svn-id: http://skia.googlecode.com/svn/trunk@11555 2bbb7eff-a529-9590-31e7-b0007b416f81
* Allow creating a picture from skp to fail.Gravatar scroggo@google.com2013-10-01
| | | | | | | | | | | | | | | | | Replace the current constructor for creating an SkPicturePlayback to a factory. In the factory, check for incorrect data that would result in an invalid playback. If the playback is invalid, return NULL, and return NULL from SkPicture's factory as well. Update SkTimedPicture(Playback) as well. BUG=skia:1672 R=caryclark@google.com Review URL: https://codereview.chromium.org/24826002 git-svn-id: http://skia.googlecode.com/svn/trunk@11554 2bbb7eff-a529-9590-31e7-b0007b416f81
* Minor changes to XPS device.Gravatar bungeman@google.com2013-10-01
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11552 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reverted r11547; filing bugs for 64-bit warningsGravatar borenet@google.com2013-10-01
| | | | | | Review URL: https://codereview.chromium.org/25530002 git-svn-id: http://skia.googlecode.com/svn/trunk@11551 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to trigger builds after r11547: Always use WERR for skia_libGravatar borenet@google.com2013-10-01
| | | | | | Review URL: https://codereview.chromium.org/25521002 git-svn-id: http://skia.googlecode.com/svn/trunk@11548 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-01
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11544 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix the android build. now both android_ninja _and_ android_make work.Gravatar mtklein@google.com2013-09-30
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/25319003 git-svn-id: http://skia.googlecode.com/svn/trunk@11542 2bbb7eff-a529-9590-31e7-b0007b416f81
* VERBOSE -> SKIA_ANDROID_VERBOSE_SETUPGravatar mtklein@google.com2013-09-30
| | | | | | | | | BUG= R=borenet@google.com Review URL: https://codereview.chromium.org/25269008 git-svn-id: http://skia.googlecode.com/svn/trunk@11541 2bbb7eff-a529-9590-31e7-b0007b416f81
* make vanilla android_ninja work, and add quiet optionsGravatar mtklein@google.com2013-09-30
| | | | | | | | | BUG= R=djsollen@google.com Review URL: https://codereview.chromium.org/25275006 git-svn-id: http://skia.googlecode.com/svn/trunk@11540 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove uneeded copy of gdbserver from apkGravatar djsollen@google.com2013-09-30
| | | | | | | | R=mtklein@google.com Review URL: https://codereview.chromium.org/25336002 git-svn-id: http://skia.googlecode.com/svn/trunk@11539 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reduce max number of textures to 4 to make room for a larger class id in ↵Gravatar bsalomon@google.com2013-09-30
| | | | | | effect key git-svn-id: http://skia.googlecode.com/svn/trunk@11538 2bbb7eff-a529-9590-31e7-b0007b416f81
* Mark when effects and programs have vertex codeGravatar commit-bot@chromium.org2013-09-30
| | | | | | | | | | | | | | | | Adds a 'hasVertexCode' method to GrEffect and a 'fHasVertexCode' field to GrGLProgramDesc::KeyHeader. Also adds a GrVertexEffect class that effects have to inherit from in order to set the 'hasVertexCode' flag and be able to emit vertex code, and updates the existing effects to use it as needed. R=bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/23653059 git-svn-id: http://skia.googlecode.com/svn/trunk@11537 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add 3 color variant to gradient bench, include scale in name, add more benchsGravatar commit-bot@chromium.org2013-09-30
| | | | | | | | | | R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/25294003 git-svn-id: http://skia.googlecode.com/svn/trunk@11536 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix Android release buildsGravatar mtklein@google.com2013-09-30
| | | | | | | | | BUG= R=djsollen@google.com Review URL: https://codereview.chromium.org/25300005 git-svn-id: http://skia.googlecode.com/svn/trunk@11535 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add a GrCustomCoordsTextureEffect classGravatar commit-bot@chromium.org2013-09-30
| | | | | | | | | | | | | | | | | | Extracts a GrCustomCoordsTextureEffect class from GrSimpleTextureEffect. This way there are no effects that can conditionally require a vertex shader. They either always need one or never do. Also removes kCustom_CoordsType from the CoordsType enum in GrEffect (that enum is really only meant for coords provided by the framework), and updates GrSimpleTextureEffect::TestCreate to make the effect with position as well, instead of just local coords. R=bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/24018007 git-svn-id: http://skia.googlecode.com/svn/trunk@11531 2bbb7eff-a529-9590-31e7-b0007b416f81
* quiet down more third-party warnings in poppler and jsoncppGravatar commit-bot@chromium.org2013-09-30
| | | | | | | | | | | BUG= R=djsollen@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/25319002 git-svn-id: http://skia.googlecode.com/svn/trunk@11530 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove unecessary warnings from third_party codeGravatar djsollen@google.com2013-09-30
| | | | | | | | R=mtklein@google.com Review URL: https://codereview.chromium.org/25030003 git-svn-id: http://skia.googlecode.com/svn/trunk@11529 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add GrSurface::savePixels().Gravatar commit-bot@chromium.org2013-09-30
| | | | | | | | | | R=bsalomon@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/25021006 git-svn-id: http://skia.googlecode.com/svn/trunk@11528 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add android_ninja, like android_make for ninja.Gravatar mtklein@google.com2013-09-30
| | | | | | | | | | | | | | | | | | | android_ninja {tests,bench,gm,bench_pictures,render_pictures} all build and run fine. They build so fast I thought maybe they were broken. Note that android_ninja with no argument is failing: ninja: Entering directory `out/config/android-arm_v7_thumb/Debug' ninja: error: 'lib.target/libSampleApp.so', needed by 'android/libs/armeabi-v7a/libSampleApp.so', missing and no known rule to make it Will look into this. BUG= R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=11525 Review URL: https://codereview.chromium.org/24833002 git-svn-id: http://skia.googlecode.com/svn/trunk@11527 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Add android_ninja, like android_make for ninja."Gravatar mtklein@google.com2013-09-30
| | | | | | | | | | Broke some builds. Will try again. BUG= Review URL: https://codereview.chromium.org/25307002 git-svn-id: http://skia.googlecode.com/svn/trunk@11526 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add android_ninja, like android_make for ninja.Gravatar mtklein@google.com2013-09-30
| | | | | | | | | | | | | | | | | android_ninja {tests,bench,gm,bench_pictures,render_pictures} all build and run fine. They build so fast I thought maybe they were broken. Note that android_ninja with no argument is failing: ninja: Entering directory `out/config/android-arm_v7_thumb/Debug' ninja: error: 'lib.target/libSampleApp.so', needed by 'android/libs/armeabi-v7a/libSampleApp.so', missing and no known rule to make it Will look into this. BUG= R=djsollen@google.com Review URL: https://codereview.chromium.org/24833002 git-svn-id: http://skia.googlecode.com/svn/trunk@11525 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ignore flaky shadertext2_pdf-poppler tests on Mac-10.7 Release buildsGravatar epoger@google.com2013-09-30
| | | | | | | | | BUG=skia:1692 TBR=edisonn Review URL: https://codereview.chromium.org/25287002 git-svn-id: http://skia.googlecode.com/svn/trunk@11524 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move the GL shader compilation step into GrGLShaderBuilderGravatar commit-bot@chromium.org2013-09-30
| | | | | | | | | | | | | | Moves the compilation step and a few other blocks of code from GrGLProgram to GrGLShaderBuilder. This way GrGLProgram doesn't have to know whether or not there is a vertex shader. R=bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/23533066 git-svn-id: http://skia.googlecode.com/svn/trunk@11523 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Add a requiresVertexShader method to GrGLEffect"Gravatar commit-bot@chromium.org2013-09-30
| | | | | | | | | | | | | This reverts commit 1a30a3af805b7ea688d4a0f0bfe373c204085a27. We're going to take a different direction for vertexless shaders. R=bsalomon@google.com Author: cdalton@nvidia.com Review URL: https://codereview.chromium.org/23464082 git-svn-id: http://skia.googlecode.com/svn/trunk@11521 2bbb7eff-a529-9590-31e7-b0007b416f81
* HTTP GM results viewer: server now returns category summaries along with ↵Gravatar epoger@google.com2013-09-30
| | | | | | | | | | | | testData (SkipBuildbotRuns) R=borenet@google.com Review URL: https://codereview.chromium.org/25045003 git-svn-id: http://skia.googlecode.com/svn/trunk@11520 2bbb7eff-a529-9590-31e7-b0007b416f81
* revert temporary r11517Gravatar epoger@google.com2013-09-30
| | | | | | Review URL: https://codereview.chromium.org/25215002 git-svn-id: http://skia.googlecode.com/svn/trunk@11518 2bbb7eff-a529-9590-31e7-b0007b416f81
* gm: temporarily re-enable multiple rendermodes, to make sure they haven't ↵Gravatar epoger@google.com2013-09-30
| | | | | | | | regressed Review URL: https://codereview.chromium.org/25213002 git-svn-id: http://skia.googlecode.com/svn/trunk@11517 2bbb7eff-a529-9590-31e7-b0007b416f81
* More image rebaselinesGravatar robertphillips@google.com2013-09-29
| | | | | | | | https://codereview.chromium.org/25184002/ git-svn-id: http://skia.googlecode.com/svn/trunk@11516 2bbb7eff-a529-9590-31e7-b0007b416f81
* Added SK_API to SkPathRef.hGravatar robertphillips@google.com2013-09-29
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11515 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-09-28
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11513 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaselining some stragglersGravatar robertphillips@google.com2013-09-27
| | | | | | | | https://codereview.chromium.org/25098008/ git-svn-id: http://skia.googlecode.com/svn/trunk@11512 2bbb7eff-a529-9590-31e7-b0007b416f81
* Limit warning message to de-clutter bench output logsGravatar robertphillips@google.com2013-09-27
| | | | | | | | https://codereview.chromium.org/25112002/ git-svn-id: http://skia.googlecode.com/svn/trunk@11511 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline after quadratic-circle approximation changeGravatar robertphillips@google.com2013-09-27
| | | | | | | | https://codereview.chromium.org/25078003/ git-svn-id: http://skia.googlecode.com/svn/trunk@11510 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline inconsequential changes to quadclosepath on N10 msaa4Gravatar bsalomon@google.com2013-09-27
| | | | | | | | R=epoger@google.com Review URL: https://codereview.chromium.org/25104003 git-svn-id: http://skia.googlecode.com/svn/trunk@11509 2bbb7eff-a529-9590-31e7-b0007b416f81
* GrAtlas cleanup: Split out GrPlot and GrAtlasGravatar commit-bot@chromium.org2013-09-27
| | | | | | | | | | | | This breaks up GrAtlas into the head of the list (GrAtlas) and the list elements (GrPlot). It also moves all of the GrPlot management code into GrAtlasMgr. It adds a simple pool allocator for GrPlots and removes use of GrPlotMgr. R=bsalomon@google.com, robertphillips@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/24981004 git-svn-id: http://skia.googlecode.com/svn/trunk@11508 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move unlikely-to-be-inlined code from SkPathRef.h to SkPathRef.cppGravatar robertphillips@google.com2013-09-27
| | | | | | | | https://codereview.chromium.org/24998004/ git-svn-id: http://skia.googlecode.com/svn/trunk@11506 2bbb7eff-a529-9590-31e7-b0007b416f81
* Added two more GMs to the suppressions fileGravatar robertphillips@google.com2013-09-27
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11505 2bbb7eff-a529-9590-31e7-b0007b416f81
* This CL effectively reverts:Gravatar robertphillips@google.com2013-09-27
| | | | | | | | | | | | | r5997 Altered arcTo's canonical points to (usually) be convex (https://codereview.appspot.com/6709051/) r9928 GM (and fix) for drawArc capping issue (https://codereview.chromium.org/18271003/) Instead of pushing some of the on-curve points out to attain convexity, this patch pulls all the off curve points in. R=reed@google.com Review URL: https://codereview.chromium.org/24810002 git-svn-id: http://skia.googlecode.com/svn/trunk@11504 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adding gms for tileimagefilter and offsetimagefilterGravatar sugoi@google.com2013-09-27
| | | | | | | | BUG=skia:1684 Review URL: https://codereview.chromium.org/25068002 git-svn-id: http://skia.googlecode.com/svn/trunk@11501 2bbb7eff-a529-9590-31e7-b0007b416f81
* Create HTTP-based GM results viewer.Gravatar epoger@google.com2013-09-27
| | | | | | | | | | | For now, it only allows VIEWING results... next, it will allow the user to rebaseline GM results via the web interface. R=borenet@google.com Review URL: https://codereview.chromium.org/24274003 git-svn-id: http://skia.googlecode.com/svn/trunk@11500 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-15 07:16:59 +0000