aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Changes to SkTDStackNester.Gravatar scroggo@google.com2013-11-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SkTDStackNester is a class used by PdfViewer to assist in saving and restoring the PDF state. Clean up and test this class. Add some documentation. Add FIXME's where I have questions to resolve. Fix a bug where fNestingLevel was not initialized. Remove a commented out line of code copied over from SkTDStack. Rename SkTDStackNester::nests() to nestingLevel() and make it const. Remove unnecessary predeclaration and friend declaration. Remove index() (both const and non-const versions). They were unused, return something that may not be expected (index from the top, rather than from the bottom), and don't work to get any elements in earlier Recs once the first one is full. Report a warning if the nesting level goes above the maximum level, or if we attempt to bring it below zero. Prevent fNestingLevel from dropping below zero. Add kUnusedObject_SkPdfIssue, and use it where appropriate. Depends on https://codereview.chromium.org/64093009/ R=mtklein@google.com Review URL: https://codereview.chromium.org/68843006 git-svn-id: http://skia.googlecode.com/svn/trunk@12328 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix SkMatrix44::invert(...) for identity matrices and a NULL parameterGravatar commit-bot@chromium.org2013-11-20
| | | | | | | | | | | | | | | | | Currently, to check if an SkMatrix44 is singular, we call ::invert(NULL) and check the result. Usually this does no more work than is necessary. One case where we do far too much work is if |this| is an identity matrix. In this case, we do not early out and compute a (partial) determinant (we don't do the full shebang because there are no perspective components). BUG=None R=ajuma@chromium.org, reed@google.com Author: vollick@chromium.org Review URL: https://codereview.chromium.org/79333002 git-svn-id: http://skia.googlecode.com/svn/trunk@12327 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove unnamed namespace usage from 'gm'.Gravatar commit-bot@chromium.org2013-11-20
| | | | | | | | | | | | | | Skia prefers static over unnamed namespaces. BUG=None TEST=None R=bsalomon@google.com, robertphillips@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/79173002 git-svn-id: http://skia.googlecode.com/svn/trunk@12326 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move SkTDStackNester into its own private file.Gravatar scroggo@google.com2013-11-20
| | | | | | | | | | | | Also remove depth(), which is unused. Otherwise the class is unchanged. R=mtklein@google.com Review URL: https://codereview.chromium.org/64093009 git-svn-id: http://skia.googlecode.com/svn/trunk@12324 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: clean up thread locksGravatar epoger@google.com2013-11-20
| | | | | | | | | | | followup to https://codereview.chromium.org/66803004/ ('rebaseline_server: improve thread locks to allow read access during updates') (SkipBuildbotRuns) R=jcgregorio@google.com Review URL: https://codereview.chromium.org/64273011 git-svn-id: http://skia.googlecode.com/svn/trunk@12323 2bbb7eff-a529-9590-31e7-b0007b416f81
* More common_conditions simplifications.Gravatar mtklein@google.com2013-11-20
| | | | | | | | | BUG= R=bungeman@google.com, djsollen@google.com Review URL: https://codereview.chromium.org/78653002 git-svn-id: http://skia.googlecode.com/svn/trunk@12322 2bbb7eff-a529-9590-31e7-b0007b416f81
* Hide unused gFormats.Gravatar mtklein@google.com2013-11-20
| | | | | | | | | | | Presumably this is WIP code? Otherwise, we delete it? BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/78503003 git-svn-id: http://skia.googlecode.com/svn/trunk@12321 2bbb7eff-a529-9590-31e7-b0007b416f81
* GpuTest::GetContext() doesn't exist.Gravatar commit-bot@chromium.org2013-11-20
| | | | | | | | | | | BUG= R=bsalomon@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/76143003 git-svn-id: http://skia.googlecode.com/svn/trunk@12320 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove the SKIA_IGNORE_GPU_MIPMAPS now that Chrome sets glGenMipmap forGravatar commit-bot@chromium.org2013-11-20
| | | | | | | | | | | | the skia GL interface. R=bsalomon@google.com, humper@google.com Author: skaslev@chromium.org Review URL: https://codereview.chromium.org/74783011 git-svn-id: http://skia.googlecode.com/svn/trunk@12319 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update expectations for Ubuntu x32 bot.Gravatar mtklein@google.com2013-11-20
| | | | | | | | | | GM diffs are few, tiny, and unreproducable on our workstations. BUG= Review URL: https://codereview.chromium.org/78913002 git-svn-id: http://skia.googlecode.com/svn/trunk@12318 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix a warning building DM using ninja on Mac.Gravatar scroggo@google.com2013-11-20
| | | | | | | | | | | | | | Here is the warning: ../../dm/DMTask.cpp: In copy constructor ‘DM::Task::Task(const DM::Task&)’: ../../dm/DMTask.cpp:17: warning: base class ‘class SkRunnable’ should be explicitly initialized in the copy constructor Also add an SK_OVERRIDE. R=mtklein@google.com Review URL: https://codereview.chromium.org/76903002 git-svn-id: http://skia.googlecode.com/svn/trunk@12317 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reverting r12315 (More Windows 64b compilation warning fixes) due to ↵Gravatar robertphillips@google.com2013-11-20
| | | | | | compilation failures git-svn-id: http://skia.googlecode.com/svn/trunk@12316 2bbb7eff-a529-9590-31e7-b0007b416f81
* More Windows 64b compilation warning fixesGravatar robertphillips@google.com2013-11-20
| | | | | | | | https://codereview.chromium.org/47513017/ git-svn-id: http://skia.googlecode.com/svn/trunk@12315 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add extra warnings to match what Android uses.Gravatar mtklein@google.com2013-11-20
| | | | | | | | | | R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=12310 Review URL: https://codereview.chromium.org/74193005 git-svn-id: http://skia.googlecode.com/svn/trunk@12314 2bbb7eff-a529-9590-31e7-b0007b416f81
* De-generalize create_typeface on Windows.Gravatar bungeman@google.com2013-11-20
| | | | | | | | | | | | The gdi and dw backends have a local create_typeface function. This function is now called in only one place, onLegacyCreateTypeface. Move the implementation into the caller. R=caryclark@google.com Review URL: https://codereview.chromium.org/76763002 git-svn-id: http://skia.googlecode.com/svn/trunk@12313 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add missing (trivial) virtual destructors.Gravatar mtklein@google.com2013-11-20
| | | | | | | | | BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/78543002 git-svn-id: http://skia.googlecode.com/svn/trunk@12312 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Add extra warnings to match what Android uses."Gravatar scroggo@google.com2013-11-20
| | | | | | | | This reverts commit d234662df1ffeb1bf45b2ade16c4acfb94f89450. This change broke the build. Will resubmit after fixing warnings. git-svn-id: http://skia.googlecode.com/svn/trunk@12311 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add extra warnings to match what Android uses.Gravatar djsollen@google.com2013-11-20
| | | | | | | | R=mtklein@google.com Review URL: https://codereview.chromium.org/74193005 git-svn-id: http://skia.googlecode.com/svn/trunk@12310 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix bench so that if SK_SUPPORTS_GPU even when not provided as compiler optionGravatar djsollen@google.com2013-11-20
| | | | | | | | | | | | | In the case that SK_SUPPORTS_GPU is not provided to the compiler the value is eithe defined in in the SkUserConfig.h or SkPostConfig.h. Prior to this change those headers were not read prior to trying to include the GPU headers which resulted in a failed compile. R=bsalomon@google.com Review URL: https://codereview.chromium.org/76213004 git-svn-id: http://skia.googlecode.com/svn/trunk@12309 2bbb7eff-a529-9590-31e7-b0007b416f81
* SkMemoryStream::setData should also set the current offset to 0.Gravatar bungeman@google.com2013-11-18
| | | | | | | | R=scroggo@google.com Review URL: https://codereview.chromium.org/73273004 git-svn-id: http://skia.googlecode.com/svn/trunk@12308 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove unused kMaxPOI.Gravatar commit-bot@chromium.org2013-11-18
| | | | | | | | | | | BUG= R=djsollen@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/62333026 git-svn-id: http://skia.googlecode.com/svn/trunk@12307 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert SK_REQUIRE_LOCAL_VAR changes for DEPS roll.Gravatar mtklein@google.com2013-11-18
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/59703012 git-svn-id: http://skia.googlecode.com/svn/trunk@12306 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove unnecessary includes.Gravatar commit-bot@chromium.org2013-11-18
| | | | | | | | | | R=djsollen@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/68893028 git-svn-id: http://skia.googlecode.com/svn/trunk@12304 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix Windows build after the SkAutoFoo guard CL.Gravatar mtklein@google.com2013-11-18
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/66593004 git-svn-id: http://skia.googlecode.com/svn/trunk@12303 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix DocumentTest/SkDocument memory leaksGravatar robertphillips@google.com2013-11-18
| | | | | | | | https://codereview.chromium.org/72833002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12302 2bbb7eff-a529-9590-31e7-b0007b416f81
* Guard against most unintentionally ephemeral SkAutoFoo instantiations.Gravatar commit-bot@chromium.org2013-11-18
| | | | | | | | | | | | | | | | | | | I think I applied the trick everywhere possible. Limitations: - can't be used with templated classes - all constructors and destructors must be defined inline A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I deleted them. This change caught the same bugs Cary found in SkPath, plus one more in SampleApp. BUG= R=reed@google.com, caryclark@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/72603005 git-svn-id: http://skia.googlecode.com/svn/trunk@12301 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to test CQ.Gravatar commit-bot@chromium.org2013-11-17
| | | | | | | | | | | | TBR= NOTREECHECKS=true NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/74723002 git-svn-id: http://skia.googlecode.com/svn/trunk@12300 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix general-pespective for conical gradient bug=1744Gravatar mike@reedtribe.org2013-11-14
| | | | | | | | | BUG= R=edisonn@google.com Review URL: https://codereview.chromium.org/71303003 git-svn-id: http://skia.googlecode.com/svn/trunk@12299 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ignore GM dashing_gpu on Debug ANGLEGravatar jvanverth@google.com2013-11-14
| | | | | | | | | | | | BUG=Skia:1844 Committed: http://code.google.com/p/skia/source/detail?r=12297 R=robertphillips@google.com Review URL: https://codereview.chromium.org/72993002 git-svn-id: http://skia.googlecode.com/svn/trunk@12298 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ignore GM dashing_gpu on Debug ANGLEGravatar commit-bot@chromium.org2013-11-14
| | | | | | | | | | | BUG=Skia:1844 R=robertphillips@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/72993002 git-svn-id: http://skia.googlecode.com/svn/trunk@12297 2bbb7eff-a529-9590-31e7-b0007b416f81
* Pdfviewer refactoring.Gravatar scroggo@google.com2013-11-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mostly superficial changes, to help me make sure I understand the code while making modifications. SkPdfRenderer: First class I'm modifying. Move it into include/ and src/ directories. Inherit from SkNoncopyable. Replace load() with factory function which returns NULL if the load fails. Remove unload() and loaded(), which no longer make sense, since the factory will return NULL on a failure to load, and unload() happens on destruction. Use a const char* for loading a PDF, following the convention of SkStream::NewFromFile. Remove unnecessary call to sqrt in SkPDFNativeRenderToBitmap. Also in SkPDFNativeRenderToBitmap, use an appropriate SkScalar macro to convert to an integer. Use this-> when calling member functions. pdf_viewer_main.cpp: Call the new interface for SkPdfRenderer. gyp files: Refer to the new location of SkPdfRenderer. R=edisonn@google.com Review URL: https://codereview.chromium.org/59493011 git-svn-id: http://skia.googlecode.com/svn/trunk@12296 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add missing functions to SkNWayCanvasGravatar commit-bot@chromium.org2013-11-14
| | | | | | | | | | | R=reed@google.com BUG=none Author: enne@chromium.org Review URL: https://codereview.chromium.org/65513003 git-svn-id: http://skia.googlecode.com/svn/trunk@12295 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove suppression of blurrect_outerGravatar robertphillips@google.com2013-11-14
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12294 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline blurrect_outer imagesGravatar robertphillips@google.com2013-11-14
| | | | | | | | https://codereview.chromium.org/70103015/ git-svn-id: http://skia.googlecode.com/svn/trunk@12293 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix warnings and Win only error in pdf_viewer.Gravatar scroggo@google.com2013-11-14
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12292 2bbb7eff-a529-9590-31e7-b0007b416f81
* increase coverage of SkPath.cpp, remove unused codeGravatar commit-bot@chromium.org2013-11-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using Mike Klein's excellent coverage tool, increase the unit testing of SkPath.cpp from 70% to 95%. Along the way, determined that these functions were not maintained or used: SkPath::pathTo SkPath::contains as well as a large block of SkPath::cheapGetDirection(). Changed SkPath::validate() to permit infinities in the path data points. Fixed errors in preserving direction. Fixed error setting direction when convexity is unknown. Added missing conic to moveTo only detector. BUG= R=bsalomon@google.com, reed@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/65493004 git-svn-id: http://skia.googlecode.com/svn/trunk@12291 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline and re-enable rrect_aa, rrect_bw, simpleaaclip_aaclip, ↵Gravatar jvanverth@google.com2013-11-14
| | | | | | simpleaaclip_path, strokerect, strokes_round git-svn-id: http://skia.googlecode.com/svn/trunk@12290 2bbb7eff-a529-9590-31e7-b0007b416f81
* Include SkBitmapDevice for pdf_viewer.Gravatar scroggo@google.com2013-11-14
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12289 2bbb7eff-a529-9590-31e7-b0007b416f81
* Include pdfviewer in everything.Gravatar scroggo@google.com2013-11-14
| | | | | | | | | | | | | | | | | This simplifies the process for building pdfviewer. Now it can be built using ./gyp_skia make pdfviewer (ninja can also be used). R=edisonn@google.com Review URL: https://codereview.chromium.org/70353003 git-svn-id: http://skia.googlecode.com/svn/trunk@12288 2bbb7eff-a529-9590-31e7-b0007b416f81
* Address some more valgrind issuesGravatar robertphillips@google.com2013-11-14
| | | | | | | | R=borenet@google.com Review URL: https://codereview.chromium.org/59713010 git-svn-id: http://skia.googlecode.com/svn/trunk@12286 2bbb7eff-a529-9590-31e7-b0007b416f81
* pdfviewer: ignore flanky testGravatar edisonn@google.com2013-11-14
| | | | | | Review URL: https://codereview.chromium.org/64223008 git-svn-id: http://skia.googlecode.com/svn/trunk@12285 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-11-14
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12283 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add rrect_aa and rrect_bw to ignore listGravatar jvanverth@google.com2013-11-13
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12282 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ignore failures for blurrect_outer (needs rebaselining).Gravatar jvanverth@google.com2013-11-13
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12281 2bbb7eff-a529-9590-31e7-b0007b416f81
* pdfviewer: seed expectations for Mac 10.8 native rendererGravatar edisonn@google.com2013-11-13
| | | | | | Review URL: https://codereview.chromium.org/61683010 git-svn-id: http://skia.googlecode.com/svn/trunk@12280 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add missing rebaselines for rrect_clip.Gravatar jvanverth@google.com2013-11-13
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12279 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ignore Nexus4 failures for complexclip2_path_aa_gpu.Gravatar jvanverth@google.com2013-11-13
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12278 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline and enable GMs: pathopsskpclip roundrects rrect rrect_clip ↵Gravatar jvanverth@google.com2013-11-13
| | | | | | samplerstress git-svn-id: http://skia.googlecode.com/svn/trunk@12277 2bbb7eff-a529-9590-31e7-b0007b416f81
* pdfviewer: readobject can return null, and catalog can be nullGravatar edisonn@google.com2013-11-13
| | | | | | Review URL: https://codereview.chromium.org/72053002 git-svn-id: http://skia.googlecode.com/svn/trunk@12276 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove backward compatibility shims from SkStream.h.Gravatar bungeman@google.com2013-11-13
| | | | | | | | R=reed@google.com Review URL: https://codereview.chromium.org/68773009 git-svn-id: http://skia.googlecode.com/svn/trunk@12275 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-03 00:44:09 +0000