aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Remove setFromPaint from GrPipelineBuilderGravatar joshualitt2015-07-09
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1227153003
* Trivial cleanup of copying GrPipelineBuilderGravatar joshualitt2015-07-09
| | | | | | | TBR=robertphillips@google.com BUG=skia: Review URL: https://codereview.chromium.org/1229983003
* add runtime option to provide data->imagegenerator factoryGravatar reed2015-07-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1229933003
* Add RAII for other types of locks. Change SkGlyphCache_Globals toGravatar herb2015-07-09
| | | | | | | | | use a SkSpinlock instead of SkMutex. This results in significant performance increase for mpd in nanobench. BUG=skia: Review URL: https://codereview.chromium.org/1210143004
* Remove init function from GrTextContext.hGravatar joshualitt2015-07-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1231923002
* Outline SkSpinlock::acquire().Gravatar mtklein2015-07-09
| | | | | | | | | | | | | | | | The proportion of time spent doing useful work is well over 99% in acquire(), so outlining it doesn't hurt speed at all, and makes it much easier to pick out on a profile. It'd be about 50/50 work/overhead if we outlined the extremely-cheap release(). I also tried outlining some SkRefCnt methods with similar mixed results. BUG=skia: No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1212253013
* Change to use mean and to use stderr.Gravatar herb2015-07-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1228783003
* More threading of GrProcessorDataManagerGravatar joshualitt2015-07-09
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1230813003
* Have nanobench pay attention to --threads.Gravatar mtklein2015-07-09
| | | | | | | | TBR= BUG=skia: Review URL: https://codereview.chromium.org/1229953002
* Remove SkImageGenerator pieces only for SkCodec.Gravatar scroggo2015-07-09
| | | | | | | | | | | Follow up to the split between SkImageGenerator and SkCodec. Now that SkCodec does not inherit from SkImageGenerator, SkImageGenerator no longer needs Options or Result, which were added for SkCodec. Remove them, but keep them behind a flag, since Chromium has its own subclasses of SkImageGenerator which assume the old signature for onGetPixels. Review URL: https://codereview.chromium.org/1226023003
* Add normal map sampleGravatar jvanverth2015-07-09
| | | | | | | | | | This adds an example of an SkShader that does normal mapping. It has a single directional light and an ambient light. Committed: https://skia.googlesource.com/skia/+/8e0da72ba890de395c9946ec6639c9e1e7b16027 Review URL: https://codereview.chromium.org/1212813009
* Temporarily suppress valgrind errors in tip of tree libjpeg-turboGravatar msarett2015-07-09
| | | | | | BUG=skia:4030 Review URL: https://codereview.chromium.org/1231613004
* SkCodec no longer inherits from SkImageGenerator.Gravatar scroggo2015-07-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SkImageGenerator makes some assumptions that are not necessarily valid for SkCodec. For example, SkCodec does not assume that it can always be rewound. We also have an ongoing question of what an SkCodec should report as its default settings (i.e. the return from getInfo). It makes sense for an SkCodec to report that its pixels are unpremultiplied, if that is the case for the underlying data, but if a client of SkImageGenerator uses the default settings (as many do), they will receive unpremultiplied pixels which cannot (currently) be drawn with Skia. We may ultimately decide to revisit SkCodec reporting an SkImageInfo, but I have left it unchanged for now. Import features of SkImageGenerator used by SkCodec into SkCodec. I have left SkImageGenerator unchanged for now, but it no longer needs Result or Options. This will require changes to Chromium. Manually handle the lifetime of fScanlineDecoder, so SkScanlineDecoder.h can include SkCodec.h (where Result is), and SkCodec.h does not need to include it (to delete fScanlineDecoder). In many places, make the following simple changes: - Now include SkScanlineDecoder.h, which is no longer included by SkCodec.h - Use the enums in SkCodec, rather than SkImageGenerator - Stop including SkImageGenerator.h where no longer needed Review URL: https://codereview.chromium.org/1220733013
* Do not try to compile x86 and x86_64 .asm files on AndroidGravatar msarett2015-07-09
| | | | | | | | | | This is currently only works on Linux hosts because we have checked in a binary and does not work on Mac hosts. We are disabling until we find a suitable solution. BUG=skia:4028 Review URL: https://codereview.chromium.org/1228823006
* YUV to RGB Texture threading GrProcessorDataManagerGravatar joshualitt2015-07-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1230803002
* doc: more changesGravatar halcanary2015-07-09
| | | | | | | | | NOTRY=true DOCS_PREVIEW= https://skia.org/user/api/skcanvas?cl=1228063002 DOCS_PREVIEW= https://skia.org/user/tips?cl=1228063002 TBR= Review URL: https://codereview.chromium.org/1228063002
* rename GrShaderDataManager -> GrProcessorDataManagerGravatar joshualitt2015-07-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1228683002
* Revert of Add normal map sample (patchset #6 id:100001 of ↵Gravatar robertphillips2015-07-08
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1212813009/) Reason for revert: Compilation failures: ../../../../../samplecode/SampleLighting.cpp:13:18: fatal error: SkGr.h: No such file or directory Original issue's description: > Add normal map sample > > This adds an example of an SkShader that does normal > mapping. It has a single directional light and an > ambient light. > > Committed: https://skia.googlesource.com/skia/+/8e0da72ba890de395c9946ec6639c9e1e7b16027 TBR=reed@google.com,bsalomon@google.com,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1230603002
* fix up test create functionsGravatar joshualitt2015-07-08
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1213623022
* Add normal map sampleGravatar jvanverth2015-07-08
| | | | | | | | This adds an example of an SkShader that does normal mapping. It has a single directional light and an ambient light. Review URL: https://codereview.chromium.org/1212813009
* SkAdvancedTypefaceMetrics zeroing constructorGravatar halcanary2015-07-08
| | | | Review URL: https://codereview.chromium.org/1221903004
* Remove another assertion that a reference is non-null.Gravatar dcheng2015-07-08
| | | | | | | | | | | This tickles a warning in Clang: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] BUG=none Review URL: https://codereview.chromium.org/1225053003
* disabled GrAALinearizingConvexRenderer for nowGravatar ethannicholas2015-07-08
| | | | | | BUG=505579 Review URL: https://codereview.chromium.org/1219653004
* add ability to get FBO ID to SurfaceGravatar joshualitt2015-07-08
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1220733007
* Add image->bitmapGravatar reed2015-07-08
| | | | | | | | BUG=skia: patch from issue 1212163012 at patchset 1 (http://crrev.com/1212163012#ps1) Review URL: https://codereview.chromium.org/1208993017
* doc: embed fiddleGravatar halcanary2015-07-08
| | | | | | | | NOTRY=true DOCS_PREVIEW= https://skia.org/user/api/skcanvas?cl=1149633009 DOCS_PREVIEW= https://skia.org/user/api/skpaint?cl=1149633009 Review URL: https://codereview.chromium.org/1149633009
* Remove SkImage::NewFromBitmap encoded data helperGravatar fmalita2015-07-08
| | | | | | | | | | | | Attempting to instantiate image decoders at this stage introduces embedder dependencies. Instead, we can just let callers set up any needed generators on the bitmap. R=reed@google.com Review URL: https://codereview.chromium.org/1218663012
* Makes GrPipelineInfo a class with query functions used by GrBatch subclasses.Gravatar bsalomon2015-07-08
| | | | | | Committed: https://skia.googlesource.com/skia/+/f5179a4c490bc787190321bd8ffdb0e6a4efa9ac Review URL: https://codereview.chromium.org/1213383005
* Revert of Use the upstream version of libwebp, v0.4.3. (patchset #6 id:70001 ↵Gravatar scroggo2015-07-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1178013008/) Reason for revert: Breaking the build e.g. http://build.chromium.org/p/client.skia/builders/Perf-Mac10.8-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Release/builds/1082/steps/build%20nanobench/logs/stdio ../../../third_party/externals/libwebp/src/utils/./endian_inl.h:51:10: error: use of unknown builtin '__builtin_bswap16' [-Wimplicit-function-declaration] return __builtin_bswap16(x); ^ 1 error generated. Original issue's description: > Use the upstream version of libwebp, v0.4.3. > > DEPS: > Update to pull v0.4.3 of libwebp from upstream > > gyp/libwebp.gyp: > Add new files, as referenced by the gyp file used by Chromium. > > resource/tests: > Add regression tests for particular images. > > BUG=skia:3442 > BUG=skia:3315 > BUG=skia:3429 > > Committed: https://skia.googlesource.com/skia/+/3aa0fb4d80c76b559ff4b82d5e569993aea06da1 TBR=djsollen@google.com,jzern@chromium.org,msarett@google.com,emmaleer@google.com,scroggo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3442 Review URL: https://codereview.chromium.org/1223583004
* doc: add instructions to capture a `.skp` from chromiumGravatar halcanary2015-07-08
| | | | | | | | NOTRY=true DOCS_PREVIEW= https://skia.org/user/tips?cl=1220783005 Review URL: https://codereview.chromium.org/1220783005
* Add gradle wrappers for Android app buildsGravatar djsollen2015-07-08
| | | | | | | | These wrappers are approxiately 56K in size and are the recommened way to use Gradle. It also ensures that developers wanting to build the app don't need install an additional dependency. Review URL: https://codereview.chromium.org/1227723002
* Use the upstream version of libwebp, v0.4.3.Gravatar scroggo2015-07-08
| | | | | | | | | | | | | | | | | DEPS: Update to pull v0.4.3 of libwebp from upstream gyp/libwebp.gyp: Add new files, as referenced by the gyp file used by Chromium. resource/tests: Add regression tests for particular images. BUG=skia:3442 BUG=skia:3315 BUG=skia:3429 Review URL: https://codereview.chromium.org/1178013008
* Revert of Rework GrPipelineInfo (patchset #7 id:120001 of ↵Gravatar bsalomon2015-07-08
| | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1213383005/) Reason for revert: breaking stuff! Original issue's description: > Makes GrPipelineInfo a class with query functions used by GrBatch subclasses. > > Committed: https://skia.googlesource.com/skia/+/f5179a4c490bc787190321bd8ffdb0e6a4efa9ac TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1213013003
* Add tools/flatten to flatten nested pictures in .skps.Gravatar mtklein2015-07-08
| | | | | | | | | Tested by running on skps/sp_desk_nytimes.skp. The output .skp had no nested draw picture calls, and the files were both 9.3M. BUG=skia: Review URL: https://codereview.chromium.org/1221303020
* more threading of GrShaderDataManagerGravatar joshualitt2015-07-08
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1215643006
* Thread GrShaderDataManager through Image filtersGravatar joshualitt2015-07-08
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1229613002
* DM runs more than 100k tests now.Gravatar mtklein2015-07-08
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1217493006
* Fix leak in PictureTest.cppGravatar mtklein2015-07-08
| | | | | | | | TBR=schenney@chromium.org BUG=skia: Review URL: https://codereview.chromium.org/1210053008
* More threading of GrShaderDataManagerGravatar joshualitt2015-07-08
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1213613016
* Makes GrPipelineInfo a class with query functions used by GrBatch subclasses.Gravatar bsalomon2015-07-08
| | | | Review URL: https://codereview.chromium.org/1213383005
* Add SK_API to GrSurfaceGravatar bsalomon2015-07-08
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1209043012
* DM: swizzle BGRA to RGBA before calculating pixel MD5.Gravatar mtklein2015-07-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | We name our .pngs by pixel hashes for gold. For 8888 images, we're hashing SkPMColors, which have platform-dependent order: BGRA on Linux and Windows, RGBA otherwise. This means we can end up with pixel-identical pngs with different hashes, which is confusing. This CL standardizes on RGBA for 8888 configs, arbitrarily chosen so that Android ends up a no-op. Long-term, this should eliminate most of the 0-pixel-diff problems we see on gold.skia.org. There are other ways to end up with the same .png from different SkBitmaps (think, red 565 square vs. red 8888 square) but they're rather less common / likely. This will temporarily create a giant 0-pixel-diff problem on gold.skia.org. Any Linux or Windows images which are not already pixel-identical to a Mac or Android image should show up as untriaged hashes that are pixel-identical to their version just before landing (we're only changing the hash, not the .png). This means anything vaguely platform dependent (fonts, GPUs) will probably show up as needing a triage but with a zero diff from a previous image. If this goes well, we might do the same for 565. Just want to leave them out for now to cut down on the triaging I need to do in one go. BUG=skia: Review URL: https://codereview.chromium.org/1226933005
* Initial CL to create dummy GrShaderDataManager and thread it throughGravatar joshualitt2015-07-08
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1225673007
* Remove &glyph from SkASSERT.Gravatar dcheng2015-07-07
| | | | | | | | | | | This tickles a warning in Clang: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] BUG=none Review URL: https://codereview.chromium.org/1220113003
* fix pathops battle testGravatar caryclark2015-07-07
| | | | | | | | | | The intermediate subtraction threw away bits causing the subsequent cross product to fail. Defer the bit truncation until after the vector is computed. TBR=reed@google.com Review URL: https://codereview.chromium.org/1226933003
* Add check that Dwrite glyph fits in unicode table.Gravatar wfh2015-07-07
| | | | | | BUG=470146 Review URL: https://codereview.chromium.org/1218043004
* Allow reset of the SkPictureRecorder cull rect and other parameters during ↵Gravatar schenney2015-07-07
| | | | | | | | | | | | | | | | | | | | | | endRecording. For some users of SkPictureRecorder, the cull rect is more efficiently determined while drawing is in progress, rather than when recording starts. The existing API requires the cull rect at start time, even though the information is not used for any culling purpose until the end of recording. This patch provides a means to reset the cull rect when recording ends, allowing users to update the rect based on information learned during drawing and for the new rect to be used as the culling bound. A valid bound is still required on the beginRecording call because it sizes the underlying canvas and sets the aspect ratio for any bounding box hierarchy. The bounding box factory can also be specified and parameters that control SkPicture creation. R=mtklein, reed1 BUG=skia:3919 Review URL: https://codereview.chromium.org/1178673007
* When GrAAConvesTesselator was merging the first and last point of the array, ↵Gravatar ethannicholas2015-07-07
| | | | | | | | it was deleting the last point without checking to see if any of the previous points shared the same index. This led to continuing to use the index of a deleted point and thus referencing memory past the end of the vertex array. BUG=chromium:505227 Review URL: https://codereview.chromium.org/1225683008
* Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.Gravatar mtklein2015-07-07
| | | | | | | | | | | | | | SkThread.h doesn't do anything anymore execept include those two, and thankfully, it doesn't seem to be mentioned outside Skia. No public API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc Review URL: https://codereview.chromium.org/1215393002
* Propagate SkSurfaceProps when knownGravatar robertphillips2015-07-07
| | | | | | This CL just closes the loop on some low hanging fruit w.r.t. propagating surface properties. Review URL: https://codereview.chromium.org/1214853025
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-05 08:34:51 +0000