aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Update SKP versionGravatar UpdateSKPs2018-03-25
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I58fc4aceb6347620be1b9d04adf29de5287835cc Reviewed-on: https://skia-review.googlesource.com/116306 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Roll skia/third_party/externals/skcms/ d9500cbd4..a50fa23a3 (1 commit)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms/+log/d9500cbd4b35..a50fa23a3165 $ git log d9500cbd4..a50fa23a3 --date=short --no-merges --format='%ad %ae %s' 2018-03-24 mtklein no particular need to assert(false) here Created with: roll-dep skia/third_party/externals/skcms The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=jvanverth@google.com Change-Id: I022010899b5650980779090531e4ab5bccbbd1f1 Reviewed-on: https://skia-review.googlesource.com/116304 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Update markdown filesGravatar Update Docs2018-03-24
| | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=update-docs@skia.org NO_MERGE_BUILDS Change-Id: I23ebdd7299210e1ed5545521d472e0b473bd5566 Reviewed-on: https://skia-review.googlesource.com/116302 Commit-Queue: Update Docs <update-docs@skia.org> Reviewed-by: Update Docs <update-docs@skia.org>
* Roll skia/third_party/externals/angle2/ e6a40d07d..26ed93d7d (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/e6a40d07d272..26ed93d7db23 $ git log e6a40d07d..26ed93d7d --date=short --no-merges --format='%ad %ae %s' 2018-03-23 ynovikov Reduce number of uniforms in UniformsBenchmark perf test 2018-02-08 ynovikov Allow ANGLE libs to have arbitrary suffix. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I3694dc26e40248199767c9e36f88fc282d9bb2f8 Reviewed-on: https://skia-review.googlesource.com/116300 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Hide GrBackendTexture/RenderTarget constructors that take a GrPixelConfigGravatar Brian Salomon2018-03-23
| | | | | | | | | | Make GrGLTexture use the version that takes GrMipMapped. Bug: skia:6718 Change-Id: Id3e801bcb5e781938e610bdea75bd92498117935 Reviewed-on: https://skia-review.googlesource.com/116221 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Roll skia/third_party/externals/angle2/ d779f6a98..e6a40d07d (3 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/d779f6a98524..e6a40d07d272 $ git log d779f6a98..e6a40d07d --date=short --no-merges --format='%ad %ae %s' 2018-03-22 lucferron Vulkan: Depth / stencil attachments bug fixes 2018-03-23 oetuaho Increment ANGLE_SH_VERSION 2018-03-21 lucferron Vulkan: Support of A8 textures Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I77f036f6f0c5d8ed23d8407954715bca1a4bad85 Reviewed-on: https://skia-review.googlesource.com/116209 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert "Implement Sk2f::Store2"Gravatar Chris Dalton2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8a8a8e9dd5c47f3fc930064bd030790f98af27af. Reason for revert: Needs non-SIMD impl Original change's description: > Implement Sk2f::Store2 > > Bug: skia: > Change-Id: Ieedd05ced376a7604936e9d2729fc20a8669496e > Reviewed-on: https://skia-review.googlesource.com/115531 > Commit-Queue: Chris Dalton <csmartdalton@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,csmartdalton@google.com Change-Id: I8dfbd87c5871b041a4fc6ef3816f121c72083a20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/116240 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Remove legacy GrContext factories function and supporting code/types.Gravatar Brian Salomon2018-03-23
| | | | | | | Change-Id: I437a4a0a58bf70ea1b8b0659b099a2af2bfa64fe Reviewed-on: https://skia-review.googlesource.com/116197 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Move GrPixelConfig to GrTypesPrivGravatar Brian Salomon2018-03-23
| | | | | | | | | BUG= skia:6718 Change-Id: I254a5d289c1216e580b8f7fe613236c090d0e901 Reviewed-on: https://skia-review.googlesource.com/116196 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Remove legacy SkSurface::MakeFromBackendRenderTarget that does not take ↵Gravatar Brian Salomon2018-03-23
| | | | | | | | | | SkColorType Bug: skia:6718 Change-Id: Iefec5be49bf7450426c5ddb668f5525876f8ec2d Reviewed-on: https://skia-review.googlesource.com/116194 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Move a bunch of internal types from GrTypes to GrTypesPrivGravatar Brian Salomon2018-03-23
| | | | | | | Change-Id: I9fe1297ae7d185957c76681305bcf22cc972e53b Reviewed-on: https://skia-review.googlesource.com/116189 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Get @constructor feature of SKSL workingGravatar Robert Phillips2018-03-23
| | | | | | | | | | This is probably the only portion of https://skia-review.googlesource.com/c/skia/+/115900 that we want to keep TBR=ethannicholas@google.com Change-Id: Ife4d7bfbe454f705e93fb051b0bcf8e2b0a052b5 Reviewed-on: https://skia-review.googlesource.com/116192 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Implement Sk2f::Store2Gravatar Chris Dalton2018-03-23
| | | | | | | | Bug: skia: Change-Id: Ieedd05ced376a7604936e9d2729fc20a8669496e Reviewed-on: https://skia-review.googlesource.com/115531 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Roll skia/third_party/externals/skcms/ a6f932c91..d9500cbd4 (1 commit)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms/+log/a6f932c91eef..d9500cbd4b35 $ git log a6f932c91..d9500cbd4 --date=short --no-merges --format='%ad %ae %s' 2018-03-13 mtklein impl A2B Created with: roll-dep skia/third_party/externals/skcms The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=jvanverth@google.com Change-Id: Ia291c1bc2612f96bc2d5a34e80437f6483d65fa8 Reviewed-on: https://skia-review.googlesource.com/116201 Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Reland "CreatePlatformGLTestContext_egl: Try GLES 3, then GLES 2."Gravatar Hal Canary2018-03-23
| | | | | | | | | | | | | | | | | | | | | | This is a reland of 0593a840b107c1abd312a03ef4000ddb58454f94 New functionality (which doesn't work everywhere) is behind a flag: GR_EGL_TRY_GLES3_THEN_GLES2. Original change's description: > CreatePlatformGLTestContext_egl: Try GLES 3, then GLES 2. > > Also cleanup. > > Change-Id: I186a7d7f509bc7852241c083414495b6182b916c > Reviewed-on: https://skia-review.googlesource.com/115922 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Hal Canary <halcanary@google.com> Change-Id: I362079dee9c74f1a2c31d935bcb821201a413923 Reviewed-on: https://skia-review.googlesource.com/116143 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Use DAA for small cubics and non-convex paths that fit into a maskGravatar Yuqian Li2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | I forgot to benchmark svgs and it turns out that DAA is specifically good for the small cubics and small non-convex paths in svgs. This should make our svg performance fast again: 2.84% faster in svgparse_Florida-StateSeal.svg_1 2.90% faster in svgparse_NewYork-StateSeal.svg_1 2.95% faster in svgparse_Seal_of_Texas.svg_1 3.05% faster in car.svg_1 3.53% faster in svgparse_Vermont_state_seal.svg_1 3.68% faster in svgparse_Wyoming-StateSeal.svg_1 4.88% faster in svgparse_Minnesota-StateSeal.svg_1 5.22% faster in svgparse_NewMexico-StateSeal.svg_1 6.49% faster in svgparse_fsm.svg_1 Bug: skia: Change-Id: Ia149944443d72c12c3dda178cb5ebc89d6d0bf18 Reviewed-on: https://skia-review.googlesource.com/116185 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Disable DDL assert to unblock ChromeGravatar Robert Phillips2018-03-23
| | | | | | | | | | Chrome is replaying DDLs into FBO 0 which impacts several rendering capabilities. FBO 0-ness of the final destination currently isn't part of SkSurfaceCharacterization so the surface flags aren't being set appropriately for the expected capabilities. Bug: skia:7748 Change-Id: I0d2bf3f689f8f75990443a0d5959f016d16f5d97 Reviewed-on: https://skia-review.googlesource.com/116188 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* [skottie] Clean up SkottiePropertiesGravatar Florin Malita2018-03-23
| | | | | | | | | | | | Split into Adapter and Value CUs. No real changes, just shuffling things around. TBR= Change-Id: I50eaeb3950f4c59e7d7027955b3f49ca2a346e59 Reviewed-on: https://skia-review.googlesource.com/116186 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Fix leak of backend texture in GrContext_maxSurfaceSamplesForColorType testGravatar Brian Salomon2018-03-23
| | | | | | | | Bug: skia:7729 Change-Id: I0e946f15e16a7f4e42d862ac468323f29d65357a Reviewed-on: https://skia-review.googlesource.com/116182 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Add error return, upon mask creation failure, in sw_draw_with_mask_filterGravatar Robert Phillips2018-03-23
| | | | | | | | | Bug: 822680 Change-Id: I7296c5be4faf1f706ad1cc05198559771e324841 Reviewed-on: https://skia-review.googlesource.com/116180 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/skcms/ 2b5c77024..a6f932c91 (1 commit)Gravatar skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://skia.googlesource.com/skcms/+log/2b5c7702441a..a6f932c91eef $ git log 2b5c77024..a6f932c91 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 mtklein prefer A2B1 over A2B0 Created with: roll-dep skia/third_party/externals/skcms The AutoRoll server is located here: https://skcms-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=jvanverth@google.com Change-Id: I7f20e6656001e83e81bfa17fa77bdafe43e5498a Reviewed-on: https://skia-review.googlesource.com/116165 Commit-Queue: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skcms-skia-autoroll <skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert "CreatePlatformGLTestContext_egl: Try GLES 3, then GLES 2."Gravatar Hal Canary2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0593a840b107c1abd312a03ef4000ddb58454f94. Reason for revert: Fails with Nexus7-GPU-Tegra3-arm Original change's description: > CreatePlatformGLTestContext_egl: Try GLES 3, then GLES 2. > > Also cleanup. > > Change-Id: I186a7d7f509bc7852241c083414495b6182b916c > Reviewed-on: https://skia-review.googlesource.com/115922 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Hal Canary <halcanary@google.com> TBR=bsalomon@google.com,halcanary@google.com Change-Id: I5f276a89d1b880212861986b5385e567ac884c62 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/116142 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Revert "Add color fonts."Gravatar Jim Van Verth2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c912d6133c66df7cde3d64adc76941856a12da64. Reason for revert: Causing TSAN issues. Original change's description: > Add color fonts. > > BUG=skia:7624 > > Change-Id: Id2b7449048591892ff802484d5e3745a7e1402bb > Reviewed-on: https://skia-review.googlesource.com/109521 > Commit-Queue: Ben Wagner <bungeman@google.com> > Reviewed-by: Mike Klein <mtklein@google.com> > Reviewed-by: Herb Derby <herb@google.com> TBR=mtklein@google.com,bungeman@google.com,herb@google.com Change-Id: I2ccd1f00e91bb92b7059323c95da0dd3de954164 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7624 Reviewed-on: https://skia-review.googlesource.com/116141 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Roll skia/third_party/externals/angle2/ 068e70308..d779f6a98 (3 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/068e70308fd7..d779f6a98524 $ git log 068e70308..d779f6a98 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 jmadill D3D11: Refactor draw call functions. 2018-03-22 oetuaho Move AST transformations to a subdirectory 2018-03-19 oetuaho Only refer to built-in function mangled names in lookup Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: Ibb66ded655b7fcbe1467af1fa27ccf04a0b1ffb6 Reviewed-on: https://skia-review.googlesource.com/116161 Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert "Remove std::move from GrSimpleTextureEffect"Gravatar Robert Phillips2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0a4b13cdea208946a59c612e0743f28533124166. Reason for revert: incorrect change Original change's description: > Remove std::move from GrSimpleTextureEffect > > Bug:822680 > Change-Id: I4780ce12a6ce244a2165bfb7b293adb06ae577c5 > Reviewed-on: https://skia-review.googlesource.com/115900 > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> TBR=bsalomon@google.com,robertphillips@google.com,ethannicholas@google.com Change-Id: Ib4123d50b02eeac3f5112bf2702b12fc080f0d1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822680 Reviewed-on: https://skia-review.googlesource.com/116140 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ 107c72476..068e70308 (1 commit)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/107c724765a9..068e70308fd7 $ git log 107c72476..068e70308 --date=short --no-merges --format='%ad %ae %s' 2018-03-22 ynovikov Make infra.cq to point to new Android configs. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I17e279b4e9991889d5348089453f26419502eca5 Reviewed-on: https://skia-review.googlesource.com/116121 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* Revert "back to individual flags for :hsw"Gravatar Mike Klein2018-03-23
| | | | | | | | | | | | | | | | | | | | | | | This reverts commit 17c1cd4d55e3a7edd988ba0aec3eb54df2581e3e. Reason for revert: good to try again. Original change's description: > back to individual flags for :hsw > > We still have some bots that use GCC 4.8 that don't understand > -march=haswell. I hope to fix that, then revert this. > > Change-Id: I8ba99d7170d00945e07da33b893a63981b64f5ca > Reviewed-on: https://skia-review.googlesource.com/115761 > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> Change-Id: Ib7b970a2987a69e4c12b2284e1f983f584bca076 Reviewed-on: https://skia-review.googlesource.com/116100 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* update Ubuntu14 CT bots to ClangGravatar Mike Klein2018-03-22
| | | | | | | | | | To run on these older bots, looks like we need to statically link libstdc++ and libgcc. Luckily that is straightforward. Change-Id: If523067df196e943c2ba2f64c52eea0711dbfcbd Reviewed-on: https://skia-review.googlesource.com/115743 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Remove SkAutoGlyphCache decls that happen to workGravatar Herb Derby2018-03-22
| | | | | | | | | | ...and fix sample code. Change-Id: I673770125064f8451e3d88ec4929a68409935ad1 Reviewed-on: https://skia-review.googlesource.com/115995 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Add color fonts.Gravatar Ben Wagner2018-03-22
| | | | | | | | | | BUG=skia:7624 Change-Id: Id2b7449048591892ff802484d5e3745a7e1402bb Reviewed-on: https://skia-review.googlesource.com/109521 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Reviewed-by: Herb Derby <herb@google.com>
* BUILD: build when !skia_use_expatGravatar Hal Canary2018-03-22
| | | | | | | Change-Id: I17a695c64be0e2081ad4937b23038b7ce88ae293 Reviewed-on: https://skia-review.googlesource.com/115988 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com>
* Upload cipd package for Node.Gravatar Joe Gregorio2018-03-22
| | | | | | | | Bug: skia: Change-Id: Ie72dee00c5160ce329c74a12d64bc68ce264c1bf Reviewed-on: https://skia-review.googlesource.com/115990 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* Remove std::move from GrSimpleTextureEffectGravatar Robert Phillips2018-03-22
| | | | | | | | | Bug:822680 Change-Id: I4780ce12a6ce244a2165bfb7b293adb06ae577c5 Reviewed-on: https://skia-review.googlesource.com/115900 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* tests/ImageTest: fail gracefullyGravatar Hal Canary2018-03-22
| | | | | | | Change-Id: Ib3bca9d1cfda17d3b63afb7d54a14ea8e6094ac1 Reviewed-on: https://skia-review.googlesource.com/115986 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* CreatePlatformGLTestContext_egl: Try GLES 3, then GLES 2.Gravatar Hal Canary2018-03-22
| | | | | | | | | Also cleanup. Change-Id: I186a7d7f509bc7852241c083414495b6182b916c Reviewed-on: https://skia-review.googlesource.com/115922 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Always validate GrBackendTextures passed to YUV image factoriesGravatar Brian Salomon2018-03-22
| | | | | | | Change-Id: I73a301fcdf13fceb82c94b0c68ac9386aa38e16d Reviewed-on: https://skia-review.googlesource.com/115126 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* GrGLES Interface: GL_OES_vertex_array_object extGravatar Hal Canary2018-03-22
| | | | | | | Change-Id: I712ec637b5699587a77ab4a6cd48784df075d8c5 Reviewed-on: https://skia-review.googlesource.com/115933 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Roll skia/third_party/externals/angle2/ 8b92c53b8..107c72476 (2 commits)Gravatar angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com2018-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/8b92c53b8a8c..107c724765a9 $ git log 8b92c53b8..107c72476 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 oetuaho ShaderVariable: separate fields for staticUse and active 2018-03-16 oetuaho Move AST utilities to a subdirectory Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=jvanverth@google.com Change-Id: I90ecd1f2439154385ee6447124fe28fffb8e1cf5 Reviewed-on: https://skia-review.googlesource.com/115980 Commit-Queue: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
* lock before using fCacheKeys in ~SkImageFilter()Gravatar Mike Klein2018-03-22
| | | | | | | | | | | | | | | | | | No other code can be using an SkImageFilter() while it's being destroyed, so there's not a chance of a race per-se here. But, because we have not acquired fMutex, there is technically a possibility that the destructor sees an outdated version of fCacheKeys, not necessarily reflecting the last change(s) made while another core held the mutex. This is an unlikely case, but it's worth fixing by locking in the destructor. This will always be uncontended, and so very cheap. Bug: skia:7666 Change-Id: I9f705bc6e8e99162b90d59b30b8dd51c4f238970 Reviewed-on: https://skia-review.googlesource.com/115929 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* dm: fix unused-private-field error when skia_use_expat=falseGravatar Hal Canary2018-03-22
| | | | | | | | Change-Id: I309aa420a7900c048c34873ede618f123719823c Reviewed-on: https://skia-review.googlesource.com/115928 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* add repro case for skia:7674Gravatar Mike Klein2018-03-22
| | | | | | | | | | | Nice to have something to trigger this issue. Bug: skia:7674 Change-Id: I653699b82f3a8a4d551f3cd98b6a7e7620c6e035 Reviewed-on: https://skia-review.googlesource.com/115920 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* rm SkTDArray::{Deleter,release()}Gravatar Mike Klein2018-03-22
| | | | | | | | | | These are unused, and would make it conceptually tricky to replace with something like std::vector that does not have a .release() method. Change-Id: Iaee913d6a513d078989166c6e97097eeec0100ba Reviewed-on: https://skia-review.googlesource.com/115921 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* [sksg] Simplify TrimEffectGravatar Florin Malita2018-03-22
| | | | | | | | | | | | Move the Lottie-specific bits to Skottie and keep TrimEffect as a thin SkTrimPathEffect wrapper. TBR= Change-Id: Iecc6624d01ba61eb96a2056ef8e9e24e731f8979 Reviewed-on: https://skia-review.googlesource.com/115923 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Remove the last uses of auto glyph cache.Gravatar Herb Derby2018-03-22
| | | | | | | Change-Id: I15fdc5bbe29aaa969fe6ec57010919b52249fd7f Reviewed-on: https://skia-review.googlesource.com/115886 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Better decisions about choosing AAA versus DAAGravatar Yuqian Li2018-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Chrome perf regressions (817942, 819185) are caused by the bad choices to use DAA instead of AAA for stroking simple curves. (BTW, in my tests, DAA is still faster than SAA so it's not too much of a regression.) We previously only considered the number of line segments, but not the length of each segment. That leads to our wrong judgement of the path complexity (the number of intersections per scan line) when there are many short line segments. The change will bring the following performance change to our nanobench: 8.45% slower in clip_strategy_path_10 8.39% slower in draw_stroke_bezier_quad_square_bevel_10 3.91% slower in chart_aa 3.76% faster in lines 6.29% faster in path_stroke_big_oval 22.81% faster in path_stroke_big_circle 24.44% faster in giantdashline_vert_2 The two slower cases, clip_strategy_path_10 and draw_stroke_bezier_quad_square_bevel_10 are caused by choosing AAA over DAA. Those two tests do seem to be simple strokes. I'll later investigate why AAA is slower than DAA for those two cases. For now, I think that this change is sufficient to address those chromium perf regresssions. Bug: chromium:817942 chromium:819185 Change-Id: I1d13c968b17f257b4ede4c70e552db5016baf1ab Reviewed-on: https://skia-review.googlesource.com/115583 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* Reland "Remove legacy precision boundary"Gravatar Yuqian Li2018-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit dab15f7a02ddaa2a6977a14d5d04955bd39350ab. Reason for revert: the Android roll is broken by something else: b/76126268 Original change's description: > Revert "Remove legacy precision boundary" > > This reverts commit a2513c14c4e143984b2eec07f5263b5cdc6c84bb. > > Reason for revert: This is breaking the Android roll. > > Original change's description: > > Remove legacy precision boundary > > > > Bug: skia:7731 > > Change-Id: I86a87b960541c2bc7b099ca9f609342cb0bbf563 > > Reviewed-on: https://skia-review.googlesource.com/115652 > > Reviewed-by: Cary Clark <caryclark@google.com> > > Commit-Queue: Yuqian Li <liyuqian@google.com> > > TBR=caryclark@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com > > Change-Id: I45b14f5a84e97cc1022b99c414f90126d368f598 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:7731 > Reviewed-on: https://skia-review.googlesource.com/115840 > Reviewed-by: Derek Sollenberger <djsollen@google.com> > Commit-Queue: Derek Sollenberger <djsollen@google.com> TBR=djsollen@google.com,caryclark@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: I5d957cb7be9cc578672079e98ab5e131ad249f70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7731 Reviewed-on: https://skia-review.googlesource.com/115940 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Support GL_RGB textures and render targets.Gravatar Brian Salomon2018-03-22
| | | | | | | | | Bug= skia:7533 Change-Id: Iba30e90dbf2574368b773bb5cf2ebd5219559717 Reviewed-on: https://skia-review.googlesource.com/108188 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* switched SPIR-V vertexid to vertexindexGravatar Ethan Nicholas2018-03-22
| | | | | | | | Bug: skia: Change-Id: I32c10e2874feea63d7fa048057ef57e27d5874bc Reviewed-on: https://skia-review.googlesource.com/115880 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Revert "Remove legacy precision boundary"Gravatar Derek Sollenberger2018-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a2513c14c4e143984b2eec07f5263b5cdc6c84bb. Reason for revert: This is breaking the Android roll. Original change's description: > Remove legacy precision boundary > > Bug: skia:7731 > Change-Id: I86a87b960541c2bc7b099ca9f609342cb0bbf563 > Reviewed-on: https://skia-review.googlesource.com/115652 > Reviewed-by: Cary Clark <caryclark@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=caryclark@google.com,fmalita@chromium.org,liyuqian@google.com,reed@google.com Change-Id: I45b14f5a84e97cc1022b99c414f90126d368f598 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7731 Reviewed-on: https://skia-review.googlesource.com/115840 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* update SkIRect centerx centery docsGravatar Cary Clark2018-03-22
| | | | | | | | | | | R=caryclark@google.com Docs-Preview: https://skia.org/?cl=115820 Bug: skia:6898 Change-Id: I1d3c32d40ed4000f060a535cbcd20b39d0ff9fc3 Reviewed-on: https://skia-review.googlesource.com/115820 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>