aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Finish rebase from df and add baseline images for n10 debugGravatar egdaniel2014-11-07
| | | | | | | | TBR=jvanverth@google.com BUG=skia: Review URL: https://codereview.chromium.org/705353003
* cleaning up geometry handling in gpuGravatar joshualitt2014-11-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/707953004
* Rebaseline s4 gmsGravatar egdaniel2014-11-07
| | | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/712693002
* Update GrTRecorder to preserve memory allocationsGravatar cdalton2014-11-07
| | | | | | | | | | | | Rather than freeing almost all of its memory on calls to reset(), this change updates GrTRecorder so it keeps around enough to satisfy the storage requirements from last time, plus up to ~50% growth. This is based on the assumption that subsequent draw calls require roughly the same amount of memory. BUG=skia: Review URL: https://codereview.chromium.org/684203003
* Revert of SkDrawCommand scrubbing (patchset #2 id:20001 of ↵Gravatar fmalita2014-11-07
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/706363002/) Reason for revert: Canary borkage. Original issue's description: > SkDrawCommand scrubbing > > Remove unused ctor, constify, etc. > > R=robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/1931ec5b5dac68f1e452af0c65161bdce35b2dec TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/712683002
* SkDrawCommand scrubbingGravatar fmalita2014-11-07
| | | | | | | | Remove unused ctor, constify, etc. R=robertphillips@google.com Review URL: https://codereview.chromium.org/706363002
* Revert of Default geometry processor (patchset #9 id:160001 of ↵Gravatar joshualitt2014-11-07
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/678953002/) Reason for revert: breaks nexus 5 Original issue's description: > Default geometry processor > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ff343074b2a3fdaa5f120600e28717e366bceadd TBR=bsalomon@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/691313003
* Default geometry processorGravatar joshualitt2014-11-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/678953002
* add patch and clicktracking to luaGravatar reed2014-11-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/712613002
* One more attempt at rebaseliningGravatar jvanverth2014-11-07
| | | | | | | TBR=egdaniel@google.com NOTREECHECKS=true Review URL: https://codereview.chromium.org/708903006
* Mesa ES 3.0 requires sized internal formatsGravatar derekf2014-11-07
| | | | | | | Mesa's ES 3.0 implementation requires GL_R8 as an internal format instead of GL_RED Review URL: https://codereview.chromium.org/705183002
* Missed some expectationsGravatar jvanverth2014-11-07
| | | | | | TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/705293002
* Refactor DrawTarget and GPU to be independentGravatar joshualitt2014-11-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/705593002
* Rebaseline for https://codereview.chromium.org/703463002/.Gravatar jvanverth2014-11-07
| | | | | | TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/709043002
* document the SkStrAppend methodsGravatar reed2014-11-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/709063002
* Get gpudft support working in dm, gm, nanobench and bench_picturesGravatar jvanverth2014-11-07
| | | | | | | | | | | | Adds a new config to test distance field text. Clean up some flags and #defines to read "distance field text", not "distance field fonts" to be consistent with Chromium NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/06ba179838ba4fe187cf290750aeeb4a02a2960b Review URL: https://codereview.chromium.org/699453005
* Update SKP versionGravatar skia.buildbots2014-11-07
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/693583003
* Cleanup: Use SkAutoGraphics in gm and tests.Gravatar tfarina2014-11-07
| | | | | | | BUG=None R=bsalomon@google.com Review URL: https://codereview.chromium.org/704413002
* When running DM, write test failures to json.Gravatar scroggo2014-11-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add skiatest::Failure to keep track of data about a test failure. Reporter::reportFailed and ::onReportFailed now take Failure as a parameter. This allows the implementation to treat the failure as it wishes. Provide a helper to format the failure the same as prior to the change. Update the macros for calling reportFailed (REPORTER_ASSERT etc) to create a Failure object. Convert a direct call to reportFailed to the macro ERRORF. Write Failures to Json. Sample output when running dm on the dummy test crrev.com/705723004: { "test_results" : { "failures" : [ { "condition" : "0 > 3", "file_name" : "../../tests/DummyTest.cpp", "line_no" : 10, "message" : "" }, { "condition" : "false", "file_name" : "../../tests/DummyTest.cpp", "line_no" : 4, "message" : "" }, { "condition" : "1 == 3", "file_name" : "../../tests/DummyTest.cpp", "line_no" : 5, "message" : "I can too count!" }, { "condition" : "", "file_name" : "../../tests/DummyTest.cpp", "line_no" : 6, "message" : "seven is 7" }, { "condition" : "1 == 3", "file_name" : "../../tests/DummyTest.cpp", "line_no" : 14, "message" : "I can too count!" } ] } } Report all of the failures from one test. Previously, if one test had multiple failures, only one was reportered. e.g: Failures: test Dummy: ../../tests/DummyTest.cpp:6 seven is 7 test Dummy2: ../../tests/DummyTest.cpp:10 0 > 3 test Dummy3: ../../tests/DummyTest.cpp:14 I can too count!: 1 == 3 3 failures. Now, we get all the messages: Failures: test Dummy: ../../tests/DummyTest.cpp:4 false ../../tests/DummyTest.cpp:5 I can too count!: 1 == 3 ../../tests/DummyTest.cpp:6 seven is 7 test Dummy2: ../../tests/DummyTest.cpp:10 0 > 3 test Dummy3: ../../tests/DummyTest.cpp:14 I can too count!: 1 == 3 3 failures. (Note that we still state "3 failures" because 3 DM::Tasks failed.) BUG=skia:3082 BUG=skia:2454 Review URL: https://codereview.chromium.org/694703005
* for X in {Dec,BigDec,Scalar}, SkWStream::write"X"AsText no longer mallocsGravatar halcanary2014-11-07
| | | | Review URL: https://codereview.chromium.org/706063002
* Add LOCAL_PICKUP_FILES to dm and bench makefiles.Gravatar scroggo2014-11-07
| | | | | | | | | | | | | | | | | Update the generator to include a line for LOCAL_PICKUP_FILES. When generating makefiles for our tests, they will now have the following line: LOCAL_PICKUP_FILES := \ $(LOCAL_PATH)/../resources This allows testing infrastructure to pick up resource files used by our tests. Update expectations files to test LOCAL_PICKUP_FILES. BUG=skia:2454 Review URL: https://codereview.chromium.org/704393002
* Remove 1d glyph positions from nvpr textGravatar cdalton2014-11-07
| | | | | | | | | | | | | Removes the case for x-only glyph positions from nvpr text, opting to always send 2d glyph positions instead. The 1d glyph positions saved a bit on memory bandwidth, but ended up a net loss because they required more updates to the view matrix. Now we can draw an entire paragraph without touching the GL state, whereas before we would have to update the view matrix at every new line. BUG=skia: Review URL: https://codereview.chromium.org/700283002
* Revert of Get gpudft support working in dm, gm, nanobench and bench_pictures ↵Gravatar jvanverth2014-11-06
| | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/699453005/) Reason for revert: Not compiling in ANGLE build Original issue's description: > Get gpudft support working in dm, gm, nanobench and bench_pictures > > Adds a new config to test distance field text. > Clean up some flags and #defines to read "distance field text", > not "distance field fonts" to be consistent with Chromium > > NOTREECHECKS=true > > Committed: https://skia.googlesource.com/skia/+/06ba179838ba4fe187cf290750aeeb4a02a2960b TBR=bsalomon@google.com,mtklein@google.com,reed@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/707723005
* Get gpudft support working in dm, gm, nanobench and bench_picturesGravatar jvanverth2014-11-06
| | | | | | | | | | Adds a new config to test distance field text. Clean up some flags and #defines to read "distance field text", not "distance field fonts" to be consistent with Chromium NOTREECHECKS=true Review URL: https://codereview.chromium.org/699453005
* Clip in grdrawtargetGravatar joshualitt2014-11-06
| | | | | | | NOTREECHECKS=true BUG=skia: Review URL: https://codereview.chromium.org/685883003
* Revert of Revert of Turn on NVPR 4x MSAA by default when supported in DM and ↵Gravatar mtklein2014-11-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | nanobench. (patchset #1 id:1 of https://codereview.chromium.org/693933004/) Reason for revert: Try again with loops overflow fix landed. Original issue's description: > Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchset #2 id:20001 of https://codereview.chromium.org/704563003/) > > Reason for revert: > Timing out on nvpr when drawing conics. Fix will take some thought so reverting for now. > > Original issue's description: > > Turn on NVPR 4x MSAA by default when supported in DM and nanobench. > > > > This brings DM and nanobench's default configs in line with GM's. > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/31f88675718966bbb7f09718b40de10c7e214739 > > TBR=bsalomon@google.com,mtklein@google.com,mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d5cd4ee5b81b51e43be7ed13f3c0f0f6c1b3fe14 TBR=bsalomon@google.com,mtklein@chromium.org,egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/685923003
* Detect loops overflow for gpu benches.Gravatar mtklein2014-11-06
| | | | | | | | NOTREECHECKS=true BUG=skia: Review URL: https://codereview.chromium.org/709473002
* Send coverage VA as floats instead of bytesGravatar egdaniel2014-11-06
| | | | | | | | NOTREECHECKS=True BUG=skia: Review URL: https://codereview.chromium.org/700943005
* Update SKP versionGravatar skia.buildbots2014-11-05
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/701363002
* Add mock context and use in ResourceCacheTest.Gravatar bsalomon2014-11-05
| | | | | | | | BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/820dd6c335411aad889c1d7e8a857642ecd87e30 Review URL: https://codereview.chromium.org/702083003
* Revert of Turn on NVPR 4x MSAA by default when supported in DM and ↵Gravatar egdaniel2014-11-05
| | | | | | | | | | | | | | | | | | | | | | | nanobench. (patchset #2 id:20001 of https://codereview.chromium.org/704563003/) Reason for revert: Timing out on nvpr when drawing conics. Fix will take some thought so reverting for now. Original issue's description: > Turn on NVPR 4x MSAA by default when supported in DM and nanobench. > > This brings DM and nanobench's default configs in line with GM's. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/31f88675718966bbb7f09718b40de10c7e214739 TBR=bsalomon@google.com,mtklein@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/693933004
* Revert of Add mock context and use in ResourceCacheTest. (patchset #4 ↵Gravatar bsalomon2014-11-05
| | | | | | | | | | | | | | | | | | | | | id:60001 of https://codereview.chromium.org/702083003/) Reason for revert: Breaking tests Original issue's description: > Add mock context and use in ResourceCacheTest. > > BUG=skia:2889 > > Committed: https://skia.googlesource.com/skia/+/820dd6c335411aad889c1d7e8a857642ecd87e30 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2889 Review URL: https://codereview.chromium.org/704563004
* Turn on NVPR 4x MSAA by default when supported in DM and nanobench.Gravatar mtklein2014-11-05
| | | | | | | | This brings DM and nanobench's default configs in line with GM's. BUG=skia: Review URL: https://codereview.chromium.org/704563003
* Add mock context and use in ResourceCacheTest.Gravatar bsalomon2014-11-05
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/702083003
* S4 RebaselinesGravatar bsalomon2014-11-05
| | | | | | TBR= Review URL: https://codereview.chromium.org/706653003
* Avoid dec = -dec overflow when appending most negative signed integers.Gravatar mtklein2014-11-05
| | | | | | BUG=skia:3096 Review URL: https://codereview.chromium.org/700953003
* Add new baselines for remaining dashing5 GM imagesGravatar robertphillips2014-11-05
| | | | | | | | | | This are the baselines for the problem children: The N5 & N10 gpu images related to Issue 3097 The perspective Windows images TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/702143002
* Remove gm from ignore expectation fileGravatar egdaniel2014-11-05
| | | | | | | | | | | No gm's actually changed from my recent change to dashing gm. This was the desired outcome since the added calls were lines of length zero TBR=robertphillips@google.com BUG=skia: Review URL: https://codereview.chromium.org/706633002
* Add baselines for the new dashing5 GMGravatar robertphillips2014-11-05
| | | | | | | | These are all the correct images TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/707513002
* Add unit test for SkDashPathEffect::asPoints' cullingGravatar robertphillips2014-11-05
| | | | | | This is a follow on to (Crop the fast path dashed lines to the cull rect - https://codereview.chromium.org/699623003/) Review URL: https://codereview.chromium.org/701133002
* Whitelist intentionally racy TRACE_EVENT reads and writes.Gravatar mtklein2014-11-05
| | | | | | | | | | | | | | | | | | | | Chrome's tracing framework appears to be intentionally racy on its quick-reject checks, trading some data loss for better performance when disabled. People will never notice the data loss, but TSAN does. Let's assuage TSAN with some annotations. The 'volatile' val in SK_ANNOTATE_UNPROTECTED_WRITE was making this not compile, but that volatile doesn't really make sense there: the value we're writing is not what we care about, it's the destination. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot No API changes. TBR=reed BUG=skia: Review URL: https://codereview.chromium.org/702883002
* Revert of Bisect Mac performance regression. (patchset #6 id:100001 of ↵Gravatar egdaniel2014-11-05
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/693213002/) Reason for revert: Block deps roll by breaking webkit test hit-test-counts on mac. Original issue's description: > With https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance. > > BUG=chromium:425566 > > Committed: https://skia.googlesource.com/skia/+/47eda52e8fb88f0725b401762a3e0bddc98e9fb3 TBR=reed@google.com,bungeman@google.com NOTREECHECKS=true NOTRY=true BUG=chromium:425566 Review URL: https://codereview.chromium.org/683753003
* Cleanup: Remove unused InstallNewHandler() function from SkGraphics.Gravatar tfarina2014-11-05
| | | | | | | | BUG=None TEST=None R=bsalomon@google.com Review URL: https://codereview.chromium.org/701813006
* Workaround for PowerVR clear issue.Gravatar bsalomon2014-11-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/701573002
* Add suppression to valgrind.supp for fun:FcConfigEvaluate.Gravatar bungeman2014-11-05
| | | | | | | Any allocation under FcConfigValues will be 'lost'. Update the valgrind suppression to reflect this. Review URL: https://codereview.chromium.org/703893003
* Bug fix for cull_line in SkDashPathEffect.Gravatar egdaniel2014-11-05
| | | | | | | | | | | In cull_line we must also check if both points are the same. Otherwise we fail the assert in the else "SkASSERT(dy && !dx)". This is currently blocking the roll as it fails a webkit test. BUG=skia: Review URL: https://codereview.chromium.org/703783002
* Crop the fast path dashed lines to the cull rectGravatar robertphillips2014-11-04
| | | | | | | | | | | | | | | | | | | | | | | Without: maxrss loops min median mean max stddev samples config bench 56M 1 13.3ms 13.6ms 13.6ms 14.2ms 2% Ooooo..... 8888 GM_dashing5_bw 56M 13 390us 417us 416us 459us 5% ooooO..o.o gpu GM_dashing5_bw 56M 1 13.4ms 13.9ms 14.1ms 15ms 3% Oooo..ooOo 8888 GM_dashing5_aa 56M 13 402us 421us 416us 425us 2% Ooo.ooOOOO gpu GM_dashing5_aa With: 40M 1 1.53ms 1.54ms 1.54ms 1.55ms 0% oo.O...o.. 8888 GM_dashing5_bw 40M 12 407us 412us 415us 445us 3% ...Oo..... gpu GM_dashing5_bw 40M 1 1.7ms 1.7ms 1.7ms 1.72ms 0% o.O....... 8888 GM_dashing5_aa 43M 13 405us 409us 409us 415us 1% ooo.Ooo..o gpu GM_dashing5_aa The GM images (including the new one) are the same with and without this CL. BUG=428296 Review URL: https://codereview.chromium.org/699623003
* DFText: fix placement of glyphs when we fall back to pathsGravatar jvanverth2014-11-04
| | | | | | | | Rendering a glyph with a path wants to place it at the (sx, sy) we get as input to the method, but we add (dx, dy) for the clipRect check. Hence, we need to subtract that out before we render the path. Review URL: https://codereview.chromium.org/699283003
* update slidesGravatar reed2014-11-04
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/686853005
* Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe ↵Gravatar piotaixr2014-11-04
| | | | | | | | | | | | | | | | | | | | | | (patchset #8 id:140001 of https://codereview.chromium.org/613673005/) Reason for revert: The patch is breaking the telemetry blink build on some windows configurations Original issue's description: > Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe > > Depend on https://codereview.chromium.org/663233002 > > BUG=skia:2947 > > Committed: https://skia.googlesource.com/skia/+/687732fe046c9cfec940f2d7f661cd97651d10a8 > > Committed: https://skia.googlesource.com/skia/+/9bb7539a59ab15749fe26fecfec05330cffae684 BUG=skia:2947, 426708 Review URL: https://codereview.chromium.org/705633002
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-15 15:34:09 +0000