aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* RecreateSKPs: Fix GoogleStorageDataStore.delete_pathGravatar borenet2016-10-17
| | | | | | | BUG=skia:5843 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2423093002 Review-Url: https://codereview.chromium.org/2423093002
* Cache dst LUTs in SkColorSpaceXformGravatar Matt Sarett2016-10-16
| | | | | | | | | | | | | | | | | | | | | | This is only useful in the rare case that the dst does not fall into one of our main paths. But it's a good optimization, since this does happen, and typically, the dst won't change. ColorCodecBench z620 --nonstd --xform_only Without Patch 511us With Patch 348us BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3400 Change-Id: Ibf68d9ce7072680465662922f4aa15630545e3d6 Reviewed-on: https://skia-review.googlesource.com/3400 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* update GN docsGravatar Mike Klein2016-10-15
| | | | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3425 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=3425 Change-Id: Iafd5a7b9feca6855d595f9ecbc05292a924e00e4 Reviewed-on: https://skia-review.googlesource.com/3425 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Put all Win bots on GN except -ANGLE bots.Gravatar Mike Klein2016-10-15
| | | | | | | | | | | Not quite there yet for ANGLE. The rest should be good to go. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3424 Change-Id: I9d6ad1de75bb0d9c1e18a9220a7ca82c84f74235 Reviewed-on: https://skia-review.googlesource.com/3424 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Unbreak -Fast bot.Gravatar Mike Klein2016-10-15
| | | | | | | | | | | CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3423 Change-Id: I1875c86b785da4483038c10715af7827b7d71f0b Reviewed-on: https://skia-review.googlesource.com/3423 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkNx_abi for passing Sk4f as function arguments, etc.Gravatar Mike Klein2016-10-15
| | | | | | | | | | | | CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3422 Change-Id: Idc0a192faa7ff843aef023229186580c69baf1f7 Reviewed-on: https://skia-review.googlesource.com/3422 Reviewed-by: Mike Klein <mtklein@chromium.org>
* Wrap SkNx types in anonymous namespace again.Gravatar Mike Klein2016-10-14
| | | | | | | | | | | | | | | | | | | | | This should make each compilation unit's SkNx types distinct from each other's as far as C++ cares. This keeps us from violating the One Definition Rule with different implementations for the same function. Here's an example I like. Sk4i SkNx_cast(Sk4b) has at least 4 different sensible implementations: - SSE2: punpcklbw xmm, zero; punpcklbw xmm, zero - SSSE3: load mask; pshufb xmm, mask - SSE4.1: pmovzxbd - AVX2: vpmovzxbd We really want all these to inline, but if for some reason they don't (Debug build, poor inliner) and they're compiled in SkOpts.cpp, SkOpts_ssse3.cpp, SkOpts_sse41.cpp, SkOpts_hsw.cpp... boom! BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3461 Change-Id: I0088ebfd7640c1b0de989738ed43c81b530dc0d9 Reviewed-on: https://skia-review.googlesource.com/3461 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Rework GL fbo blit limitations as finer grained flags.Gravatar Brian Salomon2016-10-14
| | | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3480 BUG=skia:5804 Change-Id: Idd86f96a92420ec98c7cf07962f4857e0b81b9c6 Reviewed-on: https://skia-review.googlesource.com/3480 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Fix bad test that was asserting on Vulkan Win10 botGravatar Brian Osman2016-10-14
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3504 Change-Id: Ifd1280402e6701e940c325654a8e9968b1b42065 Reviewed-on: https://skia-review.googlesource.com/3504 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* GN/Win: Vulkan support, convert -Vulkan bots.Gravatar Mike Klein2016-10-14
| | | | | | | | | | | CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86_64-Release-Vulkan-Trybot;master.client.skia:Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan-Trybot,Perf-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Release-Vulkan-Trybot,Perf-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3421 Change-Id: I7012719fff66778488589ab9c15fd2fa2a109cd1 Reviewed-on: https://skia-review.googlesource.com/3421 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Capture ES3 MSAA blit restrictions using BlitFramebufferSupport not MSFBOType.Gravatar Brian Salomon2016-10-14
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3416 Change-Id: I2baeb954bceb9d92e43e585320ae5fda1b996641 Reviewed-on: https://skia-review.googlesource.com/3416 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Disable ANGLE GL backed on windows perf botsGravatar Brian Salomon2016-10-14
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3501 Change-Id: I0e3a166cd07560501cb350b780e264c274c81601 Reviewed-on: https://skia-review.googlesource.com/3501 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* another SkSL crash fixGravatar ethannicholas2016-10-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2420163002 Review-Url: https://codereview.chromium.org/2420163002
* Refactor color_xform_RGBA() to improve performanceGravatar Matt Sarett2016-10-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we've identified this as the "fast path", it has become (somewhat) stable, and I'm ready to ship it, I feel comfortable playing games with clang to get the behavior we want. toSRGB Performance on HP z620: Before: 370us or 470us (depending on the mood of my computer) After: 345us (or better, always) My guess is that clang optimizers do a better job of interleaving instructions effectively when we put everything into one function. Regardless of being silly about performance, I also acutally prefer how the code reads this way. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3440 Change-Id: Id7a40fb9966341ab184a5331b3e4da19b3af3344 Reviewed-on: https://skia-review.googlesource.com/3440 Commit-Queue: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Revert of Presubmit recipe: commit the patch (patchset #3 id:40001 of ↵Gravatar borenet2016-10-14
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2398653002/ ) Reason for revert: Instead of trying to run the presubmit for try jobs and at every commit, let's do it only for try jobs, which worked fine without this CL. Original issue's description: > Presubmit recipe: call presubmit_support.py directly > > For some reason, presubmit_support.py can't find PRESUBMIT.py > unless it has a diff. Calling this script directly allows us > to specify a fake upstream to force it to find a diff and > therefore be able to find PRESUBMIT.py. > > BUG=skia:5823 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2398653002 > > Committed: https://skia.googlesource.com/skia/+/c1c7c21fdd2793b2c03b8ffc06461a00c4241a18 TBR=rmistry@google.com,borenet@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia:5823 Review-Url: https://codereview.chromium.org/2414133003
* more SkSL fuzzer crash fixesGravatar ethannicholas2016-10-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2414413002 Review-Url: https://codereview.chromium.org/2414413002
* Always use RGBA textures for color font atlasesGravatar Brian Osman2016-10-14
| | | | | | | | | | | | | This is the last use of kSkiaGamma8888_GrPixelConfig BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3417 Change-Id: I307479c41f1ca437733dfafd044bb1baeb42f31d Reviewed-on: https://skia-review.googlesource.com/3417 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* fix skslc crashes uncovered by fuzz testingGravatar ethannicholas2016-10-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2413423003 Review-Url: https://codereview.chromium.org/2413423003
* Faster 4f gradient premul pathGravatar fmalita2016-10-14
| | | | | | | | | | | | | | Similar to https://codereview.chromium.org/2409583003/, perform the premul in 4f. It turns out it's even faster to avoid the 255 load multiplication in this case. Also includes some template plumbing because DstTraits<>::load now needs to be premul-aware (previously it wasn't). R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2416233002 Review-Url: https://codereview.chromium.org/2416233002
* Explicit control in tools of ANGLE frontend and backendGravatar bsalomon2016-10-14
| | | | | | | | | | | | | | | Update the ANGLE test GL context, GrContextFactory, and config parsing to allow explicit control of ANGLE front/backend. This will allow us to explicitly test ES2 vs ES3 interfaces to ANGLE as well as D3D9, D3D11, and OpenGL backends. Also makes the angle api types valid in all builds (but will just fail when SK_ANGLE=1 or not on windows for the d3d backends). BUG=skia:5804 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381033002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE-Trybot Review-Url: https://codereview.chromium.org/2381033002
* Remove many uses of kSkia8888 and kSkiaGamma8888Gravatar Brian Osman2016-10-14
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3405 Change-Id: Ie920f4bcbb3dd28114a66f2363643bb10009b840 Reviewed-on: https://skia-review.googlesource.com/3405 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Update CQ_INCLUDE_TRYBOTS examples in docs to actually be "real world"Gravatar Brian Salomon2016-10-14
| | | | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3409 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=3409 Change-Id: I5f524b2d04822dd9780302fae9bd064d81f10c6c Reviewed-on: https://skia-review.googlesource.com/3409 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Move skdiff tool and add to gn build.Gravatar bungeman2016-10-14
| | | | | | | | | I really wanted this today, so I got it working again. Change-Id: I1a37d48d4806198b55c59d1df5ff15a03500195f Reviewed-on: https://skia-review.googlesource.com/3383 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Add NewRGB() with float gamma to SkColorSpace public APIGravatar Matt Sarett2016-10-14
| | | | | | | | | | | | | Necessary because PNGs like to specify their gamma this way. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3402 Change-Id: I399984d611db907b115b345df1afc88d39326fbb Reviewed-on: https://skia-review.googlesource.com/3402 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Add support for Atrace and hook into SkEventTracer framework.Gravatar Greg Daniel2016-10-14
| | | | | | | | | | | | | | | This change is a different version of: https://skia-review.googlesource.com/c/3269/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3345 Change-Id: I49d4f2987740d3ad1307f6aba3add0d63a46b22d Reviewed-on: https://skia-review.googlesource.com/3345 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Greg Daniel <egdaniel@google.com>
* added SkSL support for mustForceNegatedAtanParamToFloat capGravatar ethannicholas2016-10-14
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2413363002 Review-Url: https://codereview.chromium.org/2413363002
* Add infra_tests.py, recipe, buildbotless botGravatar borenet2016-10-14
| | | | | | | | | Have the presubmit (upload) run infra_tests.py if anything in infra/ changed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002 Review-Url: https://codereview.chromium.org/2415193002
* experimental: xps_to_png program (windows only)Gravatar Hal Canary2016-10-14
| | | | | | | | | BUG=skia:409 NOTRY=true Change-Id: Ib0df603535de71b0a324808c17e47691435df666 Reviewed-on: https://skia-review.googlesource.com/3342 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* GN/Win: hook in GPU supportGravatar Mike Klein2016-10-13
| | | | | | | | | | | | Just a simple oversight... this should make Ganesh work. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3382 Change-Id: I90353732a137d004b884cea75f1bd722ede24888 Reviewed-on: https://skia-review.googlesource.com/3382 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* GN/Win: suppport GDI, convert GDI bots to build with GN.Gravatar Mike Klein2016-10-13
| | | | | | | | | | | CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-GDI-Trybot,Build-Win-MSVC-x86-Release-GDI-Trybot;master.client.skia:Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug-GDI-Trybot,Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Release-GDI-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3324 Change-Id: I3ff2f5d16de9fff7ed77fa5127b96bef55bef957 Reviewed-on: https://skia-review.googlesource.com/3324 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Slightly generalize GPU hard stop gradient implementation.Gravatar Brian Salomon2016-10-13
| | | | | | | | | | | | | | With this CL we handle single off-center hardstop gradients. BUG=chromium:543625 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3303 Change-Id: Ic754e87469475ce15865c54055b8ed492e1d826d Reviewed-on: https://skia-review.googlesource.com/3303 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* added basic dataflow analysis to skslcGravatar ethannicholas2016-10-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2405383003 Review-Url: https://codereview.chromium.org/2405383003
* Allow F16 color type on direct raster canvasesGravatar junov2016-10-13
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2416063002 Review-Url: https://codereview.chromium.org/2416063002
* remove SkErrorGravatar Mike Klein2016-10-13
| | | | | | | | | | | | | It has not caught on. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3321 Change-Id: Ib2ee4ef99bc89c8f4b7504e42a9d7d9dfc483015 Reviewed-on: https://skia-review.googlesource.com/3321 Reviewed-by: Leon Scroggins <scroggo@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Add timestamp to bot ninja output.Gravatar Mike Klein2016-10-13
| | | | | | | | | | | The default NINJA_STATUS format is "[%f/%t] ". This prepends %e to help diagnose slow builds. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3323 Change-Id: Ied27317cedc2b07ff57c59eae61fe9e86c7fea33 Reviewed-on: https://skia-review.googlesource.com/3323 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com>
* GN/Win: quieter buildsGravatar Mike Klein2016-10-13
| | | | | | | | | | | | It's hard to read the logs as they are now. This simplifies down the descriptions, and stifles a warning about linking object files with no symbols into a static library. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3322 Change-Id: I52beb3b8405ebb2c370cad432669834b64baa840 Reviewed-on: https://skia-review.googlesource.com/3322 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Workaround unreachable code warning in GrGLCapsGravatar Brian Salomon2016-10-13
| | | | | | | | | | | BUG=skia:5833 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3179 Change-Id: I0b5ba57e533280e85b3672f476017dc12aefbbe5 Reviewed-on: https://skia-review.googlesource.com/3179 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Removed makeLinearGamma() from the public API for SkColorSpaceGravatar raftias2016-10-13
| | | | | | | | | | | | | | | It will now reside in SkColorSpace_Base. Future work for SkColorSpace will cause this function to not be desirable or sensible to call on all SkColorSpaces. Call sites were changed to make a kSRGBLinear_Named instead of kSRGB_Named -> makeLinearGamma() (the majority of cases), and if that was not possible, SkColorSpace_Base::makeLinearGamma() was called instead. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2412613005 Review-Url: https://codereview.chromium.org/2412613005
* Remove SK_SUPPORT_LEGACY_TEXTBLOB_BUILDER.Gravatar Ben Wagner2016-10-13
| | | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2988 Change-Id: Ib39913a67cdd05662e7a91b4f05fbe5429eb0c42 Reviewed-on: https://skia-review.googlesource.com/2988 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* GN/Win: pass /DEBUG to linker to get debug symbols.Gravatar Mike Klein2016-10-13
| | | | | | | | | | | | | Not much used for debug symbols if they're not linked in. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3320 Change-Id: I506ae624ec412d4151a025879a5dd14d90183bd8 Reviewed-on: https://skia-review.googlesource.com/3320 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Stop rebooting Android devices during Swarming tasksGravatar borenet2016-10-13
| | | | | | | | | Swarming will reboot the devices after each task. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2402403002 Review-Url: https://codereview.chromium.org/2402403002
* [task scheduler] Trybots assume rietveld for nowGravatar borenet2016-10-13
| | | | | | | | | | Eventually we'll switch to gerrit-only. Supporting both will probably be more complicated than it's worth. BUG=skia:5723 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2413653005 Review-Url: https://codereview.chromium.org/2413653005
* SkXPS: compile under clang on winGravatar halcanary2016-10-13
| | | | | | | BUG=chromium:616763 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2408133006 Review-Url: https://codereview.chromium.org/2408133006
* Output location of rankings CSV and a link to download SKPs by rankGravatar Ravi Mistry2016-10-13
| | | | | | | | | | | | | Example run: https://luci-milo.appspot.com/swarming/task/31cdda8d5cb95310 BUG=skia:5826 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3173 Change-Id: I56f4143e919f4328d0f573e8a4a4321eceb8564a Reviewed-on: https://skia-review.googlesource.com/3173 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Revert of leave pixel memory uninitialized for opaque alpha type in ↵Gravatar mtklein2016-10-13
| | | | | | | | | | | | | | | | | | | | | | | | SkSurface::MakeRaster (patchset #1 id:1 of https://codereview.chromium.org/2412633002/ ) Reason for revert: Reverting while we think about skia:5854 so the bot doesn't regress further. Original issue's description: > leave pixel memory uninitialized for opaque alpha type in SkSurface::MakeRaster > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2412633002 > > Committed: https://skia.googlesource.com/skia/+/c64ef3563dc8badac3d64544513b03df826cf8c3 TBR=mtklein@chromium.org,bsalomon@google.com,reed@google.com,lsalzman@mozilla.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5854 Review-Url: https://codereview.chromium.org/2421473003
* Preserve color space of images in deferred texture APIGravatar brianosman2016-10-13
| | | | | | | | | | | | | For raster images, this already worked (we were peeking the pixmap's info). But for generated images, we discarded format and color space information. Fixes an error with the deferred GMs in sRGB modes, and also should help the Chrome color correctness work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2416453004 Review-Url: https://codereview.chromium.org/2416453004
* Recipe fixes to support try jobs in task schedulerGravatar borenet2016-10-13
| | | | | | | BUG=skia:5723 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2410843002 Review-Url: https://codereview.chromium.org/2410843002
* GN/Win: warnings and warn-as-errorGravatar Mike Klein2016-10-13
| | | | | | | | | | | CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3258 Change-Id: Ia2b85904bed1e6ca72c68abaecf6c2854795342c Reviewed-on: https://skia-review.googlesource.com/3258 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* GN: naive attempt for 32-bit Windows supportGravatar Mike Klein2016-10-13
| | | | | | | | | | | | | | This uses the win_toolchain's SetEnv.cmd script to set up the environment for x86 builds. Some of what it sets is redundant with what we set: include_dirs (INCLUDE), lib_dirs (LIB). I'd sort of like to learn what parts of it actually matter: VSINSTALLDIR? VCINSTALLDIR? likely PATH? This will not work for local builds not using win_toolchain. I don't mind that too much, at least for now, maybe forever. Most humans should be using 64-bit builds. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot,Build-Win-MSVC-x86_64-Debug-GN-Trybot,Build-Win-MSVC-x86_64-Release-GN-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3257 Change-Id: Ib880fb738bc4b493e8905903706526110213be47 Reviewed-on: https://skia-review.googlesource.com/3257 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* GN: take over Windows -Exceptions bot.Gravatar Mike Klein2016-10-12
| | | | | | | | | | | | | This will make it temporarily 64-bit until I sort out 32-bit builds (tomorrow?) but that's an unimportant dimension for this bot... we just want to make sure we can build with /EHsc. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Win-MSVC-x86-Debug-Exceptions-Trybot GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3255 Change-Id: Ie3c604e7ce779d0b45149e0151b7ecc93f9dd523 Reviewed-on: https://skia-review.googlesource.com/3255 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 17:24:19 +0000