aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* More image rebaselinesGravatar robertphillips@google.com2013-10-31
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12066 2bbb7eff-a529-9590-31e7-b0007b416f81
* Yet more rebaselinesGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/55303004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12065 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add can-ignore-rect hint to clear callGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/53823003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12064 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add suppressions for Issue 1784Gravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/49533006/ git-svn-id: http://skia.googlecode.com/svn/trunk@12063 2bbb7eff-a529-9590-31e7-b0007b416f81
* Partial fix for Skia issue 1769: GenerateGMs crashing (out of memory)Gravatar commit-bot@chromium.org2013-10-31
| | | | | | | | | | | | | | | | | | | | GenerateGMs was crashing because we were adding genID listeners for textures even when creation failed -- in this case the key generated is not valid, so when it comes time to purge it, it triggers an assert and then an apparent crash. The solution is to not add a genID listener in this case. This doesn't solve the problem of running out of memory, it just prevents it from causing a crash in Debug builds. BUG= R=bsalomon@google.com, robertphillips@google.com, mtklein@google.com Author: jvanverth@google.com Review URL: https://codereview.chromium.org/55023005 git-svn-id: http://skia.googlecode.com/svn/trunk@12062 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline images that improved with 12037Gravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/55193002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12061 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline lingering RoundRect RHB imagesGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/52713011/ git-svn-id: http://skia.googlecode.com/svn/trunk@12060 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adding size parameter to read array functionsGravatar commit-bot@chromium.org2013-10-31
| | | | | | | | | | | | | | | | | | | In some cases, the allocated array into which the data will be read is using getArrayCount() to allocate itself, which should be safe, but some cases use fixed length arrays or compute the array size before reading, which could overflow if the stream is compromised. To prevent that from happening, I added a check that will verify that the number of bytes to read will not exceed the capacity of the input buffer argument passed to all the read...Array() functions. I chose to use the byte array for this initial version, so that "size" represents the same value across all read...Array() functions, but I could also use the element count, if it is preferred. Note : readPointArray and writePointArray are unused, so I could also remove them BUG= R=reed@google.com, mtklein@google.com, senorblanco@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/37803002 git-svn-id: http://skia.googlecode.com/svn/trunk@12058 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, ↵Gravatar reed@google.com2013-10-31
| | | | | | | | | | | | since it triggers a warning"" This reverts commit 1e787c38fa71f2a21fd728f1b1d620b9b09b0d3d. BUG= Review URL: https://codereview.chromium.org/54603004 git-svn-id: http://skia.googlecode.com/svn/trunk@12057 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it ↵Gravatar reed@google.com2013-10-31
| | | | | | | | triggers a warning" This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497. git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81
* add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers ↵Gravatar reed@google.com2013-10-31
| | | | | | | | | | | a warning BUG= R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org Review URL: https://codereview.chromium.org/51033004 git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix bug in don't-reuse-scratch-textures pathGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/50853003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12054 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline for r12034Gravatar vandebo@chromium.org2013-10-31
| | | | | | | | | | | | xfermodes changed in all configs - added more src types. The following gms changed only for pdf configs: xfermodes2, xfermodes3, aarectmodes, colormatrix, lumafilter, mixed_xfermodes R=edisonn@google.com Review URL: https://codereview.chromium.org/54763003 git-svn-id: http://skia.googlecode.com/svn/trunk@12053 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove suppression of morphology image diffsGravatar robertphillips@google.com2013-10-31
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12050 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaselines of morphology GM for r11966Gravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/54353004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12049 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to trigger builds after buildbot script changesGravatar borenet@google.com2013-10-31
| | | | | | Review URL: https://codereview.chromium.org/54673002 git-svn-id: http://skia.googlecode.com/svn/trunk@12047 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-31
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12043 2bbb7eff-a529-9590-31e7-b0007b416f81
* No longer use scratch textures on ARM devicesGravatar robertphillips@google.com2013-10-31
| | | | | | | | https://codereview.chromium.org/50643003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12042 2bbb7eff-a529-9590-31e7-b0007b416f81
* Speculative Android build fix.Gravatar senorblanco@chromium.org2013-10-30
| | | | | | | | TBR=robertphillips Review URL: https://codereview.chromium.org/52693003 git-svn-id: http://skia.googlecode.com/svn/trunk@12041 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert r1784: SK_API on a non-concrete template is strange.Gravatar bungeman@google.com2013-10-30
| | | | | | | | TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/52843004 git-svn-id: http://skia.googlecode.com/svn/trunk@12040 2bbb7eff-a529-9590-31e7-b0007b416f81
* Mac build fix.Gravatar senorblanco@chromium.org2013-10-30
| | | | | | | | TBR=robertphillips Review URL: https://codereview.chromium.org/45963007 git-svn-id: http://skia.googlecode.com/svn/trunk@12039 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement SSE2-based implementations of the morphology filters (dilate & ↵Gravatar senorblanco@chromium.org2013-10-30
| | | | | | | | | | | | erode). This gives a 3-5X speedup over the naive implementation, and also mitigates a timing-based security attack in Chrome (https://code.google.com/p/chromium/issues/detail?id=251711). NOTE: this will require a corresponding GYP change on the Skia roll into Chrome: https://codereview.chromium.org/52453004/ R=mtklein@google.com, reed@google.com Review URL: https://codereview.chromium.org/52603004 git-svn-id: http://skia.googlecode.com/svn/trunk@12038 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make not-reusing-scratch-textures only apply to texture uploadsGravatar robertphillips@google.com2013-10-30
| | | | | | | | https://codereview.chromium.org/53133002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12037 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix int/SkScalar mismatch in gm.Gravatar vandebo@chromium.org2013-10-30
| | | | | | Review URL: https://codereview.chromium.org/45953005 git-svn-id: http://skia.googlecode.com/svn/trunk@12036 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix int/SkScalar mismatch.Gravatar vandebo@chromium.org2013-10-30
| | | | | | Review URL: https://codereview.chromium.org/51043005 git-svn-id: http://skia.googlecode.com/svn/trunk@12035 2bbb7eff-a529-9590-31e7-b0007b416f81
* [PDF] Improve complex xfer mode support.Gravatar vandebo@chromium.org2013-10-30
| | | | | | | | | | Xfer mode applies only to the shape of the source drawing, not everything in the clip as in currently implemented. It's just that the current gm examples draw a shape that fills the visible layer. R=edisonn@google.com, reed@google.com Review URL: https://codereview.appspot.com/4631078 git-svn-id: http://skia.googlecode.com/svn/trunk@12034 2bbb7eff-a529-9590-31e7-b0007b416f81
* DM: add --rtree.Gravatar commit-bot@chromium.org2013-10-30
| | | | | | | | | | | BUG= R=epoger@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/51243003 git-svn-id: http://skia.googlecode.com/svn/trunk@12033 2bbb7eff-a529-9590-31e7-b0007b416f81
* Don't check if shaders compile or program links in release ChromiumGravatar commit-bot@chromium.org2013-10-30
| | | | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/52843003 git-svn-id: http://skia.googlecode.com/svn/trunk@12032 2bbb7eff-a529-9590-31e7-b0007b416f81
* Exclude verylargebitmap test from replay modes on windows.Gravatar commit-bot@chromium.org2013-10-30
| | | | | | | | | | | BUG=skia:1756 R=epoger@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/52903003 git-svn-id: http://skia.googlecode.com/svn/trunk@12030 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use SkPathRef gen id for SkPath::getGenerationIDGravatar commit-bot@chromium.org2013-10-30
| | | | | | | | | | R=mtklein@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/49693002 git-svn-id: http://skia.googlecode.com/svn/trunk@12029 2bbb7eff-a529-9590-31e7-b0007b416f81
* Mark GMs that are not preserving the perspective for the canvas passedGravatar edisonn@google.com2013-10-30
| | | | | | Review URL: https://codereview.chromium.org/52443005 git-svn-id: http://skia.googlecode.com/svn/trunk@12028 2bbb7eff-a529-9590-31e7-b0007b416f81
* update results for Nexus4 gms that run in perspespective modeGravatar edisonn@google.com2013-10-30
| | | | | | Review URL: https://codereview.chromium.org/48623004 git-svn-id: http://skia.googlecode.com/svn/trunk@12026 2bbb7eff-a529-9590-31e7-b0007b416f81
* semi-blindly rebaseline some GM results, keeping them marked as unreviewedGravatar epoger@google.com2013-10-30
| | | | | | | | | | | | (they were unreviewed in the first place, so there's no particular reason to think they are either better or worse than they were before) As discussed live with bsalomon TBR=bsalomon Review URL: https://codereview.chromium.org/53023002 git-svn-id: http://skia.googlecode.com/svn/trunk@12024 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline GM results on Android-IntelRhb and Valgrind bots which were not ↵Gravatar epoger@google.com2013-10-30
| | | | | | | | | | | | | | | | running for a while Mostly tiny diffs due to roundrect implementation changes. Also a couple of GM tests that are known to have changed. Visually reviewed by bsalomon and epoger BUG=skia:1771 TBR=bsalomon Review URL: https://codereview.chromium.org/52963002 git-svn-id: http://skia.googlecode.com/svn/trunk@12023 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove contains(x,y) for rects and rrects ... not well defined, and unusedGravatar reed@google.com2013-10-30
| | | | | | | | | BUG= R=robertphillips@google.com Review URL: https://codereview.chromium.org/51953003 git-svn-id: http://skia.googlecode.com/svn/trunk@12022 2bbb7eff-a529-9590-31e7-b0007b416f81
* Allow specifying the max texture count on the botsGravatar robertphillips@google.com2013-10-30
| | | | | | | | https://codereview.chromium.org/50413011/ git-svn-id: http://skia.googlecode.com/svn/trunk@12020 2bbb7eff-a529-9590-31e7-b0007b416f81
* prototype for kerning apiGravatar reed@google.com2013-10-30
| | | | | | | | | BUG= R=bungeman@google.com Review URL: https://codereview.chromium.org/29363009 git-svn-id: http://skia.googlecode.com/svn/trunk@12018 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: report proper URL upon launchGravatar epoger@google.com2013-10-30
| | | | | | | | | | | BUG=skia:1767 (SkipBuildbotRuns) R=jcgregorio@google.com Review URL: https://codereview.chromium.org/51353002 git-svn-id: http://skia.googlecode.com/svn/trunk@12016 2bbb7eff-a529-9590-31e7-b0007b416f81
* add triangles to fatbits sample ('t')Gravatar reed@google.com2013-10-30
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12015 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-10-30
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12013 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reverting r12010 (Use SkPathRef gen id for SkPath::getGenerationID ↵Gravatar robertphillips@google.com2013-10-29
| | | | | | https://codereview.chromium.org/49693002) due to test failures in PathTest on Android git-svn-id: http://skia.googlecode.com/svn/trunk@12012 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM is passing the wrong flag to beginRecording() for --rtree.Gravatar commit-bot@chromium.org2013-10-29
| | | | | | | | | | | BUG= R=epoger@google.com, reed@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/50713004 git-svn-id: http://skia.googlecode.com/svn/trunk@12011 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use SkPathRef gen id for SkPath::getGenerationIDGravatar commit-bot@chromium.org2013-10-29
| | | | | | | | | | R=mtklein@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/49693002 git-svn-id: http://skia.googlecode.com/svn/trunk@12010 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove SkMatrix44 float conversions without precision lossGravatar commit-bot@chromium.org2013-10-29
| | | | | | | | | | | BUG=none R=reed@google.com Author: enne@chromium.org Review URL: https://codereview.chromium.org/50423004 git-svn-id: http://skia.googlecode.com/svn/trunk@12009 2bbb7eff-a529-9590-31e7-b0007b416f81
* All SkAnnotations are no-draw. Propose we fold that through.Gravatar commit-bot@chromium.org2013-10-29
| | | | | | | | | | | BUG= R=edisonn@google.com, reed@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/48523008 git-svn-id: http://skia.googlecode.com/svn/trunk@12008 2bbb7eff-a529-9590-31e7-b0007b416f81
* Little changes to SkAnnotation in pipe:Gravatar commit-bot@chromium.org2013-10-29
| | | | | | | | | | | | | | | | | - store size in the op data field rather than separately (saves 4 bytes); - trim out a malloc/memcpy in each of read and write; - remove unused enum value; - use the right _unpackOp function; - make sure we call needOpBytes(). BUG= R=reed@google.com, scroggo@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/50523004 git-svn-id: http://skia.googlecode.com/svn/trunk@12007 2bbb7eff-a529-9590-31e7-b0007b416f81
* Allow SkLazyPixelRef to use SkScaledImageCacheGravatar commit-bot@chromium.org2013-10-29
| | | | | | | | | | | | | | | | | | | | | | | | | | - SkScaledImageCache: - Add new FindAndLock/AddAndLock variants that work well with SkLazyPixelRefs (take width, height, generation_id). - Add static versions of these new variants. - SkLazyPixelRef: - If NULL passed in as SkImageCache* in the constructor, it will now default to using the static SkScaledImageCache methods to cache decoded images. - If (fImageCache==NULL), the default allocator can be changed with the setAllocator method. If (fImageCache!=NULL), the SkImageCache handles allocation. - CachedDecodingPixelRefTest to test the new functionality. BUG= R=scroggo@google.com, mtklein@google.com, reed@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/37343002 git-svn-id: http://skia.googlecode.com/svn/trunk@12006 2bbb7eff-a529-9590-31e7-b0007b416f81
* tests: Provide a default resources path.Gravatar commit-bot@chromium.org2013-10-29
| | | | | | | | | | | | | | This is cuts down noise when running from skia/trunk, where this is the right path to look in. BUG= R=epoger@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/51263002 git-svn-id: http://skia.googlecode.com/svn/trunk@12005 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix pipe/annotation.Gravatar commit-bot@chromium.org2013-10-29
| | | | | | | | | | | | | We weren't keeping track of the annotation that's on the other side of the pipe. BUG=skia:1761 R=scroggo@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/48273011 git-svn-id: http://skia.googlecode.com/svn/trunk@12004 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: replace TODOs section with link to documentation/roadmapGravatar epoger@google.com2013-10-29
| | | | | | | | | | (SkipBuildbotRuns) R=bsalomon@google.com Review URL: https://codereview.chromium.org/47543008 git-svn-id: http://skia.googlecode.com/svn/trunk@12002 2bbb7eff-a529-9590-31e7-b0007b416f81