aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* keep integral rectangle intersections integralGravatar Cary Clark2017-04-18
| | | | | | | | | | | | | | | | | | | | | | A pair of coincident lines can generate multiple intersection points. Path ops is more stable when the intersection T value is used to recompute the intersection point, but this has the side-effect of making integral edges intersect at non-integral values. While it's worthwhile to fix this, for the moment it is less disruptive to only worry about keeping intersection values integral if the original intersection point is integral in both axes. Also, fix some debugging code that bit-rotted. R=msarett@google.com Change-Id: Iefd27b25d1d21c22b224c174bd59bc6c105033c4 Reviewed-on: https://skia-review.googlesource.com/13721 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Cary Clark <caryclark@google.com>
* Change SkRecord to use SkArenaAllocGravatar Herb Derby2017-04-18
| | | | | | | | | | This CL uses the strategy of allocating raw bytes with the proper alignment so that SkRecord can manage the object lifetimes. Change-Id: I73604d41a3c6a12d1e2f7f8419f75b95c0190f68 Reviewed-on: https://skia-review.googlesource.com/13621 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Split up opListsGravatar Robert Phillips2017-04-18
| | | | | | | | | | Split into: https://skia-review.googlesource.com/c/11793/ (Remove lastProxy capability from GrSurface) Change-Id: I903ba30e17de4aab8cb0d2cc3281ae5c262142f9 Reviewed-on: https://skia-review.googlesource.com/11581 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Fix out of bounds read in SkColorSpace::MakeICCGravatar Matt Sarett2017-04-18
| | | | | | | | Bug: 711895 Change-Id: I8574289bda842cf1be3fb5bcf347a81b98fdc6b0 Reviewed-on: https://skia-review.googlesource.com/13690 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Use new recipes.py test commandGravatar Eric Boren2017-04-18
| | | | | | | | Bug: skia: Change-Id: I669e96bb62ce7c91ef40f48d01bca55128db5016 Reviewed-on: https://skia-review.googlesource.com/13688 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Re-enable deferred proxies in ChromeGravatar Robert Phillips2017-04-18
| | | | | | | | | | | Chrome has branched. TBR=bsalomon@google.com Change-Id: I578deafd63af9e86ff8f7cf8f8ccad6a901c1b21 Reviewed-on: https://skia-review.googlesource.com/13687 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Pass GrSurfaceContext into read/writeSurfacePixelsGravatar Robert Phillips2017-04-18
| | | | | | | | | This is mainly so writeSurfacePixels can have continuity of surfaceContext when it draws. Change-Id: I34f1dc5c4c3dcfa7bf91aa3ad72b7a48ed9de1a9 Reviewed-on: https://skia-review.googlesource.com/13595 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Document the new bug and test lines behavior of the release rollersGravatar Ravi Mistry2017-04-18
| | | | | | | | | | | | BUG=skia:6506 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13686 Change-Id: I8f38d2f87784a846ccdc4be54d0f07e0fe98f7dc Change-Id: I8f38d2f87784a846ccdc4be54d0f07e0fe98f7dc Reviewed-on: https://skia-review.googlesource.com/13686 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Split cleanup changes out of bigger CL (take 2)Gravatar Robert Phillips2017-04-18
| | | | | | | | | | | | | This are split out of: https://skia-review.googlesource.com/c/11581/ (Split up opLists) This is a reland of: https://skia-review.googlesource.com/c/13585/ (Split cleanup changes out of bigger CL) TBR=bsalomon@google.com Change-Id: Id0d5c764953230412e78ae6aa654f8dfae998c60 Reviewed-on: https://skia-review.googlesource.com/13643 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* SkColorSpaceXformer: Handle compose color filtersGravatar Matt Sarett2017-04-17
| | | | | | | | | | | | | | | We could alternatively use the makeColorSpace() approach that we adoped for loopers and imagefilters, but this seems fine. This should finish xform canvas work on color filters. We have plenty of color filters that do math on colors, but only two that might actually hold colors. Bug: skia:6516 Change-Id: I1aee8c35d6886fdc149d4659d1bac2edc0d32b67 Reviewed-on: https://skia-review.googlesource.com/13649 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix Fuchsia Vulkan build controlGravatar Forrest Reiling2017-04-17
| | | | | | | | | | | | | | Our last patch here ran into some problems because some people build a subset of fuchsia that does not include skia, so setting skia_use_vulkan breaks their build. This relies on buildargs set from a fuchsia global GNI file to allow us to set them independently of skia in our build system Change-Id: I64f5f0f349c12947c8aff7761dc5fafdb6a91b6c Reviewed-on: https://skia-review.googlesource.com/13617 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Greg Daniel <egdaniel@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-04-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/2bd2b6306f3deaf01fed284038fab4ce05e68765 Remove deprecated script compile.py (tikuta@google.com) https://crrev.com/2220ac8ab35a3f7123d11143137124a89717198b Revert "Remove deprecated script compile.py" (mmoss@chromium.org) https://crrev.com/928c6d59f3408ad0bc823ee1549368af03b22517 V8: Make arm chromebooks tree-closers (machenbach@chromium.org) https://crrev.com/4daef50df40266df7d2dd58cea5b0c97b5ff9f63 Add ignore_swarming_task_failure attribute for isolated_script (nednguyen@google.com) https://crrev.com/b780e3c6a5b6c3fbb865eb9e2dd86f12c1ab2f8c WebRTC: Add Linux ARM 64-bit Debug+Release builders + FYI bot. (kjellander@chromium.org) https://crrev.com/83ae262fa30b20b00f65fe9bc7bd50428e6e032d On dartk/dartkp builders test all suites and not just co19 language kernel service. (vegorov@google.com) https://crrev.com/0b81a2102a55086f3dafaccf5b79637c49b3700d On dart kernel builders set --builder-tag=no_ipv6. (vegorov@google.com) https://crrev.com/31f9c83d3ed4fed0c3f215e94c00751d026d95bc [Findit] Bail out with no culprit found if compile passed on the last revision in range. (chanli@chromium.org) https://crrev.com/6d14c7141290ce60514b07a14e53dd2030df44b7 [recipes.cfg] upgrade to api_version 2 (iannucci@chromium.org) https://crrev.com/b0d19086a88ac1baba0c4d9906577e517300e5d8 Revert "[recipes.cfg] upgrade to api_version 2" (iannucci@chromium.org) https://crrev.com/6bfba7afcf2ac793044c44527932e825c21e508a remote_run: Enable per-builder canary whitelisting (dnj@chromium.org) https://crrev.com/af1aa0585197c0a944ce77c14f7c137f97ac504c [remote_run] bump recipes-py canary version (iannucci@chromium.org) https://crrev.com/c3d07fd63d6378dda05d1d477e812c0aa356d325 [remote_run] bump recipes-py prod version (iannucci@chromium.org) https://crrev.com/2798cf183e8ffb6e2903d80a71ad7d1de429a5ba [recipes.cfg] upgrade to api_version 2 (iannucci@chromium.org) https://crrev.com/c410e27324f9ab26956b3cc8cf205a7ee8e6bc72 Install goma for more bots. (hidehiko@chromium.org) https://crrev.com/002ddd5fabf636bdfde86ad4ebbcf26e846ca9ae [Findit] remove result report from build property so it will not be included in buildbucket response. (chanli@chromium.org) https://crrev.com/a2ad74e50d2662f1c14e3b31ffbceed1306eb819 Add webkit_layout_tests to closing_optional list for WebKit Linux - TraceWrappables. (mcgreevy@chromium.org) https://crrev.com/f776e58c170ce6ceeb48434f69e3c8ed027b820d call _archive_retry_summary for both webkit_layout_tests and webkit_tests. (mcgreevy@chromium.org) https://crrev.com/f0cef60e4d34194c6a8aab855f9fb74ada412146 Revert "WebRTC: Remove low_bandwidth_audio_test on Mac and Windows." (oprypin@chromium.org) https://crrev.com/eed61f7e2c89b7f40b723ccca13a815e40e78278 Upload test results presentation html file to google storage. (hzl@google.com) https://crrev.com/ce0ba39742e46a234d960b7317eba7935ebc617d Revert "Upload test results presentation html file to google storage." (hzl@google.com) https://crrev.com/356064ec92fddc7d7098067dd0d711a62d5f10f5 Revert "Retry tests without the patch on iOS try bot failures" (stgao@chromium.org) https://crrev.com/4e41fb0cdd4bda4b5a6dd9167dde76f0f63ceb0f Make sure that step presentation is not set to FAILURE if exit_code is zero (nednguyen@google.com) https://crrev.com/f7f8a5d24ed0d4dca19305bde7e372a149b992e9 Add mac and win battor agents (martiniss@google.com) https://crrev.com/68c21b4d24c70d6e77727c3f7044148908fab4de Add files in gen/layout_test_data to the package. (yzshen@chromium.org) https://crrev.com/23a7ecf5af6fd0039b2a25d9552cd706ef8c17c2 Add low_bandwidth_audio_test on Android (oprypin@chromium.org) https://crrev.com/de288b21edf2614d47df375730777814826a93d6 Revert "Add low_bandwidth_audio_test on Android" (oprypin@chromium.org) https://crrev.com/917efd4d8e43deb9c4c4b36c82fbc60fd578504e V8: Add node.js baseline bot (machenbach@chromium.org) https://crrev.com/328305ad806f3bc88fe190f754463ee007d0c040 Implement a generic postprocess/merge hook for swarming tasks. (jbudorick@chromium.org) https://crrev.com/236fd0e4571b168b58446704d8c223dd476431ed Revert "Implement a generic postprocess/merge hook for swarming tasks." (jbudorick@chromium.org) https://crrev.com/ff11ffc8f04c2a51de1f5a1a866d29422a23eb1f Convert L low-end tester on chromium.android.fyi to swarming. (bpastene@google.com) https://crrev.com/0987eb972f4aee77971c6fe8cad085789068c6e1 flutter: remove the dart_vm_entry_points_android.txt that was used by the dart:jni package (jsimmons@chromium.org) https://crrev.com/69844a761f7440e967a8eeb9263a9c578d1ce81a (Reland) Upload test results presentation html file to google storage. (hzl@google.com) https://crrev.com/d9d686021d37a70c7b48ac3ff44469f468307585 Show link to uploaded build log in upload_log step (tikuta@google.com) https://crrev.com/368d2266581f6acdb7ad072786b17f171435bdaa Remove TraceWrappable bot (machenbach@chromium.org) https://crrev.com/d458bc907d75625014522fbdd1005526485a1962 Migrate V8 api stability bot to v8 waterfall (machenbach@chromium.org) https://crrev.com/4f521927f89597a9f136b0f8fd480a38d018dbde V8: Workaround for broken node.js build targets (machenbach@chromium.org) https://crrev.com/bb9287f02c2b7377bb951a2d4b20e53f1f3394f2 Run JUnit test with wrapper scripts on bots. (mikecase@google.com) https://crrev.com/d25f8637847fe747d459b504af5390222be56eaf Add builder to client.dart, add recipe support for checked-mode kernel builders (kustermann@google.com) https://crrev.com/b31fffcd8035b6bf40f337ab77eecbb37ef19653 remote_run: Enable Kitchen for site isolation FYI (dnj@chromium.org) https://crrev.com/602e92e8af3dee11015d2a03e1e8f36535b4e3e0 Run engine unit tests on Mac & Linux host_debug_unopt builds. (chinmaygarde@google.com) https://crrev.com/90e4dcc2d924e960c3490e8255d6ca212da6ccda Tweak recipe_modules pylint blacklisting and run pylint on upload. (jbudorick@chromium.org) https://crrev.com/51053a460a8a9b71c58e93c12cb89c3881361970 Avoid running time sensitive tests in FML and don't run channels tests on Linux. (chinmaygarde@google.com) https://crrev.com/fc42f7d9f8368b8bc1d7dbb401d92c21c3205875 Fix the step link of result details. (hzl@google.com) https://crrev.com/58842dc44d709faaeafa9b8377564788004b7368 Nest step triggers (martiniss@google.com) https://crrev.com/a1adf9ee4394d73d0df7ba22b82b48351d09f41c Fix error in application on gtest_filter to fml_unittests. (chinmaygarde@google.com) https://crrev.com/5c1b3b360e2e08837206eeac43da637cc0add200 Run FTL tests on Windows (goderbauer@google.com) https://crrev.com/aff184bd83e19f34fafaa117b0f002eda1f7e972 Stop using and remove layout_test_wrapper.py. (qyearsley@google.com) https://crrev.com/dbe97aafbb818ec2f067764caa8504b8fd4c1701 Use "kitchen" path config for legacy remote run. (dnj@chromium.org) https://crrev.com/4098ffe08f199701d7a68c049ee77cb6b6ec2029 add .exe to test executables on Windows (goderbauer@google.com) https://crrev.com/3469ad46426a9ddb7fa4f512add85ac3181e6565 Fix paths on Windows (goderbauer@google.com) https://crrev.com/88460d6e88cf9187de8c336d9266b34b2bc7620e Revert "Stop using and remove layout_test_wrapper.py." (qyearsley@chromium.org) https://crrev.com/ceea9270c70c12bc28faec3555937396498f22f6 Shorter timeout for Crashpad runs (scottmg@chromium.org) https://crrev.com/885923720ca78b46817bacec215b7a0e5788253b WebRTC: Disable Linux 32-bit builds to unblock rolling. (kjellander@chromium.org) https://crrev.com/f904c7617691ce14667a6fe5b14e663f485cc1dd Upload gomacc.*.INFO. (yyanagisawa@chromium.org) https://crrev.com/bcecde5341a48f99d6fb5708e509735468b005b0 [pgo] Replace indexeddb_perf with storage.indexeddb_endure_tracing (perezju@chromium.org) https://crrev.com/893412c4cd1b601cdc46a8fcac3766eb3bf546df WebRTC: Disable Linux ARM64 Debug bot to unblock rolling (kjellander@chromium.org) https://crrev.com/b9753ba671f9adfd0c443eab24aea7a04639215c chromium_trybot: delete dont_analyze_for_non_src_project test (phajdan.jr@chromium.org) https://crrev.com/dc34fd3833b56a98a4d5b1c6d671ed2ca80983f5 V8: Bump swarming timeout and shards on mips bot (machenbach@chromium.org) https://crrev.com/4c955cb26a06b70be028078437fccd3000baa951 V8: Remove obsolete baseline testing from node integration bot (machenbach@chromium.org) https://crrev.com/9295df947dea2702b69f5af9b01d989e89b145bd chromium_tests: Fix _name usage on IncrementalCoverageTest. (tansell@chromium.org) https://crrev.com/214b9a130ddc0944ad9c509f827c9f3db70f7db3 Enable coredumps on vm-kernel-linux (non-precomp) (kustermann@google.com) https://crrev.com/7e4ff9802920593f2bf53958f2a1a9958c8c6809 Enable LogDog for syzygy waterfalls. (dnj@chromium.org) https://crrev.com/af7fe00e5c33f32cd517f29d91aa57575a8cdda4 remote_run: Bump Kitchen, cleanup logic. (dnj@chromium.org) https://crrev.com/28c6eb798fca201acc3fac954c3d3433471a774c Remove vestigial android/perf bot configs. (jbudorick@chromium.org) https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b Use cache directory for build checkout. (dnj@chromium.org) https://crrev.com/dff1924a3645f45f012689c9adc74cbd82671c16 Switch android/perf recipe to devil provisioning. (jbudorick@chromium.org) https://crrev.com/487fe058d719483abbee70d84ea5f65639e663e4 Switch bisection/android_bisect{,_staging} to devil provisioning. (jbudorick@chromium.org) https://crrev.com/0c8cdf963550631f93f79eac2b597c96fc9d4214 flutter: update APK upload for new Gradle output path (jsimmons@chromium.org) https://crrev.com/918574b36f597bd188ccc9f811d537c7f6f7e6fe chromite: Change cbuildbot/api to to cbuildbot_launch. (dgarrett@google.com) https://crrev.com/fedcb6d0c2f4d0c95e510276e958b33bb4d3ae93 Switch mojo to devil provisioning. (jbudorick@chromium.org) https://crrev.com/cbf7e4f450d1b80e563ecbcd137f992902b29035 Remove Windows and Linux GeForce GT 730 bots. (kbr@chromium.org) https://crrev.com/a18f32f7cdd9ef73511f2e5c48164e7059936d63 Fix android_n5x_swarming_dbg trybot settings (jinsukkim@chromium.org) https://crrev.com/eba6687000a5cab7d67476f987c5f3dcdd0def9a Revert "chromite: Change cbuildbot/api to to cbuildbot_launch." (dgarrett@chromium.org) https://crrev.com/023f1efa527e0b4a28c4966c9efcba4fa4a5aeb4 chromium: Enable using analyze for layout tests. (tansell@chromium.org) https://crrev.com/6543b59812744e6895e9a4c9eafdc75d9d39699e chromium_trybot: Fix martiniss OWNER email. (tansell@chromium.org) https://crrev.com/36e8830b7720e0498a7ef95953e7596b59ee7e16 Fixing step name for WebKit Layout Tests. (tansell@chromium.org) https://crrev.com/a8823304f7de8e54bff4afaa666650647b9ca11f Add a new win/mac goma canary builder for LocalOutputCache (shinyak@google.com) https://crrev.com/30d05e794441b26450f739b355be33684964efce V8: Add node-integration trybot (machenbach@chromium.org) https://crrev.com/5ae208c67eb85c76fe8b310fe1e1506f5c0761e0 Revert "chromium: Enable using analyze for layout tests." (tansell@chromium.org) https://crrev.com/c3b30e4e13da2b50708be4c448bf109217372d85 V8: Apply patches on node integration trybot (machenbach@chromium.org) https://crrev.com/ed723a35b8433678aeb0dc6d618714c4201be9dd [android] Fix WebView N arch configuration. (jbudorick@chromium.org) https://crrev.com/83683ed7f818b0029d787c1da3132416e72a86c0 chromium_tests: Allow upload_results handler to understand suffix. (tansell@chromium.org) https://crrev.com/ffb51f8389f8287c6518ce216452d4f9c7762172 Switch cronet to devil provisioning. (jbudorick@chromium.org) https://crrev.com/884fd0b5a23ff68aef05c8442de85d8275af9728 chromium_tests: Make swarmed isolated tests fail with large error codes. (tansell@chromium.org) https://crrev.com/9a1d214f237c09543a7af59b034792f8c4e68b81 Add auxiliary binary to CIPD bootstrap. (dnj@chromium.org) https://crrev.com/73671ebf77a0844d6b9b9be967b7472ff64fd5d7 Update dart-flutter integration recipe, rename sky_shell -> flutter_tester (kustermann@google.com) https://crrev.com/8d25def7aa0673ce3f1e436c5092341b32f70e6b Roll Git wrapper out to all BuildBot bots. (dnj@chromium.org) https://crrev.com/60f9f3d7a06f9f64dc13ef1a8bc550fce7ba70d8 Configure PDFium builders to build pdfium_all. (thestig@chromium.org) https://crrev.com/ece7e5aa69872d3551a64f9400024745b774a5c0 Fix recipe invocation of mb analyze on mac to check FORCE_MAC_TOOLCHAIN. (dpranke@chromium.org) https://crrev.com/6328212bbe7dfa38aaa4a2dcee04d26f14028772 chromium_trybot: Fixing missing tansell@ from OWNERS (tansell@chromium.org) https://crrev.com/8300711ed6b6396e50b6f092a77fa78491dd8dc9 Revert "WebRTC: Disable Linux ARM64 Debug bot to unblock rolling" (kjellander@chromium.org) https://crrev.com/e0cb895e24d3daeea49a32e11f9ae0903eca77cd V8: Remove deprecated clusterfuzz builders (machenbach@chromium.org) https://crrev.com/60b5be137284772d2fb55ac2e261aa279d87ec04 Dart: Add debug log step to recipes, make it work on Windows. (whesse@chromium.org) https://crrev.com/7f5a5538a09ab7be09b792c7621642a048e75628 Implement a generic postprocess/merge hook for swarming tasks. (RELAND) (jbudorick@chromium.org) https://crrev.com/217f111af09ddea4d351a371503fd02d722eae4e Revert "Implement a generic postprocess/merge hook for swarming tasks. (RELAND)" (machenbach@chromium.org) https://crrev.com/cd0f641cf6317556e481a7958d606e69a825109a Add NVIDIA Shield TV to GPU.FYI (ynovikov@google.com) https://crrev.com/437b20aeedbc9304008fe8d929f28a464e99aee1 Add config for linux_layout_tests_layout_ng try bot. (qyearsley@google.com) https://crrev.com/5b00be794346c76a12dec3a81d11c24b248b7537 Simplify layout_test_wrapper.py more, again. (qyearsley@google.com) https://crrev.com/be6a9a315bf6e9c0e45c0bbdd87c83b0a55ec28d Implement a generic postprocess/merge hook for swarming tasks. (RELAND 2) (jbudorick@chromium.org) https://crrev.com/6e7474bc7cea2bfb3da3a5f7bbdb1f5ec8b55bcf Revert "Implement a generic postprocess/merge hook for swarming tasks. (RELAND 2)" (jbudorick@chromium.org) https://crrev.com/84f4f2585534a98a827fb79962b2d8325ed61ecb Switch webview perf bots to the chromium recipe (martiniss@google.com) https://crrev.com/c568a8417c9164f8a1996a1e8768bf7d67669602 Revert "Revert "Add low_bandwidth_audio_test on Android"" (oprypin@chromium.org) https://crrev.com/ca02f065486627347da49805bd2638bedf5bea34 V8: Make sanitizer-coverage bot gerrit aware (machenbach@chromium.org) https://crrev.com/f96cbaa627fd26af2c4cc0eb26d33a277e97a586 Dart: Allow subannotations in Dartium builder main step (whesse@chromium.org) https://crrev.com/3c1eb1bfdf8677df9f79bccd04482a4e41e6381f V8: Add link to docu in email. (franzih@chromium.org) https://crrev.com/e1ea0a6aef053fe91951fe4919b19d91f53d0901 Add chromium.webkit to masters_recipes_test. (dpranke@chromium.org) https://crrev.com/2876764b52d6651834a0d8702356c968ac570eda Make Android arm/arm64 Builder download VR test APKs (bsheedy@chromium.org) https://crrev.com/3722c6c9b98063a27319ba3f97e0d6bbd538a884 Support specifying ignore_swarming_task_failure & ignore_task_failure for swarming isolated script test (nednguyen@google.com) https://crrev.com/00cd0ae22f4a9e2f1906dafcf861ceaa004d9442 Add new machines and FIPS builders to client.boringssl. (davidben@chromium.org) https://crrev.com/724973cc5ea76a9359125bb437ef6c6723ce51a9 remote_run: Roll Kitchen to pick up TMPDIR (dnj@chromium.org) https://crrev.com/0e67c706f5796cb0797e5cd09f920846a5b0a560 GetGomaLogDirectory should searches a log directory more accurately. (yyanagisawa@chromium.org) https://crrev.com/e64c2de6c57e25b55f7c73261bdacc0a82189c54 chromium_tests: Interrupted files not considered valid. (tansell@chromium.org) https://crrev.com/90711a4918e74aedb10d05fe9a4400d8007ba0d2 Move gtest log handling into api.test_utils. (jbudorick@chromium.org) https://crrev.com/85dc10fad1a7ea385ab43353f414b15695052221 Revert "chromium_tests: Interrupted files not considered valid." (kjellander@chromium.org) https://crrev.com/7f3bc2a4ae12dfc4e4c943ecee0bd24cc0c4c1db Implement a generic postprocess/merge hook for swarming tasks. (RELAND 3) (jbudorick@chromium.org) https://crrev.com/c926e68e032bf5201fdca5f01f1ab125f7233ddb Revert "Implement a generic postprocess/merge hook for swarming tasks. (RELAND 3)" (jbudorick@chromium.org) https://crrev.com/da635f7814c920356afaa25eebef15f010e9333e Fix flag for linux_layout_tests_layout_ng try bot. (qyearsley@google.com) https://crrev.com/75c17b641b40ff75b5fcb90b4ec87b3eb91290bc Remove ignore_swarming_task_failure field (nednguyen@google.com) https://crrev.com/f7b41106d64b6517c67343f2cfb03f4a9d62afc2 Bump Git wrapper staging version. (dnj@chromium.org) depot_tools: https://crrev.com/1345ba9bce159d42ec724dc0dd597ab93d4022d3 [recipes.cfg] upgrade to api_version 2 (iannucci@chromium.org) https://crrev.com/f2d0ad648a8f9739b3f0a21283446df890ba15d2 Manually roll recipe engine d7f80ca:e2b4fd5 (phajdan.jr@chromium.org) https://crrev.com/4f0fb066f93247fd8f787d2e61add6bbb5b4ba92 Manual recipe roll (trivial). (dnj@chromium.org) recipe_engine: https://crrev.com/9f7465ffe92dab0bcc6f4d0e60303c6bff4d0f72 [recipes.cfg] Add disable reason. (iannucci@chromium.org) https://crrev.com/855168108b3dab668c36b56a99ca5a73f6d98932 [recipes.cfg] upgrade to api_version 2 (iannucci@chromium.org) https://crrev.com/e77477ba61ef082e2e34d58fd1251a1cb707f698 make doc/recipes.py supported version 1 and 2 (iannucci@chromium.org) https://crrev.com/1af805aac5b8735be9effce6251286d062755257 Convert structured output of 'test' command to protos (phajdan.jr@chromium.org) https://crrev.com/09292e372498915b899f480ce9f384057dc5710c Implement debug (pdb) support in new 'test' command (phajdan.jr@chromium.org) https://crrev.com/e02889f17c4ac35b7fb99915c5e05a9dde1347c0 test: promote --train to its own subcommand (phajdan.jr@chromium.org) https://crrev.com/189f7dcc9e1151e6714987e26eb7de14c531d3ae Implement 'diff' sub-command in new 'test' command (phajdan.jr@chromium.org) https://crrev.com/0586f16a4911be4855ce52621e143662e1d58062 Always identify test names that lead to failures (phajdan.jr@chromium.org) https://crrev.com/e9b07327159884c40cc81744361d0018c5cf481c absolutize paths specified in args (nodir@chromium.org) https://crrev.com/0160aa0a9b2b85379a8e80090d753fef20e6dce5 Add deprecation warning to simulation_test command (phajdan.jr@chromium.org) https://crrev.com/ddfc94f01e4e1d3c7bf7dedfd58e6813bc5160df Assert validity of stream parameters. (dnj@chromium.org) https://crrev.com/796247003f570b54140f9cc6e7934bcdf11880e7 Put result.proto into recipe_engine proto package (nodir@chromium.org) https://crrev.com/d7f80cacbb5c61e5bdaaff122fb5ab0ea7b58345 Fix recipe bootstrap on Windows (phajdan.jr@chromium.org) https://crrev.com/e2b4fd5362e043dc66e85f5c342e414c5bfb89de Enable recipe bootstrap by default (phajdan.jr@chromium.org) https://crrev.com/0497d326e1805715e8df4095afa6d0e95b9af48f Revert of Assert validity of stream parameters. (patchset #4 id:60001 of https://codereview.chromium.org/2792333003/ ) (phajdan.jr@chromium.org) https://crrev.com/ab1007e993f5ae367c15389afb954591bf3376dd autoroll: don't send output from "fetch" command to NUL (phajdan.jr@chromium.org) https://crrev.com/bbe066964830adfaa2298d0fd77e02b86bcd48ea Disable bootstrap for recipes.py invocations in autoroll (phajdan.jr@chromium.org) https://crrev.com/162f5cba2739078a1ff263c9898fa31690864481 Revert of Enable recipe bootstrap by default (patchset #1 id:1 of https://codereview.chromium.org/2801073004/ ) (phajdan.jr@chromium.org) https://crrev.com/22e9f7a530a72ede0b5390687cfffb79e3e5bf60 Revert of Disable bootstrap for recipes.py invocations in autoroll (patchset #1 id:1 of https://codereview.chromium.org/2801273002/ ) (phajdan.jr@chromium.org) https://crrev.com/0fdbf0025e0a814b0c2ea8c787d24aeab0ecb99b Add --disable-bootstrap option to recipe engine (phajdan.jr@chromium.org) https://crrev.com/11a5a6648f538d56cd5a48169f7b349e2d71886c Enable bootstrap by default when invoking test command (phajdan.jr@chromium.org) https://crrev.com/2ea2b19c4deb2f81b462754509e2c858e73078ec Refactor and clean up unit tests a bit. (iannucci@chromium.org) https://crrev.com/86179ebcb99567b956e788bb1a100c262f533083 Work around unicode issues by re-encoding properties as utf-8 (phajdan.jr@chromium.org) https://crrev.com/f31d525eef33613aa537e8ed954e7dfbf1cae8b2 path: Add tracking of volatile paths. (dnj@chromium.org) https://crrev.com/3582ac2243ff0bcbd36bfb8f9ab9853a5ca5beb1 Fix test hang (phajdan.jr@chromium.org) https://crrev.com/4e482d2131c51fd19f9a3e8840ae74c52a7b6567 Move package.ProtoFile -> package_io.PackageFile (iannucci@chromium.org) https://crrev.com/4afdf69bc15cbcf6a88076da7074d24cb88780d2 Add test coverage for testing recipe configs and test_api (phajdan.jr@chromium.org) https://crrev.com/56ba34248d8319cfdaff19ae55d68004fdd8ebf8 Stop running deprecated simulation_test (phajdan.jr@chromium.org) https://crrev.com/f5e47cfc28b5964701572db12f96c7a5a3f1821a Enable strict coverage for json, path, platform, properties, raw_io (phajdan.jr@chromium.org) TBR=borenet@google.com Change-Id: If92ca282402a62b552e45eb5a5b89dc9dfe51b2d Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Reviewed-on: https://skia-review.googlesource.com/13653 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Pass LC_ALL_MASK to newlocaleGravatar Eric Karl2017-04-17
| | | | | | | | | | | | | | | This change fixes an issue with GrAutoLocaleSetter, which was using the C library LC_ALL mask with newlocale. Instead the xlocale LC_ALL_MASK should be used (these do not match on all platforms). See: http://man7.org/linux/man-pages/man3/newlocale.3.html Bug: 711683 Change-Id: I6dba140e72b095f75667f0dcc98480d8d4562191 Reviewed-on: https://skia-review.googlesource.com/13601 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* jumper, table_{r,g,b,a}Gravatar Mike Klein2017-04-17
| | | | | | | | | | | In testing, it didn't really seem like we're getting anything out of doing an interpolated lookup, so this just does a single rounded lookup. Change-Id: If85ba68675945b442076519dd7f1bf7540d1628d Reviewed-on: https://skia-review.googlesource.com/13646 Commit-Queue: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Matt Sarett <msarett@google.com>
* Re-enable recipe autorollerGravatar Eric Boren2017-04-17
| | | | | | | | | Bug: skia: Change-Id: Ie7460c91f808e8187c5a7205ea0b4bdfa71c7e4d Reviewed-on: https://skia-review.googlesource.com/13650 Reviewed-by: Robbie Iannucci <iannucci@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* support either 32bit swizzle in HQ modeGravatar Mike Reed2017-04-17
| | | | | | | | Bug: skia:6515 Change-Id: I8570a76824026d973fd0cc7247b34de7ae70a190 Reviewed-on: https://skia-review.googlesource.com/13593 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Reed <reed@google.com>
* jumper, hook in callbackGravatar Mike Klein2017-04-17
| | | | | | | | | | | Derp. I added the code but never hooked it up. Change-Id: I955fe36465809c891fdaf818bf1287843fbdf5fb Reviewed-on: https://skia-review.googlesource.com/13598 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Re-arrange GrResourceProvider's texture creation methodsGravatar Robert Phillips2017-04-17
| | | | | | | | | This is all in service of removing the last raw writeSurfacePixels (that we can do anything about) Change-Id: Ic84f677b2440b20e5fcc23e787584db0cfaecd01 Reviewed-on: https://skia-review.googlesource.com/13584 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Revert "Split cleanup changes out of bigger CL"Gravatar Mike Klein2017-04-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit cd11c809f206af0da3ce1779dee3c91193baa7b0. Reason for revert: assert(rtp->getLastOpList()) Original change's description: > Split cleanup changes out of bigger CL > > This are split out of: https://skia-review.googlesource.com/c/11581/ (Split up opLists) > > TBR=bsalomon@google.com > > Change-Id: I1239e806a30a93d3c17ad933f118b98a5077dd3a > Reviewed-on: https://skia-review.googlesource.com/13585 > Commit-Queue: Robert Phillips <robertphillips@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ia3ef7322fe830a6a4dc29226ce931d35d181c6e0 Reviewed-on: https://skia-review.googlesource.com/13641 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* fix android-only function now that fRec is no longer usedGravatar Mike Reed2017-04-17
| | | | | | | Bug: skia:6481 Change-Id: I9805b6eb824257038fc8521753d32fecec1433dd Reviewed-on: https://skia-review.googlesource.com/13599 Reviewed-by: Mike Reed <reed@google.com>
* jumper, u16_be load_tables stagesGravatar Mike Klein2017-04-17
| | | | | | | Change-Id: I738da1dac2ef5b74ef34cca14938c0b6cce2fe16 Reviewed-on: https://skia-review.googlesource.com/13596 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Switch SkCodec to int for counts and indicesGravatar Leon Scroggins III2017-04-17
| | | | | | | | | | | | This matches other Skia APIs. size_t was adopted from blink/ GIFImageReader. Change-Id: Ic83e59f0942f597c4fb834e623acd9886ad483fe Reviewed-on: https://skia-review.googlesource.com/13274 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Chris Blume <cblume@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Split cleanup changes out of bigger CLGravatar Robert Phillips2017-04-17
| | | | | | | | | | | This are split out of: https://skia-review.googlesource.com/c/11581/ (Split up opLists) TBR=bsalomon@google.com Change-Id: I1239e806a30a93d3c17ad933f118b98a5077dd3a Reviewed-on: https://skia-review.googlesource.com/13585 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* jumper, load_rgb_u16_beGravatar Mike Klein2017-04-17
| | | | | | | | | testing: out/dm --src colorImage --colorImages images/colorspace/ --config srgb Change-Id: I3481e1fb4a070cfd5d95361329fd95af5fcfbd1f Reviewed-on: https://skia-review.googlesource.com/13590 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Finish overriding onMakeColorSpace() for SkImageFiltersGravatar Matt Sarett2017-04-17
| | | | | | | | | | Fixes 3 gms in gbr-8888. Breaks 0 gms in gbr-8888. Bug: skia: Change-Id: I3365390b16353821ef6057a7bb68020887e36f72 Reviewed-on: https://skia-review.googlesource.com/13323 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Update SKP versionGravatar UpdateSKPs2017-04-17
| | | | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR=update-skps@skia.org NO_MERGE_BUILDS Change-Id: I040e93e28139c5127f5f77d0f3fa12f35bab28f6 Reviewed-on: https://skia-review.googlesource.com/13578 Reviewed-by: update-skps <update-skps@skia.org> Commit-Queue: update-skps <update-skps@skia.org>
* Add a test for getFrameInfo on truncated dataGravatar Leon Scroggins III2017-04-17
| | | | | | | | | | | | | | Prior to e132e7be5f9108692254c37db592ea7611abbc15, calling getFrameInfo on an SkGifCodec which was truncated before fully parsing the local color map of the first frame would hit an assert. Add a test to verify that the problem has been fixed. Modify box.gif to use a local color map for the first (and only) frame. Change-Id: I905afe60c0c6ecc82e251e00ef82b2e5b22975a3 Reviewed-on: https://skia-review.googlesource.com/13320 Reviewed-by: Chris Blume <cblume@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Split SkCrossContextImageData into Image and BackendTexture subclassesGravatar Greg Daniel2017-04-17
| | | | | | | | | | | This is needed for a follow up CL where we switch from using GrBackendTextureDesc to GrBackendTexture. Bug: skia: Change-Id: Id12d3357af1cc7f30c7f9196e614089779dc0715 Reviewed-on: https://skia-review.googlesource.com/13588 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* add flag for g3Gravatar Mike Reed2017-04-17
| | | | | | | Bug: skia:6481 Change-Id: Ibbe4543a296e5b14b24fae2136c267a2cff2962e Reviewed-on: https://skia-review.googlesource.com/13594 Reviewed-by: Mike Reed <reed@google.com>
* Further refactor read/writeSurfacePixelsGravatar Brian Osman2017-04-17
| | | | | | | | | | | | | | | Detect the situation where we're going to want to do PM/UPM, and want to use GrConfigConverionEffect, but be unable (due to the lack of a round-trip pair). This lets us hoist the SW premul work (in writeSurfacePixels), and avoid all the cascading failure logic in both functions. (We never try to create the PM/UPM effects unless we know that they're going to work). Bug: skia:5853 Change-Id: I0077447cd4be93bba273f8d2826b1ec0f4915c6c Reviewed-on: https://skia-review.googlesource.com/13592 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* use SkArenaAlloc in SkColorSpaceXform_A2BGravatar Mike Klein2017-04-17
| | | | | | | | | | | | | I am learning / refactoring this code. To start, I mostly just want to get all these one-off storage members out of my face. Testing: out/dm --src colorImage --colorImages images/colorspace/ --config srgb Change-Id: I40eb0b565eb2ab1ef8975f7a7ba35961cff75a07 Reviewed-on: https://skia-review.googlesource.com/13586 Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* hide lockpixels api behind flagGravatar Mike Reed2017-04-17
| | | | | | | | | | | | | | guarded by SK_SUPPORT_OBSOLETE_LOCKPIXELS needs https://codereview.chromium.org/2820873002/# to land first Bug: skia:6481 Change-Id: I1c39902cbf6fe99f622adfa8192733b95f7fea09 Change-Id: I1c39902cbf6fe99f622adfa8192733b95f7fea09 Reviewed-on: https://skia-review.googlesource.com/13580 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com>
* deprecate odd variants of SkCanvas::readPixelsGravatar Mike Reed2017-04-17
| | | | | | | | | Bug: skia:6513 Change-Id: I51179a85f0912d3f899c368c30a943d346dd1d05 Reviewed-on: https://skia-review.googlesource.com/13589 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
* RecreateSKPs: Use api.run instead of api.stepGravatar Eric Boren2017-04-17
| | | | | | | | | | This gets us the default env, which includes the missing depot_tools. NOTRY=true Bug: skia: Change-Id: Idc6f9c426eb88c36d8c5d9c9bf9568a9414d61a6 Reviewed-on: https://skia-review.googlesource.com/13587 Reviewed-by: Ravi Mistry <rmistry@google.com>
* add a callback stage to SkRasterPipelineGravatar Mike Klein2017-04-17
| | | | | | | | | | | | | | | | | | This lets us temporarily escape to piece of code outside SkRasterPipeline. We should be able to use this to replace - parametric_{r,g,b,a} - table_{r,g,b,a} - color_lookup_table - shader_adapter* * We want to obsolete shader_adapter for other reasons anyway, but we _could_ replace it with this if we want to. Change-Id: I42b657b3c19c679796ed1876856cae0c8471307e Reviewed-on: https://skia-review.googlesource.com/12102 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com> Reviewed-by: Matt Sarett <msarett@google.com>
* Remove lastOpList capability from GrSurfaceGravatar Robert Phillips2017-04-17
| | | | | | | | | | | This is split out of: https://skia-review.googlesource.com/c/11581/ (Split up opLists) TBR=bsalomon@google.com Change-Id: I80d589b42918ddd77538484c808b069576691da4 Reviewed-on: https://skia-review.googlesource.com/11793 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Reduce read/write-SurfacePixels call sites (take 2)Gravatar Robert Phillips2017-04-17
| | | | | | | | | | | Reland of: https://skia-review.googlesource.com/c/13068/ (Reduce read/write-SurfacePixels call sites) TBR=brianosman@google.com Change-Id: I035b9fc2feab5fa443570ca54fbb0df8c9382cb3 Reviewed-on: https://skia-review.googlesource.com/13582 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Make RecreateSKPs use the Go CIPD assetGravatar Eric Boren2017-04-17
| | | | | | | | | NOTRY=true Bug: skia: Change-Id: I21212b62cd068bd722598fe8daadf184c87785df Reviewed-on: https://skia-review.googlesource.com/13583 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* remove unused mutex from pixelrefGravatar Mike Reed2017-04-16
| | | | | | | | Bug: skia:6481 Change-Id: I4f2696b947c735157a38bc0810f3cebbb18c9d77 Reviewed-on: https://skia-review.googlesource.com/13581 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkPictureImageFilter::onMakeColorSpace()Gravatar Matt Sarett2017-04-15
| | | | | | | | | | | Improves gm/recordopts. Does not break gm/pictureimagefilter or gm/fastfilterbounds. Bug: skia: Change-Id: I67c8f02a9548bf751350dfa3c7029dd59b8a2d1d Reviewed-on: https://skia-review.googlesource.com/13276 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Set build vars for Vulkan backend on Fuchsia.Gravatar Michael Jurka2017-04-15
| | | | | | | | | | BUG=skia: Change-Id: I355209a170ad8930a59cf91d584f40de82f51b92 Reviewed-on: https://skia-review.googlesource.com/13563 Reviewed-by: Forrest Reiling <freiling@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* remove lock tracking in bitmaps -- they are always lockedGravatar Mike Reed2017-04-14
| | | | | | | | Bug: skia:6481 Change-Id: I551c9fd5cdf1ea99fc62042d24d638a1021c348d Reviewed-on: https://skia-review.googlesource.com/13473 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
* getDeferredTextureImageData(): use legacy scaling in legacy modeGravatar Matt Sarett2017-04-14
| | | | | | | | | Bug:709341 Change-Id: I0dc1dcc3874f9741e0303e376a0ad4a68cd8b03e Reviewed-on: https://skia-review.googlesource.com/13500 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Remove dangerous constructor from SkArenaAllocGravatar Herb Derby2017-04-14
| | | | | | | | | | | Make the constructors for SkArenaAlloc unambiguous. TBR=mtklein@google.com Change-Id: Iaa6419574e78e17bf746f5f9bcdf99c9d6c9d727 Reviewed-on: https://skia-review.googlesource.com/13540 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com>
* fix scan converter arena allocGravatar Cary Clark2017-04-14
| | | | | | | | | | | | | Removing the 16K alloc sped up pathops_unittest -x -V Release on Windows 7; time went from 14 minutes to 4. R=herb@google.com BUG=skia:6509 Change-Id: If43c9ad6745961e0079a7f4f6560c6fa2a7847ef Reviewed-on: https://skia-review.googlesource.com/13507 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Herb Derby <herb@google.com>
* skirt std::chrono on MSAN buildsGravatar Mike Klein2017-04-14
| | | | | | | | | | | | | | | I don't know why, but only std::chrono's calls to clock_gettime() seem to be affected by this MSAN bug. Other calls into libc++ that call libc, like std::to_string(int) calling snprintf, work fine. CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-MSAN,Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-MSAN BUG=skia:6504 Change-Id: I73fbe8793d2b5b5cca46ed68fb078a77d8748127 Reviewed-on: https://skia-review.googlesource.com/13502 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Symmetric rendering when >20px with DirectWrite.Gravatar Ben Wagner2017-04-14
| | | | | | | | | | | | | If the font has a gasp table use it to determine symmetric. Otherwise, use symmetric if the the font isn't hinted or is >20px. The remaining cases use non-symmetric. BUG=chromium:706792,skia:6432 Change-Id: I91b66a9615aae27c195e1545298a9d36bc58a705 Reviewed-on: https://skia-review.googlesource.com/11400 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Fix advances for aliased text with DirectWrite.Gravatar Ben Wagner2017-04-14
| | | | | | | | | | | | | The existing code assumes that GetGdiCompatibleGlyphMetrics transform parameter acts the same as the GetGlyphOutlineW lpmat2 parameter. However, it appears this is very much not true. BUG=skia:6499 Change-Id: I88c762b27acd09cc746da4d6e2b901540876908a Reviewed-on: https://skia-review.googlesource.com/13479 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Revert "Reduce read/write-SurfacePixels call sites"Gravatar Robert Phillips2017-04-14
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 74d5a1470378dc7dae9eec38d46f9f802fc5c249. Reason for revert: erg Original change's description: > Reduce read/write-SurfacePixels call sites > > Change-Id: I657c489c56b93765567be69076fb4c3d526e55a5 > Reviewed-on: https://skia-review.googlesource.com/13068 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > TBR=robertphillips@google.com,brianosman@google.com,egdaniel@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: If80f36ddae9d695ee2e5413f3eb49a1f5c32f8a4 Reviewed-on: https://skia-review.googlesource.com/13506 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Reduce read/write-SurfacePixels call sitesGravatar Robert Phillips2017-04-14
| | | | | | | Change-Id: I657c489c56b93765567be69076fb4c3d526e55a5 Reviewed-on: https://skia-review.googlesource.com/13068 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>