aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Enable override keyword for GCC versions >= 4.7Gravatar djsollen2015-02-20
| | | | Review URL: https://codereview.chromium.org/945803005
* Port GrGLCaps over to use SkTHash.Gravatar mtklein2015-02-20
| | | | | | | | | | | | | I've written some new hashtable interfaces that should be easier to use, and I've been trying to roll them out bit by bit, hopefully replacing SkTDynamicHash, SkTMultiMap, SkTHashCache, etc. This turns the cache in GrGLCaps::readPixelsSupported() into an SkTHashMap, mapping the format key to a bool. Functionally, it's the same. BUG=skia: Review URL: https://codereview.chromium.org/948473002
* Fix layer hoisting bug in SkCanvas::drawPicture pathGravatar robertphillips2015-02-20
| | | | | | Most of this CL is just reordering to better match the MultiPictureDraw variant. The only functional change is that we now use the device space bounds as the queryRect to the layer hoisting code. This is necessary since the layer hoisting does all its work in device space. Review URL: https://codereview.chromium.org/942853002
* Use simpler SkTHashSet in DM to store reference goldGravatar mtklein2015-02-20
| | | | | | | | It's simpler and doesn't leak the gold anymore. BUG=skia: Review URL: https://codereview.chromium.org/940283006
* PDF: Now threadsafe!Gravatar halcanary2015-02-20
| | | | | | | | | | | | | The PDF canvas is now just as threadsafe as any other Skia canvas. DM updated to thread PDF tests. SkDocument_PDF now owns SkPDFCanon, and pointers to that canon are passed around to all classes that need access to the canon. BUG=skia:2683 Review URL: https://codereview.chromium.org/944643002
* Round stencil buffers dims up to next pow2 when allowedGravatar bsalomon2015-02-20
| | | | Review URL: https://codereview.chromium.org/937303002
* This uses quad approximations of the outer and inner paths describing a ↵Gravatar caryclark2015-02-20
| | | | | | | | | | stroke. Cubics and conics' thick strokes are approximated with quads as well. The approximation uses a similar error term as the fill scan converter to determine the number of quads to use. This also updates SampleApp QuadStroker test with conics, ovals, and stroked text. Review URL: https://codereview.chromium.org/932113002
* PDF : New factory function for SkPDFDeviceGravatar halcanary2015-02-20
| | | | | | SkPDFDevice now has factory function that matches what callers need. Review URL: https://codereview.chromium.org/941023005
* PDF: remove unused SkPDFDevice::setDCTEncoder()Gravatar halcanary2015-02-20
| | | | | | | All image compression currently uses (losseless) Deflate, not Jpeg. See http://crrev.com/935843007 Review URL: https://codereview.chromium.org/946493002
* Revert of Make SkPixelRef::isLocked() debug-only, remove related dead code. ↵Gravatar reed2015-02-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/940083002/) Reason for revert: Broke callers in chrome ../../skia/ext/platform_canvas_unittest.cc:421:56: error: no member named 'isLocked' in 'SkPixelRef' EXPECT_TRUE(platform_bitmap->GetBitmap().pixelRef()->isLocked()); Original issue's description: > Make SkPixelRef::isLocked() debug-only, remove related dead code. > > DM's okay locally with no diffs, no failures. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/8e65712486c66108677a9b0a55ad3e7ca94db555 TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/940323003
* PDF: Remove SkPDFDeviceFlattenerGravatar halcanary2015-02-19
| | | | | | | | There are no clients. TBR=mtklein@google.com Review URL: https://codereview.chromium.org/937333002
* Remove unused parameters to SkDocument::CreatePDFGravatar halcanary2015-02-19
| | | | | | | | | | All image compression currently uses (losseless) Deflate, not Jpeg. All clients simply use SkDocument::CreatePDF(stream). SampleApp and SkLua still use SkDocument::CreatePDF(path). Review URL: https://codereview.chromium.org/935843007
* Make SkPixelRef::isLocked() debug-only, remove related dead code.Gravatar mtklein2015-02-19
| | | | | | | | DM's okay locally with no diffs, no failures. BUG=skia: Review URL: https://codereview.chromium.org/940083002
* Rename onGetPixelsEnum back to onGetPixels.Gravatar scroggo2015-02-19
| | | | | | | | | | | | | | | | Replace the old signature of onGetPixels (return bool) to return an enum (Result). Remove onGetPixelsEnum. Add a define for onGetPixelsEnum to onGetPixels. This is for staging in Chromium, where some implementations override onGetPixelsEnum. Add the define in skia_for_chromium_defines. Remove SK_SUPPORT_LEGACY_IMAGE_GENERATOR_RETURN, which is no longer needed by Chromium. BUG=skia:3257 Review URL: https://codereview.chromium.org/939113002
* [SkSVGDevice] Fix whitespace text handlingGravatar fmalita2015-02-19
| | | | | | | | | | | | | SVG ignores leading/trailing whitespace and consolidates mid-text (http://www.w3.org/TR/SVG/text.html#WhiteSpace). This can cause our x/y position indices to get out of whack. Implement a text builder which is SVG whitespace-munging-aware and performs the needed x/y position list adjustments. R=reed@google.com,mtklein@google.com Review URL: https://codereview.chromium.org/928583003
* use geometric ave for choosing mip levelGravatar reed2015-02-19
| | | | | | | | requires https://codereview.chromium.org/937233002/ BUG=skia: Review URL: https://codereview.chromium.org/916103008
* Allow either the old or new version of ADB on mac.Gravatar djsollen2015-02-19
| | | | Review URL: https://codereview.chromium.org/926003002
* Speculative fix for nexus player unit test failureGravatar bsalomon2015-02-19
| | | | | | | | TBR=robertphillips@google.com NOTREECHECKS=true Review URL: https://codereview.chromium.org/941433006
* gm to illustrate mipmap layer choiceGravatar reed2015-02-19
| | | | | | | | BUG=skia: NOTREECHECKS=True TBR= Review URL: https://codereview.chromium.org/942593002
* Handle the case when the GrResourceCache timestamp wraps.Gravatar bsalomon2015-02-19
| | | | | | NOTREECHECKS=true Review URL: https://codereview.chromium.org/916103006
* gm to test hairlines which fill RenderTargetGravatar joshualitt2015-02-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/934283002
* Recycle stencil buffers across render targets.Gravatar bsalomon2015-02-19
| | | | Review URL: https://codereview.chromium.org/939093002
* Revert of notify resource caches when pixelref genID goes stale (patchset #4 ↵Gravatar mtklein2015-02-19
| | | | | | | | | | | | | | | | | | | | | | | | id:60001 of https://codereview.chromium.org/825263005/) Reason for revert: Crazy failures. http://build.chromium.org/p/client.skia/builders/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/builds/1428/steps/dm/logs/stdio Original issue's description: > notify resource caches when pixelref genID goes stale > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4675819b9dbb3ad71ec851776e5de26d342f29fe TBR=bsalomon@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/936423002
* PDF: why do we have flags no one uses (or can use)?Gravatar mtklein2015-02-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/936403002
* Update fontcache gm to actually stress font atlasGravatar jvanverth2015-02-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/933313004
* Allow resources' unique keys to be changed.Gravatar bsalomon2015-02-19
| | | | Review URL: https://codereview.chromium.org/938943002
* notify resource caches when pixelref genID goes staleGravatar reed2015-02-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/825263005
* Revert of disable gammatext gm for a while, looking for other flakes ↵Gravatar bungeman2015-02-19
| | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/725303002/) Reason for revert: We now have gold!!! Original issue's description: > disable gammatext gm for a while, looking for other flakes > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/64c04882701d9ee3bbbf23d8c02c8d96c5a51719 TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/943673002
* Clarify desired behavior of FontConfigTypeface::LegacyCreateTypeface.Gravatar bungeman2015-02-19
| | | | | | | | This should have no real effect on behavior, but cleans up some names and removes an unused parameter. This is a step toward separating the SkTypeface cache from the request cache. Review URL: https://codereview.chromium.org/936893002
* move SkPDFD*.h from include to srcGravatar halcanary2015-02-19
| | | | | | CQ_INCLUDE_TRYBOTS=client.skia:Mac Builder-Trybot,Linux Builder-Trybot,Win Builder-Trybot Review URL: https://codereview.chromium.org/727343002
* Rename GrContentKey to GrUniqueKeyGravatar bsalomon2015-02-19
| | | | Review URL: https://codereview.chromium.org/940463006
* Do not clear the source device in SkGpuDevice::drawDeviceGravatar kkinnunen2015-02-19
| | | | | | | | | | Do not clear the source device in SkGpuDevice::drawDevice based on the status whether the destination device needs a clear. Source device clear is flushed in SkGpuDevice::accessRenderTarget() and target device clear is flushed in CHECK_SHOULD_DRAW(draw). Review URL: https://codereview.chromium.org/943623002
* Avoid wrong memory access due to double substitution and %%Gravatar kkinnunen2015-02-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the form SkDebugf("%s", arbitraryString) instead of SkDebugf(arbitraryString). Fixes the case where SkString::appendf-ing a string with "%%" and then printing the string with SkDebugf would cause uninitialized read and corrupted debug print. ninja -C out/Debug tools && valgrind --leak-check=full ./out/Debug/render_pictures --config gpu -w q -r ... ... ==7307== Conditional jump or move depends on uninitialised value(s) ==7307== at 0x6908475: __printf_fp (printf_fp.c:1180) ==7307== by 0x6904267: vfprintf (vfprintf.c:1629) ==7307== by 0x6906E53: buffered_vfprintf (vfprintf.c:2313) ==7307== by 0x690188D: vfprintf (vfprintf.c:1316) ==7307== by 0x67E8F5: SkDebugf(char const*, ...) (SkDebug_stdio.cpp:18) ==7307== by 0x7983F1: GrContext::printCacheStats() const (GrTest.cpp:54) ==7307== by 0x408ECF: tool_main(int, char**) (render_pictures_main.cpp:480) ==7307== by 0x40913E: main (render_pictures_main.cpp:511) ==7307== Budget: 2048 items 100663296 bytes Entry Count: current 652 (651 budgeted, 0 wrapped, 297 locked, 638 scratch 32 0.000000ull), high 652 Entry Bytes: current 51087658 (budgeted 49826658, 49 0.000000ull, 1261000 unbudgeted) high 51087658 (observe "ull" instead of "% full") (from mtklein) This CL is not editing public API. TBR=reed@google.com Review URL: https://codereview.chromium.org/943453002
* Fixing possible out of bound memory accessGravatar sugoi2015-02-19
| | | | | | | | This was a bug found by ASAN. When width is very small, we can have something like width == 1 and rowBytes == 8. Using "2 * yWidth" (2) would be smaller than rowBytesY (8), so we could read memory out of bounds. This issue has a separate fix in blink (crbug.com/458861). BUG=skia: Review URL: https://codereview.chromium.org/936133003
* Remove FontConfigTypeface::getFamilyName().Gravatar bungeman2015-02-18
| | | | | | | This method is hiding a method of the same name from the superclass. This is confusing and error prone, and doesn't really add anything. Review URL: https://codereview.chromium.org/924333003
* managing chromes use section of docsGravatar hcm2015-02-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/934893003
* Runtime configuration section of docsGravatar hcm2015-02-18
| | | | | | | | Preview here: http://skiadocs.com:8000/dev/runtime/?cl=940663002 BUG=skia: Review URL: https://codereview.chromium.org/940663002
* Pass Rendertarget into context.Gravatar joshualitt2015-02-18
| | | | | | | | Adding Jim for text context stuff, and Steven for image blur stuff. BUG=skia: Review URL: https://codereview.chromium.org/939623005
* Use uint16s for texture coordinates when rendering text.Gravatar jvanverth2015-02-18
| | | | | | | | | Allows us to push more vertices into a given vertex buffer, with a slight performance improvement. Committed: https://skia.googlesource.com/skia/+/059034d252007d0dd86fff5ffdbb53cbcb10d34b Review URL: https://codereview.chromium.org/917373002
* Use SkAutoSTMalloc in GrResourceKeyGravatar bsalomon2015-02-18
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/935863003
* PDF: Add (low-memory) SkPDFBitmap classGravatar halcanary2015-02-18
| | | | | | | | | | | | | | | | | | | | | Also: Add SkDeflateWStream and associated unit tests. SkPDFBitmap is a replacement for SkPDFImage. As of now, it only supports 8888 bitmaps (the most common case). SkPDFBitmap takes very little extra memory (aside from refing the bitmap's pixels), and its emitObject() does not cache any data. The SkPDFBitmap::Create function will check the canon for duplicates. This can reduce the size of the output PDF. Motivation: this gives another ~40% decrease in PDF memory overhead TODO: Support other ColorTypes and scrap SkPDFImage. BUG=skia:3030 Review URL: https://codereview.chromium.org/918813002
* Update DirectWrite streams to SkStreamAsset.Gravatar bungeman2015-02-18
| | | | | | | SkTypefaces now deal in terms of SkStreamAsset, but the DirectWrite port was never fully converted. Review URL: https://codereview.chromium.org/940563002
* Remove Chromium staging in SkDrawCommandGravatar robertphillips2015-02-18
| | | | | | | | This cannot land until https://codereview.chromium.org/917063008/ (Cleanup lingering scaffolding for Skia change) has landed. TBR=joshualitt@chromium.org Review URL: https://codereview.chromium.org/930973002
* update sampleapp for stroking experimentGravatar caryclark2015-02-18
| | | | | | | | | Add RotateCircles3 back as better-named QuadStroker. Switch pathfill test to call skia before draw instead of in initializer to avoid triggering debugging breakpoints. Review URL: https://codereview.chromium.org/912273003
* Expose method to retrieve CTFontGravatar dominik.rottsches2015-02-18
| | | | | | | BUG=skia:3351 R=bungeman@chromium.org Review URL: https://codereview.chromium.org/872963003
* Make SkImage::getTexture() constGravatar kkinnunen2015-02-18
| | | | | | | | | | | | | | | Make SkImage::getTexture() const. At the moment the function does not mutate the state. One use-case is that this makes it possible in the future to add draw function to SkBaseDevice functions. The device draw functions take const ref objects, but SkGpuDevice likely would benefit of using the getTexture(). BUG=skia:3388 R=reed@google.com Review URL: https://codereview.chromium.org/925853002
* fix xcode buildGravatar mtklein2015-02-18
| | | | | | | | NOTREECHECKS=true BUG=skia: Review URL: https://codereview.chromium.org/936033003
* Revert of Use uint16s for texture coordinates when rendering text. (patchset ↵Gravatar reed2015-02-17
| | | | | | | | | | | | | | | | | | | | | | | | #5 id:80001 of https://codereview.chromium.org/917373002/) Reason for revert: speculative revert for DEPS failures https://codereview.chromium.org/932973002/ Original issue's description: > Use uint16s for texture coordinates when rendering text. > > Allows us to push more vertices into a given vertex buffer, with > a slight performance improvement. > > Committed: https://skia.googlesource.com/skia/+/059034d252007d0dd86fff5ffdbb53cbcb10d34b TBR=joshualitt@google.com,robertphillips@google.com,bsalomon@google.com,reed@google.com,djsollen@google.com,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/920333003
* Use an array of nonpurgeable resources in GrResourceCacheGravatar bsalomon2015-02-17
| | | | Review URL: https://codereview.chromium.org/932863004
* zlib/pdf: remove HaveFlate(), depend on preprocessor definesGravatar halcanary2015-02-17
| | | | Review URL: https://codereview.chromium.org/933523007
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-01 02:24:10 +0000