aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix layer hoisting image filter corner casesGravatar robertphillips2014-12-16
| | | | | | | | | | | | | | | | | | | | | | | | This CL fixes 5 bugs related to hoisting image filters: For image filters the src layer (the one prior to filtering) often needs to be smaller then the final layer. This requires the saveLayer's optional bounds to be stored (in SkLayerInfo.h and SkRecordDraw.cpp) and then used in compute_source_rect and carried around in GrCachedLayer. The image filters can add an extra offset to the final draw operation. This is now computed in GrLayerHoister::FilterLayer and carried around in GrCachedLayer. Filtered layers must use exact matches. This is now done in GrLayerCache::lock. The filter cache requires a valid matrix so it can compute the correct offset. This is now done in GrLayerHoister::FilterLayer. Filtered layers need to be drawn with drawSprite while unfiltered (and therefore hopefully atlased) layers can be drawn with drawBitmap. This is now done in draw_replacement_bitmap. Review URL: https://codereview.chromium.org/803183003
* Revert of Use SkPaint::getFontBounds() for text bounding boxes in pictures. ↵Gravatar mtklein2014-12-16
| | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/805983003/) Reason for revert: Test-Win7-ShuttleA-HD2000-x86-Debug-GDI Original issue's description: > Use SkPaint::getFontBounds() for text bounding boxes in pictures. > > Now that SkTextBlobs have landed, this is a perf no-op, but it at least lets us eliminate a bunch of questionable hacks. > > CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot,Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot > > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/02d2b9831579173e783569530ab7bae08de907e9 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/789793004
* Revert of Change desktop and ES 3.0 to always use sized internal texture ↵Gravatar jvanverth2014-12-16
| | | | | | | | | | | | | | | | | | formats. (patchset #2 id:20001 of https://codereview.chromium.org/806943002/) Reason for revert: Failing GMs on Mac, Windows and Ubuntu12. Original issue's description: > Change desktop and ES 3.0 to always use sized internal texture formats. > > Committed: https://skia.googlesource.com/skia/+/bc02bf0ee4221604796cd6d0394ca3af60c0a579 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/805193003
* Use SkPaint::getFontBounds() for text bounding boxes in pictures.Gravatar mtklein2014-12-16
| | | | | | | | | | Now that SkTextBlobs have landed, this is a perf no-op, but it at least lets us eliminate a bunch of questionable hacks. CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot,Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot BUG=skia: Review URL: https://codereview.chromium.org/805983003
* Change desktop and ES 3.0 to always use sized internal texture formats.Gravatar jvanverth2014-12-16
| | | | Review URL: https://codereview.chromium.org/806943002
* rebase gms and update ignoreGravatar joshualitt2014-12-15
| | | | | | | | NOTRY=True TBR= BUG=skia: Review URL: https://codereview.chromium.org/811433004
* whitespace change to context to force rebuild of skiaGravatar joshualitt2014-12-15
| | | | | | | | | NOTREECHECKS=True NOTRY=True TBR= BUG=skia: Review URL: https://codereview.chromium.org/807663002
* This change will ultimately pull uniform color, and to a much lesser degree ↵Gravatar joshualitt2014-12-15
| | | | | | | | uniform coverage, into GPs. There are still some loose ends because drawstate has the ability to override the GP, but fixing these cleanly will have to wait until we have deferred geometry in place and can make attribute / uniform decisions on the fly. BUG=skia: Review URL: https://codereview.chromium.org/746423007
* Move all non-program cache functions out of GrGpuGL_program.cppGravatar bsalomon2014-12-15
| | | | Review URL: https://codereview.chromium.org/794343006
* pass dst-rect through from drawBitmapRect for better precisionGravatar reed2014-12-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/797963002
* Look at DYNAMIC_ANNOTATIONS_ENABLED now.Gravatar mtklein2014-12-15
| | | | | | | | | Defining SK_DYNAMIC_ANNOTATIONS_ENABLED as 1 whenever DYNAMIC_ANNOTATIONS_ENABLED was 1 seems to be working fine for Chrome. Should be we can just use DYNAMIC_ANNOTATIONS_ENABLED. BUG=skia: Review URL: https://codereview.chromium.org/810513002
* add paint::getFontBounds()Gravatar reed2014-12-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/804903006
* Add missed convexpaths.Gravatar scroggo2014-12-15
| | | | | | | | | TBR=reed NOTRY=True NOTREECHECKS=True BUG=skia:3241 Review URL: https://codereview.chromium.org/805043005
* Delete old bench expectation code.Gravatar mtklein2014-12-15
| | | | | | | | Just noticed these were still here. BUG=skia: Review URL: https://codereview.chromium.org/801373003
* devirtualize some functions on GrGpuGravatar bsalomon2014-12-15
| | | | Review URL: https://codereview.chromium.org/811483003
* Rolling libwebp broke our iOS builds. Silence warnings instead.Gravatar mtklein2014-12-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/803213002
* There can be only one (SkRandom)!Gravatar scroggo2014-12-15
| | | | | | | | | | | | | | | | | | | | | Remove SkLCGRandom. We already decided the new one was better, which is why we wrote the new SkRandom. Convert GMs that were using SkLCGRandom to use the improved SkRandom. Motivated by the fact that these GMs draw differently on some runs. We believe this to be a result of using the old SkLCGRandom. Add each of the tests that were using SkLCGRandom to ignore-tests.txt, since we expect they'll draw differently using SkRandom. Move a trimmed down version of SkLCGRandom into SkDiscretePathEffect. In order to preserve the old behavior, trim down SkLCGRandom to only the methods used by SkDiscretePathEffect, and hide it in SkDiscretePathEffect's cpp file. BUG=skia:3241 Review URL: https://codereview.chromium.org/805963002
* skimage, die die dieGravatar mtklein2014-12-15
| | | | | | | | DM's running with --images on all the bots now. They look happy. BUG=skia:3235 Review URL: https://codereview.chromium.org/804133003
* Add xp optimization for RGB coverage.Gravatar egdaniel2014-12-15
| | | | | | | | | | | | | This is needed since clearColorStages is being changed to ignore color input. For RGB coverage, we want to clear all the color stages (since we know the final output color), but we don't want to ignore the color input since it is needed. In future we will change this so the XP stores the color internally and thus can tell the GP to simiply ignore color. BUG=skia: Review URL: https://codereview.chromium.org/791933006
* Fix rrects that are large enough that we lose/gain a bit when we add the ↵Gravatar reed2014-12-15
| | | | | | | | | | radius to a bounds coordinate. add test that triggers assert in addRRect BUG=skia:3239 Review URL: https://codereview.chromium.org/803153003
* Silence warnings from libnanomsg on Mac like we do on Linux.Gravatar mtklein2014-12-15
| | | | | | | | | | | | | | This will silence these warnings: ../../third_party/externals/nanomsg/src/core/global.c:162:34: warning: missing field 'unused' initializer [-Wmissing-field-initializers] static struct nn_global self = {0}; ../../third_party/externals/nanomsg/src/utils/clock.c:44:61: warning: missing field 'denom' initializer [-Wmissing-field-initializers] static mach_timebase_info_data_t nn_clock_timebase_info = {0}; BUG=skia: Review URL: https://codereview.chromium.org/803113003
* Revert of Roll libwebp to v0.4.2 (latest stable) to fix annoying build ↵Gravatar mtklein2014-12-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | warning. (patchset #1 id:1 of https://codereview.chromium.org/807553002/) Reason for revert: uses __builtins not available on all our compilers Original issue's description: > Roll libwebp to v0.4.2 (latest stable) to fix annoying build warning. > > This warning should now go away: > > ../../third_party/externals/libwebp/src/enc/quant.c:105:23: warning: unused variable 'kCoeffThresh' [-Wunused-const-variable] > static const uint16_t kCoeffThresh[16] = { > > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e655557a551c545f4153b0764269298cd01cd0c0 TBR=caryclark@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/795823005
* Roll libwebp to v0.4.2 (latest stable) to fix annoying build warning.Gravatar mtklein2014-12-15
| | | | | | | | | | | This warning should now go away: ../../third_party/externals/libwebp/src/enc/quant.c:105:23: warning: unused variable 'kCoeffThresh' [-Wunused-const-variable] static const uint16_t kCoeffThresh[16] = { BUG=skia: Review URL: https://codereview.chromium.org/807553002
* Rewrite NaN checks in terms of SkScalarIsNaN()Gravatar ehsan.akhgari2014-12-15
| | | | | | | | | | We are trying to replace Skia's NaN checker with our own in Mozilla, so it would be nice to have to patch a single place by making sure these NaN checks used SkScalarIsNaN(). BUG=skia: Review URL: https://codereview.chromium.org/809443002
* Remove SkCanvas::isDrawingToLayerGravatar junov2014-12-15
| | | | | | BUG=3245 Review URL: https://codereview.chromium.org/803913005
* Update SKP versionGravatar skia.buildbots2014-12-15
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/803183002
* final circles?Gravatar Brian Salomon2014-12-15
| | | | Review URL: https://codereview.chromium.org/796333005
* WAE on Macs too. That leaves only Android framework builds.Gravatar mtklein2014-12-15
| | | | | | | | | | Will rebase after yours lands. BUG=skia: Committed: https://skia.googlesource.com/skia/+/161b6dee11a67e877ef5b339b17775b8e44c5927 Review URL: https://codereview.chromium.org/804063002
* Revert of WAE on Macs too. That leaves only Android framework builds. ↵Gravatar mtklein2014-12-15
| | | | | | | | | | | | | | | | | | | | | | | (patchset #3 id:40001 of https://codereview.chromium.org/804063002/) Reason for revert: Forgot CrOS and NaCl builds. Original issue's description: > WAE on Macs too. That leaves only Android framework builds. > > Will rebase after yours lands. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/161b6dee11a67e877ef5b339b17775b8e44c5927 TBR=bsalomon@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/805043002
* WAE on Macs too. That leaves only Android framework builds.Gravatar mtklein2014-12-15
| | | | | | | | Will rebase after yours lands. BUG=skia: Review URL: https://codereview.chromium.org/804063002
* circles circles circlesGravatar Brian Salomon2014-12-15
| | | | | | TBR=bensong@google.com Review URL: https://codereview.chromium.org/805793003
* fix last warnings on w64 and turn on w.a.e.Gravatar bsalomon2014-12-15
| | | | Review URL: https://codereview.chromium.org/801413002
* Add SK_OVERRIDE to a few places that are missing it.Gravatar mtklein2014-12-15
| | | | | | | | | | This was done automatically by running clang-modernize -add-override -override-macros. It's not clear to me whether include/ is already clean or I just can't get the tool to work for headers. BUG=skia: Review URL: https://codereview.chromium.org/808463002
* Add more filetypes to DM's image tests.Gravatar scroggo2014-12-15
| | | | | | | | | | | ico, wbmp, plus the alternate suffix jpeg. Also check for capitalized versions, since files sometimes use capitalized suffixes. BUG=skia:3235 Review URL: https://codereview.chromium.org/798383003
* More circle rebaselines on gpuGravatar Brian Salomon2014-12-15
| | | | | | TBR=bensong@google.com Review URL: https://codereview.chromium.org/803123002
* Rebaseline after circle normalization change.Gravatar Brian Salomon2014-12-15
| | | | | | TBR=bensong@google.com Review URL: https://codereview.chromium.org/806893002
* add dumpHex option to rect and rrect, to match pathGravatar reed2014-12-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/801383002
* Do circle anti-aliasing in normalized space to avoid precision issues with ↵Gravatar bsalomon2014-12-15
| | | | | | half-floats on Adreno. Review URL: https://codereview.chromium.org/761593006
* ensure 4-byte alignment for storage, as SkWriterBuffer requires itGravatar reed2014-12-15
| | | | | | BUG=skia:3244 Review URL: https://codereview.chromium.org/805803002
* Cleanup: Mark some overridden methods with 'SK_OVERRIDE'.Gravatar tfarina2014-12-14
| | | | | | | | | | | | | | This fixes errors like this: ../../include/gpu/effects/GrPorterDuffXferProcessor.h:27:25: error: 'name' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] BUG=skia:3075 TEST=ninja -C out/Debug skia_lib TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/804813002
* add get9 and set9 to matrix, to aid in making keysGravatar reed2014-12-13
| | | | | | | | BUG=skia: TBR= NOTREECHECKS=True Review URL: https://codereview.chromium.org/806543002
* GLPrograms leak fixGravatar joshualitt2014-12-13
| | | | | | | | NOTREECHECKS=True TBR= BUG=skia: Review URL: https://codereview.chromium.org/799063005
* DM warning-free on win64Gravatar bsalomon2014-12-12
| | | | Review URL: https://codereview.chromium.org/805543002
* Add image decoding mode to DM.Gravatar mtklein2014-12-12
| | | | | | | | This is meant to supplant skimage. BUG=skia:3235 Review URL: https://codereview.chromium.org/802793002
* Even more win64 warning fixesGravatar bsalomon2014-12-12
| | | | Review URL: https://codereview.chromium.org/800993002
* Rebaselines.Gravatar scroggo2014-12-12
| | | | | | TBR=borenet Review URL: https://codereview.chromium.org/799063004
* Check in skimage expectations for nexus player.Gravatar scroggo2014-12-12
| | | | | | TBR=borenet Review URL: https://codereview.chromium.org/799113002
* improve cull, so we don't create empty segmentsGravatar reed2014-12-12
| | | | | | BUG=skia:3224 Review URL: https://codereview.chromium.org/798093002
* Harden validation for SkPathRefGravatar robertphillips2014-12-12
| | | | Review URL: https://codereview.chromium.org/801003003
* Add Herb as a Skia committerGravatar hcm2014-12-12
| | | | | | | | TBR=hcm@google.com NOTRY=true Review URL: https://codereview.chromium.org/803633002
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-09 18:01:50 +0000