aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Implement correct clipping for image filters.Gravatar senorblanco@chromium.org2014-02-05
| | | | | | | | | | | | | | | | | | | | | | | | | | Image filters in Skia currently clip the size of the the offscreen bitmap used for filtering to the device clip bounds. This means that any pixel-moving filter (e.g., blur) has edge artifacts at the clip boundaries. This is problematic for tiling, where a single SkPicture is played back with a clip set to the tile boundaries. By implementing the onFilterBounds() traversal, and using it in saveLayer() when a filter is present, we can clip the layer to the expanded clip rect. Note that this requires that the traversal be performed in reverse as compared to computeFastBounds(). (It's also done in device space, unlike computeFastBounds()). New test imagefiltersclipped tests pixel-moving filters when clipped by various clip rects. New test imageblurtiled tests tiled (compositor-style) rendering of blurred text. There should be no artifacts at the tile boundaries. BUG=337831 R=reed@google.com Review URL: https://codereview.chromium.org/23011012 git-svn-id: http://skia.googlecode.com/svn/trunk@13323 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix SampleApp for devices who don't support the full OpenGL APIGravatar commit-bot@chromium.org2014-02-05
| | | | | | | | | | R=bsalomon@google.com, ernstm@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/137223006 git-svn-id: http://skia.googlecode.com/svn/trunk@13322 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reland "Gyp file changes for the android framework."Gravatar scroggo@google.com2014-02-05
| | | | | | | | | | | | | | Relands https://codereview.chromium.org/153093003/, which was reverted with https://skia.googlesource.com/skia.git/+/eb6295044b97db05ec40625dcebc2459b2a38a98 This reverts commit 6b32be1402eb6c549d5ba1db71860e24f9de2991. BUG=skia:1975 R=djsollen@google.com Review URL: https://codereview.chromium.org/154053002 git-svn-id: http://skia.googlecode.com/svn/trunk@13321 2bbb7eff-a529-9590-31e7-b0007b416f81
* Stop discarding in frag shader when coverage is zero and stencil writes are ↵Gravatar commit-bot@chromium.org2014-02-05
| | | | | | | | | | | | | | | | | | | | | | | | enabled This fixes the corruption in the NVPR images here: http://108.170.217.252:10117/builders/Test-Win8-ShuttleA-GTX660-x86-Debug/builds/251/steps/CompareGMs/logs/stdio caused by: https://skia.googlesource.com/skia.git/+/65ee5f424cb4dabd453268902c00086605d77c1d The stencil path step writes inside and outside the clip when the clip is implemented by a coverage effect. The path cover step then doesn't write outside of the clip because the FS discards. This leaves stencil values outside of the clip non-zero which messed up subsequent path or clip draws to those samples. R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/154623002 git-svn-id: http://skia.googlecode.com/svn/trunk@13320 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove SkCanvas::createCompatibleDevice, and add SkCanvas::newSurfaceGravatar reed@google.com2014-02-05
| | | | | | | | | BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/154163002 git-svn-id: http://skia.googlecode.com/svn/trunk@13319 2bbb7eff-a529-9590-31e7-b0007b416f81
* Clean up SkPictureRecord.cppGravatar robertphillips@google.com2014-02-05
| | | | | | | | https://codereview.chromium.org/153983007/ git-svn-id: http://skia.googlecode.com/svn/trunk@13318 2bbb7eff-a529-9590-31e7-b0007b416f81
* Wider perf trigger range for N4 and N7 perf improvementsGravatar robertphillips@google.com2014-02-05
| | | | | | | | https://codereview.chromium.org/141013019/ git-svn-id: http://skia.googlecode.com/svn/trunk@13317 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-05
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13316 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add magnifier to rebaseline server.Gravatar commit-bot@chromium.org2014-02-04
| | | | | | | | | | | | NOTRY=true BUG=skia:1917 R=epoger@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/149473005 git-svn-id: http://skia.googlecode.com/svn/trunk@13315 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make SkFontMgr interface const.Gravatar commit-bot@chromium.org2014-02-04
| | | | | | | | | | | | COLLABORATOR=mtklein@chromium.org BUG=skia: R=reed@google.com, bungeman@google.com, mtklein@chromium.org Author: mtklein@google.com Review URL: https://codereview.chromium.org/134643028 git-svn-id: http://skia.googlecode.com/svn/trunk@13314 2bbb7eff-a529-9590-31e7-b0007b416f81
* Compilation fix for r13311 (Update SkPictureRecord to allow some ops to be ↵Gravatar robertphillips@google.com2014-02-04
| | | | | | written separately - https://codereview.chromium.org/153883002/) git-svn-id: http://skia.googlecode.com/svn/trunk@13313 2bbb7eff-a529-9590-31e7-b0007b416f81
* Ignore failures on GalaxyNexus and NexusSGravatar robertphillips@google.com2014-02-04
| | | | | | | | https://codereview.chromium.org/154223002/ git-svn-id: http://skia.googlecode.com/svn/trunk@13312 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update SkPictureRecord to allow some ops to be written separatelyGravatar robertphillips@google.com2014-02-04
| | | | | | | | https://codereview.chromium.org/153883002/ git-svn-id: http://skia.googlecode.com/svn/trunk@13311 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix crash in bench when "--mode record" is usedGravatar commit-bot@chromium.org2014-02-04
| | | | | | | | | | R=mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/150633008 git-svn-id: http://skia.googlecode.com/svn/trunk@13310 2bbb7eff-a529-9590-31e7-b0007b416f81
* TSAN: use somewhat pithier SK_ANNOTATE_UNPROTECTED_READ.Gravatar commit-bot@chromium.org2014-02-04
| | | | | | | | | | | | | | | This is a little bit better practice to be i than the existing SK_ANNOTATE_BENIGN_RACE, as UNPROTECTED_READ will only ignore reads, not writes. Tag SkRefCnt::unique() as a safe unprotected read like SkOnce's double-checked locking. BUG=skia: R=reed@google.com, bungeman@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/144953005 git-svn-id: http://skia.googlecode.com/svn/trunk@13309 2bbb7eff-a529-9590-31e7-b0007b416f81
* Added root deletion code to fix valgrind errorGravatar commit-bot@chromium.org2014-02-04
| | | | | | | | | | | BUG=skia: R=robertphillips@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/153893004 git-svn-id: http://skia.googlecode.com/svn/trunk@13308 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove kGL_Capability (unused)Gravatar reed@google.com2014-02-04
| | | | | | | | | BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/153993003 git-svn-id: http://skia.googlecode.com/svn/trunk@13307 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use GrConvexPolyEffect when clip is a single convex polygonGravatar commit-bot@chromium.org2014-02-04
| | | | | | | | | | | | | | BUG=skia:2051 Committed: http://code.google.com/p/skia/source/detail?r=13286 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/151523005 git-svn-id: http://skia.googlecode.com/svn/trunk@13306 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix int->scalar warningGravatar reed@google.com2014-02-04
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13305 2bbb7eff-a529-9590-31e7-b0007b416f81
* Gyp file changes for the android framework.Gravatar scroggo@google.com2014-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Split off from https://codereview.chromium.org/140503007/. The eventual goal is to create our Android.mk from gyp. This patch adds an option for skia_android_framework with the right settings. The follow-up (https://codereview.chromium.org/140503007/) will use scripts to create the final makefile. gyp/android_deps.gyp: Use different dependencies for the framework than for building Skia normally. gyp/android_framework_lib.gyp: Like skia_lib, specifies the minimum needed for building Skia, in this case for the framework. gyp/common_conditions.gypi: Add settings specific to skia_android_framework. In some cases this means turning off flags and defines. gyp/common.gypi Turn off SK_DEBUG and SK_DEVELOPER when building for the framework. This allows the framework to create a single makefile which can be modified to add SK_DEBUG and SK_DEVELOPER as desired. gyp/common_variables.gypi: Add skia_android_framework. gyp/core.gyp: Don't depend on cpufeatures, and add the cutils library for skia_android_framework. gyp/freetype.gyp: skia_android_framework-specific options: Don't include freetype_static as a dependency. Include the proper folders. Include the android library. gyp/images.gyp: Don't export libjpeg as a dependency for targets that include images for the framework. Also reorder image decoders to match the Android order, leaving our most commonly used ones last (and therefore first in the chain for trying them). gyp/libwebp.gyp: Use the system webp when building for the Android framework. Specify the correct settings for the framework. gyp/opts.gyp: Specify a default set of files to compile when there are no possible optimizations. gyp/pdf.gyp: Add dependencies for Android framework. gyp/zlib.gyp: Include the zlib folder, and undefine SK_ZLIB_INCLUDE. BUG=skia:1975 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=13298 Review URL: https://codereview.chromium.org/153093003 git-svn-id: http://skia.googlecode.com/svn/trunk@13304 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix samplefuzz, fix some 32/64bit warningsGravatar reed@google.com2014-02-04
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13303 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove (unused by chrome) SkDeferredCanvas(device) factory signatureGravatar reed@google.com2014-02-04
| | | | | | | | | BUG=skia: R=junov@chromium.org Review URL: https://codereview.chromium.org/136753016 git-svn-id: http://skia.googlecode.com/svn/trunk@13302 2bbb7eff-a529-9590-31e7-b0007b416f81
* convert gm tool to use surfaces instead of devicesGravatar reed@google.com2014-02-04
| | | | | | | | | BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/148783003 git-svn-id: http://skia.googlecode.com/svn/trunk@13301 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add rect clip to convex_poly_clip GMGravatar commit-bot@chromium.org2014-02-04
| | | | | | | | | | | BUG=skia:2051 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/147793007 git-svn-id: http://skia.googlecode.com/svn/trunk@13300 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove redundant GrContext parameter to NewRenderTargetDirectGravatar reed@google.com2014-02-04
| | | | | | | | | BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/151183003 git-svn-id: http://skia.googlecode.com/svn/trunk@13299 2bbb7eff-a529-9590-31e7-b0007b416f81
* Gyp file changes for the android framework.Gravatar scroggo@google.com2014-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Split off from https://codereview.chromium.org/140503007/. The eventual goal is to create our Android.mk from gyp. This patch adds an option for skia_android_framework with the right settings. The follow-up (https://codereview.chromium.org/140503007/) will use scripts to create the final makefile. gyp/android_deps.gyp: Use different dependencies for the framework than for building Skia normally. gyp/android_framework_lib.gyp: Like skia_lib, specifies the minimum needed for building Skia, in this case for the framework. gyp/common_conditions.gypi: Add settings specific to skia_android_framework. In some cases this means turning off flags and defines. gyp/common.gypi Turn off SK_DEBUG and SK_DEVELOPER when building for the framework. This allows the framework to create a single makefile which can be modified to add SK_DEBUG and SK_DEVELOPER as desired. gyp/common_variables.gypi: Add skia_android_framework. gyp/core.gyp: Don't depend on cpufeatures, and add the cutils library for skia_android_framework. gyp/freetype.gyp: skia_android_framework-specific options: Don't include freetype_static as a dependency. Include the proper folders. Include the android library. gyp/images.gyp: Don't export libjpeg as a dependency for targets that include images for the framework. Also reorder image decoders to match the Android order, leaving our most commonly used ones last (and therefore first in the chain for trying them). gyp/libwebp.gyp: Use the system webp when building for the Android framework. Specify the correct settings for the framework. gyp/opts.gyp: Specify a default set of files to compile when there are no possible optimizations. gyp/pdf.gyp: Add dependencies for Android framework. gyp/zlib.gyp: Include the zlib folder, and undefine SK_ZLIB_INCLUDE. BUG=skia:1975 R=djsollen@google.com Review URL: https://codereview.chromium.org/153093003 git-svn-id: http://skia.googlecode.com/svn/trunk@13298 2bbb7eff-a529-9590-31e7-b0007b416f81
* change benchmark to use surfaces instead of devices to specify its backendsGravatar reed@google.com2014-02-04
| | | | | | | | | BUG=skia: R=mtklein@google.com Review URL: https://codereview.chromium.org/153133002 git-svn-id: http://skia.googlecode.com/svn/trunk@13297 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-04
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13296 2bbb7eff-a529-9590-31e7-b0007b416f81
* More bot whack-a-mole: fix Win build.Gravatar senorblanco@chromium.org2014-02-04
| | | | | | | | | BUG=skia: TBR=fmalita@chromium.org Review URL: https://codereview.chromium.org/146073006 git-svn-id: http://skia.googlecode.com/svn/trunk@13295 2bbb7eff-a529-9590-31e7-b0007b416f81
* Speculative build fix after r13292.Gravatar fmalita@google.com2014-02-03
| | | | | | | | TBR=senorblanco@chromium.org Review URL: https://codereview.chromium.org/153213002 git-svn-id: http://skia.googlecode.com/svn/trunk@13294 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix skia_gpu=0 build.Gravatar senorblanco@chromium.org2014-02-03
| | | | | | | | | BUG=skia: TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/132503006 git-svn-id: http://skia.googlecode.com/svn/trunk@13293 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix image filter crop offsets for GPU path.Gravatar senorblanco@chromium.org2014-02-03
| | | | | | | | | | | | | This is the GPU-side version of https://codereview.chromium.org/112803004/. Also factored the crop offset unit test into a function, so we can call it with both CPU & GPU devices. R=bsalomon@google.com Review URL: https://codereview.chromium.org/153113003 git-svn-id: http://skia.googlecode.com/svn/trunk@13292 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to test the DownloadSKImageFiles fix.Gravatar fmalita@google.com2014-02-03
| | | | | | | | | TBR=borenet@google.com NOTRY=true Review URL: https://codereview.chromium.org/142093005 git-svn-id: http://skia.googlecode.com/svn/trunk@13291 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix script so that the error is actually printed if ant is not installedGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | R=scroggo@google.com, hcm@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/148793003 git-svn-id: http://skia.googlecode.com/svn/trunk@13290 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove tools/test_rendering.py and tools/test_pictures.pyGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | BUG=skia:2035 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/153083003 git-svn-id: http://skia.googlecode.com/svn/trunk@13289 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Use GrConvexPolyEffect when clip is a single convex polygon ↵Gravatar bsalomon@google.com2014-02-03
| | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/151523005/) Reason for revert: unit tests crashing on windows? Original issue's description: > Use GrConvexPolyEffect when clip is a single convex polygon > > BUG=skia:2051 > > Committed: http://code.google.com/p/skia/source/detail?r=13286 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2051 Review URL: https://codereview.chromium.org/142443006 git-svn-id: http://skia.googlecode.com/svn/trunk@13288 2bbb7eff-a529-9590-31e7-b0007b416f81
* rename tracing parameter to be more consistent with other methodsGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/136753013 git-svn-id: http://skia.googlecode.com/svn/trunk@13287 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use GrConvexPolyEffect when clip is a single convex polygonGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | BUG=skia:2051 R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/151523005 git-svn-id: http://skia.googlecode.com/svn/trunk@13286 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adding int cast to prevent warningGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | BUG=skia: R=fmalita@google.com, fmalita@chromium.org, bsalomon@google.com, bsalomon@chromium.org Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/149463009 git-svn-id: http://skia.googlecode.com/svn/trunk@13285 2bbb7eff-a529-9590-31e7-b0007b416f81
* don't initialize the default Skia tracer if one has already been providedGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/152903005 git-svn-id: http://skia.googlecode.com/svn/trunk@13284 2bbb7eff-a529-9590-31e7-b0007b416f81
* clean up a couple of parameters in the tracing interfaceGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/145973011 git-svn-id: http://skia.googlecode.com/svn/trunk@13283 2bbb7eff-a529-9590-31e7-b0007b416f81
* Initial QuadTree implementationGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | | | | | | | | In an effort to find a faster bounding box hierarchy than the R-Tree, a QuadTree has been implemented here. For now, the QuadTree construction is generally faster than the R-Tree and the queries are a bit slower, so overall, SKP local tests showed QuadTree performance similar to the R-Tree performance. Tests and bench are included in this cl. At this point, I'd like to be able to commit this in order to more easily use the bots to test multiple configurations and a larger number of SKPs. The R-Tree BBH is still used by default so this change shouldn't affect chromium. BUG=skia: R=junov@chromium.org, junov@google.com, senorblanco@google.com, senorblanco@chromium.org, reed@google.com, sugoi@google.com, fmalita@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/131343011 git-svn-id: http://skia.googlecode.com/svn/trunk@13282 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline imagefiltersgraph_gpu ↵Gravatar fmalita@google.com2014-02-03
| | | | | | | | | | | (Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release) BUG=skia:2118 TBR=senorblanco@chromium.org Review URL: https://codereview.chromium.org/148283012 git-svn-id: http://skia.googlecode.com/svn/trunk@13281 2bbb7eff-a529-9590-31e7-b0007b416f81
* hopefully last set of rebaselines for blurrectGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | | BUG=skia:2108 R=epoger@google.com TBR=epoger Author: humper@google.com Review URL: https://codereview.chromium.org/152803002 git-svn-id: http://skia.googlecode.com/svn/trunk@13280 2bbb7eff-a529-9590-31e7-b0007b416f81
* Allow GMs to be used as benchmarks. Make convex_poly_clip opt in.Gravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | R=reed@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/151843002 git-svn-id: http://skia.googlecode.com/svn/trunk@13279 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to test the new PRESUBMIT authors checkGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | | | BUG=skia:2072 NOTRY=true TBR= (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/139993010 git-svn-id: http://skia.googlecode.com/svn/trunk@13278 2bbb7eff-a529-9590-31e7-b0007b416f81
* Check if the issue owner is in the AUTHORS file in PRESUBMIT.pyGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | | | | BUG=skia:2072 NOTRY=true (SkipBuildbotRuns) R=borenet@google.com, hcm@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/131293005 git-svn-id: http://skia.googlecode.com/svn/trunk@13277 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix valgrind issue in SkBase64Test.cppGravatar robertphillips@google.com2014-02-01
| | | | | | | | https://codereview.chromium.org/152153002/ git-svn-id: http://skia.googlecode.com/svn/trunk@13276 2bbb7eff-a529-9590-31e7-b0007b416f81
* Performance trigger rebaselinesGravatar robertphillips@google.com2014-02-01
| | | | | | | | https://codereview.chromium.org/151833004/ git-svn-id: http://skia.googlecode.com/svn/trunk@13275 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-02-01
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@13274 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-24 13:37:47 +0000