| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
texture.
Review URL: https://codereview.chromium.org/1187523005
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Yesterday's RecreateSKPs_Canary run looks good:
http://build.chromium.org/p/client.skia.fyi/builders/Housekeeper-Nightly-RecreateSKPs_Canary/builds/143
The generated SKPs look very reasonably sized:
gs://chromium-skia-gm/playback_386/skps
BUG=skia:
NOTRY=true
Review URL: https://codereview.chromium.org/1191113002
|
|
|
|
|
|
|
|
|
| |
This file had one declaration in it which actually affected the
SkFontMgr and had nothing to do with typefaces specifically. As a
result, the declaration was moved to SkFontMgr_android.h. Now that
the users have been updated, remove this now unused file.
Review URL: https://codereview.chromium.org/1177173004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1185293006
|
|
|
|
|
|
|
|
|
|
| |
When calling SkRegion::writeToMemory(NULL), it should return the same
number of bytes that it writes when calling
SkRegion::writeToMemory(buffer). Add a test to confirm this.
BUG=b/21271229
Review URL: https://codereview.chromium.org/1188293002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1191943002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should be a drop-in replacement for most for-loops to make them run in parallel:
for (int i = 0; i < N; i++) { code... }
~~~>
sk_parallel_for(N, [&](int i) { code... });
This is just syntax sugar over SkTaskGroup to make this use case really easy to write.
There's no more overhead that we weren't already forced to add using an interface like batch(),
and no extra heap allocations.
I've replaced 3 uses of SkTaskGroup with sk_parallel_for:
1) My unit tests for SkOnce.
2) Cary's path fuzzer.
3) SkMultiPictureDraw.
Performance should be the same. Please compare left and right for readability. :)
BUG=skia:
No public API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1184373003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/1184153004/)
Reason for revert:
Seeing some Nexus 4 perf regressions in individual tests in Chromium that may be due to this change. This doesn't appear to be the correct fix for the bug in any case.
Original issue's description:
> Bump up point where we switch to distance fields for large glyphs
>
> This is hopefully a temporary fix. It's unclear why distance fields
> are so much slower on the N4 (and N7).
>
> BUG=chromium:467569
>
> Committed: https://skia.googlesource.com/skia/+/0fce1fb02d93e66d42528f322f8aa4ca64ff0fb2
TBR=joshualitt@google.com,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:467569
Review URL: https://codereview.chromium.org/1178713005
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1190993002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out _LIFO does work as we expected, keeping N < M threads active when we
have M live threads but only N units of work to do at a time. Also as we
expected _FIFO does round-robin through the threads.
Performance doesn't seem to be affected, but let's do it anyway.
If nothing else this makes profiles a little easier to read.
I don't see POSIX or Windows equivalents.
BUG=skia:
Review URL: https://codereview.chromium.org/1192433006
|
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/1178023003
|
|
|
|
|
|
|
|
|
|
|
| |
This allows a faster implementation of our SkTaskGroup thread pool.
It also means we don't need SkCondVar (which, remember, isn't supported on XP.)
Doing some testing with SampleApp, this really cuts down on the overhead from SkTaskGroup, e.g. 30% to 10%.
BUG=skia:
Review URL: https://codereview.chromium.org/1192573003
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think these changes to the subset benchmarks cover what we discussed yesterday.
I removed the divisor benchmarks (2x2, 3x3) and changed the single subset benchmarks.
Also, we will no longer benchmark subset decodes on small images.
BUG=skia:
Review URL: https://codereview.chromium.org/1188223002
|
|
|
|
|
|
|
|
| |
request https://codereview.chromium.org/1184953005 to land first
BUG=skia:
Review URL: https://codereview.chromium.org/1193553002
|
|
|
|
|
|
|
|
| |
This verifier is just informative now.
BUG=457428
Review URL: https://codereview.chromium.org/1193433003
|
|
|
|
|
|
|
|
|
|
| |
Good catch by Florin; the variable was indeed uninitialized in
the complex followed by concave case.
R=fmalita@google.com
BUG=skia:3953
Review URL: https://codereview.chromium.org/1187273005
|
|
|
|
|
|
|
|
| |
This moves the SkFontMgr::Factory implementation which creates a
FontMgr around FontConfig into its own file, and allows the user
to create one manually.
Review URL: https://codereview.chromium.org/1189753007
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use SkAtomic<int32_t> for pending work count so we're statically
forced to operate on it with atomic methods.
- Replacing old methods like sk_atomic_inc/dec gives us finer control
over which barriers we need for each operation.
No public API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1193493003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the GrTextContext be owned (and hidden) by the GrDrawContext. This funnels all the drawText* calls through the GrDrawContext and hides the (dispreferred) GrPipelineBuilder drawText variant.
Some consequences of this are:
GrDrawContext now has to get the text drawing settings (i.e., SkDeviceProperties & useDFT). This means that we need a separate GrDrawContext for each combination of pixel geometry and DFT-use.
All the GrTextContext-derived classes now get a back pointer to the originating GrDrawContext so their method calls no longer take one.
Committed: https://skia.googlesource.com/skia/+/5b16e740fe6ab6d679083d06f07651602265081b
Review URL: https://codereview.chromium.org/1175553002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1177833004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:120001 of https://codereview.chromium.org/1175553002/)
Reason for revert:
Breaking Test-Win8-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug ?
https://build.chromium.org/p/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug/builds/436/steps/dm/logs/stdio
Original issue's description:
> Make GrTextContext be owned by the GrDrawContext
>
> This CL makes the GrTextContext be owned (and hidden) by the GrDrawContext. This funnels all the drawText* calls through the GrDrawContext and hides the (dispreferred) GrPipelineBuilder drawText variant.
>
> Some consequences of this are:
>
> GrDrawContext now has to get the text drawing settings (i.e., SkDeviceProperties & useDFT). This means that we need a separate GrDrawContext for each combination of pixel geometry and DFT-use.
>
> All the GrTextContext-derived classes now get a back pointer to the originating GrDrawContext so their method calls no longer take one.
>
> Committed: https://skia.googlesource.com/skia/+/5b16e740fe6ab6d679083d06f07651602265081b
TBR=joshualitt@chromium.org,joshualitt@google.com,jvanverth@google.com,reed@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1178383003
|
|
|
|
|
|
| |
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1186393006
|
|
|
|
|
|
|
|
| |
Add flag to run in windowed mode.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1183193003
|
|
|
|
|
|
| |
BUG=chromium:486947
Review URL: https://codereview.chromium.org/1193453004
|
|
|
|
|
|
| |
Rename setFullscreen to makeFullscreen, drop the param, return a bool.
Review URL: https://codereview.chromium.org/1181723006
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the GrTextContext be owned (and hidden) by the GrDrawContext. This funnels all the drawText* calls through the GrDrawContext and hides the (dispreferred) GrPipelineBuilder drawText variant.
Some consequences of this are:
GrDrawContext now has to get the text drawing settings (i.e., SkDeviceProperties & useDFT). This means that we need a separate GrDrawContext for each combination of pixel geometry and DFT-use.
All the GrTextContext-derived classes now get a back pointer to the originating GrDrawContext so their method calls no longer take one.
Review URL: https://codereview.chromium.org/1175553002
|
|
|
|
|
|
|
|
| |
Make visualbench and SampleApp build in CONSOLE mode so that we can see stdout.
I verified that by undoing the gyp modifications both tools will build as GUI.
Review URL: https://codereview.chromium.org/1185303004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1185893007
|
|
|
|
|
|
|
|
|
| |
Let's make CPU-bound .SKP benching mimic Chrome's tiles.
Unfortunately, the CPU code also performs a lot better with those big wide tiles...
BUG=skia:
Review URL: https://codereview.chromium.org/1189863002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the example from the bug we had the filter DAG:
color filter (table)
0: xfermode filter (arith)
0: tile filter [0,80,34,114] -> [0,80,800,480]
0: color filter (table)
0: bitmap src 34x34 -> [0,80,34,114]
1: color filter (table)
0: picture filter [0, 80, 800, 480]
computeFastBounds was coming out of the DAG with a bound of [0,80,34,114] which didn't represent the pixels that would be drawn.
This CL updates SkTileImageFilter to correctly set the bound for the pixels it will hit.
BUG=493783
Committed: https://skia.googlesource.com/skia/+/05be93bbdf09576f7903130e3b106b0a8c7c4b4e
Committed: https://skia.googlesource.com/skia/+/0be685755f942baea26c66a87226b569fc17e960
Review URL: https://codereview.chromium.org/1152553006
|
|
|
|
|
|
|
|
| |
Replaced the compile time file IO security setting with a runtime setting.
Unfortunately the setting is global.
Review URL: https://codereview.chromium.org/1183853003
|
|
|
|
|
|
|
|
|
| |
This is hopefully a temporary fix. It's unclear why distance fields
are so much slower on the N4 (and N7).
BUG=chromium:467569
Review URL: https://codereview.chromium.org/1184153004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1191513002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1187643002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1184923002
|
|
|
|
|
|
|
|
| |
No longer used in Chromium/Blink.
R=reed@google.com,robertphillips@google.com,mtklein@google.com
Review URL: https://codereview.chromium.org/1153593003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1190563002
|
|
|
|
|
|
|
|
|
|
| |
Our bots don't seem to mind / see the race... let's see if Chrome's do.
BUG=chromium:496982
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1169033003
|
|
|
|
|
|
|
|
|
| |
This removes the last client of SkDrawFilter.
BUG=skia:3587
R=mtklein@google.com,robertphillips@google.com
Review URL: https://codereview.chromium.org/1181633005
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:3951
Committed: https://skia.googlesource.com/skia/+/ce9d11189a5924b47c3629063b72bae9d466c2c7
CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot
Review URL: https://codereview.chromium.org/1184113003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1191523003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/1184113003/)
Reason for revert:
https://code.google.com/p/skia/issues/detail?id=3951
Original issue's description:
> Thorough tests for saturatedAdd and mulDiv255Round.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/ce9d11189a5924b47c3629063b72bae9d466c2c7
TBR=fmalita@chromium.org,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1177123004
|
|
|
|
|
|
|
|
|
|
|
| |
This fix is necessary to correctly propagate invalidations that
are external to skia. For example, when drawing video or WebGL
into a 2D canvas in Chrome, with mipmaps enabled.
BUG=crbug.com/498356
TEST=GrTextureMipMapInvalidationTest
Review URL: https://codereview.chromium.org/1177843007
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mtklein
This reverts commit 93858b49a9f3bd3037d61822c095ef59199870af.
This revert should fix the Android framework build.
NOTREECHECKS=True
NOTRY=True
Review URL: https://codereview.chromium.org/1187463005
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1184113003
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it easier to benchmark _mpd variants in a profiler.
E.g.,
<profiler> out/Release/nanobench --images --config 8888 --loops -1 --match sp_desk_nytimes
BUG=skia:
Review URL: https://codereview.chromium.org/1184673006
|
|
|
|
|
|
|
|
|
|
| |
Portable fonts don't have streams, so expect the stream open
to fail.
R=bungeman@google.com
TBR=cdalton@nvidia.com
Review URL: https://codereview.chromium.org/1185803003
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1177313006
TBR=rmistry@google.com
Review URL: https://codereview.chromium.org/1177313006
|
|
|
|
|
|
|
|
|
| |
(one less SkDrawFilter user)
BUG=skia:3587
R=robertphillips@google.com,reed@google.com
Review URL: https://codereview.chromium.org/1177323002
|
|
|
|
|
|
|
|
|
|
|
|
| |
No longer used in Chromium.
R=reed@google.com
[mtklein mischief]
No one objects to removing dead API...
TBR=reed@google.com
Review URL: https://codereview.chromium.org/1151633003
|