| Commit message (Collapse) | Author | Age |
|
|
|
| |
Review URL: https://codereview.chromium.org/869783003
|
|
|
|
|
|
|
|
|
|
| |
Depends on https://codereview.chromium.org/873753002/
Thumbs up to CLion for refactoring this for me.
BUG=skia:
Review URL: https://codereview.chromium.org/867963004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/837723008
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/874643002
|
|
|
|
|
|
|
|
| |
This will let us kill flags.
BUG=skia:
Review URL: https://codereview.chromium.org/873753002
|
|
|
|
|
|
|
|
| |
The multi-picture-draw path should not ignore the inherited transform.
R=reed@google.com,robertphillips@google.com
Review URL: https://codereview.chromium.org/867303002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/872543002
|
|
|
|
|
|
|
|
|
|
| |
In the not so new pure Git world, 'svn fetch' and 'svn rebase' are not
needed anymore.
BUG=None
R=borenet@google.com
Review URL: https://codereview.chromium.org/872433004
|
|
|
|
|
|
| |
http://skiadocs.com:8000/dev/contrib/directory?cl=866133002
Review URL: https://codereview.chromium.org/866133002
|
|
|
|
|
|
| |
BUG=446164
Review URL: https://codereview.chromium.org/871993003
|
|
|
|
|
|
|
| |
TBR=mtklein@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/871993004
|
|
|
|
|
|
| |
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/872643005
|
|
|
|
| |
Review URL: https://codereview.chromium.org/870743002
|
|
|
|
|
|
|
|
| |
TBR=robertphillips@google.com
BUG=skia:3340
Review URL: https://codereview.chromium.org/866263007
|
|
|
|
|
|
|
|
| |
https://skia.org/dev/contrib/testing?cl=868983002
BUG=skia:
Review URL: https://codereview.chromium.org/868983002
|
|
|
|
|
|
|
|
|
|
|
|
| |
- add -Wsign-compare, which has been catching useful issues for Kimmo;
- add -Winit-self and -Wpointer-arith to Mac builds so everyone's using
the same flags;
- try try removing -Wno-uninitialized. This was only for the old 10.6
compiler that we have warnings set as non-errors now.
BUG=skia:
Review URL: https://codereview.chromium.org/872793002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/861323002
|
|
|
|
|
|
|
| |
gcc (Ubuntu/Linaro 4.6.4-1ubuntu1~12.04) 4.6.4
error: comparison between signed and unsigned integer expressions
Review URL: https://codereview.chromium.org/871013002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/873543002
|
|
|
|
|
|
|
| |
BUG=skia:3277
related bug: skbug.com/3276
Review URL: https://codereview.chromium.org/821083002
|
|
|
|
|
|
|
|
|
| |
This way if a bot crashes, we might get some partial results in gold rather
than none. We do the same sort of thing in nanobench for perf.
BUG=skia:3255
Review URL: https://codereview.chromium.org/872443003
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have been hacking at this test trying to understand why the N5 is
still sometimes crashy (it seems, less but not zero now). No luck so far.
But, while I've been reading and hacking at it, I think I've made a
few small improvements, mostly to readability.
BUG=skia:
Review URL: https://codereview.chromium.org/870803002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/869743002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/858123002
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/866383002
|
|
|
|
|
|
|
|
| |
"Constructors should not do real work"
I have verified that all test PDFs render identically.
Review URL: https://codereview.chromium.org/862113004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a speculative fix for the crashing N5 bots. It looks like the bots are
always failing in or around FloatingPointTextureTest.
It looks like sometimes they're hitting a SIGBUS, which I suspect is stack
overflow. FloatingPointTextureTest allocates ~320K on the stack, which may
be too much. This CL moves those buffers to the heap. For consistency I did
the same with the half-float tests, though they're only using ~1/8th the stack.
It looks like sometimes the bots are failing to malloc. I don't understand that,
and this CL doesn't address that directly. But it's possible this is still a stack
overflow, just trashing RAM and causing arbitrary mayhem instead of a SIGBUS.
I have no idea why this is a problem only on the N5. I have been unable to
reproduce this locally, neither with a K N5 nor an L N5, but the bots are pretty
reliable.
NOTREECHECKS=true
BUG=skia:
Review URL: https://codereview.chromium.org/871623002
|
|
|
|
|
|
|
| |
BUG=skia:
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/868783002
|
|
|
|
|
|
|
|
|
| |
logcat -c clears the log before we run.
logcat -d dumps the log stdout and exits.
BUG=skia:
Review URL: https://codereview.chromium.org/870643002
|
|
|
|
|
|
|
|
| |
Msan bot detects Use-of-uninitialized-value on the pad.
BUG=445745
Review URL: https://codereview.chromium.org/865913002
|
|
|
|
|
|
|
|
|
| |
Not a big deal, but matches the intention of it being a file-scoped function
better. This mirrors a recent google3 change for clients who don't use C++11.
BUG=skia:
Review URL: https://codereview.chromium.org/865243002
|
|
|
|
|
|
|
|
|
|
|
| |
In SkImageDecoder_libjpeg, modify cinfo *after* destroying it and
creating a new one in its place.
Should fix build breakage.
Committed: https://skia.googlesource.com/skia/+/3629865bac20ae8092177f519594f79f89d09fb0
Review URL: https://codereview.chromium.org/858333002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/858343002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/865873003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/869463002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/865103002
|
|
|
|
|
|
|
|
|
| |
Fix comment, constness of one field, and delete already checks for NULL.
TBR=reed@google.com
Trivial change to debatably public api.
Review URL: https://codereview.chromium.org/868643003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/866573002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/864833002
|
|
|
|
|
|
|
|
|
| |
SkStream::unref() was added to ease transitioning off of SkStream
deriving from SkRefCnt. It is no longer needed, remove it.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/861413002
|
|
|
|
|
|
|
|
| |
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/807263005
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To compile SkCondVar, we already require either pthreads or Windows. This
simplifies that code to not need SK_USE_POSIX_THREADS to be explicitly defined.
We'll just look to see if we're targeting Windows, and if not, assume pthreads.
Both before and after this CL, that code will fail to compile if we're not on
Windows and don't have pthreads.
BUG=skia:
Review URL: https://codereview.chromium.org/869443003
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This basically takes out the Windows-only hacks and promotes them to
cross-platform behavior driven by --gpu_threading.
- When --gpu_threading is false (the default), this puts GPU tasks and tests
together in the same GPU enclave. They all run serially.
- When --gpu_threading is true, both the tests and the tasks run totally
independently, just like the thread-safe CPU-bound work.
BUG=skia:3255
Review URL: https://codereview.chromium.org/847273005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/858333002/)
Reason for revert:
Appears to cause Android dm to segfault.
Original issue's description:
> Muck with the right cinfo.
>
> In SkImageDecoder_libjpeg, modify cinfo *after* destroying it and
> creating a new one in its place.
>
> Should fix build breakage.
>
> Committed: https://skia.googlesource.com/skia/+/3629865bac20ae8092177f519594f79f89d09fb0
TBR=scroggo@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/858323003
|
|
|
|
|
|
|
|
|
| |
In SkImageDecoder_libjpeg, modify cinfo *after* destroying it and
creating a new one in its place.
Should fix build breakage.
Review URL: https://codereview.chromium.org/858333002
|
|
|
|
|
|
| |
BUG=skia:3255
Review URL: https://codereview.chromium.org/859303003
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SkDeferredCanvas uses a simple pipe: no cross-process, no shared-address, etc.
(see src/utils/SkDeferredCanvas.cpp:306).
We could just remove these modes from the bot configs, but I'd like to take the
opportunity to simplify the DM code too. I'll happily volunteer to put things
back should we decide we want to test these modes.
BUG=skia:
Review URL: https://codereview.chromium.org/861303003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
header in core/
This fixes two problems:
1) #include SK_SOME_DEFINE doesn't work well for all our clients.
2) Things in include/ are #including things in src/, which we don't like.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/862983002
|
|
|
|
|
|
|
| |
Motivation: currently we rely on mutexes for guarding static
initialization. These mutexes will go away.
Review URL: https://codereview.chromium.org/815223005
|
|
|
|
|
|
|
|
|
|
| |
Should have been included with https://codereview.chromium.org/860353005/
TBR=bungeman@google.com
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/844193007
|