aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Use SkOnce to squelch command buffer spamGravatar brianosman2016-09-29
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382793002 Review-Url: https://codereview.chromium.org/2382793002
* Recent image filter work now allows this check to be enabled.Gravatar brianosman2016-09-29
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379053002 Review-Url: https://codereview.chromium.org/2379053002
* Revert of Explicit control in tools of ANGLE frontend and backend (patchset ↵Gravatar bsalomon2016-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:90001 of https://codereview.chromium.org/2381033002/ ) Reason for revert: Broke bots Original issue's description: > Explicit control in tools of ANGLE frontend and backend > > Update the ANGLE test GL context, GrContextFactory, and config parsing to allow explicit control of ANGLE front/backend. > > This will allow us to explicitly test ES2 vs ES3 interfaces to ANGLE as well as D3D9, D3D11, and OpenGL backends. > > Also makes the angle api types valid in all builds (but will just fail when SK_ANGLE=1 or not on windows for the d3d backends). > > BUG=skia:5804 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381033002 > > Committed: https://skia.googlesource.com/skia/+/50094fb489543655df026be4e4f99e09e57a1f49 TBR=brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5804 Review-Url: https://codereview.chromium.org/2384483003
* Explicit control in tools of ANGLE frontend and backendGravatar bsalomon2016-09-29
| | | | | | | | | | | | | | | | Update the ANGLE test GL context, GrContextFactory, and config parsing to allow explicit control of ANGLE front/backend. This will allow us to explicitly test ES2 vs ES3 interfaces to ANGLE as well as D3D9, D3D11, and OpenGL backends. Also makes the angle api types valid in all builds (but will just fail when SK_ANGLE=1 or not on windows for the d3d backends). BUG=skia:5804 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381033002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2381033002
* Revert of Add SK_SUPPORT_LEGACY_HAIRLINE_END_CAP to work around dependent ↵Gravatar benjaminwagner2016-09-29
| | | | | | | | | | | | | | | | | | | | | | | | test failure. (patchset #1 id:1 of https://codereview.chromium.org/2379843002/ ) Reason for revert: Dependent test has been fixed. Original issue's description: > Add SK_SUPPORT_LEGACY_HAIRLINE_END_CAP to work around dependent test failure. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379843002 > > Committed: https://skia.googlesource.com/skia/+/aa6ef3ebc60e0f70db0e599f4cd34d5be06486c9 TBR=caryclark@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2379993004
* Start moving SkRasterPipeline stages to SkOpts.Gravatar Mike Klein2016-09-29
| | | | | | | | | | | | | | | | | | | | This lets them pick up runtime CPU specializations. Here I've plugged in SSE4.1. This is still one of the N prelude CLs to full 8-at-a-time AVX. I've moved the union of the stages used by SkRasterPipelineBench and SkRasterPipelineBlitter to SkOpts... they'll all be used by the blitter eventually. Picking up SSE4.1 specialization here (even still just 4 pixels at a time) is a significant speedup, especially to store_srgb(), so much that it's no longer really interesting to compare against the fused-but-default-instruction-set version in the bench. So that's gone now. That left the SkRasterPipeline unit test as the only other user of the EasyFn simplified interface to SkRasterPipeline. So I converted that back down to the bare-metal interface, and EasyFn and its friends became SkRasterPipeline_opts.h exclusive abbreviations (now called Kernel_Sk4f). This isn't really unexpected: SkXfermode also wanted to build up its own little abstractions, and once you build your own abstraction, the value of an additional EasyFn-like layer plummets to negative. For simplicity I've left the SkXfermode stages alone, except srcover() which was always part of the blitter. No particular reason except keeping the churn down while I hack. These _can_ be in SkOpts, but don't have to be until we go 8-at-a-time. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2752 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Change-Id: I3b476b18232a1598d8977e425be2150059ab71dc Reviewed-on: https://skia-review.googlesource.com/2752 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Disable FP contraction on -Fast bot.Gravatar Mike Klein2016-09-29
| | | | | | | | | | | | | | | It's more annoying than helpful to have GCC turn mul,add into fma. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2780 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Fast-Trybot Change-Id: I63f4615f73aed112f10f6cb516d899b820918298 Reviewed-on: https://skia-review.googlesource.com/2780 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Cary Clark <caryclark@google.com>
* *SkTCast<int*>(float*) -> memcpyGravatar Mike Klein2016-09-29
| | | | | | | | | | | | | | | In some build configurations (I think, GN, GCC 6, Debug) I get a warning that i is used unintialized. This likely has something to do with GCC correctly seeing that the SkTCast construction there is illegal aliasing, and perhaps thus "doesn't happen". Might be that if the SkTCast gets inlined, it decides its implementation is secretly kosher, and so Release builds don't see this. None of this happens with the GCCs we have on the bots... too old? Instead use memcpy() here, which is well defined to do what we intended. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2758 Change-Id: Iaf5c75fbd852193b0b861bf5e71450502511d102 Reviewed-on: https://skia-review.googlesource.com/2758 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* SkPDF/Documentation: backend limitationsGravatar halcanary2016-09-29
| | | | | | NOTRY=true Review-Url: https://codereview.chromium.org/2377473002
* Fix obvious bug in KTX encoder.Gravatar benjaminwagner2016-09-29
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2383523002 Review-Url: https://codereview.chromium.org/2383523002
* Fix gamut GM to work w/serialization configs. Remove it from blacklist.Gravatar brianosman2016-09-29
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2383513002 Review-Url: https://codereview.chromium.org/2383513002
* Add SK_SUPPORT_LEGACY_HAIRLINE_END_CAP to work around dependent test failure.Gravatar benjaminwagner2016-09-29
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379843002 Review-Url: https://codereview.chromium.org/2379843002
* skpbench: use accumulative result as the defaultGravatar csmartdalton2016-09-29
| | | | | | | | | | | Uses accum instead of median for the first column in skpbench.cpp, and the default result for parseskpbench.py. The accum is empirically proving to be more repeatable than the median. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378383002 Review-Url: https://codereview.chromium.org/2378383002
* skpbench: use double buffering instead of tripleGravatar csmartdalton2016-09-28
| | | | | | | | | | | We have no need for our command stream to get more than a couple of frames deep. Any more and we only increase our chances of sporadic flushing and unreliable timings. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376043002 Review-Url: https://codereview.chromium.org/2376043002
* isABitmap is deprecated, use isAImageGravatar Mike Reed2016-09-28
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2748 Change-Id: I7006a3231ff0e9e39b187deae550364bc97f49d6 Reviewed-on: https://skia-review.googlesource.com/2748 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Improve GN to CMake translation for building.Gravatar bungeman2016-09-28
| | | | | | | | | | This adds proper target types, dependencies, and library handling. This is enough to build and run dm on Linux and Mac. Change-Id: I5220f67f7dd3dbada7ad03ef83fff8fd80158fad Reviewed-on: https://skia-review.googlesource.com/2664 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Tag checkerboard bitmaps as sRGBGravatar brianosman2016-09-28
| | | | | | | | | | | | | | | Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 Review-Url: https://codereview.chromium.org/2368933003
* Latest ANGLE as of September 27, 2016Gravatar brianosman2016-09-28
| | | | | | | | | | | | | Includes a fix for ES3 texture reuse that solves many of the problems we saw using ES3. (There are still issues with some YUV planes). Also includes a fix for anglebug.com/1478, so half-float formats are allowed again. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302993004 Review-Url: https://codereview.chromium.org/2302993004
* skpbench: run for a fixed durationGravatar csmartdalton2016-09-28
| | | | | | | | | Runs for a fixed amount of time instead of a fixed amount of samples. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2374093002 Review-Url: https://codereview.chromium.org/2374093002
* Make applyCropRect/pad_image convert to the output color spaceGravatar brianosman2016-09-28
| | | | | | | | | | The source's color space may not be renderable, leading to makeSurface failing. This is unfortunate, but this solution is by far the simplest. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2380833002 Review-Url: https://codereview.chromium.org/2380833002
* Use brackets for explicit GPU config params in toolsGravatar bsalomon2016-09-28
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378163003 Review-Url: https://codereview.chromium.org/2378163003
* monobench: usability tweaksGravatar Mike Klein2016-09-28
| | | | | | | | | | | | | | | - Allow an second argument to limit the number of samples. - If no benchmarks match, warn and exit instead of infinitely looping. The default limit of 2147483647 10ms samples will run for 9 months, which I think is long enough to not need any special infinity logic. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2747 Change-Id: Id70cf77b624e19dc04e1d75a71385aee3c988a80 Reviewed-on: https://skia-review.googlesource.com/2747 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll buildtools adb8bf4e8fc..5fd66957f08bb7Gravatar Ben Wagner2016-09-28
| | | | | | | | | | | | | | https://chromium.googlesource.com/chromium/buildtools/+log/adb8bf4e8fc..5fd66957f08bb7 Primarily to pick up https://chromium.googlesource.com/chromium/src/+/d51d3527da33 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2749 Change-Id: I3f9ac18c8946fa28effcf8c8cff3bbd1120a86df Reviewed-on: https://skia-review.googlesource.com/2749 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
* Gradients are serialized (and can be constructed) as SkColor4f + SkColorSpaceGravatar brianosman2016-09-28
| | | | | | | | | | | | | | | | | | | | Added gradient shader factories that take SkColor4f + SkColorSpace. Modified Descriptor to only store SkColor4f + SkColorSpace. Existing factories make use of helper code to convert SkColor and forward to the new factories. Bumped SKP version to handle new gradient serialization format. I was toying with using half-float when serializing SkColor4f, despite my aggressive packing of flags, this format is significantly bigger. Also added GM to use 4f factories. This GM should (and does) look identical to the existing gradients GM. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002 Review-Url: https://codereview.chromium.org/2370063002
* documentation: update PDF design docGravatar halcanary2016-09-28
| | | | | | NOTRY=true Review-Url: https://codereview.chromium.org/2295373002
* Move toXYZD50() to SkColorSpace_BaseGravatar msarett2016-09-28
| | | | | | | | | | | | SkColorSpace needs to become more versatile, in order to support profiles that cannot specified with just a "to XYZ D50" matrix. This a just first step to clean up the public API. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381553002 Review-Url: https://codereview.chromium.org/2381553002
* SkRasterPipeline: fuse clamp_01 into stores.Gravatar Mike Klein2016-09-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a less generally applicable trick than I have previously hoped. The need to thread through contexts into each stage really means you can only include one context-dependent stage in each fused batch. We can still manually fuse these, of course, as you can see in SkRasterPipelineBench. It's just that we can't really write a generic compile-time template to do it except for context-free stages. And since we can't write a generic version, and I have only this one specific use case right now, I've kept it quite specific to that use case. This does work pretty well for this use case, though. Here's the fused clamp-then-store-565: +0x00 pushq %rbp +0x01 movq %rsp, %rbp +0x04 movq 8(%rdi), %rax +0x08 xorps %xmm4, %xmm4 +0x0b maxps %xmm4, %xmm3 +0x0e maxps %xmm4, %xmm0 +0x11 maxps %xmm4, %xmm1 +0x14 maxps %xmm4, %xmm2 +0x17 minps 4262818(%rip), %xmm3 +0x1e minps %xmm3, %xmm0 +0x21 minps %xmm3, %xmm1 +0x24 minps %xmm3, %xmm2 +0x27 movaps 4965378(%rip), %xmm3 +0x2e mulps %xmm3, %xmm0 +0x31 cvtps2dq %xmm0, %xmm0 +0x35 pslld $11, %xmm0 +0x3a mulps 4965375(%rip), %xmm1 +0x41 cvtps2dq %xmm1, %xmm1 +0x45 pslld $5, %xmm1 +0x4a mulps %xmm3, %xmm2 +0x4d cvtps2dq %xmm2, %xmm2 +0x51 orpd %xmm0, %xmm2 +0x55 orpd %xmm1, %xmm2 +0x59 pshufb 4474510(%rip), %xmm2 +0x62 movq %xmm2, (%rax,%rsi,2) +0x67 popq %rbp +0x68 retq BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2745 Change-Id: Ia7d66aecc6cbff154158d2600d7874feed1a76f6 Reviewed-on: https://skia-review.googlesource.com/2745 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkPDF: use SkImage::isAImageGravatar Hal Canary2016-09-28
| | | | | | | | | | | | | | output size savings = ~0.4% with effected gms and skps. BUG=568816 BUG=skia:5592 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2760 Change-Id: Ifead46ea5789e18aa3ddea9ca3986717296a6391 Reviewed-on: https://skia-review.googlesource.com/2760 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* fix cubic linear testGravatar caryclark2016-09-28
| | | | | | | | | | | | | | Check to see if the line between end points is degenerate before measuring control points. Also, add test case for a bug to see if it shows up on any platform. TBR=reed@google.com BUG=skia:5169, skia:5240 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375053002 Review-Url: https://codereview.chromium.org/2375053002
* Make GPU configs use kRGBA color type not kN32.Gravatar bsalomon2016-09-28
| | | | | | | | | This makes ES msaa contexts testable on systems where kN32 is compiled as kBGRA due to the fact that render buffers are not always supported for GL_BGRA with GL_EXT_texture_format_BGRA8888. BUG=skia:5804 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378713002 Review-Url: https://codereview.chromium.org/2378713002
* Rearrange SkRasterPipeline scanline tail handling.Gravatar Mike Klein2016-09-28
| | | | | | | | | | | | | | | | | | | We used to step at a 4-pixel stride as long as possible, then run up to 3 times, one pixel at a time. Now replace those 1-at-a-time runs with a single tail stamp if there are 1-3 remaining pixels. This style is simply more efficient: e.g. we'll blend and lerp once for 3 pixels instead of 3 times. This should make short blits significantly more efficient. It's also more future-oriented... AVX+ on Intel and SVE on ARM support masked loads and stores, so we can do the entire tail in one direct step. This also makes it possible to re-arrange the code a bit to encapsulate each stage better. I think generally this code reads more clearly than the old code, but YMMV. I've arranged things so you write one function, but it's compiled into two specializations, one for tail=0 (Body) and one for tail>0 (Tail). It's pretty tidy. For now I've just burned a register to pass around tail. It's 2 bits now, maybe soon 3 with AVX, and capped at 4 for even the craziest new toys, so there are plenty of places we can pack it if we want to get clever. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2717 Change-Id: I45852a3e5d4c5b5e9315302c46601aee0d32265f Reviewed-on: https://skia-review.googlesource.com/2717 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert of Tag checkerboard bitmaps as sRGB (patchset #1 id:1 of ↵Gravatar brianosman2016-09-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2368933003/ ) Reason for revert: Regression on displacement GM when sRGB support is lacking. Original issue's description: > Tag checkerboard bitmaps as sRGB > > Significantly reduces the diff between legacy and sRGB/F16 on about 25 > GMs. This is just the biggest piece of low-hanging fruit. Many GMs create > N32 raster surfaces to procedurally generate source textures, and I'd like > to fix all of them. It's much easier to reason about the GMs (is sRGB > doing the right thing) when everything is tagged like this - the only > expected differences are due to filtering and blending. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 > > Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 TBR=mtklein@google.com,reed@google.com,robertphillips@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Review-Url: https://codereview.chromium.org/2375063002
* Hide monobench target on debug builds.Gravatar Mike Klein2016-09-28
| | | | | | | | | | | | | | Unlike nanobench this tool has no purpose when built in Debug mode. Just don't let it happen. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2718 Change-Id: Iaa7b8c44d46024485d4f5ce3d9c3e33d865b99d7 Reviewed-on: https://skia-review.googlesource.com/2718 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Make SkPMColor BGRA on Fuchsia.Gravatar Mike Klein2016-09-28
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2700 Change-Id: I59b8463adcf3d49af524fec379e3b563dcbcbf6b Reviewed-on: https://skia-review.googlesource.com/2700 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Added kSRGBLinear_Named color space, along with testsGravatar brianosman2016-09-27
| | | | | | | | | | | | Gradients (and other shaders) are going to end up serializing this particular color space very frequently, so we want a shorthand way of writing it out. I think it's also helpful to have a clearer way of creating it (vs. NewNamed(kSRGB_Named)->makeLinearGamma()). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2377763002 Review-Url: https://codereview.chromium.org/2377763002
* Add SK_SUPPORT_LEGACY_ARITHMETICMODE flag to public.bzl.Gravatar benjaminwagner2016-09-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2372703007 Review-Url: https://codereview.chromium.org/2372703007
* Add command buffer submits before copy calls in vulkan.Gravatar egdaniel2016-09-27
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363773006 Committed: https://skia.googlesource.com/skia/+/25661bac7722860b7589c5b01ec404531d941456 Review-Url: https://codereview.chromium.org/2363773006
* SkRasterPipeline: add last() and docs.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | | | | | | | Today if you use the simple SK_RASTER_STAGE interface to build a pipeline, each stage you add calls into a next stage. The last stage you add calls into a special backstop stage JustReturn that, well, just returns, ending the pipeline. This adds last(), which cuts that last stage off the pipeline. Instead, the stage you add using last() returns directly, ending the pipeline itself without jumping into JustReturn. This reduces the overhead of using the pipelined version of SkRasterPipelineBench from ~25% to ~20% on my desktop. Also, add docs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2713 Change-Id: I11469378e2765c6e34db52eb3eef648d6612da3f Reviewed-on: https://skia-review.googlesource.com/2713 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Turn on -Wgnu-anonymous-struct and -Wnested-anonymous-types.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | I'm not seeing any problems with these locally. Perhaps the bots have something to say. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2709 Change-Id: I6f0c7045c8f270efcd71d837f22a40e9f9d3e9b7 Reviewed-on: https://skia-review.googlesource.com/2709 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Revert of Add command buffer submits before copy calls in vulkan. (patchset ↵Gravatar egdaniel2016-09-27
| | | | | | | | | | | | | | | | | | | | | | | | #5 id:80001 of https://codereview.chromium.org/2363773006/ ) Reason for revert: breaking things since apparently nvidia != windows always... Original issue's description: > Add command buffer submits before copy calls in vulkan. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363773006 > > Committed: https://skia.googlesource.com/skia/+/25661bac7722860b7589c5b01ec404531d941456 TBR=jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2373503004
* GN: match shell behavior for cc and cxx in is_clang.pyGravatar csmartdalton2016-09-27
| | | | | | | | | | Interprets cc/cxx as part of the shell command rather than literal arguments. This matches the behavior of shell invocations from ninja. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375573002 Review-Url: https://codereview.chromium.org/2375573002
* OverAlignedTest: use sk_ malloc and free.Gravatar Mike Klein2016-09-27
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2712 Change-Id: I73b2b45ba6a1303b957aa03953eef305f8be9144 Reviewed-on: https://skia-review.googlesource.com/2712 Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Update vulkan varying locations to correctly handle arraysGravatar egdaniel2016-09-27
| | | | | | | BUG=skia:5797 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369013006 Review-Url: https://codereview.chromium.org/2369013006
* Add command buffer submits before copy calls in vulkan.Gravatar egdaniel2016-09-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363773006 Review-Url: https://codereview.chromium.org/2363773006
* Fix dm/nanobench uploads for Gerrit-based trybotsGravatar Eric Boren2016-09-27
| | | | | | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2710 Change-Id: I43f03b19a9d7223b67de7dc7c4efea8cb75dba05 Reviewed-on: https://skia-review.googlesource.com/2710 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Turn on -Wnewline-eof.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | I don't know _why_ Clang would like these .inc files to have a newline at the end of the file, but it seems a harmless way to silence the warning. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2711 Change-Id: I6c530ee5096c48c91ddf322aca916e70a0dd770b Reviewed-on: https://skia-review.googlesource.com/2711 Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* another attempt to fix nonrectangularGravatar caryclark2016-09-27
| | | | | | | | | | | | | For hairlines extended by the end cap, set the first point to the first curve following a move, which has had its position adjusted. R=fmalita@chromium.org BUG=617658 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2371143002 Review-Url: https://codereview.chromium.org/2371143002
* need to apply CTM to clip rect in arithmetic imagefilterGravatar Mike Reed2016-09-27
| | | | | | | | | | | | | | BUG=skia:5800 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2708 NOTRY=True upload steps are failing, but the tests themselves passed Change-Id: I0210d0095b4ffdd376f18fad895655d39714bf38 Reviewed-on: https://skia-review.googlesource.com/2708 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* [task scheduler] Add uploads to tasks.jsonGravatar borenet2016-09-27
| | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376713002 Review-Url: https://codereview.chromium.org/2376713002
* Remove gen_bench_expectations_from_codereviewGravatar borenet2016-09-27
| | | | | | | | | It hasn't been used in a long time. BUG=skia:2969 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2373803002 Review-Url: https://codereview.chromium.org/2373803002
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-05 12:36:08 +0000