aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* rename rebaseline_server JSON constants to be more consistentGravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | | | | (no behavioral change, no change to JSON file format) (SkipBuildbotRuns) NOTREECHECKS=True NOTRY=True R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/287473002 git-svn-id: http://skia.googlecode.com/svn/trunk@14701 2bbb7eff-a529-9590-31e7-b0007b416f81
* bench rebase after 261d015Gravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | R=robertphillips@google.com TBR=robertphillips@google.com NOTRY=true Author: bensong@google.com Review URL: https://codereview.chromium.org/280683002 git-svn-id: http://skia.googlecode.com/svn/trunk@14700 2bbb7eff-a529-9590-31e7-b0007b416f81
* apply localmatrix in pre-order, to match other shadersGravatar reed@google.com2014-05-12
| | | | | | | | BUG=skia: Review URL: https://codereview.chromium.org/280293002 git-svn-id: http://skia.googlecode.com/svn/trunk@14699 2bbb7eff-a529-9590-31e7-b0007b416f81
* add new perlin noise gm to test localmatrixGravatar reed@google.com2014-05-12
| | | | | | | | BUG=skia: Review URL: https://codereview.chromium.org/283533002 git-svn-id: http://skia.googlecode.com/svn/trunk@14698 2bbb7eff-a529-9590-31e7-b0007b416f81
* Clean up global gSkSuppressFontCachePurgeSpew.Gravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | | | | | | | No one is using it except to flick it to true to shut up the spew, but the spew is already guarded by #ifdef SPEW_PURGE_STATUS. Let's leave it to SPEW_PURGE_STATUS. Noticed this specificially when TSAN complained about FontScalerBench modifying it in a thread-unsafe way. BUG=skia:1792 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/264333008 git-svn-id: http://skia.googlecode.com/svn/trunk@14697 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make gMask_00FF00FF a constantGravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | | | | | | | | | | | | This is to optimize SkAlphaMulQ() in PIC mode. With the visibility=default symbol the constant is not known at compile time (and is not a constant), but instead is fetched through a double indirection through GOT. The function is quite hot on one of the chromium benchmarks: rasterize_and_record_micro.key_silk_cases. This change replaces the symbol with a compile-time constant. As a bonus the variable is not exported from the dynamic library, i. e. a cleaner library interface. See specific performance improvements on Android here: http://goo.gl/iMuTDt R=skyostil@chromium.org, tomhudson@chromium.org, mtklein@google.com, reed@google.com, tomhudson@google.com Author: pasko@chromium.org Review URL: https://codereview.chromium.org/270473003 git-svn-id: http://skia.googlecode.com/svn/trunk@14696 2bbb7eff-a529-9590-31e7-b0007b416f81
* add --readJsonSummaryPath to render_picturesGravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | BUG=skia:1942 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/273783004 git-svn-id: http://skia.googlecode.com/svn/trunk@14695 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adds the ability to filter bench expectations in builder/config level.Gravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | BUG=skia:2539 NOTRY=true R=rmistry@google.com Author: bensong@google.com Review URL: https://codereview.chromium.org/277163002 git-svn-id: http://skia.googlecode.com/svn/trunk@14694 2bbb7eff-a529-9590-31e7-b0007b416f81
* Improved x86 SSE build and run-time checks.Gravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | | | | | | | | | Replaces the current build/run-time checks for SSE level in opts_check_x86.cpp with a simpler and more future-proof version. Also adds SSE versions 4.1 and 4.2 to the config file. Author: henrik.smiding@intel.com Signed-off-by: Henrik Smiding <henrik.smiding@intel.com> Committed: http://code.google.com/p/skia/source/detail?r=14644 R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com Author: henrik.smiding@intel.com Review URL: https://codereview.chromium.org/272503006 git-svn-id: http://skia.googlecode.com/svn/trunk@14693 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.Gravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | | | | | | Chrome/Blink doesn't use any of the legacy methods behind this flag any more. BUG=skia:2187 Committed: http://code.google.com/p/skia/source/detail?r=14651 R=reed@google.com Author: dominikg@chromium.org Review URL: https://codereview.chromium.org/265973002 git-svn-id: http://skia.googlecode.com/svn/trunk@14692 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove unused Kernel33MaskFilterGravatar commit-bot@chromium.org2014-05-12
| | | | | | | | | | | R=robertphillips@google.com TBR=robertphilips@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/280233002 git-svn-id: http://skia.googlecode.com/svn/trunk@14691 2bbb7eff-a529-9590-31e7-b0007b416f81
* bench rebase after 108eddbGravatar commit-bot@chromium.org2014-05-10
| | | | | | | | | | | | R=robertphillips@google.com TBR=robertphillips@google.com NOTRY=true Author: bensong@google.com Review URL: https://codereview.chromium.org/275353002 git-svn-id: http://skia.googlecode.com/svn/trunk@14690 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-05-10
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@14689 2bbb7eff-a529-9590-31e7-b0007b416f81
* add localmatrix param to asNewEffectGravatar reed@google.com2014-05-09
| | | | | | | | BUG=skia: Review URL: https://codereview.chromium.org/278983002 git-svn-id: http://skia.googlecode.com/svn/trunk@14688 2bbb7eff-a529-9590-31e7-b0007b416f81
* Factor GrTexture into public GrTexture and private GrTextureImpl.Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | Committed: http://code.google.com/p/skia/source/detail?r=14680 R=jvanverth@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/275903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14687 2bbb7eff-a529-9590-31e7-b0007b416f81
* add localmatrix parameter to shader's asNewEffectGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com, dominikg@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/278963002 git-svn-id: http://skia.googlecode.com/svn/trunk@14686 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "remove SK_SUPPORT_LEGACY_BUILDMIPMAP"Gravatar reed@google.com2014-05-09
| | | | | | This reverts commit 9acd04797101990af23f5c374b7dfcbaac12fd2b. git-svn-id: http://skia.googlecode.com/svn/trunk@14685 2bbb7eff-a529-9590-31e7-b0007b416f81
* remove SK_SUPPORT_LEGACY_BUILDMIPMAPGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | TBR=djsollen@google.com NOTRY=True Author: reed@google.com Review URL: https://codereview.chromium.org/271253002 git-svn-id: http://skia.googlecode.com/svn/trunk@14684 2bbb7eff-a529-9590-31e7-b0007b416f81
* Un-swap underline position and thickness calcualtions in DirectWrite.Gravatar bungeman@google.com2014-05-09
| | | | | | | The change at r13635 got these backwards. git-svn-id: http://skia.googlecode.com/svn/trunk@14683 2bbb7eff-a529-9590-31e7-b0007b416f81
* Flatten resources directoryGravatar halcanary@google.com2014-05-09
| | | | | | | | | | | | | | On android trybots, the files in a subdirectory weren't being loaded onto the device. Consequently, the ImageDecoderOptions test was not testing anything. I had to relax that unit test to reflect the existing behavior of our libjpeg decoder on Android. R=djsollen@google.com Review URL: https://codereview.chromium.org/264583007 git-svn-id: http://skia.googlecode.com/svn/trunk@14682 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Factor GrTexture into public GrTexture and private GrTextureImpl. ↵Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/275903002/) Reason for revert: Breaks chrome build. Original issue's description: > Factor GrTexture into public GrTexture and private GrTextureImpl. > > Committed: http://code.google.com/p/skia/source/detail?r=14680 R=jvanverth@google.com, robertphillips@google.com TBR=jvanverth@google.com, robertphillips@google.com NOTREECHECKS=true NOTRY=true Author: bsalomon@google.com Review URL: https://codereview.chromium.org/278073002 git-svn-id: http://skia.googlecode.com/svn/trunk@14681 2bbb7eff-a529-9590-31e7-b0007b416f81
* Factor GrTexture into public GrTexture and private GrTextureImpl.Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | R=jvanverth@google.com, robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/275903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14680 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Flatten resources directory"Gravatar djsollen@google.com2014-05-09
| | | | | | Review URL: https://codereview.chromium.org/278033002 git-svn-id: http://skia.googlecode.com/svn/trunk@14679 2bbb7eff-a529-9590-31e7-b0007b416f81
* Flatten resources directoryGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | On android trybots, the files in a subdirectory weren't being loaded onto the device. Consequently, the ImageDecoderOptions test was not testing anything. I had to relax that unit test to reflect the existing behavior of our libjpeg decoder on Android. R=djsollen@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/264583007 git-svn-id: http://skia.googlecode.com/svn/trunk@14678 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of hide get/setLocalMatrix (https://codereview.chromium.org/279563002/)Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | | | | | | | | | Reason for revert: broke gms Original issue's description: > hide get/setLocalMatrix > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14675 R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org TBR=dominikg@chromium.org, fmalita@chromium.org, fmalita@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: reed@google.com Review URL: https://codereview.chromium.org/278903002 git-svn-id: http://skia.googlecode.com/svn/trunk@14677 2bbb7eff-a529-9590-31e7-b0007b416f81
* Allow for no pdf rasterizers in gm.Gravatar bungeman@google.com2014-05-09
| | | | | | | | | | | | | Our poppler does not build properly with VS2013, but using gyp_skia -Dskia_enable_poppler_enabled=0 also does not build due to kPDFRasterizers being statically empty. This adds a do nothing, not run by default 'pdf rasterizer'. R=epoger@google.com Review URL: https://codereview.chromium.org/270263009 git-svn-id: http://skia.googlecode.com/svn/trunk@14676 2bbb7eff-a529-9590-31e7-b0007b416f81
* hide get/setLocalMatrixGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | BUG=skia: R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org Author: reed@google.com Review URL: https://codereview.chromium.org/279563002 git-svn-id: http://skia.googlecode.com/svn/trunk@14675 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add a dry-run option to gyp_skia.Gravatar bungeman@google.com2014-05-09
| | | | | | | | | | | | | | There are times when I want to do some low-level fiddling with the gyp command. It's nice to start with whatever the 'default' is, and it's also nice to peek behind the curtain to see what's going on. To this end, a '--dry-run' in the argument list will spit out the command to run, rather than running the command. R=epoger@google.com Review URL: https://codereview.chromium.org/278893002 git-svn-id: http://skia.googlecode.com/svn/trunk@14674 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use a tilegrid for bench_playback.Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using --tile wasn't a fair comparison: SkPicture didn't get to optimize its playback, but SkRecord did. Numbers here are starting to agree with what I saw in telemetry: SkRecord with culling is on average at 0.8-0.9 of the speed of SkPicture (10-30% slower) than SkPicture SkPicture with a tile grid, but some in some cases it's down at 0.3, taking almost 4x as long to draw a 256x256 tile. 0.4x tabl_mercurynews.skp 0.109889 0.252483 0.5x tabl_cnet.skp 0.250367 0.527789 1.0x desk_mapsvg.skp 1.48698 1.49939 1.2x desk_yahoogames.skp 0.07745 0.065343 0.9x tabl_mlb.skp 0.294509 0.312505 0.8x tabl_hsfi.skp 0.250678 0.316337 0.6x tabl_worldjournal.skp 0.510204 0.828798 0.7x desk_facebook.skp 0.318981 0.483744 0.9x desk_googlehome.skp 0.06983 0.078964 0.9x desk_tigersvg.skp 0.019232 0.022611 1.0x desk_youtubetvvideo.skp 0.401614 0.401862 1.1x desk_amazon.skp 0.415552 0.362111 0.7x desk_yahooanswers.skp 0.237995 0.358659 0.7x desk_twitter.skp 0.323466 0.439772 1.2x desk_fontwipe.skp 0.121577 0.097845 1.1x desk_css3gradients.skp 0.395335 0.362087 0.9x desk_googlespreadsheet.skp 0.362056 0.406688 1.0x tabl_frantzen.skp 15.2475 14.8521 0.6x desk_forecastio.skp 0.154236 0.276881 0.7x desk_pinterest.skp 0.077433 0.11324 0.5x tabl_cuteoverload.skp 0.173014 0.361815 0.5x tabl_androidpolice.skp 0.225903 0.465608 0.6x tabl_vnexpress.skp 0.151075 0.241104 0.6x tabl_nytimes.skp 0.06515 0.117229 0.8x desk_ebay.skp 0.353437 0.422586 0.8x tabl_deviantart.skp 0.223103 0.295496 1.1x tabl_culturalsolutions.skp 0.551348 0.506104 0.9x mobi_wikipedia.skp 0.302603 0.337292 0.6x desk_linkedin.skp 0.165102 0.276149 0.6x tabl_digg.skp 0.159074 0.281529 1.2x desk_oldinboxapp.skp 0.019815 0.017146 1.0x tabl_nofolo.skp 5.18914 5.42784 0.6x desk_jsfiddlehumperclip.skp 0.076869 0.133665 1.0x desk_blogger.skp 0.206702 0.19688 0.8x desk_espn.skp 0.346386 0.451871 1.0x desk_samoasvg.skp 3.60037 3.43147 0.8x desk_booking.skp 0.338818 0.438267 1.3x desk_yahoosports.skp 0.603811 0.470052 0.6x tabl_engadget.skp 0.248995 0.404372 0.7x desk_wowwiki.skp 0.325801 0.479559 0.8x tabl_ukwsj.skp 0.326985 0.405971 0.9x tabl_gmail.skp 0.2604 0.276744 0.9x desk_googleplus.skp 8.08874 8.71105 1.1x tabl_slashdot.skp 0.559332 0.524313 0.9x desk_gmailthread.skp 0.671569 0.74134 0.8x desk_weather.skp 0.194162 0.247681 1.3x desk_rectangletransition.skp 0.218372 0.173685 0.6x tabl_gamedeksiam.skp 0.243374 0.4134 0.9x desk_jsfiddlebigcar.skp 0.162282 0.186035 0.3x desk_pokemonwiki.skp 0.202878 0.778934 0.7x tabl_googleblog.skp 0.141203 0.209971 0.8x desk_sfgate.skp 0.229078 0.275248 1.0x desk_chalkboard.skp 2.28916 2.20101 0.9x tabl_googlecalendar.skp 0.687155 0.75413 1.1x tabl_gspro.skp 0.186399 0.169522 0.5x desk_googlespreadsheetdashed.skp 0.512622 1.02815 0.6x desk_mobilenews.skp 0.183506 0.293929 0.8x tabl_techmeme.skp 0.193074 0.229106 1.2x desk_carsvg.skp 5.33047 4.34058 0.5x desk_youtube.skp 0.132663 0.248236 0.7x tabl_pravda.skp 0.21644 0.308788 1.1x desk_gws.skp 0.698107 0.625371 0.5x tabl_mozilla.skp 0.189638 0.386801 1.0x desk_baidu.skp 0.353438 0.355965 1.1x tabl_sahadan.skp 0.476226 0.416737 summary: ≥0.3x (A 0.9x, G 0.8x) ≤1.3x Whole SKP playback speed is fine of course. BUG=skia:2378 R=fmalita@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/277653002 git-svn-id: http://skia.googlecode.com/svn/trunk@14673 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add timing to dump_record.Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prints microsecond timing for each command in the left-hand column: optimized flat/http___mobile_news_sandbox_google_com_news_pt0_scroll_layer_7.skp 4.0 1 Save 2075.0 2 DrawRect 104.0 3 BoundedDrawPosTextH 135.4 4 DrawRect 9.4 5 DrawRect 5.6 6 DrawRect 8.2 7 DrawRect 6.8 8 DrawRect ... (I'm sure Rietveld will just mangle the crap out of that. It's helpfully right-aligned.) To do this, I made Draw from SkRecordDraw Skia-public as SkRecords::Draw, and time it command-by-command. BUG=skia:2378 R=fmalita@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/272723007 git-svn-id: http://skia.googlecode.com/svn/trunk@14672 2bbb7eff-a529-9590-31e7-b0007b416f81
* update canvas-layer-state (which should be deleted soon)Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | R=reed@android.com TBR=reed NOTRY=true Author: caryclark@google.com Review URL: https://codereview.chromium.org/274133002 git-svn-id: http://skia.googlecode.com/svn/trunk@14671 2bbb7eff-a529-9590-31e7-b0007b416f81
* QuadTree: don't leak deferred inserts past clear()Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | BUG=skia: R=djsollen@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/277713003 git-svn-id: http://skia.googlecode.com/svn/trunk@14670 2bbb7eff-a529-9590-31e7-b0007b416f81
* cleanup GrContext resource cache apiGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/275563005 git-svn-id: http://skia.googlecode.com/svn/trunk@14669 2bbb7eff-a529-9590-31e7-b0007b416f81
* commit GM actuals as expectations for all tests, marking them as unreviewedGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | BUG=skia:1578 NOTRY=True R=caryclark@google.com TBR=caryclark Author: epoger@google.com Review URL: https://codereview.chromium.org/279773003 git-svn-id: http://skia.googlecode.com/svn/trunk@14668 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix typo in SkFontHost_win.cpp in comment.Gravatar bungeman@google.com2014-05-09
| | | | | | | We want the 'size', not the 'side'. git-svn-id: http://skia.googlecode.com/svn/trunk@14667 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add missing sfnt header files to gyp.Gravatar bungeman@google.com2014-05-09
| | | | | | | This makes finding these files easier in IDEs. git-svn-id: http://skia.googlecode.com/svn/trunk@14666 2bbb7eff-a529-9590-31e7-b0007b416f81
* Disable filtering in draw Bitmap operation when pixels are alignedGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | | | | | | The check is now performed in the callers of internalDrawBitmap() to avoid retrieve the texture with wrong filter mode when the pixels were aligned. This bug was spotted in Chrome for Android: Chrome for Androids's Canvas drawImage loses fidelity in canvases larger than 64k pixels. BUG=chromium:231916 R=bsalomon@google.com, robertphillips@google.com Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Author: siglesias@igalia.com Review URL: https://codereview.chromium.org/264303008 git-svn-id: http://skia.googlecode.com/svn/trunk@14665 2bbb7eff-a529-9590-31e7-b0007b416f81
* update Test-Linux-Bare-NoGPU-Arm8_64-Debug expectationsGravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | R=djsollen@google.com TBR=djsollen NOTRY=true Author: caryclark@google.com Review URL: https://codereview.chromium.org/276893002 git-svn-id: http://skia.googlecode.com/svn/trunk@14664 2bbb7eff-a529-9590-31e7-b0007b416f81
* Point to skiadocs in our README.Gravatar tfarina@chromium.org2014-05-09
| | | | | | | | | | | This seems to be the canonical location for all skia documentation nowadays. R=epoger@google.com Review URL: https://codereview.chromium.org/276483008 git-svn-id: http://skia.googlecode.com/svn/trunk@14663 2bbb7eff-a529-9590-31e7-b0007b416f81
* reland "extract some common code from PictureRenderer"Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | re-lands https://codereview.chromium.org/273703006/ NOTRY=True R=bungeman@google.com, djsollen@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/278633002 git-svn-id: http://skia.googlecode.com/svn/trunk@14662 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-05-09
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@14661 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from ↵Gravatar commit-bot@chromium.org2014-05-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_defines. (https://codereview.chromium.org/265973002/) Reason for revert: This is breaking compilation of cc_unittests in Chrome Original issue's description: > Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines. > > Chrome/Blink doesn't use any of the legacy methods behind this flag any more. > > BUG=skia:2187 > > Committed: http://code.google.com/p/skia/source/detail?r=14651 R=reed@google.com, dominikg@chromium.org TBR=dominikg@chromium.org, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2187 Author: robertphillips@google.com Review URL: https://codereview.chromium.org/275713002 git-svn-id: http://skia.googlecode.com/svn/trunk@14660 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix rendering artifacts in pull-saveLayers-forward modeGravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | | | | | | | | | | This CL fixes 2 bugs in the pre-rendering of saveLayers: 1) The drawBitmapRect call wasn't occurring in device space so could sometimes be double transformed 2) The BBH op skipping in SkPicturePlayback could sometimes mess up the SkPictureStateTree's state It also reduces the number of layers that are pre-rendered when a BBH is not in use. Committed: http://code.google.com/p/skia/source/detail?r=14650 R=bsalomon@google.com, reed@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/267293007 git-svn-id: http://skia.googlecode.com/svn/trunk@14659 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server JSON: pass category values as values, not keysGravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | | BUG=skia:1758 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/270413002 git-svn-id: http://skia.googlecode.com/svn/trunk@14658 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove non-existent header file from Android opts.Gravatar bungeman@google.com2014-05-08
| | | | | | | | R=djsollen@google.com Review URL: https://codereview.chromium.org/274793004 git-svn-id: http://skia.googlecode.com/svn/trunk@14657 2bbb7eff-a529-9590-31e7-b0007b416f81
* return null if subshader failsGravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | TBR=scroggo@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/279573002 git-svn-id: http://skia.googlecode.com/svn/trunk@14656 2bbb7eff-a529-9590-31e7-b0007b416f81
* Split Star into Star (stores nothing) and List (stores matches).Gravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | | | | | | | | | Just noticed that the cull noop pattern (PushCull, Star<NoOp>, PopCull) would trigger the Star that stores matches. We certainly don't need those matches here, so instead of magically determining which Star you need, we'll make you tell us which one you want. No one but List's unit test needs List. I'll leave it for now, but we might find it's not useful. BUG=skia:2378 R=fmalita@chromium.org, mtklein@google.com, bungeman@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/275623002 git-svn-id: http://skia.googlecode.com/svn/trunk@14655 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert r14650 (Fix rendering artifacts in pull-saveLayers-forward mode - ↵Gravatar robertphillips@google.com2014-05-08
| | | | | | https://codereview.chromium.org/267293007) due to unit test failures git-svn-id: http://skia.googlecode.com/svn/trunk@14654 2bbb7eff-a529-9590-31e7-b0007b416f81
* Noop away PushCull/PopCull pairs with nothing between them.Gravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | | BUG=skia:2378 R=fmalita@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/277613002 git-svn-id: http://skia.googlecode.com/svn/trunk@14653 2bbb7eff-a529-9590-31e7-b0007b416f81
* store map ptr in GrGeometryBuffer base classGravatar commit-bot@chromium.org2014-05-08
| | | | | | | | | | R=robertphillips@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/272503009 git-svn-id: http://skia.googlecode.com/svn/trunk@14652 2bbb7eff-a529-9590-31e7-b0007b416f81