aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* monobench: usability tweaksGravatar Mike Klein2016-09-28
| | | | | | | | | | | | | | | - Allow an second argument to limit the number of samples. - If no benchmarks match, warn and exit instead of infinitely looping. The default limit of 2147483647 10ms samples will run for 9 months, which I think is long enough to not need any special infinity logic. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2747 Change-Id: Id70cf77b624e19dc04e1d75a71385aee3c988a80 Reviewed-on: https://skia-review.googlesource.com/2747 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll buildtools adb8bf4e8fc..5fd66957f08bb7Gravatar Ben Wagner2016-09-28
| | | | | | | | | | | | | | https://chromium.googlesource.com/chromium/buildtools/+log/adb8bf4e8fc..5fd66957f08bb7 Primarily to pick up https://chromium.googlesource.com/chromium/src/+/d51d3527da33 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2749 Change-Id: I3f9ac18c8946fa28effcf8c8cff3bbd1120a86df Reviewed-on: https://skia-review.googlesource.com/2749 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com>
* Gradients are serialized (and can be constructed) as SkColor4f + SkColorSpaceGravatar brianosman2016-09-28
| | | | | | | | | | | | | | | | | | | | Added gradient shader factories that take SkColor4f + SkColorSpace. Modified Descriptor to only store SkColor4f + SkColorSpace. Existing factories make use of helper code to convert SkColor and forward to the new factories. Bumped SKP version to handle new gradient serialization format. I was toying with using half-float when serializing SkColor4f, despite my aggressive packing of flags, this format is significantly bigger. Also added GM to use 4f factories. This GM should (and does) look identical to the existing gradients GM. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002 Review-Url: https://codereview.chromium.org/2370063002
* documentation: update PDF design docGravatar halcanary2016-09-28
| | | | | | NOTRY=true Review-Url: https://codereview.chromium.org/2295373002
* Move toXYZD50() to SkColorSpace_BaseGravatar msarett2016-09-28
| | | | | | | | | | | | SkColorSpace needs to become more versatile, in order to support profiles that cannot specified with just a "to XYZ D50" matrix. This a just first step to clean up the public API. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381553002 Review-Url: https://codereview.chromium.org/2381553002
* SkRasterPipeline: fuse clamp_01 into stores.Gravatar Mike Klein2016-09-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a less generally applicable trick than I have previously hoped. The need to thread through contexts into each stage really means you can only include one context-dependent stage in each fused batch. We can still manually fuse these, of course, as you can see in SkRasterPipelineBench. It's just that we can't really write a generic compile-time template to do it except for context-free stages. And since we can't write a generic version, and I have only this one specific use case right now, I've kept it quite specific to that use case. This does work pretty well for this use case, though. Here's the fused clamp-then-store-565: +0x00 pushq %rbp +0x01 movq %rsp, %rbp +0x04 movq 8(%rdi), %rax +0x08 xorps %xmm4, %xmm4 +0x0b maxps %xmm4, %xmm3 +0x0e maxps %xmm4, %xmm0 +0x11 maxps %xmm4, %xmm1 +0x14 maxps %xmm4, %xmm2 +0x17 minps 4262818(%rip), %xmm3 +0x1e minps %xmm3, %xmm0 +0x21 minps %xmm3, %xmm1 +0x24 minps %xmm3, %xmm2 +0x27 movaps 4965378(%rip), %xmm3 +0x2e mulps %xmm3, %xmm0 +0x31 cvtps2dq %xmm0, %xmm0 +0x35 pslld $11, %xmm0 +0x3a mulps 4965375(%rip), %xmm1 +0x41 cvtps2dq %xmm1, %xmm1 +0x45 pslld $5, %xmm1 +0x4a mulps %xmm3, %xmm2 +0x4d cvtps2dq %xmm2, %xmm2 +0x51 orpd %xmm0, %xmm2 +0x55 orpd %xmm1, %xmm2 +0x59 pshufb 4474510(%rip), %xmm2 +0x62 movq %xmm2, (%rax,%rsi,2) +0x67 popq %rbp +0x68 retq BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2745 Change-Id: Ia7d66aecc6cbff154158d2600d7874feed1a76f6 Reviewed-on: https://skia-review.googlesource.com/2745 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* SkPDF: use SkImage::isAImageGravatar Hal Canary2016-09-28
| | | | | | | | | | | | | | output size savings = ~0.4% with effected gms and skps. BUG=568816 BUG=skia:5592 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2760 Change-Id: Ifead46ea5789e18aa3ddea9ca3986717296a6391 Reviewed-on: https://skia-review.googlesource.com/2760 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* fix cubic linear testGravatar caryclark2016-09-28
| | | | | | | | | | | | | | Check to see if the line between end points is degenerate before measuring control points. Also, add test case for a bug to see if it shows up on any platform. TBR=reed@google.com BUG=skia:5169, skia:5240 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375053002 Review-Url: https://codereview.chromium.org/2375053002
* Make GPU configs use kRGBA color type not kN32.Gravatar bsalomon2016-09-28
| | | | | | | | | This makes ES msaa contexts testable on systems where kN32 is compiled as kBGRA due to the fact that render buffers are not always supported for GL_BGRA with GL_EXT_texture_format_BGRA8888. BUG=skia:5804 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378713002 Review-Url: https://codereview.chromium.org/2378713002
* Rearrange SkRasterPipeline scanline tail handling.Gravatar Mike Klein2016-09-28
| | | | | | | | | | | | | | | | | | | We used to step at a 4-pixel stride as long as possible, then run up to 3 times, one pixel at a time. Now replace those 1-at-a-time runs with a single tail stamp if there are 1-3 remaining pixels. This style is simply more efficient: e.g. we'll blend and lerp once for 3 pixels instead of 3 times. This should make short blits significantly more efficient. It's also more future-oriented... AVX+ on Intel and SVE on ARM support masked loads and stores, so we can do the entire tail in one direct step. This also makes it possible to re-arrange the code a bit to encapsulate each stage better. I think generally this code reads more clearly than the old code, but YMMV. I've arranged things so you write one function, but it's compiled into two specializations, one for tail=0 (Body) and one for tail>0 (Tail). It's pretty tidy. For now I've just burned a register to pass around tail. It's 2 bits now, maybe soon 3 with AVX, and capped at 4 for even the craziest new toys, so there are plenty of places we can pack it if we want to get clever. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2717 Change-Id: I45852a3e5d4c5b5e9315302c46601aee0d32265f Reviewed-on: https://skia-review.googlesource.com/2717 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert of Tag checkerboard bitmaps as sRGB (patchset #1 id:1 of ↵Gravatar brianosman2016-09-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2368933003/ ) Reason for revert: Regression on displacement GM when sRGB support is lacking. Original issue's description: > Tag checkerboard bitmaps as sRGB > > Significantly reduces the diff between legacy and sRGB/F16 on about 25 > GMs. This is just the biggest piece of low-hanging fruit. Many GMs create > N32 raster surfaces to procedurally generate source textures, and I'd like > to fix all of them. It's much easier to reason about the GMs (is sRGB > doing the right thing) when everything is tagged like this - the only > expected differences are due to filtering and blending. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 > > Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 TBR=mtklein@google.com,reed@google.com,robertphillips@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Review-Url: https://codereview.chromium.org/2375063002
* Hide monobench target on debug builds.Gravatar Mike Klein2016-09-28
| | | | | | | | | | | | | | Unlike nanobench this tool has no purpose when built in Debug mode. Just don't let it happen. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2718 Change-Id: Iaa7b8c44d46024485d4f5ce3d9c3e33d865b99d7 Reviewed-on: https://skia-review.googlesource.com/2718 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Make SkPMColor BGRA on Fuchsia.Gravatar Mike Klein2016-09-28
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2700 Change-Id: I59b8463adcf3d49af524fec379e3b563dcbcbf6b Reviewed-on: https://skia-review.googlesource.com/2700 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Added kSRGBLinear_Named color space, along with testsGravatar brianosman2016-09-27
| | | | | | | | | | | | Gradients (and other shaders) are going to end up serializing this particular color space very frequently, so we want a shorthand way of writing it out. I think it's also helpful to have a clearer way of creating it (vs. NewNamed(kSRGB_Named)->makeLinearGamma()). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2377763002 Review-Url: https://codereview.chromium.org/2377763002
* Add SK_SUPPORT_LEGACY_ARITHMETICMODE flag to public.bzl.Gravatar benjaminwagner2016-09-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2372703007 Review-Url: https://codereview.chromium.org/2372703007
* Add command buffer submits before copy calls in vulkan.Gravatar egdaniel2016-09-27
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363773006 Committed: https://skia.googlesource.com/skia/+/25661bac7722860b7589c5b01ec404531d941456 Review-Url: https://codereview.chromium.org/2363773006
* SkRasterPipeline: add last() and docs.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | | | | | | | Today if you use the simple SK_RASTER_STAGE interface to build a pipeline, each stage you add calls into a next stage. The last stage you add calls into a special backstop stage JustReturn that, well, just returns, ending the pipeline. This adds last(), which cuts that last stage off the pipeline. Instead, the stage you add using last() returns directly, ending the pipeline itself without jumping into JustReturn. This reduces the overhead of using the pipelined version of SkRasterPipelineBench from ~25% to ~20% on my desktop. Also, add docs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2713 Change-Id: I11469378e2765c6e34db52eb3eef648d6612da3f Reviewed-on: https://skia-review.googlesource.com/2713 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Turn on -Wgnu-anonymous-struct and -Wnested-anonymous-types.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | I'm not seeing any problems with these locally. Perhaps the bots have something to say. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2709 Change-Id: I6f0c7045c8f270efcd71d837f22a40e9f9d3e9b7 Reviewed-on: https://skia-review.googlesource.com/2709 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Revert of Add command buffer submits before copy calls in vulkan. (patchset ↵Gravatar egdaniel2016-09-27
| | | | | | | | | | | | | | | | | | | | | | | | #5 id:80001 of https://codereview.chromium.org/2363773006/ ) Reason for revert: breaking things since apparently nvidia != windows always... Original issue's description: > Add command buffer submits before copy calls in vulkan. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363773006 > > Committed: https://skia.googlesource.com/skia/+/25661bac7722860b7589c5b01ec404531d941456 TBR=jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2373503004
* GN: match shell behavior for cc and cxx in is_clang.pyGravatar csmartdalton2016-09-27
| | | | | | | | | | Interprets cc/cxx as part of the shell command rather than literal arguments. This matches the behavior of shell invocations from ninja. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2375573002 Review-Url: https://codereview.chromium.org/2375573002
* OverAlignedTest: use sk_ malloc and free.Gravatar Mike Klein2016-09-27
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2712 Change-Id: I73b2b45ba6a1303b957aa03953eef305f8be9144 Reviewed-on: https://skia-review.googlesource.com/2712 Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Update vulkan varying locations to correctly handle arraysGravatar egdaniel2016-09-27
| | | | | | | BUG=skia:5797 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369013006 Review-Url: https://codereview.chromium.org/2369013006
* Add command buffer submits before copy calls in vulkan.Gravatar egdaniel2016-09-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363773006 Review-Url: https://codereview.chromium.org/2363773006
* Fix dm/nanobench uploads for Gerrit-based trybotsGravatar Eric Boren2016-09-27
| | | | | | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2710 Change-Id: I43f03b19a9d7223b67de7dc7c4efea8cb75dba05 Reviewed-on: https://skia-review.googlesource.com/2710 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Turn on -Wnewline-eof.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | I don't know _why_ Clang would like these .inc files to have a newline at the end of the file, but it seems a harmless way to silence the warning. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2711 Change-Id: I6c530ee5096c48c91ddf322aca916e70a0dd770b Reviewed-on: https://skia-review.googlesource.com/2711 Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* another attempt to fix nonrectangularGravatar caryclark2016-09-27
| | | | | | | | | | | | | For hairlines extended by the end cap, set the first point to the first curve following a move, which has had its position adjusted. R=fmalita@chromium.org BUG=617658 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2371143002 Review-Url: https://codereview.chromium.org/2371143002
* need to apply CTM to clip rect in arithmetic imagefilterGravatar Mike Reed2016-09-27
| | | | | | | | | | | | | | BUG=skia:5800 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2708 NOTRY=True upload steps are failing, but the tests themselves passed Change-Id: I0210d0095b4ffdd376f18fad895655d39714bf38 Reviewed-on: https://skia-review.googlesource.com/2708 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* [task scheduler] Add uploads to tasks.jsonGravatar borenet2016-09-27
| | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376713002 Review-Url: https://codereview.chromium.org/2376713002
* Remove gen_bench_expectations_from_codereviewGravatar borenet2016-09-27
| | | | | | | | | It hasn't been used in a long time. BUG=skia:2969 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2373803002 Review-Url: https://codereview.chromium.org/2373803002
* remove more stray semicolons from Vulkan codeGravatar Mike Klein2016-09-27
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2707 Change-Id: Idc00efeda2f9901a6f33c987202be2a781b24269 Reviewed-on: https://skia-review.googlesource.com/2707 Reviewed-by: Mike Klein <mtklein@chromium.org>
* Add GrVkCopyPipeline to handle vulkan copies as drawsGravatar egdaniel2016-09-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274663005 Review-Url: https://codereview.chromium.org/2274663005
* Delete unused upload_*_results.pyGravatar borenet2016-09-27
| | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2371883004 Review-Url: https://codereview.chromium.org/2371883004
* Add mips dsp arch variants to gyp_to_android.py.Gravatar branimir.vasic2016-09-27
| | | | | | | | | | Fixes Android build for variants mips32r2dsp-fp and mips32r2dspr2-fp by enabling correct Android.mk file generation. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2359793002 Review-Url: https://codereview.chromium.org/2359793002
* We really shouldn't pass SkFontStyle to printf as %d.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2721 Change-Id: I362063bea3909b2581d8e9b7860d4ac321082808 Reviewed-on: https://skia-review.googlesource.com/2721 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Remove stray semicolons.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | | | | Turns out function declarations don't end in semicolons... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2720 No public API changes. TBR=reed@google.com Change-Id: I72b56d52e1ff7fa6e89c295b0de8c46599791ebb Reviewed-on: https://skia-review.googlesource.com/2720 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add swarming task for upload_dm_resultsGravatar borenet2016-09-27
| | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360203004 Review-Url: https://codereview.chromium.org/2360203004
* Focus -Wno-over-aligned to just 32-bit x86 Android. (2)Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | | | I've even found the code that's making this happen, just don't know why. I've added a test to assert that it's safe to assume malloc() is 8-byte aligned. Test should compile this time. CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-GN_Android-Trybot Change-Id: I48714b99670c20704adf4f7f216da0d60d7d9bcd Reviewed-on: https://skia-review.googlesource.com/2662 Reviewed-on: https://skia-review.googlesource.com/2703 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Focus -Wno-over-aligned to just 32-bit x86 Android."Gravatar Mike Reed2016-09-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit If8a2898ab3a77571622eb125c97f676e029b902c. Reason for revert: ../../../../../work/skia/tests/OverAlignedTest.cpp: In function 'void test_OverAligned(skiatest::Reporter*, sk_gpu_test::GrContextFactory*)': ../../../../../work/skia/tests/OverAlignedTest.cpp:19:33: error: invalid operands of types 'void*' and 'int' to binary 'operator&' REPORTER_ASSERT(r, SkIsAlign8(p)); ^ ninja: build stopped: subcommand failed. Original issue's description: > Focus -Wno-over-aligned to just 32-bit x86 Android. > > I've even found the code that's making this happen, just don't know why. > I've added a test to assert that it's safe to assume malloc() is 8-byte aligned. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2662 > > CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-GN_Android-Trybot > TBR=mtklein@chromium.org,bungeman@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ic9b30ce980d8d5155528a6f2b4e1913e5fa95dc0 Reviewed-on: https://skia-review.googlesource.com/2702 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Remove outdated comments about pre-sk_sp semanticsGravatar brianosman2016-09-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2371603003 Review-Url: https://codereview.chromium.org/2371603003
* Clamp Vulkan caps to INT_MAXGravatar jvanverth2016-09-27
| | | | | | | | | | AMD sets some Vulkan caps values to 0xffffffff as a uint32_t, which overflows our int values and causes merry havok. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2371923002 Review-Url: https://codereview.chromium.org/2371923002
* Revert "Revert "replace Arithmetic xfermode with imagefilter""Gravatar Mike Reed2016-09-27
| | | | | | | | | | | | | This reverts commit 10ff5bfa789b6b602464e8511fdf676c6f5b1bd4. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2680 TBR= Change-Id: Iac2f4d48d227ff426ccf02b7eae280f382ad3580 Reviewed-on: https://skia-review.googlesource.com/2680 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Focus -Wno-over-aligned to just 32-bit x86 Android.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | | | | I've even found the code that's making this happen, just don't know why. I've added a test to assert that it's safe to assume malloc() is 8-byte aligned. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2662 CQ_INCLUDE_TRYBOTS=master.client.skia.android:Test-Android-Clang-NexusPlayer-CPU-Moorefield-x86-Release-GN_Android-Trybot Change-Id: If8a2898ab3a77571622eb125c97f676e029b902c Reviewed-on: https://skia-review.googlesource.com/2662 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Revert of My take on SkAlign changes. (patchset #3 id:40001 of ↵Gravatar mtklein2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2368293002/ ) Reason for revert: Let's see if reverting this helps the roll. Original issue's description: > My take on SkAlign changes. > > Like the other change, it makes SkAlignN(x) macros work for pointers, and makes the macros themselves just syntax sugar for SkAlign<N>(x). We can still decide if we want to sed away the macros independently. > > This just does it in a somewhat less repetitive way, and adds some tests. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002 > > No public API changes. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/e1a5f4e292384046678edc5c1e360b3e13dc118c TBR=cblume@chromium.org,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2372083002
* Revert "replace Arithmetic xfermode with imagefilter"Gravatar Mike Reed2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit Ia3f3b721854c516f3b7f8c44f71f40a8a2eeb9b4. Reason for revert: need to guard the no-gpu codepath Original issue's description: > replace Arithmetic xfermode with imagefilter > > chrome pre-cl: https://codereview.chromium.org/2369023002/ > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2595 > > Change-Id: Ia3f3b721854c516f3b7f8c44f71f40a8a2eeb9b4 > Reviewed-on: https://skia-review.googlesource.com/2595 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Robert Phillips <robertphillips@google.com> > TBR=robertphillips@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I761799b594a0379c6bf356e6abc73552c3d19480 Reviewed-on: https://skia-review.googlesource.com/2661 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Revert of Turned on SkSL->GLSL compiler (patchset #37 id:800001 of ↵Gravatar ethannicholas2016-09-26
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2288033003/ ) Reason for revert: Gold image breakage Original issue's description: > Turned on SkSL->GLSL compiler > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003 > > Committed: https://skia.googlesource.com/skia/+/9b0fe3d125f237d9884732a48414fa85fc71b4e3 > Committed: https://skia.googlesource.com/skia/+/b12b3c6908c62c908b3680be01e3b5bfd30de310 TBR=benjaminwagner@google.com,bsalomon@google.com,egdaniel@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2372773002
* Move undefined-func-template to wont-fix warnings.Gravatar Mike Klein2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | The warning looks to helpfully pre-warn about possible link failures, but it's warning exclusively in places where we're doing things right. The worst that happens ignoring this warning is a missing-symbol linker error. I've taken the opportunity to batch in a few other de-escalations: - Wconditional-uninitialized is done better by MSAN - It'll take some work to dig Wformat-literal out of our shader compiler, but nothing looks unsafe - Most of Wshift-sign-overflow is 0xff << 24. Don't want to ban that. - Wdeprecated is mostly warning about features C++11 technically deprecated that might be removed in later releases. Punt! - Wcovered-switch-default is pretty much the opposite of what we want. - Wshadow is triggering too often to fix quickly. Probably mostly false positives. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2620 Change-Id: I20a85a77d2e19ed05a536b23037bd988350f821e Reviewed-on: https://skia-review.googlesource.com/2620 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* replace Arithmetic xfermode with imagefilterGravatar Mike Reed2016-09-26
| | | | | | | | | | | | | | chrome pre-cl: https://codereview.chromium.org/2369023002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2595 Change-Id: Ia3f3b721854c516f3b7f8c44f71f40a8a2eeb9b4 Reviewed-on: https://skia-review.googlesource.com/2595 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Fix typoGravatar liyuqian2016-09-26
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370003002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2370003002 Review-Url: https://codereview.chromium.org/2370003002
* Revert of Fix bufferIndex check in VulkanWindowContext (patchset #1 id:1 of ↵Gravatar egdaniel2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2363353003/ ) Reason for revert: Fix not correct. Original issue's description: > Fix bufferIndex check in VulkanWindowContext > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 > > Committed: https://skia.googlesource.com/skia/+/e6bd20e62b827a1f26fa491fc628f015d208350f TBR=jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2370953002
* Fix bufferIndex check in VulkanWindowContextGravatar egdaniel2016-09-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 Review-Url: https://codereview.chromium.org/2363353003
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-04 16:13:15 +0000