aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Turned on SkSL->GLSL compilerGravatar ethannicholas2016-09-26
| | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003 Committed: https://skia.googlesource.com/skia/+/9b0fe3d125f237d9884732a48414fa85fc71b4e3 Review-Url: https://codereview.chromium.org/2288033003
* Minor clean up of GrAAConvexTessellatorGravatar Robert Phillips2016-09-26
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2604 Change-Id: Ie94361256675cded9ca241ddad6443e695a596e9 Reviewed-on: https://skia-review.googlesource.com/2604 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Roll recipesGravatar borenet2016-09-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2366323002 Review-Url: https://codereview.chromium.org/2366323002
* allow conic chop to failGravatar caryclark2016-09-26
| | | | | | | | | | | | | Fuzzy values may cause the conic chop to fail. Check to see if the values are all finite, and require the caller to do the same. R=reed@google.com BUG=650178 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368993002 Review-Url: https://codereview.chromium.org/2368993002
* Turn on -Wundefined-reinterpret-cast.Gravatar Mike Klein2016-09-26
| | | | | | | | | | | | | | | | | It was not a fan of this (blatant) aliasing. I suspect this best_non_simd_srcover_srgb_srgb() function has several other aliasing issues that use undefined behavior, but this is all it's complaining about for now. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2606 Change-Id: I25a8800e810bccf5068c8a10e9c8c8f565e57304 Reviewed-on: https://skia-review.googlesource.com/2606 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Tag checkerboard bitmaps as sRGBGravatar brianosman2016-09-26
| | | | | | | | | | | | | | Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 Review-Url: https://codereview.chromium.org/2368933003
* -Wcomma may be good to go now.Gravatar Mike Klein2016-09-26
| | | | | | | | | | | | | This cleans up 3 remaining sites using , that probably meant ; BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2605 Change-Id: I5e48bcd85d72a205d2b0c860461dab1ec793dd18 Reviewed-on: https://skia-review.googlesource.com/2605 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* My take on SkAlign changes.Gravatar mtklein2016-09-26
| | | | | | | | | | | | | | Like the other change, it makes SkAlignN(x) macros work for pointers, and makes the macros themselves just syntax sugar for SkAlign<N>(x). We can still decide if we want to sed away the macros independently. This just does it in a somewhat less repetitive way, and adds some tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368293002 No public API changes. TBR=reed@google.com Review-Url: https://codereview.chromium.org/2368293002
* bin/coverage: a GN version of the coverage scriptGravatar halcanary2016-09-26
| | | | | | | | intended to replace tools/coverage when GYP is gone. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343243002 Review-Url: https://codereview.chromium.org/2343243002
* Include timestamp in nanobench JSON file nameGravatar borenet2016-09-26
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2366623003 TBR=jcgregorio Review-Url: https://codereview.chromium.org/2366623003
* add tiger testsGravatar caryclark2016-09-26
| | | | | | | | | | | | | | | | Add the tiger test suite. In extended mode (-x) this adds 700K new pathop tests. Normally, it adds about 3500 tests. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2373533002 Review-Url: https://codereview.chromium.org/2373533002
* Typo?Gravatar mtklein2016-09-26
| | | | | | | | | | | This can't be what you intended... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368273002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2368273002
* GN: detect is_clang, use it to switch Clang to warning blacklist.Gravatar mtklein2016-09-26
| | | | | | | | | | | | | | | Same as the last CL, now with -Wno-over-aligned. CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369033002 TBR=bungeman@google.com NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2369033002
* Quiet a -Wcomma warning.Gravatar mtklein2016-09-26
| | | | | | | | | | | | | | | | | Clang's got a warning -Wcomma that warns about possible unintentional uses of the comma operator, usually where a semicolon looks itended. I don't think there's a bug here, but a semicolon does work just as well and reads a bit more conventionally. Though, I'm not actually sure how this parses, as fp = ...; glslFP = ...; or fp = (..., glsl = ...). The second would most definitely be a bug. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2365403002
* beziers: I missed an unsequenced moveTo() pair.Gravatar mtklein2016-09-26
| | | | | | | | | TBR=brianosman@google.com BUG=skia: NOTREECHECKS=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369933002 Review-Url: https://codereview.chromium.org/2369933002
* Fix some fuzzer complaintsGravatar Robert Phillips2016-09-26
| | | | | | | | | | | | In one case the fuzzer was switching the picture's op code to an invalid value In the other two the fuzzer was maxing out the number of points passed to drawPoints and the number of characters passed to drawTextRSXform. In these cases the validation would fail but still return a pointer into the data stream. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2593 Change-Id: Id6d4e6b7bcbae38ace7ad1d92ffcfa5c02f9fb61 Reviewed-on: https://skia-review.googlesource.com/2593 Reviewed-by: Mike Reed <reed@google.com>
* Revert "GN: detect is_clang, use it to switch Clang to warning blacklist."Gravatar Mike Klein2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit I09c3487adfeb26a6fb07e1939cb927c5d7de3107. Reason for revert: -Wover-aligned on x86 Android bots Original issue's description: > GN: detect is_clang, use it to switch Clang to warning blacklist. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2599 > > Change-Id: I09c3487adfeb26a6fb07e1939cb927c5d7de3107 > Reviewed-on: https://skia-review.googlesource.com/2599 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Mike Klein <mtklein@chromium.org> > TBR=mtklein@chromium.org,bungeman@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ic07bf7896a305be6c377f14a573cb10836f1a6f8 Reviewed-on: https://skia-review.googlesource.com/2601 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Documentation: fix linksGravatar halcanary2016-09-26
| | | | | | | TBR= NOTRY=true Review-Url: https://codereview.chromium.org/2366403002
* GN: detect is_clang, use it to switch Clang to warning blacklist.Gravatar Mike Klein2016-09-26
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2599 Change-Id: I09c3487adfeb26a6fb07e1939cb927c5d7de3107 Reviewed-on: https://skia-review.googlesource.com/2599 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Stop aggregating texture/buffer access objects in GrFragmentProcessor parents.Gravatar bsalomon2016-09-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349243002 Review-Url: https://codereview.chromium.org/2365943003
* In makeLinearGamma, return the original CS if it's already linearGravatar Brian Osman2016-09-26
| | | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2589 Change-Id: I51d8f8f64bc5f73a0b7cbf5f01f3d23b56c1895e Reviewed-on: https://skia-review.googlesource.com/2589 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* These calls to SkRandom are not sequenced.Gravatar mtklein2016-09-26
| | | | | | | | | | | | | This is why we see two versions of this GM: some compilers evaluate the rand.nextRangeScalar() calls left to right, others right to left. Remember this bug? BUG=skia:3241 (https://codereview.chromium.org/1157943006 fixed hittestpath last year.) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368263002 Review-Url: https://codereview.chromium.org/2368263002
* fix tiger bGravatar caryclark2016-09-26
| | | | | | | | | | | | | | | The tiger tests have uncovered numerous bugs. This CL fixes the last of them. If a pair of curves do not intersect, but have one or both ends very close to the opposite curve, consider that an intersection. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356363003 Review-Url: https://codereview.chromium.org/2356363003
* Dash to use SkIsAlign2Gravatar cblume2016-09-26
| | | | | | | | Dash checks for alignment by actively aligning. It should really just check for alignment. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2366283002 Review-Url: https://codereview.chromium.org/2366283002
* Add SkColor4f serializationGravatar brianosman2016-09-25
| | | | | | | | | | Adjusted usage in color shader, and will also be using this in gradients, soon. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334123003 Review-Url: https://codereview.chromium.org/2334123003
* Update SKP versionGravatar update-skps2016-09-25
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368053002 Review-Url: https://codereview.chromium.org/2368053002
* Disable msaa on iHD530 bot.Gravatar benjaminwagner2016-09-23
| | | | | | | BUG=skia:5792 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356213005 Review-Url: https://codereview.chromium.org/2356213005
* GN: ANGLEGravatar mtklein2016-09-23
| | | | | | | | | | | | | | | | Angle's existing GN files only work in Chrome, so I've written a new one. This won't work on Windows, but our GN build doesn't work on Windows anyway. So this CL is an attempt to get a ahead of that curve on ANGLE. It looks large but fairly straightforward. Now working on Linux: $ gn gen angle --args=skia_use_angle=true $ ninja -C angle $ angle/dm --config angle-gl --src gm -w dm-out BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2361983002 Review-Url: https://codereview.chromium.org/2361983002
* Change SkSpecialImage::makeSurface and makeTightSurface to take outputGravatar brianosman2016-09-23
| | | | | | | | | | | | | | | | | | | | | | properties (color space), bounds, and (optional) alphaType. We were being pretty inconsistent before. Raster was honoring all components of the info. GPU was using the supplied color type, but propagating the source's color space. All call sites were saying N32. What we want to do is propagate the original device's color space, and pick a good format from that. Rather than force all the clients to jump through hoops constructing an SkImageInfo that meets our criteria, just have them supply the few bits we care about, and do everything else internally. This also lets us always use RGBA on GPU, but N32 on raster. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349373004 Committed: https://skia.googlesource.com/skia/+/53c38087949252d27cde668368a3eeb59cc2eb00 Review-Url: https://codereview.chromium.org/2349373004
* Add validation of RRects to SkValidatingReadBufferGravatar Robert Phillips2016-09-23
| | | | | | | | | | | This comes from the Skia fuzzer where it is inverting the RRect's rect which causes trouble down the line. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2591 Change-Id: I5c34105a47369492d2df99d39a4e29116060ad37 Reviewed-on: https://skia-review.googlesource.com/2591 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Don't compute path keys for volatile paths in GrShape.Gravatar bsalomon2016-09-23
| | | | | | | | | Otherwise, we will compute cache keys for internally transformed paths that don't repeat (e.g. clip paths transformed into device space with a changing view matrix). BUG=chromium:649562 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369513002 Review-Url: https://codereview.chromium.org/2369513002
* Add Pixel C knobs to skpbenchGravatar csmartdalton2016-09-23
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369533002 Review-Url: https://codereview.chromium.org/2369533002
* Some Vulkan memory fixes and cleanupGravatar jvanverth2016-09-23
| | | | | | | | | | | | | * Switch back to not setting transfer_dst on all buffers * Add some missing unit tests * Add tracking of heap usage for debugging purposes * Fall back to non-device-local memory if device-local allocation fails BUG=skia:5031 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003 Committed: https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455 Review-Url: https://codereview.chromium.org/2356343003
* change SkXfermodeImageFilter to carry no impl informationGravatar Mike Reed2016-09-23
| | | | | | | | | | | | | | BUG=skia: NOTREECHECKS=True GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2584 Change-Id: Ibf2dfa7722348ae71a99f1c895de0d2996350e58 Reviewed-on: https://skia-review.googlesource.com/2584 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com>
* fix msan bug in pathopsGravatar caryclark2016-09-23
| | | | | | | | | | | | Msan and Valgrind found an uninitialized memory mistake in pathops. This also fixes similar bugs where not all parts of the geometry were covered in the loop iteration. R=borenet@google.com NOTREECHECKS=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2366893003 Review-Url: https://codereview.chromium.org/2366893003
* Include GLTestContext_command_buffer.cpp in G3 build.Gravatar Mike Klein2016-09-23
| | | | | | | | | | | | | | This is now required to build our GPU testing tools. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2587 NOTREECHECKS=true Change-Id: I219665fbe50e9bbea9abb88a6d63c34b76ca92e6 Reviewed-on: https://skia-review.googlesource.com/2587 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Revert of Create special surfaces according to original device (not always ↵Gravatar brianosman2016-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in N32) (patchset #9 id:160001 of https://codereview.chromium.org/2349373004/ ) Reason for revert: DM crash and/or TSAN failure Original issue's description: > Change SkSpecialImage::makeSurface and makeTightSurface to take output > properties (color space), bounds, and (optional) alphaType. > > We were being pretty inconsistent before. Raster was honoring all > components of the info. GPU was using the supplied color type, but > propagating the source's color space. All call sites were saying N32. > > What we want to do is propagate the original device's color space, and > pick a good format from that. Rather than force all the clients to > jump through hoops constructing an SkImageInfo that meets our criteria, > just have them supply the few bits we care about, and do everything else > internally. > > This also lets us always use RGBA on GPU, but N32 on raster. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349373004 > > Committed: https://skia.googlesource.com/skia/+/53c38087949252d27cde668368a3eeb59cc2eb00 TBR=robertphillips@google.com,reed@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2366723004
* use SkCanvas::ClipOpGravatar Mike Reed2016-09-23
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2583 Change-Id: I651e2c278bb4d2df08b6e134c734c5403c7e7ff7 Reviewed-on: https://skia-review.googlesource.com/2583 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Json ide script for gn to output cmake.Gravatar bungeman2016-09-23
| | | | | | | | | | | | | | | | | | | | Can be run like gn gen out/debug --ide=json --json-ide-script=../../gn/gn_to_cmake.py or gn gen out/debug --ide=json python gn/gn_to_cmake.py out/debug/project.json This first pass creates CMakeLists.txt with just enough information for an ide. Each target is just a static library with sources, include directories, and defines. NOTRY=true This isn't automatically tested. Review-Url: https://codereview.chromium.org/2363873002
* Change SkSpecialImage::makeSurface and makeTightSurface to take outputGravatar brianosman2016-09-23
| | | | | | | | | | | | | | | | | | | | | properties (color space), bounds, and (optional) alphaType. We were being pretty inconsistent before. Raster was honoring all components of the info. GPU was using the supplied color type, but propagating the source's color space. All call sites were saying N32. What we want to do is propagate the original device's color space, and pick a good format from that. Rather than force all the clients to jump through hoops constructing an SkImageInfo that meets our criteria, just have them supply the few bits we care about, and do everything else internally. This also lets us always use RGBA on GPU, but N32 on raster. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349373004 Review-Url: https://codereview.chromium.org/2349373004
* Make GrRenderableConfigForColorSpace argument constGravatar brianosman2016-09-23
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2367813002 Review-Url: https://codereview.chromium.org/2367813002
* Add swarming task for nanobench uploadGravatar borenet2016-09-23
| | | | | | | BUG=skia:5719 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2364693003 Review-Url: https://codereview.chromium.org/2364693003
* split tight quads and conicsGravatar caryclark2016-09-23
| | | | | | | | | | | | Tight quads and conics may nearly fold over on themselves, confusing coincidence against other curves. Split them at their max curvature early on to avoid complicating later logic. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357353002 Review-Url: https://codereview.chromium.org/2357353002
* sRGB cleanup in image filters. Ensure we configure paints correctly.Gravatar brianosman2016-09-22
| | | | | | | | | | | | | | Net effect of the two calls is (basically) the same, but given that we're propagating from isGammaCorrect on the DC, I figured it makes sense to use the same-named API. More importantly, a couple places had slipped through, so those draws would ignore sRGB-ness of inputs entirely. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357413004 Review-Url: https://codereview.chromium.org/2357413004
* It is possible to try and draw to an unsupported format. Let this go.Gravatar brianosman2016-09-22
| | | | | | | | | Squelches assert firing in gradient code on low-end Android bots. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365703002 Review-Url: https://codereview.chromium.org/2365703002
* SkPDF: do not assert when openStream return nullptrGravatar halcanary2016-09-22
| | | | | | | BUG=163892 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332813002 Review-Url: https://codereview.chromium.org/2332813002
* document.close from bool to voidGravatar reed2016-09-22
| | | | | | | | | | | Nothing meaningful is returned, it is inconsistent with the bulk of the rest of skia's api. The C api is waiting on this change as well. Required chrome CL: https://codereview.chromium.org/2355343003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354403002 Review-Url: https://codereview.chromium.org/2354403002
* Revert of Some Vulkan memory fixes and cleanup (patchset #2 id:20001 of ↵Gravatar jvanverth2016-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2356343003/ ) Reason for revert: fHeapIndex is not used in release, need to hide behind SK_DEBUG. Failing on Perf-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Release-GN_Android_Vulkan. Original issue's description: > Some Vulkan memory fixes and cleanup > > * Switch back to not setting transfer_dst on all buffers > * Add some missing unit tests > * Add tracking of heap usage for debugging purposes > * Fall back to non-device-local memory if device-local allocation fails > > BUG=skia:5031 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356343003 > > Committed: https://skia.googlesource.com/skia/+/c5850e9fdb62cc4ae5ed2b6af51aea92cac07455 TBR=egdaniel@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5031 Review-Url: https://codereview.chromium.org/2358123004
* G instead of R, thanks GoldGravatar msarett2016-09-22
| | | | | | | | | NOTRY=true TBR=mtklein@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2362863002 Review-Url: https://codereview.chromium.org/2362863002
* don't close a contour with a line if nothing's thereGravatar caryclark2016-09-22
| | | | | | | | R=kjlubick@google.com BUG=skia:5789 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360083006 Review-Url: https://codereview.chromium.org/2360083006
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 09:42:24 +0000