aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Try /Z7 on Windows builds.Gravatar Mike Klein2017-12-15
| | | | | | | | | | | | | | | | | | | | | Right now /FS and /Zi together serialize debug information into .pdb files through another process. I tried just dropping /FS, so that each cl.exe instance writes to the .pdb file directly, but the bots don't like that. Instead, let's try switching /Zi to /Z7, to embed debug information directly into the object file instead of alongside in a .pdb. This is all about trying to improve build times. https://docs.microsoft.com/en-us/cpp/build/reference/z7-zi-zi-debug-information-format https://docs.microsoft.com/en-us/cpp/build/reference/fs-force-synchronous-pdb-writes Change-Id: If636f8fa21c639eff81d9c335c5223908c0fdcea Reviewed-on: https://skia-review.googlesource.com/85661 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Don't set /GS- on Windows builds.Gravatar Mike Klein2017-12-15
| | | | | | | | | | | | | I'm not sure why we're setting this... it disables buffer overrun protection. That seems like something we'd like on all test bots, not just the Debug ones. https://docs.microsoft.com/en-us/cpp/build/reference/gs-buffer-security-check Change-Id: I0bc3ec146812b4ad3d1d39488caf6e78633830fc Reviewed-on: https://skia-review.googlesource.com/85660 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Roll skia/third_party/externals/angle2/ f414121d4..195be9424 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/f414121d4971..195be9424f8b $ git log f414121d4..195be9424 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 oetuaho Always create TVariables for TIntermSymbol nodes Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I559a51a032ca0e96e8f0ed6f0c67bf86fec826e0 Reviewed-on: https://skia-review.googlesource.com/85622 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Revert "remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code"Gravatar Mike Reed2017-12-15
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7f846f273ceaa5a3a8880e9af260f94bd1e614b6. Reason for revert: missed callsite in google3 Original change's description: > remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code > > Bug: skia: > Change-Id: Ia88f3e2fdf6d5c6e5128eaefda0d68c7042ae7a2 > Reviewed-on: https://skia-review.googlesource.com/85500 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Hal Canary <halcanary@google.com> TBR=halcanary@google.com,reed@google.com Change-Id: I232dc24831bd8d52e9cbbc7ee58177af0617574a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/85600 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead codeGravatar Mike Reed2017-12-15
| | | | | | | | Bug: skia: Change-Id: Ia88f3e2fdf6d5c6e5128eaefda0d68c7042ae7a2 Reviewed-on: https://skia-review.googlesource.com/85500 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* SkBitmap::pixmapGravatar Hal Canary2017-12-15
| | | | | | | | Change-Id: I6d062b9ae1d242970be140d5a1885639c8c45f77 Reviewed-on: https://skia-review.googlesource.com/85320 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Roll skia/third_party/externals/angle2/ f15f9cec3..f414121d4 (2 commits)Gravatar angle-deps-roller@chromium.org2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/f15f9cec318b..f414121d4971 $ git log f15f9cec3..f414121d4 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 jmadill D3D11: Fix program uniform buffer dity bits. 2017-11-16 jiawei.shao ES31: Remove support of GL_OES_geometry_shader in compiler Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I3311a1cfd4c7908dbc1c668960ed64ec39b8ec00 Reviewed-on: https://skia-review.googlesource.com/85281 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
* fix pdf_noneGravatar Mike Reed2017-12-14
| | | | | | | Bug: skia: Change-Id: I36e317ce306c5757988d63e39883495b4a1b0308 Reviewed-on: https://skia-review.googlesource.com/85440 Reviewed-by: Mike Reed <reed@google.com>
* Moving extra options/parameters into PDFMetadataGravatar Mike Reed2017-12-14
| | | | | | | | Bug: skia: Change-Id: I29aa69e5765a7f8ba05b0361912d1f5276d77de3 Reviewed-on: https://skia-review.googlesource.com/84501 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Don't pass a stack address as a pipeline context pointer.Gravatar Mike Klein2017-12-14
| | | | | | | | | | | | | | | | | | | | | We call isNumericalTransferFn() both to test if an SkColorSpace is a 7-parameter numerical transfer function, and to get those parameters if so. They're passed to the stage functions that apply that transfer function via a context pointer. We can't use &srcFn as this pointer, as it's on the stack, and won't be alive by the time we get around to running the pipeline. Instead, copy it to the SkArenaAlloc we thread through just for this purpose. This would be a beginner's mistake, except that I wrote the API myself... Bug: chromium:794406 Change-Id: I9f9581f07a14ab501762f050e2c26f2e55a0c253 Reviewed-on: https://skia-review.googlesource.com/85340 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Explicitly don't initialize matrix to fix deprecation warningGravatar Brian Osman2017-12-14
| | | | | | | | | | | Bug: skia: Change-Id: Ifbe71d5ec303d4b4803f9d5f15c890252a0af204 Reviewed-on: https://skia-review.googlesource.com/85300 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Yuqian Li <liyuqian@google.com>
* Add cert dimension for Mac Builders.Gravatar Ben Wagner2017-12-14
| | | | | | | | | | This will make it easier to transition to new cert. Bug: skia:7408 Change-Id: I9263851233f492c5e62155b61541783aa86ba634 Reviewed-on: https://skia-review.googlesource.com/85006 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Temporarily specify machine_type for Win GCE bots.Gravatar Ben Wagner2017-12-14
| | | | | | | | Bug: skia:7409 Change-Id: Ic86696880858b9744bf9cea86caa3564c1a5e5af Reviewed-on: https://skia-review.googlesource.com/85003 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Suppress warnings of unused variables.Gravatar Derek Sollenberger2017-12-14
| | | | | | | | | | Prepare to compile with default -Werror. Bug: b/66996870 Change-Id: I2dbff68e7482085683adb6b9d214e1af009e7479 Reviewed-on: https://skia-review.googlesource.com/85004 Reviewed-by: Stephen Hines <srhines@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* Roll skia/third_party/externals/angle2/ 9d4d7f06f..f15f9cec3 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/9d4d7f06facb..f15f9cec318b $ git log 9d4d7f06f..f15f9cec3 --date=short --no-merges --format='%ad %ae %s' 2017-12-13 jmadill Vulkan: Roll loader/validation layers SDK. (2/2) Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I900a03231dbdac8d994c6234bc9fc8a43e958033 Reviewed-on: https://skia-review.googlesource.com/85162 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* make SkColorSpace_New realGravatar Mike Klein2017-12-14
| | | | | | | | | | | | | | | | | | | Some interesting things are starting to fall out already, like the fact that I needed to add a gamma_dst stage to be able to draw into gamma-transfer-fn destinations. I've also had to pass an SkAlphaType through to the linearize functions so that they can maintain premul invariants. I'm not sure this is actually a good idea... if you can, please double- check my logic at SkRasterPipeline.cpp:128? If it's correct logic, I'm going to need to do it all over the place. But I imagine you don't do this and somehow get away with it. Change-Id: I42cd9b161b54287d674225103ad9e19f8b388959 Reviewed-on: https://skia-review.googlesource.com/84680 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Send TextBlobCache purge messages only to owning cache.Gravatar Jim Van Verth2017-12-14
| | | | | | | | Bug: 703297 Change-Id: I95cdaa5bdebadd5ce88ae3ee468c59baa08353c6 Reviewed-on: https://skia-review.googlesource.com/85046 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Turn on PGO for skia_nanobench, skia_dmGravatar Pirama Arumuga Nainar2017-12-14
| | | | | | | | | | | | | | These libraries link libskia statically and hence need to do/use PGO instrumentation whenever libskia is instrumented. Test: Build skia_nanobench with ANDROID_PGO_INSTRUMENT=skia Bug: skia: Change-Id: I6b3e64f98f28c7236b47a46c213230ad1c6b95fc Reviewed-on: https://skia-review.googlesource.com/84609 Reviewed-by: Stephen Hines <srhines@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Pirama Arumuga Nainar <pirama@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* Enable Goma fallback by default.Gravatar Ben Wagner2017-12-14
| | | | | | | | | | Add a job that doesn't allow fallback so we know when things aren't working as expected. Change-Id: If993976d6807635bde455c2091f8a1ba18c41e27 Reviewed-on: https://skia-review.googlesource.com/83700 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Switch Goma test jobs to ANGLE/Vulkan.Gravatar Ben Wagner2017-12-14
| | | | | | | | No-Try: true Change-Id: I229c2839d423d543ea7bd1aedec893d7bfeb27ea Reviewed-on: https://skia-review.googlesource.com/83701 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Roll skia/third_party/externals/angle2/ 9af765dd2..9d4d7f06f (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/9af765dd2e44..9d4d7f06facb $ git log 9af765dd2..9d4d7f06f --date=short --no-merges --format='%ad %ae %s' 2017-12-07 oetuaho Classify TSymbols using an enum Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I40e7c45f06c0e6ede4475429563cf06dfafe1bc6 Reviewed-on: https://skia-review.googlesource.com/84962 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Remove SkClampRange (unused)Gravatar Brian Osman2017-12-14
| | | | | | | | Bug: skia: Change-Id: I57fbdd39079a92e803902524a7950dd5f571639c Reviewed-on: https://skia-review.googlesource.com/84961 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com>
* quick-reject before transforming imagesGravatar Mike Klein2017-12-14
| | | | | | | | | | | Transforming images is expensive, and pointless if they're clipped out. Bug: chromium:794690 Change-Id: Iffa4f6c60275caf310b8327e083b8857018621c2 Reviewed-on: https://skia-review.googlesource.com/85044 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Remove SkColorSpace_Base::MakeNamed, along with most uses of Adobe RGBGravatar Brian Osman2017-12-14
| | | | | | | | Bug: skia: Change-Id: Ic914aacc4c47200714d66cf4487932bcb8a7693a Reviewed-on: https://skia-review.googlesource.com/85040 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* convert pipe over to serial procsGravatar Mike Reed2017-12-14
| | | | | | | | Bug: skia: Change-Id: I2c0482dd3ee1d806ff1054c486f73c705bcf2d72 Reviewed-on: https://skia-review.googlesource.com/85042 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com>
* fix broken flatten example and update usingBookmakerGravatar Cary Clark2017-12-14
| | | | | | | | | | | | | A mistake in my local script skipped running bookmaker over some files. Also responding to latest error found by Ravi's tool. Docs-Preview: https://skia.org/?cl=85000 Bug: skia:6898 Change-Id: Ic76e65400850dda8f41fde19bac7e20e53d696df Reviewed-on: https://skia-review.googlesource.com/85000 Commit-Queue: Cary Clark <caryclark@skia.org> Reviewed-by: Cary Clark <caryclark@skia.org>
* pre-api change, preparing for expanding metadataGravatar Mike Reed2017-12-14
| | | | | | | | Bug: skia: Change-Id: I367c728172f24166fb7f06a6e22fe37adb8adc4f Reviewed-on: https://skia-review.googlesource.com/84880 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Roll skia/third_party/externals/angle2/ 21f67ae06..9af765dd2 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/21f67ae06684..9af765dd2e44 $ git log 21f67ae06..9af765dd2 --date=short --no-merges --format='%ad %ae %s' 2017-12-13 jmadill Vulkan: Roll loader/validation layers SDK. (1/2) Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: Icf250caa9d3024558648aa202fff8c4a35fa8a55 Reviewed-on: https://skia-review.googlesource.com/84790 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Revert "Revert "Disable extra CPUs during Nanobench""Gravatar Kevin Lubick2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 43307c09b97c5a5c5174f0c4ccb79bdaf3ebf557. Reason for revert: Fixed this time. Echo 1 > already online cpu returns exit code 1, which makes python over-react. Original change's description: > Revert "Disable extra CPUs during Nanobench" > > This reverts commit 32af335e7abbf562dad8f1bd21bb013610b8b021. > > Reason for revert: many unhappy android bots > > Original change's description: > > Disable extra CPUs during Nanobench > > > > The previous experiment revealed that nanobench can > > run on any of the online CPUs, so rather than put > > the ones we don't need/want into powersave mode, just > > disable them. > > > > Maybe in the future we can run CPU tests on the big > > or LITTLE cpus to get perf data on higher end or > > lower end cpus, but only if we get very stable > > results from this. > > > > Bug: skia:7378 > > Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 > > Reviewed-on: https://skia-review.googlesource.com/84820 > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > Commit-Queue: Kevin Lubick <kjlubick@google.com> > > TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com > > Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9 > Bug: skia:7378 > Reviewed-on: https://skia-review.googlesource.com/84921 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> No-Tree-Checks: true Change-Id: Ie7f0a3dc6ba55c124c796aba16a0f0497f285f3a Bug: skia:7378 Reviewed-on: https://skia-review.googlesource.com/84865 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* add back purgeResourcesNotUsedInMs() temporarilyGravatar Mike Klein2017-12-14
| | | | | | | | | I think this will let Android roll. Change-Id: If6b602d66bcecd711f4340a620d78cdf27ee825f Reviewed-on: https://skia-review.googlesource.com/84960 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert "Disable extra CPUs during Nanobench"Gravatar Mike Klein2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 32af335e7abbf562dad8f1bd21bb013610b8b021. Reason for revert: many unhappy android bots Original change's description: > Disable extra CPUs during Nanobench > > The previous experiment revealed that nanobench can > run on any of the online CPUs, so rather than put > the ones we don't need/want into powersave mode, just > disable them. > > Maybe in the future we can run CPU tests on the big > or LITTLE cpus to get perf data on higher end or > lower end cpus, but only if we get very stable > results from this. > > Bug: skia:7378 > notry=true > notreechecks=true > Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 > Reviewed-on: https://skia-review.googlesource.com/84820 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7378 Reviewed-on: https://skia-review.googlesource.com/84921 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Revert "Remove SkColorSpace_Base::MakeNamed, along with most uses of Adobe RGB"Gravatar Mike Klein2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 411b8ea74d66d08252d9b617d7e7d458604dbc2e. Reason for revert: a couple layout tests in the roll. :/ Original change's description: > Remove SkColorSpace_Base::MakeNamed, along with most uses of Adobe RGB > > Bug: skia: > Change-Id: If5935eac48184bc8cbe4db21dac4d6033a8704e6 > Reviewed-on: https://skia-review.googlesource.com/84200 > Commit-Queue: Brian Osman <brianosman@google.com> > Reviewed-by: Mike Klein <mtklein@chromium.org> TBR=mtklein@chromium.org,brianosman@google.com Change-Id: I6d2eb57b613035ec26da15218182c808bed364ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/84920 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Disable extra CPUs during NanobenchGravatar Kevin Lubick2017-12-14
| | | | | | | | | | | | | | | | | | | | The previous experiment revealed that nanobench can run on any of the online CPUs, so rather than put the ones we don't need/want into powersave mode, just disable them. Maybe in the future we can run CPU tests on the big or LITTLE cpus to get perf data on higher end or lower end cpus, but only if we get very stable results from this. Bug: skia:7378 notry=true notreechecks=true Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 Reviewed-on: https://skia-review.googlesource.com/84820 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* [Infra] Automatically submit docs updatesGravatar Ravi Mistry2017-12-13
| | | | | | | | | No-Tree-Checks: true Bug: skia:7310 Change-Id: I9c26ba4d4c3f4952ec37538b7125294de153e0e6 Reviewed-on: https://skia-review.googlesource.com/84864 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Update markdown filesGravatar Update Docs2017-12-13
| | | | | | | | | | | | | | | Automatic commit by the Housekeeper-Nightly-Bookmaker bot. TBR=update-docs@skia.org NO_MERGE_BUILDS No-Tree-Checks: true Change-Id: I954a88f5fdc11387f07d81d66cfd743803b3538e Reviewed-on: https://skia-review.googlesource.com/84083 Commit-Queue: Update Docs <update-docs@skia.org> Reviewed-by: Update Docs <update-docs@skia.org> Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* [Infra] Fix skiaserve source location againGravatar Ravi Mistry2017-12-13
| | | | | | | | Bug: skia:7399 Change-Id: I749764f2dfc8239e9849cc09e68fb28932d58243 Reviewed-on: https://skia-review.googlesource.com/84861 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Remove SkColorSpace_Base::MakeNamed, along with most uses of Adobe RGBGravatar Brian Osman2017-12-13
| | | | | | | | Bug: skia: Change-Id: If5935eac48184bc8cbe4db21dac4d6033a8704e6 Reviewed-on: https://skia-review.googlesource.com/84200 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Add GrBackendTexture & GrBackendRenderTarget access methods to GrTexture and ↵Gravatar Robert Phillips2017-12-13
| | | | | | | | | GrRenderTarget Change-Id: I627fcc2cab1d04169f49e33a6c17e161e9a9772a Reviewed-on: https://skia-review.googlesource.com/84621 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add strip 2pt conical GMGravatar Yuqian Li2017-12-13
| | | | | | | | | | | | This is distilled from 82161 so we can first change the GMs of our previous bots and then compare the same GM between the old algorithm and the new one. Bug: skia: Change-Id: I4b13bb1a06d109b60c8e29f5f87adad47d0a811b Reviewed-on: https://skia-review.googlesource.com/84523 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Roll skia/third_party/externals/angle2/ ece125358..21f67ae06 (2 commits)Gravatar angle-deps-roller@chromium.org2017-12-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/ece125358ba2..21f67ae06684 $ git log ece125358..21f67ae06 --date=short --no-merges --format='%ad %ae %s' 2017-12-07 jmadill Vulkan: Remove loader/layers from GYP build. 2017-12-13 jmadill Vulkan: Add packed RenderPass descriptions. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I3686fe5797ce5864550d7c7a857963e9e2b795f8 Reviewed-on: https://skia-review.googlesource.com/84783 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Add Goma for all Windows Clang Builds.Gravatar Ben Wagner2017-12-13
| | | | | | | Change-Id: I26e75cf6cd865ec6c47b7766679177bfd30387da Reviewed-on: https://skia-review.googlesource.com/82921 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* cleanup {ASAN,MSAN}_{FAAA,FDAA,FSAA} botsGravatar Mike Klein2017-12-13
| | | | | | | | | | | | | We no longer have any reason to suspect there's anything wrong with these configurations, and we're not actively debugging anything related to them anymore. I've kept the normal Debug/Release bots. Change-Id: I1a3d8087b519d6f01223d3b33bce762511056d1a Reviewed-on: https://skia-review.googlesource.com/84522 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* move divide by zero inside guardGravatar Cary Clark2017-12-13
| | | | | | | | | | | | speculative fix to see if this helps developer. It's the right thing to do in any case. TBR=reed@google.com Change-Id: I4fa576a096a6188f290957a7f2fabe73668f142d Reviewed-on: https://skia-review.googlesource.com/84521 Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* clean up float-cast-overflow blacklistGravatar Mike Klein2017-12-13
| | | | | | | | | | These should be free of overflows now. Bug: skia:7052 Change-Id: I05118fb8f565ffb0d973b6d93a8cd8d8e27f31a9 Reviewed-on: https://skia-review.googlesource.com/84561 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* converted GrMagnifierEffect to SkSLGravatar Ethan Nicholas2017-12-13
| | | | | | | | Bug: skia: Change-Id: I6dc14ac66d5b911117e71fa23fef49a897082781 Reviewed-on: https://skia-review.googlesource.com/71342 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll skia/third_party/externals/angle2/ 5f19810d5..ece125358 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/5f19810d5d1c..ece125358ba2 $ git log 5f19810d5..ece125358 --date=short --no-merges --format='%ad %ae %s' 2017-11-21 yunchao.he ES31: Fix the issue for relink rendering/compute program. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I426b1ec44d5891d5c5a001c8eca68c712a330277 Reviewed-on: https://skia-review.googlesource.com/84720 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
* Revert "Reimplement TwoPointConicalGradient_gpu"Gravatar Yuqian Li2017-12-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 84f18c422ae98085c452d3f721ec32228e92f531. Reason for revert: GMs are incorrect on some mobile devices Original change's description: > Reimplement TwoPointConicalGradient_gpu > > 4.24% faster in gradient_conical_clamp_shallow_dither > 6.43% faster in gradient_conicalOutZero_clamp_hicolor > 10.41% faster in gradient_conicalOut_clamp_hicolor > 14.85% faster in gradient_conicalOutZero_clamp_3color > 16.72% faster in gradient_conicalOut_clamp > 24.30% faster in gradient_conicalOut_clamp_3color > > CQ_INCLUDE_TRYBOTS=skia.primary:Test-Android-Clang-Nexus7-GPU-Tegra3-arm-Release-All-Android,Test-Android-Clang-Nexus7-GPU-Tegra3-arm-Debug-All-Android > > Bug: skia: > Change-Id: I6bc1f24c9463fc9c2acbcba7bd4d55b37ade1613 > Reviewed-on: https://skia-review.googlesource.com/82161 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Yuqian Li <liyuqian@google.com> TBR=egdaniel@google.com,fmalita@google.com,liyuqian@google.com Change-Id: Ieb20cce12a958abb8293218b89baf3d5a2aad0a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Cq-Include-Trybots: skia.primary:Test-Android-Clang-Nexus7-GPU-Tegra3-arm-Release-All-Android, Test-Android-Clang-Nexus7-GPU-Tegra3-arm-Debug-All-Android Reviewed-on: https://skia-review.googlesource.com/84801 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* document default serialization behavior (briefly)Gravatar Mike Reed2017-12-13
| | | | | | | | Bug: skia: Change-Id: Ic3cb3d6a211c7da173a3d637403f7e1c93902f2c Reviewed-on: https://skia-review.googlesource.com/84740 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* binary_resources.cpp only compiles if skia_embed_resourcesGravatar Hal Canary2017-12-13
| | | | | | | Change-Id: Ib96a4646cb7b83a4039c404f547bdaf4160b4942 Reviewed-on: https://skia-review.googlesource.com/84660 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com>
* Roll skia/third_party/externals/angle2/ 8225e73bb..5f19810d5 (1 commit)Gravatar angle-deps-roller@chromium.org2017-12-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/angle/angle.git/+log/8225e73bb30f..5f19810d5d1c $ git log 8225e73bb..5f19810d5 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 bryan.bernhart WebGLCompat: Fix depth & stencil query results. Created with: roll-dep skia/third_party/externals/angle2 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-Clang-x86_64-Release-ANGLE TBR=liyuqian@google.com Change-Id: I8ad7966c8ddc48ebd983f2c2187d348c9e2a01ea Reviewed-on: https://skia-review.googlesource.com/84483 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>