aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* some utils for rect and matrixGravatar reed2015-03-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1003813003
* Have DM and nanobench display times in minutes when they're above 60 seconds.Gravatar mtklein2015-03-12
| | | | | | | | Getting tired of trying to divide in my head when reading Valgrind logs. BUG=skia: Review URL: https://codereview.chromium.org/1004703002
* Ignore public API checks if COMMIT=false is in the descriptionGravatar rmistry2015-03-12
| | | | | | | | | BUG=skia: NOTRY=true Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621 Review URL: https://codereview.chromium.org/1006473002
* Revert of Ignore public API checks if COMMIT=false is in the description ↵Gravatar mtklein2015-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #4 id:80001 of https://codereview.chromium.org/1006473002/) Reason for revert: I cannot upload patches: ~/skia (skskp) $ git clu --bypass-hooks ++ git log -1 --pretty=%B + git cl upload -t update Using 50% similarity for rename/copy detection. Override with --similarity. Loaded authentication cookies from /Users/mtklein/.codereview_upload_cookies Running presubmit upload checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com') Original issue's description: > Ignore public API checks if COMMIT=false is in the description > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621 TBR=borenet@google.com,rmistry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1005583002
* Ignore public API checks if COMMIT=false is in the descriptionGravatar rmistry2015-03-12
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1006473002
* DM: display current memory usage (instead of peak) when available.Gravatar mtklein2015-03-12
| | | | | | | | | | | | | | | Seems strictly more useful. This implements Mac and Windows, which seemed easy. Don't know how to do this on Linux yet. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Mac10.9-MacMini6.2-HD4000-x86_64-Debug-Trybot NOTREECHECKS=true TBR=halcanary@google.com Review URL: https://codereview.chromium.org/990723002
* Make presubmit check that #if or #ifdef does not come before includes.Gravatar rmistry2015-03-12
| | | | | | BUG=skia:3362 Review URL: https://codereview.chromium.org/998273002
* Rejigger keep-alive thread so TSAN and LSAN don't complain.Gravatar mtklein2015-03-12
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1006443002
* Add #include first in Sk4x_* filesGravatar rmistry2015-03-12
| | | | | | BUG=skia:3362 Review URL: https://codereview.chromium.org/1004693002
* DM: add keepalive for Valgrind bot.Gravatar mtklein2015-03-12
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/998263003
* Clean up SkDynamicAnnotations.Gravatar mtklein2015-03-12
| | | | | | | | | | | | | | | | Unprotected reads -> relaxed reads. Unprotected write -> relaxed write. The only unprotected write we had was in SkTraceEvent, which it looks like we nabbed from Chrome at some point and changed only to silence TSAN. Chrome's version uses AtomicWord / NoBarrier_Load / NoBarrier_Store, which boils down to the same as here, intptr_t / relaxed load / relaxed store. This leaves one place where we're lying a bit to TSAN, in include/core/SkLazyPtr.h where we're doing a data-dependent consume load. We're telling TSAN it's consume, but telling any other compiler to compile it as relaxed, given how they all upgrade consume to acquire. This eliminates a barrier for us on ARM. How do you guys deal with this? Just use a consume memory order, take the hit, and hope compilers get smarter one day? BUG=chromium:465721 No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/996763002
* Fix HWUI Sink for DMGravatar Derek Sollenberger2015-03-12
| | | | Review URL: https://codereview.chromium.org/996413002
* Add terrible workaround to fix stencil clear crash on S3.Gravatar bsalomon2015-03-11
| | | | | | BUG=skia:3525 Review URL: https://codereview.chromium.org/1001693003
* Glyph positions maintain 32 bit integer part.Gravatar bungeman2015-03-11
| | | | | | | | | | | | | A glyph position when mapped from canvas space to device space may land outside the bounds of the current 16 bit integer part of device space. Device space is already limited to 32 bits for the integer part, but for a short space in drawText and drawPosText it is currently limited to 16 bits (SkFixed). Raise this limit by moving to 48.16. This matches the current similar fix for measureText. BUG=chromium:375322 Review URL: https://codereview.chromium.org/977623002
* Fix Windows build.Gravatar scroggo2015-03-11
| | | | | | | | | | | | | | | | | | | | SK_BUILD_FOR_WIN is no longer a valid way to check for building on Windows (go figure). Build everywhere. Remove the REPORTER_ASSERT, which was the failing part. It also isn't necessary for the test, which is just that we are not leaking an SkColorTable. Also fix indentation. TBR=bungeman@google.com,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3457 Review URL: https://codereview.chromium.org/1002583002
* Since SkDrawFilter has serious architectural issues and may beGravatar tomhudson2015-03-11
| | | | | | | | | | | | deprecated, use a proxy SkCanvas for the same end: in every draw call, inspect the paint, changing it to fit within the capabilities of the Android Java (HWUI) drawing API. Verified that this allows us to reenable all our ColorFilter tests. R=djsollen@google.com Review URL: https://codereview.chromium.org/997183003
* delete dead codeGravatar mtklein2015-03-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1003493002
* For safety include SkTypes.h in SkFontHost_mac.cppGravatar mtklein2015-03-11
| | | | | | BUG=skia:3362 Review URL: https://codereview.chromium.org/996113003
* Clean up poppler code.Gravatar mtklein2015-03-11
| | | | | | | | | We're not actually using it. BUG=skia:3362 DOCS_PREVIEW= https://skia.org/?cl=1002493002 Review URL: https://codereview.chromium.org/1002493002
* Adjust atlas sizes to fix Mali400 precision issuesGravatar jvanverth2015-03-11
| | | | | | | | | | | | | | | | | | | The previous change to atlas sizes introduced an issue where texture coordinates for glyphs stored on the right side of the atlas were being computed in an imprecise manner on Mali400 chips. The only reasonable fix appears to be to use power-of-two texture sizes. This widens the glyph atlas to the next power of 2 (or 2048) for A8 glyphs only, and widens each GrPlot by 2x as well. By doing this, we can fit 3-4 large distance field glyphs into a single GrPlot, which gives us 100-128 total large glyphs at one time. The 565 and 8888 glyph atlases are kept in their original size to preserve space. BUG=skia:3523 Review URL: https://codereview.chromium.org/994303003
* Fix debugger's overdraw color filterGravatar robertphillips2015-03-11
| | | | | | The colors seen in the overdraw color filter are not guaranteed to remain the colors from its own table. Looping through the table to find the old overdraw level is error prone and expensive. Review URL: https://codereview.chromium.org/997913002
* Use proper SkFDot6 instead of intGravatar qiankun.miao2015-03-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/960353005
* Fix a memory leak when decoding corrupted indexed PNGs.Gravatar dml2015-03-11
| | | | | | | | | | Commit to branch refs/heads/png-leak BUG=skia:3457 Committed: https://skia.googlesource.com/skia/+/561a1ca9559a1ea7589ab93350124284fcef3315 Review URL: https://codereview.chromium.org/951663002
* Simplify clip inside a layer -- will be applied in restoreGravatar reed2015-03-11
| | | | | | | | | This reverts commit 44124650895833378938b4b174302fbf64403fe2. NOTREECHECKS=True BUG=skia: Review URL: https://codereview.chromium.org/996233002
* fix for valgrind preAbandonGpuContextGravatar joshualitt2015-03-11
| | | | | | | | NOTREECHECKS=true BUG=skia: Review URL: https://codereview.chromium.org/997923002
* optimization/fix: dirty the clip-bounds when we mod the clip in savelayerGravatar reed2015-03-11
| | | | | | | | | Before the fix, we could use a stale cache of the clipbounds in quickReject. Often this could return false negatives, meaning we would try to draw more than we should (it would eventually be really clipped). Occasionally this could also report false positives (if the layer were outside of the normal canvas bounds, e.g. a layer with an offset imagefilter). BUG=skia: NOTREECHECKS=True Review URL: https://codereview.chromium.org/983243003
* Skip WritePixels on GalaxyS3Gravatar mtklein2015-03-11
| | | | | | | | | | TBR=bsalomon@google.com NOTREECHECKS=true BUG=skia: Review URL: https://codereview.chromium.org/994343003
* DM: show skipped and --blacklist notes only in verbose mode.Gravatar mtklein2015-03-11
| | | | | | | | | | | In non-verbose mode, these notes will spin away too fast to read anyway, unless they're so long they end up leaving junk on the terminal. NOTREECHECKS=true BUG=skia: Review URL: https://codereview.chromium.org/989083002
* Revert of simplify clip inside a layer -- will be applied in restore ↵Gravatar reed2015-03-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/997763002/) Reason for revert: slight rebaselines needed in layouttests http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/51755 Original issue's description: > simplify clip inside a layer -- will be applied in restore > > BUG=skia: > TBR= > NOTREECHECKS=True > > speculative land to measure performance > > Committed: https://skia.googlesource.com/skia/+/c275493d4247a2c5ae845d340c4297258f4684bc TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/997103002
* simplify clip inside a layer -- will be applied in restoreGravatar reed2015-03-10
| | | | | | | | | | BUG=skia: TBR= NOTREECHECKS=True speculative land to measure performance Review URL: https://codereview.chromium.org/997763002
* remove unused params to DeviceCM constructorGravatar reed2015-03-10
| | | | | | | | BUG=skia: TBR= NOTREECHECKS=True Review URL: https://codereview.chromium.org/999593002
* Don't run ResourceCache unit test on NexusPlayer.Gravatar mtklein2015-03-10
| | | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/992203005
* Adjust distance field glyph and font atlas sizes to maximize storage.Gravatar jvanverth2015-03-10
| | | | | | | | | | | | | | | | Because of high DPI devices, we need more room in the glyph atlas for the larger glyphs. These settings will allow 4 of the distance field glyphs to fit in one Plot (increasing the storage from 32 large glyphs to 128), and still permit us to handle glyphs up to a 312 point size. BUG=chromium:458791 Committed: https://skia.googlesource.com/skia/+/d2737ad7dd8f4ea94a74034027014fd3d78923cb Committed: https://skia.googlesource.com/skia/+/07e245ffe1ca7f781590fcff904c2922c2269781 Review URL: https://codereview.chromium.org/986343002
* Revert of Adjust distance field glyph and font atlas sizes to maximize ↵Gravatar jvanverth2015-03-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | storage. (patchset #8 id:140001 of https://codereview.chromium.org/986343002/) Reason for revert: Still seeing bad text rendering in GMs with Nexus 2 and Nexus 3. Original issue's description: > Adjust distance field glyph and font atlas sizes to maximize storage. > > Because of high DPI devices, we need more room in the glyph > atlas for the larger glyphs. These settings will allow 4 of > the distance field glyphs to fit in one Plot (increasing > the storage from 32 large glyphs to 128), and still permit > us to handle glyphs up to a 312 point size. > > BUG=chromium:458791 > > Committed: https://skia.googlesource.com/skia/+/d2737ad7dd8f4ea94a74034027014fd3d78923cb > > Committed: https://skia.googlesource.com/skia/+/07e245ffe1ca7f781590fcff904c2922c2269781 TBR=joshualitt@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:458791 Review URL: https://codereview.chromium.org/995863002
* Fix bug in Valgrind flags config.Gravatar mtklein2015-03-10
| | | | | | | | | | | 'GPU' is in 'Test-Ubuntu14-GCE-NoGPU-x86_64-Release-Valgrind_CPU' too. This means we're building it in no-GPU mode, and running it in no-CPU mode. At least it finishes quite quickly this way (~10 seconds). BUG=skia: Review URL: https://codereview.chromium.org/992203004
* Adjust distance field glyph and font atlas sizes to maximize storage.Gravatar jvanverth2015-03-10
| | | | | | | | | | | | | | Because of high DPI devices, we need more room in the glyph atlas for the larger glyphs. These settings will allow 4 of the distance field glyphs to fit in one Plot (increasing the storage from 32 large glyphs to 128), and still permit us to handle glyphs up to a 312 point size. BUG=chromium:458791 Committed: https://skia.googlesource.com/skia/+/d2737ad7dd8f4ea94a74034027014fd3d78923cb Review URL: https://codereview.chromium.org/986343002
* Update SKP versionGravatar skia.buildbots2015-03-10
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/991263002
* Add pageset for thevergeGravatar rmistry2015-03-10
| | | | | | | | | | BUG=skia:3234 TBR=robertphillips NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/994923002
* Increase maximum gpu resources from 1024 to 4096Gravatar kkinnunen2015-03-09
| | | | | | | | | | | Pictures with many drawn paths benefit from the increase of the count. As an example, chalkboard testcase has ~2500 paths, tiger has ~300. Bigger objects, like textures, tend to be limited by the cache byte limit, not item count. Review URL: https://codereview.chromium.org/991783003
* Use SkTMin and SkTMax for clamp/pin.Gravatar bungeman2015-03-09
| | | | | | | | This changes SkScalarClampMax and SkScalarPin to use SkTMin and SkTMax. This change allows compilers to more easily transform these operations into fast max/min operarations as opposed to conditional branches. Review URL: https://codereview.chromium.org/993593002
* Revert of Adjust distance field glyph and font atlas sizes to maximize ↵Gravatar jvanverth2015-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | storage. (patchset #5 id:80001 of https://codereview.chromium.org/986343002/) Reason for revert: There's some weirdness with Tegra2 and Tegra3 GMs (Xoom and Nexus7) that may be related to this. Original issue's description: > Adjust distance field glyph and font atlas sizes to maximize storage. > > Because of high DPI devices, we need more room in the glyph > atlas for the larger glyphs. These settings will allow 4 of > the distance field glyphs to fit in one Plot (increasing > the storage from 32 large glyphs to 128), and still permit > us to handle glyphs up to a 312 point size. > > BUG=chromium:458791 > > Committed: https://skia.googlesource.com/skia/+/d2737ad7dd8f4ea94a74034027014fd3d78923cb TBR=joshualitt@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:458791 Review URL: https://codereview.chromium.org/986333005
* Use global GrMemoryPools protected by mutex for GrProcessor/GrBatchGravatar bsalomon2015-03-09
| | | | | | BUG=chromium:464892 Review URL: https://codereview.chromium.org/991943002
* Adjust distance field glyph and font atlas sizes to maximize storage.Gravatar jvanverth2015-03-09
| | | | | | | | | | | | Because of high DPI devices, we need more room in the glyph atlas for the larger glyphs. These settings will allow 4 of the distance field glyphs to fit in one Plot (increasing the storage from 32 large glyphs to 128), and still permit us to handle glyphs up to a 312 point size. BUG=chromium:458791 Review URL: https://codereview.chromium.org/986343002
* Allow user to pass in a path for extra dependencies for gpuGravatar egdaniel2015-03-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/986363002
* Remove SK_SUPPORT_LEGACY_ADDOVALGravatar fmalita2015-03-09
| | | | | | | | | The flad has been retired from Chromium. BUG=chromium:458898 R=reed@google.com Review URL: https://codereview.chromium.org/994533002
* Run Valgrind bots with --nogpu and --nocpu as appropriateGravatar borenet2015-03-09
| | | | | | | BUG=skia:3506 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/986583004
* Revert of use colorfilter instead of imagefilter when possible (patchset #6 ↵Gravatar reed2015-03-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | id:100001 of https://codereview.chromium.org/966233002/) Reason for revert: Lots of PDF failures -- need to investigate Original issue's description: > use colorfilter instead of imagefilter when possible > > big speed win w/ nanobench --match colorfilter_ > > BUG=skia: > TBR= > > Will require rebaselining, so landing temporarily to trigger layouttests. > > Committed: https://skia.googlesource.com/skia/+/f641bd076d29666a5d2a10d5384e4924b0a0e524 TBR=sugoi@google.com,senorblanco@google.com,bsalomon@google.com,reed@google.com,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/991693002
* use colorfilter instead of imagefilter when possibleGravatar reed2015-03-08
| | | | | | | | | | | big speed win w/ nanobench --match colorfilter_ BUG=skia: TBR= Will require rebaselining, so landing temporarily to trigger layouttests. Review URL: https://codereview.chromium.org/966233002
* Use ComposColorFilter to collaps hierarchy (when possible).Gravatar reed2015-03-08
| | | | | | | | | | | | | Clarify asColorFilter ... 1. Rename to isColorFilterNode for DAG reduction 2. Add asAColorFilter for removing the imagefilter entirely (future use-case) Need layouttest rebaseline suppression before this can land in chrome... https://codereview.chromium.org/984023004/ BUG=skia: Review URL: https://codereview.chromium.org/982933002
* Revert of For consistency, use our homebrew zlib everywhere possible. ↵Gravatar mtklein2015-03-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #6 id:100001 of https://codereview.chromium.org/971673005/) Reason for revert: Reverting in case this is the cause of the non-Windows failures. Original issue's description: > For consistency, use our homebrew zlib everywhere possible. > > This switches when we build our own zlib from "just Windows" to "everyone, but > not Android framework of course". > > I tested this by building DM for my Mac and for an Android bot config. > It took minor tweaks to the GYP to get ARM builds working. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/5a8f2257b0b0f954fb74f65e7ea3ada772ed9240 TBR=scroggo@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/989873002
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-05 23:22:53 +0000