aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Move inval dedup to Window for wider usages.Gravatar liyuqian2016-05-23
| | | | | | | | | | | It turns out that the inval dedup is not just useful for Android. Hence we move it up to the Window level so more OSes such as Linux, Windows can also use it. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2001153002 Review-Url: https://codereview.chromium.org/2001153002
* Test color correction in DMGravatar msarett2016-05-23
| | | | | | | | | | | | | | | | | | | | | This will allow me to test and visualize some assumptions on parsing and applying color profiles. Also, it should help me find and fix bugs. This is certainly not an optimized implementation, and, as far as I know, it doesn't take any shortcuts to improve performance. We'll probably want to do both of these once we know where it fits in the pipeline. Right now this test is only run on an arbitrary set of ~100 images from the top 10k skps. I'll continue to add more "interesting" images and probably tweak the code as necessary. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1995233003 Review-Url: https://codereview.chromium.org/1995233003
* Update image testing to version 6Gravatar msarett2016-05-23
| | | | | | | | | | | | | | This replaces the old HTC.dng test image (~40 MB) with a much smaller HTC.dng (~125 kb). This should limit OOM errors on our bots and improve the speed of the tests suite. BUG=skia:5283 BUG=skia:5307 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004113002 Review-Url: https://codereview.chromium.org/2004113002
* Enable tri-linear and NPOT-tiling support in VulkanGravatar brianosman2016-05-23
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004123002 Review-Url: https://codereview.chromium.org/2004123002
* Add vksrgb config to dm (Vulkan sRGB). Fix help formatting of vk.Gravatar brianosman2016-05-23
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2005863002 Review-Url: https://codereview.chromium.org/2005863002
* Make SkColorSpace a public APIGravatar msarett2016-05-23
| | | | | | | | | I've trimmed uniqueID for now, and added some comments. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1996973002 Review-Url: https://codereview.chromium.org/1996973002
* SkTypes: use constexpr when appropriateGravatar halcanary2016-05-23
| | | | | | | | motivation: https://codereview.chromium.org/2000853003 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004073002 Review-Url: https://codereview.chromium.org/2004073002
* fiddle: srand(0) before draw(canvas)Gravatar halcanary2016-05-23
| | | | | | TBR= Review-Url: https://codereview.chromium.org/2003043002
* Pretend that Adreno4xx doesn't have sRGB write control.Gravatar brianosman2016-05-23
| | | | | | | BUG=skia:5329 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1998953003 Review-Url: https://codereview.chromium.org/1998953003
* Update SKP versionGravatar update-skps2016-05-22
| | | | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= NO_MERGE_BUILDS GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004773002 Review-Url: https://codereview.chromium.org/2004773002
* Remove unnecessary checkGravatar scroggo2016-05-20
| | | | | | | | | | Follow-on from crrev.com/1996993003 No need to check the alpha type. If the color type is gray, the source alpha type will be opaque. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2002723002 Review-Url: https://codereview.chromium.org/2002723002
* Finish supporting decoding opaque to non-opaqueGravatar scroggo2016-05-20
| | | | | | | | | | | | | | | | | When decoding to 565 or Gray, allow the client to incorrectly ask for premul. When checking whether it's possible to decode to 565, return whether the source is opaque. In DM, allow decoding to 565 or Gray, even if the client also asked for premul. This fixes a bug introduced in crrev.com/1999593003 when we stopped ever requesting Opaque, resulting in us not testing 565 or Gray. BUG=skia:4616 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1996993003 Review-Url: https://codereview.chromium.org/1996993003
* Save comparisons for release.Gravatar liyuqian2016-05-20
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1997003003 Review-Url: https://codereview.chromium.org/1997003003
* Use SkASSERTResult to avoid unused local variablesGravatar liyuqian2016-05-20
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2003653002 Review-Url: https://codereview.chromium.org/2003653002
* Remove custom bundle ID for iOSGravatar stephana2016-05-20
| | | | | | | | BUG=skia: R=borenet GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1998273002 Review-Url: https://codereview.chromium.org/1998273002
* Retract GrRenderTarget from GrTestTargetGravatar robertphillips2016-05-20
| | | | | | | | Split out of: https://codereview.chromium.org/1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=2004433002 Review-Url: https://codereview.chromium.org/2004433002
* Only decode opaque to premul in DM imageGravatar scroggo2016-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, we would test decoding an opaque SkCodec to all three: kUnpremul, kPremul, kOpaque The image should look the same in all three cases. We already test for that in CodecTest [1], where we require that the result matches exactly. CodecTest runs on a smaller set of images, but it covers a variety of opaque images. No need to test on all opaque images. Running locally on my Mac laptop, the following command: dm --src image --images resources/ dropped from: 5932 srcs 11.2s to: 3544 srcs 6.69s for a 40% speedup. BUG=skia:5307 [1] https://skia.googlesource.com/skia/+/master/tests/CodecTest.cpp#119 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1999593003 Review-Url: https://codereview.chromium.org/1999593003
* gyp (third_party) warning changes for ccacheGravatar halcanary2016-05-20
| | | | | | | | Also fix a broken unit test in MatrixTest.cpp. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2002663002 Review-Url: https://codereview.chromium.org/2002663002
* When building circle blur profile evaluate kernel vertically once per columnGravatar bsalomon2016-05-20
| | | | | | | BUG=skia:5224 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1991413002 Review-Url: https://codereview.chromium.org/1991413002
* Make LinearSrcOverBench not crash in constructor when resource path is missingGravatar bsalomon2016-05-20
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1998113003 Review-Url: https://codereview.chromium.org/1998113003
* Stop creating CodecSrcs with unused scaleGravatar scroggo2016-05-20
| | | | | | | | | | | | | | | | | | | | | Only JPEG and WEBP support native scaling, so only create a CodecSrc with a scale for those types. If I run dm --src image --images resources this cuts down the number of Srcs from 11063 to 8032. All of these trimmed Srcs would have failed quickly for each Sink (3 Sinks with the above flags), but this will avoid creating them. It drops the runtime on my mac from 13.2s to 11.4s, for about a 14% speedup. BUG=skia:5307 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1999103002 Review-Url: https://codereview.chromium.org/1999103002
* Adjust size of imagemakewithfilter GM.Gravatar senorblanco2016-05-20
| | | | | | | | TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=2003453003 Review-Url: https://codereview.chromium.org/2003453003
* Correct gesture scale and translationGravatar liyuqian2016-05-20
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1996613002 Review-Url: https://codereview.chromium.org/1996613002
* Fix leak in SkImage_Gpu::onMakeSubset().Gravatar senorblanco2016-05-20
| | | | | | | BUG=skia:5327 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2003573002 Review-Url: https://codereview.chromium.org/2003573002
* Fix android scripts now that the $HOST is always lowercase.Gravatar djsollen2016-05-20
| | | | | | | BUG=skia:5309 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1992873003 Review-Url: https://codereview.chromium.org/1992873003
* GrSWMaskHelper and GrSoftwarePathRenderer only need the textureProvider (not ↵Gravatar robertphillips2016-05-20
| | | | | | | | | | GrContext) This is split out of: https://codereview.chromium.org/1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder) BUG=skia: Review-Url: https://codereview.chromium.org/1993403002
* Reduce the number of BRDSrcs run in DMGravatar scroggo2016-05-20
| | | | | | | | | | Testing to e.g. Index8 is useful, but not usefully different across all sampleSizes and Modes. (Same for Gray.) Drop several Srcs. BUG=skia:5307 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1990173003 Review-Url: https://codereview.chromium.org/1990173003
* Add OpenGL context to Viewer.Gravatar jvanverth2016-05-20
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978573003 Committed: https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f Review-Url: https://codereview.chromium.org/1978573003
* Fix Gold trybot results URLGravatar rmistry2016-05-20
| | | | | | | BUG=skia:5324 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1996103002 Review-Url: https://codereview.chromium.org/1996103002
* Make GrAtlasTextBlob::run own effects it points to.Gravatar bsalomon2016-05-19
| | | | | | | | | | BUG=chromium:608566 Currently the run has bare pointers and the effects can be destroyed while a run is pointing at them. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1993213003 Review-Url: https://codereview.chromium.org/1993213003
* Make circle blur profile computation separableGravatar bsalomon2016-05-19
| | | | | | | BUG=skia:5224 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1996653002 Review-Url: https://codereview.chromium.org/1996653002
* Image filters: implement SkImage::makeWithFilter().Gravatar senorblanco2016-05-19
| | | | | | | | | | This API provides a way to directly filter a subregion of an SkImage (usually texture-backed), and returns an SkImage which may include extra padding, along with a size to indicate the active region. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1964043002 Review-Url: https://codereview.chromium.org/1964043002
* Make an embeddable container to hold linear pipelines.Gravatar herb2016-05-19
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1998793002 Review-Url: https://codereview.chromium.org/1998793002
* Retract GrRenderTarget from GLProgramsTestGravatar robertphillips2016-05-19
| | | | | | | | Split out of https://codereview.chromium.org/1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1997773002 Review-Url: https://codereview.chromium.org/1997773002
* Attempt to improve lifetime management of SkGlyphCache in Ganesh atlas text ↵Gravatar bsalomon2016-05-19
| | | | | | | | code. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1983353003 Review-Url: https://codereview.chromium.org/1983353003
* Make GrAppliedClip friendlessGravatar robertphillips2016-05-19
| | | | | | | | | GrAppliedClip is a pretty amiable class but not so good about setting boundaries. It is probably for the best that it breaks things off with GrClipMaskManager before the drama of https://codereview.chromium.org/1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder) begins. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1993263002 Review-Url: https://codereview.chromium.org/1993263002
* Remove mutex for retrieving default typeface.Gravatar bungeman2016-05-19
| | | | | | | | | | This mutex was added due to FontConfigTypeface::LegacyCreateTypeface being non-thread safe. This method no longer exists and the logic was moved to SkFontMgr_FCI::onLegacyCreateTypeface which has access to an appropriate mutex ("Clean up SkFontConfigInterface implementation.", 0265707c191a31dfde08dd1cd7011c1fe5b8e643). Review-Url: https://codereview.chromium.org/1994703003
* Propagate filter mode when rendering Alpha8 bitmapsGravatar brianosman2016-05-19
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1988023009 Review-Url: https://codereview.chromium.org/1988023009
* Delete workaround for matching bitmap and pixel ref rowbytesGravatar msarett2016-05-19
| | | | | | | | | | We now handle this in: https://googleplex-android-review.git.corp.google.com/#/c/1051261/ BUG=skia:4538 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1992143003 Review-Url: https://codereview.chromium.org/1992143003
* Assert complex precondition in SkGlyphCache::Visit.Gravatar bungeman2016-05-19
| | | | | | | | | SkGlyphCache::Visit takes a descriptor and a typeface, but it is implied that the fFontID in the descriptor is the id of the typeface. This seems to be handled correctly by current callers but this is a subtle requirement which if violated could lead to subtle bugs. Review-Url: https://codereview.chromium.org/1992053002
* Update Skia milestone to 53 after 52 branchGravatar hcm2016-05-19
| | | | | | | | | TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1993203002 Review-Url: https://codereview.chromium.org/1993203002
* Revert of Don't allow uncacheable paths in tessellated path renderer ↵Gravatar bsalomon2016-05-18
| | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/1990793003/ ) Reason for revert: Caused innershapes test to be rendered incorrectly on the N10. This might be a driver bug. Original issue's description: > Don't allow uncacheable paths in tessellated path renderer > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1990793003 > > Committed: https://skia.googlesource.com/skia/+/aebd0fd32f8fde610de03b4f1e6d11ce24bfb73d TBR=senorblanco@google.com,senorblanco@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1993923002
* Fix example code in skpaint.md.Gravatar benjaminwagner2016-05-18
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1993903002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1993903002 Review-Url: https://codereview.chromium.org/1993903002
* Blacklist HTC.dng on 32-bit Win CPU botsGravatar borenet2016-05-18
| | | | | | | BUG=skia:5318 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1995703002 Review-Url: https://codereview.chromium.org/1995703002
* Skip composeshader_bitmap GM on 64-bit Win CPU Test botsGravatar borenet2016-05-18
| | | | | | | | | Temporary measure to get the bots green while the real issue is sorted out. BUG=skia:5315 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1989323002 Review-Url: https://codereview.chromium.org/1989323002
* Don't allow uncacheable paths in tessellated path rendererGravatar bsalomon2016-05-18
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1990793003 Review-Url: https://codereview.chromium.org/1990793003
* SkCanvas::adjustToTopLayer()Gravatar tomhudson2016-05-18
| | | | | | | | | | | | Given a matrix and a clip bounds, offsets them to reflect the difference between device coordinates and global coordinates. Useful when a client wants an OS-specific backing for a canvas. R=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1986383002 Review-Url: https://codereview.chromium.org/1986383002
* Reformat circle blur profile computation and add comments.Gravatar bsalomon2016-05-18
| | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1981923002 BUG=skia:5224 Review-Url: https://codereview.chromium.org/1981923002
* Revert of Add OpenGL context to Viewer. (patchset #7 id:120001 of ↵Gravatar jvanverth2016-05-18
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1978573003/ ) Reason for revert: sk_app/WindowContext.cpp is missing. Need to add file and resubmit. Original issue's description: > Add OpenGL context to Viewer. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978573003 > > Committed: https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f TBR=brianosman@google.com,bsalomon@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/1990893002
* Image filters: fix filtering of transparent black in CFIF.Gravatar senorblanco2016-05-18
| | | | | | | | | | | | | | | | | SkColorFilterImageFilter has a codepath to filter transparent black regions outside of the input image. However, it was treating the exterior as opaque black, rather than trasparent black. Note: the results of imagefiltercropexpand GM will change, as it was tweaked a bit to show this bug. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978363002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1978363002
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-03 15:12:09 +0000