aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* cumulative pathops patchGravatar caryclark2015-03-26
| | | | | | | | | | | | | | | | | | | | | Replace the implicit curve intersection with a geometric curve intersection. The implicit intersection proved mathematically unstable and took a long time to zero in on an answer. Use pointers instead of indices to refer to parts of curves. Indices required awkward renumbering. Unify t and point values so that small intervals can be eliminated in one pass. Break cubics up front to eliminate loops and cusps. Make the Simplify and Op code more regular and eliminate arbitrary differences. Add a builder that takes an array of paths and operators. Delete unused code. BUG=skia:3588 R=reed@google.com Review URL: https://codereview.chromium.org/1037573004
* remove slower scalar code in favor of vectorsGravatar reed2015-03-26
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1001833006
* Add a paint filter utility canvas (SkPaintFilterCanvas)Gravatar fmalita2015-03-26
| | | | | | | | | | Introduce a paint filter proxy base class as a SkDrawFilter replacement, and convert SkDebugCanvas to use the new approach. BUG=skia:3587 R=reed@google.com,mtklein@google.com,robertphillips@google.com,tomhudson@google.com Review URL: https://codereview.chromium.org/1032173002
* Use a wrapper for SkDebugf in SkCodec.Gravatar scroggo2015-03-26
| | | | | | | | | | | It can be silenced or not with one flag. Always print when building for the android framework. Also remove the meaningless define of override to override. BUG=skia:3257 Review URL: https://codereview.chromium.org/1032093004
* SkCodec: conditionally remove fInfoGravatar halcanary2015-03-26
| | | | Review URL: https://codereview.chromium.org/1029423005
* Add a go-fast button to Skia GYP configs.Gravatar mtklein2015-03-26
| | | | | | | | | | | | | | | | | | | | | | ./gyp_skia -Dskia_fast=1 will - always optimize for the current machine as much as possible - drop the frame pointer - optimize floating point arithmetic ignoring IEEE compliance This allows things like 3-argument VEX prefix SSE instructions and NEON autovectorization, and can give some seriously helpful clues about how to rearrange floating point math for speed. I've been having trouble with LTO linking, so I'll leave that out for now. I don't think we should set up bots with this mode. -ffast-math means I'm forced to run DM with --match ~Blend ~Path ~Rect ~Math ~Scalar ~Matrix ~Point before it passes, which is a disconcerting chunk of tests to disable (including all of PathOps). BUG=skia: Review URL: https://codereview.chromium.org/1036533003
* pdf skp tabl_worldjournal.skp took 5 days to run on ValgrindGravatar mtklein2015-03-26
| | | | | | | | | #notry BUG=skia: NOTRY=true Review URL: https://codereview.chromium.org/1030263003
* remove #if 0 codeGravatar reed2015-03-26
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1032273003
* use custom search for pathmeasureGravatar reed2015-03-26
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1037653002
* C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}Gravatar mtklein2015-03-25
| | | | | | | | | NOPRESUBMIT=true BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1037793002 Review URL: https://codereview.chromium.org/1037793002
* hack on linear gradientGravatar mtklein2015-03-25
| | | | | | | | | | Am I going nuts or can we get this down to just adds and converts in the loop? #floats #n9 BUG=skia:3592 CQ_INCLUDE_TRYBOTS=client.skia.android:Test-Android-Nexus9-TegraK1-Arm64-Release-Trybot Review URL: https://codereview.chromium.org/1008973004
* Remove sfnt dependency from xps gyp tartget.Gravatar bungeman2015-03-25
| | | | | | | | | | The xps gyp target depends on skia_lib, which in turn contains the sfnt target (and re-exports it settings). As a result, it should not separately depend on the sfnt target. This currently isn't causing issues because the sfnt target is mostly header only, but any code in it may be duplicated. Review URL: https://codereview.chromium.org/1038693003
* Use Sk4x to speed-up bounds of an array of pointsGravatar reed2015-03-25
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1015633004
* Add more parameters to GrTextContext::canDrawGravatar cdalton2015-03-25
| | | | | | | | | | | | | Updates canDraw to accept all the same Skia/Gr objects as the drawText functions, since that information may very well be relevant in determining whether a context can draw. Also moves the onDrawTextBlob implementation directly into drawTextBlob. BUG=skia: Review URL: https://codereview.chromium.org/1010113004
* Test scanline decoding in DM.Gravatar scroggo2015-03-25
| | | | | | BUG=skia:3475 Review URL: https://codereview.chromium.org/999173010
* Replace error checking mutex initializer with the glibc-compatible versionGravatar djsollen2015-03-25
| | | | | | | No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1038733002
* Update 4-at-a-time APIs.Gravatar mtklein2015-03-25
| | | | | | | | | | | There is no reason to require the 4 SkPMFloats (registers) to be adjacent. The only potential win in loads and stores comes from the SkPMColors being adjacent. Makes no difference to existing bench. BUG=skia: Review URL: https://codereview.chromium.org/1035583002
* simple patch to always init SkTextBlob uniqueIDGravatar joshualitt2015-03-25
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1036613002
* SkPDF SkPDFObject::addResources signature simplifiedGravatar halcanary2015-03-25
| | | | | | | | | | - SkPDFcatalog keeps a ordered list of object pointers - Elimiante SkTSet template class - SkPDFObject::addResources signature changes BUG=skia:3585 Review URL: https://codereview.chromium.org/1038523004
* Lazy SKP image decoding in DM.Gravatar mtklein2015-03-25
| | | | | | | | | | | | | | | | | | | @sugoi: Early out to avoid some segfaults in SkImageDecoder_libjpeg.cpp. I am just flailing here... things seem to work, but I have no idea why. This prints out a lot: libjpeg error 85 <End Of Image> from output_raw_data [0 0] @halcanary: I'm skipping on ImageSrc for now. Leon's refactoring that quite a lot. This causes minor diffs for the GPU backend, given that we're now going through the YUV path. It also reduced peak RAM usage on my desktop from 1.26GB to 1.08GB. BUG=skia: Review URL: https://codereview.chromium.org/1010983004
* land some real hashtagsGravatar mtklein2015-03-25
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1029973003
* Add post upload hook to substitute hashtags for their mapped textGravatar rmistry2015-03-25
| | | | | | | BUG=skia:3586 NOTRY=true Review URL: https://codereview.chromium.org/1004733009
* SkPDF: eliminate skpdfpage classGravatar halcanary2015-03-25
| | | | | | BUG=skia:3585 Review URL: https://codereview.chromium.org/1007083004
* Fix android_run_skia script to allow for larger blacklistGravatar msarett2015-03-25
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1011653004
* SkPDF: merge skdocument_pdf and skpdfdocumentGravatar halcanary2015-03-25
| | | | | | BUG=skia:3585 Review URL: https://codereview.chromium.org/1034793002
* SKPDF: refactor pdfcatalog and pdfdocumentGravatar halcanary2015-03-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SkPDFCatalog: - remove first-page-specific code (no longer needed, never used) (e.g. addObject()). - Make use of SkHashMap for lookups (simplifies code). - inline all small methods - emitXrefTable moved to SkPDFDocument.cpp - no longer store offsets in this data structure (moved to SkPDFDocument.cpp) - setFileOffset gone. - own substitute refs directly. SkPDFDocument::EmitPDF() - All sites that call into SkPDFCatalog modified. - catalog.addObject only called in a single place, after the resouceSet is built - offsets moved to local array. SkPDFPage: - finalizePage no longer deals with SkPDFCatalog or resource sets. - GeneratePageTree no longer deals with SkPDFCatalog SkPDFObjRef - emitObject respects the substitution map Unit Tests: - respect SkPDFCatalog::addObject signature change. SkTHash: - #include SkChecksum for SkGoodHash - Copyright notice added Review URL: https://codereview.chromium.org/1033543002
* Add scanline decoding to SkCodec.Gravatar scroggo2015-03-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add an interface for decoding scanlines, and implement that interface in the PNG decoder. Use a separate method to determine whether an image that used a type with alpha was actually opaque. SkScanlineDecoder.h: New interface for decoding scanlines. SkCodec.h: Add getScanlineDecoder. Add a virtual function (with non-virtual caller) for determining whether the image truly had alpha. The client can call this to determine if the image was actually opaque if it reported having alpha. Remove code to sneakily change the passed in alpha type. SkCodec_libpng.*: Split up code onGetPixels into helper functions that can be shared with the scanline decoder. Implement scanline decoding. Implement onReallyHasAlpha. SkSwizzler.*: Add a new SrcConfig as a default, which is invalid. Add a function for setting fDstRow directly. Assert fDstRow is not NULL. BUG=skia:3257 Review URL: https://codereview.chromium.org/1010903003
* SkTHash: add checksum includeGravatar halcanary2015-03-25
| | | | Review URL: https://codereview.chromium.org/1030883006
* Add copyright headers to remaining gyp files.Gravatar scroggo2015-03-25
| | | | | | | | Prevents some PRESUBMIT errors. TBR=mtklein@google.com Review URL: https://codereview.chromium.org/1035523003
* Remove SkClipStack's manual rounding of BW clip rectsGravatar robertphillips2015-03-25
| | | | | | | | | | | | | | | The full fix for this bug is nudging the image in device space. That is going to be a large change. This CL should address the immediate problem. This CL will alter the following GMs: clipdrawdraw convex_poly_clip complexclip_bw_* filltypespersp complexclip3_simple BUG=423834 Review URL: https://codereview.chromium.org/1033453003
* SkPDF: skpdfdocument and skpdfpage use skpdfdevice in a const wayGravatar halcanary2015-03-25
| | | | | | BUG=skia:3585 Review URL: https://codereview.chromium.org/1035513003
* SkPDF: add canon assert before adding code that might break itGravatar halcanary2015-03-25
| | | | | | | | | | | Motivation: We can write subsets (by page) of pdf documents (but this in't yet exposed in the public API), but it is a bad idea to mix pages from multiple documents (de-duping will break). This assert verifies that we don't do this by accident in the future. BUG=skia:3585 Review URL: https://codereview.chromium.org/1037573005
* SkPDF: unclass skpdfdocumentGravatar halcanary2015-03-25
| | | | | | BUG=skia:3585 Review URL: https://codereview.chromium.org/1030193002
* More file types to check for (C).Gravatar mtklein2015-03-25
| | | | | | | | | | | | - objective C++ (31) - objective C (4) - C (2) - alternate C++ extension (1) - Go (1) BUG=skia: Review URL: https://codereview.chromium.org/1032143002
* Fix for ClipMaskManager drawSimpleRectGravatar joshualitt2015-03-25
| | | | | | BUG=chromium:466819 Review URL: https://codereview.chromium.org/1031143002
* Add copyright to gyp/codec.gyp.Gravatar scroggo2015-03-25
| | | | Review URL: https://codereview.chromium.org/1023673010
* SkPDF: clean up skpdfdocument, add static functionsGravatar halcanary2015-03-25
| | | | | | | | | | | | | Add SkPDFDocument::EmitPDF and SkPDFDocument::GetCountOfFontTypes Also, make SkPDFDocument::appendPage return void, not bool. Motivation: These static functions can be used to print subsets of a pdf document (functionality to be added in a later CL). BUG=skia:3585 Review URL: https://codereview.chromium.org/1036853002
* Add copyright headers DM.Gravatar scroggo2015-03-25
| | | | Review URL: https://codereview.chromium.org/1037713003
* Fixing memory leak in ico decoderGravatar msarett2015-03-25
| | | | | | | | | | BUG=skia: NOTREECHECKS=true TBR=scroggo@google.com NOTRY=true Review URL: https://codereview.chromium.org/1036873002
* Enabling ico decoding with use of png and bmp decodersGravatar msarett2015-03-25
| | | | | | | | BUG=skia:3257 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1011343003
* SkPDF refactor skpdfdocumentGravatar halcanary2015-03-25
| | | | | | | | | | | | | | | | | | | | | Most fields removed, made local to emitPDF function (since we never emit twice). Variables made into stack variables or auto-unrefed. we hold devices, not pages. addResourcesToCatalog inlined unused setPage function removed. deprecated getCountOfFontTypes function removed private functions removed BUG=skia:3585 Review URL: https://codereview.chromium.org/1034583002
* Add copyright check to PRESUBMITGravatar borenet2015-03-25
| | | | | | BUG=skia:1724 Review URL: https://codereview.chromium.org/1003363005
* SkChopCubicAt2 using Sk2s -- 2x fasterGravatar reed2015-03-24
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1036753002
* SkPDF: unit test cleanupGravatar halcanary2015-03-24
| | | | | | BUG=skia:3585 Review URL: https://codereview.chromium.org/1033833002
* Revert of pathops version two (patchset #16 id:150001 of ↵Gravatar reed2015-03-24
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1002693002/) Reason for revert: ASAN investigation Original issue's description: > pathops version two > > R=reed@google.com > > marked 'no commit' to attempt to get trybots to run > > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/ccec0f958ffc71a9986d236bc2eb335cb2111119 TBR=caryclark@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1029993002
* Revert of remove obsolete tests (patchset #1 id:1 of ↵Gravatar caryclark2015-03-24
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1030883002/) Reason for revert: working on asan fix Original issue's description: > remove obsolete tests > > remove tests that are breaking the build -- uninitialized memory > > TBR=reed > > Committed: https://skia.googlesource.com/skia/+/e02c944e97ad6a3b8befb1f4f784919767941ba6 TBR=reed@android.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1036633002
* Revert of fix destructor order to fix build (patchset #1 id:1 of ↵Gravatar caryclark2015-03-24
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1033703002/) Reason for revert: working on asan fix Original issue's description: > fix destructor order to fix build > > TBR=reed > > Committed: https://skia.googlesource.com/skia/+/c207f9b2e8d6fb5386197fa8a8d258d2c4603418 TBR=reed@android.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1033803002
* Revert of Enabling ico decoding with use of png and bmp decoders (patchset ↵Gravatar tomhudson2015-03-24
| | | | | | | | | | | | | | | | | | | | | | #10 id:280001 of https://codereview.chromium.org/1011343003/) Reason for revert: Reverting on suspicion of massive bot failures - possible command line too long? Original issue's description: > Enabling ico decoding with use of png and bmp decoders > > BUG=skia:3257 > > Committed: https://skia.googlesource.com/skia/+/15bfd075d38e4422a477e22940d06a137f66cc97 TBR=scroggo@google.com,reed@google.com,djsollen@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3257 Review URL: https://codereview.chromium.org/1022843005
* Switch DM to use utils/android/SkAndroidSDKCanvasGravatar tomhudson2015-03-24
| | | | | | | | | Use (better) paint filter shared with nanobench, instead of custom implementation. R=djsollen@google.com Review URL: https://codereview.chromium.org/1036523002
* Enabling ico decoding with use of png and bmp decodersGravatar msarett2015-03-24
| | | | | | BUG=skia:3257 Review URL: https://codereview.chromium.org/1011343003