aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Implement an SkPicture image filter source. This is required for the ↵Gravatar senorblanco@chromium.org2013-12-12
| | | | | | | | | | external-SVG reference feature of feImage. It simply plays back an SkPicture to a given destination rect. R=reed@google.com Review URL: https://codereview.chromium.org/114263002 git-svn-id: http://skia.googlecode.com/svn/trunk@12661 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move segment mask from SkPath to SkPathRefGravatar robertphillips@google.com2013-12-12
| | | | | | | | https://codereview.chromium.org/105083003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12660 2bbb7eff-a529-9590-31e7-b0007b416f81
* Perlin noise rebaselineGravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | | | | | BUG=skia:1881 Committed: https://code.google.com/p/skia/source/detail?r=5f145c9 R=sugoi@google.com, mtklein@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/99433007 git-svn-id: http://skia.googlecode.com/svn/trunk@12659 2bbb7eff-a529-9590-31e7-b0007b416f81
* be sure to unlock the discardablememory before deleting itGravatar reed@google.com2013-12-12
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/114673002 git-svn-id: http://skia.googlecode.com/svn/trunk@12658 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Implement an SkPicture image filter source. This is required for the ↵Gravatar senorblanco@chromium.org2013-12-12
| | | | | | | | external-SVG reference feature of feImage. It simply plays back an SkPicture to a given destination rect." This reverts commit a620349a24471546ad2e8f0679774c1f5b4de0a4 (r12656). git-svn-id: http://skia.googlecode.com/svn/trunk@12657 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement an SkPicture image filter source. This is required for the ↵Gravatar senorblanco@chromium.org2013-12-12
| | | | | | | | | | external-SVG reference feature of feImage. It simply plays back an SkPicture to a given destination rect. R=reed@google.com Review URL: https://codereview.chromium.org/114263002 git-svn-id: http://skia.googlecode.com/svn/trunk@12656 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fixed a displacement issueGravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | | | | The displacement filter was assuming that both inputs were of the same size, which is true in blink, but not necessarily in a compromised stream. BUG=327372 R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, fmalita@chromium.org, fmalita@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/101623007 git-svn-id: http://skia.googlecode.com/svn/trunk@12655 2bbb7eff-a529-9590-31e7-b0007b416f81
* detect if the scaledimagecache returns a purged bitmapGravatar reed@google.com2013-12-12
| | | | | | | | | BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/110383005 git-svn-id: http://skia.googlecode.com/svn/trunk@12654 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use DEFINE_TESTCLASS_SHORT macro in tests.Gravatar tfarina@chromium.org2013-12-12
| | | | | | | | | | | | | The three version of DEFINE_TESTCLASS macro is deprecated and thus just use the simple, short one. BUG=None TEST=out/Debug/tests R=mtklein@google.com, bsalomon@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/100113004 git-svn-id: http://skia.googlecode.com/svn/trunk@12653 2bbb7eff-a529-9590-31e7-b0007b416f81
* Bounds fixes for SkXfermodeImageFilter:Gravatar senorblanco@chromium.org2013-12-12
| | | | | | | | | | | | | | 1) Change the default bounds to the union of the foreground and background bounds. 2) Use a canvas translate instead of manually offsetting the foreground and background bounds by the union. 3) Apply the transfer mode to all pixels, including those outside the foreground rect by using a difference clip. Covered by the offset test cases in the xfermodeimagefilter GM (will need rebaselines). R=reed@google.com Review URL: https://codereview.chromium.org/112683004 git-svn-id: http://skia.googlecode.com/svn/trunk@12652 2bbb7eff-a529-9590-31e7-b0007b416f81
* Try another GYP DEPSGravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | | | | This one is just before the introduction of the Python 2.7 requirement. BUG= R=rmistry@google.com, robertphillips@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/99583004 git-svn-id: http://skia.googlecode.com/svn/trunk@12651 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert r12648Gravatar borenet@google.com2013-12-12
| | | | | | Review URL: https://codereview.chromium.org/114453002 git-svn-id: http://skia.googlecode.com/svn/trunk@12650 2bbb7eff-a529-9590-31e7-b0007b416f81
* Preventing division by 0Gravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | | | | | | I did bench tests and I can't compute the denom before the if condition without taking a hit. After a few quick tests on my linux desktop, computing the 1st denom costs 6ms, the 2nd one 5ms and both together cost 9ms. The reason for this is that both if conditions here are exceptions and are expected to be false, so the denom computation should be skipped, if possible. The bench test I ran was : out/Release/bench --match Xfermode_Hue --config 8888 --minMs 1000 BUG= R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, sugoi@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/114173002 git-svn-id: http://skia.googlecode.com/svn/trunk@12649 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update GYP DEPS to obtain VS 2013 supportGravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | R=rmistry@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/103893006 git-svn-id: http://skia.googlecode.com/svn/trunk@12648 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/112783004/Gravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | | | | | | Reason for revert: Failing assert on Android R=scroggo@google.com, halcanary@google.com, reed@google.com, rmistry@google.com TBR=halcanary@google.com, reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true Author: robertphillips@google.com Review URL: https://codereview.chromium.org/93673005 git-svn-id: http://skia.googlecode.com/svn/trunk@12646 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM: stroke-fill results for pdf-popplerGravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | | | | | | (some stragglers that snuck in overnight while pdf-poppler was still ignored) NOTRY=True NOTREECHECKS=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/103383003 git-svn-id: http://skia.googlecode.com/svn/trunk@12644 2bbb7eff-a529-9590-31e7-b0007b416f81
* GM: stop ignoring pdf-poppler failuresGravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | | | BUG=skia:1657 NOTRY=True R=vandebo@chromium.org Author: epoger@google.com Review URL: https://codereview.chromium.org/108813007 git-svn-id: http://skia.googlecode.com/svn/trunk@12643 2bbb7eff-a529-9590-31e7-b0007b416f81
* ensure that we call onUnlock only when we onLock succeededGravatar reed@google.com2013-12-12
| | | | | | | | | BUG= R=halcanary@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/112783004 git-svn-id: http://skia.googlecode.com/svn/trunk@12642 2bbb7eff-a529-9590-31e7-b0007b416f81
* Initialize SkPixelRef::fInfo.Gravatar scroggo@google.com2013-12-12
| | | | | | | | | | | Still will need to make subclasses call the version of the constructor that initializes fInfo properly. R=reed@google.com Review URL: https://codereview.chromium.org/110843006 git-svn-id: http://skia.googlecode.com/svn/trunk@12639 2bbb7eff-a529-9590-31e7-b0007b416f81
* The default size of mask canvas is not appropriate. its height is too small: ↵Gravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | | | 150, while its width is 300. As a result, for non-alphaMask canvas who doesn't update the mask canvas size, this tool just magnify the upper part of 'Expected Image' as well as 'Actual Image' when user open view.html to show skpdiff_output.json in browser for many cases. The other part can't be shown because it is out of the mask canvas. This CL update non-alphaMask canvas size according to baseline canvas for each case, then the tool can magnify anywhere you want for the whole image when you click and move mouse on the mask canvas. R=djsollen@google.com Author: yunchao.he@intel.com Review URL: https://codereview.chromium.org/105823010 git-svn-id: http://skia.googlecode.com/svn/trunk@12638 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reverting r12635 (Make leak counters thread-safe - ↵Gravatar robertphillips@google.com2013-12-12
| | | | | | https://codereview.chromium.org/99483003) due to compile errors on Mac 10.6 & in Chrome git-svn-id: http://skia.googlecode.com/svn/trunk@12637 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make leak counters thread-safe and turn them on by default for DebugGravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | | | | | | | | | | | | | | | Make leak counters implemented with SK_DECLARE_INST_COUNT thread-safe. Enable the leak counting for Debug builds. Protect the instance counter initialization step (initStep) by using SkOnce. Makes SkOnce.h part of the public API, since SkInstCnt is public. Protect the per-class child list shared variable with a per-class mutex. Changes the behavior in the way that if the child list has been "cleaned up", it will still try to create subsequent child lists. BUG=skia:1219 R=robertphillips@google.com, mtklein@google.com, bungeman@gmail.com, bsalomon@google.com, bungeman@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/99483003 git-svn-id: http://skia.googlecode.com/svn/trunk@12635 2bbb7eff-a529-9590-31e7-b0007b416f81
* Whitespace change to test commit queue.Gravatar commit-bot@chromium.org2013-12-12
| | | | | | | | | | | | | (SkipBuildbotRuns) BUG= TBR=borenet@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/94103005 git-svn-id: http://skia.googlecode.com/svn/trunk@12634 2bbb7eff-a529-9590-31e7-b0007b416f81
* [PDF] Fix font width generation when glyph 0 is used.Gravatar commit-bot@chromium.org2013-12-11
| | | | | | | | | | | | | Using glyph 0 caused gid 0 to be in the subset list twice, which violated an assumption in the code. Added an assert for the assumption and updated the code to not insert gid 0 into the subset list twice. BUG=skia:1889 R=bungeman@google.com Author: vandebo@chromium.org Review URL: https://codereview.chromium.org/113093004 git-svn-id: http://skia.googlecode.com/svn/trunk@12632 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "remvoe duplicate impl for SkImageInfo flattening"Gravatar reed@google.com2013-12-11
| | | | | | | | | | | | Reason: breaks chrome_mac_tests which still have non-imageinfo constructors This reverts commit a06b8cf60b39bda93e9ef1a73579007b2b930d29. BUG= Review URL: https://codereview.chromium.org/103033005 git-svn-id: http://skia.googlecode.com/svn/trunk@12631 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "Revert of https://codereview.chromium.org/108773003/"Gravatar reed@google.com2013-12-11
| | | | | | | | | | This reverts commit 947e6a3142af66b750f1247ef933b11ed8455dd4. BUG= Review URL: https://codereview.chromium.org/112963003 git-svn-id: http://skia.googlecode.com/svn/trunk@12630 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/108773003/Gravatar commit-bot@chromium.org2013-12-11
| | | | | | | | | | | | | | Reason for revert: breaks chrome-mac-tests TBR= NOTREECHECKS=true NOTRY=true Author: reed@google.com Review URL: https://codereview.chromium.org/113193003 git-svn-id: http://skia.googlecode.com/svn/trunk@12629 2bbb7eff-a529-9590-31e7-b0007b416f81
* Tiny, urgent fix for rebaseline_server to accept new baselines.Gravatar commit-bot@chromium.org2013-12-11
| | | | | | | | | | | | | | | (SkipBuildbotRuns) R=jcgregorio@google.com TBR=jcgregorio NOTREECHECKS=True NOTRY=True BUG= Author: epoger@google.com Review URL: https://codereview.chromium.org/99763007 git-svn-id: http://skia.googlecode.com/svn/trunk@12628 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update stroke-fill_pdf-native.png after r12625Gravatar vandebo@chromium.org2013-12-11
| | | | | | | | TBR=bungeman@google.com Review URL: https://codereview.chromium.org/102443006 git-svn-id: http://skia.googlecode.com/svn/trunk@12627 2bbb7eff-a529-9590-31e7-b0007b416f81
* remaining GM baselines for pdf-popplerGravatar commit-bot@chromium.org2013-12-11
| | | | | | | | | | | | | | | R=vandebo@chromium.org TBR=vandebo BUG= (SkipBuildbotRuns) NOTRY=True NOTREECHECKS=True Author: epoger@google.com Review URL: https://codereview.chromium.org/112973004 git-svn-id: http://skia.googlecode.com/svn/trunk@12626 2bbb7eff-a529-9590-31e7-b0007b416f81
* [PDF] Fix bug in ToUnicode table generation for Type 3 fonts.Gravatar commit-bot@chromium.org2013-12-11
| | | | | | | | | | | | | | True glyphIDs where being using in the Type3 ToUnicode table instead of IDs of 1-255. This causes poppler to complain about each entry. BUG:skia:1565 R=bungeman@google.com Author: vandebo@chromium.org Review URL: https://codereview.chromium.org/112053005 git-svn-id: http://skia.googlecode.com/svn/trunk@12625 2bbb7eff-a529-9590-31e7-b0007b416f81
* remvoe duplicate impl for SkImageInfo flatteningGravatar reed@google.com2013-12-11
| | | | | | | | | | | | Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""""" This reverts commit eabd6b2ed4e494b323c08f32358f45950a0368c3. BUG= Review URL: https://codereview.chromium.org/108773003 git-svn-id: http://skia.googlecode.com/svn/trunk@12624 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "PixelRef now returns (nearly) everything that is currently in ↵Gravatar reed@google.com2013-12-11
| | | | | | | | | | | | SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""""" This reverts commit d08eca87a0bef10112a211de540f89656a80b86a. BUG= Review URL: https://codereview.chromium.org/108303003 git-svn-id: http://skia.googlecode.com/svn/trunk@12623 2bbb7eff-a529-9590-31e7-b0007b416f81
* PixelRef now returns (nearly) everything that is currently in SkBitmap. The ↵Gravatar reed@google.com2013-12-11
| | | | | | | | | | goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""" BUG= Review URL: https://codereview.chromium.org/110503003 git-svn-id: http://skia.googlecode.com/svn/trunk@12622 2bbb7eff-a529-9590-31e7-b0007b416f81
* Added canvas.fillStyle with support for just the "#RRGGBB" style of colors.Gravatar commit-bot@chromium.org2013-12-11
| | | | | | | | | | | | | Also renamed drawRect to fillRect, which now take x,y,w,h parameters. BUG= R=robertphillips@google.com Author: jcgregorio@google.com Review URL: https://codereview.chromium.org/108813004 git-svn-id: http://skia.googlecode.com/svn/trunk@12621 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix SampleApp bounding box hierarchy shortcut collision.Gravatar commit-bot@chromium.org2013-12-11
| | | | | | | | | | | | | | | 'b' is currently bound to the AA toggle, AND to the bounding box hierachy toggle. The CL switches BBH to 'B', and fixes a deferred title update issue. R=reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/112903002 git-svn-id: http://skia.googlecode.com/svn/trunk@12620 2bbb7eff-a529-9590-31e7-b0007b416f81
* be more careful about OOB source pixels in the scanline rescaler, andGravatar commit-bot@chromium.org2013-12-11
| | | | | | | | | | | | | less certain about why the standalone scaler might have faileds BUG= R=reed@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/100473011 git-svn-id: http://skia.googlecode.com/svn/trunk@12619 2bbb7eff-a529-9590-31e7-b0007b416f81
* add more tests for discardable cachesGravatar reed@google.com2013-12-11
| | | | | | | | | BUG= R=halcanary@google.com Review URL: https://codereview.chromium.org/112833003 git-svn-id: http://skia.googlecode.com/svn/trunk@12618 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-12-11
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12617 2bbb7eff-a529-9590-31e7-b0007b416f81
* Avoid heap allocation in SkPictureStateTree constructorGravatar commit-bot@chromium.org2013-12-10
| | | | | | | | | | | | | This makes empty state trees cheaper. ~1% improvement on rasterize_and_record_micro.key_silk_cases on Android. BUG=1772 R=tomhudson@chromium.org, tomhudson@google.com Author: skyostil@chromium.org Review URL: https://codereview.chromium.org/111573002 git-svn-id: http://skia.googlecode.com/svn/trunk@12616 2bbb7eff-a529-9590-31e7-b0007b416f81
* More signed/unsigned comparison warnings.Gravatar fmalita@google.com2013-12-10
| | | | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/100103006 git-svn-id: http://skia.googlecode.com/svn/trunk@12615 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix warning after bbe43a9ce051.Gravatar fmalita@google.com2013-12-10
| | | | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/108973006 git-svn-id: http://skia.googlecode.com/svn/trunk@12614 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add SkTileGridPicture SampleApp playback support.Gravatar commit-bot@chromium.org2013-12-10
| | | | | | | | | | | | | SampleApp already supports switching to a bbox hierarchy playback mode ('b' shortcut). This CL adds an SkTileGridPicture bbox mode. R=reed@google.com, robertphillips@google.com, fmalita@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/108513006 git-svn-id: http://skia.googlecode.com/svn/trunk@12613 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sk_API for SkImageGenerator and SkInstallDiscardablePixelRefGravatar halcanary@google.com2013-12-10
| | | | | | | | | | | | | | | | | | | | Added SK_API to SkImageGenerator (already in include/). Moved SkDiscardablePixelRef::Install to SkInstallDiscardablePixelRef, added SK_API to that function, and moved declaration to SkImageGenerator.h This keeps the SkDiscardablePixelRef internal to Skia, but exposes a method to install it into a bitmap. Modifed tests that rely on this functio to use new version. BUG= R=mtklein@google.com, reed@google.com Review URL: https://codereview.chromium.org/111713002 git-svn-id: http://skia.googlecode.com/svn/trunk@12612 2bbb7eff-a529-9590-31e7-b0007b416f81
* Support MSAA4 and (non-ES) OpenGL in Android SampleAppGravatar commit-bot@chromium.org2013-12-10
| | | | | | | | | | | | | | Add a menu item to set the OpenGL context type that SampleApp uses on Android. The submenu of the new item will present options to create OpenGL ES or OpenGL, aliased or multisampled. R=djsollen@google.com, bsalomon@google.com Author: kkinnunen@nvidia.com Review URL: https://codereview.chromium.org/60273006 git-svn-id: http://skia.googlecode.com/svn/trunk@12610 2bbb7eff-a529-9590-31e7-b0007b416f81
* Implement SkAshmemDiscardableMemoryGravatar halcanary@google.com2013-12-10
| | | | | | | | | | | | | | | | | | | | | | | | | | - Implement ashmem-backed SkDiscardableMemory subclass: This class in only accesible via the SkDiscardableMemory::Create() function, which replaces the mock implementation in SkDiscardableMemory_none.cpp - Added SkDiscardableMemory_ashmem.cpp to the Android port of Skia Removed SkDiscardableMemory_none.cpp from the Android port. - Added DiscardableMemoryTest. Still needs work. - SkDiscardablePixelRef Bugfix: onLockPixels() now calls SkDELETE on the SkDiscardableMemory pointer when it fails to unlock. - Improved documentation inside ashmem.h BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/83563002 git-svn-id: http://skia.googlecode.com/svn/trunk@12608 2bbb7eff-a529-9590-31e7-b0007b416f81
* improve bitmap font support (FreeType only)Gravatar bungeman@google.com2013-12-10
| | | | | | | | | | | | | | | This commit improves SkFontHost_FreeType's support for bitmap fonts, adding a number of features: - Intelligent bitmap strike selection. - Inter-strike bitmap font scaling. - Colour bitmap font support (FreeType 2.5.0+). BUG= R=reed@google.com Review URL: https://codereview.chromium.org/23684041 git-svn-id: http://skia.googlecode.com/svn/trunk@12607 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/111853003/Gravatar commit-bot@chromium.org2013-12-10
| | | | | | | | | | | | | | | Reason for revert: Was not the culprit. R=bungeman@google.com, reed@google.com TBR=bungeman@google.com, reed@google.com NOTREECHECKS=true NOTRY=true Author: mtklein@google.com Review URL: https://codereview.chromium.org/102243009 git-svn-id: http://skia.googlecode.com/svn/trunk@12606 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert "[PDF] Fix font embedding restrictions."Gravatar vandebo@chromium.org2013-12-10
| | | | | | | | This reverts r12600 and r12601, likely causing crash on Mac. Review URL: https://codereview.chromium.org/111893002 git-svn-id: http://skia.googlecode.com/svn/trunk@12604 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/109033002/Gravatar commit-bot@chromium.org2013-12-10
| | | | | | | | | | | | | | | Reason for revert: I suspect this is causing GM to crash on Mac. R=bungeman@google.com, reed@google.com TBR=bungeman@google.com, reed@google.com NOTREECHECKS=true NOTRY=true Author: mtklein@google.com Review URL: https://codereview.chromium.org/111853003 git-svn-id: http://skia.googlecode.com/svn/trunk@12603 2bbb7eff-a529-9590-31e7-b0007b416f81