aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* SkPDF: Refactor SkPDFObject heiararchy.Gravatar halcanary2015-04-25
| | | | | | | | | | | Flatten and use a tagged union type Δmemory ~= -2.4% ± 0.5% Δtime ~= -1.2% ± 0.2% BUG=skia:3585 Review URL: https://codereview.chromium.org/1069103003
* fix for GrBatchAtlas valgrind errorGravatar joshualitt2015-04-24
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1056383005
* sync-and-gyp script: fix to work in MSYS shellGravatar halcanary2015-04-24
| | | | | | | NOTRY=true TBR=scroggo@google.com Review URL: https://codereview.chromium.org/1104613003
* Update {virtual,override} to follow C++11 style in src/fonts.Gravatar tfarina2015-04-24
| | | | | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. The entries were found using the following command line: $ find src/fonts -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M "[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]" The regex was a courtesy of nick@chromium.org BUG=None R=mtklein@google.com Review URL: https://codereview.chromium.org/1101343002
* Update {virtual,override} to follow C++11 style in src/pipe.Gravatar tfarina2015-04-24
| | | | | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. The entries were found using the following command line: $ find src/pipe -iname "*.h" -or -iname "*.cpp" | xargs pcregrep -M "[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]" The regex was a courtesy of nick@chromium.org BUG=None R=mtklein@google.com Review URL: https://codereview.chromium.org/1104863003
* Do not crash nanobench in debug modeGravatar msarett2015-04-24
| | | | | | | | Instead print an error message BUG=skia: Review URL: https://codereview.chromium.org/1102083002
* Fix some lingering typosGravatar robertphillips2015-04-24
| | | | Review URL: https://codereview.chromium.org/1101293003
* Revert of Remove validation exceptions in GrGLInterface. These are all now ↵Gravatar bsalomon2015-04-24
| | | | | | | | | | | | | | | | | | | set by Chromium. (patchset #1 id:1 of https://codereview.chromium.org/1100413003/) Reason for revert: Crashing bots Original issue's description: > Remove validation exceptions in GrGLInterface. These are all now set by Chromium. > > Committed: https://skia.googlesource.com/skia/+/42d9f35a8daf7f24ba542ba3783ec46fd965ef2f TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1093323005
* simple fix for preabandon valgrind errorGravatar joshualitt2015-04-24
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1106663003
* fix multiple intersection logicGravatar caryclark2015-04-24
| | | | | | | | | | | When three or more curves intersect at the same point, ensure that each curve records the intersections of the others. This fixes a number of cubic tests. TBR=reed@google.com BUG=skia:3588 Review URL: https://codereview.chromium.org/1105943002
* fix for using too much memory in GrBatchAtlasGravatar joshualitt2015-04-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1105913002
* Remove validation exceptions in GrGLInterface. These are all now set by ↵Gravatar bsalomon2015-04-24
| | | | | | Chromium. Review URL: https://codereview.chromium.org/1100413003
* Add ability to specify extra browser args and a prefix for SKP names to ↵Gravatar rmistry2015-04-23
| | | | | | | | | webpages_playback.py BUG=skia:3763 NOTRY=true Review URL: https://codereview.chromium.org/1066933006
* Blacklist desk_unicodetable SKP on Nexus PlayerGravatar borenet2015-04-23
| | | | | | | | It's getting us killed for OOM. BUG=skia:3240 Review URL: https://codereview.chromium.org/1104693002
* Remove validation of blend barrier until Chrome can provide this functionGravatar bsalomon2015-04-23
| | | | | | | BUG=chromium:480534 TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/1101143002
* add GM to show bad banding in raster for radial gradientsGravatar reed2015-04-23
| | | | | | | BUG=427508 TBR= Review URL: https://codereview.chromium.org/1061753009
* Add onGetBlendInfo to GrXferProcessorGravatar cdalton2015-04-23
| | | | | | | | | | | | | | Adds an onGetBlendInfo method for GrXferProcessor subclasses to override instead of overriding getBlendInfo directly. This gives the base class a chance to initialize the struct with default values before passing it on. As the BlendInfo struct grows, this will keep things simple and less error prone. BUG=skia: NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1049143002
* working on initial winding for cubicsGravatar caryclark2015-04-23
| | | | | | | | | | | Path ops works well for all tests except for cubics. Isolate failures caused by cubics, and do a better job of computing the initial winding for cubics. TBR=reed@google.com BUG=skia:3588 Review URL: https://codereview.chromium.org/1096923003
* Ensure that we create a NULL codec for images with zero dimensionsGravatar msarett2015-04-23
| | | | | | | BUG=skia:3534 BUG=skia:3257 Review URL: https://codereview.chromium.org/1091043003
* small fix for perf regression in GrAtlasTextContext.cppGravatar joshualitt2015-04-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1080673005
* use acquire/release in SkEventTracer.cppGravatar mtklein2015-04-22
| | | | | | BUG=chromium:437044 Review URL: https://codereview.chromium.org/1091283006
* Remove unnecessary viewmatrix compare in GrAtlasTextContextGravatar joshualitt2015-04-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1088903009
* new GM to test clipping cubicsGravatar reed2015-04-22
| | | | | | | BUG=skia:3716 TBR=caryclark@google.com Review URL: https://codereview.chromium.org/1096433009
* [SkPDFDevice] Enable pathops-based inverse fillsGravatar fmalita2015-04-22
| | | | | | | | | Keeping the old compile guard for clipping only. BUG=skia:3749 R=halcanary@google.com,caryclark@google.com,reed@google.com Review URL: https://codereview.chromium.org/1099953002
* Remove MSAA check from Ganesh veto (dashed paths are no longer slow).Gravatar senorblanco2015-04-22
| | | | | | | R=egdaniel@google.com BUG=skia: Review URL: https://codereview.chromium.org/1098753004
* Move function to be static instead of anonymous namespaceGravatar egdaniel2015-04-22
| | | | | | | | TBR=bsalomon@google.com, jvanverth@google.com BUG=skia: Review URL: https://codereview.chromium.org/1057363004
* Fix for segfault on destruction of BitmapTextBlobGravatar joshualitt2015-04-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1065773005
* Improve the curve tessellation subdivision of the path renderers.Gravatar senorblanco2015-04-22
| | | | | | | | | | | | | | | | | | | The stencil-and-cover and tessellating path renderers currently tessellate curves to linear segments to within one screen space pixel. This is fairly poor accuracy, as can be seen from the strokecircle GM: there are noticeable rotating bumps on the circles. Improving the tolerance to 0.25 pixel eliminates the bumps, and approximates the 16x supersampling of the raster path. This does have a performance hit: 3-6% on desktop on the IE chalkboard demo, ~1% on Nexus 7 2013. Note: this will require rebaselining a number of GPU and MSAA images in Skia, but nothing in Chrome (yet). BUG=skia:3731 Review URL: https://codereview.chromium.org/1072273007
* Refactor createTexture and onCreateTextureGravatar egdaniel2015-04-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1102663002
* Revert of enable TextBlob / Batch (patchset #1 id:1 of ↵Gravatar joshualitt2015-04-22
| | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1077813004/) Reason for revert: seg fault Original issue's description: > enable TextBlob / Batch > > TBR=bsalomon@google.com > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b75f8100ace48e74319ccf43d82deaac446784b2 TBR=bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1096433007
* Make pixel_snap GMs incur less platform-specific variationGravatar bsalomon2015-04-22
| | | | Review URL: https://codereview.chromium.org/1080393009
* Fix for GrAtlasTextContext memory leakGravatar joshualitt2015-04-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1072193009
* Rewrite and move Cluster Telemetry documentation to skia.orgGravatar rmistry2015-04-22
| | | | | | | | BUG=skia:3754 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1074943003 Review URL: https://codereview.chromium.org/1074943003
* Add tokens and entry points for KHR_blend_equation_advancedGravatar cdalton2015-04-22
| | | | | | | | | | Also adds glBlendEquation, which the extension interacts with, to the core of GrGLInterface. Validation of this function is temporarily disabled until Chrome hooks it up. BUG=skia: Review URL: https://codereview.chromium.org/1039693004
* Add GM to test non-AA pixel snapping for points, lines, rects.Gravatar bsalomon2015-04-22
| | | | Review URL: https://codereview.chromium.org/1070213003
* enable TextBlob / BatchGravatar joshualitt2015-04-22
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1077813004
* O(1) SkPictureUtils::ApproxBytesUsed()Gravatar mtklein2015-04-21
| | | | | | | | | | Chrome wants to call this more often, and it's quite slow today. Seems like this could be clearer if SkPictureUtils::ApproxBytesUsed() were SkPicture::approxBytesUsed(). BUG=chromium:471873 Review URL: https://codereview.chromium.org/1090943004
* Default to arm_v7_neon.Gravatar mtklein2015-04-21
| | | | | | | | This aliases all devices we know have NEON over to that too. BUG=skia: Review URL: https://codereview.chromium.org/1095953007
* Revert of Add tokens and entry points for KHR_blend_equation_advanced ↵Gravatar tomhudson2015-04-21
| | | | | | | | | | | | | | | | | | | | | | | | (patchset #3 id:40001 of https://codereview.chromium.org/1039693004/) Reason for revert: We're getting repeated crashes since this CL landed when we try to evaluate a roll into Chrome on our bots. (https://uberchromegw.corp.google.com/i/client.skia/builders/Linux%20Tests/builds/1902) Our initial reflex is to put a #if 0 around this code (just like the immediately following lines 334-338 in GrGLInterface.cpp), but the error isn't what the GPU team expected to see if that was all we needed, so we're reverting now and asking you to resubmit tomorrow after running more thorough tests. Original issue's description: > Add tokens and entry points for KHR_blend_equation_advanced > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/8e578859f80b46a63144add215955221017d3609 TBR=markkilgard@gmail.com,bsalomon@google.com,cdalton@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1101593002
* fix some small bugs with GrAtlasTextContextGravatar joshualitt2015-04-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1098093003
* Add tokens and entry points for KHR_blend_equation_advancedGravatar cdalton2015-04-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1039693004
* Android's Clang toolchain can't assemble the JPEG's .S files.Gravatar mtklein2015-04-21
| | | | | | | | Only affecting Build-Mac10.8-Clang-Arm7-Debug-Android. BUG=skia: Review URL: https://codereview.chromium.org/1093423003
* Import glTextureBarrierGravatar cdalton2015-04-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1090163002
* Skip msaa4 on Tegra 2 and 3.Gravatar mtklein2015-04-21
| | | | | | | | | | This will fix the N7 and Xoom bots. TBR=borenet@google.com BUG=skia: Review URL: https://codereview.chromium.org/1099943002
* Revert "One more ASAN fix."Gravatar senorblanco2015-04-21
| | | | | | | | | | | | This reverts commit 409fd66a5afcef5f165f7ccec7c3473add231752. We don't expect to pass this test until the ASAN bots are correctly configured, and can run GPU tests. BUG=skia: TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1080393003
* DM: failure to canary a sink is now fatal.Gravatar mtklein2015-04-21
| | | | | | | | | | | This requires we remove NVPR from the default set of configs, as we only find out at runtime that it's not available. All the other defaults will either be compiled in and supported, or not compiled in and non-fatally skipped as unknown configs. BUG=skia: Review URL: https://codereview.chromium.org/1100773003
* Ask for NVPR only when we expect it to be available.Gravatar mtklein2015-04-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1099023003
* typo in sherrifing docsGravatar Greg Humphreys2015-04-21
| | | | | | | | BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1097353002 Review URL: https://codereview.chromium.org/1097353002
* Support HWUI rename of DisplayListRendererGravatar tomhudson2015-04-21
| | | | | | R=djsollen@google.com,ccraik@google.com Review URL: https://codereview.chromium.org/1086083004
* Some simple optimizations for improving GrAtlasTextContext perfGravatar joshualitt2015-04-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1093083003