aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Fix expectations for GN bot.Gravatar jcgregorio2016-07-28
| | | | | | BUG=skia: Review-Url: https://codereview.chromium.org/2191933002
* Remove unused render target members from GL and VK sk_app::WindowContext classesGravatar bsalomon2016-07-28
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191673002 Review-Url: https://codereview.chromium.org/2191673002
* Include NVPR configs in dm runs on TegraX1Gravatar csmartdalton2016-07-28
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2174353008 Review-Url: https://codereview.chromium.org/2174353008
* GN: add abbreviated versions of the command line as descriptions.Gravatar mtklein2016-07-28
| | | | | | | | | | | | | This should help make the bot logs a little easier to read. (On the console this wasn't much of a big deal, as Ninja auto-abbreviates when printing to an interactive console.) As usual, Ninja will print the full command when a task fails. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188263002 Review-Url: https://codereview.chromium.org/2188263002
* Add HardStopGradientBench_ScaleNumHardStops.cppGravatar fmenozzi2016-07-28
| | | | | | | | | Rename HardStopGradientBench.cpp to HardStopGradientBench_ScaleNumColors.cpp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2178913003 Review-Url: https://codereview.chromium.org/2178913003
* Add swarmbucket_wrapper recipeGravatar borenet2016-07-28
| | | | | | | | BUG=skia:5581 NOTRY=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185203003 Review-Url: https://codereview.chromium.org/2185203003
* Add writeToMemory() API to SkColorSpaceGravatar msarett2016-07-28
| | | | | | | | | | | | | | | | | New API mirrors the form of similar APIs in SkRegion, SkMatrix, etc. This also fixes a bug: SkImageInfo appears in a object that Chrome stores in discardable memory. So when sk_sp<SkColorSpace> was added to SkImageInfo a leak was introduced. We'll use this new method and deserialize to store the SkColorSpace in the discardable object. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2192903002 Review-Url: https://codereview.chromium.org/2192903002
* GN: fix mac build againGravatar mtklein2016-07-28
| | | | | | | | | | | | | Hoping to land these using the other GN bots as trybots. Don't know what magic was letting us get to webp's headers yesterday on Linux. Might have been using /usr/include's ? The other change is the difference between some setups using #define SK_BUILD_FOR_MAC and others #define SK_BUILD_FOR_MAC 1. We want either to mean "we're Mac". BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190713004 Review-Url: https://codereview.chromium.org/2190713004
* SkPaint intercept API for SkTextBlob and horizontal textGravatar fmalita2016-07-28
| | | | | | | | | | | | Add getPosTextHIntercepts(), getTextBlobIntercepts(). Consolidate the implementation in GetTextIntercepts<> template. BUG=chormium:581456 R=caryclark@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186663004 Review-Url: https://codereview.chromium.org/2186663004
* Make both SK_API definition points identical and order independent.Gravatar mtklein2016-07-28
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189983002 Review-Url: https://codereview.chromium.org/2189983002
* recipes: Add a GN flavor.Gravatar jcgregorio2016-07-28
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189713003 Review-Url: https://codereview.chromium.org/2189713003
* Add SkGammaColorFilterGravatar robertphillips2016-07-28
| | | | | | | | WDYT about this as a means of replacing GrContext::applyGamma with a normal SkCanvas::drawImage? GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190573002 Review-Url: https://codereview.chromium.org/2190573002
* Fixes for SwarmBucket botGravatar borenet2016-07-28
| | | | | | | | | | | - Print all build properties for debugging purposes. - Use correct path root for swarmbucket. - Write a dummy .gclient file if missing. BUG=skia:5581 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190933002 Review-Url: https://codereview.chromium.org/2190933002
* Added API for Bevel NormalSource.Gravatar dvonbeck2016-07-28
| | | | | | | | | | | This CL adds an API for Bevel normal source and a dummy implementation that returns a normal (0, 0, 1) every time. This CL's base is the CL for accepting nullptrs: https://codereview.chromium.org/2132113002 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2080993002 Review-Url: https://codereview.chromium.org/2080993002
* Remove unused sk_app::WindowContext::presentRenderSurfaceGravatar bsalomon2016-07-28
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184273002 Review-Url: https://codereview.chromium.org/2184273002
* Don't call finish on GrDrawTarget if we drew no batchesGravatar egdaniel2016-07-28
| | | | | | | | | | | This might give us some minor perf gains in vulkan since we won't be submitting command buffers that we've added to batch draws to. Running nanobench this does seem to happen pretty often. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179903008 Review-Url: https://codereview.chromium.org/2179903008
* Revert of align cap hairline first point (patchset #2 id:20001 of ↵Gravatar tomhudson2016-07-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2189583003/ ) Reason for revert: Speculative revert in case this is blocking our roll. Original issue's description: > align cap hairline first point > > Hairlines with square caps move the endpoints out by 1/2 pixel. > The last point needs to be the first adjusted point, instead > of the point supplied to move to. > > R=fmalita@chromium.org > TBR=reed@google.com > BUG=617658 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003 > > Committed: https://skia.googlesource.com/skia/+/52f85d4d09b815fce6bfe296a1dd2cbf8d792f05 TBR=fmalita@chromium.org,reed@google.com,caryclark@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617658 Review-Url: https://codereview.chromium.org/2188483007
* Turn on flags to enforce SK_API.Gravatar mtklein2016-07-27
| | | | | | | | | | | | | | | | These flags hide symbols that are not marked with SK_API when linked into a shared library. There's nominally no effect on static linking, but I'm pretty sure the Mac linker takes some advantage of this too to run faster. This makes component-build DM no longer link: it uses many non SK_API APIs. Fiddle in contrast is just fine with our public APIs, so no need to restrict that. It'll be fun finding out which of our other tools go which ways. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2180383003 Review-Url: https://codereview.chromium.org/2180383003
* SkPdf: SkPDFFormXObject de-class-ified.Gravatar halcanary2016-07-27
| | | | | | | | | | | | | | We don't need an object, just a few standard fields on the base class; the change lets us get rid of a bunch of boilerplate code. I think this also reduces the cognitive load of the SkPDF internals. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185803003 Review-Url: https://codereview.chromium.org/2185803003
* upload_bench_results - fix GS upload path.Gravatar jcgregorio2016-07-27
| | | | | | | | | | _UploadJSONResults does '/'.join() so the trailing / is unnecessary. BUG=skia: R=borenet GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187903003 Review-Url: https://codereview.chromium.org/2187903003
* Enable backend switching for Windows ViewerGravatar jvanverth2016-07-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184163003 Review-Url: https://codereview.chromium.org/2184163003
* SkPDF: refactor font subset: fewer copiesGravatar halcanary2016-07-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190643002 Review-Url: https://codereview.chromium.org/2190643002
* Fix silently-failing compileGravatar borenet2016-07-27
| | | | | | | | | | Ouch... TBR=rmistry BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191663002 Review-Url: https://codereview.chromium.org/2191663002
* GN: dmGravatar mtklein2016-07-27
| | | | | | | | | | | | | | | | This builds, links, and runs on Linux. Have not tried Mac. I've tested is_debug={true,false} and is_component_build. It's neat that the component build DM works, but it's also an indication I've missed an essential flag or two... it shouldn't work. :) The GPU backend isn't working yet, but all the software configurations I've tried look good. This fleshes out all the other parts of SkCodec too... I noticed we weren't able to decode gifs or webp. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188643002 Review-Url: https://codereview.chromium.org/2188643002
* Expose more gamma info for UMA statisticsGravatar msarett2016-07-27
| | | | | | | | TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188633003 Review-Url: https://codereview.chromium.org/2188633003
* Fix GrDrawContextPriv::stencilRectGravatar csmartdalton2016-07-27
| | | | | | | | | | | | | Updates stencilRect to call drawNonAAFilledRect instead of drawFilledRect. drawFilledRect can use coverage AA, which isn't appropriate for stencil draws. Also modifies drawNonAAFilledRect to take a "useHWAA" argument instead of trying to deduce whether it should be used. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187583002 Review-Url: https://codereview.chromium.org/2187583002
* Add Vulkan runtime dllGravatar kjlubick2016-07-27
| | | | | | | | | This gets copied into the out/ dir on compile and allows dm.exe to run anywhere, even if the Vulkan SDK is not installed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188543002 Review-Url: https://codereview.chromium.org/2188543002
* align cap hairline first pointGravatar caryclark2016-07-27
| | | | | | | | | | | | | Hairlines with square caps move the endpoints out by 1/2 pixel. The last point needs to be the first adjusted point, instead of the point supplied to move to. R=fmalita@chromium.org TBR=reed@google.com BUG=617658 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003 Review-Url: https://codereview.chromium.org/2189583003
* Make the experimental SwarmBucket bot use the SkiaTriggers poolGravatar borenet2016-07-27
| | | | | | | BUG=skia:5581 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187023002 Review-Url: https://codereview.chromium.org/2187023002
* DEPS: sfntly 468cad5 → b18b09bGravatar halcanary2016-07-27
| | | | | | | | | SfntlyWrapper::SubsetFont now takes TTC index, needed for SkPDF. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186103002 Review-Url: https://codereview.chromium.org/2186103002
* Rename GrContext's newDrawContext & drawContext to makeDrawContextGravatar robertphillips2016-07-27
| | | | | | | | These both return sk_sp. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186073002 Review-Url: https://codereview.chromium.org/2186073002
* Make the yasm copy target be type 'none' rather than type 'executable'Gravatar bsalomon2016-07-27
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182873005 Review-Url: https://codereview.chromium.org/2182873005
* require semi at the end of SkASSERT and friendsGravatar caryclark2016-07-27
| | | | | | | | R=bungeman@google.com TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185063002 Review-Url: https://codereview.chromium.org/2185063002
* GN: fixes for MacGravatar mtklein2016-07-27
| | | | | | | | | | | | | | - Make fiddle build on Mac (skipping GL). - Now that we're building in SkCodec, we depend on libpng and libjpeg-turbo unconditionally, not just on Linux. - Re-arrange third_party a bit so that our targets are Fuchsia/Chrome compatible. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184133002 NOTREECHECKS=true This doesn't affect Chrome/Blink, so landing through the closed tree. Review-Url: https://codereview.chromium.org/2184133002
* SkPDF: SkPDFStream takes a unique_ptrGravatar halcanary2016-07-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188623004 Review-Url: https://codereview.chromium.org/2188623004
* Rename textual includes as *.inc.Gravatar benjaminwagner2016-07-27
| | | | | | | | | This makes it easier to distinguish source files that can stand on their own vs files meant to be #included into other source files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184143002 Review-Url: https://codereview.chromium.org/2184143002
* DEPS: ICU c291cde → ec9c113Gravatar halcanary2016-07-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189643003 Review-Url: https://codereview.chromium.org/2189643003
* DEPS: harfbuzz 1.2.7 → 1.3.0Gravatar halcanary2016-07-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2179963005 Review-Url: https://codereview.chromium.org/2179963005
* DEPS: sfntly 130f832 → 468cad5Gravatar halcanary2016-07-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189643002 Review-Url: https://codereview.chromium.org/2189643002
* Include "revision" tag for all Swarming tasksGravatar borenet2016-07-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186993002 Review-Url: https://codereview.chromium.org/2186993002
* Fix ParseConfigs_ViaParsing test when skia_angle=1Gravatar brianosman2016-07-27
| | | | | | | | | | | | | | | | The handling of angle-gl changes with SK_ANGLE. We don't have any bots that test this particular combination, but I see it all the time while running DM for other things. Previously considered changing things so that the config parsing results are consistent, regardless of GYP_DEFINES, but this is much simpler (and more consistent with the other code we already have for testing config parsing). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183323004 Review-Url: https://codereview.chromium.org/2183323004
* Fix leak of srgb/adobesrgb colorspace objectsGravatar bsalomon2016-07-27
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185043002 Review-Url: https://codereview.chromium.org/2185043002
* Fix Perf data uploadGravatar borenet2016-07-27
| | | | | | | BUG=skia:5563 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187603005 Review-Url: https://codereview.chromium.org/2187603005
* SW backend for viewer on WindowsGravatar bsalomon2016-07-27
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182273002 Review-Url: https://codereview.chromium.org/2182273002
* fuzz wednesdayGravatar caryclark2016-07-27
| | | | | | | | | | | | | Add debug 'skip assert' access to SkCoincidentSpans. That permits suppressing asserts to make it easier to detect when this fuzz data generates unparsable data. TBR=reed@google.com BUG=631564, 631992 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186973002 Review-Url: https://codereview.chromium.org/2186973002
* Clean up some unused atomic routines.Gravatar mtklein2016-07-27
| | | | | | | | | | | AtomicTest was the only use of sk_atomic_add(). AtomicInc64 bench was the only use of sk_atomic_inc(int64_t*). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2183473005 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot Review-Url: https://codereview.chromium.org/2183473005
* Add gyp define to enable vulkan debug layersGravatar egdaniel2016-07-27
| | | | | | | | | | | | | | | | | | On Debug vulkan bots, running with the debug layers on seems to be adding more than an hour to the total running time. Since we suppress any output on the bots anyways the debug layers are serving no purpose. Thus I am adding a gyp define to disable the layers on the bot. With this change, by default when running vulkan in Debug, the debug_layers will be enabled. The bots should disable the layers. Android framework should also have them disabled by default. TBR=djsollen@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003 Review-Url: https://codereview.chromium.org/2185953003
* Tweaks for the experimental SwarmBucket botGravatar borenet2016-07-27
| | | | | | | BUG=skia:5581 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2181073005 Review-Url: https://codereview.chromium.org/2181073005
* Extend __mulodi4() hack to 32-bit x86.Gravatar mtklein2016-07-27
| | | | | | | | | | | This gets the Android-Clang-x86 perf bot from failing on __mulodi4() to failing on the next problem... See https://luci-milo.appspot.com/swarming/task/3042e5f68636f810/steps/nanobench/0/stdout BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2190493002 Review-Url: https://codereview.chromium.org/2190493002
* Simplify color space xform storage and usage (float[] vs. SkMatrix44)Gravatar brianosman2016-07-27
| | | | | | | | | | Public API is really just internal. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185533005 TBR=bsalomon@google.com Review-Url: https://codereview.chromium.org/2185533005