| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
| |
This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery to GrDrawTarget to enable topological sorting)
BUG=skia:4094
Committed: https://skia.googlesource.com/skia/+/45a1c34f607a970933e5cd05e1df6cd8090db1be
Committed: https://skia.googlesource.com/skia/+/869c5e82a725a6928a45cd1fa6945ac783b8b3d8
Review URL: https://codereview.chromium.org/1414903002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1405223006
|
|
|
|
|
|
|
|
|
|
| |
List of changes at
https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4ba7cdd0e7bf49d671645264f839838fc56e1492..c4e33043fb071b6ea0a153845da625d7ed633d3d
Of particular interest is
"Fix VC++ 2015 64-bit truncation warning in zlib".
Review URL: https://codereview.chromium.org/1416043007
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're all set up to serialize and deserialze paths by an integer ID,
but we're just not deduping any paths (every path gets a new ID).
This turns on deduping. This should mean the number of paths in a
deserialized SkPicture are the same as when it was recorded.
No diffs:
https://gold.skia.org/search2?issue=1409373011&unt=true&query=source_type%3Dgm&master=false
BUG=skia:4527
Review URL: https://codereview.chromium.org/1409373011
|
|
|
|
|
|
|
|
|
|
| |
Follow up to https://codereview.chromium.org/1418073005/ (Remove gpu-side clip mask merging from clip mask manager).
The path renderer chain is only ever allocated when it is about to be used (so the delayed initialization doesn't buy us anything).
We can now reduce the lifetime of the pipelineBuilder in createAlphaClipMask
Review URL: https://codereview.chromium.org/1416113006
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use DumpStackTrace in SkASSERT in GOOGLE3.
There are extra assertions enabled in debug mode that cause RecordDraw_TextBounds to fail.
New include causes a naming conflict with global name "base".
Corresponding internal cl/106495354
No public API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1423013004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1410383008
|
|
|
|
|
|
| |
R=robert.phillips@google.com
Review URL: https://codereview.chromium.org/1409393007
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Logically this CL:
Moves the PathRendererChain from GrContext to GrDrawManager
- this was needed to untangled the Path-Chain/Renderer header mess
- this entailed adding getDrawingMgr so the CMM could access the PathRenderingChain
- this also entailed re-adding freeGpuResources to the GrDrawingMgr
Moves the CanDrawArgs struct up stack
Removes the GrPipelineBuilder from the CanDrawArgs struct
Review URL: https://codereview.chromium.org/1407883004
|
|
|
|
|
|
| |
into its own class.
Review URL: https://codereview.chromium.org/1420963008
|
|
|
|
|
|
|
|
| |
It's no longer used in Chrome.
BUG=skbug:3194
Review URL: https://codereview.chromium.org/1422183008
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1412013005
|
|
|
|
|
|
|
|
|
|
| |
The unrotated CTFont was introduced to fix color emoji scaling.
Use only the unrotated CTFont and apply the rotations manually.
This allows removal of one CTFont and allows us to apply (correctly)
the transformation CoreText would otherwise need to apply
(which it appears to do inconsistently).
Review URL: https://codereview.chromium.org/1360663002
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/1406413003
|
|
|
|
|
|
|
|
| |
Part ??? of separating glsl and gl
BUG=skia:
Review URL: https://codereview.chromium.org/1425013003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1411033003
|
|
|
|
|
|
|
|
|
|
| |
Its only caller is protected by the same #ifdef.
NOPRESUBMIT=true
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1404353010
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop leaning so hard on the branch predictor, and pull the conditionals
out of the loops for box_blur_double() (NEON). This is conceptually
the same change as https://codereview.chromium.org/1426583004/ for
the NEON double-pixel loop.
R=mtklein@google.com
BUG=skia:4526
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1412793009
|
|
|
|
|
|
| |
BUG=skia:4526
Review URL: https://codereview.chromium.org/1410553007
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1413363008
|
|
|
|
|
|
|
|
| |
Don't try to do NEON detection for Android framework builds.
BUG=skia:
Review URL: https://codereview.chromium.org/1423953004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1425033003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recent changes to WallTimer broke --samplingTime. In particular, this idiom became nonsensical:
WallTimer timer;
timer.start();
do {
...
timer.end();
} while(timer.fWall < ...);
WallTimer started making private use of fWall between when start() and end() were called, so the second time around the loop we end up with nonsense.
If that makes no sense, don't worry. The code here using now_ms() is just as fast, just as precise, and clearer.
I took the opportunity to simplify --samplingTime <complicated string parsing> to --ms <int>, and to simplify the code that depends on it.
BUG=skia:
Review URL: https://codereview.chromium.org/1419103004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For optimizing saveLayer() offscreens, it is useful to know the
bounds of the primitive being drawn. Currently, the bounds passed to
saveLayer() are filtered, which makes it difficult to know the original
bounds of the primitive. This CL changes the semantics to accept
unfiltered bounds. This actually simplifies the callsites too. In
order to result in the correct pixels being produced, we then call
computeFastBounds() inside clipRectBounds().
The old behaviour is wrapped in #ifdef SK_SAVE_LAYER_BOUNDS_ARE_FILTERED,
until we can update Chrome's callsites (see
https://codereview.chromium.org/1316243002/).
This change will affect the following GMs:
testimagefilters: saveLayer bounds no longer cause clipping
imagefiltersbase: slight pixel diffs
resizeimagefilter: slight pixel diffs on the "high quality" test case
imagefilterscropexpand: displacement results are now correct
filterfastbounds: slight pixel diffs
matriximagefilter: slight pixel diffs
BUG=skia:3194 skia:4526
Review URL: https://codereview.chromium.org/1304883004
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the clip mask merging path, the CMM creates new renderTargets and draws to them. In the non-MDB world this is okay b.c. all the draws land in the same drawTarget anyway. In the MDB world the draws for the new renderTargets have to land in different drawTargets.
This can be resolved by a lot of plumbing and refactoring to create drawContexts for the created renderTargets or by removing the mask-merging drawing path.
Since, https://codereview.chromium.org/1424853002/ (Disable gpu-side clip mask merging in the clip mask manager), appears to have stuck, this CL removes the clip mask merging code.
BUG=skia:4094
BUG=skia:4519
Review URL: https://codereview.chromium.org/1418073005
|
|
|
|
|
|
|
|
|
|
|
| |
This gives ~15% improvement on blur_image on Linux Z620,
and should allow me to implement cropping without
incurring a perf hit.
BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1426583004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1405083008
|
|
|
|
|
|
|
|
|
| |
no public API changes
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1419573011
|
|
|
|
|
|
|
|
| |
This makes it consistent with Linux/Mac. There, stderr is not buffered, so the flush is not needed / implicit.
BUG=skia:
Review URL: https://codereview.chromium.org/1419073003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Call python explicitly.
- Drop numpy dependency (on numpy.mean.... come on.)
- Make scipy dependency optional.
Depends on https://codereview.chromium.org/1419073003 to really work.
BUG=skia:
Doesn't change code.
NOTRY=true
Review URL: https://codereview.chromium.org/1416833004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This used to be leaked unconditionally by libc++.
Change-Id: I984ab7328ff3a2499c3c89a6862feaa62b6166de
Author: Dan Albert<danalbert@google.com>
Cherry-pick of https://android-review.googlesource.com/#/c/178189/1
This fixes the AOSP mips build.
Review URL: https://codereview.chromium.org/1425843003
|
|
|
|
|
|
|
| |
I want to be able to compare ANGLE vs CommandBuffer for
dm and nanobench on Mac, so enabling ANGLE on mac.
Review URL: https://codereview.chromium.org/1395783003
|
|
|
|
|
|
| |
BUG=skia:4524
Review URL: https://codereview.chromium.org/1430643002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1428543003
|
|
|
|
|
|
| |
TBR=joshualitt@google.com
Review URL: https://codereview.chromium.org/1413213005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bound uniforms that are optimized away causes GL errors
when they are used.
The bound location becomes unused if its bound uniform is
optimized away. Updating the inactive uniform using the
bound location causes a GL error from the command buffer.
Alternatively, command buffer may bind another free, unbound
uniform to the bound location. This causes the uniform update to
update the wrong uniform.
Disable the extension until the spec can be clarified and the
implementation fixed, if possible and needed.
BUG=skia:4454
Review URL: https://codereview.chromium.org/1417633008
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor box_blur() into a single driver function which
SSE*, NEON and generic code paths can use. I've used macros
to do this in order to keep debug performance reasonable,
but it's fairly ugly. I'm open to other suggestions.
BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/1408003007
|
|
|
|
|
|
| |
BUG=547182
Review URL: https://codereview.chromium.org/1424093002
|
|
|
|
|
|
|
|
|
| |
Motivation: This will be easier than adding a friend every time I want
to create a one-off SkCanvas subclass or SkRemote::Encoder subclass.
See also: SkPath::Iter.
Review URL: https://codereview.chromium.org/1411723005
|
|
|
|
|
|
|
| |
Required to fix a mac build error with command buffer, and possible
memory allocation issue when used with skia_angle on linux.
Review URL: https://codereview.chromium.org/1413403005
|
|
|
|
|
|
|
|
|
|
| |
This involves disabling webps for kCanvas_Strategy.
We have not yet implemented webp subset decodes for this
strategy.
BUG=skia:4521
Review URL: https://codereview.chromium.org/1405273004
|
|
|
|
|
|
|
|
| |
The function will be needed in Android.
BUG=skia:
Review URL: https://codereview.chromium.org/1425833002
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use _mm_prefetch() if available, e.g. with MSVC.
- Some other tidying up.
No public API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1427663002
|
|
|
|
|
|
|
|
|
|
| |
The result SkBitmap, the pixel allocator, and the alpha
preference need to be communicated from the client to
the region decoder.
BUG=skia:
Review URL: https://codereview.chromium.org/1418093006
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's absurdly slow.
We can turn it back on with
skia> python gyp_skia -Dskia_win_ltcg=1
The bots will automatically define skia_is_bot and skia_win_ltcg.
BUG=skia:
Review URL: https://codereview.chromium.org/1407043009
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The extension on the mac is .dylib, updated the name.
EGL.h isn't available on mac (unless we include skia_angle.h).
I've got a somewhat bad hack of defining the types that I need
to get this running.
GetProcedureAddress was somehow successfully grabbing gl
functions from another lib. Removed this call, I copied it
from ANGLE impl, but it isn't required.
lib load path works differently, fixed in GYP
BUG=skia:2992
Review URL: https://codereview.chromium.org/1403153002
|
|
|
|
|
|
|
|
|
|
| |
In the MDB world the clip mask manager would need to create a separate drawContext for each temporary mask (and we would need to support stencil draws in the drawContext). For now, disable the feature.
Please see skbug.com/4519 (Re-enable gpu-side mask merging in Ganesh)
BUG=skia:4094
Review URL: https://codereview.chromium.org/1424853002
|
|
|
|
|
|
|
|
| |
versions.
BUG=skia:4520
Review URL: https://codereview.chromium.org/1418423008
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update FreeType to a newer version. Because this caused issues in
finding the correct ftoptions.h and ftmodule.h [1], be sure to state
the ones we want explicitly.
This also add gzip.c which is needed for WOFF support [2].
[1] FreeType "Simplify header file hierarchy."
fae382076409db198dfbff36ac4cbb97b05b30a1
[2] FreeType "[gzip] New function `FT_Gzip_Uncompress'."
dc240524ff31891a442225430b28e9620c1fa89f
Review URL: https://codereview.chromium.org/833103004
|
|
|
|
|
|
|
| |
All our codecs now support 565, so no need to have a boolean to check
it.
Review URL: https://codereview.chromium.org/1414553006
|