aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Update Porter Duff analysis to match LCD logic.Gravatar Greg Daniel2017-05-19
| | | | | | | | Bug: skia: Change-Id: Ib222c37f7ebb307752806829742a3b6278dbae3d Reviewed-on: https://skia-review.googlesource.com/17410 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Remove debug flag for ios botsGravatar Stephan Altmueller2017-05-19
| | | | | | | | | TBR=borenet Bug: skia: Change-Id: I791ad92203ca8cdd6da8abe7c9f45fde528cb7b9 Reviewed-on: https://skia-review.googlesource.com/17409 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Improve test coverage of image decode modesGravatar Matt Sarett2017-05-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the new world... --image CodecSrc and ImageGenSrc tests run on: (1) 8888 with kIgnore transfer fn behavior (2) srgb with kRespect transfer fn behavior (3) f16 AndroidCodecSrc and BRDCodecSrc tests run on: (1) 8888, since SkAndroidCodec always uses kIgnore (2) f16, since android uses f16 --colorImage ColorCodecSrc tests run on: (1) 8888 in kBaseline mode, so we can see what the raw pixels look like (2) srgb in color correct modes (3) f16 in color correct modes Bug: skia: Change-Id: I65d1a04051da6f94bf5e48f7bc610f482870dc75 Reviewed-on: https://skia-review.googlesource.com/17396 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* stage version of verticesGravatar Mike Reed2017-05-19
| | | | | | | | | | | | | | | | This CL, just to limit its size/complexity, only handles colors but not textures. Future CLs will cover everything. Performance is pretty exciting. Its faster than the old code-path, and when we fix a bug in pathutils to preserve opaqueness, it gets a lot faster (8 -> 5) Bug: skia: Change-Id: I4113060e25fe25fe4e6a0ea59bd4fa5e33abc668 Reviewed-on: https://skia-review.googlesource.com/17276 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* minor skslc bugfixesGravatar Ethan Nicholas2017-05-19
| | | | | | | | | | This fixes the attributes on sk_VertexID, and a backwards test on SkSL::String::startsWith and ::endsWith. Change-Id: Icfddfc8ca95454d8646a1771761685c2525b296e Reviewed-on: https://skia-review.googlesource.com/17398 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/0104dcd6b327b06880b9020f1cb2ca2b93d08a5d Fix recipe typo (martiniss@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I167a43ad87b66295d479d1012512e2a79d9f5a86 Reviewed-on: https://skia-review.googlesource.com/17400 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Comment out lcd assert to make GLPrograms test happyGravatar Greg Daniel2017-05-19
| | | | | | | | | | | TBR=bsalomon@google.com Bug: skia:6661 Change-Id: I944d05c31d3d5511f3c1679c9eb689dbcfbbb109 Reviewed-on: https://skia-review.googlesource.com/17399 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Remove transitional parts from iOS job namesGravatar Stephan Altmueller2017-05-19
| | | | | | | | Bug: skia: Change-Id: If19e5a956d3f10448cfe889127c2f79d9c42926e Reviewed-on: https://skia-review.googlesource.com/17372 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Fix gpu lcd blending to semi-correctly handle alpha coverageGravatar Greg Daniel2017-05-19
| | | | | | | | Bug: skia:6606 Change-Id: I16ccd97f5d047eb7fddfed5310bf669e7435ccdd Reviewed-on: https://skia-review.googlesource.com/17370 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Temporarily use default webp encode method for bzlGravatar Matt Sarett2017-05-19
| | | | | | | | | | I suspect that this will fix the failing golden image tests. Bug: skia: Change-Id: I9f88206ae782e6a04817e72cdfcb3e0c4bdaa293 Reviewed-on: https://skia-review.googlesource.com/17393 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Update NexusPlayers to O Preview 2Gravatar Kevin Lubick2017-05-19
| | | | | | | | | | | This may help with NexusPlayers flaking out. Bug: skia:6045 NOTRY=true Change-Id: I1ac1bf3cb5e17d26069082da7cb0f420865c9630 Reviewed-on: https://skia-review.googlesource.com/17388 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* detect (and preserve) if patch colors are opaqueGravatar Mike Reed2017-05-19
| | | | | | | | Bug: skia: Change-Id: Ida3a1ff3f78db2498a6dfc655d8be4de8ad912c7 Reviewed-on: https://skia-review.googlesource.com/17380 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Mike Reed <reed@google.com>
* SkDocument: remove deprecated functionGravatar Hal Canary2017-05-19
| | | | | | | | | | I meant to land this after https://crrev.com/2726103006 , but got sidetracked. Change-Id: I4f0397302d41e89d2394bec545190cb024929bd8 Reviewed-on: https://skia-review.googlesource.com/17390 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Updated workaround for Intel 6xxx clear to 0/1 bugGravatar Eric Karl2017-05-19
| | | | | | | | | | | | | The previous workaround only handled the glClearColor(0,0,0,1) case, it turns out we need to work around any glClearColor made up of entirely 0s and 1s. R=bsalomon@google.com Bug: 710443 Change-Id: I78a75559fc11811ad9a218436231354d66d2ad51 Reviewed-on: https://skia-review.googlesource.com/17327 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Eric Karl <ericrk@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/c33bbcee5e1f89a78814b7b9ebbc7cdbe19eddc8 Dart: Increase timeout for IE bots, use fewer processors (whesse@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8993e271c3252b57ce723f1f7095f38ceb5b50d7 Reviewed-on: https://skia-review.googlesource.com/17389 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/9709c362f800ceeffd2be24edee6d398d68f18ac [cronet] Don't use is_official_build universally on cronet bots. (jbudorick@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8408708568bebc62682439f9322a4684550b46b5 Reviewed-on: https://skia-review.googlesource.com/17385 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/00749f571ff265c29cc9f2be07120364b00fcda8 Dart: Add "debug" and "unittests" options to dart2js recipe. (whesse@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6d8bcf28eaf04733eae8fcd587fb24b9b2beb652 Reviewed-on: https://skia-review.googlesource.com/17384 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/28ebfb41f178f521e9187108c7b6ddd66b8e4a85 V8: Bump shards on PPC and S390 bots (machenbach@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I669307e2e1b10f2fb5e2f66781d3bb12839bff70 Reviewed-on: https://skia-review.googlesource.com/17383 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. depot_tools: https://crrev.com/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6 Refactor PRESUBMIT support for tags (agable@chromium.org) https://crrev.com/064f6f4a9d2932ae699dbf4355bc63359e599026 gclient flatten: first pass (phajdan.jr@chromium.org) https://crrev.com/063814f82efdda25a0d1737395172faa88a5fd0f Remove "url" recipe module. (dnj@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I85f0df7d2de9782fc8c66e827c53eb16c03edf34 Reviewed-on: https://skia-review.googlesource.com/17382 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-19
| | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/e99a7805ce3c1fef96b428fb542d23fe975e8c5c Fix bot config for battor non linux builders (martiniss@chromium.org) https://crrev.com/cdf1ebd83441bc4bb54899e3f94d92d7953b8c66 Remove Android Swarming Tester (martiniss@chromium.org) https://crrev.com/9d08858e8f2f3aa0c556c1339eeca3d88bb44d46 Add four more slaves to N5 bot on chromium.swarm (bpastene@google.com) https://crrev.com/16c52aa6473518cf6751a9503a6e0b0d684979f8 CrOS: Update Chromite pin. (nodir@google.com) https://crrev.com/2cc4e2912d055df545a22801adaae8d16fbcb216 Convert Android One Perf builder to swarming (martiniss@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I75e3e2f14548081e5dfb585b22aec25f48a81e76 Reviewed-on: https://skia-review.googlesource.com/17374 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/f347ca1f531aad4cfb60ac6f23b4a8d8426195db ios/try: add regression test for patch application failure (phajdan.jr@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3a296e258c78850341874b8698242ec75260f5ba Reviewed-on: https://skia-review.googlesource.com/17373 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Revert "Update clearOp for split-OpList world"Gravatar Robert Phillips2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7f1ce29c9bb9be8b2d8dbf9a99f14f74d5dc6d80. Reason for revert: Maybe causing problems in imagemakewithfilter & dropshadowimagefilter Original change's description: > Update clearOp for split-OpList world > > It would reduce a lot of noise if the GrRenderTargetOpList kept a pointer to the GrCaps but, for now, I'm trying to shrink the GrRTOpList, not expand it. > > Change-Id: Ieed56fa2a41a3fb20234e26552ae2d301147e4f2 > Reviewed-on: https://skia-review.googlesource.com/17323 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ib23ce4515d9427759ebd2b6d4c9d3a670f00a153 Reviewed-on: https://skia-review.googlesource.com/17326 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Revert "Disable resource cache in shadow_utils GM for now""Gravatar Jim Van Verth2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0b58ef7b525e5325ecd194c4b470e4c924cbb56a. Reason for revert: Wasn't actually fixed. Original change's description: > Revert "Disable resource cache in shadow_utils GM for now" > > This reverts commit c34a946d5a975ba8b8cd51f79b55174a5ec0f99f. > > Reason for revert: This is probably fixed with https://skia-review.googlesource.com/c/17279/. > > Original change's description: > > Disable resource cache in shadow_utils GM for now > > > > This should make the GMs more stable in tiled mode. > > > > Change-Id: I72996b1305fc99e60626af35267952d0a5c38624 > > Reviewed-on: https://skia-review.googlesource.com/17275 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Jim Van Verth <jvanverth@google.com> > > > > TBR=jvanverth@google.com,reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I0d21652a301b3f81e7ec04638bedbaabc723e583 > Reviewed-on: https://skia-review.googlesource.com/17304 > Reviewed-by: Jim Van Verth <jvanverth@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> > TBR=mtklein@google.com,jvanverth@google.com,reviews@skia.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: If606795bfeb4e6ed78f199fcb86ee2767bde5216 Reviewed-on: https://skia-review.googlesource.com/17371 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* comment SK_API and add fix paramsGravatar Cary Clark2017-05-18
| | | | | | | | | | | | | | | | | I thought that SK_API on operator== was redundant with SK_API on the enclosing class, and was not needed. Turns out for mac_chromium_debug_ng it is needed. Added comments for history. Meanwhile, bookmaker found some missing and mis-named parameters, so all is not lost. R=reed@google.com Change-Id: I88645666a9d06ec90c5ac133673460d6e6c75528 Reviewed-on: https://skia-review.googlesource.com/17277 Commit-Queue: Cary Clark <caryclark@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Remove ambient and spot mask filters.Gravatar Jim Van Verth2017-05-18
| | | | | | | | | Also remove a deprecated interface in SkShadowUtils. Change-Id: I32e67271be953f11071c512cb39a47ea1e7dcaaf Reviewed-on: https://skia-review.googlesource.com/17266 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Update clearOp for split-OpList worldGravatar Robert Phillips2017-05-18
| | | | | | | | | It would reduce a lot of noise if the GrRenderTargetOpList kept a pointer to the GrCaps but, for now, I'm trying to shrink the GrRTOpList, not expand it. Change-Id: Ieed56fa2a41a3fb20234e26552ae2d301147e4f2 Reviewed-on: https://skia-review.googlesource.com/17323 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add microbench for shadowsGravatar Jim Van Verth2017-05-18
| | | | | | | | | Based on Android's shadowgrid2. Change-Id: I33209b6b84fc63a762405c4988afbdbffcc170d6 Reviewed-on: https://skia-review.googlesource.com/17360 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/09b389732d01bbeb2bfb17f5de06e15a952f0cbb buildbot: log path where pruning is happening (nodir@google.com) https://crrev.com/e13406ec6a3459b6dccd3eca4be5bdcd5325682e Remove Win10 experimental bots (hinoka@google.com) https://crrev.com/745e8d9fbc8344d522a84131ffa9b43472dbb06d Revert "Reland: zip_build.py: Exclude secondary toolchain obj and gen, as well as .ninja" (agrieve@chromium.org) depot_tools: https://crrev.com/16d2ae8cb05c27956530d8f05a893caec6a488ac bot_update: fix regression with swallowed exception (phajdan.jr@chromium.org) recipe_engine: https://crrev.com/2f2d5c663eddcd8b6924a8775aaf88f3600d2ac8 [step_runner] expand try/catch to cover all step preparation functionality (iannucci@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0dfbef52e05e67b967846b91813ca1c6ee3abf15 Reviewed-on: https://skia-review.googlesource.com/17366 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Revert "Remove GrSurfaceDesc member from GrSurface."Gravatar Greg Daniel2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 84911546b9535a2fff6c5e07f588f175d5a04f45. Reason for revert: Breaking bots possibly? Original change's description: > Remove GrSurfaceDesc member from GrSurface. > > Change-Id: I0fe979994e1e3fc457b952dfb5e0090c45fad771 > Reviewed-on: https://skia-review.googlesource.com/17273 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I404e509fcd3e3d5527b3bc6e286b7d436c12e879 Reviewed-on: https://skia-review.googlesource.com/17364 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Hide SkPerlinNoiseShader impl detailsGravatar Florin Malita2017-05-18
| | | | | | | | | | Move the shader impl to a private class, leave SkPerlinNoiseShader as a factory class only (similar to e.g. SkLightingShader). Change-Id: Ic1180db8f5dfd3d8f6fba133c6bf6bbdfa4f97a4 Reviewed-on: https://skia-review.googlesource.com/17318 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Use persistent checkout for UpdateMetaConfig botGravatar Ravi Mistry2017-05-18
| | | | | | | | | | | Bot is failing without this. BUG=skia:6591 Change-Id: I29cf5e18a7fa240d3e45bdadf83c1f91060f45f5 Reviewed-on: https://skia-review.googlesource.com/17319 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Remove GrSurfaceDesc member from GrSurface.Gravatar Brian Salomon2017-05-18
| | | | | | | Change-Id: I0fe979994e1e3fc457b952dfb5e0090c45fad771 Reviewed-on: https://skia-review.googlesource.com/17273 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Switch over GrDiscardOp to IORef-ing the GrRenderTargetProxyGravatar Robert Phillips2017-05-18
| | | | | | | | | | | This cannot land until after https://skia-review.googlesource.com/c/14186/ (Split up opLists (take 3)) sticks. This is because, prior to that CL, the SurfaceProxies have a ref on the last OpList that wrote to them. Since this CL adds a IORef from a discardOp in an opList to the SurfaceProxy this can result in a loop. After the required CL sticks, opLists have a IORef on the SurfaceProxy to which they wrote and the SurfaceProxy just has a raw back pointer so there will be no loop. Change-Id: I198035f5dd5a8fad549052dea6aaa61477a89844 Reviewed-on: https://skia-review.googlesource.com/16663 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* CQ_INCLUDE_CHROMIUM_TRYBOTS: add optional trybotsGravatar Hal Canary2017-05-18
| | | | | | | Change-Id: Id1bc86592a3006b00dfd313bf48488e038f3a041 Reviewed-on: https://skia-review.googlesource.com/17317 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Add drawArraysBaseVertexIsBroken flagGravatar Chris Dalton2017-05-18
| | | | | | | | | | | A non-zero base vertex in glDrawArrays appears to not always work on Adreno. Bug: skia:6650 Change-Id: I301eaba8c7790ed814a2ab8d8c53dd2b9e0d77d1 Reviewed-on: https://skia-review.googlesource.com/17083 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Add check for incorrect opList splitsGravatar Robert Phillips2017-05-18
| | | | | | | | | | | | | This CL relies on: https://skia-review.googlesource.com/c/14186/ (Split up opLists (take 3)) We can't/don't want to close the opList in the GrSurfaceContext dtor because we, semi-often, wrap a proxy in a utility SurfaceContext in order to upload data to it (e.g., when creating a proxy w/ data or in the texture strip atlas). In the current set up, the "temporary fixes" in newRTOpList and newTextureOpList should prevent any out of order execution. Change-Id: I8189db6ed59096d7b8c1704028df395f84e4a681 Reviewed-on: https://skia-review.googlesource.com/14187 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Revert "Remove GrSurface::desc() method.""Gravatar Brian Salomon2017-05-18
| | | | | | | | | | This reverts commit c96da1e51e1ca72d54dda49f32891bd41530ad31. Bug: skia: Change-Id: I8242400a137413c01c7ef614b4fa733be7dcf939 Reviewed-on: https://skia-review.googlesource.com/17311 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Expand small tables in SkColorSpaceXform_A2BGravatar Matt Sarett2017-05-18
| | | | | | | | Bug: 722855 Change-Id: Id3661be1e9747ac0de1e35b60d334ee8187a5be5 Reviewed-on: https://skia-review.googlesource.com/17312 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Pre-cache SkPath's genID in PreCachedPath tooGravatar Mike Klein2017-05-18
| | | | | | | | SkPath::getGenerationID() calls SkPathRef's, which is where the race is. Change-Id: I71296b32148c8cda2d2b2fe249ef6b9ef84fcfe0 Reviewed-on: https://skia-review.googlesource.com/17316 Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/1929522b5629bc18495781feaf794bef80db81f4 Nitfix follow up for https://chromium-review.googlesource.com/c/507128 (tandrii@chromium.org) https://crrev.com/feefbde597dd2c76463f51ad35e555922ce2c93f Bootstrap "authorize_adb_devices". (dnj@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I24c8fc5e7c1e5a141ace50e9a8a17b079e397afe Reviewed-on: https://skia-review.googlesource.com/17314 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Fix SkImage::onMakeColorSpace() for subset lazy imagesGravatar Matt Sarett2017-05-18
| | | | | | | | Bug: 723149 Change-Id: Ib56a77958fc1b7e026ee5ca98a46e8f014fe75d4 Reviewed-on: https://skia-review.googlesource.com/17309 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Matt Sarett <msarett@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/df8a4659dcb826adfeb1f1534f124db33cda13e8 Revert "Remove debug output during recipe training." (tandrii@chromium.org) https://crrev.com/589e5267097f76224e0ac2e2ea554aff635d979f Revert "Turtles all the way down = aka debugging chromium_tests 2." (tandrii@chromium.org) https://crrev.com/af07a8d4dd8b3525570758f551c386dd680e0bf2 Revert "Turtles all the way down = aka debugging chromium_tests." (tandrii@chromium.org) https://crrev.com/81ae4cac09270557f27b650e4a19239d16ae9fde Revert "Add debug marker for ease text search for debugging info." (tandrii@chromium.org) https://crrev.com/208399a7f37deab314244d1c990570c0fd630a6a Revert "Log masked exception in test utils" (tandrii@chromium.org) https://crrev.com/8e9cb844bc627074c4aa50e1255cb468241dc2f6 V8: Add concurrent marking tsan bots (machenbach@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5823023f3b6910011055136ff603d3579482a690 Reviewed-on: https://skia-review.googlesource.com/17310 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Remove unused SkZeroShaderContextGravatar Florin Malita2017-05-18
| | | | | | | Change-Id: I3e9d9cb9c2f948b0bb363871e038ade1cf2f3d67 Reviewed-on: https://skia-review.googlesource.com/17308 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Bot to update buildbucket.config dailyGravatar Ravi Mistry2017-05-18
| | | | | | | | Bug: skia:6591 Change-Id: Ic2ec5b033965ca073a00e272693b1c5e1d0ad69f Reviewed-on: https://skia-review.googlesource.com/16541 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Move MIP color mode from GrSurfaceProxy to GrTextureProxyGravatar Brian Salomon2017-05-18
| | | | | | | Change-Id: I76bc7f551ea4052fc611cf01e0ce81102c9c3395 Reviewed-on: https://skia-review.googlesource.com/17263 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Remove GrSurface::desc() method."Gravatar Greg Daniel2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9ac995354428a916df81253e0c0c3f582db18976. Reason for revert: Lots of broken gold images Original change's description: > Remove GrSurface::desc() method. > > Change-Id: If158dee90b3b0f80aa9c674180fbe6abd5b27d3f > Reviewed-on: https://skia-review.googlesource.com/17268 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> > TBR=bsalomon@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I5608c0e287e301aeac81dd3249a5c34d4603fcc6 Reviewed-on: https://skia-review.googlesource.com/17306 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/5e7db1588c5a375b1e77c074896ec1d28e5c2717 Bootstrap 'gsutil_cp_dir.py'. (dnj@chromium.org) https://crrev.com/d12c5d4da0acff399a59b9fab33c26f4f83201b3 Bootstrap "find_xcode.py". (dnj@chromium.org) https://crrev.com/5903d958fa5b792df25a290bc8e3f2437da75f28 chromite: Explicitly fetch depot_tools and put in path. (dgarrett@google.com) https://crrev.com/548cbb2161cccbba8e0c8f6e5e91a959ecbede3b Bootstrap 'upload_perf_dashboard_results' (dnj@chromium.org) https://crrev.com/72e5b727a9aaa51e36c1a43a048933a2d477e2fb Bootstrap "taskkill" and "runhooks_wrapper". (dnj@chromium.org) https://crrev.com/5d416e2d7d87bb5b3348fddfedda09619b9070d9 Bootstrap 'chromium_codesearch' Python calls. (dnj@chromium.org) https://crrev.com/5f35f05f0059fe1a742f26e4e3419e17e24d61d4 buildbot: prune files asynchronously (nodir@google.com) https://crrev.com/59b2a19535187b885ced88a997587ae54cb8a379 Bootstrap "archive_webkit_test_results". (dnj@chromium.org) https://crrev.com/13eedbe79cab4bdfb588eae57453d1bac57465ef Bootstrap chromium recipe module through runit.py (dnj@chromium.org) https://crrev.com/48e7709a6985dca0691e7d8be35f54c54d0dac92 chromite: Use cros_git_cache cache entry, not fixed path. (dgarrett@google.com) https://crrev.com/e8ac15dd482fba8f81b9c25bb5e0885db7bb5bc1 Bootstrap "gsutil_download". (dnj@chromium.org) https://crrev.com/dd7c881ce81e4530ad0158988c1f952dbe746aef chromite: Revise git-cache cache name to be standard. (dgarrett@google.com) https://crrev.com/a820eec0c2f3b2cb88b4d660613e9c92212af46a Bootstrap "nacl_sdk_buildbot_run". (dnj@chromium.org) https://crrev.com/d4e3bd5598f8a51a843723d5da136ad452d7db8b Bootstrap "archive_build.py". (dnj@chromium.org) https://crrev.com/469eb2aa0ebc7882ca7ad20d26add15a3d4c632c chromite: Set LANG to a known value. (dgarrett@google.com) https://crrev.com/9ec76523bb3629ab4874cd834c44dfa992929fc7 Bootstrap "transfer_files.py". (dnj@chromium.org) https://crrev.com/a3b6bc4351f05643d535938e6e7f1bfaf1bfdfc7 Turn off swarming for the linux layout tests temporarily. (dpranke@chromium.org) https://crrev.com/53a6b44b40dade4da9546b3f976313f1cd3f0cbe Bisect - Push gerrit changes to prod. (simonhatch@chromium.org) https://crrev.com/8f8aee589409a3a4b09cd2df307268baa517be98 Bootstrap "daemonizer.py". (dnj@chromium.org) https://crrev.com/5eb5de9c8c3da08fa9a1d546955e237ac719f912 [codesearch] Refactor chromium_codesearch.py by adding recipe modules (shenghuazhang@google.com) https://crrev.com/74b36c2301966a939024a8f240a7896c5d9b0b87 Revert "Turtles all the way down = aka debugging chromium_tests 3." (tandrii@chromium.org) https://crrev.com/ad3ec490aaa7742ff98c5c84ed79f0e59fa3bf2d Remove "Chromium Linux Precise Goma LinkTest" from recipes. (yyanagisawa@chromium.org) recipe_engine: https://crrev.com/cae7fab7b53f5c739176e95a116401592ff2b9e2 [step_runner] fix error text (iannucci@chromium.org) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0a17c3580ddb1e80d8df38200e923b008281e805 Reviewed-on: https://skia-review.googlesource.com/17301 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
* Revert "Disable resource cache in shadow_utils GM for now"Gravatar Jim Van Verth2017-05-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c34a946d5a975ba8b8cd51f79b55174a5ec0f99f. Reason for revert: This is probably fixed with https://skia-review.googlesource.com/c/17279/. Original change's description: > Disable resource cache in shadow_utils GM for now > > This should make the GMs more stable in tiled mode. > > Change-Id: I72996b1305fc99e60626af35267952d0a5c38624 > Reviewed-on: https://skia-review.googlesource.com/17275 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> > TBR=jvanverth@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I0d21652a301b3f81e7ec04638bedbaabc723e583 Reviewed-on: https://skia-review.googlesource.com/17304 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* SkPath -> PreCachedPathGravatar Mike Klein2017-05-18
| | | | | | | | | | | SkPath is not threadsafe. Gotta use PreCachedPath. TSAN is showing a race in SkPathRef::genID() to write the fGenerationID. Change-Id: I42d6ecadaa754a3c6796ca465981de430a0abb84 Reviewed-on: https://skia-review.googlesource.com/17279 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Roll recipe dependencies (trivial).Gravatar recipe-roller2017-05-18
| | | | | | | | | | | | | | | | | | | | | This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. build: https://crrev.com/2c49b178c275e8e65b5d9b76e8ff3cefdb549f4e Remove Android Release (Pixel C) from GPU.FYI (ynovikov@google.com) TBR=borenet@google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I51c75b6755abdb9104da65730b368b0830da85be Reviewed-on: https://skia-review.googlesource.com/17278 Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-28 00:46:48 +0000