aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Revert of SkNx refactoring (patchset #4 id:60001 of ↵Gravatar mtklein2016-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1690633003/ ) Reason for revert: Precautionary revert for chromium:586487 Original issue's description: > SkNx refactoring > > - add back Sk4i typedef > - define SSE casts in terms of Sk4i > * uint8 <-> float becomes uint8 <-> int <-> float > * uint16 <-> float becomes uint16 <-> int <-> float > > This has the nice side effect of specializing uint8 <-> int > and uint16 <-> int, which are useful in their own right. > > There are many cast specializations now, some of which call each other. > I have tried to arrange them in some sort of sensible order, subject to > the constraint that those called must precede those who call. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690633003 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/c1eb311f4e98934476f1b2ad5d6de772cf140d60 TBR=herb@google.com,mtklein@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:586487 Review URL: https://codereview.chromium.org/1696903002
* Try fixing unused-variable warnings another way.Gravatar mtklein2016-02-12
| | | | | | | | | | | | | | If we mark these as extern, the compiler won't complain they're unused. This is an unsatisfying hack, but last time we tried to condition these on non-NEON only, Chromium's GN linux ARM bot failed. They must not be configured to use the NEON procs? BUG=skia:4798 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699473002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1699473002
* Add infastructure for gl_SampleMaskGravatar cdalton2016-02-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690963003 Review URL: https://codereview.chromium.org/1690963003
* Fix colorType/alphaType checks in SkCodecGravatar msarett2016-02-12
| | | | | | | | | | | | | | Make getPixels() and startScanlineDecode() behave consistently. Require that kGray8 decodes are opaque. Assert that creating the swizzler succeeds. BUG=skia:4203 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1695473002 Review URL: https://codereview.chromium.org/1695473002
* Sync DEPS to clang compatible arm v8 assembly for libjpeg-turboGravatar msarett2016-02-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1697623002 Review URL: https://codereview.chromium.org/1697623002
* followupsGravatar mtklein2016-02-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693823005 Review URL: https://codereview.chromium.org/1693823005
* Remove check for platform_tools/android/third_party/externals.Gravatar mtklein2016-02-12
| | | | | | | | | We don't sync anything into it anymore, so a fresh gclient sync won't create it. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1694813004 Review URL: https://codereview.chromium.org/1694813004
* Add support for caching font files in the Android SkFontMgr.Gravatar khushalsagar2016-02-12
| | | | | | | | | | | | | SkFontMgr_Android lazily access font files from disk, which is not possible when it is used in the renderer sandbox on Linux. Add a flag to SkFontMgr_Android_CustomFonts for caching readonly FILE streams when creating the font mgr. Since the font mgr is created before the sandbox is initialized, it can access these files on initialization, and use these cached streams safely for its lifetime. Review URL: https://codereview.chromium.org/1673373003
* Make SkJpegCodec compatible with libjpegGravatar msarett2016-02-12
| | | | | | | | BUG=skia:4470 BUG=skia:4520 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1687863003 Review URL: https://codereview.chromium.org/1687863003
* Change ScalarTo256 to more efficient implementation.Gravatar benjaminwagner2016-02-12
| | | | | | | | | The previous implementation was likely more efficient when SkScalar was SkFixed. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693683002 Review URL: https://codereview.chromium.org/1693683002
* Put all XSAN bots on the same DEPS-sourced build of Clang.Gravatar mtklein2016-02-12
| | | | | | | | | | | | This adds LLVM, Clang, and compiler-rt (*san tools) to DEPS, then uses them from xsan_build, building them if needed. This is similar to how the CMake bots bootstrap CMake if needed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693733003 Review URL: https://codereview.chromium.org/1693733003
* Use noperspective interpolation for 2D drawsGravatar cdalton2016-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | | Adds a mechanism to notify GrGLSLVaryingHandler that a shader will not emit geometry in perspective. This gives it a chance to use the noperspective keyword if it is supported. Updates the existing processors to notify the varying handler when there is no perspective. Begins using the noperspective keyword in GrGLGpu internal shaders. Web scenes with observable benefit (Pixel C, gpu config): tabl_nofolo.skp 4.62 -> 3.33 ms 28% desk_tigersvg.skp 26.5 -> 24 ms 9% desk_pokemonwiki.skp 16.1 -> 14.9 ms 7% tabl_deviantart.skp 3.97 -> 3.7 ms 7% desk_gws.skp 3.85 -> 3.65 ms 5% Also adds new methods for creating varyings with flat interpolation. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1673093002 Review URL: https://codereview.chromium.org/1673093002
* Make copySurface work in more situations.Gravatar bsalomon2016-02-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693923002 Review URL: https://codereview.chromium.org/1693923002
* added clip visualization to skiaserveGravatar ethannicholas2016-02-12
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690023004 Review URL: https://codereview.chromium.org/1690023004
* Add a dependency from the debugger on tools.gyp:url_data_manager.Gravatar jbroman2016-02-12
| | | | | | | BUG=skia:4947 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1695753003 Review URL: https://codereview.chromium.org/1695753003
* Put back the 0.5 bias in the shader. Only adjust the radii for the geometry, ↵Gravatar brianosman2016-02-12
| | | | | | | | | | | not the radii constants. After working through this with Jim, this is more mathematically correct, and also accounts for the inner radius. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692683003 Review URL: https://codereview.chromium.org/1692683003
* skiaserve now retains the graphics context rather than creating a new one ↵Gravatar ethannicholas2016-02-12
| | | | | | | | each request GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693893002 Review URL: https://codereview.chromium.org/1693893002
* Update Android framework makefile to build static and shared libsGravatar djsollen2016-02-12
| | | | | | | | Also use static lib for testing tools and expose includes needed for other framework testing tools to statically link in Skia. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696483002 Review URL: https://codereview.chromium.org/1696483002
* Documantation: nanobenchGravatar halcanary2016-02-12
| | | | | | | | | DOCS_PREVIEW= https://skia.org/dev/testing/tests?cl=1696723002 https://skia.org/dev/testing/tests?cl=1696723002#bench GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1696723002 NOTRY=true Review URL: https://codereview.chromium.org/1696723002
* Remove the 0.5 bias from the ellipse edge function. This makes coverage drop ↵Gravatar brianosman2016-02-12
| | | | | | | | | to zero before we get clipped by the rasterizer (i.e. ensures the generated ellipse is inscribed in the geometry). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683843006 Review URL: https://codereview.chromium.org/1683843006
* SkDocument: remove use of SkTArray (part 3/3).Gravatar halcanary2016-02-12
| | | | | | | TBR=reed Removal only. Verbal lgtm. Review URL: https://codereview.chromium.org/1692703003
* fixed SkDebugCanvas' handling of drawPictureGravatar ethannicholas2016-02-12
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1685133008 Review URL: https://codereview.chromium.org/1685133008
* Enable RAW codec for Google3.Gravatar benjaminwagner2016-02-11
| | | | | | | This CL depends on internal cl/113089689. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692513003 Review URL: https://codereview.chromium.org/1692513003
* Delete SkDecodingImageGeneratorGravatar msarett2016-02-11
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692053002 Review URL: https://codereview.chromium.org/1692053002
* Switch to vertex colors rather than uniforms for color in ↵Gravatar brianosman2016-02-11
| | | | | | | | | | | | | | Ellipse/Circle/RRect/DRRect [Notes:] - Performance delta on desktop looked like noise. I'm curious what the results will be on low-end mobile GPUs. I'm still trying to figure out how I determine that with perf, etc... - There appeared to be a single one-pixel image diff while running dm, if I'm understanding the results of skdiff correctly, so that's probably good news? - Should I include anyone else on the review? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1675833002 Review URL: https://codereview.chromium.org/1675833002
* Add #define directives to GrGLSLShaderBuilderGravatar cdalton2016-02-11
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1660813002 Review URL: https://codereview.chromium.org/1660813002
* Implement onSkipScanlines() for bmp and wbmpGravatar msarett2016-02-11
| | | | | | | | TBR=reed@google.com BUG=skia:4270 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691083002 Review URL: https://codereview.chromium.org/1691083002
* fixed off-by-one error in skiaserve /cmdGravatar ethannicholas2016-02-11
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1692683002 Review URL: https://codereview.chromium.org/1692683002
* Add GrShaderFlags enumGravatar cdalton2016-02-11
| | | | | | | | | Replaces GrGLSLUniformHandler::ShaderVisibility with GrShaderFlags. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684063006 Review URL: https://codereview.chromium.org/1684063006
* new version of SkHalfToFloat_01Gravatar mtklein2016-02-11
| | | | | | | | | This is a little faster than the previous version, and much better explained. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1688233002 Review URL: https://codereview.chromium.org/1688233002
* start to chip away at friending of GrAtlasTextBatch/GrAtlasTextBlobGravatar joshualitt2016-02-11
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684253002 Review URL: https://codereview.chromium.org/1684253002
* Revert of Make copySurface work for texture dsts, return a bool, & add unit ↵Gravatar kjlubick2016-02-11
| | | | | | | | | | | | | | | | | | | | | | | test. (patchset #6 id:100001 of https://codereview.chromium.org/1684313002/ ) Reason for revert: Copy surface tests are not happy for Windows, Android and probably others: https://uberchromegw.corp.google.com/i/client.skia.android/builders/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release/builds/4161 https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-ShuttleA-GPU-GTX960-x86_64-Release/builds/3694 Original issue's description: > Make copySurface work for texture dsts, return a bool, & add unit test. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684313002 > > Committed: https://skia.googlesource.com/skia/+/7ea5e28065e5eb797e95f5d81c1a65cf3209d741 TBR=robertphillips@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1690053002
* Remove GrContext* from GrTextContextGravatar joshualitt2016-02-11
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686143003 Review URL: https://codereview.chromium.org/1686143003
* Make copySurface work for texture dsts, return a bool, & add unit test.Gravatar bsalomon2016-02-11
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684313002 Review URL: https://codereview.chromium.org/1684313002
* enable ThermalManager on AndroidGravatar joshualitt2016-02-11
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1684653002 Review URL: https://codereview.chromium.org/1684653002
* Support more color types for ICOsGravatar msarett2016-02-11
| | | | | | | BUG=skia:4620 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1694513002 Review URL: https://codereview.chromium.org/1694513002
* Avoid initializing memory twice on incomplete RLE bmpsGravatar msarett2016-02-11
| | | | | | | BUG=skia:4582 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1689983002 Review URL: https://codereview.chromium.org/1689983002
* integrated SkDebugCanvas JSON support with UrlDataManagerGravatar ethannicholas2016-02-11
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686143004 Review URL: https://codereview.chromium.org/1686143004
* Test SkAndroidCodec for more typesGravatar scroggo2016-02-11
| | | | | | | | | | | | | | Now that SkAndroidCodec supports all types, stop selectively running its tests for the types supported by BRD. For the tests that actually require BRD support (i.e. partial scanlines), change the method name from supports_scaled_codec to supports_partial_scanlines to be more accurate today. Use the name SkAndroidCodec instead of SkScaledCodec. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691823002 Review URL: https://codereview.chromium.org/1691823002
* Further reduce the number of primitives in the donut tests. Avoids crashes ↵Gravatar brianosman2016-02-11
| | | | | | | | | on iOS. BUG=skia:4937 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691813002 Review URL: https://codereview.chromium.org/1691813002
* Clarify bmp comment about when we support the alpha maskGravatar msarett2016-02-11
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1689183002 Review URL: https://codereview.chromium.org/1689183002
* Fix scanline decoding of rare RLE bmpsGravatar msarett2016-02-11
| | | | | | | | | | | | | | | This also exposed a bug in rewinding RLE bmps, which I have also fixed in this CL. This should fix testcase7.bmp on Gold. The image that I am adding to resources is in the public domain. BUG=skia:4730 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1689953002 Review URL: https://codereview.chromium.org/1689953002
* SkNx refactoringGravatar mtklein2016-02-11
| | | | | | | | | | | | | | | | | | | | - add back Sk4i typedef - define SSE casts in terms of Sk4i * uint8 <-> float becomes uint8 <-> int <-> float * uint16 <-> float becomes uint16 <-> int <-> float This has the nice side effect of specializing uint8 <-> int and uint16 <-> int, which are useful in their own right. There are many cast specializations now, some of which call each other. I have tried to arrange them in some sort of sensible order, subject to the constraint that those called must precede those who call. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1690633003 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1690633003
* Remove SK_SUPPORT_LEGACY_BITMAP_FILTER guardGravatar fmalita2016-02-11
| | | | | | | TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1695443002 Review URL: https://codereview.chromium.org/1695443002
* SkDocument: remove use of SkTArray (part 1/3).Gravatar halcanary2016-02-11
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1689683002 Review URL: https://codereview.chromium.org/1689683002
* wire up new json code in skiaserveGravatar joshualitt2016-02-11
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691773002 Review URL: https://codereview.chromium.org/1691773002
* fix for gpu valgrind botGravatar joshualitt2016-02-11
| | | | | | | | TBR=egdaniel@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1689823004 Review URL: https://codereview.chromium.org/1689823004
* Pass a GrContext pointer in GrDrawContext constructorGravatar joshualitt2016-02-11
| | | | | | | | TBR=bsalomon@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691503002 Review URL: https://codereview.chromium.org/1691503002
* Add AndroidCodecBench to time scaled decodesGravatar msarett2016-02-11
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1685693003 Review URL: https://codereview.chromium.org/1685693003
* SkHalfToFloat_01 / SkFloatToHalf_01Gravatar mtklein2016-02-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are basically inlined, 4-at-a-time versions of our existing functions, but cut down to avoid any work that's only necessary outside [0,1]. Both f16 and f32 denorms should work fine modulo the usual ARMv7 NEON denorm==zero caveat. In exchange for a little speed, f32->f16 does not round properly. Instead it truncates, so it's never off by more than 1 bit. Support for finite values >1 or <0 is straightforward to add back. >1 might already work as-is. Getting close to _u16 performance: micros bench 261.13 xferu64_bw_1_opaque_u16 1833.51 xferu64_bw_1_alpha_u16 2762.32 ? xferu64_aa_1_opaque_u16 3334.29 xferu64_aa_1_alpha_u16 249.78 xferu64_bw_1_opaque_f16 3383.18 xferu64_bw_1_alpha_f16 4214.72 xferu64_aa_1_opaque_f16 4701.19 xferu64_aa_1_alpha_f16 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1685133005 Committed: https://skia.googlesource.com/skia/+/9ea11a4235b3e3521cc8bf914a27c2d0dc062db9 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review URL: https://codereview.chromium.org/1685133005
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-30 20:40:38 +0000