aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Forgot to add resources with new testGravatar msarett2015-08-19
| | | | | | | | | | I created these images using mandrill_16.png (already in resources) and an online tool. https://codereview.chromium.org/1287863004/ BUG=skia: Review URL: https://codereview.chromium.org/1297723004
* Revert of Have DM manually encode its .png outputs. (patchset #2 id:20001 of ↵Gravatar mtklein2015-08-19
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1304443002/ ) Reason for revert: derek + Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Debug Original issue's description: > Have DM manually encode its .png outputs. > > This eliminates some variability on various axes: different PNG encoders, different libpng versions, different formats (RGB, indexed), different unpremultiplication, different sRGB tags. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3cc0dfffb70c0bd08ed8899efcd2e98da86a6ec7 TBR=stephana@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1297383002
* Revert of SkCanvas::onDrawPicture() quick-reject (patchset #3 id:40001 of ↵Gravatar herb2015-08-19
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1264133003/ ) Reason for revert: Seems to be breaking some blink tests. https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/75812/layout-test-results/results.html Original issue's description: > SkCanvas::onDrawPicture() quick-reject > > R=reed@google.com,mtklein@google.com > > Committed: https://skia.googlesource.com/skia/+/48ed62b29d45e42b971aac8858da06781c93e6d7 > > Committed: https://skia.googlesource.com/skia/+/d3d07245e29504dbffa0083e84ace5bab85853d4 TBR=mtklein@google.com,reed@google.com,mtklein@chromium.org,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1301973002
* Have DM manually encode its .png outputs.Gravatar mtklein2015-08-19
| | | | | | | | This eliminates some variability on various axes: different PNG encoders, different libpng versions, different formats (RGB, indexed), different unpremultiplication, different sRGB tags. BUG=skia: Review URL: https://codereview.chromium.org/1304443002
* SkStream Testing: fix bug in new unit test.Gravatar halcanary2015-08-19
| | | | Review URL: https://codereview.chromium.org/1297143004
* add missing overrideGravatar mtklein2015-08-19
| | | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1292073003
* fill rect batch refactor into separate batchesGravatar joshualitt2015-08-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1295773003
* Init class ID in GrStencilPathBatchGravatar Brian Salomon2015-08-19
| | | | | | TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/1300093007
* Fix stack overuse errorGravatar halcanary2015-08-19
| | | | Review URL: https://codereview.chromium.org/1283193008
* Fix VS 2015 buildGravatar bsalomon2015-08-19
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1297283003
* SkCanvas::onDrawPicture() quick-rejectGravatar fmalita2015-08-19
| | | | | | | | R=reed@google.com,mtklein@google.com Committed: https://skia.googlesource.com/skia/+/48ed62b29d45e42b971aac8858da06781c93e6d7 Review URL: https://codereview.chromium.org/1264133003
* widen gm to show entire image, add place-holder for no contextGravatar reed2015-08-19
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1294113003
* SkPDF/Deflate: clean up old SkFlate codeGravatar halcanary2015-08-18
| | | | | | | | Factor out some of https://crrev.com/1227913008 BUG=skia:3030 Review URL: https://codereview.chromium.org/1298243002
* Path stenciling in GrBatchGravatar bsalomon2015-08-18
| | | | Review URL: https://codereview.chromium.org/1293973003
* Test scaling for small imagesGravatar msarett2015-08-18
| | | | | | | | | | We don't want to test small images on Gold because they are not interested to look at. Instead, I wrote a unit test to verify that scaling small images does not cause crashes. BUG=skia: Review URL: https://codereview.chromium.org/1287863004
* Try enabling all nanobenches on Nexus7Gravatar egdaniel2015-08-18
| | | | | | BUG=skia:2774 Review URL: https://codereview.chromium.org/1290223005
* handle no shader from image in drawAtlasGravatar reed2015-08-18
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1298233003
* Remove Cmd in GrTargetCommands that is no longer needed with GrCopySurfaceBatchGravatar bsalomon2015-08-18
| | | | | | TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/1292623004
* Try again to put SkXfermode_opts in SK_OPTS_NSGravatar mtklein2015-08-18
| | | | | | | | Remember failed attempt https://codereview.chromium.org/1286093004/ ? I think this one is simpler and safer and even technically legal C++. BUG=skia:4117 Review URL: https://codereview.chromium.org/1296183004
* Add skeleton json support to visualbenchGravatar joshualitt2015-08-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1298213002
* GrCopySurfaceBatchGravatar bsalomon2015-08-18
| | | | Review URL: https://codereview.chromium.org/1289673004
* added emitChild() to GrGLFragmentProcessor; removed ↵Gravatar wangyix2015-08-18
| | | | | | | | AutoFragmentChildProcAdvance class BUG=skia:4182 Review URL: https://codereview.chromium.org/1301523003
* Add support for non-mappable vert buffers to tessellating path renderer.Gravatar senorblanco2015-08-18
| | | | | | | | Use malloc-ed memory and the updateData() call instead. BUG=skia:4215 Review URL: https://codereview.chromium.org/1288683004
* Revert of Update skia to test with libpng to 1.6.10 (patchset #3 id:60001 of ↵Gravatar msarett2015-08-18
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1301523005/ ) Reason for revert: DM is failing on gm tests on Android bots. Cause is not yet clear. Original issue's description: > Update skia to test with libpng to 1.6.10 > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/f272bb03df9b86e7ea2cf23fb4d5cc56624e0118 TBR=djsollen@google.com,scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1298223002
* When getGLInstance is called on a frag proc, the resulting ↵Gravatar wangyix2015-08-18
| | | | | | | | GrGLFragmentProcessor will be the root of a tree of GrGLFragmentProcessors that mirrors the GrFragmentProcessor's tree. This allows setData() to be called recursively (removing the responsibility from compose shader) and allows gl instances direct access to their children gl instances so they can emit their code. BUG=skia:4182 Review URL: https://codereview.chromium.org/1287023009
* Add subsets to SkImageGenerator and SkImageCacheratorGravatar reed2015-08-18
| | | | | | | | ... to support subsets in SkImage! BUG=skia: Review URL: https://codereview.chromium.org/1301633002
* Update skia to test with libpng to 1.6.10Gravatar msarett2015-08-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1301523005
* Add internal links section to skia.orgGravatar hcm2015-08-18
| | | | | | | | BUG=skia:4142 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1284043004 Review URL: https://codereview.chromium.org/1284043004
* ClearStencilClip in GrBatchGravatar bsalomon2015-08-18
| | | | Review URL: https://codereview.chromium.org/1288963004
* Move GrTBatchTesselator to its own fileGravatar joshualitt2015-08-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1298983002
* Update SkOpts namespaces.Gravatar mtklein2015-08-18
| | | | | | | | portable -> default, and everyone gets an sk_ prefix. BUG=skia:4117 Review URL: https://codereview.chromium.org/1299013003
* Add missing overrides to clear and discard batch dumpInfo()Gravatar Brian Salomon2015-08-18
| | | | | | TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/1303533003
* Patches on top of Radu's latest.Gravatar mtklein2015-08-18
| | | | | | | | patch from issue 1273033005 at patchset 120001 (http://crrev.com/1273033005#ps120001) BUG=skia: Review URL: https://codereview.chromium.org/1288323004
* Use portable code for family names with DirectWrite.Gravatar bungeman2015-08-18
| | | | | | | | | | | | IDWriteFamily::GetFamilyNames appears to be 'helpful' and removes parts of family names that look like style names. Since the iterator is supposed to return the actual names and not just the name the platform thinks the name is (as getFamilyName does), try returning the raw names when possible. BUG=skia:4217 Review URL: https://codereview.chromium.org/1302573002
* Put clear and discard into GrBatch.Gravatar bsalomon2015-08-18
| | | | Review URL: https://codereview.chromium.org/1293563003
* Update BUILD.public a bit.Gravatar mtklein2015-08-18
| | | | | | | | | | | | | - SSE2 files are unfortunately now mixed-case, _SSE2 or _sse2. - Adds lists for SSSE3 and SSE4 files. - Remove SkDocument_PDF_None.cpp - Remove a few more references to animator. - Exclude private headers from HDRS. - Formatting and notes. BUG=skia: Review URL: https://codereview.chromium.org/1298003007
* Clean up BUILD_simulator.pyGravatar halcanary2015-08-18
| | | | Review URL: https://codereview.chromium.org/1298813002
* Deduplicate typefaces across sub-picturesGravatar mtklein2015-08-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | Old flow to serialize a picture: 1) serialize picture ops 2) serialize all sub pictures recursively 3) flatten the rest of this picture into a buffer, deduping flattenable factories and typefaces as we go 4) serialize the factories and typefaces 5) serialize the bytes from 3) This allows the data in step 5) to refer to the deduplicated factories and typefaces from step 4). But, each sub picture in step 2) is completely siloed, so they can't dedup with the parent picture or each other. New flow: 1) serialize picture ops 2) flatten the rest of this picture into a buffer, deduping flattenable factories and typefaces as we go 3) dummy-serialize sub pictures into /dev/null, with the effect of adding any new typefaces to our dedup set 4) serialize the factories and typefaces 5) serialize the bytes from 2) 6) serialize all sub pictures recursively, with perfect deduplication because of step 3). Now all typefaces in the top-level picture and all sub pictures recursively should end up deduplicated in the top-level typeface set. Decoding changes are similar: we just thread through the top-level typefaces to the sub pictures. What's convenient / surprising is that this new code correctly reads old pictures if we just have each picture prefer its local typeface set over the top-level one: old pictures always just use their own typefaces, and new pictures always use the top-level ones. BUG=skia:4092 Review URL: https://codereview.chromium.org/1233953004
* Prefer native scaling to samplingGravatar msarett2015-08-18
| | | | | | | | | | | | | | | | | | | | | In the cases we have come across so far, native scaling has better performance and correctness than sampling. If native scaling is supported we want to use it. Jpegs native scale rounds up. Ex: An 11x11 image with sampleSize=8 scales to 2x2. SkScaledCodec rounds down. Ex: An 11x11 image with sampleSize=8 scales to 1x1. Before the CL, we would choose to use SkScaledCodec because it scales closer to the "ideal" scale. I think we want to go with the native option as long as its within 1 of the ideal value. BUG=skia: Review URL: https://codereview.chromium.org/1284243004
* Regenerate LCD text blobs if GrPaint's color changes, not SkPaint.Gravatar jvanverth2015-08-18
| | | | | | | | | The GrPaint's color takes into account shaders and color filters, so is a more accurate picture of the color state. BUG=chromium:511787 Review URL: https://codereview.chromium.org/1297053004
* Made isEqual in GrFragmentProcessor recursiveGravatar wangyix2015-08-18
| | | | | | | | | | Added comment about how computeInvariantOutput() is non-recursive in GrFragmentProcessor Made isEqual() recursive in GrFragmentProcessor BUG=skia:4182 Review URL: https://codereview.chromium.org/1287343005
* GrAAFillRectBatch holds onto GrPipelineOptimizationsGravatar joshualitt2015-08-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1301603004
* Added class AutoFragmentChildProcAdvance to be constructed before a child ↵Gravatar wangyix2015-08-18
| | | | | | | | | | | | | | | | | | emitCode and destructed after Fixed wrong indent Changed auto child advance back to backwards linear search for getting subset of coords and samplers array of a child Used offset from parent instead of backwards linear search to find a child proc's coords and transforms in Auto...Advance append mangleString to variable name in nameVariable() BUILDS! Added AutoFragmentChildProcAdvance class; fixed a few errors from previous commits BUG=skia:4182 Review URL: https://codereview.chromium.org/1286293002
* fix pathops fuzz failuresGravatar caryclark2015-08-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a curve has the identical start and control points, the initial or final tangent can't be trivally determined. The perpendicular to the tangent is used to measure coincidence. Add logic for cubics, quadratics, and conics, to use the secondary control points or the end points if the initial control point alone can't determine the tangent. Add debugging (currently untriggered by exhaustive testing) to detect zero-length tangents which are not at the curve endpoints. Increase the number of temporary intersecions gathered from 10 to 12 but reduce the max passed in by cubic intersection from 27 to 12. Also, add checks if the max passed exceeds the storage allocated. When cleaning up parallel lines, choose the intersection which is on the end of both segments over the intersection which is on the end of a single segment. TBR=reed@google.com BUG=425140,516266 Review URL: https://codereview.chromium.org/1288863004
* Reland of Fix a few bugs in the google3 sync scripts. (patchset #1 id:1 of ↵Gravatar benjaminwagner2015-08-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1295213002/ ) Reason for revert: Retry. Original issue's description: > Revert of Fix a few bugs in the google3 sync scripts. (patchset #1 id:1 of https://codereview.chromium.org/1291343006/ ) > > Reason for revert: > MacMini buildbots were unable to apply the patch. > fatal: Could not parse object '18af0a0080cc2b2b3464292d35a0886cdade551f'. > http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1580 > http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Debug/builds/1474 > http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1566 > http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Release/builds/1480 > http://build.chromium.org/p/client.skia/builders/Perf-Mac10.9-Clang-MacMini6.2-CPU-AVX-x86_64-Release/builds/1456 > http://build.chromium.org/p/client.skia/builders/Test-Mac10.9-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug/builds/1364 > > > Original issue's description: > > Fix a few bugs in the google3 sync scripts. > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/18af0a0080cc2b2b3464292d35a0886cdade551f > > TBR=mtklein@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e349d6b92574c1b0acdb4ba1ed8ff905ea830131 TBR=mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1284093003
* Privatize GrBatch subclass overridesGravatar bsalomon2015-08-18
| | | | Review URL: https://codereview.chromium.org/1301663002
* Remove a couple zombie pathops files.Gravatar mtklein2015-08-18
| | | | | | | | These files don't compile and are not referenced by any GYP file. BUG=skia: Review URL: https://codereview.chromium.org/1299773002
* Remove SkOpts_sse2.cpp.Gravatar mtklein2015-08-18
| | | | | | | | | | | | | | | | | | It's sort of pointless: all our clients that will have SSE2 at runtime have it unconditionally at compile time, so the functions in namespace portable will pick up the SSE2 code. The procs in SkOpts_sse2.o were just duplicate code. A couple of the procs we had in _sse2.cpp can benefit slightly when compiled with SSSE3. I've moved those to _ssse3.cpp. This should lead to small speedups on platforms like Linux and Windows that have a baseline of SSE2. Similarly, I've removed the call to Init_neon() when NEON is available globally... it's a no-op. Renaming namespace portable to something clearer is TBD. BUG=skia:4117 Review URL: https://codereview.chromium.org/1294213002
* Revert[8] "move some public headers into private"Gravatar reed2015-08-17
| | | | | | | | | This reverts commit fb28cd2b13d76c324570341e1155aaadc1b532b6. BUG=skia: TBR= Review URL: https://codereview.chromium.org/1298833002
* Move normal map creation methods to sk_toolsGravatar robertphillips2015-08-17
| | | | | | Split off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call) Review URL: https://codereview.chromium.org/1298763002